6e44f96a77
4 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Ivan Akulov
|
424d2f6965
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
|
||
|
ChandanBalajiBP
|
b72dea33f3
|
feat: Error handling phase 1 (#20629)
## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com> |
||
|
Arsalan Yaldram
|
63a25ee547
|
fix: added label tooltips, updated validation messages. | ||
|
Arsalan Yaldram
|
46b3627bac
|
feat: implemented slider widgets (#15712)
* feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method. |
