Commit Graph

6747 Commits

Author SHA1 Message Date
f0c1s
74200da71c
fix: polish git-sync feature (#11740)
Faster tooltips for bottom bar quick actions
Branch popover has a backdrop like the modals do.
More than 9 changes are reported as it is
Recent commit shows "less than a minute" ago
BETA tag removed from popover
Faster tooltips for sync branch button in popover
Placeholder for commit message
Relevant placeholder for git remote input
Padding for content in modal is decreased
Notification banner is aligned with SSH key box
2022-03-10 11:08:50 +05:30
Bhavin K
71d6da19bc
feat: added isJSConvertible property in IconButton Widget (#11625)
* feat: updated  isJSConvertible property

* fix: default icon value added, validation updated
2022-03-10 09:41:02 +05:30
arunvjn
52944dcea7
fix: Prevent page reload when launching an application from the applications dashboard for faster load time (#11604) 2022-03-10 07:52:07 +05:30
Arsalan Yaldram
366276cdbc
chore: Keyboard accessibility added to canvas selector buttons. (#11420)
* chore: Keyboard accessibility added to canvas selector buttons.

* chore: Removed default tab navigation for buttons.

* chore: Fixed Tab Navigation.

* chore: Fixed edge cases, handled selectedIndex.

* chore: use OnBlur instead of Tab key press.

* chore: added jest test cases for Arrow navigation.

* chore: review changes for test cases.
2022-03-09 18:40:21 +00:00
Abhijeet
bc929f2f67
chore: Don't take client subscription into account for discard git changes (#11666) 2022-03-09 16:58:54 +05:30
Nidhi
aaf12c513d
fix: Adds user set on load prop from actions to exported JSON file (#11718) 2022-03-09 16:57:45 +05:30
arunvjn
02980068ad
Changing shortcut create query/JS shortcut to cmd + plus (#11728) 2022-03-09 11:19:19 +00:00
Aman Agarwal
9189b3d4af
fix: Updated conditions for dropdown control to take in false also as value (#11712) 2022-03-09 16:37:36 +05:30
Paul Li
b4c33fe050
fix: Icon alignment changes automatically every time the icon is changed in Menu button widget (#11570)
* fix: Icon Alignment changes automatically every time when icon is changed in Menu Widget

-- Add iconAlign property as a dependency for iconName property

* fix: Icon Alignment changes automatically every time when icon is changed in Menu Widget

-- Add a Cypress test case to ensure the fix

* fix: Icon alignment changes automatically every time the icon is changed in Menu button widget

-- Fix on a broken Cypress test, setting force to true
2022-03-09 02:29:50 -08:00
Aishwarya-U-R
fb0dc53a83
test: Script fixes for Flaky tests (#11653)
* Table_GeneralProp spec fix

* Flakes fixed

* Increased deployed page ele wait timeout

* readTabledataPublish() fix

* readTabledataPublish() updated

* Table specs flaky fix

* Table & Mongo Flaky fixes

* Mongo & Table spec flake fix

* Mongo flaky fix

* Mongo fix

* Table_Generalprop flaky fix

* Greencolor locator update

* expandCollapseEntity() method improved

* Table_generalProp flaky fix

* Datepick2, AddWidget flaky fix

* FLakyfix

* WidgetSelection_spec flaky fix

* Flaky fixes

* Adding GitSync to ignore files

* Removing GitSync from ignore files

* Added wait aft PublishApp
2022-03-09 12:05:56 +05:30
Arsalan Yaldram
e411f093cc
Merge pull request #11623 from appsmithorg/fix/table-filter-pane-overflow
fix: Added root element as the ParentBoundary for TableFilterPane.
2022-03-09 11:22:19 +05:30
Favour Ohanekwu
cd3c8c0c96
fix audio widget autocompletion (#11667) 2022-03-08 16:30:59 +01:00
akash-codemonk
a6946fbcf0
fix: end guided tour on exiting editor (#11084) 2022-03-08 20:25:20 +05:30
Aman Agarwal
c891af5b21
fix: curl import ui fixes wrt to design system (#11648) 2022-03-08 19:49:38 +05:30
Aman Agarwal
691cfb767c
fix: Rest API UI issues (Empty DS headers, UI for Param tab, Save DS button, Placeholder) (#11700)
* fix: filtered empty key value pairs in headers, ui for param tab

* fix: disabled button to save ds in auth tab if no url

* fix: changed placeholder text
2022-03-08 19:49:02 +05:30
Anand Srinivasan
ae733ca2f0
fix: unrelated widgets in loading state (#11370)
* log loading actions

* isLoading: check entity properties

* rename variables

* unit tests

* add descriptions

* clean test data

* include JS_Object self-dependencies

* add comment

* fix basic tests

* fix unit tests

* updated unit tests

* add test case

* update comment

* console - disable lint errors

* code clean up

* change folder

* find loading entites as a method

* updated unit tests

* check if entity exists in dataTree

* update test cases

* getEntityDependants - add specific path test case
2022-03-08 13:56:03 +00:00
arunvjn
dbec047959
Update appsmith docs version to 1.3 (#11692) 2022-03-08 13:55:30 +00:00
Ayangade Adeoluwa
1f7900a7db
Fixes confirmation modal flickering bug (#11618) 2022-03-08 13:55:13 +00:00
arunvjn
ff339f0295
Added analytics event to track datasource dropdown usage in query editors (#11693) 2022-03-08 13:54:48 +00:00
Bhavin K
c9760edb87
Revert "fix: handle main container height (#11461)" (#11674)
This reverts commit c6f5dcb673.
2022-03-08 12:54:40 +05:30
Arsalan
db27afeed6 Merge branch 'release' into fix/remove-datasources-action-selector 2022-03-08 11:42:35 +05:30
Tolulope Adetula
b17cd2e3bd
fix: table widget value displacement (#11650) 2022-03-07 22:06:32 -08:00
Shrikant Sharat Kandula
ae5f9569c9
Fix startup failing if signup disabled is empty (#11686)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-03-07 17:38:18 +05:30
Nidhi
966564d2bc
fix: Modified root json for SMTP to comply with UQI aggregation rules (#11676) 2022-03-07 14:56:54 +05:30
Shrikant Sharat Kandula
1233f7f7ee
chore: Change watchtower to latest from latest-dev (#11669)
This is because watchtower:latest-dev doesn't run on ARM architectures.
2022-03-07 13:58:20 +05:30
Ankita Kinger
af5483c7c4
fix: Style values of the page and default value for telemetry (#11640) 2022-03-07 11:36:34 +05:30
Nayan
be5b12b7bb
[Fix] Added permission in security config for themes (#11527)
Theme API path was not added added to security config path. As a result, themes in published mode in public apps were not loaded. This PR fixes that issue.
2022-03-07 01:43:26 +06:00
Daniel
7aa6a2015e
Merge pull request #11493 from appsmithorg/fix/reword-datasource-message
fix: reword datasource message
2022-03-06 18:48:03 +01:00
Parthvi12
1eb1a9ecb2
test: adding MySQL noise test (#11469)
* adding MySQL noise test

* fixed git tests

* updating git tests
2022-03-06 23:14:17 +05:30
f0c1s
c346af60c3
chore: update icons in org menu (#11548)
* chore: update icons in org menu
* chore: update user-heart-line and update org menu
* chore: use member instead of members for icon name
2022-03-05 21:20:33 +08:00
f0c1s
15cd2857d3
fix: remove EDIT button (#11356) 2022-03-05 08:51:25 +00:00
Anagh Hegde
dde1eb1735
Add check for default branch before deleting branch (#11631) 2022-03-05 08:30:29 +00:00
Ayangade Adeoluwa
e576ac08db
Default action config values not being set (#11632) 2022-03-05 00:45:48 +00:00
Aishwarya UR
dc07329318 Merge branch 'release' into fix/table-filter-pane-overflow 2022-03-05 01:14:09 +05:30
Aishwarya-U-R
bd69eb9c3a
test: Automated tests for Bug #10784 + Failure fixes (#11586)
* Scripting Bug # 10784

* Bug 10784 - added script

* Uncommenting - JSObjToInput spec

* Uncommenting - JSObjtoListWidget spec

* SelectEntityByName reverted

* Migration spec locators fix

* Table_GeneralProp spec updated

* Read Table Row/Column locator updated

* Calling WaitAutoSave in JSObj creation

* 19px to 28px to match CI run

* CreateJSObject() - adding back wait time

* Reverting 28px to 19px

* Commenting table specs until CI fixed

* Commenting table spec 9th case

* UNcommenting

* Commenting Table_GeneralProp failure case
2022-03-05 01:01:35 +05:30
Apeksha Bhosale
f610033240
removed default isAsync false from new js action (#11427)
Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2022-03-04 15:51:33 +05:30
Shrikant Sharat Kandula
cde48bf9a9
Don't provide extra information on forgot password (#11596) 2022-03-04 15:16:58 +05:30
Arsalan
93e2f5eb62 fix: Added root element as the ParentBoundary for TableFilterPane. 2022-03-04 14:53:29 +05:30
Vicky Bansal
43441bfce2
feat: add tooltip to column header text which overflows (#10666)
* feature: add tooltip to column header text which overflows (#10495)

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix: test issues

Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-03-04 00:56:16 -08:00
Paul Li
26d06c45a4
fix: Aspect ratio of video changes when Camera widget is longer in width than the aspect ratio (#11453) 2022-03-04 12:21:10 +05:30
Aswath K
ef89f3fee4
feat: Make icon selector keyboard accessible (#10460)
* feat: virtualize icon rendering makes icon selector smoother

* make icon selector keyboard accessible
2022-03-04 12:15:50 +05:30
Nayan
caab37de26
feat: Add new API to combine get application details and get pages API (#11448)
Merges the get application details and get page list API into one. This API takes either applicationId or pageId and returns the list of pages of that application.
2022-03-04 12:32:48 +06:00
Ankita Kinger
1688757bc6
fix: Signup text update & code optimisation (#11606)
* text change for signup admin settings & code optimized

* minor change
2022-03-04 11:56:12 +05:30
Apeksha Bhosale
e0e0fc8346
added event to stop loading (#11597) 2022-03-04 11:06:13 +05:30
Abhijeet
13d6450616
chore: Soft delete resources across Appsmith board for delete operation (#11555)
* Soft delete resources

* Add TC and migrations
2022-03-03 23:06:34 +05:30
devnamrits
406fa0cc3d
fix: firestore queries asterisk (#11599)
* fix: remove asterisk from non-mandatory fields in firestore query

* making one false

* fix: remove asterisk from non-mandatory fields in firestore query

* fix: remove asterisk from non-mandatory fields in firestore query

Co-authored-by: Hritik Kumar <devnamrits@Hritiks-Mac.local>
2022-03-03 22:08:44 +05:30
Ayush Pahwa
5c187d61ef
fix: Drop down multiselect usage fixes for query forms (#11465)
* Update: Type for initialValues

- Added string[] to the initialValues type to allow dropdowns to have multiple values too

* Remove: Old projection selector file

- Removed projection selector file
- The new usage will be the old drop down file with new options

* Update: Dropdown file

- Added options to select and deselect the multiple drop down options
- Added functions to handle selection and deselection
- Added option in final render method to allow searching
- Handled default values for multi select and single select drop downs

* Update FormControlRegistry.tsx

- Updated projection component to point to drop down component with extra options

* Update: Fixed logic for dropdown select

- Fixed the if condition blocks to catch the case when the multiselect output is not an array
2022-03-03 16:42:02 +01:00
Ayangade Adeoluwa
b25441f576
Fix apiContentType bug (#11600) 2022-03-03 16:32:59 +01:00
Nidhi
8b1638aba6
chore: Modified plugin config aggregation logic (#11561)
* fix: Modified plugin config aggregation logic

* Modified logs a bit

* Reverted incorrect path from another branch
2022-03-03 19:26:55 +05:30
Ankita Kinger
a905b33081
fix: Remove reset password button if form login is disabled (#11591)
* increased restart server timeout & showing reset pwd only if form login is enabled

* Updated callout for disconnect button

* added space
2022-03-03 18:49:10 +05:30
Yash Vibhandik
2f7d862ea0
fix: #11301 filter pane text css updated (#11410) 2022-03-03 17:33:26 +05:30
Segun Daniel Oluwadare
1c9cb183db fix: reword datascource message 2022-03-03 12:00:21 +01:00
Anand Srinivasan
d89e12e3a5
fix: warning message - if child property doesn't exist in data tree (#10351)
* makeParentsDependOnChild - return if child doesn't exist in allKeys

* add unit tests

* add nested object to unit test

* fix unit tests

* fix unit tests

* add warning messages

* add comments for mock
2022-03-03 10:59:52 +00:00
akash-codemonk
65aee7fd14
feat: Application templates (#10964) 2022-03-03 16:26:53 +05:30
NandanAnantharamu
9b075e502b
test: bugAutomation4136 (#11245)
* bugAutomation4136

* Added tests for bug 5134 / 4136

* updated test data

* Bug7258 automated
2022-03-03 16:24:44 +05:30
Apeksha Bhosale
eb34255b18
fix: removing unnecessary paths to evaluate (#11341)
* removing unnecessary paths to evaluate

* created regex and small refactor
2022-03-03 13:12:23 +05:30
Nidhi
d57207d224
fix: Changed test class reference to CE (#11578) 2022-03-03 12:00:55 +05:30
Abhijeet
cdf06cb773
feat: API to discard changes for git connected applications (#11362)
* Add discard changes functionality for git

* Recover deleted resources from the file system and refactor

* Remove untracked files, remove unwanted actions

* Testcases added for discard changes

* Added comments
2022-03-02 19:54:09 +00:00
balajisoundar
fe72182064
fix: Number type input should honour required property when value is empty string (#11442) 2022-03-03 00:38:22 +05:30
Ankita Kinger
13fe125a0c
feat: Add disconnect button on auth config pages and form login callout banner (#11389)
* added form login callout banner

* form login config page changes

* form login config page changes

* added redirecturl and uneditable field components

* added disconnect button on auth pages

* Added env variables for form login auth page

* added disconnect button on auth pages

* updated docs link for dform login callout doc

* added condition for disconnect button

* added ce changes done on ee

* updated css

* suggested changes in PR review

* suggested changes in PR review

* suggested changes in PR review

* reverted gitignore files changes

* reverted gitignore files changes

* updated logic for saving admin settings

* removed unused imports

* added changes for taginput field

* removed console

* removed warning

* removed unwanted changes
2022-03-02 23:48:50 +05:30
Leo Thomas
18104b9291
fix: 9824 Google Sheet to filter empty condition ver.2 (#11435)
* fix: 9824 Google Sheet to filter empty condition ver.2

* Code review comments updated

* Updates as per review comments - Ver 3

* Resolved errors found during testing

* Code review comments fix

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-03-02 22:34:34 +05:30
Mojtaba
29be75e0e9
feat: add smart substitution handling for known MongoDB types (#11135)
* shelf: start working on substitution for `ISODate`

* a draft for Sumit to check what I did wrong in my tests

* test: tests are working

* test: cleanup

* refactor: add replacementDataType parameter to DataTypeStringUtils.jsonSmartReplacementPlaceholderWithValue

* fix: remove quotes for Mongo Types work in single form, arrays and json.

* add handling for more use cases
add/update more TCs

* add comments

* add more comments

* add space (cosmetic change)

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-03-02 22:33:50 +05:30
Aishwarya-U-R
ef20c1e341
test: Automated tests for Promises & related bugs in Typescript + Flaky fixes (#10378)
* Flaky fixes

* S3 CRUD intercept fix

* S3 CRUD script change revert

* S3 revert!

* .its(store) not present fix

* TS failure fixes

* ChartDataopoint js removed

* JSObject ts flaky fix

* Bugs 9789, 10150 scripted

* Bug 10284 & 9782 scripted

* Updated dsl file names

* Table_Widget case #7 flaky fix

* Bug 10150 scripting improved

* DocumentViewer spec flaky fix

* Input widget locator corrected

* MemberRoles cases script started in TS

* UpdateUserRoleInOrg() fix

* Skip JSObject_To_ListWidgetSpec.ts until #10284

* Add validation

* JSObject_To_ListWidgetSpec.ts timeout increase

* Skipping tests until bug 10284 is fixed

* Increased wait time

* UpdateUserRoleInOrg() updated

* MemberRoles_Spec.ts fixed

* JSObjToInput - updated

* Postgres flaky fix

* Member Roles aka CreateOrg test flaky fix

* JSObToListWidget_Spec.ts - commenting until bugfix

* COmmenting JSobjToInput spec

* Commonlocators added back

* Entity explorer name fix

* Locators fix

* Locator corrected

* Cypress.json removed files from ignoring list

* S3 & Postgress failures fix

* Postgress failure locator fix

* S3 upload script skipping until bug fix

* Params Bug 10784 script started

* Fixing Promises Spec

* Increased wait time!

* MigrationSpec - Image column,Cardformat,Pagestyles

* S3, Postgres, Promise - failures fix

* Canvas renamed

* Bug 11415 - Added Validations

* InputWidgets_navigateTo - flaky fix

* MigrationSpec - import change

* Locators files - Json to Js conversion

* DS plugnis name change

* Locators - Json to JS conversion

* Locators - Json to JS updations

* Select_Widget_Value flaky fix

* Adding timeout for execute calls to finish

* Migration spec - diff syntax+List.js flaky fix

* List & MIgration flaky fix
2022-03-02 16:54:43 +00:00
Nidhi
5c994975d7
fix: Modified action execution endpoint (#9473) 2022-03-02 16:01:50 +00:00
Nidhi
eaf1701d7e
fix: Modified error from string to first error object in debugger log (#11511) 2022-03-02 15:52:35 +00:00
Bhavin K
12954d4e3d
fix: changed download flow for image control (#11391)
* fix: changed download flow for image control

* test: cypress test added

* fix cypress test case
2022-03-02 13:43:24 +00:00
rahulramesha
4c1a6674fa
fix: separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas (#11396)
* separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas
2022-03-02 13:42:41 +00:00
Anagh Hegde
1d90a9fed9
feat: Add API for delete branch for git connected application (#11432)
* Add API to delete git branches

* WIP

* Fix test failures

* Change the method from POST to DELETE

* Changes per review

* Changes per review
2022-03-02 13:42:16 +00:00
f0c1s
8666fc23ff
fix: use sentence casing (#11376) 2022-03-02 13:42:06 +00:00
Bhavin K
c6f5dcb673
fix: handle main container height (#11461) 2022-03-02 13:41:44 +00:00
Preet Sidhu
5bfb770d2c
Merge pull request #11503 from appsmithorg/fix-1146_page_editor_behaviour
fix: 11476 page editor behaviour upon visibility toggle
2022-03-02 13:46:34 +05:30
rashmi rai
82a56222d2
fix: added allowDeselection in ads/dropdown (#11495)
* added allowDeselection in ads/dropdown

* fix dropdown height multi-selection

* add tests

Co-authored-by: Aswath K <aswath@appsmith.com>
2022-03-02 13:15:43 +05:30
Preet
96b9cc6523 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-03-02 12:09:21 +05:30
Preet
e64bf8f60b Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-03-02 12:07:26 +05:30
Hetu Nandu
ac7a73f667
fix: table button multi-line execution (#11525) 2022-03-02 12:07:20 +05:30
Shrikant Sharat Kandula
22f24110e7
Fix extra space in email placehoder in signup page (#11436) 2022-03-02 11:54:44 +05:30
Nayan
3cfc3781f1
Handle NPE in home page API (#11481) 2022-03-02 11:54:24 +05:30
Preet
cbeeba64f2 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-02-28 23:10:50 +05:30
Ayangade Adeoluwa
51b43daa1b
fix: Fixes modal pop up bugs on page load (#11504)
* Fixes modal pop up bugs on page load

* send confirmBeforeExecute attribute with page execution order info

(cherry picked from commit 6d3cfdfbdb83b435e67797f3fb27024799d5d579)

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-02-28 23:07:21 +05:30
Preet
9831f9e334 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-02-28 19:57:31 +05:30
Tolulope Adetula
1ea734bc14
fix: revert #8121 (#11502) 2022-02-28 19:44:56 +05:30
Preet
bfad6f4af4 check for drag distance 2022-02-28 18:33:05 +05:30
Abhinav Jha
a70763d1c3
Add showdown types package as a dev dependency for the client (#11496) 2022-02-28 18:08:56 +05:30
Hetu Nandu
06bf4696b4
fix: Promises in Table buttons (#11239) 2022-02-28 15:05:43 +05:30
Bharat Patodi
59c0d94ade
chore: Replace require with import statements (#8121) 2022-02-28 14:53:19 +05:30
Aswath K
ad952bb9a9
feat: make outgoing entities keyboard accessible (#11446) 2022-02-28 14:33:09 +05:30
Ankita Kinger
821c0d2021
css changes for invite users and manage users tables (#11441) 2022-02-28 11:38:33 +05:30
Ayush Pahwa
813d5850b0
fix: Update api params for dynamic fetched values (#11463)
* <feat> Updated payload for formEvals

- Added datasource and plugin ID to the payload

* <feat> Added IDs to dispatch calls

- Added datasource and plugin IDs to the dispatch calls so they can be used for dynamic query fetch

* <feat> Added type in evaluation saga

- Added datasource ID and plugin ID in the expected type for the eval function
- Updated call type from GET to POST for the dynamic trigger URLs

* <feat> Made params compulsory for editor config

- Params are now compulsory for any config defined in editor JSON for the dynamic value fetching

* <feat> Updated API definition

- Update the definition for the axios function from GET to POST

* <feat> Added configProperty to payload

- Added configProperty to the payload to allow for distinction between different components making a call to the server

* <chroe> Added null check

- Added null check to function call for datasource and plugin IDs in API since they are not compulsory in the type

* <refactor> Remove unused imports
2022-02-27 03:32:36 +00:00
Ayush Pahwa
fe2d625f5e
fix: Updated drop down control memo usage (#11218)
* Stopped props drilling of eval state

* Connect drop down to redux state

* Added extra check to formcontrol memo function

* Reduced modification of section at top

* Stopped mutating the initial state

* Created selector to get dynamic fetched values

* <refactor> Added comments and refactors

- Added key to the ES fragment
- Cleaned drop down component from redundant code
- Added comments

* <refactor> Removed test files

- Removed testing JSON configs

* <fix> Added null check for form eval output

- Added check to prevent null evalOutput in forms

* <chore> Removed console error

- Removed console error which is causing the vercel builds to fail
2022-02-26 22:41:38 +05:30
NandanAnantharamu
a2240c7107
test: Added test for Table Switch binding (#11423)
* Added test for Table Switch binding

* Updated test
2022-02-26 16:21:39 +05:30
NandanAnantharamu
5d2c35606c
Bug10757 automation (#11149) 2022-02-26 10:59:58 +05:30
rashmi rai
705d275d12
fix: add binding paths for new UQI components (#11287) 2022-02-26 09:22:06 +05:30
Rishabh Rathod
7a484fc027
fix: meta changes (non-default) also update metaHOC state (#10734)
* Reset metaHOC state on widget reset

* Pass all meta values for metaHOC reset logic

* pass only metaReducer values in meta

* fix unit test

* Add test
2022-02-26 02:16:04 +05:30
Parthvi12
71acf31fef
test: commenting git sync tests until fixed (#11450)
* commenting git sync tests until fixed

* updating datasource locators

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-02-25 14:56:09 +00:00
Anagh Hegde
231cb34199
Add check for yml CI files in git connect (#11431) 2022-02-25 17:51:45 +05:30
Ayangade Adeoluwa
72b718ce11
fix: Fixes UI and functionality issues on the Curl editor page (#11405) 2022-02-25 15:01:06 +05:30
Shrikant Sharat Kandula
8056e76946
Fix casing of plugin names (#11447)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-25 13:10:31 +05:30
Rishabh Saxena
acf01995bd
chore: git sync cypress tests (#10006)
* Fix connect test

* check api response

* [wip] test comments across branches (#8704)

* Intercept only connect api

* chore: update switch branches tests (#9005)

* test switch branches from the query params

* test flow wip

* .

* fix merge status update

* change mergeAble to isMergeAble

* wip

* fix: show error popup if pulled from bottom bar

* fix: append branch query to notification links

* fix: disable git connection during onboarding

* fix: typo

* fix: typo

* fix: typo

* fix: z-index bottom bar cout

* fix: pull button minor fix

* fix: reset conflicts when the git sync modal is opened

* fix

* feat: enable search for branch dropdown

* fix

* fix: typo

* added merge conflicting on merge tab

* updated gitsyncsaga for git sync error action

* added generate ssh key on init and updated git changed count message

* removed git sync error action from error processing module(toast and log)

* commented push button on bottom git action bar temperory

* added option to use git global config

* Added latest deploy preview time: didn't appear until the duration was in minutes

* Link open repo button with repo link

* fixed of commented code part

* upated tooltip of push button on bottom quick git sync toolbar

* Update banner styles for error and warning

* updated repo publish url pattern and last deployed view part

* when the user clicks on the push icon the deploy tab should open

* when branch name is too big and user hover on it the tooltip is not displayed

* The dropdown alignment displayed for the git connect should be polished

* update tests

* fix: minor git sync fixes (#9228)

* fixed of Under the merge tab when the user searches for the branch name which is not present the pop up closes all of a sudden

* fix: update merge api, use message from api response

* fix: update field

* added tooltip of long dropdown option and updated merge tab dropdowns

* removed log

* chore: add connection cypress tests

* temp update for running tests locally

* fixed long branch name on branch list popup

* Use _ as the branch name separator, instead of -

* Use large buttons as CTAs

* Remove the % from the progress bar

* Fix alignment for the skeletons on the deploy tab

* Merge CTA moves down when the status is rendered, add offset to prevent that and error branch dropdown on merge tab

* Show progress bar after clicking on Merge CTA as the loading state and generate key button

* after generating the deploy key before clicking on connect close the pop-up and open it again the Remote URL is not visible in the input box

* fixing of conflicting issue

* updated git connection design

* Provide more spacing between the lines

* Learn more does not have a hover state

* Heading Merge Changes should be sentence cased like headings on other tabs

* Button can trigger CTA call when in loading state

* disabled clickable icon on git connect bottom bar

* Git connection tab: on error the window doesn't scroll all the way to the bottom

* updated temp remote url values on action and reducer

* updated ellipsis functions of text

* fix: prune branch flag

* fix: update page level roomId to include branch name

* fix

* fix

* feat: add a separate feature flag for git import

* feat: branch section headers bottom bar branch list

* fixed branch list comments

* fixed merge issue

* fix

* feat: hotkey for commit and push

* remove pull button on git conflict info

* move tempRemoteUrl redux to gitSyncreducer and added messages

* splited git error as individual action

* removed push button from git sync bottom buttons

* feat: section header at the merge dropdown

* added comment of converting ssh to https

* feat: show connected to git badge

* feat: show asterisk when we have uncommitted changes

* fix: upate segment header for dropdown

* t fix: remove redundant success toasts

* removed tempory git repo url from app data

* wrapped tooltip with elipsis text

* fix: rm unused vars

* fix: bottom bar icon updates

* updated dropdown option with ellipsis text

* added new props named "wrappedOption" on dropdown for wrapping ellipsis option

* rename wrappedOption to truncateOption on dropdown component

* updated dropdown option with disabled props of tooltip

* fix: remove remote branches from merge branch dropdown

* reset yarn lock

* reset yarn

* fix: keeping it same as the existing value

* fix: remove branch dropdown border

* fix: show merge success indicator

* feat: init repo limit error modal

* fix: disconnect git wip

* added git user config test

* removed test data

* fix: checkout api

* fix: lint

* chore: pre connection test specs

* added revoking git workflow

* renamed revoke to disconnectGit

* added setting on git sync action over bottom bar

* added analytic on git connection

* added learn more for remote url and init module of temp remote url when select new application

* .

* chore: test learn more ssh url

* Verify the functionality of Read documantation link

* added git connect with onboarding workflow

* Validate the Input Box displayed below Commit to master Text

* updated test module for deploy tab with commit comment and deploy preview

* test of prune branch name

* Validate the error faced when user switches between the branches

* verify the functionality when user click on "+" Icon

* Verify the functionality of serach input box inside the serach dropdown

* Verify the display of the Merge Button

* advanced of disconnect git ui

* added git disconnect modal test case

* updated repo limit error condition

* added learn more link test on git disconnect modal

* for review of repo limit error modal test script.

* fix: issue with intercept

* fixes

* fixes

* add key, misc fixes

* fix

* revert changes

* fix

* fix imports

* Fix import

* Yarn lock update

* fix

* fix imports

* chore: remove timeout for a test run

* Increase timeout for jgit APIs

* chore: try increasing timeout

* try increasing timeout further

* Handle git connect error on the basis of error type

* Add env variable to CI build script

* Fix bad commit for adding env var in workflow

* Refactor

* FAdd env var for local repo path

* fix import

* fix specs

* fix

* fix

* try

* fix

* fix

* fix

* fix

* fix: don't validate error msgs

* fix spec

* improve spec

* chore: rm unused code

* chore: update descriptions

* rm commented out code

* fix

* rm comment

* chore: rm comments

* fix: lint

* chore: update comment

* fix: wait for widget switch transition

* spec updates

* fix

* fix imports

* try waiting for getPagesForViewApp

* fix: rm unused file

* fix: remove spec

* fix: add js collection, comment out repo limit exceeded error since it seems not limited on appsmith instances

* Fix server failure

* chore: correct bootIntercom import and sort lines

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Abhijeet <abhijeet@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: f0c1s <anubhav@appsmith.com>
2022-02-25 06:13:16 +00:00
Shrikant Sharat Kandula
68d8c27a94
Remove CORS allow-star from RTS (#11437) 2022-02-25 10:26:04 +05:30
arunvjn
fa7d0f6a9f
Added zipy.ai for analytics (#11411) 2022-02-25 08:58:03 +05:30
Shrikant Sharat Kandula
fb19d0ef99
Scrolling issue in container and modals for app view (#11424) 2022-02-24 20:49:25 +05:30
Abhijeet
612d7d6727
feat: API to provide a way to distinguish if the application is updated manually or through DB migration (#11414)
* Added check for updating application resources manually

* Refactor to include client-side migration
2022-02-24 14:17:50 +00:00
Tolulope Adetula
8ab5557e39 fix: add Modal scroll cypress tests 2022-02-24 14:48:13 +01:00
akash-codemonk
cb4b9595d1
fix: indicator does not appear while attaching onClick handler during guided tour (#10739) 2022-02-24 18:43:23 +05:30
Tolulope Adetula
588e1356e3 fix: scrolling issue in container and modals for app view 2022-02-24 13:54:37 +01:00
Nayan
10033aea09
-Added new API to return list of default plugins (#11297)
Added a new API that'll return a list of plugins which are available to install. In other words, it'll return list of default/system plugins. This returns the package name, name and icon only - which will be used by templates to show datasource name and icons.
2022-02-24 16:43:11 +06:00
Nayan
32757a9f35
-set feature flag for templates (#11368)
Adds feature flag for templates.
2022-02-24 16:39:15 +06:00
Mojtaba
450950d68f
fix: curl import tries to guess the content-type from the body if content-type header is not specified (#11295)
* fix: content-type is empty when it's not specified.

* feat: try to guess the content type json or form-urlencoded

* fix: broken test for curl with `--data-urlencode` parameter

* fix: fix guessing urlEncodedPattern

* fix: fix broken tests

* fix: Fixed and improved the code formatting
2022-02-24 13:58:26 +03:30
Pawan Kumar
cc3f98c0f1
chore: Remove chance lib (#11230)
* remove chance

* update yarn.lock

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-02-24 10:04:17 +00:00
Bhavin K
73a3a2452e
fix: added width cap, updated props to handle size (#11357) 2022-02-24 13:51:45 +05:30
Abhijeet
86c7c09982
fix: Map correct collection ids for onPageLoad actions during import application (#11328)
* Introduce defaultCollectionId for onLayoutLoadAction

* Added TC for clone application

* ImportExportSpec & Dropdown resetSpec flaky fix

* Fix test failures

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-24 12:42:28 +05:30
Aswath K
2ad121a092
feat: Keyboard accessible property pane header (#11339) 2022-02-24 12:34:31 +05:30
Paul Li
bd9636f514
fix: left border of Input widget is cut off when icon is set and left aligned (#11257)
-- Remove the CSS rule for border-left to be transparent
2022-02-24 11:30:55 +05:30
Arsalan Yaldram
f719a791e8
Merge pull request #11195 from appsmithorg/reset-widget-option
fix: Add true as the default param to resetWidget function.
2022-02-24 10:33:06 +05:30
akash-codemonk
61a163127d
fix: scroll hides content on the canvas in guided tour (#10735)
- Also datasource structure to be expanded only when user expands it in guided tour
2022-02-24 09:38:43 +05:30
Paul Li
4b80ea27e9
fix: Some .jpg images don't load in the Image Widget (#11247) 2022-02-24 09:07:54 +05:30
Aishwarya-U-R
67652287f2
test: Automated tests for Table Migration scenarios + Flaky fixes (#11360)
* Migration table script added

* Migration case & inputv2 flaky fix

* Added menu btn validations

* MigrationSpec - Added sorting valiation

* Flaky tests fix

* LIstWidget api.users count fix

* ListWidget api.users count validation fix

* Bind_ApI spec - added waituntil
2022-02-24 08:41:35 +05:30
Tolulope Adetula
facf6a3d96
fix: date picker uniformity when only Month or year is changed (#11077)
* fix: date picker uniformity

* cypress tests

* fix: Failing date picker test

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-23 15:54:24 -08:00
Tolulope Adetula
27d645955a
fix: long page name text cutting off in preview mode (#11345) 2022-02-23 23:53:49 +00:00
Apeksha Bhosale
db2c638fc4
fix: after JS object delete success move to page url (#11331) 2022-02-23 18:09:41 +00:00
Bhavin K
89bc82b4f5
fix: radio widget example string (#11352) 2022-02-23 17:23:15 +00:00
Preet Sidhu
cc2242de9d
fix: page dragging in Pages editor (#11377) 2022-02-23 22:24:43 +05:30
Arsalan
b34a6c8268 Merge branch 'release' into reset-widget-option 2022-02-23 22:24:00 +05:30
Nayan
4ae0b5b1de
fix: Set comment authors email address as reply to field in comment notification email (#11251) 2022-02-23 21:56:57 +05:30
Favour Ohanekwu
d2c96b9727
fix: suppress warnings about the use of expressions where assignments are expected (#11343) 2022-02-23 21:49:44 +05:30
Tolulope Adetula
06eac9387e
fix: make table button transparent when no color is selected (#11348)
* fix: make table button transparent when no color is selected

* fix:  failing tests in Table_widget_add _button_spec
2022-02-23 07:54:46 -08:00
balajisoundar
5dc5cff722
fix: Update date ISO string validations (#11399) 2022-02-23 20:48:58 +05:30
Paul Li
c30f072c84
fix: Input widget onSubmit ends up triggering onTextChange (#11304)
-- Make onSubmitSuccess callback not to trigger additional onTextChange
2022-02-23 20:44:55 +08:00
Arsalan
5b892ec3fa fix: Removed Datasources from Execute Query Action List. 2022-02-23 17:28:50 +05:30
f0c1s
64a9fd451b
chore: remove second scrollbar from git connect modal (#11336) 2022-02-23 15:41:58 +05:30
f0c1s
989086337a
chore: reformat code in rts/ service (#11309) 2022-02-23 15:36:40 +05:30
Nayan
f060ab8c03
feat: Allow saving theme customizations (#11165)
This PR adds API to save a customized theme so that it can be used again for that application. It also adds permission to themes. Each customized theme will have permissions set just like other domain objects.
2022-02-23 12:32:18 +06:00
Bhavin K
03dc8da930
fix: updated max character validation (#11333) 2022-02-23 11:53:58 +05:30
Preet Sidhu
91f3e11984
Merge pull request #11323 from appsmithorg/fix-9367_resize_property_pane
fix: Property panel resize on dragging
2022-02-23 11:21:59 +05:30
Bhavin K
e944f1b17c
fix: handled to hide widget in preview mode (#11138)
* fix: handled to hide widget in preview mode

* docs : comment update

* fix: condition updated as required, cypress test added

* fix: simpler condition, types updated
2022-02-23 10:22:04 +05:30
Rishi Kumar Ray
7a97640a07
chore: Update config label in Rest API datasource config page (#11107) 2022-02-23 09:51:50 +05:30
Preet
9adf3cbb66 Merge remote-tracking branch 'origin/release' into fix-9367_resize_property_pane 2022-02-22 22:07:43 +05:30
NandanAnantharamu
9016fa0a85
test: updated flaky test (#11324)
* updated flaky test

* updated test PageOnLoad

* commented out flaky test
2022-02-22 21:05:22 +05:30
Ayangade Adeoluwa
be685ef815
Prevent content-type header from changing when switching to raw mode in API pane (#11326)
This commit fixes post body type switcher in API editor. Prior to this PR,
switching the post body to Raw changes the content-type to "text/plain", This
fixes that by preserving the previous content-type when user switches to raw or
none body type. It also gives users the flexibility to use any non supported
content type, while in Raw body mode.
2022-02-22 16:32:43 +05:30
Tolulope Adetula
24293ced76
fix: select widget accept string and object in the defaultOption property (#11082)
* fix: Select widget accept string and object

* fix: JSON object case

* Fix: make Multiselect Defaukt option Array of strings

* fix: Select and Multiselect

* fixes and test cases

* comments

* fix: Select option value

* fix: mutiselect and test case

* fix: failing test

* fix: reset select widget

* fix: PR issues

* fix: Select widget Reset

* fix: failing Test

* fix: test

* fix: tests

* FIX: EVALUATION TESTS

* fix: getting Select Value in form

* fix: Test cases

* fix: add more test cases

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-22 00:43:35 -08:00
Paul Li
42b2dc80e2
fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.) (#11085)
* fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.)

-- Set trimValue prop to false with property controls such as TabControl, MenuItemsControl, ButtonListControl, PrimaryColumnsControl

* fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.)

-- Make trimValue property default to false
2022-02-22 12:17:55 +05:30
Preet
4fb3d7169f use clientWidth instead of getBoundingClientRect 2022-02-21 22:11:50 +05:30
albinAppsmith
5022df9192
Open fix: Username and email hardcoded in mobile sidebar (#11300) 2022-02-21 16:45:11 +05:30
Trisha Anand
860b573bc2
chore: Rename metadata to idToken (#11313) 2022-02-21 16:43:37 +05:30
Bhavin K
707dd9bb8a
fix: updated css for ISDCode Dropdown in the phone widget so that placeholder does not collapses to the left when disabled (#11196) 2022-02-21 11:12:39 +05:30
arunvjn
d27dd30415
feat: Added use case input box in welcome tour to input custom use caes (#11171) 2022-02-19 11:56:10 +05:30
Bhavin K
9eeb120c77
fix: updated height for page view (#10796) 2022-02-18 19:34:14 +05:30
Apeksha Bhosale
44597c5e57
fix: marking old async functions as async in the backed for settings (#10723) 2022-02-18 19:28:11 +05:30
Apeksha Bhosale
92a8df8f04
fix: push js object after creation (#11123) 2022-02-18 19:27:38 +05:30
Arsalan Yaldram
d12ae7a800
fix: Table Filter pane overflows when Table is at the top of the canvas (#10618)
* Added boundaryParent prop to Propperto prevent table filter pane overflow.

* Review Changes, done.

* Resolved overflow issue with multiple pages.

* Removed hardcoded Top value while dragging.

* Added parentElement as a function parameter.
2022-02-18 12:26:09 +00:00