Commit Graph

475 Commits

Author SHA1 Message Date
Nidhi
06300a1758
fix: Using blobs for multipart data (#12240) 2022-03-30 13:10:05 +00:00
rashmi rai
bfd96334af
fix: where clause improvements (#11748) 2022-03-27 19:10:48 +05:30
Mojtaba
5cac8cb3b9
feat: Add Array type to MultipartFormDataType variants for REST api (#11386)
* feat: Add Array type to MultipartFormDataType variants
 and handle every item in list as a part in multipart request

* fix: add array options

* fix: rename file to  array value

* fix: parse Array from json text

* fix: reformat the code and remove `System.out.println`

* fix: testParseMultipartArrayDataWorks is more accurate now

Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-26 20:08:55 +01:00
Sumit Kumar
40f4e3c755
fix: S3 plugin: provide support for MinIO (#11766)
* update option label

* add minIO as a separate datasource option
add datasource connection changes to support minIO without SSL and when using CA signed certificates

* fix cypress tests
2022-03-24 18:28:00 +05:30
Sumit Kumar
027161e033
fix smart substitution setting toggle fetch method and path. (#12181)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-24 17:55:32 +05:30
Sumit Kumar
a486474483
rename variable. (#12204) 2022-03-24 16:38:52 +05:30
Sumit Kumar
47ad7cc9b1
feat: add JSON smart substitution feature to Firestore plugin actions
* This PR adds the JSON smart substitution feature to Firestore plugin actions.
* This smart substitution will work exactly the same way as it works for REST API actions.
* Currently, smart substitution only gets applied to the body section of Create, Set, Add or Update commands as this is the only input field that expects a JSON input type.
* It can be toggled On/Off via the Settings tab.
* It is set to On by default. However, data migration has been added to set it to Off for all existing Firestore actions so that they are not impacted by this PR's changes.
2022-03-24 13:02:54 +05:30
Nidhi
1ca9fd803a
fix: S3 formData path for bucket name (#12049) 2022-03-22 12:56:42 +01:00
Nidhi
c97b7e31e7
chore: Migrations to enable JSON and form mode (#11534)
* feat: added new component to perform generic json raw toggle functionality

* chore: Migration to convert formData references

* fix: Redid migration for per plugin changes, fixed consumption

* fix: Added JSON migration for git import

* Added JSON migration as well

* Reverted client side changes

* fix: Modified plugin config aggregation logic

* Merge conflict fixes

* different paths for different commands

* Whoopsie

* Modified usage to different paths

* Reverting env change

* Config changes to show json mode

* Test fixes

* Migrated body,path,next,prev

* Cypress test fixes

* Modified dynamic binding replacement

* Changed view type

* Reverted json form mode display

* Modified structure of JSON mmigrations

Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-21 11:22:14 +05:30
Leo Thomas
7a038400e5
fix: 10527 Google Sheet crud generation header issue v2 (#11664)
* fix: 9824 Google Sheet to filter empty condition ver.2

* Code review comments updated

* Updates as per review comments - Ver 3

* Resolved errors found during testing

* Code review comments fix

* fix:10527 Google Sheet Crud Generation header issue

* Code review comments implemented

* Updated review comments

* code review - resolve test cases issue

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-03-16 20:20:10 +05:30
Leo Thomas
60079faa58
fix: GSheet incorrect error message fixed (#11699)
Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-03-10 14:57:54 +05:30
Nidhi
966564d2bc
fix: Modified root json for SMTP to comply with UQI aggregation rules (#11676) 2022-03-07 14:56:54 +05:30
devnamrits
406fa0cc3d
fix: firestore queries asterisk (#11599)
* fix: remove asterisk from non-mandatory fields in firestore query

* making one false

* fix: remove asterisk from non-mandatory fields in firestore query

* fix: remove asterisk from non-mandatory fields in firestore query

Co-authored-by: Hritik Kumar <devnamrits@Hritiks-Mac.local>
2022-03-03 22:08:44 +05:30
Nidhi
8b1638aba6
chore: Modified plugin config aggregation logic (#11561)
* fix: Modified plugin config aggregation logic

* Modified logs a bit

* Reverted incorrect path from another branch
2022-03-03 19:26:55 +05:30
Mojtaba
29be75e0e9
feat: add smart substitution handling for known MongoDB types (#11135)
* shelf: start working on substitution for `ISODate`

* a draft for Sumit to check what I did wrong in my tests

* test: tests are working

* test: cleanup

* refactor: add replacementDataType parameter to DataTypeStringUtils.jsonSmartReplacementPlaceholderWithValue

* fix: remove quotes for Mongo Types work in single form, arrays and json.

* add handling for more use cases
add/update more TCs

* add comments

* add more comments

* add space (cosmetic change)

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-03-02 22:33:50 +05:30
Nidhi
5c994975d7
fix: Modified action execution endpoint (#9473) 2022-03-02 16:01:50 +00:00
Mojtaba
dad6dfb636
fix: Fixed test MongoDB datasource shows ok even if there is no database matching the name in the 'Default Database Name' input (#11238) 2022-02-18 10:41:01 +03:30
Mojtaba
497dd1a21b
fix: showing invalid credentials message on MongoDB test datasource if there is an unauthorized error (#11124)
* fix: if test datasource gets Unauthorized accessing admin database
It will try to access the default database.

* fix: fix broken test

* fix: cleanup unused imports

* test: make test more readable with better comments
2022-02-16 14:03:13 +05:30
Leo Thomas
4c81347128
fix: 7794 Google Sheet Fails with Mixed Datatype (#11089)
* fix: 7794 Google Sheet Fails with Mixed Datatype

* resolved failing test cases after new implementation

* Added code comments to the changes

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-02-16 08:22:40 +00:00
dependabot[bot]
7ddf4d0ab2
chore: bump postgresql in /app/server/appsmith-plugins/postgresPlugin (#11190)
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.25 to 42.3.3.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.25...REL42.3.3)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-16 08:57:41 +05:30
Félix Suarez Bonilla
9bcd4afff1
feat: Add Mongo Templates for plugin. (#11153)
Adds templates for the Aggregate, Distinct and Count commands for the MongoDB plugin.
2022-02-15 10:29:01 -06:00
Nidhi
7a8db4270a
fix: Added channel timeout configurations for REST WebClient provider (#11177) 2022-02-15 13:19:20 +00:00
Arpit Mohan
286864eb3d
feat: Support body in GET API requests (#7127)
* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* adds apiContentType to actionConfiguration.formData object

* Handling apiContentType property in Rest API formData

* change apiContentType when user types content-type value and switches http method

* makes api editor as similar as possible to postman, project postman.

* Correcting the import in ApiEditorConstants

* Resolved all merge conflicts

* replay DSL functtionality

* removes unneccessary files from worker

* Fixes type declarations, naming e.t.c.

* fix server side merge conflicts

* fix client side merge conflicts

* fix failing cypress tests

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
2022-02-15 11:13:48 +00:00
Sumit Kumar
d208792786
fix: S3 plugin: remove Expiry Duration config from Read file query
* This PR removes the Expiry Duration field from the Read file command of S3 plugin.
* An Expiry Duration field got added to Read file command mistakenly some time post migration to UQI schema. This field did not exist with the read command before the migration and does not get used even now.
2022-02-15 12:24:48 +05:30
Nidhi
1868675349
feat: Self-signed certificates for REST APIs (#11043)
* feat: Self-signed certificates for REST APIs

* Changed scope for netty dep
2022-02-15 06:54:26 +00:00
Sumit Kumar
d03f503657 add new command: delete multiple files
add template for delete multiple files
add template for create multiple files
add / update TCs
2022-02-14 10:18:01 +05:30
Sumit Kumar
004bd89e7a fix read.json 2022-02-14 07:07:10 +05:30
Mojtaba
f6463d0cf8
fix: Added stricter validation for Mongo pipeline (#11034)
* fix(mongoPlugin): try to make JSON validation more strict

* test(mongoPlugin): add testAggregateCommandWithInvalidQuery
2022-02-09 22:04:03 +05:30
Sumit Kumar
aa2290405d
fix: fix refresh token flow in REST API OAuth (#10875)
Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
2022-02-09 09:38:58 +05:30
Leo Thomas
6e7687450e
fix: 9414 Firestore where clause not fetching numbers (#10775)
* Fixed issue with Firestore in fetching data while using numbers in the where condition.
* Other Fixes made in the where condition :
  When using Boolean
  When using Date 
  When Using Timestamp 
  When given space in the key
  When Space given in the Value
2022-02-08 11:29:50 +00:00
Snyk bot
194b78b4c4
chore: Upgrade org.springframework:spring-webflux from 5.2.3.RELEASE to 5.3.15 (#4586)
* fix: upgrade org.springframework:spring-webflux from 5.2.3.RELEASE to 5.3.15

Snyk has created this PR to upgrade org.springframework:spring-webflux from 5.2.3.RELEASE to 5.3.15.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.springframework/spring-webflux/

See this project in Snyk:
https://app.snyk.io/org/nikhil-nu4/project/1b8549de-d47e-4508-85dd-9a19fa240760?utm_source=github&utm_medium=upgrade-pr

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-07 09:49:47 +05:30
dependabot[bot]
38108cc098
chore: bump postgresql in /app/server/appsmith-plugins/postgresPlugin (#10809)
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.12 to 42.2.25.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.12...REL42.2.25)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-05 00:51:45 +05:30
Shrikant Sharat Kandula
6967c35531
fix: Disallowed IPs can be bypassed by using a CNAME/A record (#10868)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-03 21:23:04 +05:30
Sumit Kumar
6f83df976d
feat: add sorting and pagination features to S3 plugin (#10736)
* add sorting and pagination features to S3 plugin
2022-02-03 06:15:01 +00:00
Mojtaba
170c263f9c
Merge pull request #10711 from appsmithorg/fix/9221-mysqlPlugin_user_with_empty_password
fix(mysqlPlugin): MySQL allow empty password if user is not empty
2022-02-02 18:39:51 +03:30
Shrikant Sharat Kandula
b1997b8b08
fix: Disallow access to instance metadata hosts (#10797)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-01 18:07:08 +05:30
Mojtaba Zarezadeh
d1ddebd3d8 merge all tests in one file 2022-02-01 13:02:53 +03:30
Mojtaba Zarezadeh
8197ebf297 fix: add single imports 2022-02-01 10:32:55 +03:30
Mojtaba Zarezadeh
e400ea0e80 cleanup: improve comments 2022-01-28 13:03:07 +03:30
Mojtaba Zarezadeh
6d3be8c283 fix(mysqlPlugin): allow empty password if user is not empty 2022-01-28 11:43:21 +03:30
Nidhi
c7d1e87c0a
fix: Removed tracking on Sentry for unsupported plugin operation (#10636) 2022-01-26 19:02:48 +05:30
Sumit Kumar
610d665aae
add query params to form.json (#10574) 2022-01-26 12:59:07 +05:30
Leo Thomas
aec120bc3c
fix: Spaces in Google Sheet name (#10605) 2022-01-25 10:52:40 +05:30
Leo Thomas
d5d37a512f
fix: Prevent Google Sheet bulk insert from overwriting existing rows (#10435)
This PR fixes the issue when bulk inset of data overwrites existing rows
Fixes #5076

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-01-20 10:33:30 +05:30
Favour Ohanekwu
72f8b7e2e1
feat: Support OAuth for all plugin types (#9657)
* customize datasource authorization

* improve performance

* fix save datasource bug

* switch auth type from form config

* better naming of components

* fix minor bug

* minor bug fix

* minor bug fix

* syntax cleanup

* Add comments where necessary

* Added comments where necessary

* fix broken airtable page

* code refactor and annotation
2022-01-14 12:01:54 +05:30
Sumit Kumar
18edb18b20
fix: implement getStructure method for S3 plugin (#8919)
* Add `getStructure` implementation for S3 to return a list of accessible buckets.
* Add command templates for S3.
  - List files
  - Read file
  - Create file
  - Delete file
* Remove getDatasourceMetadata implementation as getStructure method can be directly used now.
2022-01-13 11:33:50 +05:30
Nidhi
1d1dd72106
fix: Fixed encoding for all requests in Google Sheets (#10313)
* Fixed encoding for all requests in Google Sheets

* Additional commit for CI check
2022-01-13 05:23:11 +00:00
Sumit Kumar
f045af8bfc
feat: Mongo plugin: add limit field to aggregate command to allow users to define batchSize (#10257)
* This PR adds a limit field which sets the batchSize for aggregate command. This way the user can set the number of documents they want in their Mongo query result.
* limit is set to 10 initially. However, for pre-existing Mongo actions, migration has been added to set this field to 101 - which is the default value that has been used by Mongodb in the absence of any user set value. Ref: https://docs.mongodb.com/manual/tutorial/iterate-a-cursor/
2022-01-10 16:42:30 +00:00
Leo Thomas
9cd89884bf
fix: 9648 The Update query fails to update for all matching Document in mongo (#9975)
* fix:9648 Mongo update All issue-In Progress

* fix: Mongo Multi update query fail fixes

* Added updated testcases that got affected by the code change

* Changes reverted as per review comments
2021-12-31 19:12:19 +05:30
Snyk bot
703d47f7b1
chore: [Snyk] Security upgrade com.fasterxml.jackson.core:jackson-databind from 2.10.5.1 to 2.12.6 (#10014)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-2326698
2021-12-28 12:09:34 +05:30