Kaushik Varanasi
c37adc0a4d
Fix spacing of fields in org settings: fixes ( #3612 ) ( #3681 )
...
* add row colums styling to organisation settings fields
* add tests to make sure the grid layout is rendered
* added margin to make spacing look similar to before
* remove negative margin and reduce width
* added jest tests to make sure component mounts and that it has correct styles
* revert unnecessary changes related to cypress tests
* added strict checking for null to avoid ts errors
* use early returns on file empty
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
* use early returns on file empty
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
* fixed typo
* added findbytext for sync call
* removed unused imports
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-08 11:20:26 +05:30
Trisha Anand
df993efcde
Updated the DSL to change primary columns for an array to a map structure in the DSL ( #3905 )
2021-04-07 18:22:52 +05:30
Hetu Nandu
28995e5b53
Fix PS and smart substitute true false value ( #3896 )
2021-04-07 16:06:17 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget ( #3755 )
2021-04-07 06:33:30 +05:30
NandanAnantharamu
547a9a7ee0
Added tests for Oauth and Stubbed tests ( #3463 )
...
* Added tests for Oauth and Stubbed tests
* updated tests
* test updated
* updated DS tests
* review comments incorporated
* flag removed
* postinvite stubbed
* intercept req added and chromewebsecurity flag added
* Update app/client/cypress/support/commands.js
* updated header request
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-06 18:59:27 +05:30
Hetu Nandu
8bdc491a81
Hot fix for plugin form not downloaded for onboarding ( #3879 )
2021-04-06 15:47:25 +05:30
Rishabh Saxena
d13f755ba8
Update GTM script ( #3711 )
2021-04-05 20:54:22 +05:30
NandanAnantharamu
8cd6c95e70
updated table property pane test ( #3837 )
...
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-05 17:25:27 +05:30
Apeksha Bhosale
48790ce6ca
Array support hidden field ( #3809 )
2021-04-05 15:41:04 +05:30
Kaushik Varanasi
8f8b7b281f
Fixes error on failed github docs fetch ( #3665 )
...
fixes #3551
2021-04-05 14:07:04 +05:30
Vicky Bansal
6b26e400a8
Bug fix for table crash #3645 ( #3849 )
2021-04-04 01:10:12 +05:30
Hetu Nandu
af5f6544ea
Always guarantee to fetch Api plugin forms ( #3847 )
2021-04-02 15:17:37 +05:30
Rishabh Saxena
244930dd69
Add support of component unit testing ( #3828 )
...
Update jest config, add msw hooks
2021-04-02 15:17:16 +05:30
Abhinav Jha
28921e0324
Fix table width on drag ( #3839 )
2021-04-02 13:48:30 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties ( #3167 )
2021-04-01 14:00:33 +05:30
Arpit Mohan
91a7acea49
Adding table plugin in the Rich text editor ( #3799 )
...
* Add Table button in RTE Toolbar
Co-authored-by: Aswath K <aswath.sana@gmail.com>
2021-04-01 13:54:42 +05:30
dependabot[bot]
68e405a746
Bump y18n from 4.0.0 to 4.0.1 in /app/client ( #3817 )
...
Bumps [y18n](https://github.com/yargs/y18n ) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases )
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/yargs/y18n/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-01 10:39:29 +05:30
Apeksha Bhosale
1f216167c4
removing new lines while showing url path field ( #3717 )
...
* added 2 states for path field
* added logic for compact only
* added small condition for no compact
* PR comments fixed
* removed redundant code
* added unit test for code editor functions
* Update app/client/src/components/editorComponents/CodeEditor/index.tsx
* setting cursor
setValue is resetting cursor position to the front. so will update at the end
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-03-31 17:58:29 +05:30
Apeksha Bhosale
834fc3caf7
showing save datasource option all time ( #3695 )
...
* showing datasource
Exposing 'save as datasource' with empty path but in disable state till value is entered
* sending flag instead of value
* removed classname
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-31 16:09:13 +05:30
Rishabh Saxena
7ffc0d3786
Ignore cypress/no-unnecessary-waiting ( #3794 )
2021-03-31 14:05:19 +05:30
Hetu Nandu
0c77051944
Improve performance monitoring ( #3790 )
2021-03-31 13:10:59 +05:30
Ashok Kumar M
3bce03173a
Fix: Property pane improvements and bug fixes ( #3766 )
...
* Fix: Propane improvements bug fixes
* Adding plus indicator for New modal action.
2021-03-31 11:21:24 +05:30
Abhinav Jha
10159fc442
Fix #3752 DatePicker tries to auto parse the defaultDate ( #3753 )
2021-03-30 14:32:25 +05:30
Hetu Nandu
aec7e613ad
Update dropdown font size and shadow ( #3680 )
2021-03-30 14:18:14 +05:30
Ashok Kumar M
984fbecac5
Fix: Adding debounce for renaming tabs. ( #3758 )
2021-03-30 13:44:25 +05:30
Pawan Kumar
d8b9b8e918
Fix: TypeError: e.widgetName is undefined and TypeError: Cannot read property 'toUpperCase' of undefined ( #3694 )
...
* call toUpperCase() only when widgetName exists
* use lodash instead of string class functions
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-03-30 11:20:00 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor ( #3701 )
2021-03-30 10:59:03 +05:30
dependabot[bot]
b4b903278c
Bump lodash-es from 4.17.11 to 4.17.14 in /app/client ( #3738 )
...
Bumps [lodash-es](https://github.com/lodash/lodash ) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-30 10:38:34 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) ( #3748 )
...
* Fix: On renaming a widget via entity explorer the canvas gets resized
* Fix: Close prop pane on resize start of unselected widget.
* Fix: Match all - corejs polyfill
* Fix: Proppane not updated properly when same type widgets are selected.
* Feature: Draggable Proppane.
* Bug fixes for draggable popup.
* Fix: Property pane editor when selecting another widget.
* resolve rebase bad merges.
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fixes
* cytest fix
* fixing draggable components inside porp pane.
* Adding cypress test.
* refactored Draggable list POC version
* reverting unwanted changes.
* prop pane bug fix
* unwanted dependencies.
* double click to open prop pane.
* Fixing bugs in draggable prop pane.
* one click prop pane open.
* ignore drag/resize click captures
* make prop pane draggable only via drag handler.
* Fixed property pane title.
* converting layer to hook and adding it to top most layer.
* removing irrelevant comments.
* close panel when widget changes.
* fixing cytests.
* bug fix
* fixing cytest
* Addressing code review comments.
* bug fix
2021-03-29 21:17:22 +05:30
Rishabh Saxena
3f55e16b35
Fix onboarding test spec: check res instead of req to verify if the datasource was created successfully ( #3747 )
2021-03-29 19:51:50 +05:30
hetunandu
b0580e9ee0
Revert "Feature: Property Pane improvements ( #3561 )"
...
This reverts commit 3437c16ef0 .
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements ( #3561 )
...
* Fix: On renaming a widget via entity explorer the canvas gets resized
* Fix: Close prop pane on resize start of unselected widget.
* Fix: Match all - corejs polyfill
* Fix: Proppane not updated properly when same type widgets are selected.
* Feature: Draggable Proppane.
* Bug fixes for draggable popup.
* Fix: Property pane editor when selecting another widget.
* resolve rebase bad merges.
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fixes
* cytest fix
* fixing draggable components inside porp pane.
* Adding cypress test.
* refactored Draggable list POC version
* reverting unwanted changes.
* prop pane bug fix
* unwanted dependencies.
* double click to open prop pane.
* Fixing bugs in draggable prop pane.
* one click prop pane open.
* ignore drag/resize click captures
* make prop pane draggable only via drag handler.
* Fixed property pane title.
* converting layer to hook and adding it to top most layer.
* removing irrelevant comments.
* close panel when widget changes.
* fixing cytests.
* bug fix
* fixing cytest
* Addressing code review comments.
* bug fix
2021-03-29 15:28:52 +05:30
Apeksha Bhosale
8983940a30
Merge pull request #3659 from appsmithorg/fix/new-field-POST-change
...
Added index check to add content type in existing field
2021-03-29 15:26:03 +05:30
Hetu Nandu
55f65a9fe5
fix default override same value ( #3691 )
...
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2021-03-29 12:44:16 +05:30
Nidhi
683176fc48
Increased default limit for webclient payload ( #3718 )
...
* Increased default limit for webclient payload
2021-03-26 21:34:10 +05:30
prapullac
d9417dc043
Adding test ideas for Switch widget ( #3490 )
...
* adding test ideas for Switch widget
* reset widget for date change
2021-03-26 14:08:10 +05:30
Apeksha Bhosale
84ebd4324f
Updated link for datasource whitelist url ( #3679 )
2021-03-26 13:41:15 +05:30
prapullac
cee1b86f32
Adding test ideas for Edit profile ( #3700 )
2021-03-26 12:51:46 +05:30
Rishabh Saxena
973a70a624
Fix editor help menu background color and icon size ( #3686 )
2021-03-26 12:18:15 +05:30
Apeksha Bhosale
eab1f8372a
Merge branch 'release' into fix/new-field-POST-change
2021-03-26 09:33:52 +05:30
abhishek nayak
5114ca75c4
Merge pull request #3706 from appsmithorg/fix/filteredData-columnProperties
...
Fix #3381 : Table column properties now map correctly when filtering, sorting or searching
2021-03-26 01:30:03 +05:30
Abhinav Jha
5b3547c104
Fix filter condition functions
...
Fix issue where column properties don't update based on filters and sorting and search
2021-03-26 01:18:40 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests ( #3501 )
...
* added test with switch widget within farm widget
* Added another usecase with Switch
* added wait
* updated locators
* minor update
* add locators for switch widget spec
* removed waits and replaced with suitable assertions
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-25 21:38:16 +05:30
NandanAnantharamu
378330815b
Added test for tableWidget bug ( #3528 )
...
* Added test for tableWidget bug
* updated test
* review comment incorporated
* updated collapse pane test
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 16:31:51 +05:30
Rishabh Saxena
f2160d61e1
Fix onboarding Cypress test ( #3678 )
2021-03-25 13:23:56 +05:30
Apeksha Bhosale
4c464787a1
code folding in response and request ( #3658 )
2021-03-25 10:57:00 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config ( #2670 )
...
* Property pane enhancements
- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.
* Add chart type: "Custom FusionChart" (#2996 )
Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display ( #3607 )
2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string ( #3397 )
2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type ( #3569 )
2021-03-24 16:54:10 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells ( #3522 )
...
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-24 14:33:48 +05:30
Vicky Bansal
06231e0f5f
Fix crash on Tabs property bindings ( #3640 )
2021-03-24 14:28:00 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats ( #3162 )
...
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-24 14:23:39 +05:30
Hetu Nandu
9a4c317f20
Store value improvements ( #3663 )
2021-03-24 10:39:47 +05:30
abhishek nayak
2e53c79464
Update ForkApplicationModal.tsx
2021-03-24 00:35:46 +05:30
prapullac
9da0d7abf6
Added test ideas for Table and Hide feature of the page ( #3594 )
2021-03-23 17:56:31 +05:30
Apeksha Bhosale
28a4b4a6d6
test case fixed
...
it was checking 3rd key:value pair for content type but with changes it will added to first empty field (0th)
2021-03-23 16:55:21 +05:30
Apeksha Bhosale
5d71e86f43
Test case and refactor code
2021-03-23 15:14:44 +05:30
Hetu Nandu
2dd1791810
Refactor and add unit tests to API interceptors ( #3647 )
2021-03-22 14:52:24 +05:30
Hetu Nandu
f345619f40
Fix code coverage generation file ( #3655 )
2021-03-21 12:02:47 +05:30
Hetu Nandu
f1cb2a35b7
Add jest coverage diff reporting action ( #3651 )
2021-03-20 19:28:10 +05:30
Hetu Nandu
52c7f5331a
Trigger client integration only on approved PRs ( #3632 )
...
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2021-03-19 14:21:14 +05:30
Hetu Nandu
64116583e3
Fix container widget dynamicBindingPathList correction ( #3619 )
2021-03-19 11:39:35 +05:30
NandanAnantharamu
a82c789c1a
udpated tests ( #3617 )
...
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-19 11:19:54 +05:30
Nikhil Nandagopal
6b7fcc4c5d
Merge pull request #3615 from appsmithorg/minor-globalsearch-fixes
...
Minor globalsearch fixes
2021-03-19 11:17:00 +05:30
Kaushik Varanasi
55c17a66aa
Fix success message for single user invite and multiple user invite ( #3591 )
...
* Fixed error message for single user invite
* updated success message for single user invite and created tests
* use state to detect and update the number of users invited
* removing unnecessary lines
* typo
2021-03-18 19:20:33 +05:30
hetunandu
12aba25a00
Remove page save event from frontend
2021-03-18 19:15:57 +05:30
Pawan Kumar
80895b876b
Enhancement: Virtualized Query Editor Table ( #3496 )
...
* add react-window on react-table
* remove .vscode launch.json
* add cellwrapper
* fix height issue in virtualized table
* useBlockLayout in Table
* add border-right on table row
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-18 18:40:57 +05:30
Rishabh Saxena
8acb365201
Fix placeholder
2021-03-18 18:19:05 +05:30
Rishabh Saxena
660b00b4d5
update title
2021-03-18 18:17:09 +05:30
Rishabh Saxena
82cd1b33ba
fix document icon styles
2021-03-18 18:14:37 +05:30
Kaushik Varanasi
5f80e2561e
Merge pull request #3572 from appsmithorg/bugfix/trunncate-org-name-settings
...
add ellipsis to org name in settings
2021-03-18 12:39:52 +05:30
ram-primathon
8b21dd30fd
add icon and subText in ads dropdown ( #3598 )
2021-03-18 02:06:26 +05:30
Hetu Nandu
441bb368d2
Reduce flakiness by adding waits ( #3605 )
2021-03-18 02:02:16 +05:30
Hetu Nandu
0debe37637
Add arbitary wait on onboarding test ( #3604 )
...
We recently changed the test to make sure we wait for the client to create an onboarding data source if it did not exist. This kind of check was also happening on the source code, and the complexity was not getting translated properly in the tests.
To improve the reliability of the test, I added an arbitrary wait time before we start the building
2021-03-17 23:59:40 +05:30
Vicky Bansal
1195a0b694
Reset selected row(s) when table data is changed ( #3576 )
...
* Fixed selected row resets when table data is changed
Added cypress test case to test selected row resets when table data changes
* Fixed cypress test case
2021-03-17 17:27:38 +05:30
Nidhi
084faf8d54
Typo ¯\_(ツ)_/¯ ( #3595 )
2021-03-17 17:04:53 +05:30
Hetu Nandu
b32cdfc8cb
Remove property pane custom scrollbar for cypress ( #3592 )
2021-03-17 15:56:34 +05:30
Rishabh Saxena
0e3901953b
Fix specs ( #3577 )
2021-03-17 15:06:08 +05:30
Kaushik Varanasi
8fd0509bcb
Merge branch 'release' into bugfix/trunncate-org-name-settings
2021-03-17 12:45:13 +05:30
NandanAnantharamu
8aca378028
updated flaky test ( #3584 )
...
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-17 10:38:00 +05:30
Kaushik Varanasi
f9d2318e5a
reconciling with current release
2021-03-17 00:22:01 +05:30
Kaushik Varanasi
dfa23a6944
added tests, documentation and better naming convention
2021-03-17 00:18:36 +05:30
Apeksha Bhosale
3dc04901c8
added index check to add content type in existing field
2021-03-16 19:57:21 +05:30
Kaushik Varanasi
2dcecfbf79
add ellipsis to org name in settings
2021-03-16 13:22:25 +05:30
hetunandu
eed140f945
stringify page save analytics
2021-03-16 11:01:48 +05:30
Ashok Kumar M
fc34901be8
Fix: Dynamic Canvas Height based on bottom most widget. ( #3398 )
...
* Fix: Dynamic Canvas Height based on bottom most widget.
* Checking cytest failure reason.
* Revert "Checking cytest failure reason."
This reverts commit 2e3aaa882b282e10e1cf491633101293b72ffa89.
* Using UPDATE_CANVAS_LAYOUT to update the layout.
* Remove unwanted declarations.
* Adding comments.
2021-03-16 10:31:37 +05:30
ram-primathon
3b0fb539d5
Property Pane re design ( #3057 )
...
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Vicky Bansal
03be391fa3
Wrap evaluated data in computed value field ( #3520 )
2021-03-15 15:27:43 +05:30
Vicky Bansal
7c994da6e9
Allow null/empty values in Dropdown widget options ( #3533 )
2021-03-15 15:25:37 +05:30
Vicky Bansal
5acf2c3238
Fully display Table Widget filter conditionals (AND|OR) ( #3521 )
2021-03-15 14:39:10 +05:30
Vicky Bansal
812344c439
Persist Table Widget cell height to use as default in deployed app view ( #3537 )
2021-03-15 14:34:33 +05:30
Vicky Bansal
030269f684
Display the date column output correctly in table when using JS toggle for Display date format
2021-03-15 10:59:01 +05:30
Vicky Bansal
7f43705e7f
Fixed undefined poperty error when columnOrder is undefined ( #3511 )
2021-03-15 10:57:34 +05:30
Rishabh Saxena
3a47e085e3
Minor global search updates ( #3502 )
...
* Update editor header help button styles
* Dont show the current entity in the recents, to keep the previous on top
2021-03-13 23:31:47 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file ( #2798 )
...
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-13 19:54:45 +05:30
Hetu Nandu
89effdd2fb
Refactor evaluate function and add tests ( #3536 )
2021-03-13 19:42:21 +05:30
Rishabh Saxena
7bd1e9587c
Use replace instead of replaceAll ( #3538 )
2021-03-13 16:15:51 +05:30
ram-primathon
191dde0b18
Fix API pane header and params count ( #3494 )
2021-03-13 13:53:46 +05:30
Nikhil Nandagopal
3b2072eeb9
Merge pull request #3055 from appsmithorg/fix/rte-newline
...
Added defaultText and defaultHTML properties in RTE
2021-03-12 17:38:58 +05:30