Commit Graph

8 Commits

Author SHA1 Message Date
Rudraprasad Das
927383b82a
chore: git pkg - adding baseIds in package based urls (#38827)
## Description
- Renames url param `packageId` to `basePackageId`
- Renames url param `moduleId` to `baseModuleId`
- Modifies package init sagas to use basePackageId instead of packageId


Fixes https://github.com/appsmithorg/appsmith/issues/38504
Fixes https://github.com/appsmithorg/appsmith/issues/38503
Fixes https://github.com/appsmithorg/appsmith/issues/38502

## Automation

/ok-to-test tags="@tag.Module"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13010301792>
> Commit: 3e762e2f8dd9851157041830d25983de53ab08af
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13010301792&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Module`
> Spec:
> <hr>Tue, 28 Jan 2025 12:49:42 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Added `baseId` property to Module and Package interfaces
- Updated navigation entity matching to use `basePackageId` and
`baseModuleId`

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-29 11:43:11 +01:00
Hetu Nandu
a23bcbf955
fix: Separate Plugin Entity from Action (#38582) 2025-01-15 11:29:32 +05:30
Ashit Rath
6ce764c076
chore: add packagePullStatus to consolidated API (#38179)
## Description
This is a refactor PR to support auto pull of packages on page load.
1. adds an additional property on the consolidated API which reflects if
the application needs to upgrade it's packages (`packagePullStatus`)
2. A scaffold component to be extended in EE to show the package pull
status as it's called in parallel to consolidated API and is
non-blocking to the app's first page load

Not this is only relevant to the edit mode of the application

PR for https://github.com/appsmithorg/appsmith-ee/pull/5745

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12349195312>
> Commit: 9112f8a148a1f12c3f8cb3d59606d72afb962055
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12349195312&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 16 Dec 2024 12:30:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Introduced a new `PackageUpgradeStatus` component for future use.
	- Added a new enumeration `PACKAGE_PULL_STATUS` with status constants.
- **Enhancements**
- Updated `setupPageAction` to accept additional parameters for improved
data handling.
- Enhanced error handling and logic in methods related to loading
application data and managing plugins.
- **Bug Fixes**
- Adjusted the argument structure for the `setupPage` method to ensure
compatibility with updated action handling.
- **Documentation**
- Updated interfaces and method signatures to reflect new parameters and
structures.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-17 13:16:30 +05:30
ashit-rath
053db40e30
chore: update module constants (#33673)
## Description
Updates to module constants for easy extension in EE


PR for https://github.com/appsmithorg/appsmith-ee/pull/4257

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9218704577>
> Commit: ca8fbda349f665207bbd1c36339a8ac01c60b43d
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9218704577&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-05-27 17:50:06 +05:30
Ankita Kinger
be9b751539
chore: Refactoring code to show plugin based icons for module instances on EE (#31713)
## Description

Refactoring code to show plugin based icons for module instances on EE

Fixes [#30163](https://github.com/appsmithorg/appsmith/issues/30163)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8256707865>
> Commit: `897cc28f1c8d15efb7789788aba89687b85a4916`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8256707865&attempt=2"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->











<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new interface for module metadata, including properties
like module and plugin identifiers.
- Added a new type property to the Module interface to distinguish
module types.
- Enhanced resource list loading with unique identifiers for each
resource.
- Implemented functionality to dynamically resolve and display icons
based on module or plugin properties.
- **Enhancements**
- Updated the applications page to support workspaces more effectively,
including active workspace identification.
- Improved module selection and display across the application, allowing
for a more integrated module management experience.
- **Refactor**
- Removed unused functions and components related to module icon
resolution.
- Streamlined the logic for fetching and displaying module-related
information, including in action selectors and query editors.
- **Bug Fixes**
- Fixed an issue with resource object identification by introducing
unique `id` fields.
- **Style**
- Added new class selector for module instance name editing, enhancing
the styling options.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-13 11:11:36 +05:30
Apeksha Bhosale
6e39d11b14
chore: split for module instance evaluation on ee (#29027)
## Description
Module instance evaluation required split to be extended on EE

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-11-22 15:02:44 +05:30
ashit-rath
eeac30489b
chore: Editor rightpane refactor (#28705)
## Description
This PR refactors the Actions right pane to inject a new section
(Inputs) when the action editors are used in Module Editor.

Changes:
1. Moved the Collapsible component to a separate file
2. Added a new param to the Editor Context to provide the additional
section

The changes correspond to the EE
[PR](https://github.com/appsmithorg/appsmith-ee/pull/2829)

#### PR fixes following issue(s)
Fixes #28453

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-11-09 16:00:10 +05:30
Apeksha Bhosale
8d8e03ef76
chore: module input moved to different file to be extended (#28225)
>
## Description
Moved moduleInputs to different file to be extended

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-10-20 14:22:46 +05:30