6beeb2513c
13906 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Trisha Anand
|
6beeb2513c
|
chore: Migrate Tenant to Organization (#38891)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /test all ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13391658708> > Commit: d30db4487d93622533aec846a17fecea12e0205e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13391658708&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalStoreValueFunctions_spec.ts > <li>cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts > <li>cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Tue, 18 Feb 2025 14:35:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced organization-level configuration management, impacting admin settings, login, and branding displays. - Enhanced handling of permissions and feature flags now centered on organizations. - **Refactor** - Updated user-facing terminology across the application from “tenant” to “organization” (e.g., in dashboards, profile settings, error pages, and admin panels). - Refactored multiple components and services to utilize organization-based logic instead of tenant-based logic. - **Chore** - Deployed comprehensive migration scripts to seamlessly transition all settings and cached data to the new organization model. These updates improve consistency and clarity in how configurations and permissions are managed and presented. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Nilansh Bansal
|
f05e3be955
|
fix: file upload fixed when using Base64 type in FilePicker and multipart/form-data in REST API (#39332)
## Description > This PR fixes the file upload issues when we use the Base64 type in the File Picker Widget and the REST API uses a multipart/form-data type. From the table [here](https://github.com/appsmithorg/appsmith/issues/39109#issuecomment-2655659006), this issue points to the 3rd one in the list. Fixes #39227 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13392351852> > Commit: c731c6515d4bba00ca3232b5309401d76471f184 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13392351852&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 18 Feb 2025 14:36:12 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced multipart form data handling for file uploads, now supporting robust processing of base64-encoded content with options for custom filenames and MIME types. - Introduced specific error messages for invalid multipart data and base64 format issues. - **Refactor** - Streamlined the data processing workflow with clearer error messages and simplified logic for improved reliability during file upload operations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sneha122
|
95e8e3703c
|
fix: UQI dropdown search issue fixed (#39330)
## Description This PR fixes search issues with dropdown UQI control. Steps to reproduce: 1. Create zendesk datasource 2. Create a query 3. Check commands dropdown 4. Try searching for "Create ticket" 5. It should show the relevant options Fixes #39164 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13389048508> > Commit: 261eb4369682e2e65fae19101403002debd90c91 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13389048508&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 18 Feb 2025 12:17:03 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the dropdown control by introducing a search capability. Users can now type keywords to filter options based on their labels, making it easier and faster to locate the desired option while preserving the existing functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Rudraprasad Das
|
242840d309
|
chore: git pkg - mod fixes (#39255)
## Description - Introducing artifact aware permissions - Better error handling for sagas - New API contracts for local profile Fixes https://github.com/appsmithorg/appsmith/issues/38505 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13375089313> > Commit: 13aa020d4699a94ab5464e1a92b024d4068896b2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13375089313&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 17 Feb 2025 17:44:17 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced Git integration with adaptive connection messages and success modals that now reflect the type of artifact being handled. - Added support for storing additional Git metadata to improve artifact management. - **Refactor** - Streamlined error handling across Git operations to ensure more reliable feedback. - Updated permission structures and context management to deliver a more robust and flexible Git experience. - **Chores** - Consolidated module organization and improved type consistency for better maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ashit Rath
|
88d3599bc1
|
chore: Split canvas widget reducers (#39327)
## Description Split canvasWidgetsReducer and canvasWidgetsStructureReducer for UI modules Fixes https://github.com/appsmithorg/appsmith/issues/39326 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13385385883> > Commit: ec13bb0625735d4a0c1b918fd785b3a5ea858245 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13385385883&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 18 Feb 2025 08:41:34 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal dependency management and reorganized module paths for improved maintainability. - Updated import paths for `CanvasWidgetsReduxState`, `FlattenedWidgetProps`, and related types to reflect a new organizational structure. - These behind-the-scenes changes do not affect any user-visible functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Pawan Kumar
|
dc923c9fe6
|
chore: add wds multiselect component (#39300)
WDS Multi-Select component https://github.com/user-attachments/assets/2809dd44-2a1a-47ba-bccc-4d0bf313aa99 Note: This is a kind of hacky multi-select component. React aria does not provide us with any multi select component. So we are making it with existing components like popover, listbox, and autocomplete. /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new MultiSelect component that offers a dynamic multi-select interface with responsive display, clear error messaging, and loading states. - Added a new MultiSelectValue component to enhance the display of selected items in the MultiSelect interface. - **Enhancements** - Improved styling flexibility across key components—including ListBox, ListBoxItem, TextField, and Select—to support custom appearances. - Refined Calendar and DatePicker interactions for a smoother, more reliable user experience. - Added new export statements for selectStyles and fieldErrorStyles to improve modularity and accessibility. - Updated the version of the react-aria-components dependency for enhanced performance and features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13386938922> > Commit: 9d486cbe335446c351b098a420f0e8d0d06b268c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13386938922&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Tue, 18 Feb 2025 09:33:19 UTC <!-- end of auto-generated comment: Cypress test results --> |
||
|
Nilesh Sarupriya
|
d921110658
|
chore: add postSaveHook (#39306)
## Description > [!IMPORTANT] > Add a post save hook on datasources. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13386879786> > Commit: 260ad934fc1295d2ad5ed035ff593c9950158c74 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13386879786&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 18 Feb 2025 09:36:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced multi-tenant support: Datasource records now incorporate tenant and instance details for seamless management across environments. - Extended post-save actions: Datasource saving triggers additional operations via plugin integrations to improve overall functionality. - New transient metadata field added to DatasourceStorage for additional data handling. - New post-save hook method introduced for plugins to perform actions after saving a datasource. - New constant `TENANT_ID` added for consistent field name referencing. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|
Abhijeet
|
e4ed590822
|
chore: Code split for logout success handler (#39296)
## Description ## Description Added redirect URL on user logout Fixes https://github.com/appsmithorg/appsmith/issues/38933 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13369328042> > Commit: 5b4bbe9381d8591234c5b76687ed83b88e288f17 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13369328042&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 17 Feb 2025 12:14:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Users are now automatically redirected to the login page after logout for a smoother navigation experience. - **Refactor** - Simplified the logout request process to consistently use the "POST" method, enhancing reliability. - Streamlined the interception logic for logout API calls, improving overall consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Albin <albin@appsmith.com> |
||
|
Sagar Khalasi
|
f30ef2ee64
|
chore: Removed immur dependancy (#39324)
## Description Fixing this error : https://github.com/appsmithorg/appsmith-ee/pull/6115/files Removed dependencies. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39318 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13383377889> > Commit: 55e9bb0a1366246508ed2e12be9cfae922212a02 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13383377889&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 18 Feb 2025 05:52:11 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the app’s internal data handling to ensure more consistent and reliable feature management. - Enhanced robustness through improved error management, leading to smoother operation and better control over feature updates. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ilia
|
07187a73fa
|
fix: fix enum (#39321)
## Description
> [!TIP]
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._
Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags=""
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!CAUTION]
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Updated internal error handling annotations to align with current
linting rules. These adjustments standardize the codebase and
maintenance practices without affecting application functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Ilia
|
b910304911
|
fix: fix enum (#39320)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/13374048716> > Commit: 7957ce341184147978c9cdb47d3f02de2f8eb508 > Workflow: `PR Automation test suite` > Tags: `@tag.Anvil` > Spec: `` > <hr>Mon, 17 Feb 2025 15:49:47 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated the function options list to automatically filter out an unsupported option, ensuring users only see valid choices. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ilia
|
19cd1ec8fd
|
fix: omit assignRequest (#39319)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13372766159> > Commit: 60f29a8fb49903e390f72a93db1ad290d1e84894 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13372766159&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 17 Feb 2025 15:05:47 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the configuration for function selections to remove an outdated option, ensuring that the interface now displays only relevant choices without altering the overall functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ilia
|
e40564d739
|
feat: add function calling config form (#39252)
## Description https://github.com/user-attachments/assets/94baed89-d0e3-425d-9494-3daf3cacd905 Fixes #39152 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13369293716> > Commit: 32f0aa46a5ddd38a528f1b7137874ee308f3d0d0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13369293716&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 17 Feb 2025 11:59:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a dynamic configuration interface for managing function calls, allowing users to add, edit, and remove entries. - Added interactive components for entering and displaying function call configurations, including an attractive placeholder for when no entries exist. - Enhanced selection options for various function types (e.g., query, JS function, system function) and integrated these into the form control system for seamless user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
c0e073efa3
|
fix: infinite render loop in List Widget when hiding/unhiding with selected item (#39262)
## Description
When a List widget has a selected item and is hidden then unhidden
(unmounted/mounted), an infinite render loop occurs in the following
flow:
```typescript
// Triggered in componentDidUpdate
if (this.shouldUpdateSelectedItemAndView() && isString(this.props.selectedItemKey)) {
this.updateSelectedItemAndPageOnResetOrMount();
}
```
### Root Cause
This happens because:
1. `updateSelectedItemAndPageOnResetOrMount` calls `updatePageNumber`.
2. `updatePageNumber` uses `calculatePageNumberFromRowIndex`, which
depends on `this.pageSize`.
3. Each page number calculation triggers a meta property update through
`onPageChange`.
4. This meta update causes a rerender, repeating the cycle.
#### Problematic Calculation
`this.pageSize` is calculated dynamically based on widget dimensions:
```typescript
calculatePageNumberFromRowIndex = (index: number) => {
return Math.ceil((index + 1) / this.pageSize); // Using unstable this.pageSize
};
```
This creates instability during mount/unmount cycles as:
- Widget dimensions may not be fully stabilized.
- Each meta property update triggers recalculation.
- No break in the update-rerender cycle.
### Solution
Use `this.props.pageSize` instead of `this.pageSize` in page
calculations:
```typescript
calculatePageNumberFromRowIndex = (index: number) => {
return Math.ceil((index + 1) / this.props.pageSize); // Using stable props value
};
```
### Why This Works
- `this.props.pageSize` represents the last stable value set through the
meta property system.
- It's protected by the existing `pageSizeUpdated` flag mechanism.
- Breaking the dependency on dynamically calculated dimensions prevents
the infinite loop.
Fixes #37683
## Automation
/ok-to-test tags="@tag.Widget, @tag.Binding, @tag.List, @tag.Sanity"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13366216706>
> Commit: 74028ec9f52aa25daf0d72c7cdf3c4fa9701e86e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13366216706&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Binding, @tag.List, @tag.Sanity`
> Spec:
> <hr>Mon, 17 Feb 2025 10:23:19 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved the list widget’s pagination by updating how page numbers are
calculated, ensuring accurate reflection of the current page size
settings.
- **Tests**
- Enhanced test coverage for the list widget's visibility, adding new
tests to validate user interactions and ensuring the widget behaves as
expected when items are selected.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Rahul Barwal
|
5b9153cb19
|
feat: Implement infra code for infinite scroll implementation. (#39225)
## Description Implements infinite scroll functionality for table widget using react-window-infinite-loader. Introduces new components and hooks to manage virtualized table rendering with dynamic loading of rows. Fixes #39082 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13329193341> > Commit: 0c58fcf83dbfd520958c9989ffb607cf57d1fdb1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13329193341&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Sanity` > Spec: > <hr>Fri, 14 Feb 2025 13:18:37 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added infinite scrolling support to table views, enabling seamless data loading as you scroll. - Enhanced table interfaces with improved loading indicators and smoother virtualized rendering for large datasets. - **Chores** - Updated supporting libraries to underpin the improved scrolling and data handling capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- |
||
|
Hetu Nandu
|
22688f994f
|
chore: AppIDE Folder Structure (#39165)
## Description Updates the folder structure and file breakup according to the new IDE folder structure Fixes #39048 Fixes #39049 Fixes #39051 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13352717132> > Commit: 54cd1a3b4679ae8bd0687ddb063692a26be1d7b9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13352717132&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Sun, 16 Feb 2025 08:44:30 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
Sagar Khalasi
|
cd519bb8a9
|
fix: Fix from for promise failure (#39295)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.AppUrl" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13363538162> > Commit: 0701248cbd6cd53a9777f00933cc56fb45abcfcf > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13363538162&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.AppUrl` > Spec: > <hr>Mon, 17 Feb 2025 05:49:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Tests** - Streamlined redirection tests by removing an unnecessary sign out step. - Enhanced URL validation with improved logging to ensure correct encoding. - Refined the testing process to robustly verify that redirection parameters are accurately passed. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
shadabbuchh
|
854381671a
|
fix: skip snowflake test cases in cypress (#39304)
## Description This PR skips snowflake cypress tests. Fixes https://github.com/appsmithorg/appsmith/issues/39303 ## Automation /ok-to-test tags="@tag.Snowflake" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13363519219> > Commit: e3975ef121de8c6ea363da3a4a79b49230b40287 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13363519219&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Snowflake` > Spec: > <hr>Mon, 17 Feb 2025 05:48:57 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Temporarily disabled the test suite for Snowflake datasource integration due to external service quota issues. Existing test logic remains intact and will resume once the external constraint is resolved. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
19acf7c0ea
|
fix: sourcemaps (#39301)
## Description - Returned the logic for generating the source maps. Source maps are created for flags `REACT_APP_ENVIRONMENT=PRODUCTION` and `REACT_APP_ENVIRONMENT=DEVELOPMENT` as before. - Removed no longer used flag `DISABLE_ESLINT_PLUGIN` - Removed no longer used `cra-bundle-analyzer` package and related script. EE PR — https://github.com/appsmithorg/appsmith-ee/pull/6227 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13353994445> > Commit: 88551e50c36ff521b479128f4d0bc8f366cb253a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13353994445&attempt=3&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ServerSide/Datasources/Snowflake_Basic_Spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Sun, 16 Feb 2025 12:54:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the build process to consistently enforce quality checks. - Enhanced debugging support by refining source mapping for both production and development environments. - Removed an outdated analysis task to streamline the startup routine. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Manish Kumar
|
007f598c09
|
chore: git detach and push algorithm refinement (#39298)
## Description - logic modification for two flows - git detach - git push Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13330609252> > Commit: 888cf6f94de9769741a54fe55adeae89b828ce1a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13330609252&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Fri, 14 Feb 2025 14:41:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined version control operations for more consistent and reliable artifact management. - Simplified method signatures for better usability in artifact management processes. - **Bug Fixes** - Improved error messaging and recovery during remote interactions, providing clearer feedback when issues occur. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
23c9374e4c
|
feat: Inspect State CTA for discovery (#39100)
## Description Adds various discovery points for State Inspector Fixes #38934 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13329714726> > Commit: e9dc2398262b8cd2bbb69b45bd7089e9fd029e56 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13329714726&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 14 Feb 2025 15:47:53 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an “Inspect State” option across various parts of the interface, enabling users to directly review state details for widgets, actions, and collections via context menus, toolbars, and property pane actions. - Added a new `InspectStateHeaderButton` and `InspectStateMenuItem` for enhanced state inspection capabilities. - **Style** - Refined layout and typography in popups and menus for a cleaner, more consistent user experience. - **Bug Fixes** - Enhanced type safety in property pane actions by enforcing stricter type checks. - **Chores** - Updated imports and refactored related logic to streamline the configuration handling for the debugger interface. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
1a60eaaf89
|
fix: Reduce cycle deps by removing wrong exports (#39268)
## Description Remove specific cycle dependencies created because a file was both importing and exporting items it does not modify. By reducing cycle dependencies here, I am buying credits that allow adding cycle dependencies in another PR but very hard to avoid This PR reduces the deps by 4 EE PR: https://github.com/appsmithorg/appsmith-ee/pull/6214 PR which adds the cycle deps: https://github.com/appsmithorg/appsmith/pull/39100 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13324385763> > Commit: 34a0f459b27963531adf851f198903cf0831b719 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13324385763&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 14 Feb 2025 07:54:00 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a “Show More” option in the code editor’s command palette for additional suggestions. - Enabled default expansion for table widget panels to improve content visibility. - **Refactor** - Consolidated entity and type management for a more consistent and maintainable platform. - **Improvements** - Enhanced widget behavior with dynamic updates in dropdowns, file pickers, and map styling for a smoother user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
shadabbuchh
|
2e73bfeab9
|
fix: Fix flakiness of JSObjects_navigation_spec.ts spec (#39269)
## Description This PR fixes the flakiness of `cypress/e2e/Regression/ClientSide/Debugger/JSObjects_navigation_spec.ts` by making the following improvements: 1. Adding an assertion to verify the deletion of a JS Object in the second test case. 2. Switching to full-screen mode before creating a JS Object in the third test case. Fixes https://github.com/appsmithorg/appsmith/issues/39267 ## Automation /ok-to-test tags="@tag.JS, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13325804763> > Commit: 1e5af6110108e9694317e6943e487cc03c2edb34 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13325804763&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.JS, @tag.Sanity` > Spec: > <hr>Fri, 14 Feb 2025 09:51:57 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced deletion confirmation checks to ensure users see successful deletion notifications. - Improved test stability by enforcing the correct screen mode before creating new objects. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ayush Pahwa
|
2782994c7d
|
chore: add new condition for form conditionals (#38556)
## Description Added an extra condition for form evaluation. This allows server to render different components for application or any other editors. Form configs can now use this as a conditional to show or hide components `editorContextType === "PAGE"`. Valid values are `WORKFLOWS`, `PAGE` or `MODULE`. Fixes #37735 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13294166183> > Commit: 6ab73336517e1ad6491ae3e63a5387cd65112a7b > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13294166183&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.IDE` > Spec: > <hr>Wed, 12 Feb 2025 21:15:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced context-aware evaluation actions to improve dynamic form interactions. - **Refactor** - Streamlined the form evaluation workflow and standardized key extraction for enhanced consistency and reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
260765520e
|
feat: Introduce infinite scroll feature behind feature flag. (#39207)
## Description - Adding `infiniteScrollEnabled` prop to TableWidgetProps - Added feature flag: `release_tablev2_infinitescroll_enabled` to control this. Fixes #39079 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13305863325> > Commit: 182c03d37644cc0b7f5563ed5c9e59c4c06667b6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13305863325&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Sanity` > Spec: > <hr>Thu, 13 Feb 2025 11:35:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an option to enable infinite scrolling in table views. When activated, tables automatically adjust scrolling behavior and pagination controls, enhancing data browsing. - **Tests** - Updated test cases to verify the new infinite scrolling functionality, ensuring it is disabled by default. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Abhinav Jha
|
52c97317a3
|
chore: Eject CRA (#39264)
## Description - Eject the application from create react app - Remove references to craco in the scripts and package.json dependencies - Port craco changes to webpack configuration - Remove SASS and SCSS loaders - Add babel-plugin-lodash - Remove type checks and eslint from webpack Fixes #38903 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13323376575> > Commit: 8f206bdf2ab40f2162b8a32ead78715e850fbf58 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13323376575&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 14 Feb 2025 07:06:14 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced enhanced HTTPS configuration with improved security validations. - Improved handling of environment variables for a more robust configuration experience. - **Chores** - Upgraded and streamlined the build and start processes for better reliability and faster launches. - Refined dependency management and optimized bundling to improve performance. - Modernized module resolution and asset type definitions for a more efficient development workflow. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
0e67bbc68c
|
chore: add hybrid search control (#39258)
## Description Add hybrid search control for UQI forms.  Example of usage: ``` { "isRequired": false, "configProperty": "actionConfiguration.formData.hybridSearch", "controlType": "HYBRID_SEARCH", "initialValue": { "isEnabled": true, "keywordWeight": 0.5, "semanticWeight": 0.5 } } ``` Fixes https://github.com/appsmithorg/appsmith/issues/39236 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13324291818> > Commit: 9495722fe3224474db772890f31730becfa45d79 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13324291818&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Fri, 14 Feb 2025 07:52:38 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new hybrid search control in the form. Users can now easily adjust search parameters with intuitive sliders for keyword and semantic weights, along with a toggle to activate or deactivate hybrid search. - Added a new control type for hybrid search to the form control registry, enhancing the flexibility of form configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Apeksha Bhosale
|
23b2b9256e
|
chore: remove tags for all appsmith metrics (#39265)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13323300949> > Commit: d77b6b7279fb53bdd8dee4effb856b22496a11a1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13323300949&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 14 Feb 2025 07:04:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced system monitoring by refining how performance metrics are collected. This update streamlines performance data for clearer and more relevant insights into the system's behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ayush Pahwa
|
400f894a60
|
feat: group identifier for dropdown form controls (#39256) | ||
|
NandanAnantharamu
|
1cf1750705
|
test: datepicker3 test fix (#39019)
/ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13163657051> > Commit: 33f041b174b7e97a3f739d5d1b213bf0d728cc01 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13163657051&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 05 Feb 2025 18:41:54 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”> |
||
|
Sagar Khalasi
|
d64eab6369
|
fix: Fix the api_multipart spec test case (#39249)
## Description Fix: Removed the older code to create same name api call on each test and delete on each case which introduce the flakiness. Have improved the code via import app to fix the error for api load issue. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39248 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13306363204> > Commit: 0ee4e2816862117722b3cd96f5c09cca107532fa > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13306363204&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 13 Feb 2025 14:39:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Streamlined API testing by shifting from creating and deleting APIs to selecting existing ones. - Updated the test cleanup process to consistently restore the application’s state. - **New Features** - Introduced a comprehensive configuration that defines the application’s UI, page layouts, themes, and API actions, including enhanced support for file uploads. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Sagar Khalasi
|
ebe465b6eb
|
ci: CI update for commitMsg (#39254)
## Description **Problem**: The Schedule TBP data for both Release and Airgap workflows is currently identical in the database, making it difficult to distinguish between them. **Solution**: Added the workflow name to the commitMsg column, ensuring a clear and accurate view of the data for each workflow. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39253 ## Automation /ok-to-test tags="@tag.SignIn" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13309520198> > Commit: 87d33db158fe9ded6261edd13cf7f89e5e643ab0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13309520198&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.SignIn` > Spec: > <hr>Thu, 13 Feb 2025 14:28:44 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a customizable input to specify the number of test iterations. - Updated test commands to conditionally target specific test files based on provided parameters. - **Tests** - Enhanced test reporting by appending workflow context to commit messages. - Improved workflow tracking with the addition of a variable reflecting the active workflow name. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ayush Pahwa
|
fdf77936eb
|
feat: select widget lazy loading (#38867)
## Description This PR adds capability of server side pagination to the dropdown form component. There is another PR in works to add server side search. To ensure both grouping and pagination work correctly, the dropdown control component is refactored by adding memoization and fixing some rendering issues. Fixes #38079 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13306719132> > Commit: 01f464953b487f2f066af6fe53ae2c79577b7fd3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13306719132&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 13 Feb 2025 12:58:12 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled dynamic pagination for form options, allowing users to load additional choices smoothly. - Enhanced dropdown controls for both single and multi-select modes with improved responsiveness and clearer grouping. - Improved form evaluation processes for a more seamless and performant user experience. - Introduced new functionality for fetching paginated dynamic values, enhancing the overall data handling experience. - Added new function to retrieve conditional output based on form configuration. - **Bug Fixes** - Improved error handling and logging for dynamic value fetching processes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Manish Kumar
|
7764d3df87
|
chore: implementation of artifact type agnostic import (#39237)
## Description - Added implementation for ArtifactType agnostic git import Fixes #`Issue Number` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13305383592> > Commit: bdb5b6515ad365b611831082ee20af327b940687 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13305383592&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 13 Feb 2025 11:38:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Streamlined Git artifact import with a simplified interface for easier repository integration. - Enhanced metadata reconstruction and remote repository management to improve artifact handling. - Advanced Git analytics and error tracking for improved operational insights. - Expanded application lookup via Git integration, offering more robust identification. - New methods for moving artifacts and retrieving artifact types from repositories. - Added support for handling artifact JSON types in Git repositories. - **Refactor** - Updated theme property management for improved internal consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Sagar Khalasi
|
ec4ea27d7d
|
fix: Fix the S3 error case (#39240)
## Description Fix: Changed to aghelper functions and added check for remove all toast message. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39239 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13303544816> > Commit: c4ff7376b95da29b1fce2b0fc342badd189aa350 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13303544816&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Thu, 13 Feb 2025 09:21:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced automated testing for data page generation and user actions, ensuring smoother and more reliable interactions. - Improved handling of notifications for a more consistent application experience. - **Refactor** - Streamlined internal processes for managing data interactions, enhancing clarity and maintainability in testing routines. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
261cf8bfe6
|
fix: loading indicator ui for infinite loading table (#39208) | ||
|
sneha122
|
e71d14bc22
|
fix: move to page redirection issue fixed for paragon integration (#39215)
## Description This PR fixes issue where if we move external saas integration query from page 1 to page 2, redirection to page 2 was not happening. It's been fixed in this PR. This issue was there for remote as well as AI plugin, it's been fixed as well. Fixes #39163 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13286248107> > Commit: 1cae0a7d35772483778126338fee5b4ed1d7f764 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13286248107&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Wed, 12 Feb 2025 14:03:01 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal navigation logic for plugin workflows by replacing multiple conditional checks with a structured approach. The update improves code maintainability without impacting existing end-user functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Sagar Khalasi
|
cdd8034674
|
ci: Update version and checking failure (#39138)
## Description Problem: We see cypress retry happening for the only it block. Due to this we see failed cases always as some cases are dependent. Solution: Updated the workflow with library to retry only failed specs. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39211 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13285964571> > Commit: 9c4fb375775839503a2800eb84bc87a6abc61ac9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13285964571&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 12 Feb 2025 14:31:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated a key dependency to incorporate backward-compatible improvements. - **Tests** - Enhanced the automated testing process with improved error handling and the ability to conditionally execute tests. - Introduced configurable options for test repetition and snapshot updates, ensuring more reliable reporting and feedback. - Improved the logic for commenting on pull request statuses based on CI test results. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sneha122
|
be3809ff7e
|
fix: enable allow clear options for single select dropdown (#39213)
## Description This PR enables allow clear option for single select dropdowns in the UQI. Fixes #39087 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13284739979> > Commit: 36b6c9419e92d1fb3915f039d922b3211e89fc8a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13284739979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Wed, 12 Feb 2025 12:41:11 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the dropdown control to allow users to clear their selection even in single-select mode, offering greater flexibility in interaction. - **Tests** - Expanded test coverage with new tests ensuring that the clear selection feature works correctly in single-select scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Arpit Mohan
|
e878088bbd
|
chore: Updating mysql test dependencies in pom.xml (#39146)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes Dependabot alert. > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /test sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/13236027815> > Commit: 8d7776053f692e42e52ffc037f45df3063d06d1c > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Mon, 10 Feb 2025 07:56:09 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the backend database connector to a newer version, enhancing stability and compatibility during testing. This internal improvement supports smoother operations and sets the stage for future reliability enhancements, though no direct user interface changes have been introduced. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Trisha Anand
|
9aa065b195
|
fix: Scheduling the heavy database ops on bounded elastic thread pool for Ms-sql (#39176)
## Description Production is seeing high number of pod restarts causing downtime. It seems to be correlated with user MS-SQL query triggers. On the hypothesis that its indeed the plugin executions causing this, it could be the datasource create taking up redis thread pool (possibly because of an upstream scheduling of a task on it) Sample log lines displaying the behaviour (only user email removed from the logs) : traceId=bda95acf0e182c48037214d5173d0ac9 spanId=00fdca579a517b66 - boundedElastic-13: datasourceCreate() called for MSSQL plugin. Feb 11 05:38:05 appsmith-d6d86999-6djmx appsmith backend stdout | [2025-02-11 00:08:05,357] [lettuce-epollEventLoop-10-3] requestId=dd547055-d9bc-41ed-b7b4-03b0de691984 userEmail=<> traceId=bda95acf0e182c48037214d5173d0ac9 spanId=00fdca579a517b66 - lettuce-epollEventLoop-10-3: Connecting to SQL Server db Feb 11 05:38:05 appsmith-d6d86999-6djmx appsmith backend stdout | [2025-02-11 00:08:05,381] [lettuce-epollEventLoop-10-3] requestId=dd547055-d9bc-41ed-b7b4-03b0de691984 userEmail=<> traceId=bda95acf0e182c48037214d5173d0ac9 spanId=00fdca579a517b66 - HikariPool-3 - Starting... Feb 11 05:38:15 appsmith-d6d86999-6djmx appsmith backend stdout | [2025-02-11 00:08:15,346] [parallel-2] requestId=dd547055-d9bc-41ed-b7b4-03b0de691984 userEmail=<> traceId=bda95acf0e182c48037214d5173d0ac9 spanId=88ee6f7444f698dc - parallel-2: Action Query3 with id 67aa94d7b95fcb7ea3d5512c execution time : 10002 ms This was possibly brought on by the following PR : https://github.com/appsmithorg/appsmith/pull/38818 As part of the above PR, scheduleOn statement moved from Mono.callable() which creates its own subscription chain to outside. This could be causing the heavy database ops moving to event loop instead of bounded elastic. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /test sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13265007600> > Commit: 3e758fb8bbe536a653228d9d61c59eb0e9f1b0b1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13265007600&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 11 Feb 2025 14:53:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Optimized the connection creation workflow to defer resource initialization until required. This enhancement improves the scheduling and responsiveness of establishing connections, ensuring that system resources are utilized more efficiently during runtime. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Sagar Khalasi
|
c66512e76a
|
fix: check mongo spec 1 fix (#39168)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13258761426> > Commit: 1573f1c6fd3094f475e8ffc21cf1743bb54d7bb0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13258761426&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Tue, 11 Feb 2025 09:27:52 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Simplified content formatting in a test case for generating a MongoDB datasource by using plain text instead of HTML markup. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rudraprasad Das
|
f7cf49fc3a
|
chore: fixing discard message (#39155)
## Description Discard toast issue, introduced in https://github.com/appsmithorg/appsmith/pull/39140 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13240898404> > Commit: f8e760a40de3d8fb8b03ec606903030df6cf0643 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13240898404&attempt=4&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.Git > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Mon, 10 Feb 2025 22:21:53 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated the discard confirmation so users now receive a clear success notification, ensuring more accurate feedback when changes are discarded. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Sagar Khalasi
|
53b8bc8755
|
fix: fix for js visual spec snapshots (#39154)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Visual" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13241157151> > Commit: ff462146f0d032bb8885148e60f39182832f14f3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13241157151&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Visual` > Spec: > <hr>Mon, 10 Feb 2025 13:07:54 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Chores** - Added a comment to the internal testing instructions that does not impact existing functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
fcdf901589
|
fix: Wrong url set for Editor (#39149)
## Description Fixes the wrong url set for Editor CTA in sidebar. This happened during the refactor of Sidebar buttons ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13236899041> > Commit: 9d507db5ecba4d86883240ef7c6023c25c047eed > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13236899041&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Mon, 10 Feb 2025 09:21:06 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the configuration for the top button in the Editor interface to remove its fixed label. This change streamlines the button's display and behavior, offering a cleaner and more intuitive experience in the editor view. The update improves the overall visual consistency of the toolbar while all other interface elements remain unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
02b89b2db1
|
chore: Remove HTML column type feature flag and related code (#39108)
## Description It has been a month since we have turned on the flag for table HTML column type and we have not seen any issues. This PR removes all the feature flags related code from the codebase. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13195811365> > Commit: 7a0f810c1f6a271adad082fc5c8b630b427aea34 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13195811365&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Fri, 07 Feb 2025 09:20:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - The HTML column type now appears as a consistently available option when configuring table widgets. - **Refactor** - The table widget’s architecture has been streamlined for improved modularity and state management, enhancing overall cell rendering. - **Chore** - Legacy conditional toggling for the HTML column type has been removed to simplify configuration and standardize behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rudraprasad Das
|
d199546f1e
|
chore: git mod - fixes toast issues (#39140)
## Description Fixes issue with missing success toast related to git Fixes https://github.com/appsmithorg/appsmith/issues/38872 Fixes https://github.com/appsmithorg/appsmith/issues/38862 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13216997415> > Commit: 95ccaedc4583492a5a6c7b88c6ca8215b2a55807 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13216997415&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Sat, 08 Feb 2025 17:43:52 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Discard operations now display clear, contextual success messages to enhance user feedback. - Toast notifications have been added for pull actions and protected branch updates, providing real-time confirmation of successful operations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
dependabot[bot]
|
3fb7555962
|
chore: bump com.databricks:databricks-jdbc from 2.6.36 to 2.6.40 in /app/server/appsmith-plugins/databricksPlugin (#38245)
Bumps com.databricks:databricks-jdbc from 2.6.36 to 2.6.40. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/appsmithorg/appsmith/network/alerts). </details> <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD e914f84319d1ffd855af7e7d7ec6a12ed50d00a0 yet > <hr>Mon, 10 Feb 2025 07:39:18 UTC <!-- end of auto-generated comment: Cypress test results --> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
Vemparala Surya Vamsi
|
31810996ad
|
chore: remove redundant copies in getWidgetDependencies (#39116)
## Description We are doing excessive copies, this optimisation reduces the overall webworker scripting for configured xolair app by about 218ms (80% reduction in the contribution of getWidgetDependencies). Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13198011721> > Commit: 84bc6bb003fabeb4adac6c49e68ddf0169e519ef > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13198011721&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 07 Feb 2025 13:19:56 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the dependency management logic to initialize and update dependencies in a more efficient and clear manner. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
dependabot[bot]
|
d2160d4487
|
chore: bump net.snowflake:snowflake-jdbc from 3.20.0 to 3.22.0 in /app/server/appsmith-plugins/snowflakePlugin (#38998)
Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.20.0 to 3.22.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/snowflakedb/snowflake-jdbc/releases">net.snowflake:snowflake-jdbc's releases</a>.</em></p> <blockquote> <h2>v3.22.0</h2> <ul> <li>Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <h2>v3.21.0</h2> <ul> <li>Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst">net.snowflake:snowflake-jdbc's changelog</a>.</em></p> <blockquote> <p><strong>JDBC Driver 3.22.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.21.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.20.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.19.1</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.19.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.18.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.17.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.16.1</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.16.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.15.1</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.15.0</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.14.5</strong></p> <ul> <li>||Please Refer to Release Notes at <a href="https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc">https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc</a></li> </ul> <p><strong>JDBC Driver 3.14.4</strong></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |