Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
684 Commits 1 Branch 0 Tags 507 MiB
6630446506
Commit Graph

684 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Arpit Mohan
6630446506 Merge branch 'feature/dynamic-binding-action' into 'release' 
Adding dynamicBinding to Action

Also adding the status code to ActionExecutionResult when plugin returns with an error.

See merge request theappsmith/internal-tools-server!356
 2020-05-26 11:50:09 +00:00
Arpit Mohan
9f82bde92c Adding statusCode from AppsmithPluginErrors when plugins error out 
This ensures that we can always display a status code on the client.
 2020-05-26 11:50:09 +00:00
Arpit Mohan
a569156029 Merge branch 'hotfix/action-error' into 'release' 
Creating the actionExecutionResult object for error scenarios as well.

See merge request theappsmith/internal-tools-server!354
 2020-05-23 07:23:13 +00:00
Arpit Mohan
e6b7ffca9c Creating the actionExecutionResult object for error scenarios as well. 
This ensures that we can populate the request fields for all action executions
 2020-05-23 12:49:01 +05:30
Arpit Mohan
0ee1699603 Merge branch 'bug/datasources-name-clashes' into 'release' 
Use sequences for numbering new datasources.

Introduces a new collection in the database, `sequence`. We intend store one document per domain collection (hence a unique index on `name` field), which has a sequence number. The number is *always* set to a value that can be used next and never been used before (hence the human-readable-name `nextNumber`). Of course, this holds true only if the collection is accessed through `SequenceService.getNext(DomainClass.class)`.

This MR also includes two migrations. One for adding a unique index on `sequence.name`. Another for setting an initial value for the `nextNumber` for datasources, such that the next new datasource has a unique name. We are computing this value based off of the existing datasources named `Untitled Datasource <number>`, finding the highest number in the names and incrementing it.

See merge request theappsmith/internal-tools-server!351
 2020-05-20 11:21:32 +00:00
Shrikant Kandula
7037d99cfa Use sequences for numbering new datasources. 2020-05-20 11:21:32 +00:00
Shrikant Kandula
b13a7a5df3 Fix incorrect call to updatedAt. 2020-05-19 19:25:32 +05:30
Arpit Mohan
eae29e5cba Merge branch 'bug/datasource-without-updated-at' into 'release' 
Fix NPE when using datasources without updatedAt.

Notion ref: <https://www.notion.so/appsmith/NPE-in-DatasourceContextServiceImpl-be9b92a0d71848aea89dd695cd784034>.

See merge request theappsmith/internal-tools-server!348
 2020-05-19 13:48:58 +00:00
Shrikant Kandula
329587f5ff Fix NPE when using datasources without updatedAt. 2020-05-19 13:48:58 +00:00
Arpit Mohan
14c1778645 Merge branch 'bug/curl-auto-add-protocol' into 'release' 
Automatically add protocol to URL provided to cURL command.

Notion ref: <https://www.notion.so/appsmith/CURL-import-for-incomplete-but-valid-URLs-like-www-google-com-leads-to-the-URL-not-getting-read-Th-9191456cb1b24cd68b92072c1a6f3ab6>.

See merge request theappsmith/internal-tools-server!343
 2020-05-19 04:23:59 +00:00
Shrikant Kandula
db0532941d Automatically add protocol to URL provided to cURL command. 2020-05-19 04:23:58 +00:00
Arpit Mohan
85ea6563db Merge branch 'hotfix/server-use-forward-headers' into 'release' 
Adding the ForwardedHeaderTransform bean to enable spring to parse...

Adding the ForwardedHeaderTransform bean to enable spring to parse X-Forwarded-* headers from Nginx proxy

See merge request theappsmith/internal-tools-server!344
 2020-05-19 03:56:40 +00:00
Arpit Mohan
158f5c8203 Adding the ForwardedHeaderTransform bean to enable spring to parse X-Forwarded-* headers from Nginx proxy 2020-05-19 09:22:33 +05:30
Shrikant Kandula
bffd68b1a9 Merge branch 'bug/postgres-empty-result' into 'release' 
Don't fail after executing a non-SELECT query on Postgres.

See merge request theappsmith/internal-tools-server!341
 2020-05-18 13:42:24 +00:00
Shrikant Kandula
54febe1779 Merge branch 'feat/onload-actions' into 'release' 
Added a boolean field to Actions to explicitly mark them for execution on page-load.

See merge request theappsmith/internal-tools-server!332
 2020-05-18 12:13:54 +00:00
Shrikant Kandula
c4d3d535a1 Rename isExecuteOnLoad to executeOnLoad. 
The `is` prefix apparently makes Spring unhappy.
 2020-05-18 12:13:54 +00:00
Shrikant Kandula
c18c344f4b Don't fail after executing a non-SELECT query on Postgres. 2020-05-15 18:13:36 +05:30
Shrikant Kandula
98c38df397 Merge branch 'bug/stale-database-connections' into 'release' 
Destroy connections in stale datasource contexts and create new ones.

See merge request theappsmith/internal-tools-server!338
 2020-05-15 03:26:35 +00:00
Shrikant Kandula
180002a984 Handle errors when destroying stale connections. 
This happens when the stale connection is an invalid connection object,
like when if it's created with invalid credentials etc.
 2020-05-15 03:26:35 +00:00
Arpit Mohan
4fa254a449 Adding error log message whenever an action execution fails because of invalid datasource 2020-05-14 15:26:05 +05:30
Arpit Mohan
a9580effa7 Using the last value of duplicate headers as that is the behaviour displayed by webclient and other clients as well. 2020-05-14 08:49:06 +05:30
Arpit Mohan
cdabc8816b Merge branch 'hotfix/action-execute-duplicate-headers' into 'release' 
Fixing bug where duplicate headers were being set in the action execution result

Also removing empty headers from being sent to the action

See merge request theappsmith/internal-tools-server!337
 2020-05-14 02:50:14 +00:00
Arpit Mohan
71d8812feb Fixing bug where duplicate headers were being set in the action execution result 
Also removing empty headers from being sent to the action
 2020-05-14 08:11:24 +05:30
Arpit Mohan
8d38696b90 Merge branch 'feature/request-body-action-execute' into 'release' 
Request body and header in Action Execution Response

The actionService.execute() flow now sets the request body and header in the action execute response. 
Will help the user debug the action better.

See merge request theappsmith/internal-tools-server!336
 2020-05-14 02:08:46 +00:00
Arpit Mohan
fb9e9fbf4c Request body and header in Action Execution Response 2020-05-14 02:08:46 +00:00
Shrikant Kandula
1c33380820 Merge branch 'chore/rename-should-cache-field' into 'release' 
Rename ActionExecutionResult.shouldCacheResponse -> isExecutionSuccess.

See merge request theappsmith/internal-tools-server!334
 2020-05-12 13:50:56 +00:00
Shrikant Kandula
9c48f42990 Rename ActionExecutionResult.shouldCacheResponse -> isExecutionSuccess. 2020-05-12 18:25:49 +05:30
Arpit Mohan
d2d0805146 Merge branch 'feat/use-unique-name-on-post-datasource' into 'release' 
Automatically use a unique name for creating datasources without name.

In the request from frontend for datasource creation, if the data
doesn't have a `name` value, we now set it to an automatically numbered
value and save with that.

See merge request theappsmith/internal-tools-server!333
 2020-05-12 12:23:23 +00:00
Shrikant Kandula
b65690ec74 Automatically use a unique name for creating datasources without name. 
In the request from frontend for datasource creation, if the data
doesn't have a `name` value, we now set it to an automatically numbered
value and save with that.
 2020-05-12 16:05:29 +05:30
Nikhil Nandagopal
5dad85ff3e Update form.json 2020-05-12 09:48:56 +00:00
Arpit Mohan
f4d79ae25b Merge branch 'bug/curl-error-reporting' into 'release' 
Report error when cURL command is invalid.

See merge request theappsmith/internal-tools-server!327
 2020-05-12 04:12:55 +00:00
Shrikant Kandula
7f4d32e7d4 Report error when cURL command is invalid. 2020-05-12 04:12:55 +00:00
Arpit Mohan
4207de2c53 Merge branch 'bug/add-mongo-auth-type-to-uri' into 'release' 
Auth mechanism is not added to URI in the MongoPlugin. Fixed now.

See merge request theappsmith/internal-tools-server!330
 2020-05-12 04:11:47 +00:00
Shrikant Kandula
f3e448019d Auth mechanism is not added to URI in the MongoPlugin. Fixed now. 2020-05-11 12:16:09 +05:30
Shrikant Kandula
0e2320895c Merge branch 'bug/install-default-plugins-to-existing-orgs' into 'release' 
Migration to install existing default plugins to existing organizations.

See merge request theappsmith/internal-tools-server!326
 2020-05-08 07:12:50 +00:00
Shrikant Kandula
ffc4379a4d Migration to install existing default plugins to existing organizations. 2020-05-08 11:46:13 +05:30
Shrikant Kandula
7673ee49eb Merge branch 'chore/remove-index-annotations' into 'release' 
Remove index annotations as they don't accurately reflect actual indexes

See merge request theappsmith/internal-tools-server!322
 2020-05-08 01:58:43 +00:00
Shrikant Kandula
b8de4ef659 Remove index annotations as they don't accurately reflect actual indexes 2020-05-08 01:58:43 +00:00
Shrikant Kandula
b1a9c40397 Merge branch 'bug/npe-when-curl-command-is-invalid' into 'release' 
Guard against NPE when action is null due to cURL command being invalid.

See merge request theappsmith/internal-tools-server!323
 2020-05-08 01:22:02 +00:00
Shrikant Kandula
2e9a94341b Guard against NPE when action is null due to cURL command being invalid. 2020-05-08 01:22:02 +00:00
Trisha Anand
10f3395d3b Merge branch 'bug/add-timeout-page-actions' into 'release' 
Added timeout in page load actions

See merge request theappsmith/internal-tools-server!324
 2020-05-07 09:57:35 +00:00
Trisha Anand
485eb29e03 Added timeout in DslActionDTO which is used to represent actions inside a layout and in turn is used for page load action execution. 2020-05-07 15:06:16 +05:30
Shrikant Kandula
3e2dea8f84 Merge branch 'bug/hide-exception-class-in-plugin-error-message' into 'release' 
Hide Exception class details in the Plugin error message.

See merge request theappsmith/internal-tools-server!321
 2020-05-05 11:08:38 +00:00
Shrikant Kandula
e99c104fe7 Hide Exception class details in the Plugin error message. 2020-05-05 16:34:09 +05:30
Nikhil Nandagopal
8f95fe22a9 Update form.json 2020-05-05 10:46:58 +00:00
Nikhil Nandagopal
c4f3ccfd8b Update form.json 2020-05-05 10:34:02 +00:00
Shrikant Kandula
bc55baeb1f Merge branch 'feat/add-delete-datasource-perm-existing-groups' into 'release' 
Add `delete:datasources` permission to all existing groups.

See merge request theappsmith/internal-tools-server!320
 2020-05-05 09:19:40 +00:00
Shrikant Kandula
172be7e7e5 Merge branch 'bug/missing-default-database-name-in-mongo-form' into 'release' 
Add missing default database field in Mongo plugin form.

See merge request theappsmith/internal-tools-server!319
 2020-05-05 09:06:32 +00:00
Shrikant Kandula
f7f03c5ad7 Add delete:datasources permission to all existing groups. 2020-05-05 13:52:03 +05:30
Shrikant Kandula
57dc2205e2 Add missing default database field in Mongo plugin form. 2020-05-05 13:39:03 +05:30