Commit Graph

913 Commits

Author SHA1 Message Date
Parthvi12
b82ea06aa3
test: Adding visual tests for layout validation (#9857)
* Adding visual tests for layout validation

* updating screenshot to match CI's screenshot resolution

* updating screenshot as per CI

* setting failure threshold for the image comparision

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-24 17:47:22 +05:30
Paul Li
3d0be06ea1
fix: table filter popup is overlaid on modal (#8540)
* fix: Table widget's filter pop-up does not collapse on opening a modal

-- Dispatch an action for closing the table filter pane when a modal is opened

* fix: Table widget's filter pop-up does not collapse on opening a modal

-- Add the Cypress test case

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-24 18:02:40 +08:00
Ayangade Adeoluwa
45a5c38320
feat: Added tests for renaming entities through the entity explorer (#9867)
* Added tests for renaming entities through the entity explorer

* changes made to deletePageFromSideBar function

* adds custom made test cases config

* test cases should be within smoke test suite

* return configuration to run full test suite
2021-12-24 08:16:08 +01:00
Parthvi12
6cb4590f4f
Added testcases for statbox (#9684) 2021-12-24 09:17:43 +05:30
Bhavin K
244b089771
fix: added support for timePrecision (#9423) 2021-12-23 14:17:08 +00:00
balajisoundar
8d3e3fd88b
fix: remove allowed filetype restriction in filepickerwidget (#9921) 2021-12-23 18:46:57 +05:30
Anand Srinivasan
3a4658c8f5
fix: unexpected return error (#9432)
* assign undefined for empty scripts during evaluation

* add unit tests

* handle anonymous_function when undefined

* update unit tests

* remove unwanted assignments in evaluation scripts

* update unit tests

* Update app/client/src/workers/evaluate.test.ts

* fix lint cypress tests

* remove semicolon

* fix API_bugs_spec

* undo anonymous function change

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* add comment

* return back when JS is empty

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-21 20:00:19 +05:30
Keyur Paralkar
848bc13bc3
fix: corrected Index cond. for conditional formatting in table widget (#9735)
* fix: corrected Index cond. for conditional formatting in table widget

* test: added integration test for checking condtional formating post sorting

* refactor: enhanced the originalIndex condition with nullish coalescing op
2021-12-21 15:25:12 +05:30
Aishwarya-U-R
13f24cbce8
test: Automated tests for Rest Api, S3 Bugs and flakiness fixes (#9695) 2021-12-21 15:07:30 +05:30
NandanAnantharamu
d8e41b4b5c
test: updated org test (#9868) 2021-12-21 13:38:10 +05:30
Parthvi12
293ddc3ea1
adding test cases for undo/redo (#9742) 2021-12-21 10:44:58 +05:30
Arpit Mohan
96677ef673
fix: Updating log4j to 2.17.0 to prevent JNDI lookups (#9863)
Also making minor edit to not show "Application name updated" toast message. This is a counter-productive toast that is distracting the user
2021-12-20 16:01:08 +05:30
arunvjn
99a12be018
feat: add option to delete org (#9287)
Co-authored-by: Nayan <nayan@appsmith.com>
2021-12-20 05:58:01 +00:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
Ayangade Adeoluwa
7af727651d
fix: Assigns query Params in Datasource and Api query editor (#9184)
* adds option to assign query params in datasource and see those params in apieditor

* fix flaky cypress tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:38 +05:30
NandanAnantharamu
4fa39d924d
test: TableWidget bugs (#9795)
* Added tests for Table widget bugs

* typo in test corrected

* Updated a flaky test
2021-12-16 14:52:14 +05:30
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Aman Agarwal
d05b2d5b56
fix: Correcting the run button loading state on cancel in API pane (#9094)
* fix(run-button-loading): the run button loading state changed on cancel

* fix(run-button-loading): added test case for run button loading status
2021-12-14 12:37:42 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
NandanAnantharamu
990ec76c4b
test: Added test for select Widget (#9600)
* Added test for select Widget

* updated common locators
2021-12-13 11:14:01 +05:30
Aishwarya-U-R
fd0f258699
test: Automated tests for RestApi, S3 Bugs (#9539)
* Supressing console.log

* Bugs 5550, 8684 scripted

* Bugs # 9425, # 4775 + S3 failure fix

* S3 failure fixes

* Postgress Delete Ds correted

* Bug # 9334 - Implemented

* onlyQueryRun reverted

* testSaveDatasource reverted

* Mongo Aggregate case fix

* testSaveDatasource updated to test true & false
2021-12-10 12:53:12 +05:30
Paul Li
54579a4e6c
feat: Switch Group widget (#7590)
* Feat: Switch Group Widget

-- The first MVP of the widget

* feat: Switch Group Widget

-- Follow the same config and implementation as the other group widgets

* feat: Switch Group Widget

-- Elaborate the help text for defaultSelectedValues

* feat: Switch Group Widget

-- Add a widget icon

* feat: Switch Group Widget

-- Remove unnecessary property control at ItemsControl.tsx
-- Refactor some code snippets for higher code quality
-- Add basic cypress test cases

* fix: icon for the widget optimised & replaced

* feat: Switch Group Widget

-- Add a unit test for defaultSelectedValuesValidation

* feat: Switch Group Widget

-- Make the validation type for defaultSelectedValues property to ValidationTypes.ARRAY
-- Remove original validation function and its unit test

* feat: Switch Group Widget

-- Fix on typo
-- Fix on formatting issue
-- Change the help text for isRequired property

* feat: Switch Group Widget

-- Revert help text for isRequired property to the original one

* feat: Switch Group Widget

-- Set strict property to true on defaultSelectedValues

* feat: Switch group widget

-- Refactor utility function, getCamelCaseString
-- Add the corresponding test case

* feat: Switch group widget

-- Implement options property as a plain JS field
-- Reimplement update logic for selectedValues when options changes
-- Add a new utility function for checking equality of object arrays
-- Add a unit test for the above function
-- Rewrite the corresponding Cypress test cases

* feat: Switch Group Widget

-- Remove isArrayEqual utility function and directly use functions from lodash

* feat: Swtich Group Widget

-- Make selectedValues as a derived property

* feat: Switch Group Widget

-- Replace the widget icon

* feat: Switch Group Widget

-- Rewrite a test case for onSelectionChange property

* feat: Switch Group Widget

-- Remove redundant calls for openPropertyPane

* feat: Switch Group Widget

-- Remove closePropertyPane call from afterEach hook

* feat: Switch Group Widget

-- Change the selector for every switch element in onSelectionChange test case

* feat: Switch Group Widget

-- Fix on failed Cypress test case, adding closePropertyPane command to onSelectionChange

* feat: Switch Group Widget

-- Remove template literal from a selector

* feat: Switch Group Widget

-- Make click on onSelectionChange test case forced

* feat: Switch Group Widget

-- Fix on crash issue when editing on Options property

* feat: Switch Group Widget

-- Add the widget icon to show in entity explorer

* feat: Switch Group Widget

-- Fix on blue color on mouse down
-- Add a new property for alignment

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-12-09 20:02:47 +08:00
Tolulope Adetula
4829820e86
fix: add enableClientSideSearch (#9505)
* fix: add enableClientSideSearch

* fix: add test

* fix: refactor function

* fix: filter issue

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 22:35:27 -08:00
Aswath K
177df5cc68
fix: table icon selector js mode toggle issue (#9396)
* fix: ARRAY validation with allowedValues

* Adds TABLE_PROPERTY validation

* Add test

* fix: Table icon JS mode toggle issue

* remove unused variable

* Make use of constant for icon

* Adds comment

* better validation

* fix: failed cypress test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 11:45:59 +05:30
Tolulope Adetula
af08547529
fix: Select widget Value (#9444)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 11:14:53 -08:00
Vicky Bansal
3ac913a12c
feat: Row selection in Table widget using Primary Column (#8156) 2021-12-08 19:36:14 +05:30
Bhavin K
4889098888
fix: added placement support in button, button group, and menu widget (#9354) 2021-12-08 13:11:13 +00:00
balajisoundar
ef488f1f7a
fix: Empty column name check before computing dynamicBindingPathList in Table widget (#9466) 2021-12-08 11:24:31 +05:30
arunvjn
f62247b468
feat: Action undo redo (#9045) 2021-12-07 09:45:18 +00:00
NandanAnantharamu
f1c4f03438
Updated test (#9616) 2021-12-07 12:58:27 +05:30
Keyur Paralkar
6e986f9e50
fix: undefined evaluted value text widget (#9521)
* fix: evaluted value undefined for text widget

* test: added cypress spec for cell background and text size change validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-07 10:24:19 +05:30
Arpit Mohan
b5e27aaa57
feat: Adding a SMTP plugin (#8927) 2021-12-07 09:15:15 +05:30
Yash Vibhandik
9b3b1f5196
fix: 7487 added allowSelectAll option in property pane (#9536)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-06 11:26:44 +05:30
balajisoundar
99eb298de7
chore: disable and assert disablility of teletry on CI (#9560) 2021-12-03 23:59:17 +05:30
Tolulope Adetula
5ec470e3c6
fix: selected row issue (#9445)
* fix: selected row issue

* fix: add tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-03 06:15:23 -08:00
albinAppsmith
12e277ad1f
fix: Fold/Unfold fix on click of entity (#8961)
* * fold/unfold fix

* * cypress fix

* * Button style fixes

* * test case fix

* * cypress fixes
2021-12-03 11:54:08 +05:30
Shrikant Sharat Kandula
77caf4c536
chore: Send telemetry option in user profile to client (#9535)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Co-authored-by: sbalaji1192 <balaji@appsmith.com>
2021-12-03 01:56:16 +05:30
Parthvi12
0b8181c229
test: testcases for autocomplete using slash and mustache (#9489)
* Testcases for autocomplete using slash and mustache

* fixed failing tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-02 19:39:50 +05:30
Aswath K
eed6ad9166
fix: empty string validation if required is set (#9476) 2021-12-02 16:45:18 +05:30
Aswath K
cc0ed3b89e
fix: long dropdown popup truncates items (#9187)
* set max-height for Dropdown

* Better height calculation

* address review comment

* removed unecessary assertion

Co-authored-by: Apple <nandan@thinkify.io>
2021-12-02 08:28:51 +01:00
Keyur Paralkar
ba5262df2c
fix: fixed the default value of zero not present in parent form data on pageload (#9324)
* fix: fixed the default value of zero not present in parent form data on pageload

* test: added cypress test for Checking default value 0

* refactor: changed the DSL and added reset condition at the end of test

* refactor: removed the proxy variable

* refactor: corrected the typo
2021-12-02 11:36:24 +05:30
Aishwarya-U-R
37339c0cb1
test: RestAPI parallel run & Debug btn crash [Bugs 5550, 6863, 8686] - Script implementation (#9435)
* Bugs 5550, 6863 - Script implemented

* Added wait time in cy.updateCodeInput

* S3 DeleteSource failure fix

* S3 Delete Ds case fix

* Mongo Failure fixes

* Failure fixes

* Bug 8686 - Implemented

* cypress.json updated

* Added wait for proper validation pass

* Updated

* Updated EvaluateCurrentValue

* Update commands.js

* Added AfterEach

* Updated EvaluateCurrentValue()
2021-12-02 10:50:44 +05:30
NandanAnantharamu
425a46f34d
test: updated filter tests (#9448)
* Filter Tests

* Test spec added

* updated import

* added some wait

* updated the dependencies

* Added the dependancy files
2021-11-30 20:56:37 +05:30
Tolulope Adetula
809a288bdc
fix: popups same width as parent (#7499)
* fix: select widget popup

* fix: select widget

* fix: Menu button

* fix: make Clear Var names

* fix: consistent dropdown width

* fix: define variable better

* fix: prettier error

* fix: variable name

* fix: select popup issue

* fix: PR issues add comments

* fix: remove unused css

* fix: add tests

* fix: more pop overs

* fix: menu button popup

* fix: Multiselect dropdown

* fix: failing test

* fix: add more tests

* fix: Failing Test
2021-11-30 02:38:46 -08:00
rashmi rai
b65258876f
fix: missing number of queries in active datasource (#7694) 2021-11-30 10:11:40 +00:00
Parthvi12
af430d7049
test: testcases for content management system app using echo api (#9420)
* testcases for content management system app using echo api

* added response check method for API calls
2021-11-30 09:28:57 +05:30
Parthvi12
720806574f
test: PgAdminFix (#9313)
* commenting failing tcs for now

* resolving conflict and  fixing testcases

* Update PgAdmin_spec.js

* fixing testcases

Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-11-30 04:54:42 +05:30
Bhavin K
6ea90e7c7b
feat: add document viewer widget (#7666)
* created new widget

* new lib for document viewer

* added cypress tests

* updated icon

* handling different url types with viewer

* add to ignore react-documents in jest transformIgnorePatterns

* added jest test, updated comments

* required changes

* updated cypress test

* updated icon svg

* doc viewer new renderers added

* comment as required

* updated test case

* added url / base64 validations

* updated url checking condition for space and updated test case

* cypress selector update

* updated url validations

* Merge branch 'release' into feature/new-document-viewer

* lazy load external lib
2021-11-29 15:37:49 +00:00
Yash Vibhandik
f6acbf1407
fix: #8530 Added Config for Menu JS Convertible (#8775)
* fix: #8530 updated config for menu color jsconvertible

* test case updated

* yarn lock update
2021-11-29 15:37:05 +00:00
NandanAnantharamu
2a3089383a
updated test flow (#9388) 2021-11-26 12:18:31 +00:00
Tolulope Adetula
f30e389167
fix: Evaluation issue with Button in table Widget (#9356)
* fix: Evaluation issue

* fix: add validation

* revert jest tests changes

* revert cypress test

Co-authored-by: root <pawan@appsmith.com>
2021-11-26 17:03:50 +05:30
Aishwarya-U-R
e5a28b3d9b
test: S3 QueryPane scripting along with possible CRUD flow coverage (#9278)
* S3 QueryPane scritping

* Postgress, S3 - failure fixes

* Postgres, S3 failure fixes

* S3 failure fixes

* Added scrollIntoView for Postgres CRUD failures

* S3 - Suggested&Snipeable widgets implemented

* S3 CRUD - failure fix

* Postgres, S3 CRUD failure fixes

* S3 field inputs corrected

* JQuery empty used to clear fields

* Commenting cases to unblock CI runs

* PgAdmin Spec - commenting failures to unblock CI

* S3, Postgres CRUD failure fixes

* Added Wait for Onboarding spec case failure

* typeValueNValidate - updated

* typeValueNValidate updated

* Reverted typeValueNValidate method trigger change

* Adding wait to typeValueNValidate

* Updated typeValueNValidate with updateCodeInput
2021-11-26 16:17:53 +05:30
Hetu Nandu
8f2935f023
fix: Don't remove bindings when transfering action out of page (#9296) 2021-11-26 14:34:16 +05:30
Hetu Nandu
5d7f68a031
fix: Mute action execution errors when error callback is present (#9366) 2021-11-25 15:28:04 +05:30
NandanAnantharamu
3d495fc548
test: updated locators (#9271)
* updated locators

* updated dsl

* Skipping failing tests

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
2021-11-25 08:55:41 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking (#7361)
* add tailwindcss

* docked property pane

* uncomment a line

* make entity explorer as drawer on unpin

* remove unused imports

* add pin state in  reducer

* add menu icon in header

* fix widget sidebar

* fix widgets sidebar

* style property pane

* update property pane css

* update icons in property pane

* update property pane header styles

* update spacing

* fix few ui issues

* wip: preview mode

* wip:preview mode

* remove unused import

* comments sidebar in app and edit mode

* fix order of import

* use selected state for property pane

* update scrollbar style

* add classes to sidebar and property pane

* make widgets editor fluid

* make widgets editor fluid and refactor logic

* resize the widgets editor if explorer is pinned

* add shortcut for preview mode

* fix link for tabs in edit mode

* zoom in/zoom out for 0.75

* fix chart widget + table widget crashing

* allow zooming of canvas

* fix weird canvas draw issue + update container for handling zoom

* add actions for is panning

* allow panning with grab cursor

* reset panning + zooming when entering preview mode

* add grabbing cursor when grabbing

* only prevent default when space key is pressed

* dont allow zoom in preview mode

* remove unused imports

* fix dont allow zoom in preview mode

* fix ux of panning on space hit

* make fluid as the default app layout

* chart spec

* fix dropdown_on change spec

* fix add widget table and bind spec

* remove draggable property pane spec

* fix container spec

* fix form widget spec

* fix jest test

* fix the function typo

* remove clicking of close button for property pane in cypress tests

* remove property pane actions test

* fix drag and drop test failing

* add cypress selector id to back button in property pane

* fix toggle js spec

* fix merge conflicts from new design system

* editor header

* fix product updates styles + widget card

* remove all unused imports

* fix dynamic layout spec

* fix entity explorer tab rename test failing

* fix table spec

* fix bind tabletextpagination spec

* fix js object spec

* fix entity explorer rename issue

* fix cypress test

* fix cypress command wrong commit

* fix tab spec

* fix property pane copy tests

* add zoom header

* zoom levels

* make property pane sidebar resizable

* add multi select property pane

* fix widget search bug

* update property pane width in state on drag end

* fix viewer header

* fix editor header

* update editor header + remove zooming

* update small style

* dont allow closing of explorer when resizing

* fix jest test

* fix dropdown widget jest test

* preview test case wip

* add entity explorer pinning tests + preview mode tests

* add tooltip in layout control + add padding bottom in property pane view

* incorporate aakash feedbacks

* fix preview mode margin issue

* remove panning code

* fix cypress failing test

* uncomment jest test

* remove redundant code

* fix maincontainer test

* incorporate review feedbacks

* incorporate aakash feedbacks

* review feedbacks

* incorporate review feedbacks

* incorporate qa feedbacks

* fix dynamic layout spec

* updated test based on latest change

* dsl updated

* Updated dsl

* Updated dsl

* resize deselects widget issue.

* fix canvas height issue

* fix typo

* incorporate qa feedbacks

* incorporate qa feedbacks

* incorporate qa feedbacks

* update color for setting control for widget name

* fix onboarding styles conflicts

* Updated tests

* fix application overflow issue

* updated test method

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
Yash Vibhandik
399eabd987
fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name (#8770)
* fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name

* highlighted duplicate column labels, show error message only when duplicate column label focused

* updated test case

* updated duplicate label indicator logic for test case
2021-11-23 11:35:01 +05:30
Pranav Kanade
bffe28361a
fix: Show invite option for substring user emails of other shared users (#8962)
* show invitation option for overlapping email addr string if no exact match is found.

* added test case

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-11-22 10:33:43 +05:30
Parthvi12
ff0222e270
test: PgAdminApp Intial (#9139)
* PgAdminApp Intial

* refactored spec file and adding PgAdminlocators.json file

* updated json file path

* updated locator file

* added comments to the spec file
2021-11-21 14:00:20 +00:00
Aishwarya-U-R
c52e1d9072
test: Intercept/Real DB for Mongo, MySQL & QueryPane with CRUD flow for Postgres (#9081)
* Intercept/Real DB-Mongo,Postgres-Querypane

* Intercept-Mongo, SQL, Query-Postgres

* Added back welcomePage reference
2021-11-18 14:27:51 +00:00
Aswath K
701207718b
fix: Unable to drag disabled button (#8206) 2021-11-18 15:52:04 +05:30
NandanAnantharamu
07a70debd6
Added wait getUser (#9214) 2021-11-17 21:15:48 +05:30
balajisoundar
7978833011
test: first time user onboarding cypress tests (#9171) 2021-11-17 20:58:23 +05:30
Hetu Nandu
91253e8791
Fix issue where widget property evaluation substitution type was overriden (#9191) 2021-11-17 13:57:58 +00:00
NandanAnantharamu
72cce79a36
test: updated createModal util (#9120)
* updated common method

* Updated login route wait

* updated method
2021-11-17 15:40:57 +05:30
albinAppsmith
06ca32cd96
fix: Edit icon in API editor and toggle transition issue (#9013) 2021-11-17 12:06:18 +05:30
Yash Vibhandik
9c751ae58e
fix: #8528 Added default Icon column (#8733)
* fix: #8528 added defaultIconName for controlType ICON_SELECT and updated default value for column type icon button

* test case update
2021-11-16 16:12:20 +05:30
Yash Vibhandik
27d12754c6
fix: 8537 submenu color when disabled (#8948)
* fix: 8537 submenu color when disabled

* updated test case
2021-11-16 16:00:46 +05:30
balajisoundar
f0b781ac63
test: Fix super user signup form cypress test (#8947) 2021-11-16 15:53:05 +05:30
Bhavin K
7032ee6b89
fix: Update designs for select widgets according to Figma (#8594)
* updated design as per figma

* updated design, fix cypress test

* item width fix as required

* label functionality in select, tree-select wids

* changes as required

* label, placeholder and default focused item logic changes for select

* updated border color for invalid selected value

* fix for colors file
2021-11-16 09:27:38 +00:00
Hetu Nandu
429337b5b1
fix: clearInterval action creator adds argument in the wrong slot (#9029) 2021-11-16 09:26:47 +00:00
Pranav Kanade
dcf184b05b
added a fix and test case (#9167) 2021-11-16 12:36:18 +05:30
Paul Li
d700b62ac5
feat: Spellcheck property for the input widget (#8496)
* feat: Spellcheck property for the input widget

-- Add a new widget boolean property, isSpellCheck
-- Add the corresponding Cypress test cases

* feat: Spellcheck property for the input widget

-- Place isSpellCheck property just after autoFocus property
2021-11-12 15:34:10 +08:00
Yash Vibhandik
4b2c1fc316
fix: 8543 added disabled flag support in icon button table widget (#8950)
* fix: 8543 added disabled flag support in icon button table widget

* updated test case
2021-11-11 16:09:21 +05:30
Confidence Okoghenun
014d1f17d6
fix: Disallows entity name to be any extra library name (#8755)
Co-authored-by: sbalaji1192 <balaji@appsmith.com>
2021-11-10 19:29:24 +05:30
NandanAnantharamu
8bc0b0a90d
test: Disable status check for deleteApp step after each test (#9001)
* DeleteApp Status check disabled

* Updated deleteApp status code check to false

* Moved Layout widgets spec to clientside
2021-11-09 17:48:21 +05:30
Aswath K
7570734f23
fix: Unable to group widgets (#9043)
* fix: Unable to group when indexeddb is empty

* Add test for widget grouping
2021-11-09 15:12:07 +05:30
Tolulope Adetula
dbbb7b84b2
fix: disable sorting in view mode (#7387)
* fix: disable sorting in view mode

* fix: add sortable to property pane

* fix: fix failing tests

* fix: Add cypress test

* fix: remove unneccesary useMemo

* fix: sortable columns

* fix: default switch value

* fix: revert switch control and add migrations

* fix: migration
2021-11-08 21:08:39 -08:00
Bhavin K
2956162d7f
feat: new tooltip, updated cypress tests (#8759) 2021-11-03 09:24:19 +05:30
rashmi rai
f56e5dce1a
fix: added try catch in where key handling (#8618) 2021-11-02 15:06:42 +00:00
NandanAnantharamu
8d6e150e00
Added suitable wait (#8946) 2021-11-02 06:34:43 +00:00
Confidence Okoghenun
04bae5477b
feat: Updates widget default state (#8562) 2021-11-02 09:47:49 +05:30
balajisoundar
fd0f3d889a
chore: Comment super user cypress test (#8945) 2021-11-01 16:43:54 +05:30
albinAppsmith
55df317211
fix: API Editor bug fixes (#8803)
* * Confirmation modal fixes

* * header overflow fixed, API editor

* * Delete truncate issue fix
* Tabs count UI fix

* * Removed hardcoded text from component and added in messages

* * removed hardcoded size

* * fixed scroll issue in appviewer

* * eval field fixes

* * design fix for key in API pane

* * fixed test cases
2021-11-01 10:24:06 +05:30
Bhavin Ag
da5baba982
fix: rename no item to no results in select components (#8666)
* style: update no results found style for multi select

* style: update empty data text for multi select widget

* style(SingleSelectTree): update style for no items found

* style: remove minimum width from empty containers

* test: add integration test for tree select

* test: add integration test for empty data for multi select

* test: add integration test for empty states
2021-10-30 23:25:23 -07:00
balajisoundar
baf67a8988
chore: Super user signup form cypress tests (#8665) 2021-10-29 14:40:30 +05:30
Aishwarya-U-R
d3f2f8c04f
test: Generate CRUD implementation - Mongo, MySQL, S3 (#8879)
* Generate CRUD implementation - Mongo, MySQL, S3

* Revertion from intercept to route
2021-10-29 07:02:45 +00:00
rahulramesha
ce453fd259
fix: Copied modal close and mobile modal bug fix (#8497)
* fix for copied widget

* copied modal paste on maincontainer fix

* mobile modal fix

* added logic to paste modal widget on the main container only

* added check only for modal Widget close since the saga seems to be shared for other scenarios
2021-10-28 07:41:19 +05:30
Rishabh Saxena
44116d3c79
feat: persist embed query param in the URL (#8685) 2021-10-27 17:02:26 +05:30
NandanAnantharamu
294032376f
test: lint error/warning tests (#7211)
* Test for lint

* Basic tests for Linting Warning/Error

* Updated tests

* Updated tests

* Updated tests with another lint scenario

* updated test

* Added tests for list and text Widget

* Updated tests

* Updated tests
2021-10-27 12:54:02 +05:30
NandanAnantharamu
b27e3567c6
Updated test (#8811) 2021-10-27 11:38:39 +05:30
NandanAnantharamu
ce26b5bb5f
Commented Delete Test (#8589) 2021-10-26 22:26:26 +05:30
Apeksha Bhosale
4487fee83e
fix: changed dummy actions object (#8510)
* changed dummy actions object

* Snippets for js objects

* added js objects tag

* fixed tests for new changes

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-10-26 18:23:58 +05:30
Anand Srinivasan
9e55ca9ff0
fix: table widget design (#8426)
* Table - multi-select checkbox and selected row color update

* table: change hoverstyle on multi-select checkbox

* re-order conditions

* table widget: use px for positioning checkbox

* change hover style for unselected row

* check box remains white on hover

* fix cypress test

* table search box - highlight on active

* search cancel icon updated

* move svg to assets folder
2021-10-26 14:01:27 +05:30
Tolulope Adetula
3a40b76790
fix: page number reset (#8681)
* fix: page number reset

* fix: add cypress test
2021-10-26 01:12:03 -07:00
Rafael Baldasso Audibert
0e22f26621
fix: Change "Allow Horizontal Scroll" text to "Allow scroll" (#8085)
* chore: Change "Allow Horizontal Scroll" to "Allow Scroll"

* chore: Hide option to choose scroll for pie chart

* fix: Fix prettier errors

* feat: Add migration to allowScroll for `CHART_WIDGET`s

Closes #4227

* fix: Fix chart widget prop recursively

Per https://github.com/appsmithorg/appsmith/pull/8085#discussion_r733442011
Closes #4227
2021-10-25 17:09:39 +05:30
Rishabh Saxena
8dc3fb4951
fix: don't fetch comment threads for anonymous users (#8717)
* fix: don't fetch comment threads for anonymous users

* fix: add wait to public apps test

* proper fix

* var updated

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-10-22 17:10:12 +05:30
balajisoundar
b2c5779234
feat: Introduce a welcome banner and a form to fill in role, useCase for new user (#8312) 2021-10-21 11:06:17 +05:30
akash-codemonk
6347bd9c38
fix: show tooltips for entity names in explorer (#8501) 2021-10-21 10:07:34 +05:30
Rishabh Saxena
31476092cc
chore: refactors for supporting git branches (#7695) 2021-10-18 19:33:44 +05:30
Aswath K
ce4b984e27
fix: unable to change button color on table widget (#8521)
* fix: unable to change button color on table widget

* Adds test for Table button color validation

* removes commented out code
2021-10-14 16:25:03 +05:30
Paul Li
c9c529646f
feat: RTE - option to hide the toolbar (#8271)
-- Add a new widget property, isToolbarHidden
-- Add new Cypress test cases for the newly added property
2021-10-13 18:10:52 +05:30
Aswath K
24b9da6741
fix: change Button variant types constant (#7817)
* change Button variant types constant

* Add migration

* Adds cypress test to validate default button variant

* update the ButtonVariant for MenuButton inside table widget

* Remove only from Button_spec

* fix: Binding issue with Variant in table

* fix: cypress test for default variant validation

* Add validation to IconButton inside table
2021-10-12 08:04:51 +00:00
albinAppsmith
71886c3b9e
feat: Property pane dropdown overflow issues (#8236)
* * hide subtext for date picker fix
* EE clicking on entity, unfolding/folding added

* * bug fixes in action dropdown

* bug fix for cursor

* fix: 8190 background api request and welcome helper button (#8281)

* chore: Move action/js debugger tabs related logic to a common component (#8199)

* removed background of api request textbox and added hover text on "no thanks" button

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>

* fix: added scrolling in invited users more popup (#8226)

* added scrolling in invited users more popup

* always scrollbar displaying on invited users pan

* fixed issue related with 8190

* updated cursor of invited users more

* replace edit data source icon with remix icon (#8192)

* * active text color

* fix: dropdownlist props issue (#8322)

* Commented failing JS tests (#8276)

Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>

* docs: Update ServerSetup.md (#8255)

* Make port customizable from env variable (#8288)

* fix: issue with string templates (#7848)

* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests

* fixed props pass issue

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>

* * bug fixes

* * bug fix

* * test cases fix

* - test case fix

* * test fixes

* * bug fix in test case

Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-11 11:31:05 +05:30
Arpit Mohan
57bdbdc0f9
test: Fixing some cypress tests that were asserting if the message texts are correct (#8369) 2021-10-11 10:38:08 +05:30
Chiradeep-Banik
7af22b96a7
Remove Square bracket notation when using object properties (#7954)
- Replaced with dot-notations
2021-10-09 02:13:43 +05:30
Bhavin K
59af26dd8e
fix: tooltip should hide for a disabled on button widget (#8209) 2021-10-08 19:58:59 +05:30
Vicky Bansal
fdac6428b4
fix: Icon button click should not de-select row in table widget (#8197) 2021-10-08 18:00:12 +05:30
akash-codemonk
9f2c32b9de
fix: onboarding table widget is blank after adding binding (#8285) 2021-10-08 13:22:08 +05:30
Aswath K
b02240cc34
fix: Focus lost when typing on property pane (#8318)
* fix: Focus lost when typing on property pane

* resurrect tests for Radio & CheckboxGroup
2021-10-08 13:09:31 +05:30
balajisoundar
d1efe8405e
feat: Add tooltips for icons in editor (#7711)
fixes: #6759
2021-10-08 12:35:34 +05:30
NandanAnantharamu
470fab30f7
test: S3Crud test fix (#8323)
* added route for a validation

* removed calls which are not happening
2021-10-08 08:32:34 +05:30
yatinappsmith
9ff6c804dc
Commented failing JS tests (#8276)
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
2021-10-07 16:13:01 +05:30
akash-codemonk
30c859180e
chore: Move action/js debugger tabs related logic to a common component (#8199) 2021-10-07 12:23:58 +05:30
yatinappsmith
f900cf9765
test: JSEditor Tests (#8068)
* Added basic support for JSEditor

* Added copy and delete test cases

* Basic changes for js editor

* Basic tests

* JSEditor Binding tests
2021-10-07 07:59:16 +05:30
Favour Ohanekwu
803e5e7cc6
fix: improve dropdown component (#8183)
Improved multipart form's dropdown component
2021-10-06 20:20:35 +01:00
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
NandanAnantharamu
77d1c7ccfc
test: Updated flaky test (#8198)
* Updated flaky test

* updated test

* updated test

* commenting test
2021-10-05 18:39:07 +05:30
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30
Favour Ohanekwu
30d0fb7a6d
fix: Add window object methods and properties as invalid entity name (#7928)
Added window object property and method names to list of invalid entity names
2021-10-04 13:49:58 +01:00
Rishabh Saxena
a69c8b7484
feat: callouts for wip features (#8080) 2021-10-04 13:31:46 +05:30
Pranav Kanade
ca4541a415
updated existing test cases to validate the import export flow with different user permissions (#8099) 2021-10-04 13:04:48 +05:30
Pranav Kanade
b261efc511
fix: skip bot comment when user skips comments tour (#7693)
* setup for skipping the bot comments if user skips the comments tour

* Using the onboarding status api

* removed comments

* fixed typos

* added test cases

* small fixes

* updated the tests

* minor update to a test case
2021-10-01 21:55:55 +05:30
akash-codemonk
48f2c584ab
fix: Fix mismatch between errors in debugger and evaluated value popup (#7752) 2021-09-29 17:33:11 +05:30
Tolulope Adetula
60131403b2
feat: disable parsing link (#7075)
* feat: add disableLink for text widget

* feat: add test for disable link

* fix: email parsing

* fix: test issues

* fix: failing test

* fix: failing test
2021-09-26 23:00:40 -07:00
arunvjn
90fda1ccae
fix: Remove snippet and doc icon from property pane (#7806) 2021-09-27 04:56:39 +00:00
rahulramesha
46f525d365
fix: modal widget issues (#7821)
* fixing modal issues

* adding cypress tests

* patch for modal Issues
2021-09-25 16:45:39 +05:30
Aswath K
8a45e1507e
feat: Add AudioWidget (#7179)
* Create initial version of AudioWidget by copying VideoWidget

* Add EventType for AUDIO

* Change default Audio URL to a podcast related to Appsmith

* Add AudioWidget icon

* Change Entity definition for AudioWidget

* Add cypress test

* Add jest test

* fix: typo
2021-09-24 21:35:53 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
Vicky Bansal
609cdc05e4
feat: Table selected row and action trigger UX improvement (#7310) 2021-09-23 17:16:47 +05:30
NandanAnantharamu
8e6ba37d00
test: fix/Updated common method (#7734)
* Updated common method

* updated dsl
2021-09-23 16:44:01 +05:30
Pawan Kumar
c48cdcdeb4
chore: comment out the moving widget cypress test (#7733)
* comment out the moving of widgets test

* update tests for replay spec

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-22 20:38:03 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
Apeksha Bhosale
ffe00cd1a2
fix: widget refactor actions fetch change (#7574)
* widget refactor actions fetch change

* Added test for binding Button with API

Co-authored-by: Apple <nandan@thinkify.io>
2021-09-21 11:32:30 +05:30
Shrikant Sharat Kandula
c6c5e4fef3
ci: Add CI workflow for building fat container (#7385)
This commit changes the client test workflow into building the fat container's image, and so builds server and RTS as well, in order to achieve that.
2021-09-21 08:33:22 +05:30
rahulramesha
0b37812b56
feat: resizable modal (#7312)
* dip

* resizable modal full working commit

* resizable modal minor fixes

* code restructuring

* fix canvas small size bugs and add migration to remove modal type

* moving resize modal to modal sagas

* layoutResize and last column width

* fix warning

* setResizible if resizing

* fix incorrect import

* fixing cypress tests

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-09-20 22:36:13 +05:30
Nikhil Nandagopal
b9b5d54745
fix: Property pane updates (#7631)
* Renamed TreeSelect Widget
2021-09-20 20:48:10 +05:30
akash-codemonk
9877fe4b05
fix: Switch to the debugger error tab when clicked on the debug button in toast (#7455) 2021-09-20 16:50:22 +05:30
Nikhil Nandagopal
87b13eca2d
fix: Widget Property Pane Updates (#7467)
* reverted previous revert

* standardised widget sizes

* Text changes

* changed default input label style to match default text style

* more messaging tweaks

* minor fix

* Removed dot from the text

* minor fix for form widget

* fixed tests

* minor fixes
2021-09-20 16:13:44 +05:30
Tolulope Adetula
15b26f823e
feat: Tree Select widget (#6271)
* feat: Tree Select

* feat: styling multiselect

* fix: selected values

* fix: remove console statement

* fix: popup position

* fix: selection types

* fix: Form validation using TreeSelect

* feat: Add Label to TreeSelect

* fix: styling

* fix: Dropdown search

* fix: Add Entity Definitions

* fix: Entity Definition

* Feat: Add clear icon

* fix: validation

* fix: options validation

* fix: Styling issues

* fix: build error

* Fix: Separate Tree Select widget

* fix: issues and add validation

* fix: Options Validation

* fix: issues with build

* fix: yarn

* fix: changes

* fix

* Fix: select component

* fix: PR issues

* fix: merge conflicts

* fix: issues

* fix: all issues

* test: added test

* fix: failing test
2021-09-17 02:08:35 -07:00
NandanAnantharamu
1d101300a5
test: fixing the Cypress test for input spec (#7551) 2021-09-16 16:05:02 +00:00
NandanAnantharamu
30d337c9dc
test: Added test for public apps access check (#7525) 2021-09-16 13:44:30 +00:00
NandanAnantharamu
738f5940f2
Updated test (#7535) 2021-09-16 18:19:46 +05:30
Bhavin K
9116c6483f
fix: add check for max char in input widget only applicable for text type (#7250) 2021-09-16 16:32:34 +05:30
ashit-rath
0354fdaa16
fix: Input widget as number type 0 as default value (#7251)
* fix: Input widget as number type 0 as default value

* added cypress test case

* cypress test fix, force click default text input

* updated input widget validation of number/currency/phone number type

* minor change
2021-09-16 11:22:01 +05:30
Yash Vibhandik
aea55014ec
fix: added container wrapper component to handle styles (#6476)
* FIX #2587 : added container wrapper component to handle styles, updated test cases

* FIX #2587 : abstract widget style component for common use and wraped on text widget

* updated style boundary and css

* updated cypress test

* fix: accommodate prop pane height change for the test

* removed properties from text widget

* updated container wrapper style to handle border corners, updated migrations for container and form widget

* fixed container overflow

* added testcases for container and text widget

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-09-16 09:51:31 +05:30
rahulramesha
c4de8fc720
fix: copy paste new widget key generation (#7464)
fixes widgets from having exact same react keys
2021-09-15 19:34:27 +05:30
NandanAnantharamu
1db152bd5c
updated test and common method (#7446) 2021-09-15 14:07:58 +05:30