Commit Graph

1252 Commits

Author SHA1 Message Date
Arsalan Yaldram
9dea163172
fix: show clear input icon on allow clear value (#15232)
* fix: show clear input on allow clear value

* fix: truncate select input on small size
2022-07-27 22:33:05 +05:30
Bhavin K
47cc518dbe
fix: set default on reset of The Tab widget (#15202) 2022-07-27 14:26:16 +05:30
Bhavin K
f45a15545d
fix: depercate form button widget (#14510) 2022-07-22 08:27:37 +00:00
Souma Ghosh
d45a6bfb97
fix: Compact property not functional for menu type in table widget v2 (#15302)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:45:48 +05:30
Souma Ghosh
27e91f8524
feat: Expose message event details for Iframe Widget (#14730)
* Expose message event details for Iframe Widget

* Change meta property name from messageEventProps to messageMetadata

* Cypress test for Iframe Message event details

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:42:57 +05:30
Bhavin K
7ecca954c7
fix: changed the marker(default) value string to number (#15217) 2022-07-20 18:46:06 +05:30
Souma Ghosh
eddd1e8344
fix: Multiselect widget height decreases on selecting more options (#15228)
Fixes issue where multiselect height decreases on selecting more options
2022-07-20 14:26:37 +05:30
Bhavin K
8848d89650
fix: Added the loader in the Button group widget (#15246) 2022-07-20 14:21:54 +05:30
ashit-rath
cb40e04aa0
fix: JSONForm default array item not deletable when default value initialized with undefined (#15205) 2022-07-20 14:07:52 +05:30
Anagh Hegde
dbf0b94973
feat: Update the table widget to v2 in suggested widget list (#15277)
Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-20 12:28:50 +05:30
balajisoundar
71e581d69b
fix: cell background for edit actions column in Table v2 (#15233) 2022-07-20 11:42:59 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
rahulramesha
b878d5bd01
fix: Update maincanvas height on widget resize, drag or delete operation (#14992)
* fix extra space on canvas

* reverting selector changes

* use updated main canvas minheight

* use default canvas minHeight
2022-07-15 15:57:13 +05:30
Souma Ghosh
d40a8fd9f2
fix: Compact property not functional for menu widget (#15090)
Fix compact property functionality for menu widget and menu type in table widget
2022-07-14 17:11:03 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
rahulramesha
4dc3ed481c
fix: modal and App viewer header overlap (#15093)
* modal positions calculations on App View mode

* using css variables to compute modal offsets
2022-07-12 21:13:26 +05:30
Tolulope Adetula
d9d1c0c676
fix: dropdown not closing is fixed (#15058)
* fix: Dropdown issues

* CR fix

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-12 17:20:09 +05:30
Arsalan Yaldram
7c220affd5
fix: selectwidgets clear search input on selection (#14609)
* fix: clear search input on selection

* fix: added comments in single select test case.

* fix: single select tree widget clear search on close

* fix: test cases for mult-select-spec

* fix: clear the filterText on select widget close

* fix: added resetOnClose to select component

* fix: resetOnClose only when serverSideFiltering is off
2022-07-08 18:57:13 +05:30
Keyur Paralkar
170dc193ad
fix: reset selectedFiles meta prop only on specific reason event (#15023)
* fix:
* removed the componentWillUnmount to avoid uppy reset
* added cypress test case

* fix:
* added componentWillUnmount again
* added reason argument to the file-remove handler
2022-07-08 13:32:54 +05:30
Arsalan Yaldram
4a9a05e88c
fix: currencyInput , phoneInput show empty pop when no search result is found. (#14764) 2022-07-07 11:28:19 +05:30
Preet Sidhu
8600201694
fix: App crash on binding large base64 data to text widget (#14782)
* add validation for excessive text length

* add max length as a param

* update max length to 20k
2022-07-07 05:38:24 +00:00
Bhavin K
1ca40f9eeb
fix: show the error message for text input widget (#14934)
* fix: show the error message for text input widget

* Update the error message & added releated new test case
2022-07-07 05:37:54 +00:00
Bhavin K
cc36ae70bb
fix: revert checkbox-group widget breaking UI issue (#14933)
Revert "fix: checkbox-group widget breaking UI issue (#14820)"

This reverts commit 6686b94280.
2022-07-04 14:33:31 +05:30
f0c1s
06ed917f8e
chore: code cleanup - remove extra break (#14672)
## Description

There are some instances of unreachable code, this PR fixes them. And some typos.
## Type of change

- Code Quality Improvement and code cleanup

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-04 09:25:40 +05:30
Rishabh Rathod
8e47219d05
fix: remove debounce from RTE component (#14126)
* fix: remove debounce from RTE component

* fix value change on prop

* Add comment for useEffect order understanding

* fix:
* default text update
* Text re-appearing once deleted

* fix: cursor jump issue

* test: added cypress tests for RTE widget

* fix: isDirty value not updating properly

* chore: added comment for the new useEffect

* fix:
* Changed the logic to include a state inside RTE component
* Added cypress tests

* fix: updating ref on on keystroke events

* fix: suppressed props.onValueChange call on change of default text

* refactor: addressed review comments

* test: fixed failing cypress test

* fix: renamed styles related to label
* added a test case for checking cursor position when in markdown

* test: refacotored test case

Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-04 08:31:16 +05:30
Pawan Kumar
d60ea07e65
The reset button on properties behaves incorrect for JSONForm fields and Table primary columns (#14768)
Reset value in primary columns in table widget and fields in JSONFOrm was not working as expected. This commit fixes that.
2022-06-30 15:52:20 +05:30
Bhavin K
6686b94280
fix: checkbox-group widget breaking UI issue (#14820)
- Hides Style alignment when Inline option is false which fixes UI overlapping issues
- Resizing the widget other options which are outside don't come within the widget boundaries - Fixed
- Behaviour of widget when placed at top of the canvas - Fixed
2022-06-30 11:12:45 +05:30
Aswath K
f895f7bf14
CENTER as default value for vertical alignment (#14888)
Set "CENTER" as default value for Vertical Alignment property instead of invalid value "LEFT"
2022-06-30 09:49:52 +05:30
rahulramesha
f90ce07143
fix: Multi widget selection fixes (#14388)
* rewrite logic for widget multiselect box position and dimension

* logic to select only the widgets on the same canvas while dragging to select them

* fix jest test case
2022-06-29 11:55:26 +00:00
Bhavin K
a2dd01806c
fix: remove the duplicate and rename the actions to events in property panel (#14714)
* Fix: Remove the duplicate & rename the "Actions" To "Events"

* rename the "Actions" to "Events" in select & multiselct widget

* Trigger Build

* fix: failed testcase are resolved
2022-06-29 11:54:50 +00:00
Rishabh Rathod
5625784829
fix: reset meta to default value (#14468)
* fix: [WIP] reset meta to default value

* refactor

* fix reset child widget and type in metaReducer

* Fix type and refactor test

* fix multiselect click

* Add jest test for reset widget action

* Add cypress test

* Add comments

* Add more cases as per comment

* remove `only` from test case

* Add default value case of array with values

* MultiSelect spec fix

* fix currencyInput reset

* refactor test code suggested in comments

* fix type

* fix more type

* fix cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-25 11:00:54 +05:30
albinAppsmith
fcbcec751d
feat: Design System package & Tooltip integration (#14547)
* Added Appsmith Design System Package
* Removed tooltip from ADS folder
* Changed imports for Tooltip

* added alias for the @appsmithorg/design-system

* fix for npm aliasing in jest

* design system package version change to beta 1.0.1-beta.8

* Tooltip Position type changed to PopoverPosition

* design system package updated
2022-06-24 19:53:02 +05:30
Bhavin K
1c09031115
fix: the random month showing issue in datepicker widget (#14472) 2022-06-24 12:15:05 +00:00
Arsalan Yaldram
b4347b44e1
fix: menu button icon alignment fixed. (#14644) 2022-06-24 00:59:07 +05:30
Arsalan Yaldram
932ff31a68
fix: container gap with wrapper on border radius (#14530) 2022-06-23 23:25:03 +05:30
rahulramesha
07ded0dacc
feat: Deprecation warning message update to reference the widget that is replacing it (#14532)
* reference replacement widget in the deprecation warning message

* updated import path for messages

* adding test case for validating deprecated widget COnfig
2022-06-23 20:39:00 +05:30
Tolulope Adetula
7ba4f0679a
Merge pull request #13129 from appsmithorg/fix/12161-multiselects-broken-in-modal
fix: Popover in Multi select widget inside modals breaks away from the widget
2022-06-22 09:59:00 +01:00
ashit-rath
5a7940ae2b
fix: JSONForm - Generate Form button apply theme on new fields (#14687) 2022-06-22 14:21:53 +05:30
Bhavin K
f218642fc5
fix: show the error message in input widget (#14460) 2022-06-22 06:09:50 +00:00
Tolulope Adetula
31f91f6e1c fix: use ESC to close dropdown 2022-06-22 01:11:29 +01:00
Bhavin K
3edfa32d93
fix: the rating widget breaking on dropping issue(#14509) 2022-06-21 16:31:05 +00:00
Arsalan Yaldram
f58451aa5f
feat: upgrade to create react app 5 (#14000)
* Updated Typescript types.

* Typefixes after merge with release.

* chore: GenericApiResponse Removed alltogether.

* chore: resolved ApiResponse unknown errors removed PageListPayload.

* Added shouldBeDefined.

* fix: Resolved type errors.

* fix: Typescript upgrade to 4.5 and type fixes.

* feat: upgrade to cra 5

* feat: uncomment service worker registeration

* force secure websocket protocol

* jest test fixes

* fix: react function lint rule removed

* fix: klona test case.

* fix: typescirpt issues resolved

* fix: timeout for colorpicker test and change env.

* feat: update client-build.yml file

* fix: remove brotliplugin use compression plugin

* fix: build config fixed

* fix: upgrade webpack plugin

* fix: add branchbutton test to todo.

* fix: remove branch button test.

* fix: Add tailwind theme values, fix cypress tests

* fix: Typescript type fixes.

* feat: run jest tests in silent mode

* fix: cypress rgb values add branchbutton jest test

* fix: review comments, fixes for error.message

* fix: increase cache size for the workbox

* fix: remove OrgApi.ts file

* fix: cypress.json file remove credentials

* fix: downgrade react and react-dom packages

Co-authored-by: rahulramesha <rahul@appsmith.com>
2022-06-21 19:27:34 +05:30
Tolulope Adetula
2c6054f72d Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-20 07:01:19 +01:00
Aswath K
bd33b76c1d
feat: widget fuzzy search (#14464)
* widget fuzzy search POC

* fix threshold

* Makes fuse to initialize only once

* add proper dependancy to useEffect

* Adds more search terms

* Adds search term for other widgets

* reduce distance for better search results
2022-06-17 08:42:47 +05:30
Pawan Kumar
a38f484ede
fix: In Table widget for button/icon/menu type when Button Color is selected as Theme color and we toggle JS {{or}}}} is displayed (#14492)
* fix table widget color picker bug

* fix table widget color picker bug

* fix font issue on navigating to edit mode from view mode

* code review feedback
2022-06-16 16:46:05 +05:30
Tolulope Adetula
ddaf283f00 fix: add code comments 2022-06-09 13:50:17 +01:00
Tolulope Adetula
3d7d8911fd fix: more refactoring 2022-06-09 10:31:02 +01:00
Tolulope Adetula
909bbf0585 fix: remove console statements 2022-06-09 10:20:35 +01:00
Tolulope Adetula
2c46d42311 fix: CANVAS_SELECTOR 2022-06-09 09:56:31 +01:00
Tolulope Adetula
1f0c38bbf4 fix: remove template literals 2022-06-09 09:41:16 +01:00
Tolulope Adetula
b77870a6ba Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-09 09:39:49 +01:00
Tolulope Adetula
bd4632abd6 fix: refactor code 2022-06-09 09:38:08 +01:00
balajisoundar
265ed0dc25
fix: Improve cell overflow check logic when switching between table page (#14095)
* fix: Improve cell overflow check logic when switching between table page.

* Table locators update

* Migration spec - locators update

* Migration spec locators update

* MongoDBShoppingCart spec locators update

* POstgress Spec locator fix

* Adding wait!

* Mongo DBcart spec fix

* EchoApiCMS_spec locator update

* Table locators update

* updated locators

* Added delay

* Hidden column fix trial

* Adding refresh page

* Adding time

* Fix cypress xpaths

Co-authored-by: bhavin <techbhavin@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
2022-06-08 21:59:31 -07:00
Tolulope Adetula
665aec5d61 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-08 11:21:01 +01:00
Tolulope Adetula
3a331558ff fix: remove dead code 2022-06-08 11:17:49 +01:00
Tolulope Adetula
22db2edf42 fix: TreeSelect 2022-06-08 10:57:53 +01:00
ashit-rath
3adbb8736f
feat: Rich Text Editor enable browser spellcheck (#13886)
* feat: Rich Text Editor enable browser spellcheck

* fix: added custom menu

* add function for OS check, updated text based on OS

* fix: text update

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-06-08 14:35:35 +05:30
Tolulope Adetula
ab998cfe55
fix: Cursor pagination in list widget (#14206) 2022-06-08 13:06:21 +05:30
Bhavin K
144c999d1c
fix: updated css clash with tree select (#14343) 2022-06-08 07:22:53 +00:00
Tolulope Adetula
0d4f8a0b3f Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-08 06:33:35 +01:00
Tolulope Adetula
1680df92c7 fix: for MultiSelect 2022-06-08 06:32:28 +01:00
Bhavin K
8c40098975
fix: added hover css for indeterminate checkbox (#14194) 2022-06-03 19:16:31 +05:30
Pawan Kumar
78e6bcf7ad
fix: Theming UX Changes (#13741)
* update color control ux

* add reset theme option

* remove the console

* update theme card

* update icons + text for reset

* update button size

* fix cypress tests

* fix cypress tests

* fix flaky git tests

* incorporate ashit feedback

* fix cypress tests

* fix color button in theme panel

* fix reset theme logic + jest tests

* fix button styles reset issue in json form

* add cypress test for theming reset

* incorporate ashit feedback

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-03 15:55:38 +05:30
Bhavin K
543ce339e3
feat: Added Tooltip for icon button widget (#14131) 2022-06-02 15:14:26 +05:30
Tolulope Adetula
6108d6fd1d Fix: Disable scrolling when dropdown opens 2022-06-01 14:42:16 +01:00
Bhavin K
1a3eafb182
fix: update error highlight border in RTE widget 2022-06-01 17:41:25 +05:30
Aswath K
b83058b391
Name not getting focused on adding new modal widget (#14205) 2022-06-01 17:01:48 +05:30
Bhavin K
95e6b4fb98
fix: switch group added check for inline width (#14190)
* fix: switch group added check for inline width

* SwitchGroup inline cypress test added

* New snaps to match CI run

* Adding right images for CI run

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-01 00:13:32 +05:30
Tolulope Adetula
b22975f6db fix: PR review 2022-05-31 15:21:46 +01:00
Tolulope Adetula
af17e7b8fd Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-31 11:53:20 +01:00
Tolulope Adetula
e1301dc18b fix: remove autofocus 2022-05-31 11:52:39 +01:00
Tolulope Adetula
17ec737977 Revert "fix: popup issues"
This reverts commit 9a8bb35809.
2022-05-30 23:12:04 +01:00
Tolulope Adetula
d07d8f8a5d fix: PR review 2022-05-25 13:11:43 +01:00
Bhavin K
1760e8150c
fix: checkbox, switch property fields update, migration added (#13997) 2022-05-25 17:03:33 +05:30
Arsalan Yaldram
b266dd47d3
Merge pull request #13585 from appsmithorg/fix/table-bindingPathList
fix: table derived bindingList error.
2022-05-25 15:42:05 +05:30
ashit-rath
6d591c49b9
fix: JSONForm Select field validate empty string as an invalid value (#13993) 2022-05-25 15:34:50 +05:30
Rishabh Rathod
cbce8f8b8e
fix: trigger consuming previous evaluated values (#13084)
We are changing how we maintain meta values in our architecture,

Earlier metaHOC component state was used to store meta values that were debounced and pushed in batch to metaReducer and trigger evaluation.
We remove the metaHOC state and directly update values to metaReducer and trigger evaluation separately via a debouched function.
2022-05-25 15:16:14 +05:30
rahulramesha
a2688bb4da
feat: Add deprecation warning badge to deprecated widgets (#13381)
This Change also introduces, isDeprecated flag to widget config, when true will add the warning to the widget's propertyPane.
2022-05-25 09:38:32 +00:00
Tolulope Adetula
9a8bb35809 fix: popup issues 2022-05-24 23:35:42 +01:00
Tolulope Adetula
806b212380 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-24 22:46:15 +01:00
Arsalan
6bc68c0327 Merge branch 'release' into fix/table-bindingPathList 2022-05-23 10:41:03 +05:30
ashit-rath
76536124f8
fix: JSONForm modify source data object to null causes crash (#13966) 2022-05-20 13:46:45 +05:30
Maulik
7ccc541fbf
fix: update placeholder for phone input widget (#13635) 2022-05-20 10:41:58 +05:30
ashit-rath
f6d726b2a1
task: JSONForm footer should always stick to bottom when fixed footer enabled (#13904) 2022-05-19 13:07:59 +05:30
Bhavin K
33d8347193
fix: handle selectedValues value (#13887) 2022-05-19 12:41:54 +05:30
Satish Gandham
8dc9c0b017
feat: Optimize create uneval tree via memoization (#13476)
* - Memoize the expeinsive parts of createUnevalTree

* - Split the generateDataTreeWidget and memoize the expensize part
- Remove stary console statement in MultiSelectWidget

* - Some debugging code, needs to be removed.

* Debugging in progress

* Still debugging

* Still debugging

* Working??

* Jest tests passing, and fast enough

* remove unused imports

* One failing jest test, testing luck with cypress

* Remcoe console statment from jest test

* - Sync with release.
- Comment failing jest test

* Disable a test

* - Clean up

* Final cleanup and documentation

* - Make function and variable names accurate and easy to understand

* Update code comments

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-05-18 10:51:53 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows (#13257) 2022-05-18 04:46:25 +00:00
Tolulope Adetula
a956ff6d71
Merge pull request #13793 from appsmithorg/fix/select-widget-filtering
fix: Select widget filtering
2022-05-16 05:17:43 +01:00
ashit-rath
e44aecfe85
fix: JSONForm missing theming accent color property and few JS enabled controls not access sourceData/formData properties (#13817)
* fix: JSONForm missing theming accent color property and few JS enabled inaccessible sourceData/formData properties

* reverted adding of customJSControl JSON_FORM_COMPUTE_VALUE for exisiting properties

* minor revert

* minor fix
2022-05-13 19:53:23 +05:30
Bhavin K
dabca5aac5
fix : prevent dragging when resizing (#13600) 2022-05-13 11:26:09 +05:30
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Tolulope Adetula
379ce6cf5c fix: Select widget filtering 2022-05-12 12:31:45 +01:00
Arsalan
b0e4f099bc fix: return undefiend when propertiesToUpdate is empty array. 2022-05-12 14:15:50 +05:30
Arsalan
8fa294ae49 Merge branch 'release' into fix/table-bindingPathList 2022-05-12 11:40:52 +05:30
Pawan Kumar
2dacdec880
fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas (#13608)
* fix tab widget scrolling + text widget font control overflowing issue

* revert text widget changes

* tab widget scroll issue

* remove border radius and box shadow from v1 widgets
2022-05-11 10:23:13 +05:30
Tolulope Adetula
10aca0297f
Merge pull request #13275 from appsmithorg/fix/disable-cancel-button-on-a-disabled-select-widget
fix: disable cancel button on a disabled select widget
2022-05-11 03:55:52 +01:00
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled (#13520) 2022-05-09 17:34:49 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget (#13605)
* refactor: removed the duplicate style properties for the list widget

* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
ashit-rath
a715c0eefa
fix: JSONForm Phone number field required validation (#13525)
* fix: JSONForm Phone number field required validation

* PR review suggestion change
2022-05-09 14:59:53 +05:30