Commit Graph

2889 Commits

Author SHA1 Message Date
vicky-primathon.in
c42839180e Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-21 21:25:19 +05:30
Hetu Nandu
4d73e7e0b3
Widget validation for nested property paths (#3947) 2021-04-21 20:04:25 +05:30
Nikhil Nandagopal
a13fe4369e updated the default table data to guide users to connect a datasource 2021-04-21 16:10:45 +05:30
Satish Gandham
f7794495d7
Fix Map Widget crash #3843 (#4031)
* Fix map method being called on undefined varaible in MapComponent #3843
Sentry Issue: APPSMITH-N5

* Add type to marker property #3843

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-04-21 14:55:35 +05:30
Hetu Nandu
6c681ef98c
Fix initial value check for action form config (#4080) 2021-04-21 13:18:24 +05:30
Vicky Bansal
318cb78464
Escape line break characters when exporting table data to CSV (#3757) 2021-04-20 16:17:06 +05:30
Trisha Anand
eeaa26a7cc
Type migration from String to Object for plugin specified templates to preserve boolean and any other future data types (#4053)
* WIP : Type migration from String to Object for value

* Migrating config from string to boolean for prepared statement.
Handled error for already stored actions where PS config is stored as String and not Boolean.
2021-04-20 16:09:48 +05:30
dependabot[bot]
ff3c5cf37f
Bump ssri from 6.0.1 to 6.0.2 in /app/client (#4060)
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-20 15:59:30 +05:30
NandanAnantharamu
302181bf48
WIP: Added new test for Text widget (#3953)
* Added new test for Text widget

* Added tests for text widget property panes

* updated tests
2021-04-20 14:29:52 +05:30
Apeksha Bhosale
333c4169eb
name can't be read from empty object (#3958) 2021-04-20 12:26:30 +05:30
NandanAnantharamu
256f64aefc
Removed test for collapse/open Property pane (#4059) 2021-04-20 11:28:30 +05:30
Apeksha Bhosale
568269e8e1
size change for raw and editor in API editor (#3984)
* size change for raw and editor in API editor

* removed from global css file

* removed classes
2021-04-20 11:13:26 +05:30
Apeksha Bhosale
f509f1b50b
datasource edit should be always enabled (#3979) 2021-04-20 11:12:25 +05:30
vicky-primathon.in
385011daa0 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-19 22:17:20 +05:30
Hetu Nandu
59ad172d81
Hot fix redirection race in oAuth autorisation flow (#4052) 2021-04-19 18:47:27 +05:30
vicky-primathon.in
faaf2e3345 Scroll should not be required for header in default table 2021-04-19 17:02:31 +05:30
vicky-primathon.in
934563a154 Removed background from selected dropdown item in table widget filters 2021-04-19 13:32:23 +05:30
NandanAnantharamu
1c10279945
Updated profile tests (#4002) 2021-04-19 13:31:05 +05:30
Trisha Anand
eaa24ca894
[Bug Fix] : Fetch actions by id during refactor action name to solve IncorrectResultSizeDataAccessException for pages where duplicate action names exist (#4030)
* New dto for refactoring action name which includes actionId as well

* Refactor action name now also takes actionId as payload and fetches the action from db by id instead of name to solve for the scenario where the action names could be duplicated.

* Adding actionId to QP of action refactor API.

* WIP : test for asserting the bug fix

* WIP test

* Fixed the test case asserting refactoring works for an action when there are duplicate action names in the page.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-04-19 12:35:10 +05:30
vicky-primathon.in
2b8ab8dc8f Align page number text in table pagination 2021-04-19 11:12:18 +05:30
vicky-primathon.in
7a9dfb2066 Fixed table image cell alignment
Added cypress test to validate image cell alingment
2021-04-19 10:31:17 +05:30
vicky-primathon.in
15521fef06 Fix horizontal scrollbar 2021-04-19 09:02:47 +05:30
NandanAnantharamu
812e73a881
Basic DS test scenarios (#4026) 2021-04-16 16:08:41 +05:30
vicky-primathon.in
89af3501aa Removed vertical scroll bar from table header 2021-04-15 16:37:54 +05:30
Trisha Anand
9b49308abe
Adding dependency relationship to plugins (#3997)
* Added dependencies to be added to dependencyMap on client to Postgres, MSSQL, MySQL and Mongo plugins

* Added Dependency config for API

* Fixed the test case
2021-04-15 11:36:41 +05:30
vicky-primathon.in
c8c0ca929e fix 2021-04-15 11:12:45 +05:30
vicky-primathon.in
a3d74c692a removed unnecessary tests 2021-04-15 11:06:03 +05:30
vicky-primathon.in
f46beeb4c6 Reverted changes to ScrollIndicator file name 2021-04-15 11:03:09 +05:30
vicky-primathon.in
99ea7db01b Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-15 10:44:46 +05:30
vicky-primathon.in
d224f2921d Fix scrollbars 2021-04-15 10:31:06 +05:30
NandanAnantharamu
3a52f51af0
WIP : Updated test for page spec (#3749)
* Updated test for page spec

* Updated test for pages with widget

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-04-14 13:44:06 +05:30
vicky-primathon.in
1e6a0e8e92 Fix filepicker widget delete file not working
Added cypress test case to test selected file deletion works
2021-04-13 16:55:50 +05:30
Vicky Bansal
4778b0a450
Fix Table column names allowed to have spaces when editing in property pane panel titles (#3869)
Added cypress test to validate name formatting
2021-04-13 16:33:13 +05:30
vicky-primathon.in
3dc6e0884d Added cypress test case to test multi selected dropdown options are cleared in form reset 2021-04-12 13:07:05 +05:30
Vicky Bansal
d6399c2e48
Disable pagination controls when the table has a single page (#3895)
* Disable input number field when there are no pages to navigate to

* Added cypress test to validate table pagination is disabled
2021-04-09 16:06:50 +05:30
Vicky Bansal
791e8195b1
Align column headers when aligning columns (#3885)
* Align table column header title with table columns

* Added cypress test to validate column header text alignment
2021-04-09 16:04:01 +05:30
Vicky Bansal
43720123d8
Fix: Select Table Widget when a row is selected (#3871) 2021-04-09 16:03:22 +05:30
vicky-primathon.in
53d1333530 use derivedProperty selectedIndexArr instead of computing selectedIndexes 2021-04-09 15:50:48 +05:30
vicky-primathon.in
1db50eb527 Custom scrollbar changes 2021-04-09 12:34:31 +05:30
Rishabh Saxena
d8f2211b70
Fix edit and fork buttons visible simultaneously on the viewer header (#3723) 2021-04-08 14:12:13 +05:30
Kaushik Varanasi
c37adc0a4d
Fix spacing of fields in org settings: fixes (#3612) (#3681)
* add row colums styling to organisation settings fields

* add tests to make sure the grid layout is rendered

* added margin to make spacing look similar to before

* remove negative margin and reduce width

* added jest tests to make sure component mounts and that it has correct styles

* revert unnecessary changes related to cypress tests

* added strict checking for null to avoid ts errors

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* fixed typo

* added findbytext for sync call

* removed unused imports

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-08 11:20:26 +05:30
Trisha Anand
df993efcde
Updated the DSL to change primary columns for an array to a map structure in the DSL (#3905) 2021-04-07 18:22:52 +05:30
Hetu Nandu
28995e5b53
Fix PS and smart substitute true false value (#3896) 2021-04-07 16:06:17 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
NandanAnantharamu
547a9a7ee0
Added tests for Oauth and Stubbed tests (#3463)
* Added tests for Oauth and Stubbed tests

* updated tests

* test updated

* updated DS tests

* review comments incorporated

* flag removed

* postinvite stubbed

* intercept req added and chromewebsecurity flag added

* Update app/client/cypress/support/commands.js

* updated header request

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-06 18:59:27 +05:30
vicky-primathon.in
b2ab89c2c5 add react custom scrollbar types 2021-04-06 17:01:52 +05:30
Hetu Nandu
8bdc491a81
Hot fix for plugin form not downloaded for onboarding (#3879) 2021-04-06 15:47:25 +05:30
Rishabh Saxena
d13f755ba8
Update GTM script (#3711) 2021-04-05 20:54:22 +05:30
NandanAnantharamu
8cd6c95e70
updated table property pane test (#3837)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-05 17:25:27 +05:30
Apeksha Bhosale
48790ce6ca
Array support hidden field (#3809) 2021-04-05 15:41:04 +05:30
vicky-primathon.in
a24f8ae6ae Added react-custom-scrollbars 2021-04-05 14:52:55 +05:30
Kaushik Varanasi
8f8b7b281f
Fixes error on failed github docs fetch (#3665)
fixes #3551
2021-04-05 14:07:04 +05:30
Vicky Bansal
6b26e400a8
Bug fix for table crash #3645 (#3849) 2021-04-04 01:10:12 +05:30
Hetu Nandu
af5f6544ea
Always guarantee to fetch Api plugin forms (#3847) 2021-04-02 15:17:37 +05:30
Rishabh Saxena
244930dd69
Add support of component unit testing (#3828)
Update jest config, add msw hooks
2021-04-02 15:17:16 +05:30
Abhinav Jha
28921e0324
Fix table width on drag (#3839) 2021-04-02 13:48:30 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Arpit Mohan
91a7acea49
Adding table plugin in the Rich text editor (#3799)
* Add Table button in RTE Toolbar

Co-authored-by: Aswath K <aswath.sana@gmail.com>
2021-04-01 13:54:42 +05:30
dependabot[bot]
68e405a746
Bump y18n from 4.0.0 to 4.0.1 in /app/client (#3817)
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-01 10:39:29 +05:30
Apeksha Bhosale
1f216167c4
removing new lines while showing url path field (#3717)
* added 2 states for path field

* added logic for compact only

* added small condition for no compact

* PR comments fixed

* removed redundant code

* added unit test for code editor functions

* Update app/client/src/components/editorComponents/CodeEditor/index.tsx

* setting cursor

setValue is resetting cursor position to the front.  so will update at the end

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-03-31 17:58:29 +05:30
Apeksha Bhosale
834fc3caf7
showing save datasource option all time (#3695)
* showing datasource

Exposing 'save as datasource' with empty path but in disable state till value is entered

* sending flag instead of value

* removed classname

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-31 16:09:13 +05:30
Rishabh Saxena
7ffc0d3786
Ignore cypress/no-unnecessary-waiting (#3794) 2021-03-31 14:05:19 +05:30
Hetu Nandu
0c77051944
Improve performance monitoring (#3790) 2021-03-31 13:10:59 +05:30
Ashok Kumar M
3bce03173a
Fix: Property pane improvements and bug fixes (#3766)
* Fix: Propane improvements bug fixes

* Adding plus indicator for New modal action.
2021-03-31 11:21:24 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Abhinav Jha
10159fc442
Fix #3752 DatePicker tries to auto parse the defaultDate (#3753) 2021-03-30 14:32:25 +05:30
Hetu Nandu
aec7e613ad
Update dropdown font size and shadow (#3680) 2021-03-30 14:18:14 +05:30
Ashok Kumar M
984fbecac5
Fix: Adding debounce for renaming tabs. (#3758) 2021-03-30 13:44:25 +05:30
Pawan Kumar
d8b9b8e918
Fix: TypeError: e.widgetName is undefined and TypeError: Cannot read property 'toUpperCase' of undefined (#3694)
* call toUpperCase() only when widgetName exists

* use lodash instead of string class functions

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-03-30 11:20:00 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
dependabot[bot]
b4b903278c
Bump lodash-es from 4.17.11 to 4.17.14 in /app/client (#3738)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-30 10:38:34 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 21:17:22 +05:30
Rishabh Saxena
3f55e16b35
Fix onboarding test spec: check res instead of req to verify if the datasource was created successfully (#3747) 2021-03-29 19:51:50 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)"
This reverts commit 3437c16ef0.
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 15:28:52 +05:30
Apeksha Bhosale
8983940a30
Merge pull request #3659 from appsmithorg/fix/new-field-POST-change
Added index check to add content type in existing field
2021-03-29 15:26:03 +05:30
Hetu Nandu
55f65a9fe5
fix default override same value (#3691)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2021-03-29 12:44:16 +05:30
vicky-primathon.in
b153a0e78a Show header scrollbar always if needed 2021-03-27 11:36:42 +05:30
Nidhi
683176fc48
Increased default limit for webclient payload (#3718)
* Increased default limit for webclient payload
2021-03-26 21:34:10 +05:30
prapullac
d9417dc043
Adding test ideas for Switch widget (#3490)
* adding test ideas for Switch widget

* reset  widget for date change
2021-03-26 14:08:10 +05:30
Apeksha Bhosale
84ebd4324f
Updated link for datasource whitelist url (#3679) 2021-03-26 13:41:15 +05:30
prapullac
cee1b86f32
Adding test ideas for Edit profile (#3700) 2021-03-26 12:51:46 +05:30
Rishabh Saxena
973a70a624
Fix editor help menu background color and icon size (#3686) 2021-03-26 12:18:15 +05:30
Apeksha Bhosale
eab1f8372a Merge branch 'release' into fix/new-field-POST-change 2021-03-26 09:33:52 +05:30
abhishek nayak
5114ca75c4
Merge pull request #3706 from appsmithorg/fix/filteredData-columnProperties
Fix #3381: Table column properties now map correctly when filtering, sorting or searching
2021-03-26 01:30:03 +05:30
Abhinav Jha
5b3547c104 Fix filter condition functions
Fix issue where column properties don't update based on filters and sorting and search
2021-03-26 01:18:40 +05:30
vicky-primathon.in
ea701de662 Added unit tests 2021-03-25 23:58:09 +05:30
vicky-primathon.in
45d7a5fe0b Added unit tests 2021-03-25 23:46:56 +05:30
vicky-primathon.in
b6f21b00e0 Added unit tests 2021-03-25 23:28:51 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
vicky-primathon.in
e79f6c8806 Fix horizontal and vertical table scrollbars
Hide scrollbars during resize
2021-03-25 21:46:22 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests (#3501)
* added test with switch widget within farm widget

* Added another usecase with Switch

* added wait

* updated locators

* minor update

* add locators for switch widget spec

* removed waits and replaced with suitable assertions

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-25 21:38:16 +05:30
NandanAnantharamu
378330815b
Added test for tableWidget bug (#3528)
* Added test for tableWidget bug

* updated test

* review comment incorporated

* updated collapse pane test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 16:31:51 +05:30
Rishabh Saxena
f2160d61e1
Fix onboarding Cypress test (#3678) 2021-03-25 13:23:56 +05:30
Apeksha Bhosale
4c464787a1
code folding in response and request (#3658) 2021-03-25 10:57:00 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670)
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string (#3397) 2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-24 14:33:48 +05:30