6001bef04a
8402 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
ashit-rath
|
1fbfb28abf
|
chore: reset entities reducers on editor unmount (#29565)
## Description Reset widgets, actions and jsCollection on application unmount. This is to make sure no entities get into workflows or modules editor #### PR fixes following issue(s) PR for https://github.com/appsmithorg/appsmith-ee/pull/3138 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Implemented a feature to reset the editor to its initial state across various components. - **Refactor** - Enhanced state management to ensure a consistent reset behavior. - **Chores** - Updated internal state handling to improve performance and reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Nilansh Bansal
|
10005794dd
|
feat: http2 support for REST API and GraphQL (#29304)
## Description > This PR adds a selection dropdown for the HTTP Version in the REST API and GraphQL plugins. #### PR fixes following issue(s) Fixes #28226 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced support for selecting different HTTP protocol versions when configuring APIs. - **Enhancements** - Improved user interface for API configuration with a new dropdown to select HTTP protocol versions. - **Bug Fixes** - Fixed an issue to ensure that the API configuration now correctly displays protocol labels in dropdown menus. - **Documentation** - Added user-friendly placeholders and titles for secure and fast API connection settings. - **Refactor** - Enhanced internal methods to support the selection of HTTP protocol versions for API actions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aman Agarwal <aman@appsmith.com> |
||
|
Valera Melnikov
|
862cdded5a
|
chore: add shadow elevation color tokens (#29708)
Fixes: #29702 |
||
|
Ankita Kinger
|
cc61ca4c47
|
chore: Refactoring queries/JS section on entity explorer to support private entities on packages (#29703)
## Description Refactoring queries/JS section on entity explorer to support private entities on packages #### PR fixes following issue(s) Fixes [#28495](https://github.com/appsmithorg/appsmith/issues/28495) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced new search filtering capabilities in the global search. - Enhanced the `EntityExplorer` component to selectively display files based on new criteria. - **Enhancements** - Expanded `JSCollection` interface to support workflow associations and contextual actions. - **Refactor** - Streamlined naming functions with the introduction of `CreateNewActionKey` enum to ensure consistency in action creation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
9a38452fe5
|
fix: move canvas starter datasource prompt from entity explorer to sidebar button (#29559)
## Description In this fix, we've moved the canvas starter datasource prompt into the newly introduced left side bar for data. This enhancement not only ensures a more intuitive user experience but also establishes a clear and cohesive relationship with the data button, streamlining the workflow for a more efficient and user-friendly interface. Notion - https://www.notion.so/appsmith/Bring-in-data-modal-pops-up-in-the-wrong-place-after-the-new-sidebar-update-ecfe985e89944caeb618ea1a19398342?pvs=4 #### PR fixes following issue(s) Fixes #29484 #### Type of change - Bug fix (non-breaking change which fixes an issue) - ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Improved the visual layout of popover components for better user interface alignment. - **Refactor** - Streamlined the user interface by removing the `DatasourceStarterLayoutPrompt` from the `EntityExplorer` component. - Enhanced the `SidebarButton` component to conditionally render the `DatasourceStarterLayoutPrompt` based on context, ensuring a more dynamic and responsive user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
97d5e60842
|
test: Cypress - tags added - @tag.Workspace, @tag.Datasource, @tag.JS, @tag.PropertyPane (#29704)
## Description
> Added tags to cases
- cypress/e2e/Regression/ClientSide/Workspace - @tag.Workspace
- cypress/e2e/Regression/ServerSide/ApiTests - @tag.Datasource
- cypress/e2e/Regression/ServerSide/Datasources - @tag.Datasource
- cypress/e2e/Regression/ServerSide/GenerateCRUD - @tag.Datasource
- cypress/e2e/Regression/ServerSide/JsFunctionExecution - @tag.JS
- cypress/e2e/Regression/ServerSide/OnLoadTests - @tag.PropertyPane
- cypress/e2e/Sanity/Datasources - @tag.Datasource
- cypress/e2e/Regression/ServerSide/QueryPane - @tag.Datasource
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
## Testing
> /ok-to-test tags="@tag.Workspace, @tag.PropertyPane, @tag.JS"
#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Tests**
- Enhanced test suites for Radio, Rating, and Select widgets with
metadata tags for improved categorization and filtering.
- Updated test descriptions and restructured test cases for better
clarity and organization.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
sharanya-appsmith
|
58a8d4334e
|
test: Cypress - added tags - @tag.Radio, @tag.Rating, @tag.TextEditor, @tag.PhoneInput, @tag.IconButton, @tag.Maps, @tag.MenuButton, @tag.Progress, @tag.Statbox (#29693)
## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Widgets/Modal - @tag.Modal, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Multiselect - @tag.Multiselect, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/PhoneInput - @tag.PhoneInput, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/RTE - @tag.TextEditor, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Radio - @tag.Radio, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Select - @tag.Select, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Others/StatBox_DragAndDrop_spec.js - @tag.Statbox, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Rating - @tag.Rating, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Others/Progress_spec.js - @tag.Progress, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts - @tag.Maps, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.Radio, @tag.TextEditor, @tag.PhoneInput, @tag.Maps" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced test suites for Radio, Rating, and Select widgets with metadata tags for improved categorization and filtering. - Updated test descriptions and restructured test cases for better clarity and organization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
31a091efdb
|
test: Cypress - added tags - @tag.Filepicker, @tag.Form, @tag.Iframe, @tag.Image, @tag.Input (#29689)
## Description
> Added tags to
- cypress/e2e/Regression/ClientSide/Widgets/Filepicker - @tag.Filepicker
- cypress/e2e/Regression/ClientSide/Widgets/Form - @tag.Form
- cypress/e2e/Regression/ClientSide/Widgets/Iframe - @tag.Iframe
- cypress/e2e/Regression/ClientSide/Widgets/Image - @tag.Image
- cypress/e2e/Regression/ClientSide/Widgets/Input - @tag.Input
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## Testing
> /ok-to-test tags="@tag.Widget"
> /ok-to-test tags="@tag.Filepicker ,@tag.Image"
#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Refactor**
- Enhanced test suites with tags for better categorization and
searchability.
- Improved test descriptions and reordered test steps for clarity.
- Updated test suites to use arrow functions for consistency.
- **Tests**
- Expanded test coverage for file picker widgets, including additional
file formats.
- Added new test cases for form widget functionalities and validations.
- Refined iframe widget tests to verify different aspects separately.
- Adjusted image widget tests and input widget tests for improved
validation and functionality checks.
- **Chores**
- Updated tags.js file to reflect the latest tagging conventions for
tests.
- **Style**
- Standardized formatting across various test suites to maintain code
cleanliness and readability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
sharanya-appsmith
|
59f4d9d422
|
test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682)
## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/PropertyPane - cypress/e2e/Regression/ClientSide/ThemingTests - cypress/e2e/Regression/ClientSide/Refactoring - cypress/e2e/Regression/ClientSide/ProductRamps - cypress/e2e/Regression/ClientSide/Performance - cypress/e2e/Regression/ClientSide/PeekOverlay #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced test categorization with the addition of tags for better filtering and identification across various test suites. - Improved readability and maintenance of test cases through reformatting and restructuring. - Updated test suite options for improved test coverage and identification. - **Refactor** - Optimized test setup and execution logic for several feature-related test suites. - **Bug Fixes** - Adjusted test cases to accurately reflect application behavior, particularly in toast message validation and property setting scenarios. - **Documentation** - Added comments for clarity in test code to aid in understanding test case intent and functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
78514dcbac
|
test: Cypress - tag - @tag.MobileResponsive (#29678)
## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.MobileResponsive" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced mobile responsiveness test suites with additional tags and assertions to ensure consistent behavior across various devices. - Improved test structure for clarity and better simulation of user interactions on mobile viewports. - Increased coverage for widget dimension validations after viewport changes. - **Refactor** - Reorganized test cases and logic for a more streamlined testing process. - **Documentation** - Updated test descriptions and added comments for better understanding of test purpose and functionality. - **Chores** - Adjusted test suite setups and teardowns for optimized test execution. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Saroj
|
cf53dbfb23
|
ci: Allow static split of cypress specs (#29653)
## Description - Allowing static split of cypress specs in CI runs. - Optimised the spec allocation by considering the duration history for each spec. - Updated the affecting workflows to utilise the static split #### Type of change - Workflows - Cypress-split pugin ## Testing - Workflow run <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new environment variable to optimize test resource allocation during CI/CD processes. - Enhanced Cypress testing with dynamic and static test splitting strategies. - **Refactor** - Refactored Cypress plugin configuration to support conditional test splitting based on the environment variable. - **Chores** - Updated GitHub Actions workflows to include new environment variables for test runs. - **Documentation** - Updated internal documentation to reflect changes in test setup and execution strategies. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
0b4fe0dd10
|
test: Cypress - added tags - @tag.JSONForm, @tag.List, @tag.Widget (#29690)
## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Widgets/JSONForm - @tag.JSONForm, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/List - @tag.List, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/ListV2 - @tag.List, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.JSONForm, @tag.List" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Enhanced testing suites for the JSON Form and List widgets with improved categorization and readability. - Improved test cases for field visibility, disabling, default values, and widget functionality across various components. - **Tests** - Added new test cases to cover additional scenarios for JSON Form fields and List widget interactions. - Refined existing tests to increase reliability and coverage. - **Documentation** - Updated test suite descriptions with tags for better organization and clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
bae69cddb4
|
test: Cypress - @tag.Video, @tag.Container, @tag.Switch, @tag.Slider, @tag.Tab, @tag.Table, @tag.Select (#29698)
## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Widgets/ContainerTest2_spec.ts - @tag.Container, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Switch - @tag.Switch @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Sliders - @tag.Slider, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Tab - @tag.Tab, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/TableV1 - @tag.Table, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/TableV2, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Video, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/TreeSelect - @tag.Select, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.Container, @tag.Video, @tag.Table, @tag.Switch" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced test suites for Radio, Rating, and Select widgets with metadata tags for improved categorization and filtering. - Updated test descriptions and restructured test cases for better clarity and organization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
f5fdec13f6
|
test: Cypress - added tags - @tag.Audio, @tag.Button, @tag.Camera, @tag.Chart and @tag.Widget (#29685)
## Description > Added tags - cypress/e2e/Regression/ClientSide/Widgets/Audio - @tag.Audio, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Button - @tag.Button, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Camera - @tag.Camera, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Chart - @tag.Chart, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Widget" > /ok-to-test tags="@tag.Camera" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced test suites for Audio Recorder, Button, Camera, and Chart widgets with additional assertions and validations. - Added new test cases for various widget properties and events, including style properties, form settings, and camera modes. - Reorganized and reformatted existing test suites for improved readability and maintainability. - **Documentation** - Updated test descriptions to include tags for better categorization and traceability. - **Bug Fixes** - Modified test logic to ensure thorough verification of widget functionalities and event triggers. - **Refactor** - Reorganized test cases into individual `it` blocks for clarity. - Adjusted test control flows for more precise behavior validation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
d8a818686e
|
test: Cypress - added tags - @tag.Settings, @tag.Binding (#29684)
## Description > Added tags - cypress/e2e/Regression/ClientSide/UserProfile/ - @tag.Settings - cypress/e2e/Regression/ClientSide/VisualTests/ - @tag.Settings - cypress/e2e/Regression/ClientSide/Walkthrough/ - @tag.Binding #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing >/ok-to-test tags="@tag.Settings, @tag.Binding" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced the "Update User Picture" end-to-end test to include checks for "Remove" text and file upload functionality. - Introduced a new test case to handle and validate error messages for invalid file uploads. - Updated the "Update User's Name" test suite with a settings tag for better categorization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
2802efcbb2
|
test: Cypress - added tags - @tag.IDE, @tag.JS (#29674)
## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/IDE - cypress/e2e/Regression/ClientSide/JSObject #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.IDE" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Tests** - Enhanced test suite descriptions and added categorization tags for better filtering. - Improved test code structure and added explanatory comments for increased clarity and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
3d1828de2a
|
test: Cypress - added @tag.Checkbox, @tag.Scanner, @tag.Datepicker, @tag.DocumentViewer, @tag.CurrencyInput, @tag.Dropdown (#29687)
## Description > Added tags to - cypress/e2e/Regression/ClientSide/Widgets/Checkbox - @tag.Checkbox, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/CodeScanne - @tag.Scanner, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput - @tag.CurrencyInput, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Datepicker - @tag.Datepicker, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/DocumentViewer - @tag.DocumentViewer, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Dropdown - @tag.Dropdown, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Widget" > /ok-to-test tags="@tag.Scanner,@tag.Checkbox" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed |
||
|
Valera Melnikov
|
f793fb58f0
|
fix: put wds theme provider under feature flag (#29659)
## Description Put WDS theme provider under the feature flag so that WDS don't affect prod anymore. Also fix this  **How it look like now** WDS enabled   WDS disabled   <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved feature flag naming for clarity in the app viewer settings. - Simplified theme background color application in the editor canvas. - Centralized rendering logic for editor canvas components for better maintainability. - **Style** - Streamlined the application of themes to ensure consistent background colors across the platform. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ayush Pahwa
|
848afaf878
|
feat: workflows create js object code split (#29627)
Co-authored-by: Druthi Polisetty <druthi@appsmith.com> Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: Hetu Nandu <hetunandu@gmail.com> |
||
|
Hetu Nandu
|
88a50e58d2
|
chore: Editor Pane Segments completion (#29688)
Completes the List and Add states of Queries / JS / UI of Page Pane Segments fixes #29081 fixes #29501 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new URL building functions for widgets and queries. - Added new UI elements for creating widgets and queries. - Implemented new routing paths for widget and query creation. - **Enhancements** - Updated text labels for clarity in various components. - Improved sorting logic for page pane data. - Enhanced global search with additional display titles. - **Bug Fixes** - Corrected styling inconsistencies in the IDE's main pane. - Fixed routing issues for adding new queries and widgets. - **Documentation** - Updated button text to reflect new features for end-users. - **Style** - Applied new styles for the search bar and other UI components. Please note that some internal code changes and refactorings have been omitted from these notes to focus on user-facing features and improvements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
a411e27b46
|
test: Cypress - added tag- @tag.Binding (#29679)
## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/OneClickBinding #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Binding" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced end-to-end test coverage with new test cases and tags for better organization. - Improved existing test cases for the JSONForm and Table widgets, including additional assertions and interactions. - Synchronized test execution with application behavior through added waits. - Expanded test scenarios for one-click binding features across various widgets and data sources. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
9aa94a2746
|
test: Cypress - added tag - @tag.AutoHeight, @tag.IDE (#29670)
## Description > Add tags to cases in - cypress/e2e/Regression/ClientSide/DynamicHeight - cypress/e2e/Regression/ClientSide/ExplorerTests - cypress/e2e/Regression/ClientSide/EmbedSettings - cypress/e2e/Regression/ClientSide/Editor #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.AutoHeight" #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Reorganized test suite structures and added categorization tags to improve test clarity and maintainability. - **Style** - Reformatted code across multiple test files for better readability and consistency. - **Tests** - Enhanced existing test cases with additional assertions for element visibility and CSS attribute values. - Adjusted test control flows and logic for dynamic height and width validation across various widgets. - Updated test descriptions and restructured test steps to align with testing best practices. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Apeksha Bhosale
|
a436d81aea
|
chore: split for overlay changes on EE to accommodate module instance (#29647)
## Description split for overlay changes on EE to accommodate module instance #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new navigation data retrieval function to enhance navigation within the app. - **Refactor** - Improved the `getEntitiesForNavigation` function to integrate new navigation data. - **Documentation** - Updated import statements to reflect collaborative features between different app modules. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
87a928a168
|
test: Cypess - added tags - @tag.Fork, @tag.Git (#29672)
## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/Fork - client/cypress/e2e/Regression/ClientSide/Git #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing >/ok-to-test tags="@tag.Fork" #### How Has This Been Tested? - [x] Manual - [x] Cypress > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the structure and readability of test suites related to forking applications. - **Tests** - Enhanced test descriptions and categorization with new tags for better test management. - Added new test scenarios for forking applications by non-signed users and checking application properties post-fork. - **Chores** - Introduced new tags for test suites to facilitate automated test height adjustment and forking feature identification. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
d0de9c2fbe
|
test: Cypress - added tags - @tag.Git, @tag.JS, @tag.Binding, @tag.Datasource, @tag.ImportExport (#29516)
Renamed testcases starting with Bug to appropriate Feature_Bug eg DS_Bug, JS_Bug etc. and tagged them. Reverted the airgap change made to 1. cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.js 2. cypress/e2e/Regression/ClientSide/Autocomplete/Bugs_AC_Spec.ts Run Binding test cases -` /ok-to-test tags="@tag. Binding"` Run JS test cases - `/ok-to-test tags="@tag.JS"` Run ImportExport test cases - ` /ok-to-test tags="@tag.ImportExport"` Run Binding test cases - `/ok-to-test tags="@tag.Binding"` Few more datasource testcases added - `/ok-to-test tags="@tag.Datasource"` To run both Git and Datasource tagged testcases -` /ok-to-test tags="@tag.Datasource,@tag.Git"` > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > Ran ok to test with multiple tags #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [x] Cypress > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced test suite descriptions with relevant tags for better categorization and filtering. - Added new test cases for various bug verifications, ensuring features like datasource interactions, API executions, and widget bindings work as expected. - Improved existing test cases with additional steps and assertions to cover more scenarios and edge cases. - **Bug Fixes** - Implemented test cases to verify fixes for specific bugs related to data source configurations, JavaScript object parsing, and UI component behaviors. - **Documentation** - Updated test descriptions to provide clearer context and objectives for each test suite. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
b7b2e49966
|
test: Cypress | Replace static with Dynamic waits - Part IV (#29641)
## Description
- This PR removes static wait from below
'app/client/cypress/e2e/Regression/ClientSide/**' & replaces with
dynamic checks as needed:
- /AuditLogs/Audit_logs_spec.js
- /Autocomplete/Autocomplete_setters_spec.ts
- /Autocomplete/BracketNotation_AC_spec.ts
- /Autocomplete/Bugs_AC_Spec.ts
- /Autocomplete/JS_AC1_spec.ts
- /Autocomplete/JS_AC2_spec.ts
- /Autocomplete/PropertyPaneSuggestion_spec.ts
- /Autocomplete/autocomplete_spec.ts
- /Branding/Branding_spec.js
- /Debugger/Widget_property_navigation_spec.ts
- Flaky fix to move to TED(from Users) & remove wait in
Widgets/Chart/Chart_Widget_Loading_spec.js
- Dynamic wait add - ClientSide/SetProperty/SetOptions_Spec.ts
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Tests**
- Optimized test flows by removing unnecessary wait times, improving
test reliability and execution speed.
- Skipped certain test suites and cases, likely due to ongoing
development or identified issues requiring attention.
- Updated test cases to reflect new functionalities and ensure proper
synchronization during test execution.
- **Chores**
- Adjusted the list of limited tests, refining the focus of the test
suite for more targeted testing.
- **Documentation**
- Updated test descriptions and comments to better reflect their purpose
and the importance of specific actions within the tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Anagh Hegde
|
681ad2e6d1
|
chore: template upload process revamping (#29626)
## Description Move from all the manual process of exporting app and filling so many details, make template upload process a 1 click action. Current, the step is manual. One has to export the app manually, and then upload to s3, get the APP URL and page name correct and there is a lot of room for error. All of this can be automated. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/cloud-services/issues/1454 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [ ] Manual #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new feature for publishing templates under a "use-case" category. - Implemented a simplified endpoint for publishing community templates. - **Bug Fixes** - Streamlined the template publishing process to enhance user experience. - **Refactor** - Consolidated template-related data transfer objects to a more generic naming convention. - Refactored the publishing methods to align with the new template categorization. - **Documentation** - Updated API documentation to reflect new endpoints and usage patterns. - **Tests** - Modified existing tests to accommodate changes in template DTO naming and publishing logic. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
c1487a6125
|
test: Cypress | Replace static with Dynamic waits - Part III (#29582)
## Description
- This PR removes static wait from below:
- ClientSide/ActionExecution/*** & add dynamic waits as needed in below
specs:
- /ActionSelector_JsToNonJSMode_1_spec.ts
- /Error_handling_spec.ts
- /NavigateTo1_spec.ts
- /PostWindowMessage_spec.ts
- /disableJSToggle_spec.ts
- /setInterval_spec.js
- /uiToCode_spec.ts
- ClientSide/AdminSettings/Admin_settings_spec.js
- ClientSide/AppNavigation/**
- /AppNavigationWithMultiplePages_spec.ts
- /AppNavigation_spec.ts
- /Sidebar_spec.ts
- /TopInline_spec.ts
- /TopStacked_spec.ts
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Tests**
- Enhanced the reliability of Cypress end-to-end tests by replacing
fixed sleep times with dynamic element visibility checks.
- Streamlined test execution by removing unnecessary wait commands.
- Improved test descriptions and ordering for better clarity and test
suite organization.
- Updated limited test configurations to reflect the current focus of
regression testing.
- **Chores**
- Adjusted the build workflow to optimize the test matrix based on the
type of GitHub event trigger.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Ankita Kinger
|
cf6c77194b
|
chore: Refactoring entity types and updating DS action create permission to fix some bugs on EE (#29573)
## Description Refactoring entity types and updating DS action create permission to fix some bugs on EE #### PR fixes following issue(s) Fixes # (issue number) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [x] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined entity type naming conventions across the application for better consistency. - Enhanced type definitions for improved code clarity and maintainability. - Updated function calls to use object parameters with named properties for better readability. - **New Features** - Introduced a new entity type for module instances, expanding the application's data handling capabilities. - **Bug Fixes** - Corrected improper type assertions to ensure accurate entity recognition and processing. - **Documentation** - Added comments to clarify the non-introduction of certain dependencies in specific components. - **Style** - Adjusted import statements to align with the updated naming conventions. - **Tests** - Updated test cases to reflect changes in entity type references and assertions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rohan Arthur
|
c9e89b42c9
|
fix: copy change for explanation text on start-with-template option (#29616)
## Description #### PR fixes following issue(s) Fixes #29612 Old text: ""Begin with a specific scenario in mind. We'll guide you through tailoring your app." New text: "Begin with an app for a specific scenario. We'll guide you through tailoring your app." > #### Media >  > > #### Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated the subtitle message for starting from a template to enhance clarity and user guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
vadim
|
db493eb6a9
|
chore: WDS elevation colors refinement (#29618)
Closes #29421 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Enhanced the visual contrast in Dark Mode by adjusting background elevation colors for improved readability. - Refined Light Mode background colors for better visual hierarchy based on lightness conditions. - Updated shadow effects on UI components to provide a more pronounced depth and focus. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
93b24a145a
|
fix: update event name for template fork from canvas starter templates (#29622)
## Description There was a typo in the event name for fork_APPLICATIONTEMPLATE. The even has been named correctly. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected a typo in the analytics event name for forking application templates. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
62913aea25
|
fix: App sidebar context switching with page (#29615)
Fixes a context switching issue where app sidebar navigation does not retain the current page canvas fixes #29614 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the context switching mechanism to include page-specific data, enhancing the app's responsiveness and accuracy when users switch between different contexts. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Favour Ohanekwu
|
0c4586a64c
|
fix: defer data update for js objects (#29564)
## Description This PR defers the update of JS Action's execution data #### PR fixes following issue(s) Fixes #29566 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Refactor** - Improved the execution timing of internal functions to enhance app performance and responsiveness. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
bb2b34982c
|
fix: modal blinking (#29591)
## Description We don't display a skeleton for modal widgets anymore. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media https://github.com/appsmithorg/appsmith/assets/11555074/8568524d-8679-4bc7-af2d-16947734de6f #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [x] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the loading behavior for widgets to be context-sensitive, enhancing the user experience during widget load times. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ayush Pahwa
|
e2d1ff7f91
|
feat: workflows query actions CRUD code split (#29156)
## Description Code split for workflow queries CRUD. Included changes - Added context for explorer entity files component. - Updated sub menu actions to handle different parent entity types (pages or workflows) - Made changes to certain API calls (using payload object instead of pageID) - Created intermediate actions to check parent entity types. Main PR in EE: [#2960](https://github.com/appsmithorg/appsmith-ee/pull/2960) #### PR fixes following issue(s) Fixes #29227 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced search functionality to accept additional parameters for more refined results. - Introduced new helper functions to streamline the creation of queries, APIs, and JS collections based on parent entity types. - Implemented an improved URL building mechanism that accounts for different types of parent entities. - Upgraded the Global Search feature to filter file operations based on user permissions. - Refined the Partial Export Modal's file selection process to include additional entity types. - **Improvements** - Updated the Entity Explorer to provide context-sensitive options based on user permissions and feature flags. - Optimized the Add Query pane to conditionally display options based on user permissions and feature availability. - **Bug Fixes** - Fixed issues with entity ID resolution in URL building to ensure correct redirections within the app. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Druthi Polisetty <druthi@appsmith.com> Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: Hetu Nandu <hetunandu@gmail.com> |
||
|
Valera Melnikov
|
41445c7592
|
fix: checkbox and button border radius (#29476)
## Description Fix checkbox and button border radius https://github.com/appsmithorg/appsmith/assets/11555074/8b7cc892-eaa2-4b06-9745-40410cd1d92b <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the default font stack to include 'sans-serif' for better cross-platform consistency. - **Style** - Adjusted button padding for improved visual alignment and spacing. - Enhanced checkbox design with responsive border-radius for a more modern look. - **Documentation** - Updated theme settings to reflect the new "Pill" option value for border-radius, ensuring design consistency across components. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
6343e568df
|
test: Cypress | Replace static with Dynamic waits - Part II (#29557)
## Description
- This PR removes hard wait from - cypress/e2e/Regression/Apps/ folder
specs & fix as needed:
- /Apps/CommunityIssues_Spec.ts
- /Apps/[EchoApiCMS_spec.js
- /Apps/ImportExportForkApplication_spec.js
- /Apps/MongoDBShoppingCart_spec.ts
- /Apps/PgAdmin_spec.js
- /Apps/PromisesApp_spec.js
- This PR also removes Users mock ds dependency from below specs (using
TED instead)
- ClientSide/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js
- ClientSide/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
- Fixes Sanity/Datasources/MockDBs_Spec.ts - for record count validation
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Tests**
- Enhanced test reliability by removing hardcoded delays and utilizing
dynamic waits.
- Improved test maintainability by centralizing element interactions
through a custom helper.
- Streamlined test setup for database interactions, removing
environment-specific conditions.
- Updated test file paths to reflect the new structure and focus areas.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
ashit-rath
|
c281600ea7
|
chore: refactor create jsobject under modules (#29555)
## Description Refactor to create js objects for modules #### PR fixes following issue(s) PR for https://github.com/appsmithorg/appsmith-ee/pull/3095 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated import paths for `JSCollectionData` and related types across various files to reflect a change in the file structure or module resolution strategy. - Exported `initialState` and `handlers` from `jsActionsReducer` to align with updated code organization. - **New Features** - Added a new entry `JSModules` to the `entitySections` object in `editorContextReducer.ts` to enhance editor context management. - **Bug Fixes** - Adjusted the `createDummyJSCollectionActions` function to include `additionalParams` and `variables` for improved action creation and initialization. - **Documentation** - No visible changes to end-user documentation in this pull request. - **Style** - No style-related changes affecting end-users in this pull request. - **Tests** - No test-related changes affecting end-users in this pull request. - **Chores** - No chore-related changes affecting end-users in this pull request. - **Revert** - No reverts affecting end-users in this pull request. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
a6926a4fed
|
fix: sorting schema options alphabetically (#29460) | ||
|
Apeksha Bhosale
|
86c65b5f4a
|
chore: added new selector for all js collections to be extended on ee (#29553)
## Description this is added to run all js functions from js editor #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new function to aggregate JavaScript collections for enhanced data handling. - **Refactor** - Updated internal logic to utilize the new aggregation function for JavaScript collections, improving efficiency and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vemparala Surya Vamsi
|
e15a2ccfbd
|
chore: sentry issue fix #29551 (#29552)
## Description Fixes the null errors from the convertWebworkerSpansToRegularSpans function. #### PR fixes following issue(s) Fixes #29551 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the stability of the worker service by handling potential undefined properties more gracefully. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
a3baa9969d
|
test: Cypress | Flaky fix | Replace static waits - GitSyncedApps_spec.js (#29514)
## Description - This PR removes hard wait & flaky fix from spec: ClientSide/Git/GitSync/GitSyncedApps_spec.js #### Type of change - Script update (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Adjusted test logic for currency input handling in regression tests. - Renamed test specifications for clarity. - Enhanced table widget API binding and pagination tests. - Skipped certain test suites for older app imports and admin settings. - **Chores** - Updated the git fetch command in the build workflow for better repository syncing. - **Documentation** - No user-facing documentation changes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
9632bca064 | Adds disableExportCTA logic in PartialExportModal | ||
|
Rahul Barwal
|
2e8e307a95
|
fix: Community templates UX issue (#29164)
## Description This pull request includes several fixes and improvements to the codebase. Here is a summary of the changes: - Improved searchability and tag visibility for the application. - Disabled the public and forkable switches in ApplicationSettings. - Refactored the CommunityTemplateForm to use the defaultPageId. - Added a new event, COMMUNITY_TEMPLATE_PUBLISHED. #### PR fixes following issue(s) Fixes #29165 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability to publish community templates with enhanced settings for visibility and collaboration. - Added new analytics event tracking for community template publication. - **Enhancements** - Improved the search functionality in the template selection with responsive tag count and search feature. - Enhanced application settings with the ability to disable switches for public and forkable options. - **Documentation** - Updated instructions for triaging new changes and features. - **Refactor** - Simplified logic for determining default page ID in the template publishing form. - **Tests** - Extended unit tests to cover new session user service functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya UR
|
adf159bfd6 |
Revert "skip"
This reverts commit
|
||
|
Aishwarya UR
|
e3699382b5 | skip | ||
|
Rudraprasad Das
|
c6f26918dc
|
feat: ui for autocommit (#29441)
## Description - Adds a button to enable/disable auto-commit in Git Settings - Adds loading state for auto-commit #### PR fixes following issue(s) Fixes #29127 #### Media <img width="694" alt="image" src="https://github.com/appsmithorg/appsmith/assets/8724051/628d9c93-f374-4611-9c1d-c568d3a6bed5"> #### Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced auto-commit functionality for Git synchronization. - Added modals and status bars to manage and display auto-commit progress. - Implemented feature flags to enable or disable the auto-commit feature. - **Enhancements** - Updated Git settings to include auto-commit configuration options. - Improved user interface with new messages and warnings related to auto-commit. - **Bug Fixes** - Addressed issues with Git-related actions to ensure smoother user experience. - **Documentation** - Added user-facing messages and descriptions for the auto-commit feature. - **Refactor** - Refactored Git settings components to accommodate new auto-commit feature. - **Style** - Updated styles to support new components related to auto-commit functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|
Jacques Ikot
|
4c65938b72
|
fix: update template item to show loading indicator on selected template only (#29252)
## Description This PR addresses the issue where the loading indicator is erroneously triggered for all template cards when a user attempts to fork a single template. The proposed changes in this PR ensure that the loading indicator is appropriately tied to the specific template selected by the user. By isolating the indicator to the clicked template, we enhance the user experience and eliminate any confusion related to the forking process. #### PR fixes following issue(s) Fixes #29135 #### Media #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Implemented a new state management feature to track active template operations, enhancing the user experience during template import and forking processes. - Introduced a new button state to prevent conflicting operations, ensuring a smoother template handling experience. - **Enhancements** - Improved the visual feedback on the template interface with updated button states to reflect ongoing operations. - **Bug Fixes** - Resolved an issue where users could initiate multiple conflicting template operations simultaneously. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com> |
||
|
sharanya-appsmith
|
d287940a7d
|
test: Cypress - Added Tags to test cases - @tag.GSheet, @tag.Datasource, @tag.JS, @tag.IDE, @tag.Settings, @tag.Binding (#29471)
## Description > Adding tags to the existing test cases Run GSheet test cases - `/ok-to-test tags="@tag.GSheet"` Run JS test cases - ` /ok-to-test tags="@tag.JS"` Run IDE test cases - ` /ok-to-test tags="@tag.IDE"` Run Binding test cases - ` /ok-to-test tags="@tag.Binding"` Few datasource testcases (tags are added to few) using - ` /ok-to-test tags="@tag.Datasource"` To run both GSheet and Datasource tagged testcases -` /ok-to-test tags="@tag.Datasource,@tag.GSheet"` To run both Binding and IDE tagged testcases - ` /ok-to-test tags="@tag.Binding,@tag.IDE"` To run both Binding, IDE, JS tagged testcases - ` /ok-to-test tags="@tag.Binding,@tag.IDE,@tag.JS"` #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [x] Cypress #### Test Plan > ok to test with tags added ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced test suite categorization with the addition of metadata tags for improved filtering and organization. - **Refactor** - Reorganized test suite structures for clarity and maintainability. - Updated test descriptions and assertions for better test coverage. - **Bug Fixes** - Modified test cases to include additional validation steps for bug fix verification. - **Documentation** - Updated test suite descriptions with new tags to reflect changes in testing strategies. - **Chores** - Adjusted file paths for test specifications to align with the updated testing focus. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
fe3863eb65
|
test: Cypress | Replace static with Dynamic waits - Part 1 (#29405)
## Description
- Removed hard waits from below specs:
- Apps/CurrencyInputIssue_Spec.js
- ClientSide/Widgets/Modal/Modal_spec.ts (Fix & unskip)
- /Binding/TableV2_Widget_API_Pagination_spec.js
- Unskip - ApiTests/API_Unique_name_spec.js
- Flaky fix - TableV2_Widget_API_Pagination_spec.js
- Flaky fix - /ServerSide/QueryPane/S3_1_spec.js
- Removed empty ReusableHelper.ts
- Improved agHelper.GetElement() to include the assertion for element
presence/absence
- Modified helpers/function calls to fit the above syntax of
GetElement()
- Improved WaitUntilEleAppear(), WaitUntilEleDisappear() to use timeout
from cypress config
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Summary by CodeRabbit
- **Tests**
- Enhanced end-to-end test stability by replacing static waits with
dynamic element-based synchronization.
- Skipped certain test suites to streamline the testing process.
- Improved test assertions and control flow for more reliable
verification of UI components.
- **Chores**
- Updated test helper methods to support new verification strategies.
- Cleaned up unnecessary imports and inheritance in test support
classes.
- **Documentation**
- Adjusted test case descriptions to reflect the new synchronization
methods used.
- **Bug Fixes**
- Fixed issues with test synchronization that could lead to flaky test
results.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Rishabh Rathod
|
c29a7e1712
|
chore: CE changes for JSModule execution (#29489)
## Description - Add `isAnyJSAction` method to check for JSAction and JSModule in EE #### PR fixes following issue(s) #### Type of change - Chore ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the evaluation logic to include a broader range of JavaScript actions. - **Refactor** - Streamlined JavaScript action checks within the evaluation process for dynamic bound values. - **Documentation** - Updated function descriptions to reflect the new evaluation capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Pawan Kumar
|
544c3705e8
|
chore: Add tag group component (#29387)
Fixes #29134 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `TagGroup` and `Tag` components with features like label, description, error message, and tag removal options. - Added new stories for `TagGroup` to demonstrate various configurations and use cases. - **Enhancements** - Updated `Switch` component with improved validation logic. - Enhanced `TextArea` initialization to handle undefined default values more gracefully. - Added `validationState` property to `HelpText` and `Field` components to support form validation states. - **Style Updates** - Implemented new CSS styles for `TagGroup` and `Tag` components to improve UI consistency and interactivity. - **Documentation** - Expanded Storybook documentation with examples and usage guidelines for `TagGroup` and `Tag` components. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sneha122
|
26039e9e20
|
feat: release start with data solution (#29480)
## Description This PR release start with data onaboarding solution to 50% of new users. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29479 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified the app creation process by removing unnecessary local storage checks. - Streamlined analytics event logging during app creation. - **Chores** - Removed unused code related to local storage to enhance performance and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Vemparala Surya Vamsi
|
6395f2ea6a
|
chore: serialising moment updates #27963 (#29354)
## Description Serialising moment updates directly, no longer making granular moment object updates. #### PR fixes following issue(s) Fixes #27963 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [x] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved error handling in certain scenarios to provide clearer feedback to users. - **New Features** - Enhanced date and time handling to ensure more reliable performance. - **Tests** - Updated automated tests to include additional wait times for better stability and accuracy. - **Documentation** - Comments within the code have been updated to better reflect the current logic for future reference. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
ashit-rath
|
5a227f9933
|
chore: refactor jsobject response & settings (#29475)
## Description Refactor the JSObject response view and the settings to accept new columns #### PR fixes following issue(s) Fixes for PR https://github.com/appsmithorg/appsmith-ee/pull/3060 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Users can now opt to open the debugger when executing JavaScript functions within the app. - **Enhancements** - Improved JavaScript function execution flow with additional debugging options. - Enhanced JavaScript editor form to better handle JavaScript collection configurations. - **Bug Fixes** - Fixed issues related to JavaScript collection data retrieval and management. - **Refactor** - Streamlined JavaScript function settings with additional columns and headings for better clarity. - Updated state management to align with the new JavaScript collection data structure. - **Style** - Removed the bottom border from the `TabbedViewContainer` for a cleaner UI appearance. - **Documentation** - Updated documentation to reflect changes in JavaScript pane actions and selectors. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ayush Pahwa
|
4e72309747
|
chore: rts workflow APIs code split (#29474) | ||
|
Vemparala Surya Vamsi
|
dbe7429009
|
fix: getAllTokens initialization fix (#29488)
## Description useState is calling the initialisation function unnecessarily for every render, We will call it only during state initialisation. #### PR fixes following issue(s) Fixes #29491 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Improved stability of list widget server-side pagination tests by introducing wait times. - **Refactor** - Optimized theme state initialization in `useTheme` to enhance performance. - **Bug Fixes** - Adjusted handling of moment objects in evaluation workers to ensure accurate serialization of updates. - **Documentation** - Updated test documentation to reflect changes in moment object handling and serialization. (Note: Duplicate entries for `useTheme` have been consolidated in the Refactor category to maintain clarity and avoid repetition.) <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
a99bd1a1a1
|
chore: Remove back button (#29312)
## Description Removes the back button from Editor screen other than the canvas. With the new IA, this would not be needed #### PR fixes following issue(s) Fixes #29306 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced end-to-end test suites for Autocomplete, Git Sync, and IDE functionalities with improved UI interaction logic. - Introduced wait times in tests to better handle asynchronous UI updates. - **Refactor** - Streamlined navigation in the editor by replacing direct UI interactions with dedicated navigation methods. - Removed redundant code and improved the clarity of test scenarios. - **Chores** - Updated common locators by removing unused selectors to simplify test codebase. - **New Features** - Implemented feature flags to conditionally enable new UI components, providing a more tailored user experience. - **Documentation** - Updated internal documentation to reflect changes in test suites and feature flag usage. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ankita Kinger
|
35b9e0b544
|
chore: Refactoring header actions on datasource page to support reusable queries on EE (#29442)
## Description Refactoring header actions on datasource page to support reusable queries on EE #### PR fixes following issue(s) Fixes [#28568](https://github.com/appsmithorg/appsmith/issues/28568) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new header action management system in the data source editor, allowing for dynamic action button generation based on user permissions and editor type. - Implemented a new editor type detection hook to improve editor experience. - **Improvements** - Streamlined the data source editor interface by removing unused permissions checks and simplifying action button logic. - Enhanced the editor's routing system with additional constants for deprecated paths. - **Refactor** - Refactored the `DSFormHeader` component to utilize the new `useHeaderActions` hook for a cleaner and more maintainable codebase. - Updated Redux state management to include a new action handler for resetting editor state. - **Style** - Adjusted the layout of the `LeftPaneContainer` by removing the `min-width` property for a more responsive design. - **Chores** - Cleaned up imports and unused variables across multiple files to improve code clarity and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Favour Ohanekwu
|
95fa2328a8
|
fix: reset widget to default value after setter method (#29151)
## Description This PR ensures that widgets are reset to their default value after the `setValue` setter method is used to set its value #### PR fixes following issue(s) Fixes #27119 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Implemented a new reset functionality for widgets, allowing users to revert to default values after changes. - Enhanced widget meta updates with a new reset action. - **Bug Fixes** - Added test cases to ensure widget reset functionality works as expected, even after asynchronous operations. - **Refactor** - Refactored evaluation logic to improve handling of widget meta updates and resets. - Improved action execution logic for resetting widget properties. - **Tests** - Expanded end-to-end regression tests to cover new reset widget functionality. - **Documentation** - Updated internal documentation to reflect new action types and evaluation processes related to widget meta updates. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Druthi Polisetty <druthi@appsmith.com> |
||
|
Rudraprasad Das
|
612a97f75c
|
fix: change text copy for gen ssh key (#29432)
## Description Changes "In your repo, copy ..." to "To generate the SSH Key, in your repo, copy ..." #### PR fixes following issue(s) Fixes #29430 #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated the instructional message for copying the Remote SSH URL to include steps for generating an SSH Key. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sneha122
|
43474fcfa1
|
fix: analytic events added for start with data flow (#29463)
## Description This PR: - Adds analytic events for start with data onboarding flow, List of events and their details can be found in this [doc](https://www.notion.so/appsmith/Analytic-Events-c326270138c046f4b29328bc18b89b2d) - There was an issue in DATASOURCE_SCHEMA_FETCH event, it was throwing misleading information when the datasource structure fetch API failed, that issue has been fixed as well #### PR fixes following issue(s) Fixes #29435 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced analytics tracking for user interactions during the onboarding process, including skipping steps. - **Refactor** - Improved internal logic for fetching and refreshing datasource structures to enhance error handling and success tracking. - **Documentation** - Updated type definitions to reflect new analytics events related to the onboarding flow. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
albinAppsmith
|
a4623f529c
|
feat: added add button for queries and js sections (#29356)
## Description This PR added the add new button for queries and JS sections. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29082 #### Media https://github.com/appsmithorg/appsmith/assets/87797149/8bce820a-b383-4ca9-80af-03b3b49d6483 #### Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Testing #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress #### Test Plan #### Issues raised during DP testing ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new routing paths for API and queries editors. - Introduced sections for JavaScript and queries in the pages pane. - Implemented support for a new `CURL` plugin type. - Expanded analytics to include events from the pages pane. - **Enhancements** - Improved entity identification logic for new editor paths. - Enhanced focus handling for different entity types. - **Bug Fixes** - Corrected routing logic to accommodate new editor paths. - **Refactor** - Refactored `QueriesSection` component for better rendering logic. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Hetu Nandu <hetu@appsmith.com> |
||
|
Saroj
|
36db171a17
|
test: Fixing Gsheet Tests (#29427)
## Description - Fixing Gsheet Tests due to the latest changes to the page #### Type of change - Cypress ## Testing - [x] Cypress #### QA activity: - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the test suite to cover new interactions with the page's left pane, including expanding/collapsing items and generating new pages. - **Refactor** - Simplified the `CreateQueryAfterDSSaved` method by removing the need for a `datasourceName` parameter, indicating a more streamlined process. - **Tests** - Added new end-to-end test cases to validate the functionality of the left pane in the user interface. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Apeksha Bhosale
|
8ee2586f75
|
fix: added query module instance to one click (#29411)
## Description Added query module instances to the one click list. on CE, query module instances will be always empty as modules are EE only feature. I am replacing module instance selector on EE #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new interface to enhance module instance data handling. - Added functionality to retrieve and display module instances within the application. - Implemented new icons and analytics information for module instances. - **Enhancements** - Improved sorting and binding value functions to support module instance data. - Updated components to utilize new module instance data and icons. - **Bug Fixes** - Fixed an issue where module instances were not correctly retrieved in certain components. - **Documentation** - Updated function documentation to reflect new parameters and return types related to module instances. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
dependabot[bot]
|
ea6cacf576
|
chore(deps-dev): bump vite from 4.4.9 to 4.4.12 in /app/client (#29360)
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.4.9 to 4.4.12. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
Valera Melnikov
|
311203245c
|
fix: add fg and bg colors for inheritance in child components (#29447)
## Description Add fg and bg colors to provier for inheritance in child components Before:  After:  <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new theming capability to dynamically adjust color schemes. - **Refactor** - Enhanced theming logic to improve responsiveness to color mode changes. - **Style** - Updated visual styling to ensure consistency across different themes. - **Documentation** - Adjusted documentation to reflect new theming functions and usage. - **Chores** - Streamlined theming properties for better maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sharanya-appsmith
|
a1fb4ba197
|
test: Cypress - Added cypress grep library (#29259)
Leveraging the library [cypress-grep](https://github.com/cypress-io/cypress/tree/develop/npm/grep). Using this we can tag testcases with relevant tags and use it to run specific testcases. **Command to run in local:** `CYPRESS_grepTags=@tag.Binding,@tag.Git npx cypress run ` Pass the tags to CYPRESS_grepTags argument and only the test cases which has the tags passed will be picked to run. ex `@tag.Binding and @tag.Git` are the tag names here. **Tags can be added in the description on the test case like** `{ tags: ["@tag.Datasource"] }` for a single tag `{ tags: ["@tag.Datasource", "@tag.Git"] }` for multiple tags **How to run In CI** Single Tag - `/ok-to-test tags=@tag.Binding` Multiple tag - `/ok-to-test tags=@tag.Binding,@tag.Git` **TODOs in the next release:** - [ ] Add tags.ts file with all needed tags - [ ] Add tags to remaining spec files. - [ ] Fail the PR run if tags added are not from tag.ts and post the message on the same #### Type of change - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [x] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [x] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a search functionality to the app. - **Enhancements** - Integrated search bar at the top of the `Hero` component and a `Search` component to the `App` component. - Added styles for the search bar. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Arpit Mohan <arpit@appsmith.com> |
||
|
sneha122
|
e8b101baa3
|
feat: rest, graphql and curl fixed for onboarding (#29377)
## Description This PR adds: - functionality to REST, GraphQL and Curl import options when using these during onboarding start with data flow. On clicking on any of these options would take us inside application. #### PR fixes following issue(s) Fixes #29303 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Enhancements** - Improved the onboarding process by integrating new application and page identification logic within the data source creation workflow. - **Refactor** - Updated state management to enhance the user experience during the onboarding phase. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Aman Agarwal
|
ae778f8648
|
fix: section titles according to new ads on datasource list page (#29235)
## Description - Updated the section titles on the datasource page according to new ads changes - Updated the title of secure banner #### PR fixes following issue(s) Fixes #29214 Figma link : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=2365-20296&mode=design&t=x5YSnNQ2mNiVAnUO-4 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated text styling properties for improved visual consistency across the app. - **Style** - Enhanced text elements with new style definitions for better readability and aesthetics. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ankita Kinger
|
d5b71d6933
|
chore: Adding a tooltip conditionally on submenu options for query creation (#29273)
## Description Adding a tooltip conditionally on submenu options for query creation. This is to support package name tooltip for modules listed in submenu of queries in EE. #### PR fixes following issue(s) Fixes [#29270](https://github.com/appsmithorg/appsmith/issues/29270) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed |
||
|
Aishwarya-U-R
|
88e3e00944
|
test: Cypress | Fix Oracle_Spec.ts (#29404)
## Description - This PR fixes Oracle_Spec.ts failing in CI - It is failing to find the table in schema, which is passing fine locally. Hence changed select query flow. #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI run ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Updated Oracle data source test suite with improved query execution and test flow. - Adjusted test specifications to focus on server-side data source validation. - **Chores** - Modified test configuration to reflect changes in the test suite structure. - **Documentation** - No visible changes to end-user documentation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rishabh Rathod
|
6580c6033c
|
chore: Action execution changes for modules (#29357) | ||
|
Nilansh Bansal
|
f8c5b7ca42
|
fix: new query action button (#29398) | ||
|
Aman Agarwal
|
ab3e3b5f34
|
fix: default values for fields in rest api ds form (#29393) | ||
|
sneha122
|
9e5e90a718
|
fix: current workspace getting set incorrectly issue fixed (#29392)
Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Valera Melnikov
|
231f51719c
|
chore: add story for elevation (#29391)
Add story for elevation <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new elevation color calculation methods for both Dark and Light mode themes, enhancing the visual hierarchy in the user interface. - **Documentation** - Added Storybook documentation for the `Elevation` component, allowing for interactive testing and showcasing of elevation styles. - **Style** - Implemented new `Elevation` component with nested styling to represent different UI layers effectively. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sneha122
|
3e25d5ce19
|
fix: start with data UI issues fixed (#29265)
## Description This PR fixes two of the UI issues in start with data flow: [too much white space in datasource form, can’t see CTAs](https://www.notion.so/appsmith/too-much-white-space-in-datasource-form-can-t-see-CTAs-fd05d99a4fc04a9da273226477d41426?pvs=4) [When there is a small space then the form is itself scrolling instead of the full screen.](https://www.notion.so/appsmith/When-there-is-a-small-space-then-the-form-is-itself-scrolling-instead-of-the-full-screen-76f4871977d34c3fb2dfc23ddcf57944?pvs=4) #### PR fixes following issue(s) Fixes #29254 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an onboarding flow for the DataSource Editor, enhancing the user experience for new users. - **Style** - Updated the DataSource Editor interface to dynamically adjust its layout during the onboarding process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”> Co-authored-by: Aman Agarwal <aman@appsmith.com> |
||
|
Dhruvik Neharia
|
b1d754ca2b
|
feat: Integrate WDS Menu Button Widget (#29113)
## Description Adds WDS Menu Button Widget. #### PR fixes following issue(s) Fixes #28864 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `Menu` component with customizable color options for items. - Added dynamic styling for menu items based on color attributes. - Implemented a new `WDSMenuButtonWidget` with configurable properties and styles. - Expanded the property pane with new configurations for menu items and buttons. - **Enhancements** - Improved menu placement options and handling of colors within the Menu component. - Enhanced the `MenuButtonWidget` with additional properties for better customization. - **Bug Fixes** - Fixed incorrect component naming for `MenuList` to ensure consistency. - **Documentation** - Updated Menu component stories to reflect new color handling features. - **Refactor** - Streamlined export statements for Menu components to simplify imports. - Organized property pane configurations into separate modules for clarity. - **Style** - Added new styles for the search bar and menu items for a more polished UI. - **Tests** - No visible changes to end-users. - **Chores** - No visible changes to end-users. - **Revert** - No visible changes to end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Valera Melnikov <valera@appsmith.com> |
||
|
Apeksha Bhosale
|
b37d4a7140
|
chore: small changes in types for module instance evaluation on ee (#29313)
## Description Small changes for js module instance evaluation on EE #### PR fixes following issue(s) Fixes # (issue number) #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified the `ModuleInstance` interface by removing unnecessary properties. - Updated the `generateDataTreeJSAction` function to return a more structured object. - **New Features** - Enhanced the `JSActionEntityConfig` interface with new optional properties to support module and visibility configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
0c345d8404
|
fix: calculate fluid tokens based on provider width (#29316)
## Description - I added `--provider-width` CSS variable to the provider, which we get with the help of [ResizeObserver hook](https://github.com/jaredLunde/react-hook/tree/master/packages/resize-observer), the variable is calculated through [debounces](https://github.com/jaredLunde/react-hook/tree/master/packages/debounce) every 100 ms. - Styles for typography are now calculated only through CSS - Split useFluidTokens hook into several, now there are separate hook for sizing, spacing and typography - Create a separate folder for hooks in the theme package #### PR fixes following issue(s) Fixes #29177 #### Media https://github.com/appsmithorg/appsmith/assets/11555074/7778c5a0-9ed9-4f9c-a2b6-787784ed3e1f #### Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced fluid sizing, spacing, and typography hooks for responsive design adjustments. - Added global font stack utility for consistent typography across platforms. - Enhanced theming capabilities with new hooks and utilities. - **Improvements** - Updated `ThemeProvider` to support new styling hooks and responsive design features. - Refined typography utilities for dynamic class name generation based on design tokens. - **Documentation** - Added comments to clarify the use of `className` and `style` properties in `ThemeProviderProps`. - **Refactor** - Streamlined token access with updated `TokensAccessor` class. - Consolidated typography and font metric types for better type safety and clarity. - **Bug Fixes** - Fixed modal handling in `ComplexForm` component with improved state management and accessibility. - **Breaking Changes** - Removed exports of deprecated typography module and fluid token module. - Changed public interface for theming hooks, which may affect existing consumers. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|
Rudraprasad Das
|
77575fdae0
|
fix: git azure url special char support (#29319)
## Description Modifies git url regex to add support for special character (%) #### PR fixes following issue(s) Fixes #28061 #### Media <img width="1728" alt="image" src="https://github.com/appsmithorg/appsmith/assets/8724051/b6e477fb-1e62-44ab-a724-b963116fceda"> #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [x] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved URL validation to support Azure repository URLs with encoded spaces. - **Refactor** - Updated regular expression patterns to allow for additional characters in Git remote URLs, enhancing compatibility with various repository naming conventions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|
Shrikant Sharat Kandula
|
18eb6790bf
|
chore: Set client's version in index.html at runtime (#29318)
[Slack thread with a lot more details and discussion](https://theappsmith.slack.com/archives/C02MUD8DNUR/p1701759438660509). This will help us move towards having `info.json` as the one source of truth for Appsmith version. |
||
|
Nirmal Sarswat
|
b03c51e05d
|
feat: Anthropic AI Plugin (#29095)
## Description Anthropic AI plugin - provides chat completion API support as a datasource plugin #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29036 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? - [x] Manual - [x] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new Anthropic plugin with capabilities for testing data sources, executing actions, and validating data source configurations. - Added a search bar component to enhance user navigation and interaction within the application. - **Enhancements** - Improved form control elements, including dropdown and field array controls, for better user experience and interface consistency. - Optimized HTTP request handling in the OpenAI plugin for increased efficiency and performance. - **Bug Fixes** - Addressed issues with form control properties to ensure correct behavior and data handling. - **Documentation** - Updated plugin properties and test documentation to reflect new features and changes. - **Refactor** - Refactored various components and utilities for code clarity and maintainability. - **Tests** - Added comprehensive tests for the new Anthropic plugin to ensure reliability and functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Diljit VJ <diljit@appsmith.com> |
||
|
sharanya-appsmith
|
6bb1876f5e
|
test: Cypress - Icon Button spec (#29267)
Add cy back as win.history.back() is not redirecting to the page navigated from Added wait till element - after pressing back, the case will wait for back to editor button to appear before performing any action <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Improved the test script for the "Icon Button" widget to enhance navigation logic. - Updated test file paths to reflect the new structure for better test coverage. - Enhanced network request interception in tests for more robust testing scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
219b3f5817
|
fix: update start with data event & removed temp feature flag for its dev (#29285)
## Description - Removed feature flag `ab_onboarding_flow_start_with_data_dev_only_enabled` used for development of Start with data - Updated the event for Start with data with `shortcut` -> `true` as event param #### PR fixes following issue(s) Fixes #29284 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced app creation process with a new option to create apps from data. - **Improvements** - Streamlined onboarding flow by removing the development-only feature flag for starting with data. - **Refactor** - Renamed a property to better reflect its purpose in enabling new data source creation. - **Chores** - Removed unused feature flags and related code for a cleaner codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
8798b6e116
|
test: Cypress | Promises_1_spec.ts TED URL replace for flaky fix (#29276)
## Description
- This PR replaces 3rd party api's from
app/client/cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts
with below changes:
-- "RandomUser" api to TED api
-- "Genderize" api to TED api
-- To guess the gender passing name, instead of country
-- "InspiringQuotes" to TED api
-- "Agify" api to TED api
-- "GetAnime" to TED echo api
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **CI/CD Updates**
- Transitioned to using a nightly build for the test event driver in CI
workflows.
- **Test Enhancements**
- Expanded test coverage to include all test files.
- Updated test specifications to reflect new data endpoints and improved
error handling.
- **New Features**
- Introduced new data retrieval endpoints for gender, age, and random
quotes within the `DataManager`.
- **Documentation**
- Updated test documentation to align with the latest code changes and
testing strategies.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Hetu Nandu
|
5ab58504a8
|
feat: Create Query asks for Page (#29253)
## Description Shows a list of pages to select when creating a query. It will only show when there are multiple pages in an app. If not, clicking the button directly creates the query in the only page. #### PR fixes following issue(s) Fixes #27961 #### Media  #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the process for creating queries from the datasource editor across various test suites. - Enhanced the control flow and logic for handling data sources and queries in test scenarios. - **Bug Fixes** - Standardized the method of creating new queries after saving a datasource to improve test reliability. - Removed deprecated code and updated test cases to use the new `CreateQueryForDS` function. - **Tests** - Updated test scripts to reflect changes in datasource interaction and query creation. - Added new assertions and modified existing ones to accommodate the updated test flows. - **Chores** - Cleaned up import statements and removed unused code across multiple test files. - Commented out unused properties and methods to improve code maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vemparala Surya Vamsi
|
904c727071
|
chore: capturing more telemetry data as per fe coder's requirements(#29153) (#29287)
## Description Capturing evalTree telemetry data as well as from a few evaluation saga flows. #### PR fixes following issue(s) Fixes #29153 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced telemetry with the ability to specify start times for nested spans. - Introduced web worker span management for improved performance monitoring. - Implemented profiling functions to trace evaluation processes. - **Improvements** - Added telemetry spans to key functions for better performance insights. - Refined control flow to include telemetry span handling in various sagas. - **Documentation** - Updated interface definitions to include new telemetry-related properties. - **Refactor** - Streamlined conditional logic to incorporate telemetry span completion. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rishabh Rathod
|
54012c5c86
|
chore: CE change to log lint error in moduleEditor (#29230) | ||
|
Aman Agarwal
|
288b52a10d
|
fix: added fetch env config to imitate the ee repo functionality (#29266)
## Description - Added the fetching of environment config for ee repo on create new app onboarding flow. - Imitated the `fetchingEnvironmentConfigs` function from ee to ce to provide consistency on both repos - Avoid the redirection from datasource sagas for changing the datasource form which was throwing error trying to create a redirection url. #### PR fixes following issue(s) Fixes #29231 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Implemented a new action to fetch environment configurations, enhancing the app's data management capabilities. - Updated application creation flow to automatically fetch environment configurations when a workspace ID is present. - **Enhancements** - Improved the logic for redirecting users in the data source creation process to be more context-aware. - **Bug Fixes** - Addressed an issue where users were being redirected incorrectly during the data source creation process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aishwarya-U-R
|
da56f612ed
|
test: Cypress | Fix Oracle_Spec.ts fix for new navigation flow (#29283)
## Description - This PR fixes the /ServerSide/Datasources/Oracle_Spec.ts for new navigation - This Spec got missed to be fixed with original PR as this is not run against PR's #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the test workflow for data sources and queries. - **Tests** - Added new end-to-end test specifications for Oracle data sources. - Updated test configurations for better isolation and exclusion patterns. - **Chores** - Removed unused variables and imports from test files to improve clarity and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
b4fd90cf40
|
fix: visual images on onboarding create ne app flow & profiling questions (#29238) | ||
|
Aishwarya-U-R
|
d4c8813d31
|
test: Cypress | DB specs flaky fixes (#29106)
## Description - This PR fixes below flaky specs: - cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts - cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts - cypress/e2e/Regression/ServerSide/Postgres_DataTypes/BooleanEnum_Spec.ts - app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed |
||
|
Pawan Kumar
|
f0672f6f04
|
chore: Create a separate theme settings panel for WDS (#29196)
Fixes #28516 |
||
|
sneha122
|
ab8e4ba146
|
feat: onboarding start with data cancel cta (#29228)
## Description This PR adds datasource cancel functionality during onboarding. When a user selects start with data flow, and select a plugin, on datasource form we can see cancel CTA beside save. On cancel user will be taken back to plugins page. #### PR fixes following issue(s) Fixes #29198 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Pawan Kumar
|
fde6e2de54
|
fix: WDS Input widget bugs (#29241)
Fixes #29091 Fixes #29086 Fixes #29088 |
||
|
Dipyaman Biswas
|
4d255ffd81
|
feat: add intercept for license flags (#29245) | ||
|
Rajat Agrawal
|
66bf0c1652
|
fix: fix overlay echarts iframe (#29225)
Fixes #29226 |
