Commit Graph

712 Commits

Author SHA1 Message Date
akash-codemonk
86cac0fae3
Add test for showBindingPrompt function (#1566) 2020-11-05 19:15:40 +05:30
Hetu Nandu
c1ff711a45 Fix build errors 2020-11-05 17:58:39 +05:30
Nikhil Nandagopal
08b755bdcb
Merge pull request #1591 from appsmithorg/fix/args
Fix for args not splitting correctly with empty values
2020-11-05 17:52:35 +05:30
Hetu Nandu
20f357ae35
Add checks for wrong alert types of Toast messages (#1588)
Fixes #1583
2020-11-05 17:19:37 +05:30
Nikhil Nandagopal
6d6ef35b7c
Merge pull request #1518 from sumanthyedoti/fix/tabs-widget-corners
fix/tabs widget corners
2020-11-05 15:51:41 +05:30
Nikhil Nandagopal
a110a23574
Merge pull request #1169 from daniel-shuy/fix/download-file-type-dropdown-optional
Allow Download File Type dropdown to be deselected
2020-11-05 15:47:18 +05:30
Nikhil Nandagopal
39331d95b2 fix for args not splitting correctly with empty values 2020-11-05 15:46:38 +05:30
Nikhil Nandagopal
409c4ad9b7
Merge pull request #1571 from appsmithorg/fix/org-setting-field-validation
Fix: Field Issues in Organization's General Tab
2020-11-05 11:31:33 +05:30
devrk96
06f106090b
underline css fixed (#1570) 2020-11-05 11:27:27 +05:30
Sumanth Yedoti
851f94842e fix: tabs height 2020-11-05 10:17:55 +05:30
Sumanth Yedoti
db4e09bb1e resolve merge conflict 2020-11-04 23:09:05 +05:30
Sumanth Yedoti
6d55b37b0d fix: add shadow to TabsWidget 2020-11-04 23:03:32 +05:30
Sumanth Yedoti
cac499c9ad fix(Widgets): add rounded corners and improve overall style for TabsWidget 2020-11-04 22:53:08 +05:30
Yedoti Sumanth
f4bed59ba0 style: remove extra red border to Tabs Widget 2020-11-04 22:52:22 +05:30
Yedoti Sumanth
97e4168523 fix(Widget): add rounded corners to Tabs Widget 2020-11-04 22:52:21 +05:30
Sumanth Yedoti
60bbc963dc fix(Widgets): add shadow to TabsWidget 2020-11-04 22:51:59 +05:30
Sumanth Yedoti
41a2a53bf1 fix(Widgets): add rounded corners and improve overall style for TabsWidget 2020-11-04 22:51:58 +05:30
Sumanth Yedoti
a3d7cdb769 style: remove extra red border to Tabs Widget 2020-11-04 22:51:57 +05:30
Yedoti Sumanth
41411bddcb fix(Widget): add rounded corners to Tabs Widget 2020-11-04 22:51:57 +05:30
Rohit Kumawat
560fd9155b field validation fixed in email and white space removed 2020-11-04 21:36:06 +05:30
Daniel Shuy
2c5e74313c Add default empty selection for FILE_TYPE_OPTIONS 2020-11-04 20:23:56 +08:00
akash-codemonk
8ae77f7764
Fix prompt showing up always (#1556) 2020-11-04 16:37:10 +05:30
akash-codemonk
ba6aceb096
Fix includes is not a function error crash (#1555)
* Make the value a string to avoid includes is not a function error

* If it is not a string show the prompt
2020-11-04 15:27:11 +05:30
Abhinav Jha
d5c7fcc1e4
Fix table crash issue when selectedRowIndices was reset (#1542) 2020-11-03 22:16:44 +05:30
Nikhil Nandagopal
8a1be448e1 added a fix for null crashing a page in bindings 2020-11-03 21:17:16 +05:30
Abhinav Jha
543b7ec72d
Entity Explorer Render (#1354)
* WIP: Performance improvements in entity explorer

* WIP: Achieve feature parity for entity explorer with release

* Update unit tests

* Add sentry profiling to current page entity properties component

* Fix page add/delete not showing up on entity explorer issue. Update memoization logic for pagegroup entity

* Deal with the ban-ts-ignore eslint issues

* Update unit tests

* Fix widget entity children visibility

* Fix tests and code

* Fix tests for scenarios where the collapsed entities are unmount, as this is a part of the performance optimization

* Filter undefined children when generating structureDSL

* Remove rule from eslintrc

Consolidate createPage test command

* Update CreatePage tests to remove redundant dsl updates

* Revert CreatePage test changes, as adding more checks within this command globally causes other tests to have issues.

* re-enable eslint rule, as without it CI tests fail

* Revert to ban-ts-comment

* Fix typescript ban-ts-ignore issue by upgrading react-scripts and fixing typescript issue across the application

* Typescript errors handled

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
2020-11-03 18:35:40 +05:30
Abhinav Jha
120c2da507
Fix: Tabs Widget (#1532)
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint
2020-11-03 18:32:50 +05:30
Sumanth Yedoti
87a2effbc5
Fix/api URL field twitch (#1495)
Fixes: #1248
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
2020-11-03 12:21:02 +05:30
akash-codemonk
9afcf87156
Show binding prompt when there is no binding in the editor (#1478) 2020-11-03 09:40:07 +05:30
devrk96
09ce4329b0
underline css fixed (#1515) 2020-11-02 19:35:31 +05:30
satbir121
51cb0d82a2
Fixing zoom on pan issue. (#1474)
* FIxing zoom on pan issue.

* Adding a disabled label to 1x zoom.

* Adding comments.

* Update PropertyPaneConfigResponse.tsx

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-11-02 15:21:14 +05:30
akash-codemonk
ac70e5be4d
Update query form UI (#1500) 2020-11-02 15:01:00 +05:30
Nikhil Nandagopal
2ec5b6297b
Fix/action splitting (#1497)
* fixed argument splitting logic to rely onregex instead of simple string split

* abstracted splitting function
2020-11-02 10:54:15 +05:30
devrk96
7d6a70d3ce
Feature: New create app flow (#1375)
* EditableTextWrapper component implemented

* create new app flow implemented

* test cases for new create new app flow fixed

* role update element fixed

* before-all hooks fixed

* createOrg test cases fixed

* loading state test added

* editableText input unique identifier added in test-cases

* updateApplication API alias name corrected

* removed the second className prop on same component

* PR feedback implemented
2020-10-31 12:10:51 +05:30
Nikhil Nandagopal
5c26ef5d07
Fixed Bindings Working inside action selectors (#1484)
* added functions to convert string to JS and JS to string while manipulating property pane values
refactored getters and setters to reuse functions instead of creating multiple functions

* minor fixes

* optimized the js conversion function and fixed an edge case

* minor fix for type setters

* abstracted enum getter

* dummy commit
2020-10-30 18:05:21 +05:30
vicky-primathon
75c84cbba7
Map resetting when clicking on a marker fix (#1299) 2020-10-29 23:46:27 +05:30
Nuwan Sameera Alawatta
e782ca17e8
fix lightning bolt menu onhover bug (#1454)
* fix lightning bolt create new api onhover bug

* fix lightning bolt menu onhover bug
2020-10-29 19:00:04 +05:30
devrk96
f6bb16a4e6
Fix: Invalid email error in invite modal (#1368)
* Invalid email error showing on entering incorrect email before submission

* error state name corrected

* colon removed from error message
2020-10-29 16:47:52 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356)
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
2020-10-29 16:44:39 +05:30
vicky-primathon
dbf98fde5f
Fix/table widget filter conditions (#1297)
* Table widget isEqualTo and notEqualTo conditions fixed
2020-10-28 21:10:33 +05:30
vicky-primathon
4cd2579dfa
Added horizontal scrolling in table widget (#1436)
* Added horizontal scrolling in table widget

* Handled table grow shrink with display table css property
2020-10-28 19:49:15 +05:30
devrk96
5ebea89d98
Test cases: Application update (#1339)
* application name and icon update test cases implemented

* application icon update test case implemented
2020-10-28 17:36:30 +05:30
devrk96
bc70460093
role change update fixed (#1192) 2020-10-28 17:21:14 +05:30
devrk96
15ab7809f8
Org name, email and website update test cases implemented (#1433) 2020-10-28 11:09:28 +05:30
akash-codemonk
0f34c7f38f
Secure connection UI (#1358) 2020-10-27 10:32:32 +05:30
akash-codemonk
f19810117b
Query editor styling fixes (#1318) 2020-10-21 13:24:10 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
Akshay Avinash
4cd2d94f74
Updated positioning of delete icon and eslint error fix (#1304) 2020-10-20 20:29:28 +05:30
vicky-primathon
56225d2fdd
Rich text editor content with newline is parsed for RTE (#1296) 2020-10-20 13:24:05 +05:30
satbir121
6c1e13a6e9
Revert create new app flow to use the old flow for now (#1265) 2020-10-20 12:44:39 +05:30