Commit Graph

390 Commits

Author SHA1 Message Date
Nikhil Nandagopal
5e17450e2f
added check for no matches (#1673) 2020-11-10 14:52:35 +05:30
Nikhil Nandagopal
6121e6938e
Merge pull request #1576 from appsmithorg/fix/button-ui-invite-modal
Fix: Invite modal cancel button UI
2020-11-06 15:04:10 +05:30
Hetu Nandu
2820413b7d
Fix bad fix for show alert issue #1583 (#1614) 2020-11-06 14:57:10 +05:30
Hetu Nandu
f99291ea2d Revert "Fix still crashing for #1583"
This reverts commit 2c88f11ed4.
2020-11-06 14:17:26 +05:30
Hetu Nandu
2c88f11ed4 Fix still crashing for #1583 2020-11-06 14:08:22 +05:30
Rohit Kumawat
64d053de6e variable name corrected 2020-11-06 13:23:38 +05:30
Rohit Kumawat
d85351526d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/button-ui-invite-modal 2020-11-06 08:47:59 +05:30
akash-codemonk
86cac0fae3
Add test for showBindingPrompt function (#1566) 2020-11-05 19:15:40 +05:30
Hetu Nandu
c1ff711a45 Fix build errors 2020-11-05 17:58:39 +05:30
Nikhil Nandagopal
08b755bdcb
Merge pull request #1591 from appsmithorg/fix/args
Fix for args not splitting correctly with empty values
2020-11-05 17:52:35 +05:30
Hetu Nandu
20f357ae35
Add checks for wrong alert types of Toast messages (#1588)
Fixes #1583
2020-11-05 17:19:37 +05:30
Nikhil Nandagopal
a110a23574
Merge pull request #1169 from daniel-shuy/fix/download-file-type-dropdown-optional
Allow Download File Type dropdown to be deselected
2020-11-05 15:47:18 +05:30
Nikhil Nandagopal
39331d95b2 fix for args not splitting correctly with empty values 2020-11-05 15:46:38 +05:30
Rohit Kumawat
5eff7e7970 cancel button text color fixed 2020-11-05 12:34:44 +05:30
Daniel Shuy
2c5e74313c Add default empty selection for FILE_TYPE_OPTIONS 2020-11-04 20:23:56 +08:00
akash-codemonk
8ae77f7764
Fix prompt showing up always (#1556) 2020-11-04 16:37:10 +05:30
akash-codemonk
ba6aceb096
Fix includes is not a function error crash (#1555)
* Make the value a string to avoid includes is not a function error

* If it is not a string show the prompt
2020-11-04 15:27:11 +05:30
Nikhil Nandagopal
8a1be448e1 added a fix for null crashing a page in bindings 2020-11-03 21:17:16 +05:30
Abhinav Jha
543b7ec72d
Entity Explorer Render (#1354)
* WIP: Performance improvements in entity explorer

* WIP: Achieve feature parity for entity explorer with release

* Update unit tests

* Add sentry profiling to current page entity properties component

* Fix page add/delete not showing up on entity explorer issue. Update memoization logic for pagegroup entity

* Deal with the ban-ts-ignore eslint issues

* Update unit tests

* Fix widget entity children visibility

* Fix tests and code

* Fix tests for scenarios where the collapsed entities are unmount, as this is a part of the performance optimization

* Filter undefined children when generating structureDSL

* Remove rule from eslintrc

Consolidate createPage test command

* Update CreatePage tests to remove redundant dsl updates

* Revert CreatePage test changes, as adding more checks within this command globally causes other tests to have issues.

* re-enable eslint rule, as without it CI tests fail

* Revert to ban-ts-comment

* Fix typescript ban-ts-ignore issue by upgrading react-scripts and fixing typescript issue across the application

* Typescript errors handled

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
2020-11-03 18:35:40 +05:30
Sumanth Yedoti
87a2effbc5
Fix/api URL field twitch (#1495)
Fixes: #1248
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
2020-11-03 12:21:02 +05:30
akash-codemonk
9afcf87156
Show binding prompt when there is no binding in the editor (#1478) 2020-11-03 09:40:07 +05:30
Nikhil Nandagopal
2ec5b6297b
Fix/action splitting (#1497)
* fixed argument splitting logic to rely onregex instead of simple string split

* abstracted splitting function
2020-11-02 10:54:15 +05:30
Nikhil Nandagopal
5c26ef5d07
Fixed Bindings Working inside action selectors (#1484)
* added functions to convert string to JS and JS to string while manipulating property pane values
refactored getters and setters to reuse functions instead of creating multiple functions

* minor fixes

* optimized the js conversion function and fixed an edge case

* minor fix for type setters

* abstracted enum getter

* dummy commit
2020-10-30 18:05:21 +05:30
Nuwan Sameera Alawatta
e782ca17e8
fix lightning bolt menu onhover bug (#1454)
* fix lightning bolt create new api onhover bug

* fix lightning bolt menu onhover bug
2020-10-29 19:00:04 +05:30
devrk96
f6bb16a4e6
Fix: Invalid email error in invite modal (#1368)
* Invalid email error showing on entering incorrect email before submission

* error state name corrected

* colon removed from error message
2020-10-29 16:47:52 +05:30
devrk96
bc70460093
role change update fixed (#1192) 2020-10-28 17:21:14 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
satbir121
6c1e13a6e9
Revert create new app flow to use the old flow for now (#1265) 2020-10-20 12:44:39 +05:30
Yash Joshi
c085fc778d
Fix evaluated pane scrollbar style (#1251)
fixes: #1182
2020-10-19 12:02:07 +05:30
Shrikant Sharat Kandula
0055f01f2f
Remove extraneous scrollbars in API action pane (#1222) 2020-10-16 12:28:34 +05:30
Thakur Karthik
fd9fa46bdd
Fix/fix input size (#1207)
* fix(codemirror-autocomplete): show selection background on hover for options

This fix if merged shows the selection background by hovering on autocomplete
options.

Ref: #946

* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* fix for removing the extra padding in input field

* Revert "Merge branch 'master' of https://github.com/appsmithorg/appsmith into fix/fix-input-size"

This reverts commit 05a97588f8187c5a9f3146214ef523c30d1370d9, reversing
changes made to 4f70eb61e43c1a9270cb6bd05689820351a5b6e0.

* set scrollbarstyle to null in compact mode

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2020-10-16 11:56:03 +05:30
Shrikant Sharat Kandula
4a070c3d92
Fix blank scrollbars on Firefox (#1171)
* Fix blank scrollbars on Firefox

* Hide scrollbars on Firefox for consistency
2020-10-14 10:56:43 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
Thakur Karthik
d476bb14bc
fix(codemirror-autocomplete): show selection background on hover for options (#1134)
This fix if merged shows the selection background by hovering on autocomplete
options.

Ref: #946
2020-10-12 13:49:29 +05:30
satbir121
1cafe307d5
Feature/invitation modal (#938)
* light and dark mode added in Invite modal

* warnings removed

* create org and invite user test cases fixed

* Application invite design implemented

* manage user icon added

* button width fixed

* PR feedback implemented

* test cases fixed

* used blueprint classes

* used calc for width distribution

* copy button width fixed

* prop passing fixed

* copy button size reduced

* readonly input field background color fixed

* input background theme name ordering changed

* TagInputComponent moved to ads

* created DropdownWrapper for select field in orgInviteForm

* Warnings created due to unique key and depdencies is fixed

* Warning fixed in dropdown component

* correct prop name used

Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
2020-10-12 12:45:35 +05:30
Anshul Bansal
776daa61ba
Auto Focus on email fields in auth screens (#923)
Fixes: #610 
Co-authored-by: Anshul <anshul@typito.com>
2020-10-07 12:37:16 +05:30
Nikhil Nandagopal
194f27aabb
Feature/analytics (#1022)
* added appname to PAGE_LOAD data and fixed getCurrentApplication method

* Fixed analytics to save and test datasources

* fixed analytics for create action

* added event for action execution

* added a type for event location
2020-10-06 20:40:21 +05:30
Nikhil Nandagopal
3fdd0a246a
Feature/instrumentation (#744)
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods

* added use effect to stop tracking on mount of entity properties

* removed open api tracking

* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount

* added tracking for entity explorer

* moved from app route to sentry app route because passing JSX to app route causes re-renders

* Fixing theme and route change issues.

* added performance tracking for API / Query execution and Page Load actions

* added isntrumentation to open / close actions

* added instrumentation for apis & actions

* reduced sample rate
added async tracking

* added tracking for property pane

* Remove tracking from reducer

* added option to attach async operations to parent transactions

* Fix typo

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-28 10:42:23 +05:30
Nikhil Nandagopal
d5ac05caf8
Feature/instrumentation (#708)
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods

* added use effect to stop tracking on mount of entity properties

* removed open api tracking

* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount

* added tracking for entity explorer

* moved from app route to sentry app route because passing JSX to app route causes re-renders

* Fixing theme and route change issues.

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
2020-09-24 21:35:18 +05:30
Nikhil Nandagopal
662098d771
Manual Performance Tracking utility (#696)
- Created Performance Tracker to use a queue internally to make synchronous logging easy
- Bump sentry sdk versions
- Added performance tracking for 
  - GENERATE_VIEW_MODE_PROPS
  - GENERATE_API_PROPS
  - ENTITY_EXPLORER_ENTITY
  - GENERATE_PROPERTY_PANE_PROPS
  - GENERATE_WIDGET_EDITOR_PROPS
  - CLOSE_API
    - SYNC_PARAMS_SAGA
    - CHANGE_API_SAGA
  - CONSTRUCT_UNEVAL_TREE
  - DATA_TREE_EVALUATION
    - CREATE_DEPENDENCIES
    - SORTED_DEPENDENCY_EVALUATION
    - SET_WIDGET_LOADING
    - VALIDATE_DATA_TREE
  - CONSTRUCT_CANVAS_DSL
 

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-24 10:17:37 +05:30
Abhinav Jha
114dfd3cbb
Add Tests: Delete widget and Undo delete widget (#556)
* Add selectors for delete trigger, toast action and copy trigger

* Copy/Paste/Delete/Undo test

Co-authored-by: Nandan <nandan@thinkify.io>
2020-09-21 11:27:54 +05:30
Abhinav Jha
436f190555
Feature: Widgets: Cut-Copy-Paste-Delete shortcuts, undo-delete facility (#500) 2020-09-16 15:58:01 +05:30
Hetu Nandu
f09b717b38
Retry dynamic import and lazy promises (#543) 2020-09-15 12:29:58 +05:30
Abhinav Jha
c02a19396f
Fix the stacking context of the sidebar (#533) 2020-09-11 13:50:33 +05:30
Abhinav Jha
70fea0e560
Feature: Add widgets from explorer (#464)
* Deprecate Navbar. Sidebar becomes a panelStack. It now has two panels, WidgetSidebar and Explorer

Co-authored-by: Nandan <nandan@thinkify.io>
2020-09-02 12:14:01 +05:30
Hetu Nandu
f7ec5209cf
Add function to download part of the Data tree as a file (#458) 2020-08-28 17:37:37 +05:30
Nikhil Nandagopal
bdbc73658e
Feature/sentry (#452)
* updated sentry and added performance monitoring

* identify users on sentry

* removed sentry browser

* added the environment for sentry

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-28 14:04:01 +05:30
Abhinav Jha
76072dcb04
Fix Entity Names (#439)
- Fix Page name restrictions to allow for spaces
- Keep new names of entities until failure
2020-08-27 16:05:15 +05:30
Hetu Nandu
d53dfede0e
Feature/new ux bad drop (#440) 2020-08-27 11:33:25 +05:30
Hetu Nandu
487102469f
Add store value action in the action dropdown (#427) 2020-08-26 14:24:03 +05:30