Commit Graph

2907 Commits

Author SHA1 Message Date
rahulramesha
60c4887432
Navigation Dropdown feedback Changes (#6119)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-04 16:23:04 +05:30
akash-codemonk
f413924fd4
Fix: Keep inspect entity in sync with the widget selection in the entity explorer 2021-08-04 15:36:13 +05:30
Nayan
0d106a5c9d
Improvement: Add limit on password length in user signup (#6312)
* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login
2021-08-04 15:33:33 +06:00
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
akash-codemonk
63dc8123bb
Fix: Update debugger placeholder text for non-mac (#6142) 2021-08-04 10:20:27 +05:30
Yash Vibhandik
31f8a708ae
FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)
reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished
2021-08-03 19:06:03 +05:30
Rishabh Rathod
a9f16d75bd
Enable Autocomplete for Static Objects (#6302)
* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action
2021-08-03 13:36:48 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
Satish Gandham
88c92fd2f5
Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)
* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-02 21:36:33 +05:30
Rishabh Saxena
ce6f42683e
Fix comment card click at the view mode (#6332) 2021-08-02 21:15:19 +05:30
rahulramesha
7252975201
more conditions for run check (#6255)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 19:25:43 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering (#5941)
* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Pranav Kanade
2ca224d444
Updated labels Mock data to Sample data (#6330) 2021-08-02 18:14:56 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
2587d78404
Sentry typeError fix, with checks (#6256)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:46:50 +05:30
rahulramesha
a3152c450c
fix stop Rich text Editor from crashing on Modal (#6077)
* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:45:51 +05:30
Rishabh Saxena
5d6d9f75f4
[Fix] Refresh sidebar comments list when a thread is unresolved (#6326) 2021-08-02 16:05:58 +05:30
Rishabh Saxena
4b79291a7f
Fix comment card click: set visible thread (#6166) 2021-08-02 13:55:35 +05:30
Rishabh Saxena
6ee28950be
Minor comments feature fixes (#6245) 2021-08-02 12:57:20 +05:30
Abhinav Jha
cd8407152c
Missing validations (#6281)
* Fix validations for certain scenarios which were missed earlier
2021-08-02 12:53:46 +05:30
Anagh Hegde
9dbb16747e
Add analytics event for mock-data creation (#6136)
* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-02 08:30:56 +05:30
Abhinav Jha
607012388e
Disable tern in view mode (#6203) 2021-07-30 15:54:22 +05:30
Paul Li
334c092fe4
FEATURE-5852 : make the iframe widget message property accessible (#5897)
-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.
2021-07-30 12:06:00 +05:30
Pranav Kanade
44374f5641
[Fix] Small UI improvements to suggested widgets section (#6190)
* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment
2021-07-30 11:25:11 +05:30
akash-codemonk
7e0ebdd6b0
Add missed new nav analytics for connections (#6233)
* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks
2021-07-30 11:23:24 +05:30
Pranav Kanade
e08b748b02
Fix - #6221 new nav analytics improvements (#6223)
* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards
2021-07-30 11:17:38 +05:30
Rishabh Rathod
fbf6d9ad2d
Add Skip tour button in welcome onboarding (#6158)
This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.
2021-07-29 18:37:26 +05:30
Hetu Nandu
8789c4f897
Fix JS error message showing callstack in firefox (#6234) 2021-07-29 17:06:49 +05:30
Rishabh Saxena
7409982674 Revert "Update msg"
This reverts commit 0ac70ea7e9.
2021-07-29 16:28:47 +05:30
Rishabh Saxena
0ac70ea7e9 Update msg 2021-07-29 16:26:33 +05:30
Rishabh Saxena
96615e11b6
Fix xss redirectURL (#6229) 2021-07-29 08:49:46 +00:00
Rishabh Rathod
76dfcd0163
[Feature] Generate template page from datasource (#5513)
- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-29 13:43:10 +05:30
akash-codemonk
1fc6a21898
Fix overflowing text in toasts on safari (#6200) 2021-07-29 13:42:07 +05:30
Rishabh Saxena
2b60519b7c Merge branch 'release-frozen' into release 2021-07-28 13:11:43 +05:30
Rishabh Saxena
8b4e9af1f0
[hotfix][release-frozen] Fix xss iframe source url (#6212) 2021-07-28 13:03:10 +05:30
Arpit Mohan
4d5b366c43
Merge branch 'master' into release-frozen 2021-07-28 12:59:51 +05:30
Rishabh Saxena
f4018f450e
Comments feature related fixes (#6156) 2021-07-28 12:32:11 +05:30
Pranav Kanade
e84b28e825
added another regex to support short youtube video link format (#6192) 2021-07-28 12:06:46 +05:30
Rishabh Saxena
bec7acdcfc
Fix iframe url xss (#6209) 2021-07-28 11:31:09 +05:30
Rishabh Saxena
8f4db40b0f [Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:44:54 +05:30
Rishabh Saxena
7fa2f7e038 [Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:39:45 +05:30
Rishabh Saxena
8638b6951a
[Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:35:33 +05:30
Favour Ohanekwu
b3de24e3e1
changed texts on datasources page (#6130) 2021-07-27 07:15:49 +01:00
rahulramesha
10ff97b3dc
fix for tabelwidget filter bug (#6001)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-27 10:48:52 +05:30
Satish Gandham
ee3890b4b4
[Perf] Increase the code editor debounce time from 300 to 600ms (#5914)
* - Increase the code editor debounce time from 300 to 1000ms

* Decrease the debounce time from 1000 to 600ms

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-27 10:46:02 +05:30
balajisoundar
f6ae3b2d84
Fix #6084: Fix alignment issue with multiselection checkbox when there are (#6123)
no rows present in the table
2021-07-27 10:33:13 +05:30
Pranav Kanade
3547976dc7
[Feature] new nav sniping mode (#5746)
* added sniping mode toggle option to header

* added cover to components on hover in sniping mode

* fixed the transition time

* using filled icon

* Show dependencies in action pane

* Added a wrapper to make a widget snipeable

* removed older parts of sniping from Positioned Container

* removed onclick action from snipeable wrapper

* Showing widget name in different color

* Added a mechanism to send user to sniping mode from successful API screen

* created new property pane saga to bind the data

* Fix datasource list width issue

* Fix sidebar going out of view when the response is a table

* Minor refactor

* Show add widgets section on the sidebar

* Stop showing autocomplete option after adding a widget

* fetching pageId, appId from store

* Get suggested widget from response

* Fix table data not getting evaluated after adding binding

* Fix property pane going below the entity explorer while navigating from query/api pane

* Fix width of sidepane shifting for apis

* Fix vertical margins of connections

* Fix api pane suggested widget showing up for errors

* Fix margins

* can show select in canvas btn in sidebar

* can get the action object at the end to bind the data

* updated saga and action names

* can bind data to table

* Use themes

* Use new image url for Table widget

* Added conditional mapping for sniping mode binding.

* updated the widget name tags and seq of calls to open property pane

* pushed all sniping mode decoration to header

* moved setting sniping mode logic to editor reducer

* Added keyboard short cut to get out of sniping mode

* updated reset sniping mechanism

* removed a divider line

* if there are no relationships, will not show the complete section

* Connect Data will automatically show relevant tab in integrations

* Update list and dropdown image urls

* Remove create table button

* no wrapping bind to text

* minor review considerations

* showing the widget name to left in sniping mode

* can set data to datepicker

* will not show snipe btn if there are no widgets in canvas

* Changes for multiple suggested widgets

* removed dependency of sniping from suggested widgets

* Added analytics events for sniping mode

* logic for binding data to a widget, moved to snipeable component

* changed binding widget func from capture to onClick and took care of sniping from widget wrapper too.

* added tests to check sniping mode for table

* updated test spec

* minor fix

* Fix copy changes

* Update test to use table widget from suggested widget list

* if fails to bind will generate warning and keep user in sniping mode

* in sniping mode will only show name plate if it is under focus

* fixed the test case

* added a comment

* minor fix to capture on click event in sniping mode

* updated text

* Hide connections UI when there are no connections

* Increase width to 90%

* Show placeholder text and back button in sidepane

* Show tooltip on hover

* Add analyitcs events for suggested widgets and connections

* Update label based on whether widgets are there or not

* binding related changes

* renamed the saga file containing sinping mode sagas

* Changes for inspect entity

* Revert "binding related changes" temporarily

This reverts commit 54ae9667fecf24bc3cf9912a5356d06600b25c84.

* Update suggested widgets url

* Update table url

* Fix chart data field not getting evaluated

* a minor fix to show proper tool tip when user hovers on widget name

* Show sidepane when there is output

* Update locators

* Use constants for messages

* Update file name to ApiRightPane

* Remove delay

* Revert "Revert "binding related changes" temporarily"

This reverts commit ee7f75e83218137250b4b9a28fcf63080c185150.

* Fix width

* Fix overlap

Co-authored-by: Akash N <akash@codemonk.in>
2021-07-26 22:14:10 +05:30
Pranav Kanade
109039c342
[Feature] Keep the scroll position into a widget when user switches to comment mode (#6132)
* updated the comment overlay to avoid widget re-rendering when user switches to comment mode

* removed duplicate code.
2021-07-26 18:43:20 +05:30
akash-codemonk
56e29d22f5
Add new nav related analytics (#6125)
Analytics events for the following have been added

- Create new datasource CTA on the property pane
- Run button at the response tab for actions
- Click on associated entity dropdown from the property pane
- Select an associated entity from the associated entity dropdown at the property pane
2021-07-26 16:29:15 +05:30
Vicky Bansal
0e6ff2bebe
Fix-Keep date picker open when selecting time, month, year in Table widget filters (#5991)
Keep date-picker open when selecting time or changing month, year in Table filters, The user before this could not select or change time. We have fixed this by closing the date-picker popover onClick of outside overlay/canvas.
2021-07-26 12:29:53 +05:30