Commit Graph

3527 Commits

Author SHA1 Message Date
Apeksha Bhosale
8d844e3961
changed the logic for tern server def creation (#6071) 2021-07-22 16:19:41 +05:30
Arpit Mohan
634092586b
Merge branch 'master' into release-frozen 2021-07-22 15:21:08 +05:30
Bhavin K
c23925c0c9
handle image download error (#5951)
Fixed an issue where because of the CORS issue the image was not able to download, To fix this we now open the image in a new tab where an error is received.
2021-07-22 14:15:45 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Bhavin K
bd05ab5dc7
fix when component update (#5931)
The custom chart onDataPointClick did not function well in the editor and view more, This is now fixed
2021-07-22 14:11:18 +05:30
Pranav Kanade
22bec1fce7
[Feature] Authenticated API datasource creation (#6017)
* added an oauth datasource tab

* added a comment

* removed warnings

* updated authenticated datasource name

* added a test case to verify new authenticated api card

* can create a simple rest api datasource

* enabled the use of view mode for rest api datasources

* minor fix for centered icons

* added analytics event
2021-07-22 13:25:13 +05:30
akash-codemonk
f1e829fe4a
Feature: Show error state in property pane connections if associated connection has errors (#5877) 2021-07-21 18:10:46 +05:30
NandanAnantharamu
2477c1f5ac
updated spec to wait for postexecute (#6042) 2021-07-21 16:02:40 +05:30
akash-codemonk
89000efffd
Fix: Fix horizontal scroll on overflow in property pane (#5909) 2021-07-21 13:23:14 +05:30
Rishabh Saxena
cf1e5dda19 Fixes related to the comments feature (#5904) 2021-07-21 11:34:57 +05:30
Hetu Nandu
7063ee9d2d
Improve information for cyclic dependency error (#5949) 2021-07-20 16:20:22 +05:30
Rishabh Saxena
745927ffef
Set focused comment based on url and visible thread id (#5992) 2021-07-20 15:44:35 +05:30
Hetu Nandu
ba06d797de
Improve autocomplete sorting (#5798) 2021-07-20 15:32:56 +05:30
Satish Gandham
93c675ba92
Provent property pane title from re-rendering on every state change #5867 (#5876)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-20 12:14:15 +05:30
Tolulope Adetula
32c746d6fe
fix: Menu button truncating (#5970)
The widget tag of menu button widget was broken and overflowing, We fixed that here
2021-07-20 12:09:17 +05:30
Arpit Mohan
9f29dd028d
Improving error message for invalid entities (#5977)
Also removing the toast message for successful action runs. With the debugger, this is no longer required.
2021-07-20 11:07:20 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30
Satish Gandham
fb78233973
[perf] Update redux store with only the values that changed (#5594)
* Pass evaluation order along with dataTree and update only evaluated values in the store.

* - Update the entire changed entitiy

* Make the updates in a way the top level tree reference is changed.

* Clean up.

* - Revert back to using evaluation order and removedPaths as JSON.stringify is expensive

* yarn.lock changes

* Only send eval updates across the worker thread

* - Update the tree with only the updates sent from the worker. (40% improvement)

* Fix evaluation tests

* Remove console.log

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-07-20 10:34:12 +05:30
akash-codemonk
8657a52f09
Fix: Fix create new query in onsubmit not creating a query for onboarding (#5918) 2021-07-20 09:44:32 +05:30
Nayan
6efe78479f
[Enhancement] Add link to unsubscribe from email notification for a comment thread (#5769)
* -added API to and template for unsubscribe  comment thread

* -changed public API url to make it sepratate from client public pages
-included the unsubscribe link to email body

* -made unsubscribe email notification API to private

* -added unsubscribe page

* -removed unused code

* Update app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Comments/UnsubscribeEmail_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/BaseAppsmithRepositoryImpl.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* -updated text as per lint error

* -updated text as per lint error

* -moved unsubscribe screen texts to messages.ts

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-07-20 00:14:38 +06:00
Ayush Pahwa
9560df8492 Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 21:07:44 +05:30
Ayush Pahwa
2cee1b5a7c Added axios call to the special use case of downloading zip files (#5927)
* Added axios call to the special use case of downloading zip files

* Removed console logs, added comments, fixed error handling

* Removed url check from getType, exported a fn to check tif string is a URL

* Changed filter from only zip to binary
2021-07-19 21:07:21 +05:30
Ayush Pahwa
5f950c4080 Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 21:03:49 +05:30
Rishabh Saxena
25a6fd2240
Fixes related to the comments feature (#5904) 2021-07-19 20:58:41 +05:30
Ayush Pahwa
cab6c12471
Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 20:13:37 +05:30
Rishabh Saxena
488e7e20df [Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 19:02:40 +05:30
Rishabh Saxena
7f95e4d268 Enable intercom for self hosted instances (#5871) 2021-07-19 19:02:06 +05:30
Rishabh Saxena
dff61da5ac [Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 18:56:08 +05:30
Rishabh Saxena
6947f4b7a0
[Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 17:36:04 +05:30
Rishabh Saxena
dc012be1de
Enable intercom for self hosted instances (#5871) 2021-07-19 15:34:15 +05:30
NandanAnantharamu
d80bb7a31b
Fix checkbox spec Cypress test (#5952) 2021-07-19 15:28:34 +05:30
Ayush Pahwa
4a06a57cda
Added axios call to the special use case of downloading zip files (#5927)
* Added axios call to the special use case of downloading zip files

* Removed console logs, added comments, fixed error handling

* Removed url check from getType, exported a fn to check tif string is a URL

* Changed filter from only zip to binary
2021-07-17 20:26:06 +05:30
Pranav Kanade
3f34ce08e3
[Fix] Hide binding prompt if auto complete is open (#5911)
* temp

* hiding binding prompt if auto suggestion box is open

* slash btn click works in api pane

* removed unnecessary code
2021-07-16 18:02:48 +05:30
Tolulope Adetula
82d887338a
fix: update JS options (#4475)
Add JS options to widget properties, please check the issue for more details
2021-07-16 17:59:53 +05:30
Paul Li
b6703ebe11
BUG-4058 : Inconsistence in the meta properties fallbacks in widgets (#4167)
Datepicker selected data and formatted date will not be empty on clear and not fallback to default date. This is consistent with other widget behaviour
2021-07-16 17:56:39 +05:30
Trisha Anand
bfaf856c16
Merge branch 'master' into release-frozen 2021-07-16 14:41:33 +05:30
Rishabh Saxena
8f7165b5fe
Update comments onboarding tour (#5903) 2021-07-16 14:01:26 +05:30
Bhavin K
374e8aec4a
datepicker 2 migration 27 added, default response udpated (#5393)
Default Min and Max Date were showing errors, We have fixed it now. This was specific to safari
2021-07-16 12:34:11 +05:30
akash-codemonk
4ddc430411
Fix: Hide connect data cta for certain widgets (#5690) 2021-07-16 09:40:17 +05:30
akash-codemonk
57903ec88c
Fix: Increase initial height for bottom tabs in action screen (#5894) 2021-07-16 09:39:51 +05:30
Pranav Kanade
56caba8f55
[Fix] Support Videos in omnibar (#5873)
* replacing gitbook video embeddings with iframes for youtube videos

* changed func names

* using single regex to select video id and remove embedding
2021-07-15 22:50:21 +05:30
Hetu Nandu
7efc96efd2 Fix code editor width issue (#5895) 2021-07-15 21:18:03 +05:30
Hetu Nandu
855acc4e37
Fix code editor width issue (#5895) 2021-07-15 21:10:26 +05:30
arunvjn
c2ecfa94b3 Fix for slash commands blocker issues
(cherry picked from commit 6c0da9a380)
2021-07-15 20:10:48 +05:30
arunvjn
6c0da9a380
Fix for slash commands blocker issues 2021-07-15 20:08:31 +05:30
Vicky Bansal
fad7874613
Currency datatype in Input Widget (#5049)
Added currency type input to input widget
2021-07-15 18:20:01 +05:30
Rishabh Saxena
cb91221276
Fix globalsearch test: wait for page load (#5883) 2021-07-15 17:10:54 +05:30
yatinappsmith
d8e2488a9b
Disabled maven Tests (#5882) 2021-07-15 16:45:53 +05:30
rahulramesha
3042adbdea
Task/5463 Navigation Bar menu Dropdown (#5575)
* Feature/ Navigation Bar menu

* Cypress test fixes and minor style changes

* Changed some more integration test files and fixed some styling post feedback

* Updated failing tests

* Minor Cypress test change

* requested design changes and Analytics

* resolving conflicts

* minor style fix

* current deploy verbage change

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

* addressing review comments

* Updating discord link with permanent invite

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-15 16:26:18 +05:30
Ashok Kumar M
ccf017be12 Fix: Stop page DSL updates in view mode. (#5843) 2021-07-15 13:03:54 +05:30
akash-codemonk
794ef1bbd6
Fix: Fix bugs related to debugger errors (#5824) 2021-07-15 12:44:42 +05:30
Hetu Nandu
fd612829a2 Revert back to old way of eval (#5851)
This change was introduced in #4446 and #5034
2021-07-15 12:11:18 +05:30
Hetu Nandu
da67128e80 Only add appsmith functions in global scope during trigger evaluation (#5760) 2021-07-15 12:11:01 +05:30
hetunandu
3cc145cd55 Revert "Revert back to old way of eval (#5851)"
This reverts commit a24e0b180a.
2021-07-15 12:04:46 +05:30
Hetu Nandu
a24e0b180a Revert back to old way of eval (#5851)
This change was introduced in #4446 and #5034
2021-07-15 11:30:45 +05:30
Pranav Kanade
8f2e913bc9
[Fix] Query editor fields get appended when switching between Mongo and other SQL Datasource queries. (#5863)
* added a unique key to field wrapper for query editor

* removed a log
2021-07-15 11:02:11 +05:30
Hetu Nandu
a5187aadd5
Revert back to old way of eval (#5851)
This change was introduced in #4446 and #5034
2021-07-15 10:29:04 +05:30
Ayush Pahwa
d54f5b01ca
Updating the URL object in appsmith global object when the pageid is same as the previous one (#5796) 2021-07-14 23:48:21 +05:30
Ashok Kumar M
1ed8c4f587
Fix: Stop page DSL updates in view mode. (#5843) 2021-07-14 22:00:10 +05:30
rahulramesha
9ff4ad7e8a
Fix/5077,5079,5739,5879 video widget name fix (#5823)
remove overriding of shouldComponentUpdate

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-14 16:50:22 +05:30
yatinappsmith
5edd9d0fdb
Wait for server to start before Cypress tests (#5846) 2021-07-14 16:40:48 +05:30
hetunandu
dcfb8f6e48 Revert "Revert back to old way of eval"
This reverts commit ca54f9f21b.
2021-07-14 16:19:01 +05:30
hetunandu
ca54f9f21b Revert back to old way of eval 2021-07-14 16:18:28 +05:30
akash-codemonk
092622e26f
Fix: Reduce initial height of bottom tabs in api/query (#5836) 2021-07-13 19:07:54 +05:30
Hetu Nandu
52311e8944
Only add appsmith functions in global scope during trigger evaluation (#5760) 2021-07-13 18:27:59 +05:30
Hetu Nandu
f0a7a5ab02 Fix top level parallel runs (#5613) 2021-07-13 17:10:10 +05:30
akash-codemonk
41aeaf448d
Fix: Update incorrect type to handle undefined sentry error (#5694) 2021-07-13 15:23:02 +05:30
Paul Li
560db4d4df
Menu button widget (#5334)
* FEATURE-3261 : Menu Widget

-- Perform initial onboarding of the widget, not completed

* FEATURE-3261 : Menu Widget

-- Create a menuItemsControl
-- Create the first MVP of IconSelectControl

* FEATURE-3261 : Add Menu Widget

-- Align add menu item button to the center
-- Build icon select control with a grid popup

* FEATURE-3261 : Menu Widget

-- Create a icon alignment control
-- Complete the property pane of the widget

* FEATURE-3261 : Add Menu Widget

-- Implement the body of the widget
-- Bind into the properties from property pane

* FEATURE-3261 : Menu Widget

-- Fix the issues from the first feedback

* FEATURE-3261 : Menu Widget

-- Fix on the 2nd feedback

* FEATURE-3261 : Menu Widget

-- Fix on issues from IconSelectControl, IconAlignControl

* FEATURE-3261 : Menu Button Widget

-- Rename Menu to MenuButton, accordingly refactoring the relevant codes
-- Change some help content
-- Change styles for icon select control, adding padding for search box

* FEATURE-3261 : Menu Button Widget

-- Bind isDisabled property into the UI
-- Prevent input text of menu item from overflowing
-- Add tooltip feature for icon select control
-- Set the height of the popover content dynamically

* FEATURE-3261 : Menu Button Widget

-- Use POPOVER2_TARGET class name for styling
2021-07-13 13:35:09 +05:30
Rishabh Saxena
bb14742051
[GlobalSearch Results] Update sorting order based on the index of the query (#5543) 2021-07-12 21:14:40 +05:30
Ayush Pahwa
d5a2285c9f
Fix: Value of API's data is different in widgets and entity explorer. Showing curly brackets when empty data is received (#5646)
* Showing curly brackets when empty data is received

* Added type protection for the statement
2021-07-12 17:01:02 +05:30
Ayush Pahwa
06de06c11f
Improved label, updating navigateTo default prams when action type is changed to navigateTo in JS actions (#5532)
* Updating navigateTo default prams when action type is changed to navigateTo

* Gave default value to url, made the query params defaault to empty object rather than the empty curly braces with single quotes
2021-07-12 13:22:27 +05:30
Nikhil Nandagopal
2dba1558e6
removed chat with us for self hosting since we killed github discussions (#5767) 2021-07-10 15:31:53 +05:30
Rishabh Saxena
91e5a5a911
Dont enable comment mode if deactivated (#5766) 2021-07-10 12:50:28 +05:30
Sumit Kumar
727f4aa4b3
Feature: return hint message to user if the expected content type is json but the api response is not a valid json. (#5666)
* return hint message to user if the expected content type is json but the api response is not a valid json.

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-07-09 22:31:50 +05:30
Yash Vibhandik
c7577a23f0
FIX #4676 : added onclick handler and update property pane config to table widget for column type image
added onclick handler and update property pane config to table widget for column type image

* added default value for onclick and remove extra check

* updated TableUtilities test case

* updated cypress test Table_spec
2021-07-09 17:51:51 +05:30
Vicky Bansal
195d3deea7 Support for Google reCaptcha v2 in Button Widget (#5638)
* Handle google recaptcha v2 in button component

* Use same code for recaptcha v2 and v3

* Updated error handling comments

* Added toggle to use google recaptcha v2 with button

* Create separate components for Google recaptcha v2 and v3

* Extract click function from google recaptch v3 component

* Hide recaptcha error badge and show invalid site key error on button key

* Fix isInvalidKey name

(cherry picked from commit 718c257286)
2021-07-09 15:56:31 +05:30
Confidence Okoghenun
f5f73b47c6
Adds YT Setup Videos to Docs (#5744) 2021-07-09 15:54:34 +05:30
Nidhi
193f20ad7a
Redirecting to view mode of datasource after authorization (#5758)
* view mode true

* removed new query btn from view mode for google sheet datasource

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-09 15:13:54 +05:30
Nayan
45198c7d68
Increased maximum image size to be uploaded as profile picture (#5641)
* -increased max image size to upload as profile picture

* -removed unnecessary changes

* -show message on maximum allowed file size
2021-07-09 15:38:14 +06:00
Somangshu Goswami
ad840bb8b4
Change the default object fit property of image widget to contain (#5696)
* Change the default object fit property of image widget to `contain`
2021-07-09 13:35:14 +05:30
NandanAnantharamu
763f9ac77c
Fixing Flaky tests (#5578)
* Fix flaky Org tests

* updated log spec

* Removed unwanted calls
2021-07-09 12:41:07 +05:30
akash-codemonk
0f96469e03 Add try/catch (#5731) 2021-07-09 12:30:53 +05:30
akash-codemonk
45276c9e56 Analytics for debugger errors (#5660) 2021-07-09 12:30:45 +05:30
Hetu Nandu
0f32cf10b6 Handle exception where prepared statements viewer does not get a value (#5531) 2021-07-09 12:17:46 +05:30
NandanAnantharamu
eea53bc1e0
Fix image widget spec for property pane click changes (#5707) 2021-07-09 10:22:57 +05:30
Pranav Kanade
8e3c630c20 on google sheet deletion success, redirecting user to active datasources (#5748)
(cherry picked from commit 75eff29b03)
2021-07-09 10:14:00 +05:30
Pranav Kanade
75eff29b03
on google sheet deletion success, redirecting user to active datasources (#5748) 2021-07-09 09:43:18 +05:30
akash-codemonk
5e39c75d9b
Add try/catch (#5731) 2021-07-08 18:14:31 +05:30
Vicky Bansal
718c257286
Support for Google reCaptcha v2 in Button Widget (#5638)
* Handle google recaptcha v2 in button component

* Use same code for recaptcha v2 and v3

* Updated error handling comments

* Added toggle to use google recaptcha v2 with button

* Create separate components for Google recaptcha v2 and v3

* Extract click function from google recaptch v3 component

* Hide recaptcha error badge and show invalid site key error on button key

* Fix isInvalidKey name
2021-07-08 17:32:08 +05:30
Rishabh Saxena
0a0cbec488 Filter out undefined values from the recent entities array (#5724) 2021-07-08 16:13:58 +05:30
Bhavin K
f471a269b1
Feature/image rotation (#4674)
Developers now have the control to allow users to rotate or download image. These settings are available in the property pane.
2021-07-08 16:10:22 +05:30
Rishabh Rathod
c27974b2a2
Replace pluginName with packageName in mockDB creation (#5720)
* replace pluginName with packageName in mockDB creation

* Replace pluginName with packageName

Co-authored-by: Anagh Hegde <anagh@appsmith.com>
2021-07-08 16:03:41 +05:30
Rishabh Saxena
499fe6fe9b
Filter out undefined values from the recent entities array (#5724) 2021-07-08 15:59:59 +05:30
Tolulope Adetula
814823aab8
fix: filterable default value (#4657)
The enable filter switch in the select widget property pane shows up as false but the widget component shows it. Fixed.
2021-07-08 15:53:12 +05:30
Rishabh Saxena
525367fdb0 Add null checks for recent entities (#5722) 2021-07-08 15:43:36 +05:30
Rishabh Saxena
c4d3160fd6
Add null checks for recent entities (#5722) 2021-07-08 15:21:28 +05:30
Pranav Kanade
f28b9bd20b
[Fix] create new api not working from saved google sheet state (#5681)
* fix show proper icons for queries

* Using query creation action creator for google sheet

* Properly setting up action config, if data source is of type api

* minor loading state fixed

* fixed warnings

* Handling the action for apis as well

* Re introduced the new query btn for google sheets
2021-07-08 12:47:56 +05:30
Pawan Kumar
b0a6cc87dd
Widget Context Menu (#5698)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* fix list widget overflow issue

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-07-08 12:38:42 +05:30
Hetu Nandu
0c0e165ee0
Improve Codemirror mount performance (#5497) 2021-07-08 12:34:47 +05:30
Pawan Kumar
f19102d997
Widget Grouping Context Menu (#5284)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* fix list widget overflow issue

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-07-08 12:00:19 +05:30