Commit Graph

53 Commits

Author SHA1 Message Date
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Arpit Mohan
c1de6ce8f7 Fixing prettier errors in DynamicBindingUtils 2020-12-10 17:22:18 +05:30
Hetu Nandu
f312320940
Remove unsafe functions from eval (#2076) 2020-12-10 14:00:49 +05:30
Pawan Kumar
1aea90c404
Fix: Persist of default values even after delete of widget (#1929)
* clear cache values on delete

* added test cases

* add reload in test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-01 10:56:35 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625)
Implements #1575
2020-11-12 16:53:32 +05:30
Hetu Nandu
9cc94777f2 Remove extra dependency and use browser atob and btoa 2020-11-06 14:04:10 +05:30
Hetu Nandu
6dc40970ef
Fix async evaluation issues (#1348)
* Fix issue with deleted widgets still showing up in binding reference

* Fix for firefox not letting errors pass through
2020-10-22 18:45:50 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
Nikhil Nandagopal
6922b9b564
added a fix so that sub dependencies did not look into prototype chain (#771)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-28 19:12:50 +05:30
Hetu Nandu
bff5527dfc Fix issue where unknown functions in data tree cause evaluation issues (#722)
Solved by removing functions before setting the evaluatedValues map of a widget
2020-09-25 12:11:18 +05:30
Nikhil Nandagopal
d5ac05caf8
Feature/instrumentation (#708)
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods

* added use effect to stop tracking on mount of entity properties

* removed open api tracking

* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount

* added tracking for entity explorer

* moved from app route to sentry app route because passing JSX to app route causes re-renders

* Fixing theme and route change issues.

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
2020-09-24 21:35:18 +05:30
Nikhil Nandagopal
662098d771
Manual Performance Tracking utility (#696)
- Created Performance Tracker to use a queue internally to make synchronous logging easy
- Bump sentry sdk versions
- Added performance tracking for 
  - GENERATE_VIEW_MODE_PROPS
  - GENERATE_API_PROPS
  - ENTITY_EXPLORER_ENTITY
  - GENERATE_PROPERTY_PANE_PROPS
  - GENERATE_WIDGET_EDITOR_PROPS
  - CLOSE_API
    - SYNC_PARAMS_SAGA
    - CHANGE_API_SAGA
  - CONSTRUCT_UNEVAL_TREE
  - DATA_TREE_EVALUATION
    - CREATE_DEPENDENCIES
    - SORTED_DEPENDENCY_EVALUATION
    - SET_WIDGET_LOADING
    - VALIDATE_DATA_TREE
  - CONSTRUCT_CANVAS_DSL
 

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-24 10:17:37 +05:30
Nikhil Nandagopal
4995706679
Fix chart data evaluation (#548)
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval

* added a migration for older charts that have their data as strings

* flagged column actions as an action trigger to avoid evaluating it

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-15 22:24:15 +05:30
Nikhil Nandagopal
7724fe5d82
Feature/intercom (#521)
* removed duplicate user object
removed id field which is never populated
added help modal in applications page and intercom to load in help modal
shutdown intercom on signout to clear existing chats

* added analytics to help modal and invite user
unescaped bindings before evaluation to prune newlines

* updated action confirmation text

* added a check to ignore old properties which are no longer dynamic

* fixed test case

* fix tests

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-10 12:56:55 +05:30
Hetu Nandu
4a6717889c
Streamline action save with widgets (#10)
- Remove drafts from actions
- Direct update action from forms
- Debounced saving of actions
- Add org id in default datasource
- Merge query and api run saga
2020-07-03 14:28:58 +05:30
Hetu Nandu
ded1a130e3 Action draft fixes 2020-06-18 14:16:49 +00:00
Hetu Nandu
cb2867069f Action creator evaluated value fixes 2020-06-10 12:16:50 +00:00
Hetu Nandu
e401844014 Fix Chart series data 2020-06-05 16:20:23 +00:00
Hetu Nandu
d9540f8927 Evaluated value popup 2020-06-04 13:49:22 +00:00
Hetu Nandu
44e657fe12 refactored function name
reverted binding logic
2020-06-03 17:27:24 +00:00
Vicky Bansal
747c3d5d8b Chart validations, Tabs add new tab issue fix 2020-05-29 06:07:56 +00:00
Hetu Nandu
91783b840c Fix minor data tree issues 2020-04-27 07:31:04 +00:00
Hetu Nandu
b346969465 fixed date picker default value down to the ms
fixed sharing of cachedDependency values
2020-04-23 14:57:37 +00:00
Satbir Singh
a2086d2b5f Action selector refactor 2020-04-20 05:42:46 +00:00
Hetu Nandu
a266472e4e Fix batched action execution 2020-04-17 16:15:09 +00:00
Nikhil Nandagopal
1a1c703126 added fast get eval with a debounce.
added cache dependency creation but doesn't work
2020-04-10 08:48:00 +00:00
Satbir Singh
1a71c8f317 Default option value multi select 2020-03-31 03:21:35 +00:00
Hetu Nandu
80db9eb030 Performance instrumentation 2020-03-23 12:40:17 +00:00
Hetu Nandu
d9dee9b16d Form Widget 2020-03-06 09:45:21 +00:00
Hetu Nandu
ce0f3b933a Critical fixes 2020-03-03 06:51:59 +00:00
Hetu Nandu
5e0beb9fe7 Property Pane - Convert control to dynamic 2020-02-26 12:44:56 +00:00
Hetu Nandu
fb80c4b576 Action refactor 2020-02-18 10:41:52 +00:00
Hetu Nandu
ef245c1c8d P0 fixes 2020-02-03 11:49:20 +00:00
Hetu Nandu
0dd25ba2ef Refactor Widget loading 2020-01-30 13:23:04 +00:00
Hetu Nandu
9b00a345ad Various P0 fixes 2020-01-27 13:53:33 +00:00
Hetu Nandu
cc50beb0a0 Add back derived properties 2020-01-17 09:28:26 +00:00
Hetu Nandu
91ecf6ebac unescaping any strings 2020-01-08 16:20:49 +05:30
Hetu Nandu
3ecad24203 Fixes for Dynamic Input styling 2020-01-02 13:36:35 +00:00
Hetu Nandu
f1be938bb3 Recursive dynamic binding resolution 2019-12-30 07:39:53 +00:00
Hetu Nandu
d5e08b5836 Validation Error Message display 2019-12-10 13:30:16 +00:00
Hetu Nandu
f45d2b9135 Data Tree Autocomplete 2019-12-06 13:16:08 +00:00
Satbir
1f267954ef Tests for dynamic binding parse. 2019-12-02 15:21:18 +05:30
Satbir
431d127a74 Renaming data binding regex. 2019-12-02 13:07:33 +05:30
Satbir
8cbdd84857 Renaming extractDynamicBoundValue to evaluate. 2019-12-02 13:06:20 +05:30
Satbir
6e0155664e Removing performance.now and trace. 2019-11-28 09:29:15 +05:30
Satbir
48fa52d9ba Adding JS execution functionality. 2019-11-28 09:26:44 +05:30
Hetu Nandu
fbb7742f0e moved to absolute paths for all fiels 2019-11-25 10:37:27 +05:30
Hetu Nandu
a2b275bade Validation parse widget property 2019-11-22 13:12:39 +00:00
Hetu Nandu
a6f7882d5f Revamp widget property validation 2019-11-19 12:44:58 +00:00