Commit Graph

14 Commits

Author SHA1 Message Date
albinAppsmith
629999f124
feat: [epic] appsmith design system version 2 deduplication (#22030)
## Description

### Fixes
- [x] https://github.com/appsmithorg/appsmith/issues/19383
- [x] https://github.com/appsmithorg/appsmith/issues/19384
- [x] https://github.com/appsmithorg/appsmith/issues/19385
- [x] https://github.com/appsmithorg/appsmith/issues/19386
- [x] https://github.com/appsmithorg/appsmith/issues/19387
- [x] https://github.com/appsmithorg/appsmith/issues/19388
- [x] https://github.com/appsmithorg/appsmith/issues/19389
- [x] https://github.com/appsmithorg/appsmith/issues/19390
- [x] https://github.com/appsmithorg/appsmith/issues/19391
- [x] https://github.com/appsmithorg/appsmith/issues/19392
- [x] https://github.com/appsmithorg/appsmith/issues/19393
- [x] https://github.com/appsmithorg/appsmith/issues/19394
- [x] https://github.com/appsmithorg/appsmith/issues/19395
- [x] https://github.com/appsmithorg/appsmith/issues/19396
- [x] https://github.com/appsmithorg/appsmith/issues/19397
- [x] https://github.com/appsmithorg/appsmith/issues/19398
- [x] https://github.com/appsmithorg/appsmith/issues/19399
- [x] https://github.com/appsmithorg/appsmith/issues/19400
- [x] https://github.com/appsmithorg/appsmith/issues/19401
- [x] https://github.com/appsmithorg/appsmith/issues/19402
- [x] https://github.com/appsmithorg/appsmith/issues/19403
- [x] https://github.com/appsmithorg/appsmith/issues/19404
- [x] https://github.com/appsmithorg/appsmith/issues/19405
- [x] https://github.com/appsmithorg/appsmith/issues/19406
- [x] https://github.com/appsmithorg/appsmith/issues/19407
- [x] https://github.com/appsmithorg/appsmith/issues/19408
- [x] https://github.com/appsmithorg/appsmith/issues/19409

Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers
about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in>
Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com>
Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-05-20 00:07:06 +05:30
Sangeeth Sivan
02b5e7d7f6
chore: update upgrade page with s3 assets, get instance id(#20562) 2023-02-12 01:13:53 +05:30
Sangeeth Sivan
e4857851a9
chore: upgrade page changes & license route removed on CE (#20412)
## Description

Updated the image on upgrade page. Removed license route on CE.

Fixes [#303](https://github.com/appsmithorg/cloud-services/issues/303)


Media
<img width="1440" alt="Screenshot 2023-02-07 at 3 59 30 AM"
src="https://user-images.githubusercontent.com/74818788/217102992-f542094a-8563-450f-b81b-e6ceea74e9e8.png">
![Screenshot 2023-02-07 at 3 59 30 AM
(2)](https://user-images.githubusercontent.com/74818788/217103001-9d630000-7ecb-4131-ad73-3c65d3639f34.png)


## Type of change

> Please delete options that are not relevant.
- Chore (housekeeping or task changes that don't impact user perception)



## How Has This Been Tested?
- Manual


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-02-08 13:05:35 +05:30
Sangeeth Sivan
ad5d236a05
chore: [Usage & billing] change upgrade hook link and refactor upgrade to BE page (#20312)
## Description

Updates the redirection link when the user clicks on `Upgrade`. Also
renders the background in CSS instead of using still image as an
placeholder.

Fixes #20313 


Media
![Screenshot 2023-02-02 at 2 09 25
PM](https://user-images.githubusercontent.com/74818788/216273606-99c88da1-c047-4940-ae24-4ba532c6a976.png)



## Type of change

> Please delete options that are not relevant.

- Chore (housekeeping or task changes that don't impact user perception)



## How Has This Been Tested?
- Manual


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-02-03 09:48:50 +05:30
Ankita Kinger
bfd242f627
chore: Updating the graphics for Access control upgrade page (#19154)
## Description

> Updating the graphics for the Access control upgrade page. Also,
removing the feature flag.

Fixes [#19072](https://github.com/appsmithorg/appsmith/issues/19072)

## Type of change

- Uptaing images


## How Has This Been Tested?
> Locally checked that the new images are being used

- Manual

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-23 13:39:36 +05:30
Ankita Kinger
b7d00d2498
feat: Adding an upgrade page for Access control (#18554)
* updated content for access control upgrade page

* added feature flag and moved content to message constants

* adding feature flag for RBAC

* updated some styles

* added a missing comma

* removed width on trigger details container

* updated some styles
2022-12-04 20:12:35 +05:30
f0c1s
9db612cf92
fix: upgrade page for audit logs with correct data (#17697)
## Description

This PR fixes:
- content that was repeated
- has new images
- removes comments
- brings text to messages file

## Compare

| OLD | NEW |
| - | - |
| ![security-and-compliance](https://user-images.githubusercontent.com/1573771/196636819-325d2a42-e992-43a3-91e6-9a1580ddd003.svg) | ![security-and-compliance](https://user-images.githubusercontent.com/1573771/196636392-f9778aef-4f8b-41a5-8408-4e0f636a1437.svg) |
| ![debugging](https://user-images.githubusercontent.com/1573771/196636997-b19c1886-7d7c-460f-a0ea-69ae0030bbe8.svg) | ![debugging](https://user-images.githubusercontent.com/1573771/196637039-389ceb6d-f408-402d-8c0e-3d431fd0dda6.svg) |
| ![incident-management](https://user-images.githubusercontent.com/1573771/196637122-743c03d3-7bd3-4f9b-8a3c-eb0e74735cde.svg) | ![incident-management](https://user-images.githubusercontent.com/1573771/196637182-281a318b-a609-4a74-b5d9-6dabc5d08bfd.svg) |
2022-10-21 10:42:59 +05:30
f0c1s
d2ba72306f
feat: upgrade hooks | audit logs (#17525) 2022-10-17 18:39:09 +05:30
imgbot[bot]
1427d88d3d
chore: [ImgBot] Optimize images (#16991) 2022-10-07 23:49:45 +05:30
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
imgbot[bot]
3eec0594f7
chore: [ImgBot] Optimize images (#9208)
*Total -- 929.35kb -> 640.18kb (31.11%)

/deploy/helm/images/helm-ssl-config.png -- 194.07kb -> 104.73kb (46.03%)
/static/images/client-wsl-yt-video-thumbnail.png -- 690.06kb -> 490.46kb (28.93%)
/app/client/src/assets/icons/widget/table/checkbox-line.svg -- 0.20kb -> 0.19kb (7.77%)
/app/client/src/assets/icons/widget/table/checkbox-check.svg -- 0.21kb -> 0.20kb (7.41%)
/app/client/src/assets/icons/comments/commentCursor.svg -- 1.10kb -> 1.07kb (3.1%)
/app/client/src/assets/icons/widget/recorder/recorder_recording.svg -- 0.14kb -> 0.14kb (2.74%)
/app/client/src/assets/icons/widget/recorder/recorder_pause.svg -- 0.23kb -> 0.23kb (2.53%)
/app/client/src/widgets/AudioWidget/icon.svg -- 0.39kb -> 0.39kb (1.98%)
/app/client/src/assets/icons/widget/recorder/recorder_complete.svg -- 0.23kb -> 0.23kb (1.67%)
/app/client/src/assets/icons/comments/unpinIcon.svg -- 0.28kb -> 0.27kb (1.41%)
/app/client/src/assets/icons/control/underline1.svg -- 0.77kb -> 0.76kb (1.27%)
/app/client/src/assets/icons/ads/plus.svg -- 0.24kb -> 0.24kb (1.22%)
/app/client/src/widgets/TextWidget/icon.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/assets/icons/ads/arrow-right-line.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/assets/icons/ads/up-arrow.svg -- 0.26kb -> 0.26kb (1.11%)
/app/client/src/assets/icons/ads/down-arrow.svg -- 0.29kb -> 0.28kb (1.02%)
/app/client/src/assets/icons/ads/dropdown.svg -- 0.23kb -> 0.23kb (0.83%)
/app/client/src/assets/icons/menu/run.svg -- 0.41kb -> 0.41kb (0.71%)
/app/client/src/assets/svg/no_entities_found.svg -- 0.98kb -> 0.98kb (0.7%)
/app/client/src/assets/icons/ads/snippet.svg -- 0.57kb -> 0.56kb (0.69%)
/app/client/src/assets/icons/ads/share-2.svg -- 0.46kb -> 0.46kb (0.63%)
/app/client/src/assets/icons/widget/recorder/recorder_default.svg -- 0.94kb -> 0.93kb (0.63%)
/app/client/src/assets/icons/widget/button-group.svg -- 1.29kb -> 1.28kb (0.53%)
/app/client/src/widgets/ButtonGroupWidget/icon.svg -- 1.29kb -> 1.28kb (0.53%)
/app/client/src/assets/icons/menu/beta.svg -- 1.00kb -> 1.00kb (0.49%)
/app/client/src/assets/svg/checkmark.svg -- 0.23kb -> 0.23kb (0.43%)
/app/client/src/assets/icons/menu/js-function.svg -- 0.91kb -> 0.91kb (0.43%)
/app/client/src/assets/icons/menu/js-group.svg -- 1.81kb -> 1.80kb (0.38%)
/app/client/src/assets/icons/ads/file-copy-line.svg -- 0.86kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/control/color-picker.svg -- 1.46kb -> 1.45kb (0.34%)
/app/client/src/assets/icons/ads/git-commit-line.svg -- 0.88kb -> 0.88kb (0.33%)
/app/client/src/assets/icons/ads/key-2-line.svg -- 1.28kb -> 1.28kb (0.31%)
/app/client/src/assets/icons/menu/js-file.svg -- 2.33kb -> 2.32kb (0.29%)
/app/client/src/assets/icons/widget/recorder/recorder_no_permission.svg -- 1.63kb -> 1.63kb (0.24%)
/app/client/src/assets/icons/ads/support.svg -- 1.23kb -> 1.22kb (0.24%)
/app/client/src/assets/icons/ads/cloudy-line.svg -- 1.38kb -> 1.38kb (0.21%)
/app/client/src/assets/icons/ads/user-v2.svg -- 1.55kb -> 1.54kb (0.19%)
/app/client/src/assets/icons/ads/upload-v2.svg -- 1.76kb -> 1.75kb (0.17%)
/app/client/src/assets/icons/ads/shield-success.svg -- 3.03kb -> 3.03kb (0.13%)
/app/client/src/assets/icons/ads/shield-error.svg -- 3.03kb -> 3.03kb (0.13%)
/app/client/src/assets/icons/ads/git-branch.svg -- 2.80kb -> 2.80kb (0.1%)
/app/client/src/assets/svg/loader-2-fill.svg -- 3.78kb -> 3.78kb (0.1%)
/app/client/src/assets/icons/ads/gear.svg -- 3.23kb -> 3.23kb (0.09%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-11-19 09:43:30 +05:30
haojin111
d3c3707ad3
feat: git sync - add error, progress states to connect and merge tabs (#9007)
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
2021-11-09 15:21:18 +05:30
Rishabh Rathod
a4c3c6ca9d
fix: Remove Success GIF and Add Tick Animation (#7925)
- Decreased the delay to 3 seconds and
- Added CSS animation instead of GIF which reduces the load time.
- Added Placeholder image for the information image to show while it is loading.
2021-10-13 09:43:57 +00:00
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30