Commit Graph

5017 Commits

Author SHA1 Message Date
Rimil Dey
be5d8d9924 Add a field for the post message api exposure 2022-06-24 09:20:07 +05:30
Arsalan Yaldram
b4347b44e1
fix: menu button icon alignment fixed. (#14644) 2022-06-24 00:59:07 +05:30
Arsalan Yaldram
130451ade0
fix: show cancel button on left pane resize (#14531) 2022-06-23 23:42:24 +05:30
Arsalan Yaldram
932ff31a68
fix: container gap with wrapper on border radius (#14530) 2022-06-23 23:25:03 +05:30
Arsalan Yaldram
cf4eebde39
fix: added focus border for numeric input buttons (#14709) 2022-06-23 22:33:30 +05:30
Aishwarya UR
906cbe1f3f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-23 21:01:19 +05:30
rahulramesha
07ded0dacc
feat: Deprecation warning message update to reference the widget that is replacing it (#14532)
* reference replacement widget in the deprecation warning message

* updated import path for messages

* adding test case for validating deprecated widget COnfig
2022-06-23 20:39:00 +05:30
f0c1s
b97042a38a
fix: disable branch dropdown until merge status returns (#14540) 2022-06-23 10:27:35 +05:30
f0c1s
ab3766adbe
chore: throttle git apis (#14639) 2022-06-23 10:22:25 +05:30
ChandanBalajiBP
abaafab74b Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-22 17:43:51 +05:30
Anand Srinivasan
ed59802702
add analytics log on app crash (#14575) 2022-06-22 16:00:33 +05:30
Tolulope Adetula
7ba4f0679a
Merge pull request #13129 from appsmithorg/fix/12161-multiselects-broken-in-modal
fix: Popover in Multi select widget inside modals breaks away from the widget
2022-06-22 09:59:00 +01:00
ashit-rath
5a7940ae2b
fix: JSONForm - Generate Form button apply theme on new fields (#14687) 2022-06-22 14:21:53 +05:30
Pawan Kumar
790452cc74
fix: Edit App button not confirming to the theme (#14629)
* fix edit button not rendering issue

* dummy push to make vercel build again

* Removing wait time aft Publish - tetsing fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-22 12:30:17 +05:30
Aswath K
7ce8cd8848
fix: JS toggle issue for dropdown control with numeric value (#14648)
* fix: JS toggle issue for dropdown control with numeric value

* fix jest tests
2022-06-22 11:53:54 +05:30
Bhavin K
f218642fc5
fix: show the error message in input widget (#14460) 2022-06-22 06:09:50 +00:00
Arsalan Yaldram
c8f4dd04b5
Merge pull request #14718 from appsmithorg/fix/editorutils
fix: editor utils moment async import
2022-06-22 11:05:33 +05:30
akash-codemonk
b6641f48a3
chore: add analytics events for to see how a user moves from the canvas to any other file (#14385) 2022-06-22 09:31:49 +05:30
Tolulope Adetula
31f91f6e1c fix: use ESC to close dropdown 2022-06-22 01:11:29 +01:00
ChandanBalajiBP
b4c6b0b49a Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-21 22:11:53 +05:30
Bhavin K
3edfa32d93
fix: the rating widget breaking on dropping issue(#14509) 2022-06-21 16:31:05 +00:00
Arsalan Yaldram
f58451aa5f
feat: upgrade to create react app 5 (#14000)
* Updated Typescript types.

* Typefixes after merge with release.

* chore: GenericApiResponse Removed alltogether.

* chore: resolved ApiResponse unknown errors removed PageListPayload.

* Added shouldBeDefined.

* fix: Resolved type errors.

* fix: Typescript upgrade to 4.5 and type fixes.

* feat: upgrade to cra 5

* feat: uncomment service worker registeration

* force secure websocket protocol

* jest test fixes

* fix: react function lint rule removed

* fix: klona test case.

* fix: typescirpt issues resolved

* fix: timeout for colorpicker test and change env.

* feat: update client-build.yml file

* fix: remove brotliplugin use compression plugin

* fix: build config fixed

* fix: upgrade webpack plugin

* fix: add branchbutton test to todo.

* fix: remove branch button test.

* fix: Add tailwind theme values, fix cypress tests

* fix: Typescript type fixes.

* feat: run jest tests in silent mode

* fix: cypress rgb values add branchbutton jest test

* fix: review comments, fixes for error.message

* fix: increase cache size for the workbox

* fix: remove OrgApi.ts file

* fix: cypress.json file remove credentials

* fix: downgrade react and react-dom packages

Co-authored-by: rahulramesha <rahul@appsmith.com>
2022-06-21 19:27:34 +05:30
Trisha Anand
c3bc8ae89b
fix: handled content type none in API 2022-06-20 17:10:51 +05:30
ChandanBalajiBP
3b60d16d1f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-20 13:38:38 +05:30
Rishabh Rathod
f7b2c17136
fix: storeValue functionality & handle multiple action completion (#14658)
Instead of waiting for the specific `storeValue` action completion, earlier we were waiting for any storeValue action to complete. It means when running multiple storeValue, completion of 1st action will resolve promise for all the storeValue triggered. 

Now, we track completion of each storeValue action separately.
2022-06-20 13:35:14 +05:30
Tolulope Adetula
2c6054f72d Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-20 07:01:19 +01:00
ChandanBalajiBP
7a900cd558 fix: updated logic to not have content type none 2022-06-18 11:56:45 +05:30
Ashit Rath
90532f123c merged latest release 2022-06-17 11:42:56 +05:30
Aswath K
bd33b76c1d
feat: widget fuzzy search (#14464)
* widget fuzzy search POC

* fix threshold

* Makes fuse to initialize only once

* add proper dependancy to useEffect

* Adds more search terms

* Adds search term for other widgets

* reduce distance for better search results
2022-06-17 08:42:47 +05:30
Pawan Kumar
a38f484ede
fix: In Table widget for button/icon/menu type when Button Color is selected as Theme color and we toggle JS {{or}}}} is displayed (#14492)
* fix table widget color picker bug

* fix table widget color picker bug

* fix font issue on navigating to edit mode from view mode

* code review feedback
2022-06-16 16:46:05 +05:30
Aswath K
478ae29b34
feat: Disable js toggle button if field is not empty (#12754)
* feat: Disable js toggle button if field is not empty and on non-default value

* allows certain values based on control type

* adds handling for more control types

* Change disabled message

* feat: makes option control delete button keyboard accessible

* adds support for theme values

* Adds support for border radius & box shadow controls

* message change and refactor

* minor correction in the message

* Add proper condition for Datepicker control

* fix one cypress test

* updated tests

* add checks for OptionControl

* Updated table binding test

Co-authored-by: apple <nandan@thinkify.io>
2022-06-16 15:17:35 +05:30
Aswath K
06422d1ce2
fix: Issues with widget name focus (#14504)
* fix: black border on organisation menu name

* fix: not focusing on widget name on reflow
2022-06-16 14:33:06 +05:30
ChandanBalajiBP
0f1a64d906 Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-16 11:50:34 +05:30
ChandanBalajiBP
24d1ac1018 added test cases with requireed changes 2022-06-16 11:48:44 +05:30
akash-codemonk
1514734b27
fix: hide focus pointer when the associated element is out of view in welcome tour (#14216) 2022-06-16 10:04:42 +05:30
ChandanBalajiBP
20f652b543 Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-15 23:25:26 +05:30
Ankita Kinger
9b7944e7ee
feat: migrate organisation to workspace (#13863)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* migrated a few missed out org to workspace

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* fixed AppsmithRole

* mongodb version update

* fixed compile error

* fixed compile issue

* fixed some tests

* simplified embedded mongodb config

* updated a cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-06-15 21:07:41 +05:30
Anand Srinivasan
ef6a2452b5
List copy - update dynamic trigger path list names (#14334) 2022-06-15 15:54:04 +05:30
akash-codemonk
0ddab71a79
fix: hide explorer toggle icon in preview mode (#14318) 2022-06-15 13:52:53 +05:30
Favour Ohanekwu
6c45270def
fix: order async functions in settings tab alphabetically (#13731)
* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* fix merge conflict

* JSFunctionnExe spec flow fix

* update cypress tests

* update cypress tests

* add test case for cloning page

* Datatypes - Numeric spec addition

* failure fixes

* JSfun failure fix

* Postgres failure fix

* JSFuncExecutions failure fix

* MySQL failure point fix

* COmmunity issues wait time fix

* Fixing toast mesg validation point

* Reverting all fixes

* Revertion

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:46:53 +05:30
Pawan Kumar
89bf40e3d7
fix: Toast shows wrong theme name when changing themes (#14488)
* fix typo in toast when changing theme

* fix cypress test

* Added wait time!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:21:37 +05:30
Anand Srinivasan
8b68af1d85
fix: cyclic dependency on array of objects removal (#13962)
* initial fix

* remove un-necessary diff event

* add array accessor dependencies

* init tests

* updated test case

* create folder

* move file

* nested array test cases

* simplify test cases

* comments

* clean up

* evaluation utils test

* remove test

* add back tests and merge
2022-06-15 06:47:57 +00:00
Ayush Pahwa
d220ed428a
Skipping parse of empty array response (#14502)
- When we get a response from API, the data can be either null, undefined, not an array and an array but with no data
- We had handled for everything else except the case of empty array
- This commit fixes that

- We run a query which will return an empty array as response
- We check if application is crashing because of this
2022-06-15 10:59:57 +05:30
Rishabh Rathod
35aa6536d9
fix: mutliple onPageLoad api call (#14484)
* fix: mutliple onPageLoad api call
* fix postgres spec
2022-06-13 19:26:06 +05:30
rahulramesha
f6cfe32bc7
chore: remove addChildrenSaga dead code and it's associated redux actions (#14425) 2022-06-13 11:31:25 +05:30
Rishabh Rathod
4e13fc5125
fix: AppViewer init and page fetch logic (#14294)
OnPageSwitch we need not `initializeAppViewPage` but instead, only `fetchPublishedPage` this changes fixes that.
2022-06-10 18:22:59 +00:00
f0c1s
3594cb3d24
Slowed down git commit and discard progress bar (#14196) 2022-06-10 08:28:57 +05:30
f0c1s
4e2f6d902a
Fix fallback url for git documentation (#14430) 2022-06-10 08:28:19 +05:30
Ankita Kinger
3b62e3f26a
Refactor code for RBAC feature (#14426) 2022-06-10 07:35:30 +05:30
Aswath K
c096027a54
fix: Editable being autofocused on Application card (#14393) 2022-06-10 00:47:48 +05:30
ChandanBalajiBP
aaa2bc1f2f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-09 23:29:03 +05:30
Tolulope Adetula
ddaf283f00 fix: add code comments 2022-06-09 13:50:17 +01:00
rahulramesha
c1da8a6866
fix: paste widgets on a new page (#14295)
* paste widget on generate Page

* adding cypress tests
2022-06-09 17:17:47 +05:30
rahulramesha
abf5821d32
fix: select Modal Widget on clicking on settings badge (#14195) 2022-06-09 16:30:15 +05:30
Tolulope Adetula
3d7d8911fd fix: more refactoring 2022-06-09 10:31:02 +01:00
Tolulope Adetula
909bbf0585 fix: remove console statements 2022-06-09 10:20:35 +01:00
Tolulope Adetula
2c46d42311 fix: CANVAS_SELECTOR 2022-06-09 09:56:31 +01:00
Tolulope Adetula
1f0c38bbf4 fix: remove template literals 2022-06-09 09:41:16 +01:00
Tolulope Adetula
b77870a6ba Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-09 09:39:49 +01:00
Tolulope Adetula
bd4632abd6 fix: refactor code 2022-06-09 09:38:08 +01:00
Pawan Kumar
e3a8d782cf
fix canvas loading issue (#14400) 2022-06-09 13:45:45 +05:30
Tolulope Adetula
4d5fc3b31f Revert "fix: empty commit"
This reverts commit cef5bed7f6.
2022-06-09 07:11:53 +01:00
Tolulope Adetula
cef5bed7f6 fix: empty commit 2022-06-09 07:11:24 +01:00
Aswath K
a88618d17d
chore: Adds feature flag for Property pane grouping (#14311)
* Adds feature flag for Property pane grouping

* changes assertion logic
2022-06-09 11:16:00 +05:30
akash-codemonk
50b93894d2
fix: Update the widget from drop down to select widget in suggested widget list (#14059) 2022-06-09 11:01:52 +05:30
balajisoundar
265ed0dc25
fix: Improve cell overflow check logic when switching between table page (#14095)
* fix: Improve cell overflow check logic when switching between table page.

* Table locators update

* Migration spec - locators update

* Migration spec locators update

* MongoDBShoppingCart spec locators update

* POstgress Spec locator fix

* Adding wait!

* Mongo DBcart spec fix

* EchoApiCMS_spec locator update

* Table locators update

* updated locators

* Added delay

* Hidden column fix trial

* Adding refresh page

* Adding time

* Fix cypress xpaths

Co-authored-by: bhavin <techbhavin@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
2022-06-08 21:59:31 -07:00
ChandanBalajiBP
c8f733fb08
Handle string datatype in API response (#14274) 2022-06-09 10:28:56 +05:30
Ankita Kinger
442b849d9e
Refactor code for RBAC feature (#14362) 2022-06-08 18:48:15 +05:30
RakshaKShetty
221d9c0a7c
test: git delete branch tests (#14047)
* gitdeletebranchtests
2022-06-08 17:14:15 +05:30
Tolulope Adetula
665aec5d61 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-08 11:21:01 +01:00
Tolulope Adetula
3a331558ff fix: remove dead code 2022-06-08 11:17:49 +01:00
Tolulope Adetula
22db2edf42 fix: TreeSelect 2022-06-08 10:57:53 +01:00
Pawan Kumar
065cb0e1ba
chore: code split for hiding branding badge (#14346)
* code split for hiding branding badge

* use selectors in branding badge
2022-06-08 15:11:53 +05:30
ashit-rath
3adbb8736f
feat: Rich Text Editor enable browser spellcheck (#13886)
* feat: Rich Text Editor enable browser spellcheck

* fix: added custom menu

* add function for OS check, updated text based on OS

* fix: text update

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-06-08 14:35:35 +05:30
Favour Ohanekwu
d5da24e51e
fix: cyclic dependency in renaming js objects (#13914)
* keep localunevaltree update in sync with unevaltree

* undo tree check

* identify .data difference for js objects

* empty line

* unit test

* unit test name change

* comment

Co-authored-by: Anand Srinivasan <anand.a.srinivasan@outlook.com>
2022-06-08 08:47:59 +01:00
Tolulope Adetula
ab998cfe55
fix: Cursor pagination in list widget (#14206) 2022-06-08 13:06:21 +05:30
Bhavin K
144c999d1c
fix: updated css clash with tree select (#14343) 2022-06-08 07:22:53 +00:00
Tolulope Adetula
0d4f8a0b3f Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-08 06:33:35 +01:00
Tolulope Adetula
1680df92c7 fix: for MultiSelect 2022-06-08 06:32:28 +01:00
Rishabh Rathod
dbcd69e63e
fix: crash due to evalMetaUpdate (#14320)
* fix: crash due to evalMetaUpdate

* Add default value for workerResponse

* patch fix

* fix root cause of DataCloneError
2022-06-07 12:06:27 +05:30
Ayangade Adeoluwa
2ffd942e06
fix: Add null checks for empty datatypes in api/query responses (#14208)
* Add null checks for empty datatypes in api/query responses

* Add jest cases for failing tests

* Add one more test case
2022-06-06 13:27:19 +05:30
Ankita Kinger
290298b2d8
update document link for SAML (#14285) 2022-06-06 12:55:03 +05:30
rahulramesha
9cbcf180cc
minor correcion in Deprecation message (#14273) 2022-06-06 10:18:43 +05:30
Aman Agarwal
3bcb1daf73
fix: onPageLoad false failure issue (#14141)
1. Fixed on page load actions getting called multiple times.
2. Now Evaluation only happens once we complete the fetching of the page's all entities including js objects and actions, this avoids cases where actions are not defined when ran.

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2022-06-06 09:26:14 +05:30
Bhavin K
8c40098975
fix: added hover css for indeterminate checkbox (#14194) 2022-06-03 19:16:31 +05:30
Pawan Kumar
78e6bcf7ad
fix: Theming UX Changes (#13741)
* update color control ux

* add reset theme option

* remove the console

* update theme card

* update icons + text for reset

* update button size

* fix cypress tests

* fix cypress tests

* fix flaky git tests

* incorporate ashit feedback

* fix cypress tests

* fix color button in theme panel

* fix reset theme logic + jest tests

* fix button styles reset issue in json form

* add cypress test for theming reset

* incorporate ashit feedback

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-03 15:55:38 +05:30
Aswath K
c29fd2db19
chore: Adds canDisplayValue to property controls (#13309)
* Adds canDisplayValue to property controls

* Adds tests

* add fn for LocationSearch & ActionSelector

* Adds CSV value support in ButtonTabControl
2022-06-03 10:37:02 +05:30
Aswath K
7bb58ff3c2
fix: uses forwardRef instead of using ref prop (#14201) 2022-06-02 22:11:28 +05:30
Bhavin K
543ce339e3
feat: Added Tooltip for icon button widget (#14131) 2022-06-02 15:14:26 +05:30
Tolulope Adetula
6108d6fd1d Fix: Disable scrolling when dropdown opens 2022-06-01 14:42:16 +01:00
Bhavin K
1a3eafb182
fix: update error highlight border in RTE widget 2022-06-01 17:41:25 +05:30
Aswath K
b83058b391
Name not getting focused on adding new modal widget (#14205) 2022-06-01 17:01:48 +05:30
akash-codemonk
ec6d998d27
Revert "fix: signing up with a redirect url which has a query param goes to a 400 page (#13548)" (#13991)
This reverts commit c0f7c4534d.
2022-06-01 16:00:15 +05:30
Aman Agarwal
7aeaf75c90
fix: removed default value for API DS, updated conditions for headers and apiformattype (#14107)
* fix: removed default value for API DS, updated conditions for headers and apiformattype

* fix: added test cases for content type changes on changing method types

* fix: imported isEmpty directly with loading full lodash module
2022-06-01 10:29:58 +00:00
Bhavin K
95e6b4fb98
fix: switch group added check for inline width (#14190)
* fix: switch group added check for inline width

* SwitchGroup inline cypress test added

* New snaps to match CI run

* Adding right images for CI run

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-01 00:13:32 +05:30
Tolulope Adetula
b22975f6db fix: PR review 2022-05-31 15:21:46 +01:00
Tolulope Adetula
af17e7b8fd Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-31 11:53:20 +01:00
Tolulope Adetula
e1301dc18b fix: remove autofocus 2022-05-31 11:52:39 +01:00
Tolulope Adetula
88a1daacc3 Revert "remove unused code"
This reverts commit 2d694ca446.
2022-05-30 23:17:35 +01:00
Tolulope Adetula
17ec737977 Revert "fix: popup issues"
This reverts commit 9a8bb35809.
2022-05-30 23:12:04 +01:00
arunvjn
b2158131a6
chore: auto focus search input box when widgets library is open(#14148) 2022-05-30 09:26:51 +05:30
arunvjn
fd68dd5bc2
chore: changed edit/launch button to links in applications dashboard. (#14111) 2022-05-30 09:25:18 +05:30
haojin111
3c1b1a3628
Merge pull request #13864 from appsmithorg/feat/13412-improve-import-app-flow-ui
feat: 13412 - improve import app with progress bar
2022-05-26 16:49:47 +08:00
rahulramesha
9cb8524acd
fix: stop showing errored widget labels permanently and show them only on hover or when selected (#14064) 2022-05-26 12:55:29 +05:30
Chandan Balaji
4d76db5fe7 updated harcoded values 2022-05-26 12:45:48 +05:30
Pawan Kumar
7c9135f945
fix: Canvas jitters on page refresh on an application where widgets don't occupy the entire width of the canvas (#13917)
* fixes the flicker of widgets

* fix jest test

* fix use dynamic app layout jitter issue

* fix use dynamic app layout jitter issue

* remove unecessary dispatch

* remove unecessary dispatch
2022-05-26 10:22:55 +05:30
Ankita Kinger
fa45282b0a
fix: alignment of the image seen on no search results on application page (#13950)
* fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)

* add debounce to search and remove state var

* increase debounce time

* fix: updated the condition to show expiry key (#13092)

* Add index for git (#13133)

* fix: Fixed compile time errors

* fix: Unable to see apps in home page after git connect fails (#13387)

* Fix Redis installation in Dockerfile (#13428) (#13430)

Conflicts:
	Dockerfile

* fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)

* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections

(cherry picked from commit 7261834fe5)

* fix: NPE check when datasource createdAt is null

(cherry picked from commit beafb371b24180dce2e351f1dea6d9d34db2a204)

* fixed image alignment for no search results on applications page

* deleted duplicate file

* reload to Refresh script update

* Adding sleep - script fix

Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Rimil Dey <rimildeyjsr@gmail.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-26 10:05:35 +05:30
arunvjn
f75440f29a
fix: removes animation in tooltips (#14032) 2022-05-25 23:12:01 +05:30
Favour Ohanekwu
7bbd109f62
fix: improve jseditor linting performance (#14001) 2022-05-25 18:08:35 +02:00
arunvjn
5947b07c70
fix: Removes animation in deploy button (#14029) 2022-05-25 19:39:12 +05:30
arunvjn
82328f4753
fix: delay comment threads API call till the application details are retrieved (#14011) 2022-05-25 18:19:01 +05:30
Tolulope Adetula
d07d8f8a5d fix: PR review 2022-05-25 13:11:43 +01:00
Bhavin K
1760e8150c
fix: checkbox, switch property fields update, migration added (#13997) 2022-05-25 17:03:33 +05:30
Chandan Balaji
b24428be59 fix: UI Inconsistencies in Datasource Card and Page 2022-05-25 16:58:30 +05:30
Arsalan Yaldram
b266dd47d3
Merge pull request #13585 from appsmithorg/fix/table-bindingPathList
fix: table derived bindingList error.
2022-05-25 15:42:05 +05:30
Aswath K
c8e79eca95
feat: Focus widget name or first property when opening property pane (#13513)
* feat: intial investigation.

* Completed focusing of Property title

* removes unused import

* fix issue with inability to focus Dropdown

* checks if PP opened not because of focusing on input elements in widget

* Adds two level of focus for LocationSearch

* adds multi state to KeyValue component

* Adds multi state to Draggable List as well

* Adds multi state to DatePickerControl

* fix: style issue with draggableList & KeyValue comp

* avoids auto focusing on Panel

* remove commentedout code

* fix: cypress tests

* change ActionConstant name

Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-05-25 15:35:53 +05:30
ashit-rath
6d591c49b9
fix: JSONForm Select field validate empty string as an invalid value (#13993) 2022-05-25 15:34:50 +05:30
Rishabh Rathod
cbce8f8b8e
fix: trigger consuming previous evaluated values (#13084)
We are changing how we maintain meta values in our architecture,

Earlier metaHOC component state was used to store meta values that were debounced and pushed in batch to metaReducer and trigger evaluation.
We remove the metaHOC state and directly update values to metaReducer and trigger evaluation separately via a debouched function.
2022-05-25 15:16:14 +05:30
akash-codemonk
77cee950b1
fix: inconsistency in naming actions from omnibar (#13898) 2022-05-25 15:10:06 +05:30
rahulramesha
a2688bb4da
feat: Add deprecation warning badge to deprecated widgets (#13381)
This Change also introduces, isDeprecated flag to widget config, when true will add the warning to the widget's propertyPane.
2022-05-25 09:38:32 +00:00
Tolulope Adetula
2d694ca446 remove unused code 2022-05-24 23:36:56 +01:00
Tolulope Adetula
9a8bb35809 fix: popup issues 2022-05-24 23:35:42 +01:00
Tolulope Adetula
806b212380 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-24 22:46:15 +01:00
Pawan Kumar
297421b332
fix: Redirect to website home instead of appsmith home on watermark (#14018)
* update url

* open url in new tab;
2022-05-23 17:39:12 +05:30
haojin111
7e5332ceb7 Merge branch 'release' into feat/13412-improve-import-app-flow-ui 2022-05-23 13:31:28 +08:00
Arsalan
6bc68c0327 Merge branch 'release' into fix/table-bindingPathList 2022-05-23 10:41:03 +05:30
rahulramesha
f2c02ab931
fix: Grouped widgets moving to the bottom most row, even when widgets are not overlapping with the multi select box (#13658) 2022-05-20 15:57:12 +02:00
arunvjn
da1a57de72
Fixes the error message shown in reset password flow from user profile (#13974) 2022-05-20 14:37:02 +05:30
ashit-rath
76536124f8
fix: JSONForm modify source data object to null causes crash (#13966) 2022-05-20 13:46:45 +05:30
Maulik
7ccc541fbf
fix: update placeholder for phone input widget (#13635) 2022-05-20 10:41:58 +05:30
arunvjn
9753df54f4
fix: remove transition delay in the switch between explorer and widgets. (#13942) 2022-05-20 10:32:13 +05:30
haojin111
82dcfeff21
Merge branch 'release' into feat/13412-improve-import-app-flow-ui 2022-05-20 04:17:18 +08:00
haojin111
9561fe0dd8 updated comments of commit 2022-05-19 23:02:35 +08:00
Favour Ohanekwu
cad1620683
fix:prevent execution of js function when jscollection is saving (#13592) 2022-05-19 14:13:51 +01:00
Favour Ohanekwu
244095a888
fix: Js editor inconsistency (#13708) 2022-05-19 13:21:51 +01:00
Favour Ohanekwu
2748ed0e64
fix: prioritize parse errors in debugger callout (#13765)
Prioritize parse errors over lint errors in debugger callout
2022-05-19 11:57:49 +01:00
ashit-rath
f6d726b2a1
task: JSONForm footer should always stick to bottom when fixed footer enabled (#13904) 2022-05-19 13:07:59 +05:30
Bhavin K
33d8347193
fix: handle selectedValues value (#13887) 2022-05-19 12:41:54 +05:30
f0c1s
f4c1049027
Add analytics for git import application (#13925)
Analytics tracking is missing for git import application. This commit adds event tracking as follows:

- When git-import-application card is clicked
2022-05-19 12:16:38 +05:30
Ayangade Adeoluwa
f7107a4a0a
Fix response tab overflow issue (#13839)
This commit fixes three things

- It prevents the tab headers from being scrolled up when on the RAW/JSON tabs.
- It prevents the Table component from pushing the API right pane away when its contents are too wide.
- It also prevents the table and JSON component from clipping the data displayed within them by adding margins/paddings between them and the parent container.
2022-05-19 08:32:43 +05:30
Ayangade Adeoluwa
1ee494b9ca
fix: Fix validation check that is blocking input from changing (#13943)
* Fix validation check that is blocking input from changing

* Add testcases for Elastic search datasource

* Adds header value to test case

* Fix validation logic
2022-05-18 17:35:03 +00:00
Ayangade Adeoluwa
dd46351e38
Increase width for various form controls (#13895) 2022-05-18 15:37:47 +01:00
arunvjn
0bcabdb11f
fix: Text overlap in slash commands (#13871) 2022-05-18 15:37:24 +05:30
Anand Srinivasan
4e5cf6c156
add unit test (#13776) 2022-05-18 13:16:16 +05:30
arunvjn
f3dec5ca0f
fix: bind api/query to list widget in sniping mode (#13859) 2022-05-18 13:03:52 +05:30
arunvjn
1296fe7f57
Added selected state for query/js add button (#13897)
Adds selected state to Query/JS add button in explorer when submenu is open.
2022-05-18 12:03:09 +05:30
Satish Gandham
8dc9c0b017
feat: Optimize create uneval tree via memoization (#13476)
* - Memoize the expeinsive parts of createUnevalTree

* - Split the generateDataTreeWidget and memoize the expensize part
- Remove stary console statement in MultiSelectWidget

* - Some debugging code, needs to be removed.

* Debugging in progress

* Still debugging

* Still debugging

* Working??

* Jest tests passing, and fast enough

* remove unused imports

* One failing jest test, testing luck with cypress

* Remcoe console statment from jest test

* - Sync with release.
- Comment failing jest test

* Disable a test

* - Clean up

* Final cleanup and documentation

* - Make function and variable names accurate and easy to understand

* Update code comments

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-05-18 10:51:53 +05:30
Nayan
33c78e93ef
feat: Update organization slug (#13791)
When organization name is updated, the slug is not updated. This generates a outdated URL when user clicks on a organization name from the left panel. This PR changes the following behaviors

    The Organization slug will be no more unique
    Link to organization applications will be based on organization id instead of slug
    Organization slug will be updated whenever there is a change in organization name
    All the existing organization slugs will be updated
2022-05-18 11:08:13 +06:00
Ankita Kinger
1396141af4
chore: optimize naming conventions for variables and functions (#13858)
* optimize naming conventions for variables and functions

* update import statement

* minor css change
2022-05-18 10:23:08 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows (#13257) 2022-05-18 04:46:25 +00:00
haojin111
27ebbfabe3 update full changes 2022-05-17 14:56:34 +08:00
ashit-rath
25d24688a6
fix: Property pane - Hidden sections icon select popover not opening properly (#13881) 2022-05-17 12:25:25 +05:30
haojin111
89990c2114 unstaging coverage-summary.json 2022-05-17 14:28:00 +08:00
Ankita Kinger
11d03370a4
Add field for reply-to email address on email config page (#13857) 2022-05-16 16:23:36 +05:30
haojin111
a3be2498e3 added import application progress bar when importing from json 2022-05-16 18:09:23 +08:00
Keyur Paralkar
22605a341a
fix: added empty stack in sppThemingReducer (#13837) 2022-05-16 13:16:35 +05:30
albinAppsmith
7f241cb98e
feat: Entity explorer pages section resize (#13576)
* * Page container resize changes

* * changed inline style to styled component

* * Added preserve height functionality
2022-05-16 12:09:32 +05:30
Tolulope Adetula
a956ff6d71
Merge pull request #13793 from appsmithorg/fix/select-widget-filtering
fix: Select widget filtering
2022-05-16 05:17:43 +01:00
rahulramesha
6738c969bf
chore: changes to render complete property pane post dragging or resizing (#13141)
* changes to render complete property pane post dragging or resizing

* rework to compensate for expensive render of theming properties
2022-05-15 18:42:07 +05:30
ashit-rath
e44aecfe85
fix: JSONForm missing theming accent color property and few JS enabled controls not access sourceData/formData properties (#13817)
* fix: JSONForm missing theming accent color property and few JS enabled inaccessible sourceData/formData properties

* reverted adding of customJSControl JSON_FORM_COMPUTE_VALUE for exisiting properties

* minor revert

* minor fix
2022-05-13 19:53:23 +05:30
akash-codemonk
e1045b1bc3
chore: add autofocus prop to TagInputComponent (#13578) 2022-05-13 17:34:08 +05:30
Keyur Paralkar
a5f426d02b
fix: theme property pane reset on hover over the widget (#13716) 2022-05-13 16:10:09 +05:30
Bhavin K
dabca5aac5
fix : prevent dragging when resizing (#13600) 2022-05-13 11:26:09 +05:30
arunvjn
9381eeaea7
Trigger submenu instead of omni-bar when "Add Query/JS" button in the explorer is clicked. (#13774) 2022-05-13 10:31:08 +05:30
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Tolulope Adetula
83a2237a3a Merge branch 'release' into fix/select-widget-filtering 2022-05-12 12:41:32 +01:00
Tolulope Adetula
379ce6cf5c fix: Select widget filtering 2022-05-12 12:31:45 +01:00
Arsalan
b0e4f099bc fix: return undefiend when propertiesToUpdate is empty array. 2022-05-12 14:15:50 +05:30
f0c1s
84be23c490
chore: refactor git code (#13724) 2022-05-12 14:02:56 +05:30
Arsalan
8fa294ae49 Merge branch 'release' into fix/table-bindingPathList 2022-05-12 11:40:52 +05:30
Maulik
7856d8234e
chore: update error message for no schema available for a datasource (#13467) 2022-05-11 19:15:06 +02:00
arunvjn
ae22baaa36
fix: persists query param in redirect urls (#13738) 2022-05-11 20:42:07 +05:30
arunvjn
8084744e98
chore: safe crash application on theme APIs failure (#13743) 2022-05-11 16:01:04 +05:30
Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects (#13700) 2022-05-11 11:20:33 +01:00
ChandanBalajiBP
43758f6e7e
Merge pull request #13725 from appsmithorg/Fix/Hover-state-of-renaming-titles
fix: Hover state of renaming titles
2022-05-11 14:59:26 +05:30
rahulramesha
27d5ae8b77
fix: Avoid pasting list widget inside another list widget (#13719)
* fix for stopping list widget from copying onto itself

* remove duplicate comment

* verify selected widgets are not inside list widget if list widget is to be pasted
2022-05-11 14:46:22 +05:30
Rishabh Rathod
89c4bbeeec
chore: remove only for jest test (#13668) 2022-05-11 09:12:59 +00:00
rahulramesha
3923204dcc
The page order doesn't work as expected in page setting page (#13448) 2022-05-11 13:28:07 +05:30
arunvjn
0571f9c36b
Delay on page load actions till all actions are retrieved (#13657)
As a quick fix to prevent the on-page load actions from firing before the actions are even fetched, we had reverted the changes to make fetch page DSL call parallel in 13587. Unfortunately, theming PR brought back parallelisation and the issue along with it.

This PR ensures that the on-page-load actions are only made after actions are fetched while preserving parallelisation.
2022-05-11 12:36:25 +05:30
Pawan Kumar
2dacdec880
fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas (#13608)
* fix tab widget scrolling + text widget font control overflowing issue

* revert text widget changes

* tab widget scroll issue

* remove border radius and box shadow from v1 widgets
2022-05-11 10:23:13 +05:30
Tolulope Adetula
10aca0297f
Merge pull request #13275 from appsmithorg/fix/disable-cancel-button-on-a-disabled-select-widget
fix: disable cancel button on a disabled select widget
2022-05-11 03:55:52 +01:00
Tolulope Adetula
2f8c178dda fix: Failing Tests 2022-05-11 02:36:54 +01:00
Ayangade Adeoluwa
49a4e47b95
Add functionality to close modal when back overlay is clicked. (#13669) 2022-05-10 12:39:03 +00:00
Chandan Balaji
01604bb25a hover state of renaming titles 2022-05-10 17:38:08 +05:30
akash-codemonk
c0f7c4534d
fix: signing up with a redirect url which has a query param goes to a 400 page (#13548) 2022-05-10 13:32:25 +05:30
Arpit Mohan
cf27bbdfec
Merge pull request #13653 from appsmithorg/fix-13652 2022-05-10 05:25:44 +02:00
akash-codemonk
2b5d5dd89f
fix: triggering omnibar shortcuts toggles visibility when visible (#11601) 2022-05-09 19:43:57 +05:30
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled (#13520) 2022-05-09 17:34:49 +05:30
Sangeeth Sivan
897d3818b9
fix: Handle login form password error message on blur (#13568)
* gitignore

* don't show password field errorMessage onBlur

* remove unused import of usestore
2022-05-09 15:53:41 +05:30
Sangeeth Sivan
d5845e972a
fix: Use unique id instead of indices as keys for DraggableList (#13553)
* gitignore

* fix: Use unique id instead of indices as keys for DraggableList(#9991).

* removed duplicate 'stacks' from gitignore

* revert change to cypress selector for draggable list

* use 'id' ad key name for consistency and that it doesn't break in other places
2022-05-09 15:52:37 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget (#13605)
* refactor: removed the duplicate style properties for the list widget

* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
ashit-rath
a715c0eefa
fix: JSONForm Phone number field required validation (#13525)
* fix: JSONForm Phone number field required validation

* PR review suggestion change
2022-05-09 14:59:53 +05:30
Aishwarya UR
fdc3143c21 Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-05-09 13:58:37 +05:30
Arsalan
f6f5125018 Merge branch 'release' into fix/table-bindingPathList 2022-05-09 11:11:04 +05:30
Sangeeth Sivan
ab557b1443
fix: Lowercase 'first' on the welcome page. (#13559)
* gitignore

* fix: Lowercase 'first' on the welcome page.(#8876)

* removed duplicate 'stacks' from gitignore
2022-05-09 10:54:48 +05:30
Tolulope Adetula
de8aebfe00 Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-05-09 03:15:51 +01:00
Favour Ohanekwu
3ab904d83d
fix:only show js successful execution toast message in edit mode (#13590)
* only show js successful execution toast message in edit mode
2022-05-07 17:03:03 +01:00
Anubhav
e35f8dc897 fix: use modified instead of updated 2022-05-07 08:10:34 +05:30
rashmi rai
c0f98ad4d7
fix:change default value in rest api json and placeholder (#13261) 2022-05-06 19:13:10 +01:00
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page (#13178)
* added cypress test of form login on admin setting page

* resotre setting after checked

* added a check if signup form is enabled for all users

* minor fix

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Arpit Mohan
4934fc9066
Merge pull request #13644 from appsmithorg/fix-12164 2022-05-06 16:17:37 +02:00
rahulramesha
7a501ecd9c
fix: stopping list widget from copying onto another list widget (#13621)
* fix for stopping list widget from copying onto itself

* remove duplicate comment
2022-05-06 19:41:09 +05:30
arunvjn
c7305d4114
Makes bindings popover consistent with the other popovers (#13579) 2022-05-06 11:40:51 +00:00
Aswath K
be6946773e
fix: Broken keyboard nav with BorderRadius & BoxShadow (#13636) 2022-05-06 11:24:33 +00:00
f0c1s
1de19956e3
fix: add visual cue to SSH key regeneration (#13625) 2022-05-06 15:30:48 +05:30
ashit-rath
ddc95fae53
fix: JSONForm fix events/actions controls JS mode produces additional binding strings (#13509)
* fix: JSONForm fix events controls js mode additional binding strings

* fixed globalContext value for fieldState update and fix FilterText spec
2022-05-06 15:29:56 +05:30
Anubhav
03684fce97 fix: disable revoke button after first click 2022-05-06 15:21:33 +05:30
ashit-rath
910427788e
fix: JSONForm currency and phone input dropdown not working in Array Field (#13564) 2022-05-06 15:19:36 +05:30
rahulramesha
abe62f294c
Skip copying logic while grouping (#13573)
Adding check to skip pasting logic while grouping widgets
2022-05-06 13:52:20 +05:30
balajisoundar
08a882be24
chore: Update property from property pane to use improved get strategy & BATCH_UPDATE_WIDGET_PROPERTY to be processed serially (#12544) 2022-05-06 11:12:35 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component (#13105)
* fix: set max-height for Dropdown component

* changes style for date format dropdown

* Combines MultiSelectControl into DropdonwControl

* fix: max height set via props

* fix: popover double scrollbar issue

* fix: styles for chips

* Delete MultiSelectControl

* fix: error when pressing Enter twice

* add tests for multi select & fix some warnings

* removes unwanted test file

* fix: country filtering issue

* address review comments

* fix dropdown for primary columns dropdown

* fix: issue with position

* Adds scrollIntoView when using arrow key for navigation

* fixes issue with scrollbar

* fix: jest tests

* fix: jest test

* fix: flaky cypress test

* fix: height & align issue in Date format selection

* smoothens the scroll
2022-05-06 10:34:17 +05:30
f0c1s
7a3985f962
feat: git discard changes (#11835)
* feat: git discard changes
* fixed cypress test in git connection
* feat: add discardDocUrl and update casing
* chore: update tests
* chore: fix review comment

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-06 10:14:24 +05:30
Ayangade Adeoluwa
ec3a1acc4b
Fix text/plain not showing up when api is run in api response viewer (#13575) 2022-05-05 19:54:24 +00:00
Aswath K
f3eb7f6ed9 Merge branch 'release' into fix/colorpicker-tests 2022-05-05 19:51:34 +05:30
Aman Agarwal
ff510cba0e
fix: undefined check added for plugin (#13595) 2022-05-05 18:48:56 +05:30
rashmi rai
0b6ea8dc7e
fix: moving refreshTokenClientCredentialsLocation from oAuth2Common to AuthoCode (#13551) 2022-05-05 17:24:14 +05:30
arunvjn
d7d4386e1e
feat: entity explorer submenu (#13425) 2022-05-05 15:44:10 +05:30
Arsalan
69fb17eae0 fix: moved test to WidgetOperationSaga.test.tsx 2022-05-05 14:03:18 +05:30
Arsalan
a02aee83f4 fix: propertyUtils return propertiesToUpdate. 2022-05-05 12:46:57 +05:30
Arsalan
d340242ef8 fix: table derived bindingList error. 2022-05-05 12:08:27 +05:30
ashit-rath
f0952b8082
fix: JSONForm RadioGroupField - support numeric values in the options (#13365)
* fix: JSONForm RadioGroupField accept numeric values in the options

* cypress test - clear options before adding

* update code editor clear
2022-05-05 11:10:52 +05:30
Ankita Kinger
8522692bac
Code split for RBAC features (#13557) 2022-05-05 11:07:50 +05:30
arunvjn
7f243c505a
Fixes missing applicationId in fetch comments API by delaying the component mount. (#13519) 2022-05-05 10:52:32 +05:30
Paul Li
58dfb48023 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-04 21:46:14 +08:00
arunvjn
3c57ac1764
fix: update JS libs version numbers in entity explorer (#13526) 2022-05-04 19:06:10 +05:30
ankurrsinghal
ef79f6450d
Merge pull request #12190 from appsmithorg/feature/pp-datepicker
feat: added keyboard interaction for datepicker
2022-05-04 18:10:27 +05:30
f0c1s
9cc0cdd404
fix: remove horizontal scrollbar in git sync modal (#13514) 2022-05-04 17:10:32 +05:30
Aswath K
c03cc6e1d3 fix: package issue with focus-trap causing jest test failure 2022-05-04 16:32:04 +05:30
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects (#13212) 2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Favour Ohanekwu
7261834fe5
fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)
* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections
2022-05-04 09:43:26 +01:00
akash-codemonk
05fdfd540b
fix: welcome form shown for a while after signup (#13304) 2022-05-04 14:13:02 +05:30
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience (#12906)
* copy paste commit

* class name generator changes

* modal widget fixes change

* addressing review comments

* bug fix for after deleting a widget by undoing action

* additional fix for modal widget

* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data (#13453) 2022-05-04 12:53:48 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load (#13415)
* fix: submit button not disabled in invalid json form on first load

* reset fixes
2022-05-04 10:45:27 +05:30
Favour Ohanekwu
3efb3588d2
chore: Add JS editor test cases 2022-05-03 15:22:45 +01:00
haojin111
0414c8823d
fix: 12456 - oauth redirection issue (#13511)
* fixed issue of gsheet authorization
* hidden cloudhost ip info on reconnect modal
2022-05-03 14:22:48 +05:30
Rimil Dey
c55718f9f1
fix: don't run onClick event handler when button is disabled (#12333) 2022-05-03 07:25:31 +02:00
Favour Ohanekwu
395fd30335
add overflow to js editor settings (#13488) 2022-05-02 20:34:55 +02:00
Ankur Singhal
0d0f5d4c2c Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-05-02 13:23:59 +05:30
haojin111
ca33d68532 fixed uppercase of url 2022-05-02 12:50:49 +08:00
haojin111
ecffa88684 updated label text of remote url 2022-04-30 21:18:53 +08:00
rashmi rai
4596a12bfd
added fixActionPayloadForMongoQuery (#13465) 2022-04-30 08:27:15 +05:30
Preet Sidhu
c6f3f356e6
Merge pull request #12964 from appsmithorg/fix-10379
fix: 10379 disable html parsing for long texts
2022-04-29 12:29:36 -04:00
Rishabh Rathod
3b1fbfa989
fix: replace klon/full with klona default (#13457)
- when manipulating props, react state (immutable values)
2022-04-29 15:14:17 +00:00
Ankita Kinger
63479dbb3e
chore: update subtext copies for Google & Github (#13451)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-04-29 17:52:27 +05:30
Preet
2ee727bd84 Merge branch 'release' into fix-10379 2022-04-29 06:34:47 -04:00
akash-codemonk
9b9048fdc4
chore: add analytics event for similar templates click (#13177) 2022-04-29 15:39:16 +05:30
Paul Li
297b6141c0
fix: feedbacks on label feature (#13123)
* fix: Fix on feedbacks on Label feature

-- Eliminate CSS restriction for horizontal scrolling

* fix: feedbacks on label feature

-- Eliminates CSS rules for overflow-x: hidden
2022-04-29 17:21:08 +08:00
Ankur Singhal
e29a879ff7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-29 14:14:37 +05:30
Maulik
59e8ad12e1
fix: allow camera & mic access for page in iframe widget 2022-04-29 11:49:44 +05:30
Tolulope Adetula
fa48a026ad Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-04-29 06:12:19 +01:00
Tolulope Adetula
16724bdc04
Merge pull request #13074 from appsmithorg/fix/table-mutiselect-checkbox-alignment
fix: table Widget Multiselect Row checkbox alignment
2022-04-28 21:51:38 -07:00
akash-codemonk
cc3de11bfa
fix: dropdown showing an empty row when the options list is empty (#13364) 2022-04-29 10:09:44 +05:30
Tolulope Adetula
14e1b20464
Merge pull request #12626 from appsmithorg/feat/show-page-count-when-total-records-exist
feat: show total records and pageCount in table header
2022-04-28 19:30:51 -07:00
Tolulope Adetula
5749a4461b Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-29 02:37:59 +01:00
Tolulope Adetula
302644473c
Merge pull request #13164 from appsmithorg/fix/Primary-column-control-visibility-icon-out-of-sync
fix: Primary column control visibility icon out of sync
2022-04-28 18:35:11 -07:00
Tolulope Adetula
76b2e219f6 fix: build issue 2022-04-29 02:22:28 +01:00
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
Tolulope Adetula
70c475f049
Update Icon.tsx 2022-04-28 04:59:14 -07:00
Tolulope Adetula
359d3706fe Merge branch 'release' into fix/Primary-column-control-visibility-icon-out-of-sync 2022-04-28 12:42:04 +01:00
Tolulope Adetula
47398e20d9 fix: PR reviews 2022-04-28 12:25:14 +01:00
Ankur Singhal
f2cabb8eec Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-28 16:51:19 +05:30
Ankur Singhal
47d219cc90 removed day click and clear click which was crfeating the ambiguity 2022-04-28 16:36:18 +05:30
Ankita Kinger
3835e81105
chore: Add analytic event for the Reset button click on the Admin settings page. (#13408) 2022-04-28 14:46:38 +05:30
Favour Ohanekwu
02d4af3ed7
prevent multiple execution of pageload actions when generating a template (#13361) 2022-04-27 19:28:52 +01:00
Ankita Kinger
251ad6097b
chore: Add analytic events on Authentication page (#13384)
* added analytic events for Authentication page on Admin settings

* updated event names
2022-04-27 23:16:24 +05:30
rahulramesha
727889434c
fix: calculating the canvas container height to be exact to not scroll on scrollIntoView() call (#13096)
* canvas container Fix

* add comments
2022-04-27 15:43:29 +00:00
Ayangade Adeoluwa
5a126bfda2
Add space to both sides of response run button (#13368) 2022-04-27 12:42:29 +01:00
Tolulope Adetula
2d57840938 fix: add new line 2022-04-27 12:30:43 +01:00
Tolulope Adetula
7f8bf5c4fe fix: PR reviews 2022-04-27 12:29:31 +01:00
ashit-rath
fc36a3af94
feat: Analytics to log source data limit exceed (#13339)
* feat: Analytics to log source data limit exceed

* minor change
2022-04-27 14:04:15 +05:30
Maulik
0eef3b0bfd
fix: code hidden issue for JS Enabled fields (#13241)
* fix code hidden issue for JS Enabled fields

* test for code hidden fix
2022-04-27 12:37:33 +05:30
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Ayangade Adeoluwa
c264e1cd89
Add fallback for responseType, in case it does not exist (#13324) 2022-04-26 20:40:59 +05:30
Arsalan Yaldram
4dabbd8f13
fix: onSucess & onError action selector () => {} (#12753) 2022-04-26 20:01:23 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once (#13272) 2022-04-26 19:51:06 +05:30
albinAppsmith
1d019d1376
fix: Modal padding and color fixes (#12189)
* * share modal fixes

* * modal ui fixes
2022-04-26 19:26:07 +05:30
Tolulope Adetula
faea2712fe fix: disable cancel button on a disabled select widget 2022-04-25 13:36:36 +01:00
Bhavin K
20aa7196d2
fix: handle editor value update (#12726) 2022-04-25 12:32:55 +05:30
f0c1s
d428262bf9
fix: Azure SSH url was not accepted for git connection (#12896) 2022-04-23 18:01:43 +05:30
haojin111
08bbd55020
Merge pull request #13207 from appsmithorg/fix/13184-master-branch-issue
fix: 13183, 13184 - fixed issue of correct branch name on edit mode
2022-04-23 05:03:44 +08:00
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity (#13083) 2022-04-22 17:20:51 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name (#12930)
* Change response tab name

* Fix response tab name
2022-04-22 12:10:00 +01:00
Aman Agarwal
9a022a668f
fix: datasource ui style issues resolved (#13175) 2022-04-22 16:23:00 +05:30
Bhavin K
78600bd2ed
fix: handle dropdown flickers (#12979) 2022-04-22 15:56:48 +05:30
Abhinav Jha
60503bb9a6
feat: Dynamic Height widget config (#13143)
* Add platform feature which adds dynamic height property controls and default properties based on widget config

* Move features to the top, so that defaults can override them if necessary

* - Add unit tests to verify that the property controls show up for dynamic height
- Add unit test to verify that the hidden hook in the dynamic height controls work
- Fix console warning for react key unavailable in Generator.tsx
- Move constants and types to their respective files

* Remove dynamic height config from Container Widget

* Add comments in hard to understand areas

* Add function which converts fn validation params to fnString
2022-04-22 15:14:22 +05:30
ashit-rath
07757c7e7b
fix: Replace "klona/full" -> "klona" in JSONForm to avoid cloning of non-enumerable properties (#13193)
- non-enumerable like `writable`, `configurable`, `enumerable` were getting cloned with `klona/full` and it wasn't needed.
2022-04-22 14:15:45 +05:30
haojin111
498b9a6f7e fixed issue of correct branch name on edit mode 2022-04-22 14:36:49 +08:00
Bhavin K
7e3d873d20
feat: added searched address into map center data (#12962) 2022-04-22 11:44:42 +05:30
akash-codemonk
7d646bf11c
chore: redirect to home page at the end of onboarding (#12961) 2022-04-21 19:28:26 +05:30
arunvjn
bdcc99b53b
chore: Hides update button when there are no pending updates. (#13152) 2022-04-21 18:44:10 +05:30
Bhavin K
958233f4f5
fix: added dataFormat into file data (#12807) 2022-04-21 16:09:24 +05:30
albinAppsmith
978f1d3cd1
chore: Added margin bottom for sign posting checklist footer (#12884) 2022-04-21 11:44:34 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
Preet
19172bf2b6 reduce line break limits to 1000 2022-04-20 13:22:45 -04:00
Preet
eb4eaf849a Merge remote-tracking branch 'origin/release' into fix-10379 2022-04-20 13:20:22 -04:00
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change (#13085)
* Scroll to active entity in explorer on route change

* Removes scroll animation

* Open modal via entity explorer

* Try tonavigate to canvas only in edit mode

* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
Tolulope Adetula
04ac78ba15 fix: Primary column control visibility icon out of sync 2022-04-20 14:56:01 +01:00
rahulramesha
98f6a3fede
move reflow out of beta (#12746) 2022-04-20 18:33:30 +05:30
Paul Li
0771f23294 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Rename getDropdownPosition to getCloesetCanvas
2022-04-20 20:40:53 +08:00
Paul Li
ef56d732a8 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 20:36:53 +08:00
Paul Li
b2c1ebf736 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Makes getDropdownPosition as a widget utility function
2022-04-20 20:35:35 +08:00
Aman Agarwal
356cdfffab
fix: changed prop drilled fn to class fn, avoided array prop (#12788) 2022-04-20 15:56:27 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
Paul Li
43ca423b48 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 17:04:24 +08:00
Paul Li
9301bf9637 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Sets popover container to the closest canvas
2022-04-20 17:02:57 +08:00
rahulramesha
27b54f22e8
Reflow overlapping fix on canvas edges (#12745) 2022-04-20 12:56:35 +05:30
haojin111
923efa9696
fixed issue of deleting original default branch (#13062) 2022-04-20 05:50:54 +05:30
Tolulope Adetula
a892aa678d fix: Table Multiselect checkbox alignment 2022-04-19 09:40:42 +01:00
rashmi rai
bb5d7159c6
Always show advanced settings in rest api editor (#12927) 2022-04-19 12:03:27 +05:30
Ankita Kinger
5b4628a9d4
Add common code for SAML (#12976)
Added new form field component in ads. Also, updated copy URL form component.
2022-04-18 17:47:29 +05:30
Bhavin K
3575a03005
fix: updated cursor style in actionWrapper (#12850) 2022-04-18 11:39:11 +05:30
Preet Sidhu
820a99e5d1 disable html parsing for long texts 2022-04-15 10:03:38 -04:00
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
akash-codemonk
71591ff75f
chore: remove frontend template feature flag (#12937) 2022-04-15 14:58:27 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Aswath K
25afe65cb7
Merge pull request #12923 from appsmithorg/fix/delete-button-kdb
feat: makes option control delete button keyboard accessible
2022-04-14 19:57:06 +05:30
Rishabh Rathod
846ba223ea
fix: replace rfdc with klona (#12568)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-14 14:19:13 +00:00
Aswath K
6a4b632338 Merge branch 'release' into fix/delete-button-kdb 2022-04-14 16:24:52 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Aswath K
1bf959d177 feat: makes option control delete button keyboard accessible 2022-04-14 13:23:41 +05:30
Ayangade Adeoluwa
a4d22b3d13
Handle stringified json response and fix alignment issue (#12886) 2022-04-14 12:53:07 +05:30
Rishabh Rathod
ee76cabb96
chore: fix Key missing error in Boxed component (#12912) 2022-04-14 06:31:50 +00:00
arunvjn
b7aff3c38b
chore: Parallellise fetch page call with actions, jsObject and plugins (#12537) 2022-04-14 10:16:17 +05:30
rahulramesha
cfba555fe8
chore: Should not persist DSL for mainContainer layout changes (#12351)
* Moving out non persistent state out of DSL

* replacing canvas width seector

* converting to immerReducer

* adding TODO and more immer reducer changes
2022-04-14 10:06:20 +05:30
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
rahulramesha
faaf977728
feat: Container Jump Improvements and Code for tracking Container Jumps (#12686)
* conatiner Jump Optimization and tracking

* Round of mouse positions ans add negative jest test cases

* addressing review comments
2022-04-13 20:27:44 +05:30
akash-codemonk
2abb7bb822
fix: welcome form getting submitted on pressing enter key (#12613) 2022-04-13 15:37:11 +05:30
f0c1s
736c2e024e
feat: git delete branch (#12681) 2022-04-13 15:33:23 +05:30
akash-codemonk
73482000a6
chore: search for templates with a given datasource or widgets (#12434) 2022-04-13 14:18:40 +05:30
f0c1s
f5796bfa30
fix: git merge tab issues (#12576) 2022-04-13 08:47:33 +00:00
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30
Favour Ohanekwu
b102d32761
fix: show loading state in JS Editor (#12820) 2022-04-13 11:47:56 +05:30
Anand Srinivasan
8420f6c5fa
fix: Js object - set async tag after all objects are parsed (#12684)
* set isAsync after all parsing is done

* clean up
2022-04-13 11:07:46 +05:30
Preet Sidhu
19d0db30b0
fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)
* add debounce to search and remove state var

* increase debounce time
2022-04-12 16:31:51 +00:00
akash-codemonk
d292075243
fix: template fork button style on safari (#12202) 2022-04-12 19:23:57 +05:30
Rishabh Rathod
136308fd7c
fix: table search text dependency deletion (#11608)
* Replace BindingPaths with ReactivePaths and remove non-bindable property path from bindingPaths to reduce confusion.
2022-04-12 13:09:26 +00:00
arunvjn
68bca33a55
fix: broken checklist onboarding flow (#12822) 2022-04-12 17:03:35 +05:30
Aman Agarwal
21eb88f847
fix: updated default content-type and default body format type (#11878)
* fix: updated default content-type and default body format type

* fix: updated the cypress test because the default content-type is changed

* fix: update content type on change of http method and update body format type too

* fix: changed cypress test back to previous
2022-04-12 16:43:11 +05:30
Ankita Kinger
c1e48f7486
feat: Refactor code for SAML integration (#12700)
* Implemented code splitting of some files for SAML integration

* Implemented code splitting of some more files for SAML integration

* updated redirect url component

* fixed an import statement

* fixed a unit test

* updated restart banner tooltip logic

* updated an import statement
2022-04-12 16:20:01 +05:30
Rishabh Rathod
7626d75ccf
fix: remove "Error when determining async func" (#12683)
- Add logs for debugging
2022-04-12 10:02:02 +00:00
Tolulope Adetula
89fcc414e3
fix: remove internalKeys from Selected row and Triggered row (#12655) 2022-04-12 10:01:03 +00:00
Trisha Anand
85ebed6d5e
Merge branch 'master' into release 2022-04-12 14:06:53 +05:30
haojin111
c32ca69a91
fix: 12456, 12420, 12422 on reconnect modal issues (#12569)
* fixed-12456 gsheet auth issue

* fixed - 12420 save button functionality failed

* fixed - 12422 datasource selection issue

* fixed issue of gsheet authentication

* fixed comments point

* fixed 12511: typo issue

* fixed cypress test import and export
2022-04-11 23:00:29 +05:30
Ayangade Adeoluwa
5bc414082a
fix: Fix app crash on arrow down in where clause (#12801)
* Fix app crash on arrow down in where clause

* Makes sure first index is not omitted
2022-04-11 17:02:56 +00:00
Ayangade Adeoluwa
8bdcbec9f1
fix: Fix google sheets datasource options (#12773) 2022-04-11 20:29:13 +05:30
Tolulope Adetula
52a51b882c
fix: select widget virtualization not rendering first top items (#12768)
* fix: select widget virtualization

* fix: use max height of renderMenuItem

* fix: make height a constant

* fix: variable name

* fixed spec

Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-04-11 18:20:01 +05:30
haojin111
6e63290477
fix: 12338 - postgres datasource default configure on reconnect modal (#12503)
* updated logic of form initialization on reconnect datasource modal

* fixed cypress test

* fixed cypress test
2022-04-11 16:53:52 +05:30
Ankita Kinger
65ffb56f34
chore: Improve the UI for restart banner on admin settings page (#12580)
* improved the UI for restart banner on admin settings page

* implemented suggestions from PR

* retrying to restart server on button click

* updated colors getting used

* implemented PR suggestions

* fixed cypress test failure
2022-04-11 14:12:06 +05:30
akash-codemonk
d100cac0ec
fix: fork app button not opening the fork modal for non-signed in users (#12479) 2022-04-11 10:44:50 +05:30
Aswath K
7aba7772e2
fix: invisible icon in panel (#12610) 2022-04-10 00:01:37 +05:30
Favour Ohanekwu
b3e30725dc
properly handle translated diffs when change is between undefined and an Array (#12577) 2022-04-09 14:55:41 +01:00
balajisoundar
a11ae569e1 Fixing merge conflicts 2022-04-08 19:48:47 +02:00
albinAppsmith
2ffeb192cc chore: Edit app icon color changes to white (#12693) 2022-04-08 19:43:22 +02:00
balajisoundar
6cdef28afa
fix: Phone and currency widget's dialCode and currencyCode should … (#12720) 2022-04-08 19:39:05 +02:00
ashit-rath
6a33b4da5a
fix: JSONForm select not working in nested fields - Array/Object (#12635)
* fix: JSONForm select not working in nested fields - Array/Object

* fixed merge-conflict missing import
2022-04-08 22:54:08 +05:30
imgbot[bot]
bc0325617c
chore: [ImgBot] Optimize images (#12266)
*Total -- 563.13kb -> 460.13kb (18.29%)

/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/EmptyApp.snap.png -- 17.86kb -> 11.54kb (35.43%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/quickPageWizard.snap.png -- 57.24kb -> 39.42kb (31.12%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/emptyAppBuilder.snap.png -- 74.00kb -> 51.48kb (30.43%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/apppage.snap.png -- 46.22kb -> 32.18kb (30.38%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/loginpage.snap.png -- 33.64kb -> 24.07kb (28.44%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/Profile.snap.png -- 29.72kb -> 21.58kb (27.4%)
/app/client/src/assets/gifs/table_data.gif -- 60.23kb -> 50.42kb (16.29%)
/app/client/src/assets/gifs/default_text.gif -- 90.40kb -> 75.70kb (16.26%)
/app/client/src/widgets/JSONFormWidget/icon.svg -- 0.47kb -> 0.46kb (1.66%)
/app/client/src/assets/icons/ads/js.svg -- 1.14kb -> 1.12kb (1.2%)
/app/client/src/assets/icons/ads/fork-2.svg -- 1.45kb -> 1.44kb (0.47%)
/app/client/src/assets/images/lock-password-line.svg -- 0.80kb -> 0.80kb (0.36%)
/app/client/src/assets/icons/menu/settings.svg -- 1.00kb -> 1.00kb (0.29%)
/app/client/src/widgets/CurrencyInputWidget/icon.svg -- 1.05kb -> 1.05kb (0.28%)
/app/client/src/widgets/PhoneInputWidget/icon.svg -- 1.47kb -> 1.46kb (0.2%)
/app/client/src/assets/images/saml.svg -- 2.71kb -> 2.70kb (0.18%)
/app/client/src/widgets/CircularProgressWidget/icon.svg -- 2.32kb -> 2.32kb (0.17%)
/app/client/src/assets/images/oidc.svg -- 19.98kb -> 19.97kb (0.05%)
/app/client/src/assets/images/request-template.svg -- 121.44kb -> 121.43kb (0.01%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2022-04-08 22:52:58 +05:30
albinAppsmith
ab7bfc1cd2
chore: Edit app icon color changes to white (#12693) 2022-04-08 22:42:14 +05:30
Ayangade Adeoluwa
bc8d885813
feat: Response view switcher for all action editors (#9629)
* Response view switcher for all action editors

* fixes prettier issue

* adds correct type to responseDataTypes property

* fix some more conflicts

* Try a new  multi switch component

* Revert multiswitch changes

* Adds finishing touches

* remove warnings

* Fixing bugs, reusing logic
2022-04-08 16:32:34 +00:00
arunvjn
8b10190e1b chore: Added analytics for manual upgrade and adds redirection (#12707) 2022-04-08 17:00:13 +02:00
arunvjn
7f4a190657
chore: Added analytics for manual upgrade and adds redirection (#12707) 2022-04-08 20:27:19 +05:30
Paul Li
9219545879
fix: Form widget should include the following widgets in data property when added in form (#12529)
* fix: Form widget should include the following widgets in data property when added in form

-- Add value props to the widgets, including CheckboxGroupWidget, MultiSelectTreeWidget, MultiSelectWidgetV2, SingleSelectTreeWidget, SwitchGroupWidget
-- Add the corresponding Cypress test case

* fix: Form widget should include the following widgets in data property when added in form

-- Set the value meta propperty for PhoneInputWidget to empty string by default

* fix: Form widget should include the following widgets in data property when added in form

-- Include PhoneInputWidget for test

* fix: Form widget should include the following widgets in data property when added in form

-- Add InputWidgetV2 and CurrencyInputWidget

* fix: Form widget should include the following widgets in data property when added in form

-- Add SelectWidget for assertion

* fix: Form widget should include the following widgets in data property when added in form

-- Wait for @updateLayout

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
2022-04-08 21:07:10 +08:00
Tolulope Adetula
08246e7783
Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-08 09:02:06 +01:00
ashit-rath
99ec9e82e3
fix: JSONForm select/multiselect filterText value synchronous update with onFilterUpdate action (#12578)
* fix: JSONForm select/multiselect filterText synchronous update with onFilterUpdate action

* removed unused dep from useMemo
2022-04-08 11:39:23 +05:30
Favour Ohanekwu
dcddf4cb86
chore: Add data property in entity explorer as part of "show bindings" (#12590)
* include JSAction data in show-bindings
2022-04-07 21:37:03 +01:00
Tolulope Adetula
99a5b8ca69
Merge pull request #12356 from appsmithorg/fix/table-widget-scroll-issue
fix: remove unnecessary horizontal scroll when table columns fit within table widget width and prevent unnecessary re-renders
2022-04-07 19:46:43 +01:00
arunvjn
fabfb65a4f
chore: Parallelise feature flags and user info API (#12263) 2022-04-07 23:27:32 +05:30
Arsalan Yaldram
461f35380b
Merge pull request #12546 from appsmithorg/fix/10319-select-api-response
fix: Disable CTRL+A to select all widgets on Api / Datasource Pane.
2022-04-07 21:51:10 +05:30
Yash Vibhandik
7736daf0a5
fix: 8385 added button variant support in table column type button (#9164) 2022-04-07 16:19:51 +00:00
f0c1s
0ad66f27bd
fix: introduce new regexp for remote url validation (#12004)
* fix: introduce new regexp for remote url validation
* chore: add tests and refactor
* fix: failing cypress test
2022-04-07 16:19:28 +00:00
Bhavin K
d22ae809cb
fix: handle duplicate tab name in tab widget (#12411) 2022-04-07 16:19:12 +00:00
Ayangade Adeoluwa
a210d67e55
feat: Refactor SaasEditor page (#12559)
* Refactor SaasEditor page

* Remove unused variables

* Fixes query form issue with google sheets
2022-04-07 16:18:49 +00:00
rashmi rai
58ac293bda
fix: retained value of where condition (#12592) 2022-04-07 16:18:29 +00:00
f0c1s
ecb6b4457e
feat - remove horizontal rule from git branch list (#12614) 2022-04-07 16:18:14 +00:00
Ankur Singhal
80cebebc0d fixed the first movement on shift 2022-04-07 19:34:55 +05:30
Ankur Singhal
ba24c9736b abstracted out the keyboard navigation behavior in a separate hook 2022-04-07 17:54:17 +05:30
Ankur Singhal
28859aa844 cycling back through controls with shift+tab is also working 2022-04-07 17:45:02 +05:30
Ankur Singhal
6bd7b07747 cycling back through controls with shift+tab is also working 2022-04-07 17:44:45 +05:30
arunvjn
345df76ccc Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 16:33:00 +05:30
Anand Srinivasan
ada1293797
Revert "fix: trigger fields linting issue (#11875)" (#12668)
This reverts commit 186a97c699.
2022-04-07 16:31:31 +05:30
arunvjn
c3fdeb884e Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 15:43:29 +05:30
Paul Li
7045416dd8
fix: Progress widget with circular type is showing wrong value (#12667)
-- Output progress value as it is
2022-04-07 15:39:35 +05:30
arunvjn
1c5e216e6f Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 14:08:48 +05:30
Paul Li
481c1297a7
fix: Auto-suggestion is not working for progress widget while binding (#12658) 2022-04-07 13:37:09 +05:30
Ayangade Adeoluwa
d54720fd19
fix: Fix app crash on navigation to API and Datasource Editor (#12640) 2022-04-07 12:45:10 +05:30
Apeksha Bhosale
7b88bfd380
chore: added beta tag to onPageLoad for js actions (#12657) 2022-04-07 12:42:55 +05:30
arunvjn
03b46483dc
fix: 404 on apps with names that start with api, login or oauth (#12619) 2022-04-07 07:39:15 +02:00
Tolulope Adetula
25c0dabd7b fix: add HTML default for empty space 2022-04-07 05:23:08 +01:00
Tolulope Adetula
86ce80abc3 feat: add total records and pageCount to table header 2022-04-06 12:48:55 +01:00
arunvjn
f18d3b8dc4
fix: update url while switching between git branches (#12586) 2022-04-06 11:46:37 +02:00
Ankur Singhal
149c1e29bb increased the height and added vertical padding like other controls 2022-04-06 14:26:18 +05:30
Ankur Singhal
9ea3f5005f we can now cycle through all internal controls of Datepicker on pressing tab 2022-04-06 13:53:25 +05:30
Apeksha Bhosale
e7d4bdba6e
fix: removed promisification of confirmation (#12553)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 12:52:18 +05:30
Bhavin K
787df868bb
Revert "fix: #6518 Implemented responsive table header controls (#10971)" (#12583)
This reverts commit 88ad2bcbd1.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 11:07:13 +05:30
Tolulope Adetula
f7018314ab
Merge pull request #12541 from appsmithorg/fix/Align-Table-widget-URL-Column-type
fix: align Table widget URL Column type
2022-04-05 13:54:14 +01:00
Ankita Kinger
253b90e595
chore: Add some cypress tests for Admin settings page (#12542)
* added few cypress tests for admin settings page

* uncommented some cypress tests

* updated PR based on suggestions in comments
2022-04-05 18:00:57 +05:30
Arsalan Yaldram
db67e91b63
Merge pull request #12253 from appsmithorg/fix/bindPathList-error
fix: remove bindingPathList properties on jstoggle off.
2022-04-05 17:56:00 +05:30
Arsalan Yaldram
889fd9075c
Merge pull request #12372 from appsmithorg/fix/7554-disabled-button-enable-tooltip
fix: Disabled button widget tooltips stay open
2022-04-05 17:18:19 +05:30