Commit Graph

5017 Commits

Author SHA1 Message Date
Tanvi Bhakta
4975d8790b
fix: large app icons (#16473)
* ignore the value of width and height set by AppIcon

* unset -> 100%
2022-09-02 19:16:35 +05:30
akash-codemonk
254bdb5fe0
chore: some datasources not appearing in templates tab (#16335) 2022-09-02 18:47:17 +05:30
akash-codemonk
9bb1ad64ee
fix: welcome tour ending on page refresh (#16079) 2022-09-02 18:45:48 +05:30
Smruti Parida
0d892bea37
fix: Refactoring to replace all usages of isEqual method from lodash with equal method from fast-deep-equal/es6 (#16439)
* replaced all instances of _.isEqual, isEqual from lodash with equal from fast-deep-equal/es6

Co-authored-by: Smruti Parida <smrutiparida@Preetis-MacBook-Pro.local>
2022-09-02 14:46:30 +05:30
Tanvi Bhakta
a0292d432a
feat: import changes batch 2 (#15722)
* Remove treedropdown from ads

* Change Treedropdown imports

* Remove Notification Banner, change imports

* Remove Toggle from ads

* Change toggle imports

* explicitly declare function argument types

* Remove Menu from ads

* Change menu imports

* Remove Spinner from ads

* Change spinner imports

* Remove Radio, import changes

* test: updated flaky test under default meta (#15707)

* updated flaky test

* Updated tests

* updated tests

* updated the tests

* updated tests

* Update constants.ts

* add more typecasting

* Remove ListSegmentHeader, import changes

* Remove TagInputComponent, import changes

* Remove Switch, import changes

* Remove SearchInput, change imports

* Rename TagInputComponent to TagInput

* Remove ProgressiveImage, import changes

* import changes for SearchVariant

* Remove menu divider, import changes

* Remove TableDropdown, import changes

* Remove Switcher

* Remove StatusBar, import changes

* Remove showcase carousel

* Remove RectangularSwitcher, import change

* Add types to TableDropdown's args

* Remove MultiSwitch, import change

* Remove GifPlayerComponent, import change

* Remove DraggableList, import change

* Remove DisplayImageUpload, import change

* Remove DatePickerComponent, import change

* Remove CopyToClipBoard, import change

* Remove ColorSelector, import change

* Remove TabItemBackgroundFill, NumberedStep, ColorPickerComponent

* GifPlayerComponent -> GifPlayer

* change named import

* Remove FormFieldError, change imports

* Update to new version of Tree Dropdown

* Fix issue with ads/index.ts

* Test file fix

* Fix issue with merge?!?!??

* update design system to 1.0.18

* Bump ds version

* bump ds version

* bump ds version

Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-09-02 14:08:17 +05:30
Ayangade Adeoluwa
b0e7c2e60d
fix: Fix encrypted label icon and text alignment (#16414) 2022-09-01 22:55:36 +02:00
Ayangade Adeoluwa
80fa2c2713
fix: Blocks shortcut action execution when git modal is open (#16248) 2022-09-01 22:55:22 +02:00
sneha122
05ca82764c
fix: response table misalignment (#16267)
* Bug response table misalignment

* test mock widgets canvas build issue

* unit test added for table misalignment issue

* deleted unnecessary cypress tests

* removed unnecessary cypress changes

* comments added for the newly added function

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-01 19:28:56 +05:30
ChandanBalajiBP
61a5f0bd64
Unit test for datatype evaluation logic (#16332) 2022-09-01 16:32:30 +05:30
Souma Ghosh
ca11be276f
feat: Add new pageOffset binding to Table Widget (#16083)
* feature: Add new pageOffset binding to Table Widget

* Add jest tests
Modify getPageOffset to account for failed tests

* Review changes

* take page size as tableData.length when Serverside pagination is on

* Update bindings count in cypress test for table widget v2

* Changes default value of pageOffset to 0
Use pageSize instead of tableData.length when tableData is not available

* Update jest tests according to changes in the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-01 15:31:02 +05:30
Bhavin K
e3001757a2
fix: show the form setting in button widget (#16013)
* fix: show the form setting in button widget

* test: fix test case

* refactor: code refinement

* refactor: remove hidden fun. for form setting

* refactor: remove unused var

* refactor: recall the old code

* refactor: remove the parent hack for hidden

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-01 15:08:41 +05:30
Hetu Nandu
16e62fb64f
feat: Fetch Appsmith version when browser tab comes on focus (#16153) 2022-09-01 14:17:29 +05:30
Souma Ghosh
3d40780d94
fix: Table reverts column positions on sorting if columns returned differ (#16237)
* fix: Table reverts column positions on sorting if columns returned differ

* Adds Cypress tests

* Update cypress tests to reorder column and validate

* Adds another assertion to table column order cypress test
2022-09-01 11:40:19 +05:30
Tolulope Adetula
6bed5a3b7a
fix: TreeWidgets issues (#16401)
* fix: TreeWidgets issues

* fix: make FlattenedOptions derived props

* feat: add more test cases

* fix: test issues
2022-09-01 06:40:04 +01:00
arunvjn
fce2352599
fix: fast render form elements in UQI query editors (#16199) 2022-09-01 10:41:57 +05:30
akash-codemonk
c9ac2e9568
chore: show template fork modal based on query param (#16193) 2022-09-01 09:28:04 +05:30
Ankita Kinger
2f8e3f5c33
Shift loader component to common file (#16375)
Shifted loader component to common file so that it can be used in other components as well.
2022-09-01 06:07:20 +05:30
Ayangade Adeoluwa
0e49c6efa9
fix: replace action execution cancellation toast errors with a better one (#16277)
* Remove error messages when user cancel action executions

* Add toast message after user cancels action execution

* Change error message

* Cypress validation for Bug #1609 added

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-31 18:08:42 +00:00
Rishabh Rathod
55082812b2
revert: "fix: dataTree mutation (#15952)" (#16406)
## Description

This reverts commit dbcc643ccf.

Fixes #16378

## Type of change

- Revert changes which impacted performance

## How Has This Been Tested?

Manual performance verification 

@ramsaptami 

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
2022-08-31 13:38:17 +00:00
Arsalan Yaldram
4c9484935b
fix: Property pane dropdown for currency and phone input widgets. (#16379)
* fix: Property pane dropdown for currency and phone input widgets.

* fix: added focus on open, added test cases
2022-08-30 11:33:31 +05:30
Ankita Kinger
3bd313864c
fix: Hiding the add new button in new workspace created if user has app viewer access (#16363)
* hiding the add new button in new workspace created if user has app viewer access

* refactored some parts of code

* minor change
2022-08-29 14:46:24 +05:30
Arpit Mohan
0ef456de1e Modifying the version display in the admin panel 2022-08-28 03:52:25 +05:30
Arpit Mohan
ab5b59e276
chore: Removing the Community/Business edition display for cloud hosting. (#16352)
The edition string will only be shown for self hosted instances. This change is being done because Appsmith Cloud doesn't yet support Business edition yet.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

Manual

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-08-28 02:52:53 +05:30
Ankita Kinger
d00e448dda
feat: Make headers sticky on Members page (#16292)
* css changes for members page

* fixed members page UI

* minor css change

* updated styles

* added a comment

* css change

* removed multiple copies of Back button component
2022-08-27 19:57:10 +05:30
Arpit Mohan
037efacbf3
fix: Display community edition along with version (#16341)
## Description

This PR adds the string `Community` along with the Appsmith version. This will help users identify the type of instance that they are running.

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

Manually

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-08-27 15:10:03 +05:30
Ashok Kumar M
bb60ce6889
fix: useCanvasDragging should not be called in View mode. (#16030)
* Fix: useCanvasDragging should not be called in View mode.

* fixing test that broke coz of rebase.
2022-08-26 18:43:48 +05:30
nzidol
a5851cd171
feat: Added Vanuatu Vatu to currency list (#16121) 2022-08-25 17:17:03 +05:30
Rishabh Rathod
dbcc643ccf
fix: dataTree mutation (#15952) 2022-08-24 22:06:54 +05:30
Pawan Kumar
8884345aee
feat: Select Reskinning (#16173)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* update input

* fix input

* fix input

* fix input fix

* fix disalbed icon color

* empty commit to deploy again

* address review feedbacks

* fix font in dropdown

* fix colors

* fix search icon alignment

* fix space in right cross icon

* fix colors and label alignment

* fix margin top in tooltip

* replace red color with css variable

* Json form field spec fix

* wip

* fix select styles

* fix select styles

* fix select styles

* fix css

* update focus color

* fix error state

* fix hover state

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-24 20:31:45 +05:30
Sangeeth Sivan
e9d719103c
chore: code split sagas and reducer's index file (#16261)
* chore: code split sagas and reducers index file

* fix: update imports

* chore: remove acl reducers file on ce

* fix: code split reducers properly

* chore: remove unnecessary import

* chore: split root sagas file
2022-08-24 17:46:32 +05:30
Dhruvik Neharia
11d33b79cd
feat: Add USA to the Map Chart Widget (#16130)
* feat: Add USA to the Map Chart Widget

* test: Add USA test to Map Chart Cy Spec
2022-08-24 13:49:24 +05:30
Dhruvik Neharia
7b222d0237
fix: Series Title Custom Charts (#16232)
* fix: Series Title not showing up for custom charts

* fix: Always get series title from dataset name for Custom Charts
2022-08-23 19:02:57 +05:30
balajisoundar
38f9661e45
fix: Table widget pagesize in short row height mode (#16045) 2022-08-23 17:19:59 +05:30
Ayangade Adeoluwa
3de00c6bf4
feat: Extraction of AST Logic (#15892)
* POC for Shared AST Logic using Yarn Symlinks

* fix: preinstall script for bundling shared packages

* Merge commit

* fix: updated the script to link, unlink the package as shared dep

* fix: updated dependencies

* Add a post-install script and fix yarn.lock file

* Remove commented code

* fix: added verification script, readme, moved scripts to shared

* Extraction of AST Logic into shared/ast folder

* Add jest test script

* Replace hardcoded ast Logic use with Shared AST module

* Replace parse code with getAST

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-08-23 16:39:42 +05:30
Souma Ghosh
5cf06cd071
fix: Table Widget shows scrollbar when not in focus (#15573)
* fix: Table Widget shows scrollbar when not in focus

* Scroll bar fix for table widget v1

* - Shows all table scrollbars on hover for table widget v2
- Extends ScrollIndicator component to support showScrollbarOnHover functionality

* json field spec fix

* Changes requested in review

* index.js revert

* Review changes

* Club hover and active css together in scrollbarOnHoverCSS

* Fix "scroll thumb not visible until first scroll" issue

* Fix some typos in comment

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-23 12:02:48 +05:30
Rimil Dey
b502332076
fix: catch block not working in firefox and safari for async functions (#15376)
* Add error.message only to data.reason, since the call stack being sent to responsePayload is different for different browsers. This fix ensures a consistent behaviour across all browsers

* Add integration tests

* Update test to typescript

* Fix error message

* Use new error instead of message object

* Code review fix

* Add else block to catch unknown errors

* Update tests

* Get back to original solution - error solution not working in safari
2022-08-23 11:32:31 +05:30
Trisha Anand
8f3591615a
feat: RBAC framework (#14823)
Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
2022-08-22 23:27:07 +05:30
Sangeeth Sivan
c7158da79f
chore: code split sagas and reducers for abac (#16134)
* chore: code splitted sagas and reducers

* chore: add comment instead of disabling rule for empty function
2022-08-22 23:07:59 +05:30
Ankita Kinger
1800a45a85
fix: import of admin settings button (#16195)
fixed import of admin settings button
2022-08-22 22:52:09 +05:30
Arsalan Yaldram
46e368afa9
Revert "fix: Fix Encrypted Text alignment" (#16191)
Revert "fix: Fix Encrypted Text alignment (#15866)"

This reverts commit aef6b4575f.
2022-08-22 17:45:03 +05:30
Rishabh Rathod
b7de2c0c9c
fix: ternserver code (#16179)
## Description

Hotfix to resolve `focusedValue` undefined error 
## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?



## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-08-22 13:37:03 +05:30
Rishabh Rathod
83d30b8d05
fix: autocomplete fixes & enhancement (#15857) 2022-08-22 11:17:24 +05:30
Arsalan Yaldram
aef6b4575f
fix: Fix Encrypted Text alignment (#15866) 2022-08-22 11:12:51 +05:30
Dhruvik Neharia
9dae56ef30
fix: Allow "spaces" in theme names while saving and display a more relevant error message (#15837)
* fix: Allow 'space' in theme name while saving a new theme

* feat: Add more relevant error message for theme name while saving theme

* chore: Remove SPECIAL_CHARACTER_ERROR msg since it's not being used anywhere

* cy fix

* cy fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
2022-08-22 10:52:11 +05:30
albinAppsmith
fbc3bd663b
feat: Migrate design system components import to design-system repo - I (#15562)
* Icon component deleted and changed the imports in refrence places

* design system package version changed

* import changes

* Delete TextInput.tsx

* Change imports

* Change single named import

* Update package

* Update package

* Delete ScrollIndicator.tsx

* Change imports

* Icon import completed

* Event type added

* Changed Button component imports

* import change button

* Button onclick type fix

* Label with Tooltip import changes

* Changed breadcrumbs import

* EmojiPicker and Emoji Reaction import changes

* AppIcon import change

* import bug fix

* Menu Item import chnages

* Icon selector imports changed

* Delete LabelWithTooltip.tsx

* Change imports across the app

* Update package version

* Update version number for design-system

* Delete Checkbox.tsx

* Remove the exports

* Add lock file for ds package update

* Change imports

* default import -> named

* Update release version

* Make arg type explicit

* Updated design-system to latest release

* Missing file mysteriously comes back and is updated accordingly

* changes design-system package version

* Add types to arguments in the onChange for text input

* onBlur type fix

* Search component in property pane

* WDS button changes reverted

* package version bumped

* conflict fix

* Remove Dropdown, change imports

* Category import fix

* fix: table icon size import

* Bump version of design system package

* Yarn lock

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
2022-08-22 10:39:39 +05:30
Rishabh Rathod
5da0411fa9
fix: Autocomplete object value binding (#15999)
## Description

Fixes #15950
Fixes #16141

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
**Test plan**
- [ ] https://github.com/appsmithorg/TestSmith/issues/1982
- [ ] https://github.com/appsmithorg/TestSmith/issues/2049


## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-19 19:09:07 +05:30
ashit-rath
893fd34cdd
perf: Widget re-rendering refactor (#14485)
* initial commit

* props hoc

* changes

* removed ignores and withWidgetProps

* added extra props to canvasStructure

* widget props changes

* list widget changes

* reintroduced widget props hook and other refactors

* remove warnings

* added deepequal for childWidgets selector

* fix global hotkeys and tabs widget jest test

* fix main container test fix

* fixed view mode width

* fix form widget values

* minor fix

* fix skeleton

* form widget validity fix

* jest test fix

* fixed tests: GlobalHotkeys, Tabs, CanvasSelectectionArena and fixed main container rendering

* minor fix

* minor comments

* reverted commented code

* simplified structure, selective redux state updates and other inconsistencies

* fix junit test cases

* stop form widget from force rendering children

* fix test case

* random commit to re run tests

* update isFormValid prop only if it exists

* detangling circular dependency

* fixing cypress tests

* cleaned up code

* clean up man cnavas props and fix jest cases

* fix rendering order of child widgets for canvas

* fix dropdown reset spec

* adding comments

* cleaning up unwanted code

* fix multiselect widget on deploy

* adressing review comments

* addressing minor review comment changes

* destructuring modal widget child and fix test case

* fix communityIssues cypress spec

* rewrite isVisible logic to match previous behaviour

* merging widget props with component props before checking isVisible

* adressing review comments for modal widget's isVisible

Co-authored-by: rahulramesha <rahul@appsmith.com>
2022-08-19 15:40:36 +05:30
Ayangade Adeoluwa
45c52c60da
fix: Fix template for MongoDB Raw command (#16034)
Fix template for MongoDB Raw command
2022-08-19 11:11:41 +05:30
subratadeypappu
0e2637b1b2
chore: Modified action execution payload to support data types (#16106)
* POC: Datatype handling autogenerated naming params client

* added array and file datatype

* handles all primitive types

* paramproperties convetred to map instead of array

* parametermap inversion

* handled no bindings bug

* feat: Consume action execution payload changes w.r.t. data type mapping (#15555)

This commit does the following things
1. It consumes data type metadata from payload
2. It consumes the mapping between the pseudo binding name and original binding name
3. It doesn't apply any logic w.r.t. data type identification after consumption

* added comments and cleaned code with proper datatypes

* removed URLencoding for binding params names

* feat: Remove URL decoding on param keys from server-side codebase (#15555)

* Remove unused import (#15555)

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
2022-08-19 01:01:47 +05:30
Aman Agarwal
14262e1601
fix: old column names exists even after renamed columns (#16076) 2022-08-18 21:53:24 +05:30
Bhavin K
d48976105d
fix: search functionality in tree select (#16073) 2022-08-18 16:00:37 +05:30
Tolulope Adetula
e36a28d7da
feat: Select default value control (#15856)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* Fix: Default Value Control

* fix: updated Multiselect

* Fix: issues with curly braces

* fix: Serverside filtering issue

* fix: revert commit

* Fix: empty commit

* fix: copy-paste widgets

* fix: use WidgetOperationSaga to fix copy-paste

* fix: update comment

* feat: add test for copy-past Select and MultiSelect
2022-08-18 08:10:58 +01:00
Pawan Kumar
ea04404de9
fix: Reskinning Input Widgets (#15546)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* update input

* fix input

* fix input

* fix input fix

* fix disalbed icon color

* empty commit to deploy again

* address review feedbacks

* fix font in dropdown

* fix colors

* fix search icon alignment

* fix space in right cross icon

* fix colors and label alignment

* fix margin top in tooltip

* replace red color with css variable

* Json form field spec fix

* fix css variable typo in checkbox

* fix css variable typo in checkbox

* fix label spec

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-18 11:56:07 +05:30
Aswath K
6645413dec
chore: Grouping & reorganisation of Table Widget (#15638) 2022-08-17 23:53:53 +05:30
Tolulope Adetula
7a3784e50e
fix: prevent children rerender in listwidget (#16015)
* fix: move to deepEqual

* fix: performance issue

* fix: improve code using klona import

* fix: refactor function
2022-08-17 22:26:19 +05:30
Favour Ohanekwu
b4875193c1
Fix set button type to prevent reload of page when clicked (#16090)
For most browsers the default type of button is submit, this could cause the page to reload when clicked. Setting button type to button, prevents this behavior.
2022-08-17 17:28:23 +05:30
Favour Ohanekwu
7c5f6c4bd4
Fix Show invalid page UI for invalid jsobject page (#16056) 2022-08-17 17:27:54 +05:30
Favour Ohanekwu
950e57aab7
Fix error with undefined triggerpath dependency (#16037)
Return early for undefined trigger field dependency
2022-08-17 13:57:59 +05:30
Sangeeth Sivan
3da13577f1
chore: integrate msw to browser to mock api requests (#15965)
* feat: msw browser integration to mock apis on dev

* chore: dynamic import to code split worker

* refactor: added new line at end of file
2022-08-17 12:01:55 +05:30
Ankita Kinger
dbbae79aec
feat: refactor invite modal UI (#15957)
* updated ads components required for invite modal refactoring

* removed unused code

* minor css changes

* implemented pr suggestions

* minor fix
2022-08-17 11:00:47 +05:30
Sangeeth Sivan
5e2e701220
feat: added support for loaders / spinners in table component. (#15683)
* feat: added loader/spinner support for table

* added empty data state in table

* updated no data UI for table

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-08-16 16:48:12 +05:30
akash-codemonk
583320bea6
fix: hide explorer menu on scroll (#15537) 2022-08-16 14:18:47 +05:30
Souma Ghosh
44d1885ae9
fix: Text getting clipped for Italic font in Table Widget V1 (#15549) 2022-08-16 11:12:31 +05:30
Bhavin K
0aafa388ec
fix: navigation issue in the Iframe widget due to src change (#15656)
* fix: navigation issue in the Iframe widget due to src change

* test: added test case for the iframe widget
2022-08-16 09:12:38 +05:30
Souma Ghosh
4acf5aa59c
fix: Cell background colour not applied to new columns in table widget (#15898) 2022-08-15 17:27:28 +05:30
Aswath K
b88564d96a
fix: unable to remove Icon on Input widget (#16007) 2022-08-15 09:44:58 +00:00
Aswath K
359d09d53e
chore: Grouping & reorganisation for Toggle widgets (#15706) 2022-08-15 13:35:46 +05:30
Aswath K
759ad4fda4
chore: Grouping & Reorganisation for Select Widgets (#15831) 2022-08-15 13:08:30 +05:30
Keyur Paralkar
d39cecbbb4
feat: chartwidget reskin feedback (#15621)
* style: added styles to chart configs

* style: adjusted axis names and legend position

* style:
* adjusting legend position
* removed background property at the widget level
* exposed current theme data at widget level

* fix: addressed feedback on chart widget reskin

* fix:
* style according to feedback
* styled custom charts

* fix:
* added migration for accentColor and fontFamily
* implemented reskinning feedback

* fix: changed the position of properties in custom chart config

* fix:
* added unit test for migration
* changed the caption color

* fix: spacing fix

* fix: added accentColor and fontFamily defaults

* test: added cypress test for chart reskinning

* test: fixed cypress test failure
2022-08-12 17:40:17 +05:30
Aswath K
b77a8cae81
feat: JS toggle for icon property of Inputs (#15947) 2022-08-12 14:35:37 +05:30
Ayangade Adeoluwa
0e36569b06
feat: Abort Query Execution (#15775)
* Snaps response view to certain height and adds abort query execution feature

* make raw string a constant

* Add cypress tests

* Remove theme variable

* move raw strings to constants in messages.ts file

* Fix test case description

* Comment out query abort action execution

* cy fix

* Fix abortion of parallel action execution like onPageLoad

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-12 12:49:17 +05:30
Pawan Kumar
a5733da363
fix: Cypress tests for admin settings's watermark setting (#15760) 2022-08-11 17:35:08 +02:00
Aswath K
ee32ffb76f
chore: Grouping & reorganisation for Input widgets (#15584) 2022-08-11 16:50:09 +05:30
Rishabh Rathod
e255593e28
fix: Improve Autocomplete for local vars, JSObject & ButtonGroup Widget
Add Autocomplete support for
- local variables 
- JSObjects
- ButtonGroupWidget
Remove Autocomplete suggestion for
- `eval`
-  undefined global values like `tabs`
2022-08-11 15:29:38 +05:30
Tolulope Adetula
c6ed1b7214
fix: select default value validation (#15846)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* fix: add jest test

* Empty Commit

* Fix: Empty commit to re-reun

* empty commit

* Empty Commit

* cy fix

* json field event fix

* TableFilter failure fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 10:02:55 +05:30
Dhruvik Neharia
ce2aafaee4
feat: Change default label position of RTE widget to top (#15769) 2022-08-10 14:00:24 +05:30
Rishabh Rathod
78379d4718
fix: update def on widget property name update (#15490) 2022-08-10 10:50:08 +05:30
rahulramesha
b4e9f648c3
fix: Multiple scrolls in view mode (#15679)
fix multiple scrollbars
2022-08-09 22:40:10 +05:30
Ayangade Adeoluwa
1ecffb8272
fix: Modify Form Control Inputs for various Datasource Actions (#15396)
* Modify control type for MongoDB Collection field

* Make more form control changes across datasources

* Fix cypress errors

* Fix typescript error

* Fix more cypress tests

* Fix failing MongoDBShoppingCart spec

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-09 13:05:59 +00:00
Aswath K
781620d57b
chore: Property Pane Grouping of Chart, Maps & Media widgets (#15557)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Adds FilePickerWidget

* Adds MapChartWidget

* Adds ContainerWidget

* Adds MapWidget

* Adds ImageWidget

* Adds AudioRecorderWidget

* Adds CameraWidget

* Adds ChartWidget

* fix: issues found in design review

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* Adds FormWidget

* fix: mapchart style section heading

* refactor: cleanup

* incoorporate latest change for Camera widget
2022-08-09 13:05:36 +00:00
Aswath K
6430adb413
chore: Grouping & reorganisation for multiple widgets (#15673)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties

* Adds TextWidget

* Adds RateWidget

* Adds DividerWidget

* Adds ProgressWidget

* Adds ListWidget

* adds TabWidget

* Adds IframeWidget

* Adds StatboxWidget

* Adds ModalWidget

* changes after design review
2022-08-09 13:05:15 +00:00
Aswath K
a3fe6a7826
fix: Remove unwanted logs which may confuse the users (#15815) 2022-08-08 19:24:37 +05:30
Shrikant Sharat Kandula
31481ddaae
fix: Disable polling transport for RTS (#15773)
Disable polling transport for RTS

This is required to support clustering of RTS, and with it, the Appsmith server.
2022-08-06 12:36:11 +05:30
Favour Ohanekwu
5c7f4009cb
fix: Correctly update trigger field dependency map (#15733) 2022-08-05 19:58:38 +02:00
Bhavin K
f85cbb9938
fix: reset the filepicker widget when the user goes to a different link (#15626)
* fix: reset the the fileficker widget

* test: add test-case for file-picker
2022-08-05 19:00:01 +05:30
Tanvi Bhakta
86f0da37db
feat: change imports for dropdown v2 and dependencies (#15081)
* Remove Dropdown, SearchComponent from this repository

* Change the imports so that SearchComponent and DropdownV2 come from the design system

* Add yalc

* default imports become named imports

* remove the yalc package, add the beta version

* Change import for SearchComponent in TableHeader

* Updated Label Config

* chore: Refactor dependency Map code (#14944)

* feat: Triggerpath dependency (#15015)

* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-05 10:05:28 +00:00
ashit-rath
ab5eb0e325
fix: JSONForm field event trigger binding get updated formData values (#15650)
fix: JSONForm field event trigger receive updated formData
2022-08-05 11:49:24 +05:30
Pawan Kumar
89b39e239b
fix: Reskinning Radio + Toggle + Checkbox (#15329)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* fix alignment issue

* fix cypress tests

* fix snapshot tests
2022-08-05 10:16:42 +05:30
Aswath K
56b247f421
Re-render of PropertyPaneConnections (#15552)
Prevents the re-rendering of PropertyPane connections when a property changes.
This improves the performance of the property pane a bit.
2022-08-04 18:21:54 +05:30
Bhavin K
66d3205f4f
fix: revert success flag from trigger response (#15641) 2022-08-04 17:30:53 +05:30
Tanvi Bhakta
819d43b5d0
feat: import changes for button tab component (#15507)
* Update ds package

* Remove ButtonTabComponent

* Remove exports

* Change imports

* bump ds package version
2022-08-04 10:30:36 +00:00
arunvjn
4e5b21600d
Optimise code editor renders (#15405) 2022-08-04 11:10:44 +05:30
Aswath K
7624b91026
chore: Grouping & Reorganisation for ButtonWidget, JSON Form widget and Audio Widget (#14379)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties
2022-08-04 11:01:05 +05:30
Anagh Hegde
82a9d720ae
feat: Added unconfigured datasources to the template API response (#15606)
Co-authored-by: Akash N <akash@codemonk.in>
2022-08-04 09:50:54 +05:30
Preet Sidhu
3cb57b531d
fix: tighten controls for fuzzy search in widget sidebar (#15032)
fix tighten controls for fuzzy search
2022-08-03 17:47:27 +00:00
Favour Ohanekwu
8ec31061e7
fix: Add support for crypto API in linting (#15607)
## Description

This PR adds [crypto web api](https://developer.mozilla.org/en-US/docs/Web/API/Crypto) support in linting

Fixes #15469 


## Type of change


- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- [x] https://github.com/appsmithorg/TestSmith/issues/1996

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented on my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-03 20:05:33 +05:30
Tolulope Adetula
9e66a774dd
feat: Multiselect defaultValue Validation Check for ServerSide Filtering(On/Off) (#15491)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests
2022-08-03 14:17:07 +01:00
arunvjn
7c37f7b35a
Add a new rule to show selectedRow in autocomplete's best match (#15406)
Refactored auto complete sorting logic.
2022-08-03 12:54:38 +05:30
Hetu Nandu
887832d29a
refactor: deprecate commenting and notifications (#15484) 2022-08-03 12:32:49 +05:30
Bhavin K
cf9b869b12
fix: improve camera widget (#14679)
* fix: issue points Android :2,3,6

* fix: improving the camera widget

* fix: show the device menu in fullscreen mode

* refactor: use getPlatformOS for check platform os

* refactor: add missing yarn file

* fix: camera switching issue when video mode

* fix: removed the audio/video mute button from ios devices

* fix: Disable the media button instead of hide in ios devices
2022-08-03 11:32:23 +05:30
Hetu Nandu
69490bbcbf
chore: Extend commenting deprecation deadline to 1.7.12 (#15616) 2022-08-02 10:02:34 +00:00
Anagh Hegde
1fb4cac6f5
chore: Update text message for git remote url placeholder (#15553)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-08-02 12:55:51 +05:30
Pawan Kumar
901749d442
fix: Delay in display of Intercom pop up when user tries to upgrade the Watermark property (#15576) 2022-08-01 21:20:37 +05:30
f0c1s
4ec0a1fe8c
fix: Improve ssh url checking for git import (#15494) 2022-08-01 10:50:38 +05:30
Tolulope Adetula
ef956ecad0
feat: Select defaultValue Validation Check for ServerSide Filtering(On/Off) (#15133)
* feat: defualt value check

* fix: Empty commit trigger deploy

* Fix: add more tests

* fix: improve validation

* Feat: improve jest test

* fix: more tests

* Fix: add github link

* Update app/client/src/widgets/SelectWidget/widget/index.tsx

Co-authored-by: ashit-rath <ashit@appsmith.com>

* fix: add more comment to issue

* fix: failing test

* fix: cypress config

* Fix: empty commit

* fix: select issue

* Fix: failing tests

* fix: failing Tests

Co-authored-by: ashit-rath <ashit@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2022-08-01 06:02:48 +01:00
balajisoundar
a6d37625a1
fix: provide access to currentRow in table widget menubutton items (#15457) 2022-08-01 10:31:34 +05:30
Keyur Paralkar
c396224fe8
fix: filePicker widget re-skinning (#15183)
* fix:
* added css variables for primary color
* added styles for dropHint custom icon

* feat:
* styled the remove uploaded file icon to match re-skinning
* added theme font-family to the contents inside the upload modal
* styled upload button to match re-skinning

* feat:
* set cancel button color to theme's primary color
* set the close button style according to theme
* set the border radius of the upload modal
* set the error message styles in accordance with re-skinning

* fix: cross mark position on the top right corner of upload modal

* fix: added hover background color on modal back and add more files button

* fix: added border radius fix for file remove button

* fix: modal close icon

* fix: addressed feedback from dilip

* fix: font-family issue inside the modal

* test: added cypress test to test styling logic
2022-07-29 10:29:02 +05:30
ashit-rath
b21c8cff31
fix: JSONForm input field REGEX validation (#15316)
* fix: JSONForm input field REGEX validation

* fix cypress test
2022-07-29 09:49:39 +05:30
Pawan Kumar
bae0b75583
feat: Code-split for admin setting for toggling appsmith watermark (#15036)
* create checkbox

* code split for hiding branding badge

* code split for hiding branding badge

* code review feedback fixes

* rename auth to upgrade button

* update mobile branding badge

* change label

* minor refactor

* minor updates

* add a cypress tests to check if watermark setting contains a upgrade button
2022-07-28 14:08:37 +05:30
Arsalan Yaldram
a02155fc88
fix: remove appsmith incoming entity from widget entity dropdown (#15324)
* fix: remove appsmith incoming entity from widget entity dropdown
2022-07-28 13:08:50 +05:30
Arsalan Yaldram
9dea163172
fix: show clear input icon on allow clear value (#15232)
* fix: show clear input on allow clear value

* fix: truncate select input on small size
2022-07-27 22:33:05 +05:30
akash-codemonk
3fdce8462c
fix: onboarding visual distraction from the entity explorer being hidden (#15446) 2022-07-27 19:29:43 +05:30
akash-codemonk
526f2a8be6
chore: fix cannot read properties of null (reading 'id') sentry error (#15323) 2022-07-27 16:25:41 +05:30
Favour Ohanekwu
e5d89e7099
chore: Upgrade astring version from v1.7.5 to v1.8.3 (#15245)
## Description
Previous version of the astring library doesn't preserve parenthesis when transforming AST to JS Code. This led to syntax error when null coalesce and logical expressions are used together.

The latest version of astring library fixes this.

<img width="1291" alt="screenshot_2022-07-16_at_04 29 52" src="https://user-images.githubusercontent.com/46670083/179581475-863d70f2-0886-403a-a667-a32ad93e76b7.png">


Fixes #15283 


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
Test plan

- [x] https://github.com/appsmithorg/TestSmith/issues/1970

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-27 14:48:39 +05:30
Bhavin K
47cc518dbe
fix: set default on reset of The Tab widget (#15202) 2022-07-27 14:26:16 +05:30
Arsalan Yaldram
22250b88a0
fix: updated marked to the latest version (#15309)
fix: updated marked added @babel/helper-create-regexp-features-plugin
2022-07-27 14:04:47 +05:30
Hetu Nandu
a1e5b511eb
chore: Deprecation warning for comments (#15363)
Adds deprecation warning for comments

Resolves #15364
2022-07-26 18:04:54 +05:30
Parthvi
58c7f3d805
test: Update documentation URLs used in tests (#15419)
## Description

With the new documentation structure, updating the URLs which are being used in tests.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-26 12:58:07 +05:30
Ankita Kinger
3b7ace67b5
feat: migrate texts and error messages from organization to workspace (#15410) 2022-07-25 17:52:09 +05:30
Favour Ohanekwu
0f92b97226
feat: Triggerpath dependency (#15015)
* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 21:31:08 +01:00
Bhavin K
f45a15545d
fix: depercate form button widget (#14510) 2022-07-22 08:27:37 +00:00
Rishabh Rathod
6ad308ec39
chore: Refactor dependency Map code (#14944) 2022-07-22 12:32:16 +05:30
Souma Ghosh
d45a6bfb97
fix: Compact property not functional for menu type in table widget v2 (#15302)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:45:48 +05:30
Souma Ghosh
27e91f8524
feat: Expose message event details for Iframe Widget (#14730)
* Expose message event details for Iframe Widget

* Change meta property name from messageEventProps to messageMetadata

* Cypress test for Iframe Message event details

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:42:57 +05:30
jaden
06e7d3cc63
CSS cant apply when constant WIDGET_PADDING=0 (#15227) 2022-07-21 18:34:10 +05:30
Favour Ohanekwu
243dc7f477
Improve lint error reporting (#15098)
Core changes in this PR

    Prevents logging of lint warnings (not errors) in the debugger
    Refined message for using 'await' in non-async functions
    Show lint error messages that include line numbers (previously weren't shown)

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-21 18:31:23 +05:30
Nidhi
50172ecd64
fix: Added support for self signed certificate during OAuth2 flows (#14719)
* Added support for self signed certificate during OAuth2 flows, server side changes

* fix: authentication.useSelfSignedCert key added

* Merging from release

* Fixed issue with dependencies, plus bug with using ssl

* Cypress test attempt 1

* Cypress test attempt 2

* Cypress test attempt 3

* Clean up

* Review comments

* Enabled compression again

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-07-21 16:10:36 +05:30
Hetu Nandu
48d2294f84
chore: typescript build error (#15262) 2022-07-21 09:30:02 +05:30
Bhavin K
7ecca954c7
fix: changed the marker(default) value string to number (#15217) 2022-07-20 18:46:06 +05:30
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 (#14158)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* refactor code to migrate from org to workspace

* migrated a few missed out org to workspace

* updated a few more

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* reverted code change

* few more changes

* fixed failing cypress test

* fixed failing cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
Preet Sidhu
c03fddf1c9
fix: Improve CodeMirror rendering performance using idleCallback (#13676)
* working editor wrapper

* updated other property controls

* fix tablefilter_spec unit test

* autofocus on editor

* update font styles

* show lint errors

* add syntax highlighting

* fix import issue

* fix input height

* use lazy and suspense

* wip

* update code clean up

* update input style

* fix select widget issue

* fix build issue

* fix import issue and linting css

* update lint error method

* add polyfill for idle callback

* fix undo aggregate helper changes

* rename CodeEditor component

* fix tests add delay before code mirror

* undo name change

* rename lazy editor

* add comments and update aggregate helper

* fix cypress helper

* fix testJsonText command

* update aggregate helper

* add wait to allow time to load

* fix filepicker issue

* fix currency input test

* fix unit tests

* update aggregate helper

* fix table property tests

* fix test

* fix command

* update json text command

* updated command ii

* update iii

* update iv

* add force click

* check for wrapper

* fix for objects

* fix test iv

* fix test v

* fix tests vi

* fix tests vi

* fix variable naming issue

* fix tests vii

* remove wait from wrapper click

* fix tests viii

* fix recheck wrapper availability

* fix updateCodeInput command

* fix undo while loop

* fix ix

* fix each loop

* removed EnableAllCodeEditors

* updated tests

* Upated wait

* updated some more tests

* updated wait time

* updated common method

* updated all related common methods

* update state name and add callback timeout

* updated test

* updated the test

* fix use while loop and update count

* update click func

* fix use get instead of find

* fix on click action command

* remove comments

* fix: update import statements

* add force click to widget command

* update wrapper ui

* fix auto load code editor

* update editor wrapper ui

* fix lineheight adjustment

* refactor editor wrapper

* update style import

* fix ascetic style import

* fix font style

* fix wrapper height

* update color for code block

* fix min height of content wrapper

* remove error linting and editor wrapper

* remove unused variable

* remove unused imports

* fix font color for objects

* update styles for placeholders

* remove console log

* remove react syntax highlighter

* cancel idlecallback on unmount

* Delay input foucs

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-20 14:56:12 +05:30
Souma Ghosh
eddd1e8344
fix: Multiselect widget height decreases on selecting more options (#15228)
Fixes issue where multiselect height decreases on selecting more options
2022-07-20 14:26:37 +05:30
Bhavin K
8848d89650
fix: Added the loader in the Button group widget (#15246) 2022-07-20 14:21:54 +05:30
ashit-rath
cb40e04aa0
fix: JSONForm default array item not deletable when default value initialized with undefined (#15205) 2022-07-20 14:07:52 +05:30
Aman Agarwal
4890742168
fix: api auth fails displays error on view mode now (#14767) 2022-07-20 13:09:11 +05:30
Rimil Dey
9284c5e240
Auto-indent JS code in the editor (#13222)
This pull request:

    introduces a new option to the menu in the JS editor which lets users prettify/auto-indent code.
    introduces a new keyboard shortcut that lets users prettify/auto-indent code
    Fixes bug where pressing CMD + <- in Mac (Home in windows) shifts the cursor to the first indented column. If the cursor is present on the first indented column, the cursor shifts to the 0th column in the editor

Fixes #9268
2022-07-20 12:43:23 +05:30
f0c1s
58dac0213c
Regenerate SSH key in connect and import flow (#14383)
As of today, we were supporting only ECDSA keys for GitHub, GitLab, and BitBucket. For Azure, RSA key generation was not available. This PR allows users to generate RSA or ECDSA keys.

As of now we support following key types and version control service providers:

    Github: ECDSA
    Gitlab: RSA, ECDSA
    Bitbucket: RSA, ECDSA
    Azure: RSA

Fixes #14382, #14715, #14570
2022-07-20 12:30:11 +05:30
Anagh Hegde
dbf0b94973
feat: Update the table widget to v2 in suggested widget list (#15277)
Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-20 12:28:50 +05:30
balajisoundar
71e581d69b
fix: cell background for edit actions column in Table v2 (#15233) 2022-07-20 11:42:59 +05:30
f0c1s
6eaabc3a7b
fix: reload default page on discard (#14964) 2022-07-20 11:40:06 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Hetu Nandu
5d568b7a6f
fix: Tooltip for long names in Entity Explorer (#15068) 2022-07-20 06:06:11 +00:00
Aswath K
8724f1c4fa
fix: Unwanted width calculation in Dropdown (#15239) 2022-07-20 06:05:44 +00:00
Aman Agarwal
10ca5b5033
fix: query creation via shortcut (#15281)
## Description

- Shortcut key-up and key-down were not working because the list of file operations on ui were filtered out of the `sectionTitle` but on key actions it was being referred to which was adding in the offset for the current active item.

Fixes #15264

## Type of change

- Bug fix (non-breaking change which fixes an issue)
2022-07-20 10:06:51 +05:30
akash-codemonk
086ac89565
fix: query forms which require evaluation shows loading (#15272) 2022-07-19 12:16:07 +05:30
f0c1s
df4fca9b8f
fix: show conflict info properly (#15240)
## Description

ConflictInfo was showing up along side discard button. Moved it to a row of its own.

Fixes #15113 

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:03:21 +05:30
f0c1s
654ae38e67
fix: break branch creation text, fix text casing (#15241)
## Description

During branch creation, a bit of text was clinging to each other. Put them as per the design.

Fixes #15014 

### Issue:

![image](https://user-images.githubusercontent.com/1573771/179294901-7820fe79-4f35-47fd-9f63-98a886f102b5.png)

### design:

![Screenshot 2022-07-16 at 12 40 39 AM](https://user-images.githubusercontent.com/1573771/179295031-bbb5ef67-8955-4901-997a-1f455bdf5bb0.png)

### fix:


https://user-images.githubusercontent.com/1573771/179295053-d5940ba7-2a9f-41a9-965d-596bff69ac71.mov

![Screenshot 2022-07-16 at 12 36 52 AM](https://user-images.githubusercontent.com/1573771/179295067-c82d3905-f325-47ed-9007-06b0c7104e86.png)


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:02:54 +05:30
Anand Srinivasan
53641d9c68
feat: filter error messages from hidden widgets (#14738)
* initial filter

* hide modal errors

* handle tabs and modal

* remove console logs

* clean up

* comment

* add comments

* handle nested tab

* unit tests

* update test

* uncomment

* show errors in isVisible bindings

* show all errors when widget has faulty binding for isVisible

* handle isVisible faults inside containers
2022-07-18 08:55:32 +05:30
Ayush Pahwa
886359b0a3
fix: UI alignment for key value arrays (#15235)
fix: added required padding for form label div
2022-07-16 17:20:58 +05:30
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30