Commit Graph

1425 Commits

Author SHA1 Message Date
Tolulope Adetula
589f2b9765
fix: select widget search improvement (#17006)
* fix: type issues in select widget

* feat: add cypress tests

* fix: select type issues in JSONform and Table Widget

Co-authored-by: souma-ghosh <souma@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2022-10-04 10:45:33 +00:00
subratadeypappu
d2de8f7cec
feat: Implement data type handling in MySQL (#16621) (#17017)
* feat: Implement data type handling in MySQL (#16621)

With this implementation we can now achieve the following under prepared statement:
- Ability to distinguish between null object and "null" string
- Ability to distinguish values like {{"098765"}} and {{098765}}. The former is identified as a string and the latter is identified as an integer

* feat: Add unit test cases on data type handling in MySQL (#16621)

* chore: Move MySQL specific types to a separate class (#16621)

* chore: Remove import shortening (#16621)

* Fix testStructure test case to have loose coupling with the order of tables (#16621)

* Fix: Add missing client-side data types in params in a few test cases (#16621)

* Fix query in test case (#16621)

* Fix test cases and add small refactoring (#16621)

* Refactor assertion with a check on Optional (#16621)

* additional cypress test cases for mysql

* updated test case object

* update for failing test cases

* mysql failure point fix

* mysql false spec failure point fix

* fix flacy test cases

* flacky JSON test cases

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-04 10:45:10 +00:00
Abhinav Jha
e6b89d03aa
Sandboxed iFrames with srcDoc (#11426)
Change iFrame widgets to use sandbox mode if srcDoc is provided
Allowed options:
`allow-forms allow-modals allow-orientation-lock allow-pointer-lock allow-popups allow-scripts allow-top-navigation-by-user-activation`

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-04 15:20:45 +05:30
Aishwarya-U-R
7596dfc35a
test: Script updates for flaky tests to unblock CI (#17264) 2022-10-03 15:25:11 +05:30
akash-codemonk
a560051d86
feat: fork templates inside an existing app (#17184) 2022-09-30 19:11:04 +05:30
rahulramesha
db6ebe3324
fix: Extra Space at the end of the Canvas in Viewmode (#16747)
We had logic to fix MainCanvas height when a Widget is dragged, resized or deleted. Extending that logic to When a widget is added to mainCanvas as well.

Also added logic to trim mainCanvas width in View Mode.
2022-09-30 13:49:52 +05:30
Souma Ghosh
54e00b9c5d
fix: JS toggle default value is wrong for vertical alignment table widget (#16733)
* fix: JS toggle default value is wrong for vertical alignment table widget
- Fixes wrong default value for Vertical Alignment in column settings
- Fixes issue where JS toggle cannot be turned off after turning it on once

* Fix failing cypress test

* Change horizontalAlignment default value to LEFT
2022-09-30 11:39:26 +05:30
balajisoundar
ed1dccaba7
feat: Table widget select column type (#16337) 2022-09-30 09:33:53 +05:30
Apeksha Bhosale
a0646bca77
fix: return statement is not necessary to execute .then and .catch execution (#16802) 2022-09-30 07:01:05 +05:30
Ankita Kinger
a1b24ab7dc
refactor: Invite modal component to support single & multi-select dropdown options (#17073)
* refactored code for invite modal

* updated invite users modal component

* minor change

* optimized addition of links in invite modal dropdown

* fixed a cypress test

* removed msw

* fixed a cypress test

* fixed a cypress test

* fixed a cypress test

* fixed a test
2022-09-29 09:53:25 +00:00
Arpit Mohan
c036087379
chore: Import template application to a git branch in application (#17032)
Also fixing the comodification array error when we are removing items from a list while iterating over it.
Fixes #17030

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-29 14:39:19 +05:30
Souma Ghosh
88fe538a70
feat: Autoassigns column datatype in table widget (#16701)
* feat: Autoassigns column datatype in table widget
- Limited to only number, string and boolean datatypes

* Review changes
Adjust jest tests accordingly

* Adds support for recognising Date type columns
Review changes

* Adds jest test for Date field

* Fix warning

* Adjust cypress tests and add helper method to account for code changes

* Fix failing test
2022-09-29 10:56:08 +05:30
Aswath K
756d27b00e
chore: Property pane config cleanup (#16639) 2022-09-29 10:54:49 +05:30
Pawan Kumar
f59f33c1f8
fix: RTE + Form + JSONForm reskinning (#16956)
* update rich text editor styles

* fix disalbed text  color

* add border

* fix gaps and borders in json form

* fix disabled state

* fix checkbox disabled state color on checkbox + font size of title in json

* fix disabled state of rte not re-rendering

* remove unused import

* fix cypress test
2022-09-28 17:28:40 +00:00
f0c1s
7ef0b9669a
feat: Introduce admin settings to left bottom pane (#17060) 2022-09-26 19:38:32 +05:30
akash-codemonk
9715bd3db3
chore: Revert "feat: fork templates inside an existing app (#14514)" (#17041) 2022-09-26 13:44:39 +05:30
Manish Kumar
bfc79bdfd3
feat: Informative error messages on cyclic dependency for queries on page load (#16634)
* This commit addresses the feature https://github.com/appsmithorg/appsmith/issues/16154

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-24 15:31:52 +05:30
Souma Ghosh
57f3b6fde5
fix: Table's last column doesn't resize properly (#16448)
* fix: Table's last column doesn't resize properly

* Adds comments to code responsible for dynamic resizing of last column width
Adjusts component width to account for widget padding
  - This fixes issue where last column goes outside the table container resulting in showing less padding-right for the last column cells

* Review changes

* Review changes

* Fix failing test
2022-09-22 16:45:00 +05:30
Souma Ghosh
172762bcc9
fix: Table filter issues (#16904)
* fix: Table Filter issues
- Filter reverts to previous operator upon removing a filter condition
- Removing a filter does not rightly update the filter value field
- Removing the second filter causes the table to crash

* Adds cypress tests for bug 12642 and 12638
2022-09-22 14:33:10 +05:30
Favour Ohanekwu
3e49ca175a
fix: cancelled execution causing multiple on page load execution failures (#16137) 2022-09-22 12:09:27 +05:30
akash-codemonk
1b43b16461
feat: fork templates inside an existing app (#14514) 2022-09-22 09:19:18 +05:30
Tolulope Adetula
42003b97b9
feat: parse CSV data using File Picker Widget (#16689)
* feat: user Papaparser for Parsing csv

* feat: enable dynamic typing

* Update cypress.env.json

* Revert "Update cypress.env.json"

This reverts commit 5ca9f43c8ad90c164b4ac68a9b3764eb9c4bd480.

* fix: reorder property pane

* feat: add helper text for property pane inputs (#16782)

* feat: improve helperText

* feat: add test for csv parsing in filePicker

* fix: proper types

* fix: add more test for helperText

* fix: type error

* fix: props issues

* fix: change file name

* fix: helper text

* fix: test
2022-09-21 13:59:17 +01:00
balajisoundar
56d58d8e55
fix: table editaction column should be disabled when injected (#16693) 2022-09-21 17:05:15 +05:30
Souma Ghosh
1dbcde6066
fix: Table interact-able columnTypes should not show in selectedRow (#16648)
* fix: Table interactable columnTypes should not show in selectedRow

* Review changes

* Update failing Cypress tests

* Remove comments
2022-09-21 16:28:11 +05:30
Souma Ghosh
5f0df66b91
fix: URL column in table widget not working correctly (#16425)
* fix: URL column in table widget not working correctly

* Adds cypress tests for URL column issue
2022-09-21 16:22:28 +05:30
Ayush Pahwa
e3f90db341
feat: grouping in console logs (#16698)
* fix: updated skip functionality

* update: type of logs to add occurence count

* update: reducer function to merge the new logs

* update: added dependance on last log's occurence count

* add: UI to show the occurence badge

* fix: added null check for dependency array

* update: omit occurence from compare fn

* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array

* fix: replaced forEach with reduce

* test: added functions for console log grouping

* feat: updated warning grouping color

* update: moved function to reducer file for jest tests
2022-09-19 06:29:04 +00:00
Rishabh Rathod
9a1fa98416
fix: Autocomplete now works with multiple bindings (#16314)
Fixes #16288
Fixes #16158
Fixes #16188
Fixes #15859
2022-09-19 11:02:06 +05:30
Favour Ohanekwu
d6fbdb15b9
feat: Linting in entity properties and methods (#16171)
* Initial commit

* Remove arrow function params from identifiers

* Remove invalid identifiers from extracted identifiers

* Remove invalid identifiers which are derived from function params and variable declarations

* Fix typo error

* Correctly remove invalid identifiers

* Remove invalid names from identifier list

* fix build failure

* Add Promise to list of unacceptable entity name

* Keep track of unreferenced identifiers in bindings

* Add Global scope object names as unusable entity names

* Keep track of unreferenced identifiers

* Prevent traversal of data tree for addition of new paths and entities

* Sync linting in trigger fields

* Support linting of invalid properties

* Fix linting reactivity bug in trigger field

* Remove unused objects

* Fix conflict in merging

* Lint jsobject body for function change

* Remove unused map from tests

* Code cleanup

* Modify jest tests

* Update jest tests

* Fix cypress tests

* Code cleanup

* Support  linting of multiple bindings

* Set squiggle line as long as invalid property length

* Add jest tests

* Minor code refactor

* Move ast to shared repo

* Rename confusing identifiers

* Improve naming of functions and their return values

* move shared widget validation utils and constants to shared folder

* Add jest test for invalid entity names

* Add cypress tests

* Modify test comment

* Extend list of dedicated worker scope identifiers

* Resolve code review comments

* Resolve review comments

* Annonate code where necessary

* Code refactor

* Improve worker global scope object

* Code refactor

* Fix merge conflict

* Code refactor

* Minor bug fix

* Redundant commit to retrigger vercel build

* Add null checks to dependecy chain
2022-09-17 18:40:28 +01:00
Ankita Kinger
db32d520d1
fix: Optimize reflows on the applications list page (#16812)
* optimized the reflows

* removed unneccessary changes

* fixing a cypress test

* updated a cypress test
2022-09-17 11:38:28 +05:30
ChandanBalajiBP
2b70914f31
test: mysql datatypes cypress test cases (#16696)
* test: mysql datatypes cypress test cases

* test: cypress added comments with cleaner code

* updates w.r.t review comments

* fix 10th cases failure

* fix for test failing on CI

* fix for test failing on CI another way

* fix: address review comments
2022-09-16 11:51:25 +05:30
Dhruvik Neharia
88637de7aa
feat: Code Scanner Widget (#15990)
* feat: Add QR Scanner Widget Folder

* feat: Add QR Code Scanner in the Modal

* feat: Add viewfinder and close button

* QR generator

* feat: Change deafult camera in QR Scanner to back camera

* feat: remove qr generator widget from the registry

* feat: update qr scanner icon

* style: qr code scanner modal and video container, remove futile code

* feat: add camera switch control panel to qr scanner

* fix: update input devices list when the menu opens in qr scanner

* fix: viewfinder in qr scanner responsive on mobile

* feat: Add onCodeDetected event to the QR Scanner widget

* feat: Add QR Scanner to autocomplete's entity definitions

* feat: Add tooltip to QR Scanner

* fix: isDisabled for QR Scanner

* feat: Add icon and related properties to QR Scanner

* feat: Add QR Scanner search tags, remove futile styles

* feat: Add QR Scanner to themes, regex for button color

* test: Add one cy test for qr scanner

* revert: Remove qr scanner from system themes, will be merged in a seperate PR

* fix: typo 'disable' to 'disabled' in qr scanner widget

* test: add disabled and visibility cy tests for qr scanner

* test: add open and close qr scanner modal test

* feat: remove qr scanner image for tests

* feat: add TODO item for solving performance issues for QR Generator widget

* feat: shift from react-qr-reader to react-qr-barcode-scanner to enable barcode and QR scanning both

* feat: Update QR Scanner Widget to Code Scanner Widget

* test: update tests from qr scanner to code scanner widget

* refactor: move code scanner's property pane config to individual files

* fix: code scanner error message on permission denied

* feat: remove Modal.setAppElement from code scanner

* fix: hide code scanner scan animation overflow

* feat: code scanner modal close on escape and overlay click

* fix: code scanner video border radius on mobile

* test: scan qr test for code scanner

* feat: Add Modal.setAppElement for code scanner modal accessibility

* fix: typo in search tags of code scanner

* feat: update property pane content helper texts of code scanner

* feat: hide code scanner widget from explorer

* fix: code scanner events not working

* feat: hide code scanner widget from explorer

* feat: Show Code Scanner widget in Explorer

* fix: remove code scanner scan cypress test

* feat: Add barcode reader to search tags and put Modal.setAppElement inside a block in code scanner

Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:25:32 +05:30
Keyur Paralkar
fff5c16f89
feat: table widget switch column type (#16262)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* feat: added switch column type to table widget

* fix: removed unused imports

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix: added unsaved marker and cypress test

* fix: alginment issues for the tooltipped wrapped switches

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix:
* cypress tests
* rebased new property pane changes for switch column type

* fix: merge conflicts on property section

* fix: address code review callouts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:04:11 +05:30
Rimil Dey
903aaa7a14
feat: Change navigate to UI (#14856)
* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Fix types and imports

* Update the tests

* Add ref back to the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:00:16 +05:30
Satish Gandham
12f9a005ae
chore: Refactor getSelectedWidget selector (#16647)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Rename getSelectedWidget to getLastSelectedWidget in selectors/ui

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-15 05:44:11 +00:00
albinAppsmith
3beea62e44
feat: Updates modal new design changes (#16553)
* feat: Updates modal new design changes

* Title and Subtitle font changes

* test cases fixed for product updates modal
2022-09-14 10:40:48 +05:30
NandanAnantharamu
642cdb886b
test: updated locator with wait for flaky test (#16734)
updated locator with wait
2022-09-14 08:39:09 +05:30
Parthvi
ca64ceb4fb
test: update cypress test fork_template_spec (#16719)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-09-13 12:50:09 +05:30
NandanAnantharamu
6f45430395
test: updated test and dsl (#16656)
updated test and dsl
2022-09-13 11:56:37 +05:30
balajisoundar
afb9aa93c1
feat: Table widget V2 Inline editing validation for plain text & number column (#15954) 2022-09-13 11:11:59 +05:30
Ayangade Adeoluwa
342c5cc673
fix: Fix Api url path issue (#16628)
* Fix Api url path issue

* Modify test cases
2022-09-13 05:02:59 +00:00
Ayangade Adeoluwa
b3c4f7c392
feat: AST apis for parsing script and returning identifiers (#16252)
* rts configurations for ast

* update shared dependencies.json for shared ast module

* feat: api for script to identifiers

* fix: typo for identifiers

* feat: api for multiple scripts to get identifiers

* fix: rts config, apis for ast

* fix: removed unnecessary changes for ast modules

* fix: docker image for rts including ast shared module, rts file alias ref

* fix: added comments in build.sh file

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-09-12 14:45:47 +05:30
Aishwarya-U-R
bdadb827e3
test: Script updates for flaky tests (#16631)
* CreateNewApp spec flaky fix

* fix

* Moved RepoLimit to commented files

* Inline spec failure fix - case 19

* Table FIlter specs V1/V2 split

* Binding/Table_Property_ToggleJs spec - V1/V2 fix

* Spec name update

* Wait increase

* DS - duplicate error capture fix

* revert

* Recaptcha spec fix

* Jsfun exe flaky fix - unskipped case

* jsfunc exec spec fix

* jsfunex spec fix

* Api bugs spec fix

* Api bugs spec fix

* Chartdata point spec flaky fix

* Theme_multiselect brown type fix

* Jsfunc exe spec fix

* Inline spec fix

* Inline spec fix

* Inline spec fix

* Theme multiselect spec fix

* Promises spec fix

* JSFun Exe spec fix

* Api_all verb methods update

* List1 spec 4th case fix

* Jsfun exe skipping 10th case

* jsunf exe 10th case trial fix

* firestore stub error capture

* jsonload failng spec skip

* JSonload spec fix

* json load spec fix

* Git repo moved back
2022-09-12 09:48:44 +05:30
Parthvi
ee8259d311
test: Fix flaky git tests (#16675)
* fix flaky git tests

* undo skip for git import tests
2022-09-12 08:59:06 +05:30
arunvjn
7d0dae89d8
fix: Better autocomplete for fast-xml-parser (#16452) 2022-09-09 22:07:33 +05:30
Sumit Kumar
0cbe81dfde
feat: merge GraphQL plugin to release (#16554)
* merge GraphQL plugin to release
2022-09-09 21:29:47 +05:30
Tolulope Adetula
b4b4284a56
fix:allow clear button in tree select widget (#16542)
* Fix: tree select allowClear button

* fix: import duplication

* Fix: add tests for bug

* fix: Add Placeholder fix

* fix: test case

* fix: remove comments
2022-09-09 04:55:31 -07:00
NandanAnantharamu
14140c10b7
test: fix for flaky test (#16534)
* updated test

* updated test

* uncommented the working tests

* updated test to avoid flakiness
2022-09-08 18:41:20 +05:30
Keyur Paralkar
e7209f06fd
feat: Table widget checkbox column type (#15933)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix: type casting issue for sectionName

* fix: addressed review comments

* chore: removed unused imports

* fix: added prop.hidden comparision in the memoized PropertySection component

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-08 16:35:59 +05:30
Arpit Mohan
8590308945 ci: Commenting out the test for git repo limit check
This test needs to be improved to hit TED instead of the Github API
2022-09-08 02:35:06 +05:30
Arpit Mohan
15ddca66c8
ci: Removing the git repo limit test as this test will fail in EE. (#16622)
We need to organize the Cypress test suite in a way that we have different checks running in CE vs EE.
2022-09-08 00:41:48 +05:30