Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
5,830 Commits 1 Branch 0 Tags 507 MiB
51b98eed2f
Commit Graph

4258 Commits

Author SHA1 Message Date
Sumit Kumar
cb9df80694
change default value of s3 file data type on create file action (#3685) 
- modify default value for s3 on file create to Yes.
- change dropdown option names to base64, text from yes, no.
 2021-03-24 15:02:13 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-24 14:33:48 +05:30
Vicky Bansal
06231e0f5f
Fix crash on Tabs property bindings (#3640) 2021-03-24 14:28:00 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-03-24 14:23:39 +05:30
Hetu Nandu
9a4c317f20
Store value improvements (#3663) 2021-03-24 10:39:47 +05:30
Sumit Kumar
56f22edbe8
Return hint message on identical columns (#3656) 
- Return hint message if identical column names are found in SQL query for postgres, MySQL, mssql, redshift plugin.
- Add a PluginUtils class to hold general utility functions for plugins.
 2021-03-24 08:22:49 +05:30
Nidhi
992da806bf
Added dummy instances to UI matrix (#3683) 2021-03-24 08:18:19 +05:30
abhishek nayak
2e53c79464
Update ForkApplicationModal.tsx 2021-03-24 00:35:46 +05:30
vicky-primathon.in
f4d25f6b2e Renamed ScrollIndicator to VerticalScrollIndicator 
Common css moved to DefaultTheme
 2021-03-23 20:51:13 +05:30
prapullac
9da0d7abf6
Added test ideas for Table and Hide feature of the page (#3594) 2021-03-23 17:56:31 +05:30
Shri
a18e569f7d
Fix data serialization in analytics (#3677) 
* Serialize object fields before sending to analytics

* Push event when application is published
 2021-03-23 17:13:02 +05:30
Apeksha Bhosale
28a4b4a6d6 test case fixed 
it was checking 3rd key:value pair for content type but with changes it will added to first empty field (0th)
 2021-03-23 16:55:21 +05:30
Apeksha Bhosale
5d71e86f43 Test case and refactor code 2021-03-23 15:14:44 +05:30
Hetu Nandu
2dd1791810
Refactor and add unit tests to API interceptors (#3647) 2021-03-22 14:52:24 +05:30
Hetu Nandu
f345619f40
Fix code coverage generation file (#3655) 2021-03-21 12:02:47 +05:30
Hetu Nandu
f1cb2a35b7
Add jest coverage diff reporting action (#3651) 2021-03-20 19:28:10 +05:30
Sumit Kumar
38c5639542
Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins. (#3518) 
- Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins.
- Added a new option default, apart from the the SSL mode types supported by the driver. Default means that go with whatever default configuration driver provides.
 2021-03-19 15:03:56 +05:30
Hetu Nandu
52c7f5331a
Trigger client integration only on approved PRs (#3632) 
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
 2021-03-19 14:21:14 +05:30
Hetu Nandu
64116583e3
Fix container widget dynamicBindingPathList correction (#3619) 2021-03-19 11:39:35 +05:30
NandanAnantharamu
a82c789c1a
udpated tests (#3617) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-19 11:19:54 +05:30
Nikhil Nandagopal
6b7fcc4c5d
Merge pull request #3615 from appsmithorg/minor-globalsearch-fixes 
Minor globalsearch fixes
 2021-03-19 11:17:00 +05:30
vicky-primathon.in
5fa3f3abd9 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-19 00:39:24 +05:30
vicky-primathon.in
bb77794125 handle scrollbar changes 2021-03-19 00:39:13 +05:30
Nidhi
93d5a061e2
Added logs and analytics (#3622) 
* Added logs and analytics

* Fix in error string

Co-authored-by: Shri <shrikant@appsmith.com>

* Review fixes :)

Co-authored-by: Shri <shrikant@appsmith.com>

Co-authored-by: Shri <shrikant@appsmith.com>
 2021-03-18 21:48:13 +05:30
Shri
bb1d0059d3
Clear OAuth tokens for forked datasources (#3609) 
* Clear OAuth tokens for forked datasources

* Fix datasource duplicate finder in light of oAuth tokens

* Fix potential NPE
 2021-03-18 21:08:56 +05:30
Kaushik Varanasi
55c17a66aa
Fix success message for single user invite and multiple user invite (#3591) 
* Fixed error message for single user invite

* updated success message for single user invite and created tests

* use state to detect and update the number of users invited

* removing unnecessary lines

* typo
 2021-03-18 19:20:33 +05:30
hetunandu
12aba25a00 Remove page save event from frontend 2021-03-18 19:15:57 +05:30
Pawan Kumar
80895b876b
Enhancement: Virtualized Query Editor Table (#3496) 
* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

* fix height issue in virtualized table

* useBlockLayout in Table

* add border-right on table row

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-18 18:40:57 +05:30
Rishabh Saxena
8acb365201 Fix placeholder 2021-03-18 18:19:05 +05:30
Rishabh Saxena
660b00b4d5 update title 2021-03-18 18:17:09 +05:30
Rishabh Saxena
82cd1b33ba fix document icon styles 2021-03-18 18:14:37 +05:30
vicky-primathon.in
354405d975 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-18 13:01:36 +05:30
Kaushik Varanasi
5f80e2561e
Merge pull request #3572 from appsmithorg/bugfix/trunncate-org-name-settings 
add ellipsis to org name in settings
 2021-03-18 12:39:52 +05:30
vicky-primathon.in
fb7cea6ec6 Resolved conflicts 2021-03-18 11:07:16 +05:30
ram-primathon
8b21dd30fd
add icon and subText in ads dropdown (#3598) 2021-03-18 02:06:26 +05:30
Hetu Nandu
441bb368d2
Reduce flakiness by adding waits (#3605) 2021-03-18 02:02:16 +05:30
Hetu Nandu
0debe37637
Add arbitary wait on onboarding test (#3604) 
We recently changed the test to make sure we wait for the client to create an onboarding data source if it did not exist. This kind of check was also happening on the source code, and the complexity was not getting translated properly in the tests.

To improve the reliability of the test, I added an arbitrary wait time before we start the building
 2021-03-17 23:59:40 +05:30
vicky-primathon.in
5f2d994fda Fix double imports 2021-03-17 18:00:16 +05:30
Vicky Bansal
1195a0b694
Reset selected row(s) when table data is changed (#3576) 
* Fixed selected row resets when table data is changed

Added cypress test case to test selected row resets when table data changes

* Fixed cypress test case
 2021-03-17 17:27:38 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30
vicky-primathon.in
9e65136a75 Merge branch 'fix/table-scrollbar' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:21:37 +05:30
vicky-primathon.in
212cd423b5 Added horizontal scrollbar component 
Add horizontal and vertical scrollbars in table widget
 2021-03-17 17:15:49 +05:30
Nidhi
084faf8d54
Typo ¯\_(ツ)_/¯ (#3595) 2021-03-17 17:04:53 +05:30
Hetu Nandu
b32cdfc8cb
Remove property pane custom scrollbar for cypress (#3592) 2021-03-17 15:56:34 +05:30
Rishabh Saxena
0e3901953b
Fix specs (#3577) 2021-03-17 15:06:08 +05:30
Kaushik Varanasi
8fd0509bcb Merge branch 'release' into bugfix/trunncate-org-name-settings 2021-03-17 12:45:13 +05:30
NandanAnantharamu
8aca378028
updated flaky test (#3584) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-17 10:38:00 +05:30
Kaushik Varanasi
f9d2318e5a reconciling with current release 2021-03-17 00:22:01 +05:30
Kaushik Varanasi
dfa23a6944 added tests, documentation and better naming convention 2021-03-17 00:18:36 +05:30
Apeksha Bhosale
3dc04901c8 added index check to add content type in existing field 2021-03-16 19:57:21 +05:30
Shri
cbd7828503
Add migration to remove template organization config (#3568) 2021-03-16 15:29:06 +05:30
Kaushik Varanasi
2dcecfbf79 add ellipsis to org name in settings 2021-03-16 13:22:25 +05:30
hetunandu
eed140f945 stringify page save analytics 2021-03-16 11:01:48 +05:30
Ashok Kumar M
fc34901be8
Fix: Dynamic Canvas Height based on bottom most widget. (#3398) 
* Fix: Dynamic Canvas Height based on bottom most widget.

* Checking cytest failure reason.

* Revert "Checking cytest failure reason."

This reverts commit 2e3aaa882b282e10e1cf491633101293b72ffa89.

* Using UPDATE_CANVAS_LAYOUT to update the layout.

* Remove unwanted declarations.

* Adding comments.
 2021-03-16 10:31:37 +05:30
Shri
e1fb1203b5
Application forking fixes and improvements (#3519) 
* Clone only those datasources that are actually used

* Retry when cloning app causes a name class

* Search for an existing datasource before cloning

* Test deep matching of datasources

* Refactoring, since now the tests pass

* Allow forking of owning applications

* Don't limit datasource naming suffix number
 2021-03-15 22:19:40 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057) 
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-15 17:47:56 +05:30
Vicky Bansal
03be391fa3
Wrap evaluated data in computed value field (#3520) 2021-03-15 15:27:43 +05:30
Vicky Bansal
7c994da6e9
Allow null/empty values in Dropdown widget options (#3533) 2021-03-15 15:25:37 +05:30
Vicky Bansal
5acf2c3238
Fully display Table Widget filter conditionals (AND|OR) (#3521) 2021-03-15 14:39:10 +05:30
Vicky Bansal
812344c439
Persist Table Widget cell height to use as default in deployed app view (#3537) 2021-03-15 14:34:33 +05:30
Vicky Bansal
030269f684
Display the date column output correctly in table when using JS toggle for Display date format 2021-03-15 10:59:01 +05:30
Vicky Bansal
7f43705e7f
Fixed undefined poperty error when columnOrder is undefined (#3511) 2021-03-15 10:57:34 +05:30
Shrikant Sharat Kandula
3d6bd51556
Fix NPE in action execution analytics (#3541) 
The NPE noticed is with the return value of `.getStatusCode`.
But this PR adds NPE guards to a few other potential cases.
 2021-03-14 07:58:27 +05:30
Rishabh Saxena
3a47e085e3
Minor global search updates (#3502) 
* Update editor header help button styles

* Dont show the current entity in the recents, to keep the previous on top
 2021-03-13 23:31:47 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798) 
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-03-13 19:54:45 +05:30
Hetu Nandu
89effdd2fb
Refactor evaluate function and add tests (#3536) 2021-03-13 19:42:21 +05:30
Rishabh Saxena
7bd1e9587c
Use replace instead of replaceAll (#3538) 2021-03-13 16:15:51 +05:30
ram-primathon
191dde0b18
Fix API pane header and params count (#3494) 2021-03-13 13:53:46 +05:30
vicky-primathon.in
c952e9b10d Remove unnecessary scrollbar from inside table widget 2021-03-13 12:06:02 +05:30
Nikhil Nandagopal
3b2072eeb9
Merge pull request #3055 from appsmithorg/fix/rte-newline 
Added defaultText and defaultHTML properties in RTE
 2021-03-12 17:38:58 +05:30
Nikhil Nandagopal
261dfc308c
Merge pull request #3514 from appsmithorg/fix/file-picker 
[Fix] Made bade 64 encoding the default type for S3
 2021-03-12 16:29:05 +05:30
vicky-primathon.in
3da86b33fe Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-03-12 15:24:51 +05:30
Nikhil Nandagopal
6bdd39c4b8 minor fixes 2021-03-12 14:47:42 +05:30
Nikhil Nandagopal
dbb16775de updated type to enum 2021-03-12 14:43:47 +05:30
Nikhil Nandagopal
82b65e12d1 Removed the property pane 2021-03-12 14:37:24 +05:30
Nikhil Nandagopal
11c8d4f34b made files a derived prop to change based on the file data type 
added file type
 2021-03-12 14:34:05 +05:30
Nikhil Nandagopal
d7a5f36fea Made bade 64 encoding the default type for S3 
Added a data field for file pickers that is filled based on the property pane value
 2021-03-12 13:44:32 +05:30
akash-codemonk
4995288801
Show fork modal while returning back to forking after signing in (#3509) 
- Show loaders where required and other styling fixes
 2021-03-12 13:14:16 +05:30
Abhinav Jha
246f7de444
Preserve Table Column properties when evaluations fail (#3495) 
* When there is a cyclic depenency, the table data is processed as s string, leading to incorrect column computations and a render loop. Fixed this by bailing out when table data is a string, as further computations are moot
 2021-03-12 12:00:38 +05:30
Arpit Mohan
f11cd45886
Correcting the github condition to start the API server (#3506) 2021-03-12 11:06:54 +05:30
ram-primathon
5b2832f380
Fix api settings page not getting updated (#3489) 2021-03-11 17:33:23 +05:30
Trisha Anand
217e36aaa9
Enrichment of analytics event for execute. (#3492) 
* WIP : enrichment of analytics event for execute.

* Plugin level : Catch all exceptions and set request in the result
Server level : Adding new fields to analytics : `isSuccessfulExecution`, `statusCode`, `timeElapsed`

* Dont catch StaleConnectionException. Server handles the same.

* Removed class specification for onErrorResume in plugins since its supposed to catch all errors.
 2021-03-11 15:40:07 +05:30
Shrikant Sharat Kandula
b12057ef73
Allow client to set layouts without id when creating a page (#3477) 
* Allow client to set layouts without id when creating a page

* Mild refactoring

* Fix Layout action tests
 2021-03-11 15:13:24 +05:30
Nidhi
f017ef29d4
Modified maven dependencies to reduce build time and jar size of s3 (#3491) 2021-03-11 14:58:07 +05:30
Trisha Anand
9f63bfafd2
Adding JSON intelligent substitution for Rest Api plugin (#3474) 
* POC : null value getting handled correctly

* Refactor code. Tested with and without quotes. This is working! Woohoo!

* Added support for mustache binding to include json objects and arrays

* Added test for smart substitution.

* Added setting to turn on/off smart substitutions in Rest API plugin

* Handling turning on smart json substitution

* Added error handling

* Added config to turn on smart substitution in JSON to make the tests pass now

* Adding a beta tag to the API setting.

* Spelling error resolved.

* Incorporated review comments.

* Catching JSON Parse exception in http call.
 2021-03-11 14:10:00 +05:30
Shrikant Sharat Kandula
1d683ad458
Fix recaptcha failing on signup when not configured (#3488) 2021-03-11 11:05:48 +05:30
Pawan Kumar
385baaddcb
Enhancement: Virtualized Query Editor Table (#3460) 
* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-11 10:25:37 +05:30
Hetu Nandu
bc646ab9b2
Fix: Delete tabs from the entity explorer (#3405) 
Co-authored-by: Akash N <akash@codemonk.in>
 2021-03-11 09:48:46 +05:30
Abhinav Jha
0172430489
Fix unreachable code reported by deepsourcelabs (#3483) 2021-03-11 08:46:50 +05:30
Shrikant Sharat Kandula
65568a4e13
Add more devices in AppLayout options (#3451) 
* Remove width and introduce more AppLayout type enums

* Fix: Adding min width to layout options.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
 2021-03-11 07:51:48 +05:30
Abhishek
0b4adf198d
Add recaptcha verification for user signup on the server (#3383) 
Co-authored-by: Abhishek <abhishek.ak@bytedance.com>
 2021-03-11 07:25:01 +05:30
dependabot[bot]
27bc73482a
Bump elliptic from 6.5.3 to 6.5.4 in /app/client (#3480) 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-03-11 06:40:35 +05:30
akash-codemonk
1be56a8512
Applications marked as forkable can be forked (#3453) 2021-03-10 12:38:20 +05:30
Sumit Kumar
aaf4ce95f2
use dynamic input text in plugin editor forms (#3470) 
- Use dynamic input text for plugin editor forms so that the evaluated value of mustache expression is visible.
- Those fields which are meant to store Key only - i.e. they are not visible to the user and are only meant to provide key for key value pair in db have been skipped.
 2021-03-10 12:29:19 +05:30
Hetu Nandu
4e4c6b76a8
Improve cylical dependency error (#3471) 2021-03-10 12:28:52 +05:30
Rishabh Saxena
08ebbe410b
Fix chat with us button at the editor help menu (#3465) 2021-03-10 11:27:17 +05:30
Sumit Kumar
b6961ce7a4
Add timeout failure for mongo plugin test datasource (#3431) 
- Mongo plugin client driver does not return with exception upon first failure - instead it keeps retrying. Hence, adding timeout error to report failure before the client thread cancels due to delay in response.
- It seems that the mongdb connection string cannot be directly used for ping test, hence skipping it.
 2021-03-10 11:11:14 +05:30
Sumit Kumar
04e8acb763
Custom S3 service support (#3469) 
- Provide support for non Amazon S3 service providers like Upcloud, Digital Ocean, Wasabi, DreamObjects and any other S3 compliant storage service provider.
- Change plugin label from "Amazon S3" to "S3"
 2021-03-10 10:30:07 +05:30
akash-codemonk
4fb55b4fd0
Fix: Incorrect validation of gif source in onboarding (#3448) 2021-03-10 09:44:43 +05:30
Hetu Nandu
a885fc8d3b
Fix chart data migration issues (#3458) 2021-03-09 20:05:42 +05:30
Hetu Nandu
6f4f2bb26c
Render placeholder text in the Key Value form input (#3452) 2021-03-09 17:35:29 +05:30
Shrikant Sharat Kandula
bb9a9a307f
APIs for profile photos (#3260) 
* Add API for uploading profile photos for current user

* Add delete and get APIs for profile photos

* Add test for uploading and deleting profile photo

* Added negative tests for upload profile photo API
 2021-03-09 17:03:20 +05:30
Trisha Anand
092a942036
Added support for Prepared Statement in MS SQL plugin. (#3438) 
* Added support for Prepared Statement in MsSQL plugin.

* Minor code formatting

* Merged release and refactored code for compilation.
 2021-03-09 14:42:53 +05:30
Trisha Anand
cd45a1dd74
Added support for Arrays in Prepared Statement in Postgres (#3421) 
* Added support for Arrays in Prepared Statement

* Minor code cleanup

* Super minor code readability changes

* Incorporated review comment
 2021-03-09 13:17:42 +05:30
Ashok Kumar M
4781f1096c
Fix: Modal Size gets cut in smaller screens. (#3441) 2021-03-09 11:27:44 +05:30
Abhinav Jha
0a7bf6d0d3
Deprecate UPDATE_WIDGET_PROPERTY action (#3392) 
* Deprecate UPDATE_WIDGET_PROPERTY action

* Handle JS property toggle independently
 2021-03-09 11:00:57 +05:30
Trisha Anand
38c0151e94
Changed order of message for easy grep in case of invalid dynamic binding path (#3436) 2021-03-08 16:05:05 +05:30
Trisha Anand
79164fde44
Only return request object in action execute if the action was executed in EDIT mode. (#3426) 2021-03-08 16:04:17 +05:30
Hetu Nandu
9bf78a06c0
Add analytical events on page save (#3434) 2021-03-08 15:58:20 +05:30
Hetu Nandu
6898a0bbd5
Fix for Table onPageSizeChange trigger executing when not defined (#3422) 2021-03-08 14:34:00 +05:30
imgbot[bot]
243082e568
[ImgBot] Optimize images (#3435) 
*Total -- 1,191.78kb -> 1,073.90kb (9.89%)

/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/images/no_search_data.png -- 2.59kb -> 1.63kb (37%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/link.svg -- 0.32kb -> 0.31kb (2.45%)
/app/client/src/assets/icons/ads/fluid.svg -- 0.57kb -> 0.56kb (1.37%)
/app/client/src/assets/icons/ads/entities.svg -- 0.22kb -> 0.22kb (1.32%)
/app/client/src/assets/icons/ads/tablet.svg -- 0.58kb -> 0.57kb (1.01%)
/app/client/src/assets/icons/ads/recent.svg -- 0.59kb -> 0.59kb (0.66%)
/app/client/src/assets/icons/ads/docs.svg -- 2.24kb -> 2.22kb (0.57%)
/app/client/src/assets/icons/ads/desktop.svg -- 0.73kb -> 0.73kb (0.4%)
/app/client/src/assets/icons/ads/mobile.svg -- 0.79kb -> 0.79kb (0.37%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.17%)
/app/client/src/assets/icons/ads/shine.svg -- 0.71kb -> 0.71kb (0.14%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.12%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2021-03-08 14:32:48 +05:30
Rishabh Saxena
99b3fa6bb8
Omnibar global search (#2903) 2021-03-08 13:54:12 +05:30
Dwayne Forde
2dfc8ebf8a
Adds support for base64 image strings to image cells (#2769) 2021-03-06 01:07:49 +05:30
Sumit Kumar
800d305dab
Gracefully handle the timeout overflow / out of expected range errors (#3411) 
- Expect max value of timeout as 60000 ms.
- If value exceeds max value then add error message to the list of invalids. This list is returned to the client in response body.
- Detect integer overflow exception (Number format exception) and override the value to 60000 ms.
 2021-03-05 17:09:29 +05:30
Trisha Anand
10cd7f5f80
Adding support for Prepared Statements in MySQL plugin (#3327) 2021-03-05 16:22:46 +05:30
prapullac
d452c78453
Adding manual test cases for Table (#3325) 2021-03-05 14:02:54 +05:30
akash-codemonk
e012ea54aa
Fix: Action name being appended with a 1 when moved to another page even when there is no duplicate (#3352) 2021-03-05 13:05:15 +05:30
hetunandu
8574b86926 Merge branch 'master' into release 2021-03-05 12:06:14 +05:30
Pawan Kumar
220b28df3e
Fix: TypeError: e is undefined (#3337) 
* add conditional operator

* check for widget before calling the function

* check for widget exisitence

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-05 10:04:35 +05:30
NandanAnantharamu
71f4a4b0a9
grouping another set of tests (#3404) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-03-05 00:35:41 +05:30
Hetu Nandu
2b2cee6bd6
fix chart validation (#3400) 2021-03-05 00:28:43 +05:30
Hetu Nandu
dc154b94b0
Fix widget updates not working properly (#3403) 
* Fix widget updates not working properly

* Revert "Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218)"

This reverts commit 39e4990a7f.
 2021-03-05 00:05:41 +05:30
Vicky Bansal
c4d6405981
Fix: RTE Error (#3385) 
* Added defaultText property for text type validations to fix invalid data type beings passed to RichTextEditor component

* removed text and defaultValue properties from widget property validation map
 2021-03-04 16:21:58 +05:30
Trisha Anand
20ed017a58
In case of no mustache bindings are found in dynamic path list, throw invalid dynamic binding reference error. (#3394) 2021-03-04 15:35:46 +05:30
akash-codemonk
39e4990a7f
Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218) 2021-03-04 15:24:01 +05:30
akash-codemonk
1e4878f983
Support editing user's name field (#3306) 2021-03-04 15:07:02 +05:30
Hetu Nandu
c81495e2cb
Fix chart data validation (#3389) 2021-03-04 13:40:22 +05:30
Rishabh Saxena
013c4230e2
Wrap ads button text within span for resilience for DOM mutations (#3292) 2021-03-04 11:34:36 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-03-04 10:54:47 +05:30
Ashok Kumar M
af6b3dfdbb
Fix: Drop overlay widgets anywhere and add them as main container child (#3332) 
* Fix: Drop overlay widgets anywhere and add them as main container child

* Using detachFromLayout config.
 2021-03-04 10:26:00 +05:30
Trisha Anand
5e448b9331
DSL parsing : Catch index out of bound exception (#3364) 
* In case index being referred does not exist, throw appropriate error during DSL parsing

* Fixing bad commit.
 2021-03-03 18:51:35 +05:30
Sumit Kumar
639913703a
Fix/add mongo srv support (#3341) 
Provide helpful error msg when srv url is provided to mongo plugin

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2021-03-03 18:31:04 +05:30
Trisha Anand
75b0986b92 Fixed the incorrect JSON string in INVALID_DYNAMIC_BINDING_REFERENCE appsmith error. 2021-03-03 18:22:42 +05:30
Shrikant Sharat Kandula
bb49f04f06
Support descending ordering for Firestore documents (#3340) 2021-03-03 18:18:57 +05:30
Trisha Anand
f49cc7b455
Added throwing a properly formatted error for client to consume when dynamic binding path list contains an invalid entry (#3343) 2021-03-03 17:47:35 +05:30
Trisha Anand
ca8be4c7f5
Db Migration : Delete unreferenced dynamic binding paths in actions (#3310) 
* WIP compute if the dynamic binding path list is correct.

* Tested code for deleting the incorrect dynamic binding path list from actions.

* Added comments for code readability
 2021-03-03 17:11:03 +05:30
Shrikant Sharat Kandula
9c50182f0e
API for forking of public applications (#3221) 
* A barely working API for forking a public application

* Tests WIP

* Mild refactoring in tests

* Refactoring in test

* Not all applications are forkable
 2021-03-03 15:45:47 +05:30
Vicky Bansal
d3c2c02745
Fix: Tabs Widget crashes when data is invalid (#3235) 
* Fixed tabs data validation and added check to ensure tab property is accessible when tabs array is not empty

* added isVisible property in validations
 2021-03-03 11:29:02 +05:30
Ashok Kumar M
a7e0990cf8
Feature: Canvas Layout Options(max width config) (#3141) 
* Feature: Canvas Layout Options(max width config)

* Fixing css issues.

* Changing Default Device option to Desktop.

* Changed Implementation to maintain resize updates within the client.

* Addressing code review changes.

* Updating device resolutions.

* updating cytests

* Fixing resize bug.
 2021-03-03 10:56:47 +05:30
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
Sumit Kumar
e5586a590a
fix placeholderText label in form.json files (#3331) 
fix placeholderText label in form.json files
 2021-03-03 09:33:02 +05:30
Piyush
462379721d
Reset widget global function (#3181) 2021-03-02 18:19:36 +05:30
Sumit Kumar
5bab77a141
remove endpoint host and port fields from dynamodb datasource form (#3316) 
- A consensus has emerged that the utility of overriding endpoint is only for local development and testing. Hence, removing the fields from datasource form.
 2021-03-02 17:25:25 +05:30
Sumit Kumar
6c04e1467b
Provide option for only one endpoint and port in the dynamodb plugin datasource form (#3314) 
- provide a max length to keyvalue_array type. If the max length is set to 1, then the "+" button will not appear.
- front end changes are pending. A new github issue will be opened to track the same : #3315
 2021-03-02 15:42:38 +05:30
Arpit Mohan
bf16b45f2b
Merge pull request #3309 from appsmithorg/release 
Release v1.4.1
 2021-03-02 13:41:51 +05:30
Trisha Anand
bd18030c2d
Add request body in case http method is not GET (#3307) 
* Add request body in case http method is not GET

* Incorporated review comments.
 2021-03-02 12:46:20 +05:30
Rishabh Saxena
7204e87ea5
fix help modal overlapping with close button (#3289) 2021-03-02 11:26:02 +05:30
Rishabh Saxena
d48e00422e
Minor code cleanups (#3165) 2021-03-02 11:25:45 +05:30
Trisha Anand
91e308665b
Requests preparation by plugins instead of ActionService (#3159) 
* Added action request in S3 plugin.

* Added request data in Dynamo plugin

* Added request in Elastic Search.

* Request in Firestore.

* Request added in Mongo

* MsSQL request added.

* Added MySQL request.

* Added Postgres request.

* Added redis request.

* Redshift doen.

* Catching AppsmithPluginExceptions at the plugin level itself to ensure that the request gets passed on as part of the result.

* Fixed failing plugin test failures

* Fixed AmazonS3 test failures.

* WIP post analytics working

* WIP : Making the request data confirm to existing analytics request data format.

* Fixed the headers in the analytics body.

* Migrations S3, Postgres to the accepted format for request in analytics

* Updated S3 action to be the query

* Migration completed for all plugins for analytics.

* Removed the old analytics event. Now sending only the new one.

* Ensuring all data is captured in S3 plugin request in case of error.

* Minor editing of firestore to ensure that the errors get caught by the plugin itself.

* Fixed test cases in Amazon S3

* Incorporated review comments.
 2021-03-02 10:58:46 +05:30
Young Yoo
d61a900011
Fix #2712 - Duplicate Property For Map Widget (#3174) 
After a Map Widget created, the text field in the Text Widget can bind the map properties. Inside the map properties, "Map center" and "Center" are duplicate value. The "MapCenter" is deleted for the adjustment.

Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
 2021-03-02 10:45:39 +05:30
imgbot[bot]
13b4d61b8f
[ImgBot] Optimize images (#3303) 
*Total -- 114.50kb -> 96.16kb (16.02%)

/app/client/src/assets/images/no_data.png -- 103.98kb -> 85.71kb (17.58%)
/app/client/src/assets/icons/control/vertical_align_top.svg -- 0.17kb -> 0.17kb (2.3%)
/app/client/src/assets/icons/control/vertical_align_bottom.svg -- 0.18kb -> 0.17kb (1.67%)
/app/client/src/assets/icons/control/heading_1.svg -- 0.32kb -> 0.31kb (1.54%)
/app/client/src/assets/icons/control/vertical_align_center.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.12%)
/app/client/src/assets/images/secure.svg -- 1.08kb -> 1.07kb (0.91%)
/app/client/src/assets/icons/control/paragraph.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/control/delete-column.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/hide-column.svg -- 0.52kb -> 0.52kb (0.56%)
/app/client/src/assets/icons/control/heading_2.svg -- 1.08kb -> 1.08kb (0.45%)
/app/client/src/assets/icons/control/checkmark.svg -- 0.96kb -> 0.95kb (0.41%)
/app/client/src/assets/icons/control/paragraph_2.svg -- 1.49kb -> 1.49kb (0.33%)
/app/client/src/assets/icons/control/bullets.svg -- 1.52kb -> 1.52kb (0.32%)
/app/client/src/assets/icons/control/heading_3.svg -- 1.52kb -> 1.52kb (0.32%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2021-03-02 10:24:47 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222) 
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-02 08:43:43 +05:30
dependabot[bot]
d7b7cb26fa
Bump prismjs from 1.22.0 to 1.23.0 in /app/client (#3300) 
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.22.0...v1.23.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-03-02 08:20:31 +05:30
Sumit Kumar
7d2effae18
Modify hint statement for 'import from curl' form (#3285) 
- Move to hint statement out of query box and put if above it - between the label and the query box - so that user's don't confuse it as a typed in statement.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-03-01 23:28:07 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
akash-codemonk
beb6eb8241
Add validation to check if organization exists during onboarding (#3243) 2021-03-01 15:21:23 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function" 
This reverts commit 54f158694f.
 2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
RIshabh Saxena
2a868c89a6 Revert "Wrap text with span for resilience for DOM mutations by google translate" 
This reverts commit e87ef2452e.
 2021-03-01 13:25:05 +05:30
RIshabh Saxena
e87ef2452e Wrap text with span for resilience for DOM mutations by google translate 2021-03-01 13:24:36 +05:30
Sumit Kumar
68e6c7b1d8
stop logging datasource argument error externally. (#3262) 
- Stop logging datasource argument error externally. The error described in the linked GitHub issue arises due to bad service account credentials provided as arg.
- Update error msg to make it clear.
- Add TC.
 2021-03-01 12:13:32 +05:30
Trisha Anand
31b20da347
Adding support for NULL value parameters in Prepared Statement. (#3255) 2021-02-27 18:59:51 +05:30
Sumit Kumar
d2643a18c3
check dynamodb connection validity using listTables cmd. (#3241) 
* check dynamodb connection validity using listTables cmd.
* add TC
* add encrypted logo to password field
* rectify the default value of region dropdown
* remove unused imports
 2021-02-26 16:57:18 +05:30
vicky-primathon.in
950c7b93bb Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-26 16:35:12 +05:30
Shrikant Sharat Kandula
a1d027bb59
Save separate appLayout for edit/view and sync on publish (#3245) 2021-02-26 16:18:04 +05:30
Hetu Nandu
1f7fc9c0ed
Api form on submit (#3225) 2021-02-26 14:52:11 +05:30
Shrikant Sharat Kandula
5808620716
Add API for the signed in user to set their name (#3164) 
* Add API for the signed in user to set their name

* Use the correct error in session handling
 2021-02-26 14:48:20 +05:30
akash-codemonk
0682a92d87
Update useEffect dependency (#3239) 2021-02-26 14:13:24 +05:30
Shrikant Sharat Kandula
dc146a1a16
Fix MongoDB test operation errors not being caught (#3234) 2021-02-26 12:55:54 +05:30
Piyush
21a2a2bdf4
Redirect URL for oAuth Auth code flow (#3232) 2021-02-26 12:28:47 +05:30
Piyush
c38e58b3bc
Fix race between action reducer and handleQueryCreatedSaga (#3236) 2021-02-26 12:28:03 +05:30
Vicky Bansal
5e8805b40a
Feature: selectedOptionLabel and selectedOptionLabels in Dropdown widget (#3205) 2021-02-26 11:54:25 +05:30
Vicky Bansal
118467c5bb
Feature: Show/Hide Tabs in Tabs Widget (#3192) 
* Added functionality to show/hide a tab from tab property pane controls

* Added isVisible property in tabs widget default value

* Passing visible tabs to component from widget. Added missing widgetId
 2021-02-26 11:47:21 +05:30
akash-codemonk
05b2cd6d29
Fix renaming action goes to the action page (#3201) 2021-02-26 11:15:27 +05:30
Pawan Kumar
7185536c67
Fix: Cannot read property 'length' of undefined (#3207) 
* update

* fix chart component on empty dataset

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-26 10:58:31 +05:30
akash-codemonk
7daeadd447
Fix current page not changing while switching to an action of another page (#3214) 2021-02-26 10:34:14 +05:30
NandanAnantharamu
4bed88d7e1
Added test for table data sorting (#2257) 
* Added test for table data sorting

* commented tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-26 10:18:27 +05:30
hetunandu
3cc1fbfefd Merge branch 'release' 2021-02-25 22:36:20 +05:30
Hetu Nandu
a8889d6985
Capture cyclical dependency on sentry (#3226) 2021-02-25 22:29:00 +05:30
Abhinav Jha
3e7d2bb720 Merge branch 'release' of github.com:appsmithorg/appsmith 2021-02-25 21:39:02 +05:30
Abhinav Jha
a1bda002c0 Fix issue where renaming table data keys did not delete the previous key 2021-02-25 21:36:27 +05:30
Arpit Mohan
73d47413ff Merge branch 'release' 2021-02-25 20:43:04 +05:30
Hetu Nandu
ffeb297a1a
Fix dynamic path duplicate issue (#3223) 2021-02-25 20:42:29 +05:30
Arpit Mohan
4f16b23352 Merge branch 'release' 2021-02-25 19:34:22 +05:30
Hetu Nandu
c2646a8863
Use property config for trigger properties (#3217) 
* Use triggerPaths and remove isDynamicTrigger argument

* Remove triggerMaps from widgets

* Fix property updates
 2021-02-25 19:30:02 +05:30
Abhinav Jha
bdc2d46192
Add min max values to datepicker control (#3215) 2021-02-25 17:47:13 +05:30
Shrikant Sharat Kandula
9f18aa2e69
Fix NPE in analytics on action execution (#3216) 2021-02-25 17:46:24 +05:30
Arpit Mohan
d420518cad Fixing merge conflicts 2021-02-25 17:29:49 +05:30
Hetu Nandu
4a557309ca
Fix eval error logging (#3206) 
* Update app/client/src/utils/WidgetFactory.tsx
 2021-02-25 17:23:06 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212) 
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
 2021-02-25 17:21:54 +05:30
Sumit Kumar
1e59ed4928
Internal fix: Remove raw response from transformed DynamoDB response structure. (#3209) 
* remove raw response from transformed response structure.
* update TCs
 2021-02-25 16:34:07 +05:30
Trisha Anand
42af1fa771
Only extract dynamic bindings from leaf nodes on update layout (#3210) 
* Only extract dynamic bindings from leaf nodes.

* Minor code refactoring

* Moved to using generic Map type instead of LinkedHashMap
 2021-02-25 15:56:45 +05:30
NandanAnantharamu
21eecb1fe6
WIP : Added test for chart datapoint validation (#3176) 
* Added test for chart datapoint validation

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-25 12:49:23 +05:30
Rishabh Saxena
6b13347157
Fix navigation to modal widget's children from the entity explorer (#3067) 2021-02-25 12:39:33 +05:30
Piyush
8383d79c91
Remove client side validation on save for OAuth Datasource (#3131) 2021-02-25 12:01:21 +05:30
Hetu Nandu
3944d7e43e
Sort order fix if property path gets updated via multiple start nodes (#3194) 2021-02-24 21:56:00 +05:30
Abhinav Jha
e197d13399
Fix issue when searching for certain places does not return a valid list from a google maps control (#3197) 2021-02-24 20:59:12 +05:30
akash-codemonk
7fa5e3b1af
Hide pages in publish mode (#3106) 2021-02-24 19:17:37 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186) 
* Fix selected row issue in view mode

* Remove un-select feature
 2021-02-24 15:59:19 +05:30
akash-codemonk
791d92af94
Add validation to check if widget exists (#3140) 
* Check if widget is present incase it got deleted etc.

* Update test
 2021-02-24 11:30:22 +05:30
Rishabh Saxena
c0222db163
Fix editor header popovers (#3173) 2021-02-24 10:42:12 +05:30
Sumit Kumar
63ff3c73fa
Fix execute on page load for api on app copy (#3150) 
* first draft

* added fix without TC

* cleanup

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* - add TC
- minor code refactor

* fix condition

* update clone page test

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-02-24 10:21:03 +05:30
Shrikant Sharat Kandula
68bbc4fb28
Support server-side pagination for Firestore (#3128) 
* POC for Firestore server-side pagination

* Load pagination information values from action configuration

* Get execution information for Firestore plugin

* Working implementation of pagination for Firestore

* Add tests for next and previou page navigations

* Require ordering to be set when paginating

* Remove commented code

* Don't report error on bad configuration

* Error out on usupported operation

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Move constant indices to constant fields

* Use executeParameterized instead of execute

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-02-24 10:20:08 +05:30
vicky-primathon.in
b474442ec7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-23 18:11:14 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889) 
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-23 18:05:09 +05:30
Shrikant Sharat Kandula
72df6fb299
Allow MongoDB datasources without username/password (#3149) 2021-02-23 16:54:27 +05:30
Hetu Nandu
17dd5345a8
Fix code editor theme colours on the property pane (#3168) 2021-02-23 16:25:22 +05:30
Sumit Kumar
4b09b2c379
Transform Dynamodb response for easy consumption (#3050) 
- add support to handle dnyamoDb Binary type
- transform raw response to show extracted response and raw response for:
GetItem
BatchGetItem
DeleteItem
PutItem
Scan
TransactGetItems
UpdateItem
- modify TC.
 2021-02-23 16:24:06 +05:30
Trisha Anand
139d870c17
Marking Prepared Statement in Postgres plugin as a beta feature (#3161) 2021-02-23 15:39:53 +05:30
Hetu Nandu
3a5e0b30bb
Force light theme on the whole editor except the header (#3143) 2021-02-23 15:37:13 +05:30
NandanAnantharamu
d20d013d69
Cypress test for Tab rename from entity explorer (#2780) 
* Bug automation

* Test flow completed

* Another bug automation

* Updated tests

* uncommented delete tab test

* Uncommented a test

* updated tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-23 15:08:31 +05:30
Piyush
faea2f36ff
Add support for setting.json for pluginType DB (#3156) 2021-02-23 13:57:37 +05:30
Shrikant Sharat Kandula
9b58e683b5
Fix Spring deserialization routines failing at appLayout (#3155) 2021-02-23 12:32:55 +05:30
vicky-primathon.in
8b334c3064 Removed passing formatType to component as html is default output 2021-02-23 12:10:19 +05:30
Nidhi
61af306110
Added null check for OAuth2 scopes(#3153) 2021-02-23 11:10:47 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074) 
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
 2021-02-23 10:19:14 +05:30
NandanAnantharamu
725043fde3
Replace test api with mockApi in Cypress tests (#2975) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-23 09:56:02 +05:30
Shrikant Sharat Kandula
e2509ae325
Add placeholder for MongoDB datasource config's host inputs (#3145) 
* Remove example indicator
 2021-02-23 09:52:45 +05:30
Shrikant Sharat Kandula
4f6a48bf40
Fix BatchGetItem & TransactGetItems operations failing on the DynamoDB plugin (#3120) 
* Fix batch operations APIs failing with DynamoDB

* Fixed TransactGetItems operation on DynamoDB
 2021-02-23 09:51:23 +05:30
Ashok Kumar M
d1822a9dee
Feature: Modal Widget (#3092) 
* Feature: Modal Widget(DIP)

* Adding cypress tests.
 2021-02-23 09:48:23 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Shrikant Sharat Kandula
15b8e0f590
Add appLayout field to Applications (#3144) 
* Add `appLayout` field to Applications

* Fix NPE on clone
 2021-02-22 19:21:13 +05:30
Hetu Nandu
6f7ce24a2f
Fix action subtree evaluation (#3142) 2021-02-22 16:44:08 +05:30
Shrikant Sharat Kandula
276338af0a Rename the $ref field to _ref in Firestore plugin (#3135) 
(cherry picked from commit 198abbf37d)
 2021-02-22 14:40:02 +05:30
Shrikant Sharat Kandula
198abbf37d
Rename the $ref field to _ref in Firestore plugin (#3135) 2021-02-22 13:57:04 +05:30
Rishabh Saxena
1d76f391da
Fix styles for the primary logo within viewer for safari (#3133) 2021-02-22 13:32:38 +05:30
Piyush Mishra
90fba15630
Fix/datasource name conflict issue (#3134) 2021-02-22 12:57:05 +05:30
Hetu Nandu
447f458656
Minor Api pane design and logic fixes (#3091) 2021-02-22 11:45:02 +05:30
Rishabh Saxena
0dab943be2
Fix app title widths for both viewer and editor (#3094) 2021-02-22 11:02:19 +05:30
Hetu Nandu
88c86fa881
Add toast for trigger errors (#3100) 2021-02-22 10:30:16 +05:30
NandanAnantharamu
03eba7ed27
Categorise tests between client and server (#2856) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-02-22 10:18:30 +05:30
Trisha Anand
7ff80ea192
In case an action is created without plugin template being set, update doesn't set the property as well. (#3116) 2021-02-19 23:26:33 +05:30
vicky-primathon.in
c5a689b560 Added support for markdown type in RTE 2021-02-19 16:57:54 +05:30
Trisha Anand
5a2ad75d1b
Use a toggle instead of dropdown to configure Prepared Statements (#3105) 2021-02-19 16:31:18 +05:30
Rishabh Saxena
a8aa41b652
Handle false (type: string) as falsy for the switch control (internal forms) 2021-02-19 16:30:07 +05:30
Shrikant Sharat Kandula
ef732f1389 Add request body and some other details in action execution data point (#3096) 2021-02-19 15:20:20 +05:30
Shrikant Sharat Kandula
a6be22e028
Add request body and some other details in action execution data point (#3096) 
* Include request body in action execution data point

* Send analytics data point when analytics fails
 2021-02-19 14:39:40 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing. 
Fix default input type
 2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
akash-codemonk
f0be4341f3
Fix execute action error message (#3077) 2021-02-19 11:16:54 +05:30
Abhinav Jha
59f56c8052
Internal Fix: When tables are migrated, the computedValue for the columns do not have currenRow (#3066) 2021-02-19 10:21:52 +05:30
Abhinav Jha
419d724096
Internal Fix: Issue where the property panel isn't scrolled to top when opening it (#3065) 2021-02-19 10:21:01 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
dependabot[bot]
9579b91fae
Bump jackson-databind in /app/server/appsmith-plugins/restApiPlugin (#3098) 
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.4 to 2.10.5.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-19 08:24:07 +05:30
Shrikant Sharat Kandula
6eb9f399a3
Add a boolean isHidden field for pages (#3090) 
* Add a boolean `isHidden` field for pages

* Add `isHidden` when loading all pages of application
 2021-02-18 19:23:15 +05:30
Trisha Anand
e5574c1945
Support Prepared Statements in Postgres (#2967) 
* Pushing minor editor form changes to ensure that prepared statement could be turned off.

* Code refactor to do variable substitution in PluginExecutor instead of action service.

* WIP : Prepared Statement handling in psql plugin

* WIP Prepared Statements.

* Working version of prepared statements

* Quote trimming added for post preparing sql statements. Now the unprepared statements and prepared statements do not require edits.

* Fixed existing test cases failing.

* Code formatting.

* Super minor code cleanup.

* Added migration for the existing postgres actions.

* Fixed failing test cases in ActionServiceTest.

* Minor change in the text for turning on and off prepared statements in the postgres query pane.

* Added test cases for prepared statement.

* Some minor comments for code readability

* Moved Prepared Statement setting from Action Configuration to Plugin Specified Templates since this setting does not make sense for all the DB plugins.

* Added function level comments

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/SqlStringUtils.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/SqlStringUtils.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Incorporated review comments.

* Fixed compile time error.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-18 18:33:27 +05:30
imgbot[bot]
3ff938712c
[ImgBot] Optimize images (#2978) 
*Total -- 1,442.90kb -> 1,261.25kb (12.59%)

/app/client/src/assets/icons/gifs/lightmode_thumbnail.png -- 13.33kb -> 4.62kb (65.34%)
/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/images/invalid-page.png -- 3.20kb -> 2.22kb (30.49%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/images/appsmith_logo_square.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/icons/gifs/config_pagination_lightmode.gif -- 110.67kb -> 81.84kb (26.05%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/icons/gifs/config_pagination_darkmode.gif -- 101.19kb -> 80.38kb (20.57%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/icons/gifs/darkmode_thumbnail.png -- 4.87kb -> 4.34kb (10.88%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/view-less.svg -- 0.25kb -> 0.24kb (3.53%)
/app/client/src/assets/icons/ads/add-more.svg -- 0.50kb -> 0.49kb (2.53%)
/app/client/src/assets/icons/ads/play.svg -- 0.23kb -> 0.22kb (2.16%)
/app/client/src/assets/icons/ads/no-response.svg -- 3.84kb -> 3.76kb (1.88%)
/app/client/src/assets/icons/ads/close-modal.svg -- 0.28kb -> 0.27kb (1.75%)
/app/client/src/assets/icons/ads/chevron_left.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/chevron_right.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/right-arrow.svg -- 0.27kb -> 0.27kb (1.44%)
/app/client/src/assets/icons/ads/fork.svg -- 0.45kb -> 0.44kb (1.31%)
/app/client/src/assets/icons/ads/lightning.svg -- 0.22kb -> 0.22kb (1.3%)
/app/client/src/assets/icons/ads/arrow-left.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.67%)
/app/client/src/assets/icons/ads/shine.svg -- 0.72kb -> 0.71kb (0.41%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/ads/datasource.svg -- 0.87kb -> 0.87kb (0.34%)
/app/client/src/assets/icons/help/updates.svg -- 1.01kb -> 1.01kb (0.29%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-02-18 18:08:13 +05:30
Trisha Anand
b565301afe
Datasource is given permission for a public app during create/update of a public action (#3086) 
* Added test case to assert that new datasources and actions created post making an application public have the correct permissions for public execution.
 2021-02-18 18:05:07 +05:30
Sumit Kumar
2c395b8c82
Enchancements for AWS S3 plugin (#3079) 
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-02-18 17:55:01 +05:30
vicky-primathon.in
2636c70410 Handled commont property for default text input type 2021-02-18 15:56:40 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Shrikant Sharat Kandula
60a4ddb3c1 Fix NPE on plugin specified templates (#3084) 
(cherry picked from commit 2a2b55ceaf)
 2021-02-18 13:12:08 +05:30
Shrikant Sharat Kandula
128444f46c Add more information for action execution (#3060) 
* Add more information for action execution

* Add orgId and pageName to action execution data point

(cherry picked from commit 6936a40361)
 2021-02-18 13:12:08 +05:30
Shrikant Sharat Kandula
2a2b55ceaf
Fix NPE on plugin specified templates (#3084) 2021-02-18 09:10:15 +05:30
Shrikant Sharat Kandula
6936a40361
Add more information for action execution (#3060) 
* Add more information for action execution

* Add orgId and pageName to action execution data point
 2021-02-18 08:30:56 +05:30
Hetu Nandu
e1d43992b2
Fix default value reset issue (#2861) 2021-02-17 20:32:36 +05:30
prapullac
743791a95d
Manual negative test ideas for user invite flow (#2481) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-17 20:27:18 +05:30
prapullac
8cd3a981b9
Manual test ideas for datasource query (#2763) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-17 20:22:16 +05:30
akash-codemonk
5c80e2e3e2
Update the message on the widget sidebar (#3056) 2021-02-17 11:05:24 +05:30
Shrikant Sharat Kandula
c80b6b4761 Include Firestore document metadata in responses (#3063) 
(cherry picked from commit b9cb76e7e5)
 2021-02-17 10:59:36 +05:30
Pawan Kumar
503a8ae3fe
remove negative margin (#3037) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-17 10:54:56 +05:30
Shrikant Sharat Kandula
b9cb76e7e5
Include Firestore document metadata in responses (#3063) 2021-02-16 22:09:09 +05:30
Piyush Mishra
74b013d909
Encode params toggle (#3006) 
* Makes client side changes to support actionConfiguration.encodeParamsToggle setting.
* Add migration code.

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-16 20:31:35 +05:30
Nidhi
afc329fd7b
Added grant type Authorization code to OAuth2 (#2992) 
Co-authored-by: Piyush <piyush@codeitout.com>
 2021-02-16 17:58:03 +05:30
akash-codemonk
86725baf61 Update onboarding indicator animation for widget menu (#3018) 
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
 2021-02-16 17:52:15 +05:30
akash-codemonk
e604357643 Go back to application list instead of deleting app (#2981) 2021-02-16 17:52:04 +05:30
akash-codemonk
9c20ac5306 New onboarding flow (#2686) 
Co-authored-by: a <rishabh.robben@gmail.com>
 2021-02-16 17:51:46 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999) 
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816) 
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-02-16 15:59:08 +05:30
Ashok Kumar M
24c5357f9d
Fix: Shrink Entity explorer by 20% (#3005) 2021-02-16 15:56:09 +05:30
Piyush Mishra
7e84c93282
Add QUERY_DYNAMIC_INPUT_TEXT control (#2983) 2021-02-16 11:51:19 +05:30
Rishabh Saxena
2e72be0f8a
Handle quota exceeded and running low on disk space errors while saving a key in localStorage (#2947) 2021-02-16 11:47:23 +05:30
Arpit Mohan
a973d779fd
Correcting the display message for query actions based on isExecutionSuccess flag (#3045) 
Also improving the mongo error response string. Now we only send the error message instead of the entire stack trace back to the client
 2021-02-15 22:10:04 +05:30
Hetu Nandu
ebd61efcca
Show a toast when action executeOnLoad status updates (#3042) 2021-02-15 21:43:44 +05:30
Piyush Mishra
56170b0cdf
Null check in getConfigInitialValues (#3043) 2021-02-15 21:43:20 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value 
Added migrations to handle the same
 2021-02-15 17:19:33 +05:30
Abhinav Jha
342bad8909
Fix #2829 Crash when resetting form widget (#2942) 2021-02-15 11:03:30 +05:30
akash-codemonk
c7a5b8f6d5
Update onboarding indicator animation for widget menu (#3018) 
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
 2021-02-15 10:44:42 +05:30
Shrikant Sharat Kandula
3fd8db90bd
Consistent handling of signup configuration over FORM and OAUTH (#3013) 
* Fix OAuth flow throwing 500 when signup is disabled

* Check for error code to identify signup disabled error

* Add consistent handling of allowed-domains for signing up

* Check for existence of valid email before checking domain
 2021-02-12 19:48:07 +05:30
Sumit Kumar
5638997a36
change response data format for AmazonS3 Plugin (#3023) 
* change response data format.
* fix TCs
 2021-02-12 19:34:03 +05:30
Shrikant Sharat Kandula
48b8bb9de1
Fix order of roles in share modal (#3017) 2021-02-12 16:37:34 +05:30
Rishabh Saxena
051156da29
Follow the same sequence while displaying oauth options for Signup & Login (#3009) 2021-02-12 16:12:53 +05:30
Sumit Kumar
4df595417f
return url on file create and fix image/video file upload issues with amazons3 plugin (#3012) 
1. Return url on file create.
2. Fix image/video upload/download.
3. Change error msg format to directly print error msg without adding any prefix sentence.
 2021-02-12 16:01:26 +05:30
Pawan Kumar
5b23cbf6f1
fix margin/padding issue in container in publish view (#2446) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-12 10:37:03 +05:30
abhishek nayak
14d17dfad5
Update JSDependencies.tsx 
Updated 'Dependencies' to 'JS libraries you can use'
 2021-02-12 01:38:52 +05:30
Arpit Mohan
01ca53899e
Fixing the organization share Cypress test cases (#2993) 2021-02-11 23:50:49 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-11 18:24:00 +05:30
Nidhi
8823f9d407
Added client credentials grant type for OAuth2 (#2649) 
* Added client credentials grant type for OAuth2

Co-authored-by: Piyush <piyush@codeitout.com>
 2021-02-11 17:58:06 +05:30
Rishabh Saxena
1a593e1981
add default values to payload while creating a new action (#2976) 
Fix default values not sent as payload while creating a new action
 2021-02-11 17:17:21 +05:30
akash-codemonk
8aa39eae7b
Go back to application list instead of deleting app (#2981) 2021-02-11 16:55:47 +05:30
Shrikant Sharat Kandula
8440d4e4e3
Allow app-viewers to invite others as app-viewers (#2961) 
* Allow app-viewers to invite others as app-viewers

* Fix description for new permissions

* Migration for setting invite policy for app viewers
 2021-02-11 16:33:35 +05:30
Sumit Kumar
4870c0d743
enable save on missing username/password (#2979) 
1. Add encrypted logo to password.
2. Enable save on empty username / password.
 2021-02-11 14:35:10 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686) 
Co-authored-by: a <rishabh.robben@gmail.com>
 2021-02-11 12:06:07 +05:30
Pawan Kumar
234b6983e9
Fix: border-radius of modal and bug where children of modal were not resetting on close of modal. (#2963) 
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

* update border radius of modal

* reset modal children on close

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
 2021-02-11 11:55:11 +05:30
Pawan Kumar
3b28653395
update rich text editor version + add check for string in editor value (#2966) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-11 11:55:00 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Sumit Kumar
e9e30d1fa4
Enable toggle for params encoding (#2968) 
Enable toggle for params encoding
1. Add toggle param to ActionConfiguration class.
2. Add TCs to test toggle on/off/null.
 2021-02-11 11:02:29 +05:30
Ashok Kumar M
0da3421dc2
Fix Local setup changes to accommodate M1 chip Macbooks. (#2959) 
* Fix Local setup changes to accommodate M1 chip Macbooks.

* escaping quotes.

* formatting start-https.sh
 2021-02-10 16:12:01 +05:30
Sumit Kumar
2a7f7ba8c4
s3 plugin (#2735) 
1. Integrate S3 plugin.
 2021-02-10 15:26:01 +05:30
Shrikant Sharat Kandula
95d1717f57 Merge branch 'release' 2021-02-10 14:35:02 +05:30
Shrikant Sharat Kandula
ed1c926c8a
Add datasource structure support for DynamoDB (#2919) 2021-02-10 13:28:35 +05:30
Rishabh Saxena
8c72e901ee
Fix input's onSubmit action being triggered if its validation is failing (#2960) 2021-02-10 13:13:41 +05:30
Abhinav Jha
4becc50005
Fix issue where the parentRowSpace of the new widget generated from the query was incorrect. Resulting in incorrect pageSize calculations (#2944) 2021-02-10 12:34:11 +05:30
Shrikant Sharat Kandula
c5df149ba8
Add IN operator support for forms' hidden fields (#2939) 2021-02-10 11:27:21 +05:30
Pawan Kumar
c78a578247
Fix: Cannot read property 'closeModal' of null (#2911) 
* update filepicker uppy implementation

* update uppy implementation

* fix uppy implementation

* remove typo

* remove consoles

* remove unused variable

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-10 10:29:47 +05:30
Abhinav Jha
eafadb8988
Update nvmrc to match the node version in package.json (#2943) 2021-02-09 20:53:05 +05:30
Hetu Nandu
8439affd67
Update node to latest LTS version (#2931) 2021-02-09 19:14:50 +05:30
Shrikant Sharat Kandula
0861836db4
Fix bindings in Firestore plugin's where condition value (#2934) 2021-02-09 19:11:16 +05:30
abhishek nayak
785c81df23
Update messages.ts 2021-02-09 17:38:43 +05:30
Nidhi
c0e44d0cd9
Added null check for error messages (#2922) 
* Added null check for error messages

* Added a generic null check for future null pointers from other sources.
 2021-02-09 15:00:22 +05:30
Trisha Anand
af273c60d8
When fetching unpublished actions and unpublished pages, check if the undeployed version is not deleted before fetching. (#2792) 
* When fetching unpublished actions and unpublished pages, check if the undeployed version is not deleted before fetching.

* Only add unpublished page deleted at check if the view mode is false (aka edit mode)

* 1. Update action repository to fetch only non deleted actions if fetching actions in edit mode.
2. Added test cases to assert re-using of deleted page and action names.
 2021-02-09 12:57:10 +05:30
Shubhendra Singh Chauhan
ac49a5aa87
Remove true from boolean attribute (#2892) 
Added .deepsource.toml file
 2021-02-09 11:38:54 +05:30
Rishabh Saxena
36021f9aba
fix viewer tabs arrow btns on mobile (#2910) 2021-02-09 11:05:06 +05:30
Trisha Anand
078870f7c9
Communicate action execute on load changes in update layout (#2825) 
* 1. Update on load actions correctly
2. Send the changed actions with their changes as well as messages back to the client as part of the response.

* Added test case to assert that the action updates are correctly recorded in updateLayout.

* Code cleanup + added more comments for code readability

* Incorporated review comments.
 2021-02-09 10:39:08 +05:30
Shrikant Sharat Kandula
fbf6021080
Fix nested structure translation in DynamoDB (#2915) 2021-02-09 06:59:45 +05:30
Nidhi
973cd850e7
Modified documentation links for plugins (#2909) 
* Modified documentation links for plugins

* Modified documentation links for plugins
 2021-02-08 17:11:31 +05:30
Shrikant Sharat Kandula
ebcbfb0043 Merge branch 'release' 2021-02-08 16:39:47 +05:30
Piyush Mishra
0a6040c1cd
Hotfix redux-form getting destroyed (#2908) 2021-02-08 16:24:49 +05:30
NandanAnantharamu
3d43d04658
Remove unwanted step in Cypress Map widget test (#2902) 
* updated test

* removed the commented line

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-08 16:20:28 +05:30
NandanAnantharamu
1aa879d8c2
updated flaky test (#2899) 
* updated flaky test

* review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-08 15:50:03 +05:30
Shrikant Sharat Kandula
433ce89c76
Add support for handling array types in Postgres plugin (#2887) 2021-02-08 15:06:57 +05:30
Nidhi
35b3e7d84f
Switched test container ver (#2898) 2021-02-08 13:40:53 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823) 
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
 2021-02-08 13:00:01 +05:30
Rishabh Saxena
a473ed23b0
fix navbar bottom border when tabs arent rendered (#2883) 2021-02-08 10:50:52 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Piyush Mishra
a2d8061aa2
Prep for a separate RestAPIDatasource (#2874) 2021-02-04 17:50:24 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Sumit Kumar
e6b77a1299
Stop logging some AppsmithPluginException to Sentry (#2351) 
1. Move package  appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
 2021-02-04 15:24:30 +05:30
Hetu Nandu
0332c15d56
Better handling of action error response (#2839) 2021-02-04 15:08:25 +05:30
Shrikant Sharat Kandula
5c9f90fd59
Fix missing user name in first organization name (#2873) 2021-02-04 14:04:24 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link 
Fix/docs link
 2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Piyush Mishra
0ca5563b83
Chronological system events for developer user (#2530) 2021-02-03 18:46:48 +05:30
NandanAnantharamu
b3a75de6d3
split the test (#2799) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-03 18:08:27 +05:30
Shrikant Sharat Kandula
779c41e0d3 Merge branch 'release' 2021-02-03 17:44:23 +05:30
Nikhil Nandagopal
db9c2d6c27 Updated doc link 2021-02-03 17:28:05 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-03 17:00:19 +05:30
Shrikant Sharat Kandula
f950a9352b
Fix datasource hostnames being saved with spaces (#2844) 2021-02-03 16:46:09 +05:30
Nikhil Nandagopal
d27865e4c9
Merge pull request #2843 from appsmithorg/fix/filepicker-name 
added file name to file picker and fixed a crash
 2021-02-03 15:10:44 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
63c028159c
Fix manage users link not visible in the share modal when triggered from the editor or viewer (#2653) 2021-02-03 14:51:49 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777) 
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-03 11:56:46 +05:30
Piyush Mishra
311fb5ad47
Fail client build if anything fails (#2820) 2021-02-03 11:02:00 +05:30
Hetu Nandu
bda90b4bf3
Wrap words in a toast message (#2832) 2021-02-03 10:43:55 +05:30
Shrikant Sharat Kandula
e9ba40f1f4
Analytics data point on action execution (#2740) 
* Add analytics data point on action execution

* Include application details in action exec data point

* Only send action execution event on cloud

* Analytics is auto-disabled on self-hosted setups

* Move event name to AnalyticsEvents enum

* Move analytics Mono to separate method

* Use a common function to enqueue analytics message

* Provide analytics properties from caller method

* Use consistent casing in event names for analytics
 2021-02-02 20:24:27 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789) 
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
 2021-02-02 20:12:49 +05:30
Rishabh Saxena
9d97645b3c
minor style fixes: page context menu background color (#2479) 2021-02-02 17:47:18 +05:30
prapullac
66eb08413c
Test Ideas for "Copy to Clipboard" (#2585) 
* Test Ideas for copy to Clipboard

* Adding test ideas for App viewer and admin flow

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-02 14:11:34 +05:30
Nidhi
01bbc03857
Fixed handling of lists in dynamodb (#2818) 2021-02-02 13:35:58 +05:30
Nidhi
c83fb70b95
Fixed ExecuteOnLoad not getting set for onPageLoad actions (#2801) 
* Piped onpageload update function

* Added tests
 2021-02-02 10:48:51 +05:30
Shrikant Sharat Kandula
98a0cd59b1
Fix reference types in arrays in Firestore (#2811) 
* Fix reference types in arrays in Firestore

* Added a whole bunch of tests for various data types
 2021-02-02 10:18:06 +05:30
Hetu Nandu
4505e41369
Migrate renamed canvas widgets to the correct name (#2782) 2021-02-01 20:03:13 +05:30
Abhinav Jha
3a9b328dcc
Fix: New widget and action name conflicts (#2778) 2021-02-01 20:02:43 +05:30
Abhinav Jha
51696b7220
Tab names can now be updated from the entity explorer (#2779) 2021-02-01 18:47:55 +05:30
Tim Dillon
91d5eb5860
Fix user email duplicated as name (#2787) 2021-02-01 14:51:44 +05:30
Shrikant Sharat Kandula
8475d71600
Fix RestAPI plugin not starting up (#2757) 
* Remove unneeded dependency exclusions
 2021-02-01 14:38:06 +05:30
Shrikant Sharat Kandula
018e1a94d6
Fix Firestore single document method for ref types (#2790) 2021-02-01 14:23:48 +05:30
Hetu Nandu
86cb8cac67
Allow for navigateTo urls to be of mailto or tel url schemes t (#2781) 2021-02-01 13:47:31 +05:30
Hetu Nandu
22afbe8971
Fix Array paths (#2775) 2021-01-29 09:59:23 -08:00
Piyush Mishra
164de6fb7e
Avoid double validation (#2687) 2021-01-29 11:34:28 +05:30
Dwayne Forde
f8974f1911
Fixes a small syntax issue with ./start-https.sh (#2767) 2021-01-29 09:55:51 +05:30
Arpit Mohan
433461a347
Merge pull request #2759 from appsmithorg/release 
Release v1.3.2
 2021-01-28 18:02:48 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
prapullac
4ccdba9e85
Adding manual test ideas for Home page and Login scenarios (#2627) 
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-01-28 14:42:22 +05:30
Piyush Mishra
c3740709d0
Do not show sections that are supposed to be hidden (#2746) 2021-01-28 14:26:29 +05:30
Rishabh Saxena
ca052e7515
minor updates for auth pages: polish UI, hide empty email error message (#2743) 2021-01-28 12:50:09 +05:30
Nidhi
c17a2ea536
Modified error displayed to user on generic bad request (#2583) 
* Modified error displayed to user on generic bad request

* Separate null check for cURL import
 2021-01-28 12:14:34 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines (#2729) 
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
 2021-01-28 12:08:44 +05:30
Rishabh Saxena
4c393f0f1f
fix: action not a plain object for widget entity name action creater (#2638) 2021-01-27 23:38:08 +05:30
Rishabh Saxena
19c4559c95
fix: datasource bound value preview in the explorer showing entire response (#2480) 2021-01-27 23:35:32 +05:30
Shrikant Sharat Kandula
b731793a88
Fix reference type fields in Firestore throwing 500 (#2718) 2021-01-27 20:38:46 +05:30
NandanAnantharamu
8358709f56
Added usecase for orgNaming convention (#2521) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-27 18:44:44 +05:30
Shrikant Sharat Kandula
350aea90c4
Revert RestAPI plugin signature timeout fix (#2748) 2021-01-27 17:24:25 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478) 
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-27 17:08:21 +05:30
Shrikant Sharat Kandula
63b7eb6e95
Fix signature in RestAPI plugin throwing timeout error (#2745) 
* Fix restapi signature throwing timeout error

* Add missing dependencies for restapi
 2021-01-27 14:55:08 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691) 
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-27 14:37:33 +05:30
Shrikant Sharat Kandula
a6d76d1672
Fix organization slug computation clashes (#2725) 
* Fix organization slug computation clashes

* Handle case where number-less slug is available
 2021-01-27 14:35:43 +05:30
Abhinav Jha
0fa245a985
Fix issue where users could undo delete long after the timeout has expired (#2741) 2021-01-27 13:51:47 +05:30
Shrikant Sharat Kandula
6bf2be65c0
Don't attempt to get structure for invalid datasources (#2730) 2021-01-27 13:44:15 +05:30
Vicky Bansal
aa71f2ae7b
Handle invalid entity ids (#2547) 2021-01-27 12:26:19 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Hetu Nandu
43322413c6
Support for navigateTo function to open in new window (#2706) 
* Support target for navigate function

* Add docs and action creator field
 2021-01-27 11:58:23 +05:30
Rishabh Saxena
aea3b3d4db
Revamping UI on the Login/Signup page (#2696) 2021-01-27 11:42:32 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
Tim Dillon
c9b3059498
Disable sort by Delete column in Members page (#2722) 2021-01-27 00:24:50 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Shrikant Sharat Kandula
42efb20d14
Remove unused cert fields for Mongo and Postgres plugins (#2723) 2021-01-26 18:44:01 +05:30
Nidhi
6515b5c91c
Fixed null endpoint issue for MySQL plugin (#2719) 2021-01-26 17:16:31 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Trisha Anand
9e0f36a6f2
Improve Server thrown Error Messages' language (#2705) 
* Improve Error Messages

* Added naming convention expansion for action name in the error

* Fixed failing test case assertion.

* Minor formatting.
 2021-01-25 18:50:32 +05:30
Trisha Anand
3776e82fb8
Scheduling of parallel tasks implementation for on-page load actions (#2667) 
* Proof of concept code which calculates the on load page actions.

* Refactored the field names introduced in Layout. Added a new field to keep a track of direct action names used in dynamic bindings in the DSL.

* Untested compute on on page load actions completed.

* Working page load actions computation.
TODO : Update the tests for correctness.

* Added fix for BFS starting from root nodes instead of arbitrary nodes.
Fixed a test case to assert for correct page load actions.

* Fixed the bug where the ids of the actions were not getting set in the layout. Also asserting the same in the test case for catching the future breaks.

* Minor refactor of function name to clear its purpose without reading the code.

* Incorporated review comments.

* Added conditional checks for unpublished action deleted and circular dependency of actions depending on each other.
 2021-01-25 16:54:45 +05:30