Commit Graph

2983 Commits

Author SHA1 Message Date
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
Piyush
462379721d
Reset widget global function (#3181) 2021-03-02 18:19:36 +05:30
Arpit Mohan
bf16b45f2b
Merge pull request #3309 from appsmithorg/release
Release v1.4.1
2021-03-02 13:41:51 +05:30
Rishabh Saxena
7204e87ea5
fix help modal overlapping with close button (#3289) 2021-03-02 11:26:02 +05:30
Rishabh Saxena
d48e00422e
Minor code cleanups (#3165) 2021-03-02 11:25:45 +05:30
Young Yoo
d61a900011
Fix #2712 - Duplicate Property For Map Widget (#3174)
After a Map Widget created, the text field in the Text Widget can bind the map properties. Inside the map properties, "Map center" and "Center" are duplicate value. The "MapCenter" is deleted for the adjustment.

Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-03-02 10:45:39 +05:30
imgbot[bot]
13b4d61b8f
[ImgBot] Optimize images (#3303)
*Total -- 114.50kb -> 96.16kb (16.02%)

/app/client/src/assets/images/no_data.png -- 103.98kb -> 85.71kb (17.58%)
/app/client/src/assets/icons/control/vertical_align_top.svg -- 0.17kb -> 0.17kb (2.3%)
/app/client/src/assets/icons/control/vertical_align_bottom.svg -- 0.18kb -> 0.17kb (1.67%)
/app/client/src/assets/icons/control/heading_1.svg -- 0.32kb -> 0.31kb (1.54%)
/app/client/src/assets/icons/control/vertical_align_center.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.12%)
/app/client/src/assets/images/secure.svg -- 1.08kb -> 1.07kb (0.91%)
/app/client/src/assets/icons/control/paragraph.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/control/delete-column.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/hide-column.svg -- 0.52kb -> 0.52kb (0.56%)
/app/client/src/assets/icons/control/heading_2.svg -- 1.08kb -> 1.08kb (0.45%)
/app/client/src/assets/icons/control/checkmark.svg -- 0.96kb -> 0.95kb (0.41%)
/app/client/src/assets/icons/control/paragraph_2.svg -- 1.49kb -> 1.49kb (0.33%)
/app/client/src/assets/icons/control/bullets.svg -- 1.52kb -> 1.52kb (0.32%)
/app/client/src/assets/icons/control/heading_3.svg -- 1.52kb -> 1.52kb (0.32%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-03-02 10:24:47 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
dependabot[bot]
d7b7cb26fa
Bump prismjs from 1.22.0 to 1.23.0 in /app/client (#3300)
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.22.0...v1.23.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-02 08:20:31 +05:30
Sumit Kumar
7d2effae18
Modify hint statement for 'import from curl' form (#3285)
- Move to hint statement out of query box and put if above it - between the label and the query box - so that user's don't confuse it as a typed in statement.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-03-01 23:28:07 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
akash-codemonk
beb6eb8241
Add validation to check if organization exists during onboarding (#3243) 2021-03-01 15:21:23 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function"
This reverts commit 54f158694f.
2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
RIshabh Saxena
2a868c89a6 Revert "Wrap text with span for resilience for DOM mutations by google translate"
This reverts commit e87ef2452e.
2021-03-01 13:25:05 +05:30
RIshabh Saxena
e87ef2452e Wrap text with span for resilience for DOM mutations by google translate 2021-03-01 13:24:36 +05:30
vicky-primathon.in
950c7b93bb Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-26 16:35:12 +05:30
Hetu Nandu
1f7fc9c0ed
Api form on submit (#3225) 2021-02-26 14:52:11 +05:30
akash-codemonk
0682a92d87
Update useEffect dependency (#3239) 2021-02-26 14:13:24 +05:30
Piyush
21a2a2bdf4
Redirect URL for oAuth Auth code flow (#3232) 2021-02-26 12:28:47 +05:30
Piyush
c38e58b3bc
Fix race between action reducer and handleQueryCreatedSaga (#3236) 2021-02-26 12:28:03 +05:30
Vicky Bansal
5e8805b40a
Feature: selectedOptionLabel and selectedOptionLabels in Dropdown widget (#3205) 2021-02-26 11:54:25 +05:30
Vicky Bansal
118467c5bb
Feature: Show/Hide Tabs in Tabs Widget (#3192)
* Added functionality to show/hide a tab from tab property pane controls

* Added isVisible property in tabs widget default value

* Passing visible tabs to component from widget. Added missing widgetId
2021-02-26 11:47:21 +05:30
akash-codemonk
05b2cd6d29
Fix renaming action goes to the action page (#3201) 2021-02-26 11:15:27 +05:30
Pawan Kumar
7185536c67
Fix: Cannot read property 'length' of undefined (#3207)
* update

* fix chart component on empty dataset

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-26 10:58:31 +05:30
akash-codemonk
7daeadd447
Fix current page not changing while switching to an action of another page (#3214) 2021-02-26 10:34:14 +05:30
NandanAnantharamu
4bed88d7e1
Added test for table data sorting (#2257)
* Added test for table data sorting

* commented tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-26 10:18:27 +05:30
hetunandu
3cc1fbfefd Merge branch 'release' 2021-02-25 22:36:20 +05:30
Hetu Nandu
a8889d6985
Capture cyclical dependency on sentry (#3226) 2021-02-25 22:29:00 +05:30
Abhinav Jha
3e7d2bb720 Merge branch 'release' of github.com:appsmithorg/appsmith 2021-02-25 21:39:02 +05:30
Abhinav Jha
a1bda002c0 Fix issue where renaming table data keys did not delete the previous key 2021-02-25 21:36:27 +05:30
Arpit Mohan
73d47413ff Merge branch 'release' 2021-02-25 20:43:04 +05:30
Hetu Nandu
ffeb297a1a
Fix dynamic path duplicate issue (#3223) 2021-02-25 20:42:29 +05:30
Arpit Mohan
4f16b23352 Merge branch 'release' 2021-02-25 19:34:22 +05:30
Hetu Nandu
c2646a8863
Use property config for trigger properties (#3217)
* Use triggerPaths and remove isDynamicTrigger argument

* Remove triggerMaps from widgets

* Fix property updates
2021-02-25 19:30:02 +05:30
Abhinav Jha
bdc2d46192
Add min max values to datepicker control (#3215) 2021-02-25 17:47:13 +05:30
Arpit Mohan
d420518cad Fixing merge conflicts 2021-02-25 17:29:49 +05:30
Hetu Nandu
4a557309ca
Fix eval error logging (#3206)
* Update app/client/src/utils/WidgetFactory.tsx
2021-02-25 17:23:06 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212)
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
2021-02-25 17:21:54 +05:30
NandanAnantharamu
21eecb1fe6
WIP : Added test for chart datapoint validation (#3176)
* Added test for chart datapoint validation

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-25 12:49:23 +05:30
Rishabh Saxena
6b13347157
Fix navigation to modal widget's children from the entity explorer (#3067) 2021-02-25 12:39:33 +05:30
Piyush
8383d79c91
Remove client side validation on save for OAuth Datasource (#3131) 2021-02-25 12:01:21 +05:30
Hetu Nandu
3944d7e43e
Sort order fix if property path gets updated via multiple start nodes (#3194) 2021-02-24 21:56:00 +05:30
Abhinav Jha
e197d13399
Fix issue when searching for certain places does not return a valid list from a google maps control (#3197) 2021-02-24 20:59:12 +05:30
akash-codemonk
7fa5e3b1af
Hide pages in publish mode (#3106) 2021-02-24 19:17:37 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186)
* Fix selected row issue in view mode

* Remove un-select feature
2021-02-24 15:59:19 +05:30
akash-codemonk
791d92af94
Add validation to check if widget exists (#3140)
* Check if widget is present incase it got deleted etc.

* Update test
2021-02-24 11:30:22 +05:30
Rishabh Saxena
c0222db163
Fix editor header popovers (#3173) 2021-02-24 10:42:12 +05:30
vicky-primathon.in
b474442ec7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-23 18:11:14 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889)
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-23 18:05:09 +05:30
Hetu Nandu
17dd5345a8
Fix code editor theme colours on the property pane (#3168) 2021-02-23 16:25:22 +05:30
Hetu Nandu
3a5e0b30bb
Force light theme on the whole editor except the header (#3143) 2021-02-23 15:37:13 +05:30
NandanAnantharamu
d20d013d69
Cypress test for Tab rename from entity explorer (#2780)
* Bug automation

* Test flow completed

* Another bug automation

* Updated tests

* uncommented delete tab test

* Uncommented a test

* updated tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 15:08:31 +05:30
Piyush
faea2f36ff
Add support for setting.json for pluginType DB (#3156) 2021-02-23 13:57:37 +05:30
vicky-primathon.in
8b334c3064 Removed passing formatType to component as html is default output 2021-02-23 12:10:19 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074)
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-02-23 10:19:14 +05:30
NandanAnantharamu
725043fde3
Replace test api with mockApi in Cypress tests (#2975)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 09:56:02 +05:30
Ashok Kumar M
d1822a9dee
Feature: Modal Widget (#3092)
* Feature: Modal Widget(DIP)

* Adding cypress tests.
2021-02-23 09:48:23 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Hetu Nandu
6f7ce24a2f
Fix action subtree evaluation (#3142) 2021-02-22 16:44:08 +05:30
Rishabh Saxena
1d76f391da
Fix styles for the primary logo within viewer for safari (#3133) 2021-02-22 13:32:38 +05:30
Piyush Mishra
90fba15630
Fix/datasource name conflict issue (#3134) 2021-02-22 12:57:05 +05:30
Hetu Nandu
447f458656
Minor Api pane design and logic fixes (#3091) 2021-02-22 11:45:02 +05:30
Rishabh Saxena
0dab943be2
Fix app title widths for both viewer and editor (#3094) 2021-02-22 11:02:19 +05:30
Hetu Nandu
88c86fa881
Add toast for trigger errors (#3100) 2021-02-22 10:30:16 +05:30
NandanAnantharamu
03eba7ed27
Categorise tests between client and server (#2856)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-22 10:18:30 +05:30
vicky-primathon.in
c5a689b560 Added support for markdown type in RTE 2021-02-19 16:57:54 +05:30
Rishabh Saxena
a8aa41b652
Handle false (type: string) as falsy for the switch control (internal forms) 2021-02-19 16:30:07 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing.
Fix default input type
2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
akash-codemonk
f0be4341f3
Fix execute action error message (#3077) 2021-02-19 11:16:54 +05:30
Abhinav Jha
59f56c8052
Internal Fix: When tables are migrated, the computedValue for the columns do not have currenRow (#3066) 2021-02-19 10:21:52 +05:30
Abhinav Jha
419d724096
Internal Fix: Issue where the property panel isn't scrolled to top when opening it (#3065) 2021-02-19 10:21:01 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
imgbot[bot]
3ff938712c
[ImgBot] Optimize images (#2978)
*Total -- 1,442.90kb -> 1,261.25kb (12.59%)

/app/client/src/assets/icons/gifs/lightmode_thumbnail.png -- 13.33kb -> 4.62kb (65.34%)
/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/images/invalid-page.png -- 3.20kb -> 2.22kb (30.49%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/images/appsmith_logo_square.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/icons/gifs/config_pagination_lightmode.gif -- 110.67kb -> 81.84kb (26.05%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/icons/gifs/config_pagination_darkmode.gif -- 101.19kb -> 80.38kb (20.57%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/icons/gifs/darkmode_thumbnail.png -- 4.87kb -> 4.34kb (10.88%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/view-less.svg -- 0.25kb -> 0.24kb (3.53%)
/app/client/src/assets/icons/ads/add-more.svg -- 0.50kb -> 0.49kb (2.53%)
/app/client/src/assets/icons/ads/play.svg -- 0.23kb -> 0.22kb (2.16%)
/app/client/src/assets/icons/ads/no-response.svg -- 3.84kb -> 3.76kb (1.88%)
/app/client/src/assets/icons/ads/close-modal.svg -- 0.28kb -> 0.27kb (1.75%)
/app/client/src/assets/icons/ads/chevron_left.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/chevron_right.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/right-arrow.svg -- 0.27kb -> 0.27kb (1.44%)
/app/client/src/assets/icons/ads/fork.svg -- 0.45kb -> 0.44kb (1.31%)
/app/client/src/assets/icons/ads/lightning.svg -- 0.22kb -> 0.22kb (1.3%)
/app/client/src/assets/icons/ads/arrow-left.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.67%)
/app/client/src/assets/icons/ads/shine.svg -- 0.72kb -> 0.71kb (0.41%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/ads/datasource.svg -- 0.87kb -> 0.87kb (0.34%)
/app/client/src/assets/icons/help/updates.svg -- 1.01kb -> 1.01kb (0.29%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-02-18 18:08:13 +05:30
vicky-primathon.in
2636c70410 Handled commont property for default text input type 2021-02-18 15:56:40 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Hetu Nandu
e1d43992b2
Fix default value reset issue (#2861) 2021-02-17 20:32:36 +05:30
prapullac
743791a95d
Manual negative test ideas for user invite flow (#2481)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-17 20:27:18 +05:30
prapullac
8cd3a981b9
Manual test ideas for datasource query (#2763)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-17 20:22:16 +05:30
akash-codemonk
5c80e2e3e2
Update the message on the widget sidebar (#3056) 2021-02-17 11:05:24 +05:30
Pawan Kumar
503a8ae3fe
remove negative margin (#3037)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-17 10:54:56 +05:30
Piyush Mishra
74b013d909
Encode params toggle (#3006)
* Makes client side changes to support actionConfiguration.encodeParamsToggle setting.
* Add migration code.

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-16 20:31:35 +05:30
Nidhi
afc329fd7b
Added grant type Authorization code to OAuth2 (#2992)
Co-authored-by: Piyush <piyush@codeitout.com>
2021-02-16 17:58:03 +05:30
akash-codemonk
86725baf61 Update onboarding indicator animation for widget menu (#3018)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2021-02-16 17:52:15 +05:30
akash-codemonk
e604357643 Go back to application list instead of deleting app (#2981) 2021-02-16 17:52:04 +05:30
akash-codemonk
9c20ac5306 New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-16 17:51:46 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999)
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
Ashok Kumar M
24c5357f9d
Fix: Shrink Entity explorer by 20% (#3005) 2021-02-16 15:56:09 +05:30
Piyush Mishra
7e84c93282
Add QUERY_DYNAMIC_INPUT_TEXT control (#2983) 2021-02-16 11:51:19 +05:30
Rishabh Saxena
2e72be0f8a
Handle quota exceeded and running low on disk space errors while saving a key in localStorage (#2947) 2021-02-16 11:47:23 +05:30
Arpit Mohan
a973d779fd
Correcting the display message for query actions based on isExecutionSuccess flag (#3045)
Also improving the mongo error response string. Now we only send the error message instead of the entire stack trace back to the client
2021-02-15 22:10:04 +05:30
Hetu Nandu
ebd61efcca
Show a toast when action executeOnLoad status updates (#3042) 2021-02-15 21:43:44 +05:30
Piyush Mishra
56170b0cdf
Null check in getConfigInitialValues (#3043) 2021-02-15 21:43:20 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value
Added migrations to handle the same
2021-02-15 17:19:33 +05:30
Abhinav Jha
342bad8909
Fix #2829 Crash when resetting form widget (#2942) 2021-02-15 11:03:30 +05:30
akash-codemonk
c7a5b8f6d5
Update onboarding indicator animation for widget menu (#3018)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2021-02-15 10:44:42 +05:30
Rishabh Saxena
051156da29
Follow the same sequence while displaying oauth options for Signup & Login (#3009) 2021-02-12 16:12:53 +05:30
Pawan Kumar
5b23cbf6f1
fix margin/padding issue in container in publish view (#2446)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-12 10:37:03 +05:30
abhishek nayak
14d17dfad5
Update JSDependencies.tsx
Updated 'Dependencies' to 'JS libraries you can use'
2021-02-12 01:38:52 +05:30
Arpit Mohan
01ca53899e
Fixing the organization share Cypress test cases (#2993) 2021-02-11 23:50:49 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 18:24:00 +05:30
Nidhi
8823f9d407
Added client credentials grant type for OAuth2 (#2649)
* Added client credentials grant type for OAuth2

Co-authored-by: Piyush <piyush@codeitout.com>
2021-02-11 17:58:06 +05:30
Rishabh Saxena
1a593e1981
add default values to payload while creating a new action (#2976)
Fix default values not sent as payload while creating a new action
2021-02-11 17:17:21 +05:30
akash-codemonk
8aa39eae7b
Go back to application list instead of deleting app (#2981) 2021-02-11 16:55:47 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-11 12:06:07 +05:30
Pawan Kumar
234b6983e9
Fix: border-radius of modal and bug where children of modal were not resetting on close of modal. (#2963)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

* update border radius of modal

* reset modal children on close

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-11 11:55:11 +05:30
Pawan Kumar
3b28653395
update rich text editor version + add check for string in editor value (#2966)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 11:55:00 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Ashok Kumar M
0da3421dc2
Fix Local setup changes to accommodate M1 chip Macbooks. (#2959)
* Fix Local setup changes to accommodate M1 chip Macbooks.

* escaping quotes.

* formatting start-https.sh
2021-02-10 16:12:01 +05:30
Rishabh Saxena
8c72e901ee
Fix input's onSubmit action being triggered if its validation is failing (#2960) 2021-02-10 13:13:41 +05:30
Abhinav Jha
4becc50005
Fix issue where the parentRowSpace of the new widget generated from the query was incorrect. Resulting in incorrect pageSize calculations (#2944) 2021-02-10 12:34:11 +05:30
Shrikant Sharat Kandula
c5df149ba8
Add IN operator support for forms' hidden fields (#2939) 2021-02-10 11:27:21 +05:30
Pawan Kumar
c78a578247
Fix: Cannot read property 'closeModal' of null (#2911)
* update filepicker uppy implementation

* update uppy implementation

* fix uppy implementation

* remove typo

* remove consoles

* remove unused variable

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-10 10:29:47 +05:30
Abhinav Jha
eafadb8988
Update nvmrc to match the node version in package.json (#2943) 2021-02-09 20:53:05 +05:30
Hetu Nandu
8439affd67
Update node to latest LTS version (#2931) 2021-02-09 19:14:50 +05:30
abhishek nayak
785c81df23
Update messages.ts 2021-02-09 17:38:43 +05:30
Shubhendra Singh Chauhan
ac49a5aa87
Remove true from boolean attribute (#2892)
Added .deepsource.toml file
2021-02-09 11:38:54 +05:30
Rishabh Saxena
36021f9aba
fix viewer tabs arrow btns on mobile (#2910) 2021-02-09 11:05:06 +05:30
Piyush Mishra
0a6040c1cd
Hotfix redux-form getting destroyed (#2908) 2021-02-08 16:24:49 +05:30
NandanAnantharamu
3d43d04658
Remove unwanted step in Cypress Map widget test (#2902)
* updated test

* removed the commented line

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-08 16:20:28 +05:30
NandanAnantharamu
1aa879d8c2
updated flaky test (#2899)
* updated flaky test

* review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-08 15:50:03 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-08 13:00:01 +05:30
Rishabh Saxena
a473ed23b0
fix navbar bottom border when tabs arent rendered (#2883) 2021-02-08 10:50:52 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Piyush Mishra
a2d8061aa2
Prep for a separate RestAPIDatasource (#2874) 2021-02-04 17:50:24 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Sumit Kumar
e6b77a1299
Stop logging some AppsmithPluginException to Sentry (#2351)
1. Move package  appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
2021-02-04 15:24:30 +05:30
Hetu Nandu
0332c15d56
Better handling of action error response (#2839) 2021-02-04 15:08:25 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link
Fix/docs link
2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Piyush Mishra
0ca5563b83
Chronological system events for developer user (#2530) 2021-02-03 18:46:48 +05:30
NandanAnantharamu
b3a75de6d3
split the test (#2799)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 18:08:27 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-03 17:00:19 +05:30
Nikhil Nandagopal
d27865e4c9
Merge pull request #2843 from appsmithorg/fix/filepicker-name
added file name to file picker and fixed a crash
2021-02-03 15:10:44 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
63c028159c
Fix manage users link not visible in the share modal when triggered from the editor or viewer (#2653) 2021-02-03 14:51:49 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777)
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 11:56:46 +05:30
Piyush Mishra
311fb5ad47
Fail client build if anything fails (#2820) 2021-02-03 11:02:00 +05:30
Hetu Nandu
bda90b4bf3
Wrap words in a toast message (#2832) 2021-02-03 10:43:55 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789)
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
2021-02-02 20:12:49 +05:30
Rishabh Saxena
9d97645b3c
minor style fixes: page context menu background color (#2479) 2021-02-02 17:47:18 +05:30
prapullac
66eb08413c
Test Ideas for "Copy to Clipboard" (#2585)
* Test Ideas for copy to Clipboard

* Adding test ideas for App viewer and admin flow

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-02 14:11:34 +05:30
Hetu Nandu
4505e41369
Migrate renamed canvas widgets to the correct name (#2782) 2021-02-01 20:03:13 +05:30
Abhinav Jha
3a9b328dcc
Fix: New widget and action name conflicts (#2778) 2021-02-01 20:02:43 +05:30
Abhinav Jha
51696b7220
Tab names can now be updated from the entity explorer (#2779) 2021-02-01 18:47:55 +05:30
Hetu Nandu
86cb8cac67
Allow for navigateTo urls to be of mailto or tel url schemes t (#2781) 2021-02-01 13:47:31 +05:30
Hetu Nandu
22afbe8971
Fix Array paths (#2775) 2021-01-29 09:59:23 -08:00
Piyush Mishra
164de6fb7e
Avoid double validation (#2687) 2021-01-29 11:34:28 +05:30
Dwayne Forde
f8974f1911
Fixes a small syntax issue with ./start-https.sh (#2767) 2021-01-29 09:55:51 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
prapullac
4ccdba9e85
Adding manual test ideas for Home page and Login scenarios (#2627)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-01-28 14:42:22 +05:30
Piyush Mishra
c3740709d0
Do not show sections that are supposed to be hidden (#2746) 2021-01-28 14:26:29 +05:30
Rishabh Saxena
ca052e7515
minor updates for auth pages: polish UI, hide empty email error message (#2743) 2021-01-28 12:50:09 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines (#2729)
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
2021-01-28 12:08:44 +05:30
Rishabh Saxena
4c393f0f1f
fix: action not a plain object for widget entity name action creater (#2638) 2021-01-27 23:38:08 +05:30
Rishabh Saxena
19c4559c95
fix: datasource bound value preview in the explorer showing entire response (#2480) 2021-01-27 23:35:32 +05:30
NandanAnantharamu
8358709f56
Added usecase for orgNaming convention (#2521)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 18:44:44 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478)
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-27 17:08:21 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691)
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 14:37:33 +05:30
Abhinav Jha
0fa245a985
Fix issue where users could undo delete long after the timeout has expired (#2741) 2021-01-27 13:51:47 +05:30
Vicky Bansal
aa71f2ae7b
Handle invalid entity ids (#2547) 2021-01-27 12:26:19 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Hetu Nandu
43322413c6
Support for navigateTo function to open in new window (#2706)
* Support target for navigate function

* Add docs and action creator field
2021-01-27 11:58:23 +05:30
Rishabh Saxena
aea3b3d4db
Revamping UI on the Login/Signup page (#2696) 2021-01-27 11:42:32 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
Tim Dillon
c9b3059498
Disable sort by Delete column in Members page (#2722) 2021-01-27 00:24:50 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Hetu Nandu
3f2e60dc0d
Sanitise any other possible place which could send functions (#2704) 2021-01-25 16:49:31 +05:30
Hetu Nandu
5dc01c677d
Batching widget property updates (#2685)
- Changed the updateWidgetProperty redux action to use an object of updates instead of single update
- Added the new batchUpdateWidgetProperty action
> This action will calculate dynamicPath changes for all the updates and update them together
- Added the new deleteWidgetProperty action
>This action will delete a property and any dynamicPaths/child dynamicPaths that exist
2021-01-25 14:27:26 +05:30
devrk96
3be4828d63
Fix: App name UI in edit and deploy mode (#2216) 2021-01-25 12:51:54 +05:30
Pawan Kumar
4f1fd68052
add check if widget is available in data tree (#2681)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-25 11:01:44 +05:30
NandanAnantharamu
536a222e1c
Uncommented few tests (#2695)
* Uncommented few tests

* updated dsl

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-25 10:39:16 +05:30
Rishabh Saxena
e8a01c456d
product updates modal test (#2677) 2021-01-23 13:46:50 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a309107623
Fix - Remove delete icon when there are no filters in table widget (#2605) 2021-01-22 15:17:14 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
ae276a93f8
Fix - Boolean values comparison in Table widget filters(#2586)
- Display filter label instead of value
2021-01-22 15:14:03 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
vicky-primathon
64a0a44446
Remove table row alternating colors (#2552) 2021-01-22 15:07:43 +05:30
Hetu Nandu
d4be9b9404
Remove any functions from Eval Action bindings task before returning from the worker (#2679) 2021-01-22 13:40:00 +05:30
Rishabh Saxena
5ab2e194f7
update release modal styles (#2668) 2021-01-22 11:31:41 +05:30
Rishabh Saxena
57f6219d75
update styles for new updates count (#2646) 2021-01-22 11:04:37 +05:30
Rishabh Saxena
64a90a6767
enable immer autofreeze only in development (#2669) 2021-01-22 10:50:55 +05:30
dependabot[bot]
41690e2d61
Bump immer from 7.0.9 to 8.0.1 in /app/client (#2659)
Bumps [immer](https://github.com/immerjs/immer) from 7.0.9 to 8.0.1.
- [Release notes](https://github.com/immerjs/immer/releases)
- [Commits](https://github.com/immerjs/immer/compare/v7.0.9...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-21 19:00:44 +05:30
Pawan Kumar
f059e40484
Fix - RichTextEditor test by increasing wait time (#2666)
* remove default action function in messages file

* revert getErrorMessageFromActionType comment

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-21 16:38:18 +05:30
Arpit Mohan
8ba4db6a96 Commenting out the test for RTE because it's failing even though the widget is operating properly
The test needs to be fixed
2021-01-21 14:58:00 +05:30
Hetu Nandu
4021b210b1
Never show the redux action type in toast errors (#2635) 2021-01-21 12:12:53 +05:30
Rishabh Saxena
628ac6953f
Scroll to created org (#2477) 2021-01-21 11:49:06 +05:30
hetunandu
7f713b3def uncomment RTE tests 2021-01-20 16:53:58 +05:30
hetunandu
a478fcb149 Temporary comment RTE tests 2021-01-20 16:48:02 +05:30
Rishabh Saxena
d2dfd75a0c
use editor init event intead of setup to check if initialised (#2622) 2021-01-20 11:00:53 +05:30
Shrikant Sharat Kandula
d4990683c6
Fix UI for documentation modal (#2631) 2021-01-19 22:01:35 +05:30
Rishabh Saxena
cf2e5ce9d1
fix: use popover for ads dropdown options (#2628) 2021-01-19 19:42:00 +05:30
Rishabh Saxena
20d315b527
check for empty releases (#2619) 2021-01-19 14:48:32 +05:30
Rishabh Saxena
3aa268174d
use script loader for tinymce (#2620) 2021-01-19 14:24:50 +05:30
NandanAnantharamu
4d556754e5
Fixes for Filepicker test flakiness (#2616)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-19 14:21:16 +05:30
Rishabh Saxena
8e459a0c6b
validate map center and markers (#2488) 2021-01-19 12:59:15 +05:30
Rishabh Saxena
969b6fd0d2
Product updates modal (#2453) 2021-01-19 11:47:15 +05:30
abhishek nayak
4048b81b2e
Update ChartDataControl.tsx 2021-01-18 18:47:50 +05:30
akash-codemonk
6b8e3d7dd5
Onboarding changes (#2549)
- Reduce the delay for the deploy modal to 1s.
- Separate ONBOARDING_ADD_WIDGET from ONBOARDING_ADD_WIDGET_CLICK event
- Add step metadata for skip onboarding event
- Improve the contrast for the add widget button
2021-01-15 14:49:15 +05:30
Hetu Nandu
11766c0e4a
Action onPageLoad test fix (#2581) 2021-01-15 11:08:53 +05:30
Hetu Nandu
2b8bae158c
Batch action evaluation calls (#2561) 2021-01-14 20:07:21 +05:30
Hetu Nandu
8cff9bd9b9
Avoid evaluation for unnecesarry batch success calls (#2579) 2021-01-14 16:45:25 +05:30
NandanAnantharamu
9f2fbf13c8
Cypress upgrade to 6.2.1 (#2535)
* Cypress upgrade to 6.2.1

* Replaced route and server and assertions

* Removed intercept as it involves changes with alias

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-14 11:14:07 +05:30
NandanAnantharamu
d1d70b8b5c
Updated mongodatasource tests (#2567)
* Updated mongodatasource tests

* Commented assertion for test datasource and updated query test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-13 21:34:23 +05:30
Hetu Nandu
5310908cea
Handle action failure of on page load actions (#2554) 2021-01-13 17:17:41 +05:30
Hetu Nandu
42aa83a729
Selectively add paths to dependency map and evaluation order (#2537) 2021-01-13 16:22:03 +05:30
Hetu Nandu
c184fd3d3c
Remove deleted paths from evaluation order (#2517) 2021-01-13 16:21:46 +05:30
Arpit Mohan
36a47631ba Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-01-13 15:41:52 +05:30
Arpit Mohan
5860b1b2ab Adding the init dump SQL file for PostgreSQL database
This is used when running the Cypress tests
2021-01-13 15:41:39 +05:30
Hetu Nandu
d3e517ecb2
Fix for tabs widget getting the same name (#2538)
Co-authored-by: Piyush <piyush@codeitout.com>
2021-01-13 15:40:28 +05:30
Arpit Mohan
2135a4a0e8 Dummy commit to trigger the build 2021-01-13 13:39:24 +05:30
Rishabh Saxena
a2528286a3
bump blueprint core to 3.36 for using async control prop (#2491) 2021-01-13 10:53:16 +05:30
Shrikant Sharat Kandula
c6c128270c
Include version information when building Docker images for server and client (#2200)
* Include version information in backend builds

* Enable manual trigger of server workflow

* Add a dummy input field for manual trigger

* Fix secret checking in github actions

* Disable cron scheduling of sync job

* Build docker image on pushing a version tag

* Fix duplicated id and invalid id in release workflow

* Don't try to login to Docker

* Avoid download progress outputs from Maven

* Add version information for building client

* Calculate version number only once

* Enable push to DockerHub after building images

* Use Docker username from GitHub secrets

* Fix Docker username in tags when building image

* Use different secret for org name

* Minor refactoring in server workflow

* Update client build workflow to use version

* Enable manual triggering of client workflow

* Set snapshot version for server builds

* Push to docker for all branches (temp)

* Undo temp change to push all branches to DockerHub

* Use Docker org from secrets in client.yml

* Fix missing version reference in client.yml

* Remove debug command in dockerfile

* Save release notes in a resource file in Docker image

* Fix query serialization to get release notes

* Get releases of current repo instead of hard-coded repo

* Fix variable quoting for repo variables

* Exclude draft and prerelease nodes from image

* Fix call to any in release notes processor

* Fix syntax error in release notes script

* Implement API to get new release count and info

* Add missing ReleaseNotes component

* Have the release workflow run after a release is created

* Build server after generating release notes

* Change release trigger to "released"

* Change release trigger to "published"

* Change release trigger to released, edited and deleted

* Use JS script to get release notes, take 1

* Filter drafts and prereleases in script

* Fix syntax error in ES6

* Write release notes to file

* Create parent directory before writing release notes

* Log cwd in release notes script

* Log pwd along with release-notes content

* Handle case where working directory is incorrect

* Remove shell based release notes generator

* Don't show error when Sentry config is missing

* Check for sentry auth token to enable Sentry

* Carry build's exit code over to CI

* Mark out build result and add a note about it

* Add a small test to verify new versions computation

* Remove incorrect test assertion

* Remove generation of release notes file

* Connect to cloud services to fetch release notes data

* Fix missing runner for test class

* Handle missing cloud_services base URL

* Fix test failures due to missing mocks

* Enable sync-ee cron job

* Revert build.sh as there's no real change

* Add API to update release notes viewed version for users

* Fix prettier line-length errors

* Create UserData model for info unrelated to auth

* Fix field name calls

* Ensure we have a userId before setting userData

* Add tests for setting version number in UserData

* Include instanceId when fetching release notes
2021-01-12 18:15:15 +05:30
Hetu Nandu
f53af44316
Make first eval after page change happen with new layout first (#2516) 2021-01-12 14:34:34 +05:30
Hetu Nandu
94cae231c1
Make sure Table selected row is not set to undefined on mount (#2518) 2021-01-12 11:45:08 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Trisha Anand
6704e05ad0
Sub tree fixes for issues found on Jarvis (#2482) 2021-01-11 13:26:17 +05:30
Rishabh Saxena
c36b6b640f
auto focus create org input field (#2493) 2021-01-11 11:14:54 +05:30
Pawan Kumar
fcac402789
Fix - 502 in save layout is abruptly taking me to an error screen (#2475)
* remove crash:true in api + add error icon on page save

* remove crash true in api

* add crash on user init request fail

* dispatch safe crash action on user init call error

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-11 10:58:10 +05:30
akash-codemonk
d82d8965e4
Onboarding deploy tooltip fix (#2490) 2021-01-11 09:46:59 +05:30
Nikhil Nandagopal
4666f40a21
Merge pull request #2489 from appsmithorg/fix/analytics
added appmode analytics to the execute action
2021-01-08 14:53:04 +05:30
NandanAnantharamu
06ecc106d6
Using Cypress wait instead of postExecute for Table binding test (#2249)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-08 14:11:23 +05:30
Nikhil Nandagopal
a435133bdf added appmode analytics to the execute action 2021-01-08 13:06:22 +05:30
akash-codemonk
bad63f9e68
Onboarding fixes (#2458) 2021-01-08 11:36:09 +05:30
imgbot[bot]
ec115967f5
[ImgBot] Optimize images (#2384)
*Total -- 1,492.69kb -> 1,218.88kb (18.34%)

/static/form.png -- 651.09kb -> 517.01kb (20.59%)
/static/editor.png -- 694.01kb -> 555.61kb (19.94%)
/static/appsmith_logo_white.png -- 4.91kb -> 4.31kb (12.23%)
/app/client/src/assets/icons/ads/app-icons/bar-graph.svg -- 0.54kb -> 0.51kb (4.18%)
/app/client/src/assets/icons/ads/app-icons/team.svg -- 1.03kb -> 1.00kb (3.12%)
/app/client/src/assets/icons/ads/app-icons/line-chart.svg -- 0.88kb -> 0.86kb (2.77%)
/app/client/src/assets/icons/ads/app-icons/email.svg -- 0.25kb -> 0.24kb (2.73%)
/app/client/src/assets/icons/ads/app-icons/single-person.svg -- 0.69kb -> 0.68kb (1.97%)
/app/client/src/assets/icons/ads/app-icons/airplane.svg -- 1.18kb -> 1.16kb (1.82%)
/app/client/src/assets/icons/ads/app-icons/family.svg -- 1.52kb -> 1.49kb (1.8%)
/app/client/src/assets/icons/ads/app-icons/hospital.svg -- 0.41kb -> 0.41kb (1.65%)
/app/client/src/assets/icons/ads/app-icons/pants.svg -- 0.45kb -> 0.44kb (1.52%)
/app/client/src/assets/icons/ads/app-icons/call.svg -- 0.67kb -> 0.66kb (1.46%)
/app/client/src/assets/icons/ads/app-icons/lotus.svg -- 1.35kb -> 1.33kb (1.3%)
/app/client/src/assets/icons/ads/app-icons/lightning.svg -- 0.78kb -> 0.77kb (1.25%)
/app/client/src/assets/icons/ads/app-icons/hat.svg -- 0.55kb -> 0.54kb (1.24%)
/app/client/src/assets/icons/ads/app-icons/couples.svg -- 1.50kb -> 1.48kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/mug.svg -- 0.56kb -> 0.55kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/sunflower.svg -- 1.15kb -> 1.13kb (1.19%)
/app/client/src/assets/icons/ads/app-icons/website.svg -- 1.83kb -> 1.81kb (1.12%)
/app/client/src/assets/icons/ads/app-icons/diamond.svg -- 0.63kb -> 0.62kb (1.09%)
/app/client/src/assets/icons/ads/app-icons/money.svg -- 1.18kb -> 1.17kb (1.07%)
/app/client/src/assets/icons/ads/app-icons/headphones.svg -- 0.84kb -> 0.83kb (1.04%)
/app/client/src/assets/icons/ads/app-icons/bus.svg -- 2.09kb -> 2.07kb (1.03%)
/app/client/src/assets/icons/ads/app-icons/pie-chart.svg -- 0.96kb -> 0.95kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/shirt.svg -- 0.67kb -> 0.67kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/smartphone.svg -- 0.68kb -> 0.68kb (1%)
/app/client/cypress/fixtures/appsmithlogo.png -- 1.97kb -> 1.96kb (0.99%)
/app/client/src/assets/icons/ads/app-icons/music.svg -- 0.74kb -> 0.73kb (0.93%)
/app/client/src/assets/icons/ads/app-icons/rocket.svg -- 1.55kb -> 1.54kb (0.88%)
/app/client/src/assets/icons/ads/app-icons/medical.svg -- 0.57kb -> 0.56kb (0.86%)
/app/client/src/assets/icons/ads/app-icons/plant.svg -- 1.06kb -> 1.05kb (0.83%)
/app/client/src/assets/icons/ads/app-icons/love.svg -- 0.83kb -> 0.82kb (0.82%)
/app/client/src/assets/icons/ads/app-icons/repeat.svg -- 0.76kb -> 0.75kb (0.78%)
/app/client/src/assets/icons/ads/app-icons/bird.svg -- 1.15kb -> 1.14kb (0.77%)
/app/client/src/assets/icons/ads/app-icons/car.svg -- 1.79kb -> 1.78kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/coding.svg -- 0.51kb -> 0.51kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/rose.svg -- 1.29kb -> 1.28kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/system.svg -- 1.03kb -> 1.02kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/tree.svg -- 0.95kb -> 0.94kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/card.svg -- 1.22kb -> 1.21kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/cricket.svg -- 0.96kb -> 0.95kb (0.71%)
/app/client/src/assets/icons/ads/app-icons/yen.svg -- 0.99kb -> 0.99kb (0.69%)
/app/client/src/assets/icons/ads/app-icons/location.svg -- 1.00kb -> 1.00kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/laptop.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/rupee.svg -- 1.04kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/medal.svg -- 1.05kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/shop.svg -- 1.96kb -> 1.94kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/cat.svg -- 1.60kb -> 1.59kb (0.61%)
/app/client/src/assets/icons/ads/app-icons/dog.svg -- 2.11kb -> 2.09kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/bicycle.svg -- 1.46kb -> 1.46kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/basketball.svg -- 1.52kb -> 1.51kb (0.58%)
/app/client/src/assets/icons/ads/app-icons/flag.svg -- 1.22kb -> 1.22kb (0.56%)
/app/client/src/assets/icons/ads/app-icons/euros.svg -- 1.24kb -> 1.23kb (0.55%)
/app/client/src/assets/icons/ads/app-icons/stars.svg -- 1.20kb -> 1.19kb (0.49%)
/app/client/src/assets/icons/ads/app-icons/chat.svg -- 1.49kb -> 1.49kb (0.46%)
/app/client/src/assets/icons/ads/app-icons/restaurant.svg -- 1.52kb -> 1.52kb (0.45%)
/app/client/src/assets/icons/ads/app-icons/saturn.svg -- 1.59kb -> 1.58kb (0.43%)
/app/client/src/assets/icons/ads/app-icons/moon.svg -- 1.65kb -> 1.65kb (0.41%)
/app/client/src/assets/icons/ads/app-icons/chinese-remnibi.svg -- 1.69kb -> 1.68kb (0.4%)
/app/client/src/assets/icons/ads/app-icons/burger.svg -- 2.77kb -> 2.76kb (0.39%)
/app/client/src/assets/icons/ads/app-icons/earth.svg -- 1.87kb -> 1.86kb (0.37%)
/app/client/src/assets/icons/ads/app-icons/joystick.svg -- 1.98kb -> 1.97kb (0.35%)
/app/client/src/assets/icons/ads/app-icons/steam-bowl.svg -- 2.95kb -> 2.94kb (0.33%)
/app/client/src/assets/icons/ads/app-icons/alien.svg -- 1.27kb -> 1.27kb (0.31%)
/app/client/src/assets/icons/ads/app-icons/uk-pounds.svg -- 2.33kb -> 2.32kb (0.29%)
/app/client/src/assets/icons/ads/app-icons/dollar.svg -- 2.59kb -> 2.58kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/pizza.svg -- 1.86kb -> 1.86kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/bitcoin.svg -- 2.75kb -> 2.74kb (0.25%)
/app/client/src/assets/icons/ads/app-icons/rainy-weather.svg -- 8.28kb -> 8.27kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/shake-hands.svg -- 4.62kb -> 4.61kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/football.svg -- 4.93kb -> 4.92kb (0.14%)
/app/client/src/assets/icons/ads/app-icons/snowy-weather.svg -- 8.34kb -> 8.33kb (0.12%)
/app/client/src/assets/icons/ads/app-icons/server.svg -- 9.10kb -> 9.10kb (0.08%)
/app/client/src/assets/icons/ads/app-icons/cloud.svg -- 23.21kb -> 23.20kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-01-07 11:23:35 +05:30
NandanAnantharamu
523e3ec397
flaky test updated (#2468)
* flaky test updated

* updated another flaky test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-07 10:37:17 +05:30
Hetu Nandu
cb2dd3c9da
Handle for scenarios scrollTo is not available in browser (#2456) 2021-01-07 10:36:25 +05:30
prapullac
7309e91153
Added test for Datasource associated with API (#2336)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-01-07 10:32:26 +05:30
Hetu Nandu
2943f7f782
Copy Text trigger function (#2394) 2021-01-07 10:14:30 +05:30
Pawan Kumar
6fa31e6388
Fix - Lodash import typo (#2466)
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

* fix improt typo

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 17:31:04 +05:30
Pawan Kumar
563c32d203
[Fix] - Authentication after 404 not redirecting back to the original page (#2423)
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 16:54:16 +05:30
Rishabh Saxena
affb68ee52
Fix widths for pagination test and modal confirm btns (#2445) 2021-01-06 16:39:08 +05:30
Hetu Nandu
eb1f9e7ec8
Update axios package (#2454) 2021-01-06 13:58:49 +05:30
Pawan Kumar
51076eaead
Fix: Show appropriate error message when an onPageLoad action fails (#2355)
* show action in toast error message on pageload error

* add test case

* add error body in toast

* fix test case

* fix test case

* update test case

* uncomment test case

* remove the console log

* remove unused console

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 10:55:47 +05:30
akash-codemonk
8d303d3d9f
Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-06 09:38:46 +05:30
akash-codemonk
f5e696a4f4
Hide other header elements while showing the deploy button 2021-01-06 09:38:18 +05:30
Hetu Nandu
1598899dd6
Fix invalid toast message for evaluation error (#2443)
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
2021-01-05 17:15:37 +05:30
Rishabh Saxena
2629ead4b7
fix: check for undefined error action payload (#2428) 2021-01-05 12:12:04 +05:30
akash-codemonk
69cd988c01
Fix onboarding test failure causing other tests to fail (#2417) 2021-01-04 15:52:22 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
2021-01-04 15:46:08 +05:30
NandanAnantharamu
4c5387f707
updated assertion (#2419)
* updated assertion

* review comment incoirporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-04 12:59:21 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-31 17:54:50 +05:30
Piyush Mishra
3d7242d716
Cleanup cancelled requests (#2387) 2020-12-30 18:56:44 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Rishabh Saxena
c344377a9d
only autofocus widget search (#2400) 2020-12-30 18:32:11 +05:30
Hetu Nandu
31d8c8c4eb
[Worker] Fix critical issues (#2393) 2020-12-30 18:28:57 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30
Rishabh Saxena
f1f9441cc6
auto focus search input (#2360) 2020-12-30 14:33:24 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
5ae2da1578
Send clean validated tree back (#2376) 2020-12-29 23:57:07 +05:30
Rishabh Saxena
37d0314c2a
default error code (#2363) 2020-12-29 22:22:31 +05:30
Rishabh Saxena
14effe6db1
fix del hotkey (#2349) 2020-12-29 22:21:57 +05:30
Rishabh Saxena
ccd9371820
update tooltip test (#2392) 2020-12-29 19:50:14 +05:30
Rishabh Saxena
13fae1a5c1
fix test (#2390) 2020-12-29 17:45:15 +05:30
Rishabh Saxena
e526f5cca5
minox css fixes (#2375) 2020-12-29 16:17:32 +05:30
Hetu Nandu
b5e8673921
Properly log data tree instrumentation (#2228) 2020-12-29 14:55:56 +05:30
Piyush Mishra
988ebe975b
RPC-like layer with graceful startup and shutdown around a webworker (#2252) 2020-12-28 14:12:43 +05:30
dependabot[bot]
45497ba5ac
Bump node-notifier from 8.0.0 to 8.0.1 in /app/client (#2316)
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 10:55:39 +05:30
Piyush Mishra
ebcffadca1
Prettier fixes (#2366) 2020-12-28 09:47:50 +05:30
Piyush Mishra
8ef8bfd2ac
Prettier fix. (#2353) 2020-12-24 19:01:09 +05:30
akash-codemonk
466d0cfde1
Fix explorer entity icon alignment (#1413) 2020-12-24 15:41:02 +05:30
Rishabh Saxena
83349e2996
fix modal entity not renamed through property pane when closed by clicking on the overlay (#2185) 2020-12-24 11:43:01 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
3930c4c63c
Hotfix circularJSON (#2214) 2020-12-23 19:48:46 +05:30
Rishabh Saxena
4e802d2c5a
reset query on select, don't jump to active item (#2237) 2020-12-23 17:45:14 +05:30
Rishabh Saxena
396b12b024
reorder widgets alphabetically, autofocus search input (#2325) 2020-12-23 17:02:30 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Rishabh Saxena
77801b10ff
fix undo delete tab, create copy of tabs array (#2315) 2020-12-23 16:55:52 +05:30
Rishabh Saxena
9417335176
render column submenu popover inline (#2329) 2020-12-23 16:55:25 +05:30
a
61e12235b2 Revert "reorder widget locale wise, autofocus search input"
This reverts commit 0bcc8872eb.
2020-12-23 11:08:52 +05:30
a
0bcc8872eb reorder widget locale wise, autofocus search input 2020-12-23 11:01:00 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
prapullac
91125ebc26
Manual test Ideas for home page (#2208) 2020-12-22 14:06:52 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)"
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
2020-12-22 13:02:02 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293)
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
2020-12-22 08:27:57 +05:30
Rishabh Saxena
42173e9249
fix tooltip boundary, don't show on target focus (#2250) 2020-12-21 15:22:58 +05:30
devrk96
851ae51c3a
Auto scroll to specific section on homepage when reloading with same url (#2115) 2020-12-21 14:35:58 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
Piyush Mishra
5408806bf1
Do not add objects to the DataTree (#2275)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-21 11:44:20 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-18 18:48:47 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223)
* @hetunandu for president
2020-12-17 20:13:01 +05:30
Hetu Nandu
4b3a0ca9de
Fix table text pagination test (#2253) 2020-12-17 18:52:19 +05:30
Piyush Mishra
29de447411
Upgrade fusioncharts npm package (#2241) 2020-12-17 17:43:33 +05:30
NandanAnantharamu
db89dddbad
Organization test split into 2 parts (#2247)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 14:16:54 +05:30
Hetu Nandu
4f92ea99ed
Remove functions for action evals (#2242) 2020-12-17 13:36:16 +05:30
Pawan Kumar
e63f0a9d2a
Fix: 404 error page shows server unavailable (#2195)
* mount error wise route

* remove log

* add test case

* fix wrong error page

* fix typescript error + remove unused variable

* remove 404 + 500 routes

* remove unused imports

* fix typo in test case

* remove history replace in utils

* remove unused variable

* add error codes for safe crash

* remove unused variables

* add error codes in all api rejects + update error reducer code type

* update error codes in init saga

* add selectors for error safe crash + take error logic out of app router

* remove unused variables

* remove extra line

* add header in error pag

* refactor page header on error page

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-17 12:33:59 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 11:40:50 +05:30
Piyush Mishra
0ccc80127a
move null check out (#2221) 2020-12-16 14:52:34 +05:30
Rishabh Saxena
2f152bf5b1
fix prev widget hidden when dragging new (#2211) 2020-12-16 14:51:57 +05:30
Rishabh Saxena
17ded71de3
fix actions/queries not fetched after cloning a page (#2196)
* fix actions/queries not fetched after cloning a page

* cf fix

* update type

* update test to check if api is cloned

* trigger tests
2020-12-16 14:51:31 +05:30
Ashwani Sindhu
15a00f4982
Set document title as app name (#2203) 2020-12-15 16:54:44 +05:30
Rishabh Saxena
5c905ac0d8
Update styles for date time headers in a table (#2197) 2020-12-15 16:54:15 +05:30
Hetu Nandu
df902440f5
Add xml2json and json2xml functions (#2022) 2020-12-15 14:16:33 +05:30
Pawan Kumar
1cafbca767
Fix: The search in the multi select is not showing + Multi select dropdown stops functioning if default value is undefined (#2057)
* fix dropdown input ghost width

* add fix when default option is undefined

* update test cases for dropdown undefined default value

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:51 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165)
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:30 +05:30
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Rishabh Saxena
20d15188fd
br instead of p on enter within rte (#2188) 2020-12-14 14:50:45 +05:30
Rishabh Saxena
29d87a88f0
unmount during drag (#2168) 2020-12-14 12:38:00 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-14 11:50:44 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
dependabot[bot]
17e8725a84
Bump ini from 1.3.5 to 1.3.8 in /app/client (#2176)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-13 11:10:46 +05:30
Arpit Mohan
7ae4959c29 Correcting the if clause for environment variable 2020-12-12 22:03:03 +05:30
Arpit Mohan
372774e728 Checking if the new run command works in Github Action 2020-12-12 20:48:21 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Piyush Mishra
2a05df86c7
Hotfix crash on navigate to API page after widget rename (#2134) 2020-12-11 18:04:06 +05:30
Arpit Mohan
75b3f18a92 Correcting github actions yaml.
Really need a validator for this
2020-12-11 17:41:39 +05:30
Arpit Mohan
7fbd14228d Correcting the node_modules cache for Cypress tests 2020-12-11 17:39:10 +05:30
prapullac
b27a32940e
Manual Test Ideas (#2129) 2020-12-11 17:25:54 +05:30
Arpit Mohan
51757072de Ignoring manual cypress tests during build
Also correcting the node_modules cache during yarn install
2020-12-11 17:10:05 +05:30
Arpit Mohan
b517639bd0 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-12-11 13:11:11 +05:30
Arpit Mohan
2951c609ec Correcting the APP_HOST in netlify for deploy previews 2020-12-11 13:10:55 +05:30
devrk96
7475aa643a
Fix: Org logo upload redux state (#2068) 2020-12-11 12:31:13 +05:30
Arpit Mohan
85d958c2c0
[CodeFactor] Apply automated fixes (#2131)
Co-authored-by: codefactor-io <support@codefactor.io>
2020-12-10 18:44:31 +05:30
Arpit Mohan
c1de6ce8f7 Fixing prettier errors in DynamicBindingUtils 2020-12-10 17:22:18 +05:30
Piyush Mishra
580c261e5d
copy tab data before mutating (#2084) 2020-12-10 14:21:54 +05:30
Hetu Nandu
f312320940
Remove unsafe functions from eval (#2076) 2020-12-10 14:00:49 +05:30
Pawan Kumar
5553da02e8
Fix: Page crashes on cloning the API (#2087)
* fixed the page crashig on cloning the api

* adding test cases

* comment out the drag and drop test case in input spec

* update test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-10 13:52:40 +05:30
devrk96
8ef7405421
Fix: User icon numbers on home page (#2070) 2020-12-10 13:37:48 +05:30
devrk96
2995410d27
Fixing text overflow word-break property fixed. (#2116) 2020-12-10 13:36:13 +05:30
Rishabh Saxena
d7dea9aff4
fix toast message on widget cut (#2059)
* fix toast message on widget cut

* show msg when widget not selected during cut/copy
2020-12-10 13:03:43 +05:30
Piyush Mishra
0e47c0a4c0
Fix brackets mismatch (#2019) 2020-12-10 11:48:59 +05:30
Nikhil Nandagopal
9b51bf9af2
Merge pull request #2109 from appsmithorg/fix/boolean-validation
Fix for false evaluated value showing as null
2020-12-10 11:27:52 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
NandanAnantharamu
9fb99c1145
Added tests for Table binding with Input Widget (#1955)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-12-10 10:52:19 +05:30
Hetu Nandu
74f8b51db3 Fix for false evaluated value showing as null 2020-12-09 22:25:59 +05:30
Nikhil Nandagopal
8864a1eca2
Merge pull request #2101 from appsmithorg/fix/sentry-errors
added code to prune payloads from sentry actions and reduce depth of …
2020-12-09 19:11:34 +05:30
Nikhil Nandagopal
d228f6d117 fix for undefined access to crash field 2020-12-09 18:22:36 +05:30
Nikhil Nandagopal
7d70a71d70 added code to prune payloads from sentry actions and reduce depth of actions reported 2020-12-09 14:42:12 +05:30
Nikhil Nandagopal
854d514359
Merge pull request #2094 from appsmithorg/fix/sentry-errors
Prune expensive redux actions and console logs from sentry
2020-12-09 13:06:54 +05:30
devrk96
fba79f960b
App icon and color name change issue resolved (#2089) 2020-12-09 12:36:02 +05:30
Nikhil Nandagopal
67fc762968 Merge branch 'release' into fix/sentry-errors
# Conflicts:
#	app/client/src/sagas/ErrorSagas.tsx
2020-12-09 12:34:08 +05:30
Nikhil Nandagopal
0fc5817caa added a check for errors without payloads 2020-12-09 12:32:27 +05:30
Nikhil Nandagopal
e0ac6e9850 Allowed console errors to still be logged 2020-12-09 11:59:40 +05:30
Nikhil Nandagopal
cfa020c063 pruned expensive redux actions and console logs from sentry 2020-12-09 11:50:39 +05:30
Rishabh Saxena
6a3b3c7cb8
treat false str as falsy for env vars (#2055)
* check boolean env values against  string

* refactor parseConfig

* consistent bools

* return true/false for those strings
2020-12-09 11:22:50 +05:30
Hetu Nandu
04e963c599
Fix for 502 errors from the server (#1949) 2020-12-09 00:43:48 +05:30
NandanAnantharamu
ec7149f9d8
Test case for creating multiple apps (#1871)
* Added test for #1716

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-08 23:47:34 +05:30
Pawan Kumar
f8fd19d026
fix alignment of api editor response view (#2002)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-08 14:54:36 +05:30
Pawan Kumar
c67ada9a24
Fix/updating datasources does not update sidebar (#2018)
* add check for datasources in memo equality check

* add test cases

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-08 14:54:02 +05:30
vicky-primathon
19d6ad695e
Table column max width limit removed (#2077) 2020-12-08 12:25:30 +05:30
Nikhil Nandagopal
0c1d914c38
Merge pull request #2064 from appsmithorg/fix/sentry-errors
[Fix] reduced depth of information shared via sentry to prevent 413 errors
2020-12-07 20:01:25 +05:30
Nikhil Nandagopal
03053d40c3 reduced depth of information shared to allow error sharing 2020-12-07 19:54:51 +05:30
Pawan Kumar
e4b28172a7
add ellipsis in button (#2031)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-07 12:48:53 +05:30
devrk96
6cd44a5b84
Fix: Application name update checks (#1710) 2020-12-07 12:22:49 +05:30
devrk96
b7d77e15f1
Feature: New app icons and color palette (#2026) 2020-12-07 12:21:13 +05:30
Piyush Mishra
9ec030e101
null check for errors forEach(#2030) 2020-12-07 11:15:14 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985)
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Arpit Mohan
a900b48712
Improving the text we see in the API and query settings pages (#1997) 2020-12-02 16:27:57 +05:30
vicky-primathon
6c19af7c24
Fix: Columns flicker when columns are resized or reordered (#1940)
* Fixed flickering issue on column reorder and resize

* Disable sort when resizing column to stop flicker issue
2020-12-02 16:14:56 +05:30
Pawan Kumar
066e20d0a2
Fix: Remove Fusioncharts Watermark (#1978)
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-02 16:12:51 +05:30
akash-codemonk
afa81d9eaf
Datasource form bug fixes (#1986)
* Datasource form fixes #1967 and fixes #1966
* Add tests for scenarios in #1967 and #1966
2020-12-02 16:06:35 +05:30
Piyush Mishra
1eddc0c7d1
Faster recompile with cached eslint (#1987) 2020-12-02 11:57:56 +05:30
imgbot[bot]
4fa2fd4ba6
[ImgBot] Optimize images (#1993)
*Total -- 307.73kb -> 177.70kb (42.25%)

/deploy/heroku/images/app-settings.png -- 215.56kb -> 118.43kb (45.06%)
/deploy/heroku/images/finish.png -- 33.21kb -> 19.53kb (41.19%)
/deploy/heroku/images/add-domain-form.png -- 29.12kb -> 18.04kb (38.06%)
/deploy/heroku/images/add-domain-button.png -- 29.37kb -> 21.23kb (27.71%)
/app/client/src/assets/icons/ads/upload.svg -- 0.47kb -> 0.47kb (0.62%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-12-02 11:50:10 +05:30
satbir121
8afa900044
Filepicker component and logo upload for org (#250) 2020-12-02 03:31:27 +05:30
devrk96
5d820c7203
Fix: Organization rename and toast issues (#1954)
* Toast message removed when renaming an organization
2020-12-02 03:30:29 +05:30
Hetu Nandu
29d0c49962
Wait for eval before executing the next evaluation (#1959) 2020-12-01 16:09:55 +05:30
Pawan Kumar
43f821fddc
Fix: test cases for datepicker (#1977)
* clear cache values on delete

* added test cases

* add reload in test case

* fix test cases for datepicker spec

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-01 12:10:31 +05:30
Pawan Kumar
1aea90c404
Fix: Persist of default values even after delete of widget (#1929)
* clear cache values on delete

* added test cases

* add reload in test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-01 10:56:35 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Hetu Nandu
f248304720
Using --no-cache option for jest tests 2020-11-28 10:37:10 +05:30
Piyush Mishra
b199c539be
Fix setup for local linux server (#1948) 2020-11-27 14:49:09 +05:30
Abhinav Jha
55ef8a0084
Loop sagas to respawn when they crash (#1880)
* Added Sentry logging

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-11-27 14:21:08 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865)
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-27 14:18:38 +05:30
akash-codemonk
49026d9b3c
Sava api with datasource without having to click on save datasource (#1930) 2020-11-27 11:06:16 +05:30
Nikhil Nandagopal
9c29b83d07
Fixed Action selector function arg splitting regex to include arrays and objects (#1893)
- Also added navigateTo params field
2020-11-27 10:30:53 +05:30
imgbot[bot]
f073698fcc
[ImgBot] Optimize images (#1928)
*Total -- 316.18kb -> 175.10kb (44.62%)

/deploy/aws_ami/images/system-log.png -- 136.77kb -> 73.60kb (46.19%)
/deploy/aws_ami/images/select-system-log.png -- 178.91kb -> 101.01kb (43.54%)
/app/client/src/assets/icons/ads/warning.svg -- 0.49kb -> 0.49kb (0.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-11-26 18:43:05 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884)
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-26 16:51:23 +05:30
NandanAnantharamu
a64069b9f2
Added test for Tab and input widget binding (#1912)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-26 15:15:03 +05:30
NandanAnantharamu
7a73763aea
Feature/pageload usecase (#1750)
* Usecase for pageload Api and input widget

* Updated test name

* updated tests

* Updated assertion

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-25 21:40:31 +05:30
Piyush Mishra
d9e7baea45
Fix infinite loop crash on widget drag (#1916) 2020-11-25 21:32:54 +05:30
devrk96
461b662c7a
Feature: Rename organization in homepage (#1201) 2020-11-25 17:54:14 +05:30
Nikhil Nandagopal
8109b3b001
Merge pull request #1836 from vvkpd/show-number-of-records
show number of the records
2020-11-25 12:31:46 +05:30
Nikhil Nandagopal
25e9516315
Update TableHeader.tsx 2020-11-25 12:06:27 +05:30
Nikhil Nandagopal
610ea6c1f7 minor fix for user ids being sent 2020-11-24 21:10:50 +05:30
Vivek Pandey
1bdefc0094 removes show label from header 2020-11-24 20:05:34 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab
Fix selectedTab binding issue
2020-11-24 19:06:10 +05:30
Piyush Mishra
dbf947a1a6
Hotfix for mac start-https.sh script (#1891) 2020-11-24 18:58:05 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
e7c465eaae
Add support for WSL local dev (#1756)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2020-11-24 16:45:33 +05:30
Piyush Mishra
7376ada1b1
[Documentation] Use env variables in Cypress tests (#1887) 2020-11-24 16:44:38 +05:30