Commit Graph

4115 Commits

Author SHA1 Message Date
Shrikant Sharat Kandula
506dfd7563 Fix typo in RTS 2021-04-30 16:22:16 +05:30
Shrikant Sharat Kandula
0895c68f1f
Send time information in comments and threads even from RTS (#4235)
* Include time information in comments from RTS

* Fix ISO formatting missing Z suffix
2021-04-30 15:32:34 +05:30
Nikhil Nandagopal
9650dfe638
Merge pull request #4236 from appsmithorg/fix/table-data
fixed the column sizes
2021-04-30 14:55:19 +05:30
Nikhil Nandagopal
529114f57f fixed the column sizes 2021-04-30 13:49:13 +05:30
Abhinav Jha
d8c9d16575
Fix #1805 base64 encoded images (#4020)
Co-authored-by: Navdeep Singh <navdeep.er@gmail.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-04-30 12:30:13 +05:30
Nidhi
11556b0bbb
Add authorized check (#4222) 2021-04-30 11:10:20 +05:30
Somangshu Goswami
9caf953b41
Merge pull request #4128 from appsmithorg/fix/#4023-datepicker-incorrect-placeholder
[Bug-4023] : Incorrect placeholder in the datepicker widget
2021-04-29 21:21:36 +05:30
Somangshu Goswami
64961dde16
Merge pull request #4006 from appsmithorg/fix/native-scrollbars-experience
Fix-Native scrollbar UX with custom scrollbars
2021-04-29 16:27:14 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
Paul Li
aedac74d3a Merge branch 'release' into fix/#4023-datepicker-incorrect-placeholder 2021-04-29 05:54:24 -04:00
Apeksha Bhosale
82a330bebb
show invalid datasource but in different color (#4198) 2021-04-29 13:25:20 +05:30
arunvjn
5867375090
Code changes to show records count for db queries/APIs/GSheets. (#4185) 2021-04-29 11:29:38 +05:30
vicky-primathon.in
fcc4ad18f6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-29 01:42:47 +05:30
Trisha Anand
9884135cb7
NPE check when there are no mongo escaped widgets (#4200) 2021-04-28 22:27:01 +05:30
Somangshu Goswami
3c144a1fe5
Merge pull request #3962 from appsmithorg/fix/multi-select-values-reset
Fix-Multi select dropdown values does not get reset inside a form
2021-04-28 20:58:23 +05:30
Somangshu Goswami
6eec8236b6
Merge pull request #4192 from appsmithorg/fix/dropdown-default-value
Fix-Dropdown default value not trimming special characters
2021-04-28 20:52:36 +05:30
Somangshu Goswami
8e5f6ec271
Merge pull request #4045 from appsmithorg/fix/table-image-cell-align
Fix- Image alignment in table widget cells
2021-04-28 20:48:31 +05:30
Somangshu Goswami
0c5e73f9fa
Merge pull request #4065 from appsmithorg/fix/table-filter-selection-background
Removed background from selected dropdown item in table widget filters
2021-04-28 20:46:41 +05:30
Somangshu Goswami
201436b84d
Merge pull request #4187 from appsmithorg/fix/bug-1610-cropped-text-in-text-widget
BUG-1610 : Text gets cropped in the text widget even when there is go…
2021-04-28 20:08:16 +05:30
Trisha Anand
73c2b09dc4
[Bug Fix] : In case the table being renamed has mongo escaped fields, rename the table name in set keeping a track of these widgets as well (#4195) 2021-04-28 17:36:30 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Nidhi
706fd06e15
Including services and their role (#4193)
* Including services and their role

* Explicitly mention Google tokens
2021-04-28 15:07:55 +05:30
vicky-primathon.in
6d5269fa3b Added cypress test to validate default value with enter works 2021-04-28 12:43:08 +05:30
Paul Li
2e61174890 BUG-1610 : Text gets cropped in the text widget even when there is good amount of space
-- Change css line-height property into 1.2
2021-04-28 01:43:03 -04:00
Hetu Nandu
c8bce7344b
Set derived values as undefined if cyclic dependency (#4159) 2021-04-27 19:09:52 +05:30
Nikhil Nandagopal
a931c372be
Merge pull request #4179 from appsmithorg/fix/logs
[Fix] fire events locally to debug analytics
2021-04-27 18:31:47 +05:30
Nikhil Nandagopal
73cb703962 fire event locally to debug analytics 2021-04-27 18:23:08 +05:30
arunvjn
cbb619a266
Show server error message when mongo auth is invalid. (#4110) 2021-04-27 18:22:26 +05:30
Pawan Kumar
6cd9f39b7f
fix cypress test for chart-text binding (#4177)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-04-27 17:13:36 +05:30
Nikhil Nandagopal
217b55697b
Merge pull request #4089 from appsmithorg/fix/table-data
Updated the default table data to guide users to connect a datasource
2021-04-27 14:14:23 +05:30
Ashok Kumar M
8f7cc87801
Fix: Tabs widget refactor with new nested property validation (#4014)
* dip

* test cases first commit

* Adding Tabs migrator.

* fixing tests.

* bug fix.

* selected tab fix

* missed commit

* fixing bugs

* Fixing tab name bugs.

* close property pane when dragging or resizing

* migration changes.

* release rebase changes.

* adding List factory

* remove dynamic bindings on deleting tabs.

* Adding validation messages for nested properties as well

* fixing validation issue.

* tabs visibility validation.

* missed commit

* Fixing broken cypress tests.

* Fixing broken tests.
2021-04-27 12:46:54 +05:30
vicky-primathon.in
72d5ec5b64 Fix dropdown default value not trimmed before using for value selection 2021-04-27 11:29:52 +05:30
Apeksha Bhosale
0b2bd452df
Query pane size adjusted as API pane field (#4162) 2021-04-27 11:04:09 +05:30
abhishek nayak
c1bc9ed9f2
Update ContainerWidget.tsx
Updated the color field in the property pane to color picker instead of 'Input_text'
2021-04-27 05:07:11 +05:30
Kaushik Varanasi
9752631103
Bugfix: omnibar issues : fixes #3742 (#3998)
* Added reducers and sagas for cleaning up ui.pageWidgets on creating new application

* Add border and scale to omnibar helpbar on hover

* Added analytics event for omnibar fire on clicking help button

* Linked documentation buttons in API pane and DB query pane to Omnibar

* Added tests to make sure Omnibar has correct styles

* Added margin to make sure border is visible

* Added cypress tests to check that api pane documentation opens the omnibar modal

* Added tests for page widgets reducer reset widget state action

* Added cypress tests to check db documentation opens in global search modal

* remove scale transform

* update recent widgets on selecting widget from omnibar and also clear search when done

* added some documentation links for specific db queries

* added more documentation links, added analytics for omnibar open, set query on opening omnibar from navigation

* remove slicing of 1st option in recent entities, revert previous code and remove console log

* make query syntax better

* add transparent border to remove side effects

* ensure that query is empty upon opening omnibar

* add omnibar documentation helpers to constants

* remove unused files

* added omnibar open and search to readmore button in new query pane

* added analytics event, cleanup and documentation

* removed unused set queries

* Fixed failing cypress tests according to new workflow. Removed invalid comments
2021-04-26 22:15:03 +05:30
Nidhi
4d0d01950b
Error handling for unknown sheet when deleting row (#4165)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 20:50:45 +05:30
somangshu goswami
02fed75899 Merge branch 'release' into fix/table-filter-selection-background 2021-04-26 20:24:03 +05:30
Somangshu Goswami
978bec7866
Merge pull request #3987 from appsmithorg/fix/filepicker-clear-files
Fix-Selected file deletion not working in File Picker widget
2021-04-26 20:17:45 +05:30
vicky-primathon.in
c88e0724e1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-26 19:46:02 +05:30
Nikhil Nandagopal
c3ef0b1bc5 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:19:41 +05:30
Hetu Nandu
12bb6dd715
Fix datasource invalids check (#4164) 2021-04-26 19:18:13 +05:30
Nikhil Nandagopal
edac5344d2 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:00:09 +05:30
Nikhil Nandagopal
165c7cdc78 removed unused imports 2021-04-26 18:59:53 +05:30
Nikhil Nandagopal
54fd4c5832 updated action as a primary col 2021-04-26 18:16:56 +05:30
Apeksha Bhosale
be15d0d44b
Show warning when connecting to localhost (#4017) 2021-04-26 17:47:38 +05:30
Apeksha Bhosale
5dac939534
Show hint message for identical column (#4033) 2021-04-26 17:46:48 +05:30
Hetu Nandu
74a292ffda
Add better code coverage comments (#4140) 2021-04-26 16:21:52 +05:30
Pawan Kumar
d814e780ed
Fix: Update chart from array to object (#3907)
* update structure of chart data

* update chart data

* update chart data structure

* remove array like validator

* remove log

* remove log

* widget utils + update tests for chart data validations

* update utils test

* add migrations

* remove unnecessary helper function

* remove unnecessary helper function

* update validation test cases

* WIP

* WIP 2

* Remove validationConfigMap from widget and add to properties

* Update data tree validator to get validation from the correct place

* Minor reference fixes

* Fix test mocks

* fix for bad setting of nested property path

* add test for migration for chart widget function

* fix test for widget utils

* remove unused import;

* remove unsued import

* update migration version

* remove console and add check if data is array

* fix custom fusion chart + validation not working issue

* move custom fusion chart config to chart data section

* remove console and unused import

* fix test

* fix property config test

* fix dynamicbinding path list in migration

* remove old chart validation

* remove old validation test

* fix widget prop utils test

* remove array codepath for widget utils

* fix utils test

* fix utils test

* fix prettier issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 16:05:59 +05:30
Rishabh Saxena
46b67577dd
Check if localstorage is supported (#3974) 2021-04-26 14:48:39 +05:30
Nidhi
f86f6a4de9
Only consider headings till value grid size, but consider all values till this size (#4115)
* Only consider headings till value grid size, but consider all values till this size

* Switched from null to blank for consistency

* Whoops, we don't do null row objects anymore
2021-04-26 12:11:18 +05:30