Commit Graph

4348 Commits

Author SHA1 Message Date
Pawan Kumar
1c983f6c58
fix: Cannot read properties of undefined (reading 'children') (#8406)
* fix widget grouping failing issue

* fix widget grouping pasting edge case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-10-22 12:32:19 +00:00
Rishabh Saxena
8dc3fb4951
fix: don't fetch comment threads for anonymous users (#8717)
* fix: don't fetch comment threads for anonymous users

* fix: add wait to public apps test

* proper fix

* var updated

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-10-22 17:10:12 +05:30
Pawan Kumar
b9d8105949
fix: TypeError: Cannot read properties of undefined (reading 'filter') (#8598)
* fadd null check

* fix validation of checkbox group

* add jest test for checkbox default selected option validation

* fix checkbox group failing

* sort order of imports

* update default selected value validation
2021-10-22 13:26:52 +05:30
albinAppsmith
9c8cdacd0f
Hover state of incoming connection fix (#8670) 2021-10-22 10:54:32 +05:30
haojin111
4dc8da3cbb
enable edit icon (#8613) 2021-10-21 11:06:33 +05:30
balajisoundar
b2c5779234
feat: Introduce a welcome banner and a form to fill in role, useCase for new user (#8312) 2021-10-21 11:06:17 +05:30
Rishabh Saxena
7fe75ba711
chore: fetch published page after fetching actions for viewer (#8635) 2021-10-21 10:53:34 +05:30
balajisoundar
e7de8bafd5
feat: option to download config files from admin settings page (#8631) 2021-10-21 10:27:10 +05:30
akash-codemonk
6347bd9c38
fix: show tooltips for entity names in explorer (#8501) 2021-10-21 10:07:34 +05:30
akash-codemonk
5a80e9b014
fix: scroll bar shifting widget sidebar content on windows (#8524) 2021-10-20 20:05:12 +05:30
arunvjn
71b1ea0675
fix: autocomplete experience (#8539)
CodeEditor component refactor and fixes around autocomplete flicker
2021-10-20 17:51:07 +05:30
Bhavin K
4f5facbe7a
fix: Radio component keys are now unique (#8277) 2021-10-20 17:45:54 +05:30
Aanchal
e78ace8bc2
fix: Removed unused variables (#8122)
Fix: Removed unused variables
2021-10-20 18:09:50 +06:00
akash-codemonk
ea98e4e075
chore: add analytics event for debugger context menu click (#8628) 2021-10-20 17:10:29 +05:30
albinAppsmith
b1367caf1f
fix: border radius of google sheet where clause removed (#8453)
* dynamic text field bg fixed

* removed | replaced color with constant

* * border radius of google sheet where clause removed

* * Error header BG color changed

* * where field alignment fix

* fixed hover state of dynamicinputtextcontrol

* border-radius fix

* css syntax fix

Co-authored-by: rashmi rai <rashmirai@rashmis-MacBook-Pro.local>
2021-10-20 15:03:04 +05:30
Rishabh Rathod
258189cc3f
fix: git sync ui fixes (#8133) 2021-10-20 07:38:17 +00:00
haojin111
bc5643db80
fix: 8239 - fixed issue of delete action truncatedd (#8604)
* fixed issue of delete action truncatedd

* matched option width

Co-authored-by: Albin <albin@appsmith.com>
2021-10-20 11:21:25 +05:30
haojin111
7a4e96fab9
fixed issue of api action query icon (#8555)
Co-authored-by: Albin <albin@appsmith.com>
2021-10-20 11:11:29 +05:30
kyteinsky
5676d6f652
fix: Added hover state to the black-colored Launch button on Applications Page. (#8279)
* Added hover state to the black Launch button on Applications Page.
The black button didn't exhibit hover changes while the orange Edit button did
because the Button base component made the buttons darker, and the launch button
was already dark.
Custom CSS was included in Applications.tsx for hover state background-color
change.

* Fix: Added hover state to Launch button on Applications page

default: black background, white text
hover: transparent background, black text and border

* replaced harcoded colors with src/constants/Colors.tsx properties
2021-10-20 10:52:17 +05:30
Rishabh Saxena
3ba3aed30f
fix: hide entity explorer search (#8610) 2021-10-20 04:45:23 +00:00
Bhavin Ag
c45de57ab8
fix(Dropdown): remove empty dropdown in case of no options (#8357)
* fix(dropdown): add check for empty option array

* test(Dropdown): add UT for empty option

* refactor(Dropdown): show no results found message on empty data

* refactor: update empty data message
2021-10-19 08:40:07 -07:00
Apeksha Bhosale
f7fa2aefe5
fix: refactor js action name flow change (#8302)
* refactor js action name flow chnage

* PR commnets fixeed

* refactor states missing
2021-10-19 17:23:15 +05:30
Ashok Kumar M
5233887890
fix: Dynamic canvas height escaping un-wanted migrations. (#8305) 2021-10-19 16:34:32 +05:30
Pranav Kanade
23078215df
fix: unread indicator behaviour (#8290)
* fix: unread indicator behaviour

* minor fixes

* no need to deep copy the state

* removed state update of show indicator

* refactor to handle delete & insert thread cases and getting rid of unnecessary state

* removing unnecessary updates to store

* with update event if the thread is not there we'll put it in

* fetching the comments when user starts to edit the app

* updated tests

* typo fixed

* using memo to get the unread comments flag

* removed dependency from global state

* storing last updated comment thread id for each application.

* updated a few test cases
2021-10-19 15:56:56 +05:30
haojin111
8f32a6dba3
updated style of multiple dropdown as v2 (#8433) 2021-10-19 11:03:30 +05:30
haojin111
4bc370c3d8
remove 3 dot for loading sketon app card (#8435) 2021-10-19 10:52:55 +05:30
albinAppsmith
f9f2808719
* Icon alignment in debugger fiox (#8581)
* Omnibar icon bg fix
* Highlight color for input box
2021-10-19 10:32:36 +05:30
albinAppsmith
1a1e550986
icon color on hover fix (#8486) 2021-10-19 10:29:50 +05:30
Rishabh Rathod
6693c62396
hotfix: Add check to confirm variable are string (#8358) 2021-10-18 17:38:34 +00:00
Rishabh Saxena
31476092cc
chore: refactors for supporting git branches (#7695) 2021-10-18 19:33:44 +05:30
balajisoundar
8ea9e0d31c
chore: Add helper tooltips for page properties icons (#8538) 2021-10-18 15:09:04 +05:30
balajisoundar
10de149240
feat: Introduce a setting page for a super user to tinker with Appsmith env variables (#8144) 2021-10-18 13:17:55 +05:30
Rishabh Saxena
6225aca046
chore: conditionally load plausible on Appsmith cloud (#8477) 2021-10-18 11:48:27 +05:30
Rishabh Saxena
2040dceed9
fix: remove redundant env var (#8544) 2021-10-18 05:51:55 +00:00
rashmi rai
4b722449eb
fix: Fixes different form field background in forms (#8373) 2021-10-16 11:47:38 +00:00
Yyee
870dadd777
fix: Refresh current user in edit profile (#8267) 2021-10-15 11:07:27 +05:30
Favour Ohanekwu
922ab5f008
fix: close hint when certain characters are pressed (#7662)
Don't show autocomplete hint when brackets is pressed
2021-10-14 17:23:46 +01:00
Pranav Kanade
82c033c785
fix: allow api error interceptor to handle api call failure (#8513)
* letting error interceptor take care of api call failure

* minor fix
2021-10-14 18:38:24 +05:30
Favour Ohanekwu
813af16dba
fix: Show readable error in query response pane if present (#8518) 2021-10-14 16:34:43 +05:30
Aswath K
ce4b984e27
fix: unable to change button color on table widget (#8521)
* fix: unable to change button color on table widget

* Adds test for Table button color validation

* removes commented out code
2021-10-14 16:25:03 +05:30
Tolulope Adetula
da49fabfdf
fix: add column order to default Config (#8386) 2021-10-14 00:06:46 -07:00
Samyak Jain
23dbc6c6d7
chore: Removing re-declared variables (#8050) 2021-10-14 09:47:26 +05:30
Noel Daniel Aguilera
c613195c9d
fix: remove append isCommentMode=false when hitting esc key outside of comment view (#8135)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-13 21:54:23 +05:30
Paul Li
c9c529646f
feat: RTE - option to hide the toolbar (#8271)
-- Add a new widget property, isToolbarHidden
-- Add new Cypress test cases for the newly added property
2021-10-13 18:10:52 +05:30
Paul Li
d3fc8d8d1d
feat: Change color picker icon for better UX (#8352)
-- Replace no color icon with new design
2021-10-13 18:10:25 +05:30
Paul Li
a9e2eac8c3
fix: After using an app with AudioRecorder widget, Appsmith always shows the mic symbol in the tab (#8424)
-- Upgrade underlying package, react-media-recorder to the latest one
2021-10-13 18:10:04 +05:30
Rishabh Rathod
a4c3c6ca9d
fix: Remove Success GIF and Add Tick Animation (#7925)
- Decreased the delay to 3 seconds and
- Added CSS animation instead of GIF which reduces the load time.
- Added Placeholder image for the information image to show while it is loading.
2021-10-13 09:43:57 +00:00
Ashok Kumar M
4807e58267
fix: Switching back from comment mode the selection canvas doesn't work. (#8328) 2021-10-13 15:13:16 +05:30
Satish Gandham
b580e55e83
fix: Check if event.target is defined before accessing the value (#8475)
This is a patch, should see what triggered this issue.

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-10-13 11:55:04 +05:30
Nidhi
a3e63758d8
fix: Added default cs url for netlify builds (#8471) 2021-10-12 20:17:17 +05:30
Favour Ohanekwu
d10bde59e9
Add support for optional chaining and null coalescing in Linting (#8448) 2021-10-12 15:39:43 +01:00
Apeksha Bhosale
c0e945f0a3
in case if empty eval tree (#8441) 2021-10-12 15:49:10 +05:30
Aswath K
24b9da6741
fix: change Button variant types constant (#7817)
* change Button variant types constant

* Add migration

* Adds cypress test to validate default button variant

* update the ButtonVariant for MenuButton inside table widget

* Remove only from Button_spec

* fix: Binding issue with Variant in table

* fix: cypress test for default variant validation

* Add validation to IconButton inside table
2021-10-12 08:04:51 +00:00
Apeksha Bhosale
7c55a903f9
clear history from code editor (#8422) 2021-10-12 12:06:15 +05:30
Rishabh Rathod
41758bcd4d
fix: icon path fillColor issue (#8347) 2021-10-12 11:14:47 +05:30
Apeksha Bhosale
7eeba049ba
fix: js collection static values as part of best match (#8351)
* no rules for js actions

* add edit option to explorer
2021-10-11 19:22:39 +05:30
Hetu Nandu
2c3a0991f7
feat: setInterval and clearInterval support (#8158) 2021-10-11 12:55:03 +00:00
Paul Li
8bf6f1379e
feat: Audio recorder widget - permission denied state (#8223)
-- Design a new UI for permission denied status
-- Add a new recorder status for getting permission
2021-10-11 18:21:34 +05:30
Nayan
c288df157b
Show profile picture from the uploaded photo id of the user (#8402)
Sends photoId in user profile response. Shows profile picture from the uploaded photo id instead of email address.
2021-10-11 18:28:08 +06:00
Vicky Bansal
1d9f1831ba
Reset table page on filters reset (#8257)
Date column to not show invalid date when column value is empty
2021-10-11 17:51:35 +05:30
Apeksha Bhosale
5eb292aaee
fix: recent entities and incoming entity change (#8342)
* recent entities and incoming entity change

* added icon for js objects
2021-10-11 14:14:26 +05:30
Alyssa Holland
b4b038d90e
fix: 🐛 Display tooltips for scroll content label (#8134) 2021-10-11 13:08:27 +05:30
albinAppsmith
71886c3b9e
feat: Property pane dropdown overflow issues (#8236)
* * hide subtext for date picker fix
* EE clicking on entity, unfolding/folding added

* * bug fixes in action dropdown

* bug fix for cursor

* fix: 8190 background api request and welcome helper button (#8281)

* chore: Move action/js debugger tabs related logic to a common component (#8199)

* removed background of api request textbox and added hover text on "no thanks" button

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>

* fix: added scrolling in invited users more popup (#8226)

* added scrolling in invited users more popup

* always scrollbar displaying on invited users pan

* fixed issue related with 8190

* updated cursor of invited users more

* replace edit data source icon with remix icon (#8192)

* * active text color

* fix: dropdownlist props issue (#8322)

* Commented failing JS tests (#8276)

Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>

* docs: Update ServerSetup.md (#8255)

* Make port customizable from env variable (#8288)

* fix: issue with string templates (#7848)

* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests

* fixed props pass issue

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>

* * bug fixes

* * bug fix

* * test cases fix

* - test case fix

* * test fixes

* * bug fix in test case

Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-11 11:31:05 +05:30
Jen Dunlap
bd1e196139
chore: removed duplicate else-if JS-0034 (#8356)
Co-authored-by: Jen Dunlap <jen@customer.io>
2021-10-11 10:49:03 +05:30
Arpit Mohan
57bdbdc0f9
test: Fixing some cypress tests that were asserting if the message texts are correct (#8369) 2021-10-11 10:38:08 +05:30
Vaishnavi Joshi
9818001c3d
fix: updated misleading title in datasource page (#8028) 2021-10-10 09:18:20 +05:30
Bhavin K
22acbe4474
feat: updated widget meta key reset logic (#7901)
* updated widget meta key reset logic

* changes as required
2021-10-09 10:13:19 +05:30
Chiradeep-Banik
7af22b96a7
Remove Square bracket notation when using object properties (#7954)
- Replaced with dot-notations
2021-10-09 02:13:43 +05:30
Sheetal Patel
addca3fdb4
fix: if-else-statements-converted to ternary operator (#8219) 2021-10-09 02:05:24 +05:30
abhishek nayak
daeaf44fac
chore: Improve product copy by removing improper character capitalization (#7911) 2021-10-08 23:04:04 +05:30
Rafael Baldasso Audibert
7da4941571
fix: Update message to check request body (#8272) 2021-10-08 22:30:38 +05:30
Bhavin K
59af26dd8e
fix: tooltip should hide for a disabled on button widget (#8209) 2021-10-08 19:58:59 +05:30
Vicky Bansal
fdac6428b4
fix: Icon button click should not de-select row in table widget (#8197) 2021-10-08 18:00:12 +05:30
Rishabh Rathod
4fde9d63be
Fix css issue due to new DS (#8181) 2021-10-08 16:56:39 +05:30
Vinod
1bf41ed413
feat: add authentication tab in api editor (#8245)
* Remove bracket highlight on error

* add authentication section

* move string to messages.ts

* move api editor tab titles to messages.ts

* use createMessage to create strings

* navigate edit datasource to data source edit mode
2021-10-08 07:52:30 +00:00
akash-codemonk
9f2c32b9de
fix: onboarding table widget is blank after adding binding (#8285) 2021-10-08 13:22:08 +05:30
Aswath K
b02240cc34
fix: Focus lost when typing on property pane (#8318)
* fix: Focus lost when typing on property pane

* resurrect tests for Radio & CheckboxGroup
2021-10-08 13:09:31 +05:30
balajisoundar
d1efe8405e
feat: Add tooltips for icons in editor (#7711)
fixes: #6759
2021-10-08 12:35:34 +05:30
Tolulope Adetula
0b1f6da7fa
fix: column reorder on data load (#8167)
* fix: column reorder

* fix: table reorder with derived column
2021-10-08 07:43:33 +01:00
rahulramesha
86c931e365
chore: add ctrl y for windows users to redo (#7856)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

* ctrl y to redo for windows users

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-10-08 12:01:43 +05:30
NandanAnantharamu
470fab30f7
test: S3Crud test fix (#8323)
* added route for a validation

* removed calls which are not happening
2021-10-08 08:32:34 +05:30
Vinod
159e7f2062
fix: issue with string templates (#7848)
* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests
2021-10-07 12:33:15 +00:00
yatinappsmith
9ff6c804dc
Commented failing JS tests (#8276)
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
2021-10-07 16:13:01 +05:30
akash-codemonk
30c859180e
chore: Move action/js debugger tabs related logic to a common component (#8199) 2021-10-07 12:23:58 +05:30
Aswath K
b2e3f5d022
fix: make property pane control example to be one of the allowed values (#7851) 2021-10-07 11:42:18 +05:30
yatinappsmith
f900cf9765
test: JSEditor Tests (#8068)
* Added basic support for JSEditor

* Added copy and delete test cases

* Basic changes for js editor

* Basic tests

* JSEditor Binding tests
2021-10-07 07:59:16 +05:30
Favour Ohanekwu
803e5e7cc6
fix: improve dropdown component (#8183)
Improved multipart form's dropdown component
2021-10-06 20:20:35 +01:00
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
Apeksha Bhosale
b34102f685
fix: added errors to debugger (#8195)
* added errors to debugger

* comment added
2021-10-06 12:42:22 +05:30
balajisoundar
9fc8c92b02
chore: show canvas when user selects widgets tab during signposting flow (#8205) 2021-10-06 12:17:59 +05:30
balajisoundar
5db77f9b3f
chore: change welcome page usage data preferences label (#8166) 2021-10-06 11:41:25 +05:30
Samyak Jain
e772fd4ff9
fix: using let instead of var and all var declarations at top (#8026)
* using let instead of var and all var declarations at top

* fix: used let instead of var
2021-10-05 22:55:16 +05:30
Hetu Nandu
038c62aea3
fix: Bug in evaluated value for falsy value checks (#8194) 2021-10-05 20:17:30 +05:30
Hetu Nandu
94e3ffef67
feat: Linting in trigger fields (#7638) 2021-10-05 13:52:27 +00:00
NandanAnantharamu
77d1c7ccfc
test: Updated flaky test (#8198)
* Updated flaky test

* updated test

* updated test

* commenting test
2021-10-05 18:39:07 +05:30
arunvjn
f8ef495e4c
chore: Correct Appsmith spelling in messages (#8186) 2021-10-05 12:29:32 +05:30
albinAppsmith
7e4a5a0810
fix: Appsmith design system style fixes (#8182) 2021-10-05 12:03:58 +05:30
Nayan
c43854677f
fix: send list of users to others when someone leaves the page edit (#8162) 2021-10-05 01:27:53 +05:30
albinAppsmith
13b7c0431d
fix: Hardcoded version name removed (#8178) 2021-10-05 01:26:54 +05:30
Nikhil Nandagopal
98c395cec7
chore: anonymised user id for ce (#8176) 2021-10-04 23:06:31 +05:30
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30
Favour Ohanekwu
30d0fb7a6d
fix: Add window object methods and properties as invalid entity name (#7928)
Added window object property and method names to list of invalid entity names
2021-10-04 13:49:58 +01:00
Apeksha Bhosale
7665ff3c4f
fix: small fixes js editor (#8022)
* remove space below response

* changes to name editor

* removing variable as dynamic binding path list

* error message change for js object
2021-10-04 16:38:02 +05:30
Ayush Pahwa
5c3cdea47b
Preventing evaluations to be reset on page change unless it is the first load (#8153) 2021-10-04 15:32:41 +05:30
arunvjn
d67165f8bb
fix: for in null check sentry bug (#8150) 2021-10-04 15:11:25 +05:30
Ayush Pahwa
b90a00ba0f
fix: Added checks to ensure that the configs are valid before starting eval (#8019) 2021-10-04 13:39:14 +05:30
Rishabh Saxena
a69c8b7484
feat: callouts for wip features (#8080) 2021-10-04 13:31:46 +05:30
Pranav Kanade
ca4541a415
updated existing test cases to validate the import export flow with different user permissions (#8099) 2021-10-04 13:04:48 +05:30
Pranav Kanade
7298937e36
revert: back button navigation fixes (#8044)
* Revert "fixes to add proper routing around navigation between query pane, api pane and integration screen (#7782)"

This reverts commit b3d7f08d4e.

* Revert "fix: back btn navigation problems (#7692)"

This reverts commit c0f5ab3f30.
2021-10-04 12:27:26 +05:30
rashmi rai
4e7dec2738
added max width to the switch control (#7790) 2021-10-04 06:57:17 +00:00
Vinod
d9b4685192
Introduce linting to all users (#7736)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-10-04 12:11:02 +05:30
akash-codemonk
3d95598c18
fix: Fixes scenario where onboarding was trying to create an app in an organisation with view access (#8072) 2021-10-04 09:57:57 +05:30
akash-codemonk
a7fd0e16ac
fix: Fixes scenario where renaming actions was clearing debugger errors (#7993) 2021-10-04 09:57:23 +05:30
akash-codemonk
3209ad8cdf
chore: Do not show initialLocation of map widget in an error state when field is blank (#7931) 2021-10-04 09:56:52 +05:30
Hetu Nandu
79aefc4d74
hotfix: js action parsing error resolution (#8086) 2021-10-01 22:40:49 +05:30
Pranav Kanade
a1488a73f6
refactor: client side rts (#7837)
* moved constants to a proper files

* added new action constants

* updated websocket reducers and actions

* updated websocket saga to handle proper socket events

* updated initialization

* updated multi pointer arena + realtime app editors components

* minor feedback update

* updated events list by socket level

* removed e.persist

* passing socket obj rather than just id
2021-10-01 16:44:19 +00:00
Pranav Kanade
b261efc511
fix: skip bot comment when user skips comments tour (#7693)
* setup for skipping the bot comments if user skips the comments tour

* Using the onboarding status api

* removed comments

* fixed typos

* added test cases

* small fixes

* updated the tests

* minor update to a test case
2021-10-01 21:55:55 +05:30
Hetu Nandu
633db3068e
fix: Single binding sql query causing prepared statement issue (#7792) 2021-10-01 21:05:05 +05:30
Bhavin K
1e6b916ff9
added auto focus for number input (#7961) 2021-10-01 15:09:59 +00:00
Abhijeet
49182e7060
chore: Update success asset urls for generate page (#7579)
* Update asset urls

* fix: use successImageUrl for CRUD success popup

* Increase delay to switch between GIF and image

* Use ASSETS_CDN_URL instead of S3_BUCKET_URL

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2021-10-01 15:09:41 +00:00
Hetu Nandu
72f6ad8d99
fix: Cyclic dependency not resolving in JS Editor (#8003) 2021-10-01 15:09:09 +00:00
arunvjn
7acce6e802
fix: slash command auto open (#7977)
* Remove onFocus trigger for slash commands.
2021-10-01 15:08:42 +00:00
arunvjn
223bf0174f
fix: snippets ranking (#8020) 2021-10-01 15:08:26 +00:00
rashmi rai
0619e3798f
fix: missing where key in plugin specified templates (#8040) 2021-10-01 14:02:52 +00:00
Rishabh Rathod
70e6e54815
fix: Avoid sending param with no initialValue (#7647)
- Add initialValue for spreadSheetURL
- Pass only params having initialValue defined in generate CRUD
2021-09-30 11:29:09 +00:00
Tolulope Adetula
8b30fdd758
fix: wrong doc link (#7983) 2021-09-30 03:39:21 -07:00
Ayush Pahwa
6023bb10e4
fix: 7630 fixing where clause add delete row (#7968)
* Added new row addition action for form value changes

* Added comments

* Added special handling for where clause rows
2021-09-30 09:40:40 +00:00
Pranav Kanade
cf3cdced07
fix: small utility fixes for redirection to datasource and export app permissions (#7970)
* send user to auto tab in integration from property pane when they create new query

* only app admins will be able to export from inside app
2021-09-30 13:29:14 +05:30
arunvjn
964d58747a
fix: snippet usage analytics (#7946) 2021-09-30 03:31:50 +00:00
Apeksha Bhosale
1aac46a66d
don't send errors to sentry (#7906) 2021-09-29 20:11:55 +05:30
Apeksha Bhosale
222f0e04c3
sending collectionName instead id in refactor (#7930) 2021-09-29 20:10:49 +05:30
akash-codemonk
48f2c584ab
fix: Fix mismatch between errors in debugger and evaluated value popup (#7752) 2021-09-29 17:33:11 +05:30
Rishabh Rathod
570731507b
fix: Remove unneccessary scrolling (#7896) 2021-09-29 11:23:24 +05:30
Satish Gandham
c3d5b1010b
fix: Change multiselect back to supporting numbers and boolean. (#7895)
* Revert "fix: multiselect validation (#7698)"

This reverts commit 728a2559c5.

* - Convert the multiselect options value and labels to string before filtering as the values can be numbers.

* - Discourage users from using string in multiselect default value

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-28 19:38:24 +05:30
Ayush Pahwa
f8442622b3
fix: Added new row addition action for form value changes (#7682) 2021-09-28 11:36:03 +00:00
Aswath K
b4bab33d1e
fix: make the row click event trigger when table button is clicked (#7878) 2021-09-28 16:27:44 +05:30
Pranav Kanade
25035cbf88
hiding comments mode toggle for anonymous users (#7885) 2021-09-28 14:37:12 +05:30
Apeksha Bhosale
a1e5b39b49
fix: Debugger logs and errors related to js editor (#7749)
* added errors

* small change url

* messages created

* few logs for debugger

* after merge
2021-09-28 13:01:46 +05:30
balajisoundar
287f7e2de2
chore: Signposting progress should be hidden when user generates a page (#7883)
Fixes: #7660
2021-09-28 11:58:18 +05:30
Apeksha Bhosale
1b8a77044e
scroll for response tab list of functions (#7864) 2021-09-28 11:29:09 +05:30
Vinod
d1730a92f9
fix: autocomplete suggestions should be restricted in bindings (#7732)
* Remove bracket highlight on error

* hide data tree functions in non actions

* filter by entity type

* fix the autocomplete issue

* temp

* Fix case where entity type is undefined

* remove unused code

* fix failing test
2021-09-28 11:09:43 +05:30
Paul Li
31424e77b1
fix: The recorder widget does not reset when onClick actions on submit button is set to reset recorder widget (#7729)
-- Add the logic for resetting the widget
2021-09-27 23:55:53 +05:30
Bhavin K
59edccf294
fix: Image widget - file format change on download file (#7335) 2021-09-27 19:42:21 +05:30
Pranav Kanade
db02756173
fix: upgraded socket.io client package to latest stable version (#7845)
* upgraded socket io client to latest stable version

* auto update enabled

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
2021-09-27 16:59:47 +05:30
arunvjn
cb2ad8990a
Removed snippets feature flag (#7839) 2021-09-27 08:19:07 +00:00
Aswath K
d9fa049578
fix: Button variant validation (#7699)
* fix: Button variant validation

* fix: MenuVariant validation

* Add default value to buttonVariant

* Adds default value to MenuVariant
2021-09-27 12:00:04 +05:30
Tolulope Adetula
60131403b2
feat: disable parsing link (#7075)
* feat: add disableLink for text widget

* feat: add test for disable link

* fix: email parsing

* fix: test issues

* fix: failing test

* fix: failing test
2021-09-26 23:00:40 -07:00
Aswath K
20c1b56932
fix: table button migration issues (#7825) 2021-09-27 10:45:51 +05:30
arunvjn
90fda1ccae
fix: Remove snippet and doc icon from property pane (#7806) 2021-09-27 04:56:39 +00:00
rahulramesha
46f525d365
fix: modal widget issues (#7821)
* fixing modal issues

* adding cypress tests

* patch for modal Issues
2021-09-25 16:45:39 +05:30
Aswath K
8a45e1507e
feat: Add AudioWidget (#7179)
* Create initial version of AudioWidget by copying VideoWidget

* Add EventType for AUDIO

* Change default Audio URL to a podcast related to Appsmith

* Add AudioWidget icon

* Change Entity definition for AudioWidget

* Add cypress test

* Add jest test

* fix: typo
2021-09-24 21:35:53 +05:30
arunvjn
f3afa81afe
fix: copy snippet (#7769)
Fixes copy snippets and snippets execution toast messages
2021-09-24 19:19:59 +05:30
Pranav Kanade
79f613cf71
handle socket exception and log to sentry for time being. Need to test its impact on import/export (#7818) 2021-09-24 17:44:26 +05:30
Satish Gandham
941db9e99c
fix: Tweak how we show errors for required and not required inputs (#7783)
* - If a field is not required and empty, don't show error.
- If a field is required and empty, bail early and show error.

* - Remove default label from input
- Fix a issue with required validation

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-24 11:52:46 +00:00
Satish Gandham
eb2cbb383d
perf: Optimize list widget renders by memoizing part of renderChildren (#7681)
* - Optimze list widget renders by memoizing part of renderchildren

* - Fix failing tests and add more dependecnies to memo

* - Fix issue with repositioning widgets inside list.

* comment out the moving of widgets test

* Remove stray import

* Fix the failing jest test

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-24 17:00:26 +05:30
balajisoundar
8e0cf39419
chore: UI enhancements to welcome landing page (#7766)
Fixes: #7765
2021-09-24 14:47:58 +05:30
Pranav Kanade
b3d7f08d4e
fixes to add proper routing around navigation between query pane, api pane and integration screen (#7782) 2021-09-24 12:52:43 +05:30
arunvjn
7159119329
Fixed header resizing (#7787) 2021-09-24 12:43:36 +05:30
Trisha Anand
c84844e905
Fix for generating action from datasource structure (#7778) 2021-09-24 12:17:36 +05:30
Pranav Kanade
5a2ac0db69
fix: show correct dependency list for widgets even if one's name is substring of other widget (#7725)
* checking string equivalence rather than inclusion.

* reusing getEntityName function to get the abs name of the dependencies and entities

* added a test to check the fix
2021-09-24 10:23:32 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
rahulramesha
fb7143cef2
fix: chartWidget fix for "TypeError: r.palettecolors.split" (#7717)
* adding validation for fusion chart's paletteColors Attribute

* restructuring as params for TEXT type

* removing unnecessary space

* addressing review comments

* adding validations to ignore case
2021-09-23 18:12:34 +05:30
Rishabh Rathod
f0325c11c6
fix: Git sync modal minor fixes (#7760)
fix: Hide Snackbar for gitSSHKey fetch failure
Add Tooltip for copy icon
Fix config issues
2021-09-23 18:02:58 +05:30
Vicky Bansal
609cdc05e4
feat: Table selected row and action trigger UX improvement (#7310) 2021-09-23 17:16:47 +05:30
Hetu Nandu
d18d781a06
Fix issue when form crashes after copy or move of mongo query (#7750) 2021-09-23 11:35:49 +00:00
NandanAnantharamu
8e6ba37d00
test: fix/Updated common method (#7734)
* Updated common method

* updated dsl
2021-09-23 16:44:01 +05:30
Apeksha Bhosale
3f76855d59
fetching js collections parallel with actions in view mode (#7481) 2021-09-23 15:39:01 +05:30
Rishabh Rathod
90a275a502
fix: On connect Tab Switch error (#7740)
fix: On connect Tab Switch error
Add Git local config API
2021-09-23 08:47:09 +00:00
Pawan Kumar
be7e573175
fix: crashing of menu widget in list widget + "type" of undefined error (#7092)
* fix crashing of menu widget in list

* add ternary operator when calling type on widget

* remove eslint disable rule

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-09-23 13:57:28 +05:30
arunvjn
e474958d2d
fix: evaluation popper z index (#7744)
Reduce z-index to place modals above evaluations popper
2021-09-23 08:05:36 +00:00
Nidhi
688b75af22
Changes to introduce peader prefix in API key authentication type (#7742) 2021-09-23 13:20:44 +05:30
Hetu Nandu
8f84fc0f69
fix: error handling in trigger execution flow (#7671) 2021-09-23 07:21:57 +00:00
Pranav Kanade
ab450e5cb9
fix: add support for self tagging (#7715)
* removed current user filtering for getting tagging suggestions in comment input.

* using map instead of for
2021-09-23 11:03:22 +05:30
akash-codemonk
a971d49a1e
chore: Fix remaining empty fields in property pane shown in error state (#7537) 2021-09-23 10:35:59 +05:30
Rishabh Rathod
48dabf9efd
feat: Add Git push API & UI Updates (#7704)
Add Git push API & UI Updates
-  Add Global Config fetch in git connection
-  Add Success Toast Msg for commit and push API
-  Fix generate and fetch SSHKey API
-  Fix Close button UI
-  Add Tick Icon when SSH Key is copied
- Add Direct Deploy option
-  Hide Merge Tab
- Add Commit success and push success msg
- Add the Latest Deploy Preview option
2021-09-23 00:18:50 +05:30
balajisoundar
0eaabe9423
chore: Fix signposting issue where application crashing out if there is nested binding (#7731)
Fixes: #7730
2021-09-22 23:14:55 +05:30
arunvjn
3cd93e11a7
feat: snippets discoverablity (#7689) 2021-09-22 16:59:47 +00:00
Pawan Kumar
c48cdcdeb4
chore: comment out the moving widget cypress test (#7733)
* comment out the moving of widgets test

* update tests for replay spec

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-22 20:38:03 +05:30
Bhavin K
de20a2a52f
feat: add server side pagination in list widget (#7128) 2021-09-22 14:16:51 +05:30
Tolulope Adetula
728a2559c5
fix: multiselect validation (#7698)
* fix: multiselect validation

* fix: add failing scenarios for validation

* fix: test
2021-09-22 08:37:12 +01:00
Vicky Bansal
2c08417829
Fix digits after decimal in input widget (#7468) 2021-09-22 12:58:56 +05:30
Vicky Bansal
8679141c76
Fix button click issue in table widget when action configured in onClick is no action (#7523) 2021-09-22 12:58:35 +05:30
Pranav Kanade
c0f5ab3f30
fix: back btn navigation problems (#7692)
* the package name is not necessary when routing to saas action editor.

* This makes back btn truly perform go back operation.
2021-09-22 12:54:05 +05:30
ashit-rath
4144b8786c
fix: Enable dragging of widgets only when focused on (#7494)
* fix: Enable dragging of widgets only when focused on

* added test cases
2021-09-22 12:48:46 +05:30
akash-codemonk
997eb0b65b
fix: Do not show empty array as an error for tableData field (#7332) 2021-09-22 12:36:26 +05:30
Vinod
f3b281092b
fix: copy icon in evaluated popup and dot notation jshint error (#7639)
* Remove bracket highlight on error

* remove dot notation rule and change copy icon

* fix #7582
2021-09-22 07:05:02 +00:00
Nidhi
c3f4cdaa15
feat: Introducing SaaS integrations as a plugin (#7560)
* WIP client side changes

* Saas execution flow + scheduled import of remote plugins
2021-09-21 17:35:29 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
Apeksha Bhosale
386e788e28
fix: pushing and removing errors from debugger for js object (#7465)
* pushing and removing errors from debugger for js object

* added message part of messages

* changes for linting and errors showing

* added try catch for executing function

* PR comments fixed

* PR comment fixed
2021-09-21 11:32:45 +05:30
Apeksha Bhosale
ffe00cd1a2
fix: widget refactor actions fetch change (#7574)
* widget refactor actions fetch change

* Added test for binding Button with API

Co-authored-by: Apple <nandan@thinkify.io>
2021-09-21 11:32:30 +05:30
Tolulope Adetula
834507866a
fix: tabindex and a11y (#7125)
* fix: Datepicker Keypress and Focus State

* fix: Dropdown Select Focus and Tabbale
2021-09-21 06:49:13 +01:00
Satish Gandham
1423b55f55
Add array and object_array to list widget validation check (#7572)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-21 10:40:16 +05:30
Shrikant Sharat Kandula
c6c5e4fef3
ci: Add CI workflow for building fat container (#7385)
This commit changes the client test workflow into building the fat container's image, and so builds server and RTS as well, in order to achieve that.
2021-09-21 08:33:22 +05:30
rahulramesha
0b37812b56
feat: resizable modal (#7312)
* dip

* resizable modal full working commit

* resizable modal minor fixes

* code restructuring

* fix canvas small size bugs and add migration to remove modal type

* moving resize modal to modal sagas

* layoutResize and last column width

* fix warning

* setResizible if resizing

* fix incorrect import

* fixing cypress tests

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-09-20 22:36:13 +05:30
Nikhil Nandagopal
b9b5d54745
fix: Property pane updates (#7631)
* Renamed TreeSelect Widget
2021-09-20 20:48:10 +05:30
Aswath K
1cca96c032
fix: Currency input text overlap (#7477)
* Change currency input layout to flex

* fix: styles for normal input

* Increase space b/w icon and text. Add focus color

visual modifications as suggested by Momcilo

* fix: alignment for ISDCodeDropdown

* fix: background color for disabled

* change dropdown focus color as suggested by Momcilo

* remove unwanted conditional height

* makes disabled Numeric input consistent to disabled input
2021-09-20 14:20:46 +00:00
Hetu Nandu
4315e92cf7
Reset widget children by default (#7505) 2021-09-20 18:40:03 +05:30
akash-codemonk
9877fe4b05
fix: Switch to the debugger error tab when clicked on the debug button in toast (#7455) 2021-09-20 16:50:22 +05:30
Pranav Kanade
a555ed7a88
fixed the pointer for omnibar (#7629) 2021-09-20 16:24:05 +05:30
Nikhil Nandagopal
87b13eca2d
fix: Widget Property Pane Updates (#7467)
* reverted previous revert

* standardised widget sizes

* Text changes

* changed default input label style to match default text style

* more messaging tweaks

* minor fix

* Removed dot from the text

* minor fix for form widget

* fixed tests

* minor fixes
2021-09-20 16:13:44 +05:30
balajisoundar
2dddd07f92
chore: Fix unnecessary scrollbar in entity explorer during onboarding (#7613)
Fixes: #7425
2021-09-20 14:55:37 +05:30
Nayan
1296faef8e
feat: [Feature] Use photo asset id instead of email address for profile picture in comments (#7434)
* -set user photo id when adding a new comment thread

* -update user data when users remove their profile photo

* -updated photo id in comments when user changes or set a profile photo

* -remove photoid from thread, kept it in comment only

* -resized uploaded profile image

* -added test for delete profile photo

* -add test for the comment set user photo

* -check user change event handler is called in delete user photo

* -add test for checking user photo change event is triggered after upload photo

* -fixed tests due to changes

* -make profile pictures thumbnail only

* - used get photo by asset id API to show user photo in comment card
- set cache control header in get asset by id API

* - stop using email address to show user photo
2021-09-20 15:03:39 +06:00
akash-codemonk
1fef96666a
fix: Hide generate page button in integration home screen during onboarding (#7521) 2021-09-20 14:30:36 +05:30
Tolulope Adetula
3c4ef11df2
fix: radio group widget options (#7313)
* Update RadioGroupComponent.tsx

* fix: radio widget validation

* fix: add test for default param
2021-09-20 00:13:37 -07:00
Shrikant Sharat Kandula
fae8de553d
Add retries when getting page from GitBook (#7611)
GitBook API occasionally throws a 500 when trying to get a page. This makes our whole sync Lambda fail.

This commit adds a retry step, that will wait a second and retry the GitBook API, with retries capped to three, so the Lambda is a little more resilient to random 500s from GitBook API.
2021-09-20 12:34:04 +05:30
balajisoundar
4288b44f2c
chore: Invite user to org form input tab issue (#7603)
Fixes: #6785
2021-09-20 12:19:50 +05:30
balajisoundar
5e88255feb
chore: Miscellaneous signposting issues (#7569)
Fixes: #7223
Fixes: #7225
Fixes: #7228
2021-09-20 12:17:04 +05:30
akash-codemonk
a4bfb1b7c0
chore: minor styling fixes for debugger (#7584) 2021-09-20 11:10:59 +05:30
Pranav Kanade
4fa741c06c
fixed alignment for import btn (#7562) 2021-09-20 11:06:54 +05:30
Rishabh Rathod
373f64c9ca
feat: git sync ui update (#7486)
- fix commit & push functionality
- Add Link to docs
- Add user settings toggle

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-09-17 22:28:04 +05:30
Ayush Pahwa
fdc1510236
feat: JSON view for query & datasource form components (#7534)
* Removed unused var

* Added new type and extra props to enable JSON editing experience
2021-09-17 12:14:04 +00:00
Tolulope Adetula
582f4a568f
fix: multiselect loading state (#7418) 2021-09-17 04:14:48 -07:00
Tolulope Adetula
f472ec996d
fix: multiselect selectAll design (#7424) 2021-09-17 04:13:09 -07:00
Vinod
0ef0da041b
feat: add copy button to evaluated value (#7159)
* add copy function for evaluated value
2021-09-17 16:32:16 +05:30
Rishabh Saxena
819f0c2753
feat: add git config to user profile settings (#7538) 2021-09-17 16:18:38 +05:30
Vinod
2bd324a5aa
feat: address few bug with linting and improve highlighting (#7287)
* show lint errors as warnings

* add initial code

* adjust editor positions

* update pr comments

* mark jshint errors

* reset changes

* remove unused prop

* fix test errors

* remove unused imports

* dont show warning in the error counter

* show yellow if warning

* remove active error functionality

* update linter to use async functionality

* update linter messages

* update binding positions

* fix evaluate tests

* dont show undefined errors in debugger

* move lint code to separate file

* update testes

* remove unused import

* update tests

* address pr comments

* add comment to explain why

* replace proper regex

* fix undefined message error

* Update styling for warnings

* address position issue in the linter

* Fix failing tests

* Merge 'release' on to  'Feature/linting-errors'

* add console as global object

* address lint issues

* fix requested linting erros for release

* fix breaking issue

* remove unwanted code

* revert unrelated changes

* remove unnecessary file

* add extra libraries to jshint data

* import lodash functions that are used

* update jshint settings

* Fix failing test

* don't show lint errors if there is a parsing issue

* update jshint to latest version
2021-09-17 16:01:45 +05:30
balajisoundar
6baa5c8489
chore: Fix misc minor welcome page issues (#7504)
Fixes: #7503
2021-09-17 15:31:42 +05:30
Tolulope Adetula
15b26f823e
feat: Tree Select widget (#6271)
* feat: Tree Select

* feat: styling multiselect

* fix: selected values

* fix: remove console statement

* fix: popup position

* fix: selection types

* fix: Form validation using TreeSelect

* feat: Add Label to TreeSelect

* fix: styling

* fix: Dropdown search

* fix: Add Entity Definitions

* fix: Entity Definition

* Feat: Add clear icon

* fix: validation

* fix: options validation

* fix: Styling issues

* fix: build error

* Fix: Separate Tree Select widget

* fix: issues and add validation

* fix: Options Validation

* fix: issues with build

* fix: yarn

* fix: changes

* fix

* Fix: select component

* fix: PR issues

* fix: merge conflicts

* fix: issues

* fix: all issues

* test: added test

* fix: failing test
2021-09-17 02:08:35 -07:00
Aswath K
49551987fc
fix: Transparent menu on MenuButton widget (#7268) 2021-09-17 08:55:47 +00:00
Pranav Kanade
73b795cb71
fix: layout control not working (#7502)
* fixed layout control problem.

* removed extra padding for multi pointer canvas
2021-09-17 11:07:09 +05:30
Tolulope Adetula
ca8b74da30
fix: app crashes when editing table visibility (#7472) 2021-09-17 05:33:26 +00:00
Tolulope Adetula
0ce1bac98a
fix: only run onFilterUpdate when it's defined (#7552) 2021-09-16 23:02:16 +05:30
Ashok Kumar M
34c4dad0ac
fix: flashElement scrolls canvas too much. (#7547) 2021-09-16 22:24:12 +05:30
NandanAnantharamu
1d101300a5
test: fixing the Cypress test for input spec (#7551) 2021-09-16 16:05:02 +00:00
rahulramesha
333c28f702
fix: list widget cyclic dependency (#7542)
This commit fixes the cyclic dependency error shown to users when the data for list widget is removed.
2021-09-16 21:13:11 +05:30
NandanAnantharamu
30d337c9dc
test: Added test for public apps access check (#7525) 2021-09-16 13:44:30 +00:00
NandanAnantharamu
738f5940f2
Updated test (#7535) 2021-09-16 18:19:46 +05:30
Abhinav Jha
f19b62e86b
chore: Fix widget help links from the property pane (#7529) 2021-09-16 17:46:14 +05:30
Abhinav Jha
8a787c9918
chore: Fix the name of the select widget listed in the widget list (#7518) 2021-09-16 17:41:45 +05:30
Abhinav Jha
6913d188f9
chore: Fix checkbox widget icon (#7524) 2021-09-16 17:40:20 +05:30
Ashok Kumar M
396b72a378
Fix for #7526. Scrolling issue on canvas (#7530) 2021-09-16 11:42:11 +00:00
Bhavin K
9116c6483f
fix: add check for max char in input widget only applicable for text type (#7250) 2021-09-16 16:32:34 +05:30
ashit-rath
1c24afb356
fix: table row cell actions to get proper currentRow data (#7244)
* fix: table row cell actions to get proper currentRow data

* minor change
2021-09-16 12:26:52 +05:30
ashit-rath
0354fdaa16
fix: Input widget as number type 0 as default value (#7251)
* fix: Input widget as number type 0 as default value

* added cypress test case

* cypress test fix, force click default text input

* updated input widget validation of number/currency/phone number type

* minor change
2021-09-16 11:22:01 +05:30
akash-codemonk
71d7b26665
fix: Do not show errors for blank fields in datepicker and listwidget (#7032) 2021-09-16 11:02:00 +05:30
akash-codemonk
8b8ddb3390
fix: Quickly clicking do it for me button shows errors during onboarding (#7386) 2021-09-16 10:09:55 +05:30
Yash Vibhandik
aea55014ec
fix: added container wrapper component to handle styles (#6476)
* FIX #2587 : added container wrapper component to handle styles, updated test cases

* FIX #2587 : abstract widget style component for common use and wraped on text widget

* updated style boundary and css

* updated cypress test

* fix: accommodate prop pane height change for the test

* removed properties from text widget

* updated container wrapper style to handle border corners, updated migrations for container and form widget

* fixed container overflow

* added testcases for container and text widget

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-09-16 09:51:31 +05:30
rahulramesha
c4de8fc720
fix: copy paste new widget key generation (#7464)
fixes widgets from having exact same react keys
2021-09-15 19:34:27 +05:30
Rishabh Saxena
f277fe92e0
feat: minor bottom bar UI updates (#7456) 2021-09-15 19:31:32 +05:30
Arpit Mohan
37e7a61792
chore: Minor changes for fixing some strings on the home page & action settings page (#7469) 2021-09-15 12:20:25 +00:00
Abhinav Jha
d94408776f
fix: Styling issues with the buttons on the platform (#7365)
Fix button styles in platform and also update stat box widget icon svg
2021-09-15 12:15:21 +01:00
balajisoundar
cf3b4ae1be
fix: Signposting and Welcome tour overlapping issue (#7421)
Fixes: #7405 
Fixes #7226
2021-09-15 15:26:15 +05:30
NandanAnantharamu
1db152bd5c
updated test and common method (#7446) 2021-09-15 14:07:58 +05:30
haojin111
523ba15d88
chore: fixed issue of height when focusing on API inputbox (#6304)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-09-15 06:37:49 +00:00
Apeksha Bhosale
3dd6c14b5f
create js action default with js collection (#7388) 2021-09-15 11:58:25 +05:30
deepsource-autofix[bot]
042f9d249a
chore: Remove the unreachable code block (#7326)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-09-15 11:29:13 +05:30
akash-codemonk
e9fe54fefe
fix: Show trigger errors in the debugger with widget and property name (#6970) 2021-09-15 10:41:13 +05:30
balajisoundar
e102ee781f
fix: Suppress unauthorised error, when user visits welcome page (#7435)
fixes: #7433
2021-09-14 22:25:29 +05:30
Ayush Pahwa
cd889201a2
Added new key propertyName to uniquely store evals in state (#7430) 2021-09-14 15:41:50 +00:00
akash-codemonk
d34827da78
fix: Show recent errors first in the debugger error tab (#7420) 2021-09-14 20:21:07 +05:30
Rishabh Rathod
1911cf53c8
chore: remove debugger (#7438)
Remove `debugger`
2021-09-14 13:46:23 +00:00
Pranav Kanade
a811bac995
feat: Enabled collab presence feature (#7376)
* enabled collab presence feature

* putting back unrelated changes
2021-09-14 18:57:39 +05:30
Rishabh Saxena
e08fc3c538
chore: check for anonymous user before fetching notifs (#7381) 2021-09-14 18:48:49 +05:30
Ayush Pahwa
8f294c8868
fix: Initial values extraction process from json (#7414)
* Updated getConfigInitialValues function to extract initialValues properly

* Added error catching in case the form is not loaded properly

* Comparing the whole formdata instead of just the values

* Refactoring

* Moved setting initial eval state to query pane saga

* Running update only if uicomponent type is consitent with UQI

* Removed check for UQI type for form eval

* Removed unused imports
2021-09-14 13:01:09 +00:00
Hetu Nandu
1c3cf30ac1
always assume onSuccess, onError, .then, .catch to be callbacks (#7402) 2021-09-14 13:56:54 +05:30
akash-codemonk
4af5a4dc0d
fix: debug button message shown in query pane (#7373) 2021-09-14 09:49:52 +05:30
Rishabh Rathod
a6c2a63ce9
feat: Git connection (#7269)
Add git connection UI

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-09-13 18:56:24 +05:30
ashit-rath
289c490217
fix: allow multiple draggable popper to co-exist (#7323)
* fix: allow multiple draggable popper to co-exist

* added custom data-cy for popper drag handler to fix failing cypress tests
2021-09-13 18:05:05 +05:30
ashit-rath
6d7ebf81b1
fix: New table widget migration to sanitize primaryColumn, columnOrder and binding paths (#7037)
* Table widget migration to sanitize keys and binding paths

* added new test case

* modified the logic to sanitize dynamicBindingPathList

* fix calling migrateTableSanitizeColumnKeys on child and fix updating dsl version
2021-09-13 17:33:39 +05:30
arunvjn
80d1766dfb
Execute snippet only for js snippets and remove default dynamic binding before execute. (#7360) 2021-09-13 17:13:05 +05:30
Hetu Nandu
bc6164cb81
Fix action error callback crash (#7377) 2021-09-13 15:55:22 +05:30
Ayush Pahwa
2c92b507b5
fix: Calling form eval init on form change (#7372)
* Calling form eval init on form change

* Updated comment on the function
2021-09-13 10:07:39 +00:00
NandanAnantharamu
0cfdd35df1
Test : Added assertion for query data (#7061) 2021-09-13 14:27:00 +05:30
balajisoundar
e2ef262f05
feat: Improved onboarding flow on user signup (#7089)
This commit introduces new improved onboarding flow for new users. 

fixes: #4057
2021-09-13 12:52:51 +05:30
balajisoundar
95c729d7d1
feat: Introduce a Welcome screen and a form to create a super user, on a fresh installation (#6806)
This commit introduces a super user signup form, that appears only on an empty instance, to create a super user.

fixes: #6934
2021-09-12 22:06:43 +05:30
arunvjn
8f2d0c0984
fix: Removed js formatter and new icons for snippets (#7290) 2021-09-10 20:30:50 +05:30
Rishabh Rathod
dbfc140f2b
fix: text overflow issue (#7270)
Changed label text to avoid overflow issue
2021-09-10 20:13:17 +05:30
Pranav Kanade
3c0b33763e
fix: Collab feedback fixes (#7298)
* hide the widget names

* blocking multiselect in comment mode

* wrapped the name

* the latest comment will be on top

* isolated a condition for selection canvas

* added unresolve tooltip

* added resolved thread tooltip

* updated sorted comment cards when user gets the update/insert/delete events
2021-09-10 16:17:17 +05:30
Rishabh Saxena
594e0ef2e1
fix: ui polish comments (#7273) 2021-09-10 10:37:17 +05:30
akash-codemonk
116558fe8f
chore: Update snippet text and search params for debugger search menu (#7249) 2021-09-10 09:48:32 +05:30
dependabot[bot]
238698e2e9
chore: bump tar from 6.1.6 to 6.1.11 in /app/client (#7070)
Bumps [tar](https://github.com/npm/node-tar) from 6.1.6 to 6.1.11.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.1.6...v6.1.11)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-09 16:39:55 +00:00
Rishabh Saxena
e7cec074aa
refactor: reset comments fetched flag at the init sagas (#7265) 2021-09-09 16:01:26 +00:00
Abhinav Jha
b49f5097c6
refactor: Widget Development API (#6405) 2021-09-09 20:40:22 +05:30
Bhavin K
cc28b82ec6
fix: add migration for removed table default selected row (#7276)
fix: revert migration and add reverse migration for table widget's last migration.
2021-09-09 19:13:36 +05:30
Pranav Kanade
94e7594820
fix: sniping checkbox will set the string not boolean (#7311)
This prevents a crash from happening when an object is bound to the checkbox.
2021-09-09 18:49:39 +05:30
somangshu
f18d58bb12 Revert "fix: property pane (#7157)"
This reverts commit 72f667bec4.
2021-09-09 13:48:16 +05:30
akash-codemonk
3ded440ca8
fix: convert message to string if it is not to avoid crash (#7272) 2021-09-09 11:05:25 +05:30
yatinappsmith
6f4d91865b
commenting dropdown_spec (#7271) 2021-09-09 10:31:16 +05:30
Apeksha Bhosale
09eea59330
feat: JS Editor (#6003)
* Changes to add js plugin

* routes+reducer+create template

* added debugger to js editor page

* entity explorer changes

* create js function

* added copy, move and delete action

* added js plugin

* added existing js functions to data tree

* removed actionconfig for js collection

* new js function added to data tree and entity as well

* parsing flow added

* changes to data tree

* parse and update js functions

* small changes for def creator for js action

* create delete modified

* small changes for update

* update flow change

* entity properties added

* removed linting errors

* small changes in entity explorer

* changes for update

* move, copy implementation

* conflict resolved

* changes for dependecy map creation

* Only make the variables the binding paths

* Basic eval sync working

* Minor fixes

* removed unwanted code

* entity props and autocomplete

* saving in progress show

* redirection fix after delete js action

* removed unnecessary line

* Fixing merge conflict

* added sample body

* removed dummy data and added plugin Type

* few PR comments fixed

* automplete fix

* few more PR comments fix

* PR commnets fix

* move and copy api change

* js colleciton name refactor & 'move to page' changes & search

* view changes

* autocomplete added for js collections

* removing till async is implemented

* small changes

* separate js pane response view

* Executing functions

* js collection to js objects

* entity explorer issue and resolve action on page switch

* removed unused line

* small color fix

* js file icon added

* added js action to property pane

* Property pane changes for actions

* property pane changes for js functions

* showing syntax error for now

* actions sorted in response tab

* added js objects to slash and recent entitties

* enabling this to be used inside of function

* eval fix

* feature flag changes for entity explorer and property pane

* debugger changes

* copy bug fix

* small changes for eval

* debugger bug fix

* chnaged any to specific types

* error in console fix

* icons update

* fixed test case

* test case fix

* non empty check for functions

* evaluate test case fix

* added new icons

* text change

* updated time for debounce for trial

* after release mereg

* changed icon

* after merge

* PR comments simple

* fixed PR comments - redux form, settings remove

* js object interface changes

* name refactor

* export default change

* delete resolve actions chnage

* after merge

* adding execute fn as 3rd option and removed create new js function

* issue 7054 fixed - app crash

* execute function on response tab changes

* refactor function name part 1

* refactor of js function name

* try catch added refactor

* test fix

* not used line removed

* test cases locator fixed

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-09-08 23:02:22 +05:30
Nikhil Nandagopal
72f667bec4
fix: property pane (#7157)
* updated widget properties

* updated placeholders

* updated default for date

* lint fix

* Fixed more styles and reverted changes to input widget

* adjusted default sizes of different widgets

* resized image in list widget

* reduced chart default data

* fixed tests

* PR comment fixes

* fixed tests failing

* fix: Fixed failing jest tests because of an error in chart widget propertyConfig object

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-09-08 20:03:06 +05:30
Nidhi
a7239cfa5b
feat: Changes to add js plugin (#4861)
Adds server side changes for supporting JS editor
2021-09-08 19:17:30 +05:30
Ayush Pahwa
dd7ad6a3ed
feat: Updating query fom render according to new json structure (#7188)
* Updated renderEachConfig function, changed keys for eval storing

* Removed unused imports
2021-09-08 11:35:06 +00:00
Paul Li
4c6fb4fcb6
feat: New widget - Audio Recorder widget (#6702)
User can record audio / play it as feedback and then use the data in any API with the help of this new widget
2021-09-08 16:30:36 +05:30
akash-codemonk
30899cbb4a
fix: Undoing delete widget does not restore the errors in the debugger (#7232) 2021-09-08 16:13:44 +05:30
rashmi rai
542a204a32
wrapped header text in AutotooltipComponent (#7186)
Co-authored-by: rashmi rai <rashmirai@appsmith.com>
2021-09-08 15:08:22 +05:30
Vicky Bansal
b7385ebd91
fix: Filter columns which has a column accessor (#7101)
* Filter columns which has does not have a column accessor property
2021-09-08 14:41:48 +05:30
Yash Vibhandik
387ba66f00
FIX #4952 : checked array before spread (#7027) 2021-09-08 14:30:07 +05:30
arunvjn
e9f079ea03
fix: snippets meta and short title (#7216) 2021-09-08 12:20:21 +05:30
ashit-rath
39aa4e6d8d
feat: Consistent styling for widgets disabled state (#6983)
* checkbox and button default styling

* rate widget disabled styling

* added cursor: not-allowed to disable css
2021-09-08 11:45:11 +05:30
ashit-rath
863d992d77
fix: Tabs widget - full height when showTabs is false (#6949)
* Fix - Tabs widget - full height when showTabs is false

* added conditional height for ChildrenWrapper based on tab visibility state
2021-09-08 10:13:11 +05:30
Rishabh Saxena
b61be1eb66
fix: persist draft comments on clicking outside (#7156) 2021-09-07 20:53:40 +05:30
arslanhaiderbuttar
603e282529
test: Select UI test cases (#6328)
* Select/MultiSelect widget UI test cases

* Select/MultiSelect Test Cases

Dropdown-AlertModal
Dropdown-FromModal
Dropdown-Call-Api
Dropdown-Call-Query
Toggle JS - Dropdown-Call-Query
Toggle JS - Dropdown-CallAnApi Validation
Verify Search box for selecting drop-down options
Verify Dropdown default value
Dropdown Icon Visibility
Explore Widget related documents
Dropdown Close
On Option Change Action
Copy paste dropdown
Dropdown-Delete
Toggle JS - Dropdown-Unckeck Visible field
Toggle JS - Dropdown-ckeck Visible field

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* Added go to edit page from published page

* Removed the multiselect test cases from dropdown

* Select ui test cases fixes

* Select UI test fixes
2021-09-07 13:41:36 +00:00
Rishabh Saxena
5f6a948acd
fix: try making create new thread transition better (#7200) 2021-09-07 19:05:01 +05:30
Rishabh Rathod
fafe03a2e7
chore: jest state update on unmount error (#7141)
Add clearTimeout to avoid setState on unMount
2021-09-07 18:43:56 +05:30
Rishabh Rathod
027ed55611
fix: omit props passing to DOM element (#7181) 2021-09-07 18:42:04 +05:30
Rishabh Rathod
a2a5439741
fix: text overflow gen CRUD form (#7180)
Fix #7151 : Text overflows the row when the table's column name is more than 25 characters.
2021-09-07 18:41:27 +05:30
Rishabh Saxena
ea1d49775c
fix: handle resolved/deleted comment threads after they're fetched (#7185) 2021-09-07 18:25:38 +05:30
arslanhaiderbuttar
c5503ee9e8
List widget UI test cases (#5535)
* List Widget UI Test Cases

List Widget UI Test Cases:

Change the List Widget Name
Add or Modify items
Change the Background Color
Change the Item Background Color
Enable Disable Visible
Enable Disable Visible - JS
Adding Query/API
Copy Widget
Delete Widget
Change the list and item background color using JS Button

* Update List_spec.js
2021-09-07 12:48:38 +00:00
Rishabh Saxena
89b10b5520
fix: close notifications list on clicking a list item (#7178) 2021-09-07 18:15:17 +05:30
Rishabh Saxena
928242d79b
fix: center alignment for profile placeholder (#7197) 2021-09-07 18:15:04 +05:30