Commit Graph

841 Commits

Author SHA1 Message Date
Yash Vibhandik
02384eed36
updated isLoading state when event action completed in Filepicker widget (#5407) 2021-07-05 10:58:47 +05:30
Vicky Bansal
b6e205e5b2
Fix-Rename compact mode property in Table Widget to Row Height (#5496)
* Change compact mode title to Row height in property pane configurations
2021-07-02 16:57:20 +05:30
Paul Li
38ffe86290
Rate widget (#4891)
* FEATURE-3357 : Rate Widget

-- Create the first MVP of rate widget

* FEATURE-3357 : Rate Widget

-- Change the widget name into rating
-- Change the widget icon
-- Fix the overflow issue in case max count is big
-- Fix the issue in case default rate is zero
-- Add validations for maxCount and defaultRate

* FEATURE-3357 : Rate Widget

-- Fix an issue : Stars is cut off if maxCount is greater than 20
-- Add test cases for two validation types, RATE_DEFAULT_RATE and RATE_MAX_COUNT

* FEATURE-3357 : Rate Widget

-- Add expected data type for tooltip field

* FEATURE-3357 : Rate Widget

-- Expose maxCount

* FEATURE-3357 : Rate Widget

-- Change contents of isAllowHalf property
-- Adjust alignment of stars dynamically
-- Decrease default widget width

* FEATURE-3357 : Rate Widget

-- Remove a unnecessary comment block
2021-07-02 15:25:50 +05:30
Yash Vibhandik
6102f5b119
Added text color JS convertible support in text widget
added text color js convertible support in text widget, added COLOR_PICKER_TEXT validation and updated test case (#5409)
2021-07-02 12:39:17 +05:30
Bhavin K
96c6b3b80f
moved table property pane config (#5478)
In the table widget, The header options are not re-ordered below the Actions
2021-07-01 12:23:21 +05:30
Tolulope Adetula
132abdaa54
feat: add object fit control (#4986)
* Added attribute to image widget to change cover properties
2021-06-29 19:00:14 +05:30
Somangshu Goswami
9b1dbeb9dc
Revert "Enable total number of rows and page size for server side pagination in table widget (#4863)" (#5469)
This reverts commit related to #2230 & #1578. We will revisit this problem again and implement the solution based on the discussion in the thread.
2021-06-29 15:01:41 +05:30
Vicky Bansal
fe700a8049
Fixed empty area issue when columns are hidden in published mode (#5162) 2021-06-23 19:09:04 +05:30
Vicky Bansal
6b7aef8dc8
Enable total number of rows and page size for server side pagination in table widget (#4863)
* Add defaultPageSize and totalRecordsCount properties in table widget

* Changing next button disable

* Added checks for properties change

* Handle defaultPageSize change

* Updated util.test to handle new table properties

* Configure for cypress test for page size and total records count properties

* Added cypress test for default page size and total records count validation

* Fix test cases

* Handle empty space for page size is less than availabe space in table widget
2021-06-23 18:53:24 +05:30
Satish Gandham
47bc5aa032
Merge pull request #5026 from appsmithorg/feature/1726-iframe-widget
Adding iframe widget
2021-06-23 13:01:40 +05:30
rahulramesha
b12cea84a6
Merge pull request #5167 from appsmithorg/FIX/5073-File-Picker-close-button-tool-tip-content-change
FIX/5073 for File Picker close button tool tip content change
2021-06-22 16:52:19 +05:30
Somangshu Goswami
3c8944cc1c
Merge pull request #4341 from appsmithorg/fix/dropdown-overlap-modal
fix: Dropdown option gets overlapped on the ModalComponent
2021-06-22 15:37:44 +05:30
Hetu Nandu
441f42c72f
Generate linting errors via JSHint (#5034) 2021-06-21 16:39:51 +05:30
Paul Li
9bc1cd4899 Merge branch 'release' into feature/1726-iframe-widget 2021-06-21 06:54:20 -04:00
Paul Li
96c273cc22 FEATURE-1726 : Iframe Widget
-- Set default source url to wikipedia.org
-- Fix typo on the tooltip of onURLChanged, url to URL
-- Fix the issue which is related to reduced iframe in its deploy mode
-- Fix the issue which is related to the inclusion of nearby widgets in deploy mode
-- Add Expected Data Type fields with regard to borderOpacity and borderWidth
2021-06-21 06:48:00 -04:00
rahulramesha
c17588f2f8 Merge branch 'release' of github.com:appsmithorg/appsmith into FIX/5073-File-Picker-close-button-tool-tip-content-change 2021-06-21 15:17:10 +05:30
Somangshu Goswami
82a62cf4a7
Merge pull request #4864 from appsmithorg/FIX/4731-dragging-and-dropping-table-widget-error-in-debugger
FIX #4731: update condition for selectedRowIndices when table widget drag and drop
2021-06-21 14:39:10 +05:30
akash-codemonk
e7f6598231
Fix: Log dependent property values in debugger when a property is updated (#4865) 2021-06-21 13:50:25 +05:30
Yash
26a70870f0 Merge remote-tracking branch 'origin/release' into FIX/4731-dragging-and-dropping-table-widget-error-in-debugger 2021-06-21 13:15:07 +05:30
Abhinav Jha
2c3b457b47
Fix Table Widget Filter issue (#3975)
* Fix issue where non-string empty values are not correctly filtered

* Add unit test for fix
2021-06-18 17:34:34 +05:30
Pawan Kumar
91bf527bea
List Widget Phase 2 (#4189)
* update  meta properties + default properties map

* update widget registery

* update get meta property

* update metahoc + widgetfactory + data tree evaluator

* try sending function as string to worker

* revert data tree evaluator update

* pass default props map from dataTreeWidget file

* wip

* save child meta properties

* remove console.log

* save meta and default map in list

* update listwidget

* remove console.log + unused variables

* revert getMetaPropertiesMap function

* fix data tree test

* fix list widget test

* fix entity definition test

* fix overriting of item in updatedItems

* remove todo comments

* fix meta prop issue

* revert making meta properties from undefiend to "" & fix filepicker bug

* fix test case

* change items to listData and updatedItems to items

* remove console.log

* fix test

* extract derived properties to dervied.js

* disabled top, left, right resize handler list widget container

* add test for dervied js

* add test for selectedItem

* fix background color bug on hover

* remove console.log

* fix chart widget inside list widget

* fix checkbox issue + points raised by yogesh

* revert the createImmerReducer usage

* fix parse derived properties

* remove internal props object that fails the test

* fix import typo

* allow bottom resize handler

* fix template height check

* fix template height check

* update template size check

* fix the is visible invalid prop issue

* fix migration of list widget phase 2

* fix migration

* remove unused import

* fix migration

* fix migration

* remove console.log

* hide delete option for container in entity explorer

* fix testcases

* remove unused import

* fix switch widget meta prop

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-06-18 13:12:57 +05:30
Tolulope Adetula
9b39cdbb45 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-18 07:07:35 +01:00
rahulramesha
b4519b9dae Merge branch 'release' of github.com:appsmithorg/appsmith into FIX/5073-File-Picker-close-button-tool-tip-content-change 2021-06-18 10:46:27 +05:30
Ashok Kumar M
a76b8cad9b
Feature: Widget Grouping Phase II (#4825)
* dip

* dip

* Cleaning up grid density positioning.

* dip

* dip

* dip

* dip

* code clean up

* dip

* dip(restructuring widget selection)

* Deselect parents and children of a widget when user multi selects.

* dip

* dip

* dip

* dip

* dip

* fixing a bad merge

* fixing tests

* adding jest tests.

* common util

* dip

* dip

* fixes

* restrict in deploy mode.

* fixing dynamic layout.

* fixing tests.

* on paste fix.

* fixing specs.

* addressing code review comments

* dip

* dip

* dip

* fixing specs.
2021-06-17 18:56:54 +05:30
rahulramesha
9ce7e906a0 fix for #5073 2021-06-16 15:14:09 +05:30
Yash
2e0f307794 Merge remote-tracking branch 'origin/release' into FIX/4731-dragging-and-dropping-table-widget-error-in-debugger 2021-06-16 14:57:09 +05:30
Tolulope Adetula
47bda1d736 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-15 10:18:19 +01:00
Paul Li
31177efc18 FEATURE-1726 : Iframe Widget
-- Remove the spread operator in IframeWidget
-- Connect the widget help with the correct documentation path
-- Expose source and title for autocomplete
-- Remove the redundant wrapping with meta from the widget
2021-06-12 12:08:10 -04:00
Paul Li
809416ab21 Merge branch 'release' into feature/2111-toggle-header-options 2021-06-11 09:25:12 -04:00
Paul Li
4d9ea51baa Merge branch 'release' into feature/1726-iframe-widget 2021-06-11 09:21:38 -04:00
Paul Li
6c9f3c2a89 FEATURE-1726 : Iframe widget
-- Remove spread operator on IframeComponent
-- Use a theme color by default for border color
-- Fix the crash issue when the widget is removed
2021-06-11 09:16:29 -04:00
Paul Li
e2168f70d8 Merge branch 'release' into feature/1726-iframe-widget 2021-06-10 04:18:56 -04:00
Paul Li
88a885b759 FEATURE-1726 : Iframe Widget
-- Bind onMessageReceived
-- Refactor event bindings
2021-06-10 04:17:33 -04:00
Paul Li
b682741f13 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-06-10 01:31:54 -04:00
Paul Li
47da2c622f FEATURE-1726 : Iframe Widget
-- Bind onURLChanged event listener
2021-06-10 01:29:52 -04:00
Paul Li
a54b0ffc16 Merge branch 'release' into feature/2111-toggle-header-options 2021-06-09 06:19:41 -04:00
Paul Li
a5cdf32590 FEATURE-1726 : iframe widget
-- Scaffold the widget
-- Bind properties
2021-06-09 05:39:17 -04:00
Somangshu Goswami
d37c7a97a4
Merge pull request #4834 from appsmithorg/feature/modal-onClose
added onclose property and handlers on ModalWidget
2021-06-08 12:43:50 +05:30
Somangshu Goswami
5f01ec859d
Merge pull request #4660 from appsmithorg/FIX/4573-custom-chart-type-not-supported-text
FIX #4573 : added custom fusion chart config to override default message
2021-06-07 19:09:35 +05:30
Somangshu Goswami
5bca743790
Merge pull request #4452 from appsmithorg/fix--color-picker-in-form-widget
fix: add color picker to form component
2021-06-07 18:15:15 +05:30
Somangshu Goswami
ba0a7a428e
Merge pull request #4734 from appsmithorg/bug/select-lodash-options
added string check on options props
2021-06-07 14:45:49 +05:30
Tolulope Adetula
cf8d9b8c0b Merge branch 'release' into fix--color-picker-in-form-widget 2021-06-07 07:33:17 +01:00
Tolulope Adetula
210e65a668 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-07 07:28:42 +01:00
Paul Li
f7ae4f0b2d Merge branch 'release' into feature/2111-toggle-header-options 2021-06-03 03:46:29 -04:00
Yash
3d18a9b36a FIX #4731: update condition for selectedRowIndices when table widget drag and drop 2021-06-02 15:31:52 +05:30
bhavin
a889153714 fixing docs and expectation strings on custom chart 2021-06-01 16:01:32 +05:30
bhavin
53598e8027 added onclose property and handlers on ModalWidget 2021-06-01 14:50:13 +05:30
Tolulope Adetula
59738c5019 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-01 07:11:52 +01:00
Hetu Nandu
ae28731947
Enable smart substitution for widgets (#4801) 2021-06-01 10:29:45 +05:30
bhavin
2b9cc622cc replaced string check with array check 2021-06-01 09:36:47 +05:30
Somangshu Goswami
d770b360b0
Merge pull request #4350 from appsmithorg/fix/dropdown-default-value
fix: set default format in table date type cell
2021-05-31 20:08:49 +05:30
Somangshu Goswami
fd7db3356e
Merge pull request #4433 from appsmithorg/fix/-filePicker-widget-property-cleanup
fix: remove uploadedFileUrls property from FilePicker
2021-05-31 20:07:16 +05:30
Yash
9de9b1eb30 FIX #4573 : added sample custom fusion chart config and updated data shape to override default message 2021-05-28 14:49:36 +05:30
Tolulope Adetula
664ba6ab22
Update File-picker widget property 2021-05-28 01:45:37 -07:00
Ashok Kumar M
575d7fe7f9
Fix: Adding missing widget properties when a new tab is created. (#4733)
* dip

* dip

* dip

* Revert "dip"

This reverts commit f0eeaa4a2dc9845509945c2af9376f1573baafdf.

* dip

* removing unwanted iteration.

* Adding and fixing specs.
2021-05-28 08:28:02 +05:30
bhavin
c014485268 added string check on options prop 2021-05-27 16:27:10 +05:30
somangshu
ee4fa8307f Merge branch 'release' into areyabhishek-patch-4 2021-05-27 12:38:32 +05:30
Pawan Kumar
0d41797a26
Fix: List Widget crashes on null empty object in data (#4349)
* filter null values in property pane autocomplete

* add hover states for list items

* add loading state in list

* fix loading state of list widget

* open list widget property on click of container

* fix isVisible bug in list widget children

* remove unused import

* add cusor pointer

* add focused state for first item in list widget

* fix empty state

* fix test case

* fix visiblity bug

* fix test case

* fixes for review comments

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-05-27 12:11:38 +05:30
Tolulope Adetula
3c1f4bca9b Merge branch 'release' into fix/-filePicker-widget-property-cleanup 2021-05-21 08:05:17 +01:00
Tolulope Adetula
f4e693f4f8 Merge branch 'release' into fix--color-picker-in-form-widget 2021-05-21 06:42:26 +01:00
somangshu
29579a71fa Merge branch 'release' into areyabhishek-patch-4 2021-05-20 15:21:25 +05:30
bhavin
4e559b4228 remove no selection option 2021-05-20 13:54:26 +05:30
Tolulope Adetula
afcf7d793a fix: PR comments 2021-05-20 06:04:52 +01:00
Paul Li
c1557c187a FEATURE-2111 : Show/Hide Table Controls
-- Adjust pageSize
-- Change column header height
-- Restore the logic for renderEmptyRow
2021-05-19 07:02:07 -04:00
Paul Li
c906b0e447 FEATURE-2111 : Show/Hide table controls
-- Apply some cleanup
2021-05-19 05:36:30 -04:00
Paul Li
7cf12ed031 FEATURE-2111 : Show/Hide Table Controls
-- Remove extra space when the header options is all hidden
2021-05-19 05:36:30 -04:00
Paul Li
f943d0b330 FEATURE-2111 : Show/Hide Table Controls
-- Remove JS convertible
-- Set isBindProperty and isTriggerProperty to false
2021-05-19 05:31:53 -04:00
Paul Li
c76ef9e3d7 FEATURE-2111 : Show/Hide Table Controls
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
2021-05-19 05:31:53 -04:00
Tolulope Adetula
523972e191 Fix: modal and Dropdown 2021-05-19 08:20:00 +01:00
Tolulope Adetula
18e5dde01d Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-18 22:24:33 +01:00
Ashok Kumar M
8c8141650a
Feature: Widget grouping Phase I (Multi select and Bulk Delete) + Canvas Enhancements. (#4219)
* Feature: Canvas layer enhancements(DIP)

* feedback fixes

* fixing build

* dip

* dip

* dip

* fixing build

* dip

* dev fixes

* dip

* Fixing top bottom resize handles

* dip

* reposition widget name on top edges.

* dip

* dip

* dip

* dip

* renaming selectedWidget to lastSelectedWidget

* code clean up

* Fixing list widget as per grid scale.

* Fixing existing specs.

* Adding migration test cases.

* dip

* FIxing proppane in modal.

* fixing modal z-indedx.

* fix for modal name.

* dip

* dip

* dip

* adding test cases for hotkeys.

* dip

* dip

* fixing build

* Trying some performance improvements for jests.

* 17 mins with runinband lets try without it.

* minor bug fixes.

* code clean up

* save migrated app on fetch.

* fixing few cypress tests

* fixing cypress tests

* fixing cypress tests.

* fixing cypress

* updated DSL

* Addressing code review comments.

* test fails

* dip

* eslint fixes.

* fixing debugger cypress tests.

* updating latest page version.

* updating migration changes to cypress dsl's.

* updating chart data fixes for cypress tests.

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-18 23:59:39 +05:30
Somangshu Goswami
01aa8ed36d
Merge pull request #4316 from appsmithorg/fix/server-side-search
Disable client side search when server side search is enabled in table widget
2021-05-18 20:16:30 +05:30
Somangshu Goswami
52da3e7030
Merge pull request #3791 from aswathkk/issue/3321
Allow removing filter on Dropdown Widget
2021-05-18 20:15:42 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Satish Gandham
bed4b39561
Merge pull request #4292 from appsmithorg/perf/optimize-table-widget
Optimize table widget
2021-05-17 14:52:49 +05:30
Satish Gandham
8ecac87ec7 Change the cell renderer function from class property to inline and use JSON.stringify to do the comparision. 2021-05-13 17:38:15 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Tolulope Adetula
285f7faf41 fix: add color picker to form component 2021-05-12 11:03:34 +01:00
Pawan Kumar
cc36bdc051
Fix: TypeError: t.match is not a function (#4445)
* add is number check before setting widget property

* use toString of lodash

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-12 13:27:28 +05:30
Tolulope Adetula
0b1db5689f Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-12 02:22:07 +01:00
Tolulope Adetula
f6c7036d5c fix: remove uploadedFileUrls ppty from FilePicker 2021-05-11 16:53:02 +01:00
akash-codemonk
d6de913949
Revert "Feature: Show widget error state (#4202)" (#4406)
This reverts commit bf7a8b91a4.
2021-05-11 09:40:43 +05:30
abhishek nayak
1276edf517
Update DropdownWidget.tsx
Updated the default value to something that doesn't fail.
2021-05-11 03:19:03 +05:30
Apeksha Bhosale
2138c9059b
match is not a function (#4409) 2021-05-10 19:40:22 +05:30
Tolulope Adetula
23367fe3be Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-10 14:43:38 +01:00
Tolulope Adetula
57a621978d Merge branch 'release' into pr/3791 2021-05-10 14:33:01 +01:00
Somangshu Goswami
1864166fdc
Merge pull request #4285 from appsmithorg/fix/date-time-picker-bug
change data-time format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss'
2021-05-10 11:21:42 +05:30
akash-codemonk
bf7a8b91a4
Feature: Show widget error state (#4202) 2021-05-07 20:03:20 +05:30
Tolulope Adetula
213d7e0c58 Merge branch 'release' into pr/3791 2021-05-06 19:04:14 +01:00
Paul Li
8ea4638d00 FEATURE-4135 : Table URL columns pretty link
-- Change controlType for display text to COMPUTE_VALUE
2021-05-06 10:29:09 -04:00
bhavin
9b91a09c73 fix: set default format in table date type cell 2021-05-06 19:36:41 +05:30
Tolulope Adetula
829742b239 fix: reduced portal zindex 2021-05-06 08:18:39 +01:00
Satish Gandham
f193ff4a21 - Remove the accidental recursive funciton call in tablewidget 2021-05-06 12:01:39 +05:30
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Paul Li
ee47510fac Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-05 05:29:46 -04:00
Paul Li
4be80b665a FEATURE-4135 : Table URL columns pretty link
-- Remove the anchor tag wrapping display text
-- Make display text case-sensitive
2021-05-05 05:26:57 -04:00
vicky-primathon.in
e96fa63f6d Disable client side search when server side search is enabled in table widget 2021-05-05 12:39:15 +05:30
Somangshu Goswami
0a0d9794dd
Merge pull request #4099 from appsmithorg/fix/#3860-input-widget-validation
[Bug] : Input widget validation issues#3860
2021-05-05 12:06:59 +05:30
Somangshu Goswami
6d41a4eb27
Merge pull request #4211 from appsmithorg/fix/4134-table-filter-case-insensitive
Fix/4134 table filter case insensitive
2021-05-05 12:02:27 +05:30
Paul Li
a5a0e0d85d FEATURE-4135 : Table URL columns pretty link
-- Add displayText field into property pane
-- Display urls based on displayText
-- Fix url alignment issue
2021-05-04 15:48:40 -04:00
bhavin
5f9497a627 date format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss' 2021-05-04 16:39:05 +05:30
Satish Gandham
30b33331a2
Fix cyclic dependency making the table widhget crash the app. #4209 (#4214)
- Check if sanitizedTableData is array

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-05-04 13:04:35 +05:30
Satish Gandham
e3b361a8d4 Change inline functions in jsx to class properties 2021-05-03 14:33:03 +05:30
Ashok Kumar M
4350da7da3
Fix: Updating help text for tabs widget after refactor. 2021-05-03 13:12:57 +05:30
Pawan Kumar
923cbcd595
Fix: Validation on grid gap + handle delete child on list widget (#4247)
* handle delete case for list widget

* add check for grid grap validation

* update test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-03 10:31:47 +05:30
Abhinav Jha
d8c9d16575
Fix #1805 base64 encoded images (#4020)
Co-authored-by: Navdeep Singh <navdeep.er@gmail.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-04-30 12:30:13 +05:30
Somangshu Goswami
64961dde16
Merge pull request #4006 from appsmithorg/fix/native-scrollbars-experience
Fix-Native scrollbar UX with custom scrollbars
2021-04-29 16:27:14 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
Paul Li
6d9d7d94bf Merge branch 'release' into fix/4134-table-filter-case-insensitive 2021-04-29 06:04:05 -04:00
Paul Li
2344af3b59 BUG-4134 : Table filter search shouldn't be case sensitive
-- Lowercase and then apply filters
2021-04-29 05:41:16 -04:00
vicky-primathon.in
fcc4ad18f6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-29 01:42:47 +05:30
Somangshu Goswami
3c144a1fe5
Merge pull request #3962 from appsmithorg/fix/multi-select-values-reset
Fix-Multi select dropdown values does not get reset inside a form
2021-04-28 20:58:23 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Paul Li
17dd8d525e Merge branch 'release' into fix/#3860-input-widget-validation 2021-04-27 09:19:50 -04:00
Ashok Kumar M
8f7cc87801
Fix: Tabs widget refactor with new nested property validation (#4014)
* dip

* test cases first commit

* Adding Tabs migrator.

* fixing tests.

* bug fix.

* selected tab fix

* missed commit

* fixing bugs

* Fixing tab name bugs.

* close property pane when dragging or resizing

* migration changes.

* release rebase changes.

* adding List factory

* remove dynamic bindings on deleting tabs.

* Adding validation messages for nested properties as well

* fixing validation issue.

* tabs visibility validation.

* missed commit

* Fixing broken cypress tests.

* Fixing broken tests.
2021-04-27 12:46:54 +05:30
abhishek nayak
c1bc9ed9f2
Update ContainerWidget.tsx
Updated the color field in the property pane to color picker instead of 'Input_text'
2021-04-27 05:07:11 +05:30
Somangshu Goswami
978bec7866
Merge pull request #3987 from appsmithorg/fix/filepicker-clear-files
Fix-Selected file deletion not working in File Picker widget
2021-04-26 20:17:45 +05:30
Pawan Kumar
d814e780ed
Fix: Update chart from array to object (#3907)
* update structure of chart data

* update chart data

* update chart data structure

* remove array like validator

* remove log

* remove log

* widget utils + update tests for chart data validations

* update utils test

* add migrations

* remove unnecessary helper function

* remove unnecessary helper function

* update validation test cases

* WIP

* WIP 2

* Remove validationConfigMap from widget and add to properties

* Update data tree validator to get validation from the correct place

* Minor reference fixes

* Fix test mocks

* fix for bad setting of nested property path

* add test for migration for chart widget function

* fix test for widget utils

* remove unused import;

* remove unsued import

* update migration version

* remove console and add check if data is array

* fix custom fusion chart + validation not working issue

* move custom fusion chart config to chart data section

* remove console and unused import

* fix test

* fix property config test

* fix dynamicbinding path list in migration

* remove old chart validation

* remove old validation test

* fix widget prop utils test

* remove array codepath for widget utils

* fix utils test

* fix utils test

* fix prettier issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 16:05:59 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
Pawan Kumar
1717b0e392
[Feature] Grid Widget (#2389)
* Updated test

* updated assertions

* Resizing image to take full width of table cell

* updated assertion

* Stop updating dynamicBindingPathList directly from widget

* Fix selectedRow and selectedRows computations

* Fix primaryColumns computations

* Updated test for derived column

* Added tests for computed value

* Added check clear data

* Reordering of test

* updated common method

* Made image size as 100% of table cell size

* add templating logic

* Updated flow and dsl

* Clear old primary columns

* Updated testname

* updated assertion

* use evaluated values for children

* Fix primary columns update on component mount and component update

* add isArray check

* remove property pane enhancement reducer

* add property pane enhancement reducer

* disable items other than template + fix running property enchancment on drop of list widget

* disbled drag, resize, settingsControl, drag for items other than template

* add grid options

* uncomment the widget operation for add child for grid children

* handle delete scenario for child widget in list widget

* WIP: Use the new delete and update property features

* add listdsl.json for testcases

* add test cases for correct no. of items being rendered

* add test cases currentItem binding in list widget

* change dragEnabled to dragDisabled

* change resizeEnabled to resizeDisabled

* change settingsControlEnabled to settingsControlDisabled

* change dropEnabled to dropDisabled

* update settingsControlDisabled default value

* Use deleteProperties in propertyControls

* Fix unsetting of array indices when deleting widget properties

* remove old TableWidget.tsx file

* Fix derived column property update on primary column property update

* Handle undefined primary columns

* Fix filepicker immutable prop issue

* Fix object.freeze issue when adding ids to the property pane configuration

* fix widget issue in grid

* Fix column actions dynamicBindingPathList inclusion issue

* remove consoles + fix typo around batch update

* Remove redundant tests

* js binding test for date picker

* hydate enhancement map on copy list widget

* check for dynamicleaf

* fixes

* improve check

* fix getNextWidgetName

* update template in list widget when copying

* updating template copy logic when copying widget

* update dynamicBindingPathList in copied widget

* Add path parameter to hidden functions in property pane configs

* fix copy bug when copying list widget

* add computed list property control

* Remove time column type

Fix editor prompt for currentRow

Fix undefined derivedColumns scenario

Remove validations for primaryColums and derivedColumns

Fix section toggle for video, image and button column types

* Fix table widget actions and custom column migrations

* Add logs for cyclical dependency map ♻️

* Process array differences

* add property control for list widget

* Fix onClick migrations

* Property pane config parity

* binding and trigger paths from the property pane config (#2920)

* try react virtualized library

* Fix unit test

* Fix unit test 

* Fix minor issues in table widget

* Add default meta props to binding paths to ensure eval and validation

* Dummy commit 🎉

* Remove unnecessary datepicker test

Fix chart data as string issue

* Achieve table column sorting and resizing parity with release

* handle scenario where last column isn't available to access

* Fix for panel config path not existing in the widget

* Fix bindings in currentRow (default)

Add dummy property pane config for canvas widget

* Update canvas widgets with dynamicPathLists on delete of property paths

* Add all diffs to change paths and trim later

* Add back default properties 🚶🏻‍♂️

* Use object based paths instead of arrays for primaryColumns and derivedColumns

* Fix issue in reordered columns

* Fix inccorect update order

* add virtualized list

* Fix failing property pane tests

* minor change

* minor list widget change

* Remove .vscode from git

* Rename ads to alloy

Fix isVisible in list widget

* move grid component to widget folder

* fix import in widget registry

* add sticky row in virtualized list

* add sticky container

* Fix Height of grid widget items container

* fix dragging of items in children other than template children

* update list widget

* update list widget

* Fix padding in list widget

* hide scrollbar in list widget list

* fix copy bug in list widget

* regenrate enhancement map on undo delete widget

* Use enhancementmap for autocomplete in list widget

Basic styles for list widget scrollbar

* add custom control in widget config

* minor commit

* update scrollbar styles

* remove unused variable

* fix typo in custom control

* comment out test cases

* remove unused imports

* remove unused imports

* add JSON stringify in interweave

* add noPad styling in dragLayer for noPad prop

* implement grid gap

* add list item background color prop

* add white color in color picker control

* fix gap in last list item

* remove onBeforeParse in textcomponent

* remove virtualization in grid widget

* allow overflow-y

* add onListItemClick action

* add beta label

* add pagination

* fix actions in pagination in list widget

* add list widget icon

* add list background color default value

* remove extra div

* fix pagination issue

* fix list widget crashing on perpage change

* extract child operation function to widgetblueprint saga

* refactor enhancements

* add enhancement hook

* refactor propertyUpdate hook enhancment

* remove enhacement map

* revert renaming ads to alloy

* add autopagination

* Cleanup unused vars

Re-write loop using map

Fix binding with external input widget

* update default background color

* remove unnessary scrol + fix pagination per page

* remove console.log

* use grid gap in pixel instead of snap

* fix list widget tests for binding

* add tests for on click action and pagination

* remove unnecessary imports

* remove overflow hidden in list component

* Add feature to enable template actions

* update property pane help text for list widget

* disable pagination in editor view

* update property pane options

* add test case for action

* uncomment tests

* fix grid gap validation

* update test cases

* fix property pane opening issue for list tempalte

* Disable form widgets in list widget

* fix template issue for actions

* add validation tests for list data

* update starting template

* add selectedRow + enable pagination in edit mode

* remove extra padding in list widget + popper fix on settingDisabled

* add stop propagation for button click

* fix click event in edit mode

* disallow filepicker widget for list widget

* add test for list widget entity definition for selectItem

* remove unused imports

* fix test

* remove evaluated value for list child widgets

* add comment

* remove log

* fix copying bug in list widget

* add check for not allowing template to copy

* fix test

* add test for property pane actions

* remove unused import

* add draglayercomponent test

* add test for draggable component

* add test for evaluatedvalue popup

* add test for messages.ts

* add test for widgeticons

* add test for property pane selector

* add test for widget config response

* start testing widget configresponse

* add test for enhancements in widget config

* add test for codeeditor

* add test for base widget + list widget

* add test for executeWidgetBlueprintChildOperations

* remove unused import

* add test for widget operation utils

* remove unused import

* add test for handleSpecificCasesWhilePasting

* remove unused function

* remove unused import

* add empty list styling

* resolve all review comments

* fix message test

* add test for widget operation utils

* fix merge conflicts

* move validations in property config

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-04-23 11:13:13 +05:30
Paul Li
d099a3954e [Bug] : Input widget validation issues#3860
-- Rewrite the validation for number type
2021-04-22 04:32:23 -04:00
vicky-primathon.in
1474aa01e3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-21 21:27:55 +05:30
vicky-primathon.in
e9055a6521 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/multi-select-values-reset 2021-04-21 21:26:19 +05:30
vicky-primathon.in
eea0472a72 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/filepicker-clear-files 2021-04-21 21:25:47 +05:30
Hetu Nandu
4d73e7e0b3
Widget validation for nested property paths (#3947) 2021-04-21 20:04:25 +05:30
vicky-primathon.in
99ea7db01b Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-15 10:44:46 +05:30
vicky-primathon.in
1e6a0e8e92 Fix filepicker widget delete file not working
Added cypress test case to test selected file deletion works
2021-04-13 16:55:50 +05:30
vicky-primathon.in
53d1333530 use derivedProperty selectedIndexArr instead of computing selectedIndexes 2021-04-09 15:50:48 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
Rishabh Saxena
244930dd69
Add support of component unit testing (#3828)
Update jest config, add msw hooks
2021-04-02 15:17:16 +05:30
Abhinav Jha
28921e0324
Fix table width on drag (#3839) 2021-04-02 13:48:30 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Aswath K
b447aa8345 Allow removing filter on Dropdown Widget 2021-03-31 00:35:17 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 21:17:22 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)"
This reverts commit 3437c16ef0.
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 15:28:52 +05:30
Abhinav Jha
5b3547c104 Fix filter condition functions
Fix issue where column properties don't update based on filters and sorting and search
2021-03-26 01:18:40 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670)
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string (#3397) 2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-24 14:33:48 +05:30
Vicky Bansal
06231e0f5f
Fix crash on Tabs property bindings (#3640) 2021-03-24 14:28:00 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-24 14:23:39 +05:30
vicky-primathon.in
354405d975 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-18 13:01:36 +05:30
Vicky Bansal
1195a0b694
Reset selected row(s) when table data is changed (#3576)
* Fixed selected row resets when table data is changed

Added cypress test case to test selected row resets when table data changes

* Fixed cypress test case
2021-03-17 17:27:38 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057)
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Vicky Bansal
812344c439
Persist Table Widget cell height to use as default in deployed app view (#3537) 2021-03-15 14:34:33 +05:30
Vicky Bansal
030269f684
Display the date column output correctly in table when using JS toggle for Display date format 2021-03-15 10:59:01 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798)
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-13 19:54:45 +05:30
vicky-primathon.in
c952e9b10d Remove unnecessary scrollbar from inside table widget 2021-03-13 12:06:02 +05:30
Nikhil Nandagopal
3b2072eeb9
Merge pull request #3055 from appsmithorg/fix/rte-newline
Added defaultText and defaultHTML properties in RTE
2021-03-12 17:38:58 +05:30
Nikhil Nandagopal
261dfc308c
Merge pull request #3514 from appsmithorg/fix/file-picker
[Fix] Made bade 64 encoding the default type for S3
2021-03-12 16:29:05 +05:30
vicky-primathon.in
3da86b33fe Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-03-12 15:24:51 +05:30
Nikhil Nandagopal
6bdd39c4b8 minor fixes 2021-03-12 14:47:42 +05:30
Nikhil Nandagopal
dbb16775de updated type to enum 2021-03-12 14:43:47 +05:30
Nikhil Nandagopal
11c8d4f34b made files a derived prop to change based on the file data type
added file type
2021-03-12 14:34:05 +05:30
Nikhil Nandagopal
d7a5f36fea Made bade 64 encoding the default type for S3
Added a data field for file pickers that is filled based on the property pane value
2021-03-12 13:44:32 +05:30
Abhinav Jha
246f7de444
Preserve Table Column properties when evaluations fail (#3495)
* When there is a cyclic depenency, the table data is processed as s string, leading to incorrect column computations and a render loop. Fixed this by bailing out when table data is a string, as further computations are moot
2021-03-12 12:00:38 +05:30
Hetu Nandu
a885fc8d3b
Fix chart data migration issues (#3458) 2021-03-09 20:05:42 +05:30
Ashok Kumar M
4781f1096c
Fix: Modal Size gets cut in smaller screens. (#3441) 2021-03-09 11:27:44 +05:30
Abhinav Jha
0a7bf6d0d3
Deprecate UPDATE_WIDGET_PROPERTY action (#3392)
* Deprecate UPDATE_WIDGET_PROPERTY action

* Handle JS property toggle independently
2021-03-09 11:00:57 +05:30
Hetu Nandu
6898a0bbd5
Fix for Table onPageSizeChange trigger executing when not defined (#3422) 2021-03-08 14:34:00 +05:30
Vicky Bansal
c4d6405981
Fix: RTE Error (#3385)
* Added defaultText property for text type validations to fix invalid data type beings passed to RichTextEditor component

* removed text and defaultValue properties from widget property validation map
2021-03-04 16:21:58 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-04 10:54:47 +05:30
Vicky Bansal
d3c2c02745
Fix: Tabs Widget crashes when data is invalid (#3235)
* Fixed tabs data validation and added check to ensure tab property is accessible when tabs array is not empty

* added isVisible property in validations
2021-03-03 11:29:02 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function"
This reverts commit 54f158694f.
2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
vicky-primathon.in
950c7b93bb Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-26 16:35:12 +05:30
Vicky Bansal
5e8805b40a
Feature: selectedOptionLabel and selectedOptionLabels in Dropdown widget (#3205) 2021-02-26 11:54:25 +05:30
Vicky Bansal
118467c5bb
Feature: Show/Hide Tabs in Tabs Widget (#3192)
* Added functionality to show/hide a tab from tab property pane controls

* Added isVisible property in tabs widget default value

* Passing visible tabs to component from widget. Added missing widgetId
2021-02-26 11:47:21 +05:30
Abhinav Jha
a1bda002c0 Fix issue where renaming table data keys did not delete the previous key 2021-02-25 21:36:27 +05:30
Hetu Nandu
c2646a8863
Use property config for trigger properties (#3217)
* Use triggerPaths and remove isDynamicTrigger argument

* Remove triggerMaps from widgets

* Fix property updates
2021-02-25 19:30:02 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212)
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
2021-02-25 17:21:54 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186)
* Fix selected row issue in view mode

* Remove un-select feature
2021-02-24 15:59:19 +05:30
vicky-primathon.in
b474442ec7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-23 18:11:14 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889)
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-23 18:05:09 +05:30
vicky-primathon.in
8b334c3064 Removed passing formatType to component as html is default output 2021-02-23 12:10:19 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074)
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-02-23 10:19:14 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
Hetu Nandu
447f458656
Minor Api pane design and logic fixes (#3091) 2021-02-22 11:45:02 +05:30
vicky-primathon.in
c5a689b560 Added support for markdown type in RTE 2021-02-19 16:57:54 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing.
Fix default input type
2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
vicky-primathon.in
2636c70410 Handled commont property for default text input type 2021-02-18 15:56:40 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Hetu Nandu
e1d43992b2
Fix default value reset issue (#2861) 2021-02-17 20:32:36 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999)
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value
Added migrations to handle the same
2021-02-15 17:19:33 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Rishabh Saxena
8c72e901ee
Fix input's onSubmit action being triggered if its validation is failing (#2960) 2021-02-10 13:13:41 +05:30
Pawan Kumar
c78a578247
Fix: Cannot read property 'closeModal' of null (#2911)
* update filepicker uppy implementation

* update uppy implementation

* fix uppy implementation

* remove typo

* remove consoles

* remove unused variable

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-10 10:29:47 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-08 13:00:01 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link
Fix/docs link
2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-03 17:00:19 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789)
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
2021-02-02 20:12:49 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
Rishabh Saxena
8e459a0c6b
validate map center and markers (#2488) 2021-01-19 12:59:15 +05:30
Hetu Nandu
94cae231c1
Make sure Table selected row is not set to undefined on mount (#2518) 2021-01-12 11:45:08 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
2021-01-04 15:46:08 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293)
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
2020-12-22 08:27:57 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165)
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:30 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985)
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865)
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-27 14:18:38 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884)
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-26 16:51:23 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab
Fix selectedTab binding issue
2020-11-24 19:06:10 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
03f97c0323
Fix: Maps widget crash on wrong initial location datatype (#1854) 2020-11-24 14:13:45 +05:30
vicky-primathon
3b85cc8222
Added defaultSelectedRow property in table widget so that users can configure default selected row(s) (#1684)
* Added defaultSelectedRow property in table widget so that users can configure default selected rows

* Cypress test cases added to test default row selection in table widget

* Fix defualtSelectedRow property's evaluation type

* Fix default select row type

* Set default selected row when resetting user selected rows

* Use defaultSelectedRow when no user selected row in table
2020-11-20 13:13:39 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625)
Implements #1575
2020-11-12 16:53:32 +05:30
Hetu Nandu
3a84af82ed
Fix critical issues (#1686)
Fixes #1683
Fix for dropdowns with option not being an object crashes dropdown and stops eval
Fixes #1656 #1657
Fix issue where updateWidgetProperty would get called without a widgetId
2020-11-11 17:02:14 +05:30
Hetu Nandu
a52c5df987 Fix form widget eval loops for arrays 2020-11-10 13:23:18 +05:30
vicky-primathon
fd12e907af
Map not resetting to location selected fix. Location map to search location. (#1619) 2020-11-06 20:39:35 +05:30
vicky-primathon
54a6ca0850
Fix/table widget pagination changes (#1298) 2020-11-06 16:45:47 +05:30
Abhinav Jha
e14f23c31d
Handle null regex parts in input widget regex function (#1569) 2020-11-04 19:49:46 +05:30
Abhinav Jha
1747390183
Fix: All canvas widgets should have no container styling applied (#1564) 2020-11-04 18:58:21 +05:30
Abhinav Jha
120c2da507
Fix: Tabs Widget (#1532)
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint
2020-11-03 18:32:50 +05:30
vicky-primathon
1c4adf84a1
Fix/multi select dropdown (#1295)
* Cypress test locator fix

* Multi select dropdown values initialization fixed

* Reverted test case selector change

* Using lodash isEqual since values can be object
2020-11-03 10:49:27 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356)
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
2020-10-29 16:44:39 +05:30
vicky-primathon
aa9bc58a90
Fix/map crash (#1301)
* Adding default map center to fix map crash issue

* API key removed
2020-10-26 15:31:01 +05:30
Hetu Nandu
a16372fed1
Fix Dropdown widget selection (#1340) 2020-10-22 01:15:02 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
Shrikant Sharat Kandula
920b38da90
Resolve conflict with master (#1246)
* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* added binary raw data to be set for files picked (#1211)

* added binary raw data to be set for files picked

* spread options before modifying to maintain immutability

* Add isFromInvite field to create_USER event (#1223)

* Adding dummy commit to trigger build

* added extra information to execute action call (#1244)

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-10-19 16:36:44 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
satbir121
8bf80fe507
Google Recaptcha integration for button and form button widgets. (#1118)
* Adding base code for google re-captcha.

* Removing recaptcha as well

* Adding recaptchaToken on Button.

* Fixing updateMetaProperty errors.

* Handling recaptcha generation failed case.

* Adding a message for recaptcha token gen fail

* Rename setRecaptchaToken

* Adding loading state for recaptcha button

* Adding googleRecaptchaKey as a Btn prop

* Adding the bound functions in widgets

* Removing unused vars.

* Handling google recaptcha key error.

* Adding proper messages for
2020-10-12 18:31:19 +05:30
Hetu Nandu
9ac935c424
Fix release cleanup issues (#1132) 2020-10-11 19:02:02 +05:30
dodococo
17028a3f86
Input Widget: Parse regexp before regex validation (#884)
Fixes #697
2020-10-07 12:03:53 +05:30
Hetu Nandu
bf2b4efbfd
Fix for action execution (#1023) 2020-10-06 22:17:16 +05:30
Hetu Nandu
8b75e1c8f4
Local meta state in widgets (#851) 2020-10-06 14:31:51 +05:30
Ajay Kumar
9fce3912ea
Fix image widget not showing default image when image property is invalid (#882)
Fixes: #760
2020-10-06 12:06:57 +05:30
Hetu Nandu
858db968f6
Fix issue with radio widget crashing (#922)
* fix types

* Options Validaor checks for empty values

Fixes: #662

Co-authored-by: Sanchit Jain <171220040@nitdelhi.ac.in>
2020-10-05 12:57:44 +05:30
MartinT
58b759bd6a
fix: input widget number validation #768 (#917) 2020-10-05 12:36:24 +05:30
Nicholas
052bd2a5e3
Fix triggering of onChange when value is the same (#892)
Fixes: #710
2020-10-03 15:22:59 +05:30
satbir121
53c616b747
Video URL and Auto Play labels changed. Removed onStart. (#793)
* Removing onStart

* Changing auto play and url label
2020-09-29 15:30:55 +05:30
satbir121
15f84203c7
Video widget (#684)
* Working version of video player.

* Adding default video url

* Reducing the default widget of video widget

* Fixed tests

* Adding video icon.

* Removing commented code.

* Adding playState, onPause, onStart, onEnd.

* Adding onPlay event.

* Fixing onPlay

* Adding isVisible field.

* Changing video icon.

* Fixing Popover table video.

* Adding an error message for no url.
2020-09-26 18:29:33 +05:30
Satbir Singh
d444b2e169 Adding onClick property for image widget. 2020-09-18 15:42:57 +05:30
Abhinav Jha
0b87c7431b
Fix issue where tabs are lost when the user enters an invalid tabs value (#569) 2020-09-18 10:52:54 +05:30
Abhinav Jha
436f190555
Feature: Widgets: Cut-Copy-Paste-Delete shortcuts, undo-delete facility (#500) 2020-09-16 15:58:01 +05:30
Nikhil Nandagopal
4995706679
Fix chart data evaluation (#548)
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval

* added a migration for older charts that have their data as strings

* flagged column actions as an action trigger to avoid evaluating it

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-15 22:24:15 +05:30
Hetu Nandu
f09b717b38
Retry dynamic import and lazy promises (#543) 2020-09-15 12:29:58 +05:30
Nikhil Nandagopal
c0fcdef4b6 Merge branch 'master' into release 2020-09-11 17:08:15 +05:30
vicky-primathon
2cb7c7be97
Reset selected rows when table data is modified (#536) 2020-09-11 17:07:33 +05:30
vicky-primathon
e343f9deaa
Table Widget: Date column type: user defined input and display format (#409) 2020-09-11 16:10:15 +05:30
Nikhil Nandagopal
02c3c199ac deprecated selectedOptionValueArr 2020-09-10 12:51:44 +05:30
Hetu Nandu
96643507ec
Merge branch 'master' into release 2020-09-09 12:55:21 +05:30
vicky-primathon
fb34609c89
selectedRowIndexes changed to selectedRowIndices (#516)
Data type of selectedRowIndices changed to array of numbers
2020-09-09 12:42:15 +05:30
vicky-primathon
da9274de10 Feature: Table Widget - multi row selection (#507) 2020-09-09 11:16:06 +05:30
vicky-primathon
f7931701d8
Feature: Table Widget - multi row selection (#507) 2020-09-08 18:34:51 +05:30
Nikhil Nandagopal
0b22fc67b3
Updated sentry sdk (#461)
Integrated react router for better performance reporting
Added Sentry Profiler for editor, appviewer and widgets

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-28 22:53:07 +05:30
vicky-primathon
8a0805d77f
Fix: Table widget actions header scrollbar padding (#353)
* Table header scrollbar padding removed. 
* Table row font size changed based on compact mode.
2020-08-28 15:25:20 +05:30
vicky-primathon
a8e6b268ab
Setting table widget filteredTableData after reset. (#425) 2020-08-26 11:11:18 +05:30
satbir121
bccef563c4
Alignment of icon button is to right (#372) 2020-08-24 11:12:19 +05:30
Hetu Nandu
a2b1d3442f
Table widget selected row initial value fix (#401)
* Set initial value as empty object

* log debug
2020-08-21 22:13:02 +05:30
vicky-primathon
17af152148
Table Widget: Filter updates (#355)
- Show symbol signifying selected filters in table widget
- Show callout to prompt users to change column data types for accurate filter operations
2020-08-20 15:00:19 +05:30
vicky-primathon
222ba74996
Table widget initializing selectedRow value to show up in autocomplete (#359) 2020-08-20 12:09:16 +05:30
vicky-primathon
714d107a71
Table column sorting changes (#360)
- Sort icon correction
- Allow users to remove sorting
2020-08-20 12:08:16 +05:30
Hetu Nandu
590afa7a30
Fix query response state (#348) 2020-08-19 10:07:20 +05:30
vicky-primathon
33cd1ac1d9
Fix-table filtered data calculations (#342)
* Update table widget's filtered data calculations to avoid recursive dataTree evaluations

* Stringify removed from Table component as data is already checked inside TableWidget

* Vertical scrollbar removed from Table Widget. Stop column sorting by stopping event propagation when clicking column menu icon.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2020-08-18 17:00:26 +05:30
Hetu Nandu
bb369e6bdf
Fix overflowing multi select widget (#320)
Co-authored-by: Akash N <akash@codemonk.in>
2020-08-18 13:11:53 +05:30
akash-codemonk
664d55053d
Add email validation for email input (#276)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-08-17 19:53:57 +05:30
Abhinav Jha
28e3831862
Fix: Jump issue of APIPane fields (#330) 2020-08-17 15:13:25 +05:30
vicky-primathon
cf91361637
Fix: table compact mode to persist and saved from canvas editor (#316)
* Table widget compact mode to persist after reload

* Table widget compact mode to be saved from canvas editor
2020-08-17 13:03:37 +05:30
vicky-primathon
b7815006a1
Fix: selection of correct table row data after sort, search and filter (#315)
* Table fix sort, search and filter methods to set correct selectedRow after these methods are applied

* Filtering table data with the latest filters, to correctly select the row

* Setting initial filteredTableData value

* Updating filteredTableData when tableData is updated
2020-08-17 13:01:17 +05:30
vicky-primathon
02a2d8e0a3
Fix-table widget compact mode row height (#285)
* Table column header made sticky. Scrollbar background changed to be in consistent with the background for table body scroll and table header scroll

* Row height changed for short compact mode

* New "Tall" row size
2020-08-13 22:11:08 +05:30
Abhinav Jha
2cb5e4442b
Tab Widget Fixes (#293)
* Issue: Tabs widget's child canvas widget's minHeight is not updating

* Fix: Warning removed for unused onTabChange event handler by removing event handler from props passed to ScrollableCanvasWrapper

* Removed tab container not working as droppable component if added again with same name fixed

* Selecting first tab as default tab when no tab is selected in tabs widget. Used getNextEntityName funciton to generate new tab name
2020-08-13 13:38:16 +05:30
vicky-primathon
e1676beba2
Table filters to be accessible in publish mode (#273)
Filters are only available on the client. This results in filters being available in published mode.
2020-08-13 13:26:10 +05:30
vicky-primathon
c0527a4816
Reset page number when searching in table widget (#274) 2020-08-12 10:52:19 +05:30
vicky-primathon
76bc382a2d
Table Widget UI Filters (#61)
New Table Widget Feature
- Filter columns
- Misc table widget bug fixes
2020-08-10 16:46:13 +05:30
vicky-primathon
6a53e1e0ed
Added compact modes to table widget UI (#222)
New Feature: Table Widget compact rows
Users can now use different sizes for rows in the table widget
2020-08-10 15:31:36 +05:30
NandanAnantharamu
05f190c102
Feature/entity browse (#220)
# New Feature: Entity Explorer
- Entities are actions (apis and queries), datasources, pages, and widgets
- With this new feature, all entities in the application will be available
  to view in the new entity explorer sidebar
- All existing application features from the api sidebar, query sidebar, datasource sidebar and pages sidebar
  now are avialable on the entity explorer sidebar
- Users are now able to quickly switch to any entity in the application from the entity explorer sidebar.
- Users can also search all entities in the application from the new sidebar. Use cmd + f or ctrl + f to focus on the search input
- Users can rename entities from the new sidebar
- Users can also perform contextual actions on these entities like set a page as home page, copy/move actions, delete entity, etc from the context menu available alongside the entities in the sidebar
- Users can view the properties of the entities in the sidebar, as well as copy bindings to use in the application.
2020-08-10 14:22:45 +05:30
vicky-primathon
c68114331c
Feature/table ui sort columns (#238)
* Added sorting functionality in table widget

* Removing sorting for Images and Video column types

* Code review changes incorporated
2020-08-10 12:15:31 +05:30
Hetu Nandu
0e7c0c3ce4
Widget fixes (#242)
* fix table styles

* rich text editor fix

* Fix action panes showing as blank

* correct fix this time

* cleanup

* default search in table

* Fix for text widget heading style

* Fix for table widget filtered table search

* Another approach to see if app has been created

* Fixes in styles of table and text
2020-08-07 23:39:54 +05:30
akash-codemonk
e265a1cfa3
Add missing isDisabled prop to filepicker, radio and dropdown components (#231) 2020-08-07 18:47:15 +05:30
Nikhil Nandagopal
9b867e4fe0 added on Tab selected for tab widget 2020-08-07 12:53:15 +05:30
Nikhil Nandagopal
1df7599d5e
Fix/tab widget (#233)
* Added information to setup domain

* Fixed incorrect var reference

* Updated documentation message

* Updated env template

* updated template

* removed debug echo

* Updated Script

* Updated Text

* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed

* Updated docker installation explanation

* added a question to skip custom domain if user is installing locally

* Inverted script question and

* Removed question to determine local installation

* Updated Popup CTA to Modal
Updated query templates to contain bindings
Added a message to display on API / Query errors

* updated styles for evaluated value
updated styles for auto complete

* added spaces to questions

* grouped data tree functions together in autocomplete

* Updated autocomplete styles

* Updated property pane styles to become more dense

* Fixed lightning menu styling

* fixed tests

* Fixed Cypress test

* added property to show / hide tabs

* fixed selected tabs not updating

* fixed cypress tests for tabs

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-07 11:49:36 +05:30
Nikhil Nandagopal
8118b2d8c0
Fix/copy changes (#230)
* Added information to setup domain

* Fixed incorrect var reference

* Updated documentation message

* Updated env template

* updated template

* removed debug echo

* Updated Script

* Updated Text

* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed

* Updated docker installation explanation

* added a question to skip custom domain if user is installing locally

* Inverted script question and

* Removed question to determine local installation

* Updated Popup CTA to Modal
Updated query templates to contain bindings
Added a message to display on API / Query errors

* updated styles for evaluated value
updated styles for auto complete

* added spaces to questions

* grouped data tree functions together in autocomplete

* Updated autocomplete styles

* Updated property pane styles to become more dense

* Fixed lightning menu styling

* fixed tests

* Fixed Cypress test

* added property to show / hide tabs

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-06 14:31:28 +05:30
akash-codemonk
bfa15671d4
Add space around documentation (#229)
Authored by: @akash-codemonk
2020-08-06 12:06:12 +05:30
vicky-primathon
0474e339f3
Removed table widget row deselection (#209) 2020-08-03 19:14:34 +05:30
vicky-primathon
527bb5898a
Fix-The tabs should scroll with the increase in the number of tabs. (#131)
* Fixed tabs widget bugs and other updates:
1. Moved drag icon to the left of tab name field in the tabs widget property pane
2. Change drag icon
3. Add scroll when the tabs occupy more width than the width of tabs widget.
4. Add selected tab name validation.
5. Hide overflow tabs.
6. Avoid vertical scrollbars in tabs widget header
2020-07-29 14:31:17 +05:30
Abhinav Jha
08d2a94768
Change derivedpropertiesmap for selectedRow to use filtered table data (#173)
* Add a new meta property to tableWidget called filteredTableData which will be used by the table to filter

* Use derived properties to update filteredTableData

* Check if search is done via actions, if so, filteredTableData is the same as tableData
2020-07-29 11:45:06 +05:30
vicky-primathon
e794c916e6
Fix-Row to be selected when button is clicked and row is not selected (#167)
* Row selection when button is clicked and row is not selected

* Added columnActions to useMemo for columns computation to support live action name updated and action change support
2020-07-28 19:56:27 +05:30
vicky-primathon
8fb0dc02ad
Fix-Search component in Table widget updated with support for clearing search data (#96)
* Added Button component in Table widget for actions

* Action button state loading added for Table widget

* Action button font-weight made as normal

* Created header for common functionalities in Table Widget

* Client side searching added in Table Widget. Action created for server side searching also.

* Columns visibility feature initial commit

* Column visibility list added in Table Widget

* Changed pagination designs in accordance with new layout. This enable user to jump page as well.

* Using colors values from constants

* Table widget pagination, numeric input page number clamped between 1 and total pages

* Adding tool tip to truncated values in table widget. Added AutoToolTipComponent that adds tooltip when text is truncated.

* Table data download changes. Added downlaod icon and button to table widget.

* Table data download changes

* Table button loading state fixed. Table code refactored, rendering from props instead of state in ReactTableComponent

* Table widget action button alignment fixed

* Handled actions column changes

* added proper keys to useMemo for react table widget

* Download table data as CSV implemented

* table data download, unused code removed

* Code refactors and added dependency map with meta props and table data for computing columns

* Table UI breakages on scroll and empty cells fixed

* Handled empty rows in table widget

* Fixed last row cut issue

* Code review changes

* Code review changes

* Added table widget component heights as enum

* code review changes

* Search component in Table widget updated with support for clearing data, renamed properties

* Opening image in new tab on clicking in table widget

* Fixed table craching due to empty data filtering

* Empty extra space on loading removed in table widget

* Removed stopping of event propagation on table widget action button click

* Fixing for test cases

* Table header UI overflow fixed

* Clearing selected row on searching data in table widget

* fix for cypress test

* Table crash issue fix

* searchKeyword renamed to searchText. searchText added to entity definitions

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-24 19:28:28 +05:30
vicky-primathon
a2673aaa87
Fix-Open image in new tab on clicking it in table widget. (#119)
* Added Button component in Table widget for actions

* Action button state loading added for Table widget

* Action button font-weight made as normal

* Created header for common functionalities in Table Widget

* Client side searching added in Table Widget. Action created for server side searching also.

* Columns visibility feature initial commit

* Column visibility list added in Table Widget

* Changed pagination designs in accordance with new layout. This enable user to jump page as well.

* Using colors values from constants

* Table widget pagination, numeric input page number clamped between 1 and total pages

* Adding tool tip to truncated values in table widget. Added AutoToolTipComponent that adds tooltip when text is truncated.

* Table data download changes. Added downlaod icon and button to table widget.

* Table data download changes

* Table button loading state fixed. Table code refactored, rendering from props instead of state in ReactTableComponent

* Table widget action button alignment fixed

* Handled actions column changes

* added proper keys to useMemo for react table widget

* Download table data as CSV implemented

* table data download, unused code removed

* Code refactors and added dependency map with meta props and table data for computing columns

* Table UI breakages on scroll and empty cells fixed

* Handled empty rows in table widget

* Fixed last row cut issue

* Code review changes

* Code review changes

* Added table widget component heights as enum

* code review changes

* Search component in Table widget updated with support for clearing data, renamed properties

* Opening image in new tab on clicking in table widget

* Fixed table craching due to empty data filtering

* Empty extra space on loading removed in table widget

* Removed stopping of event propagation on table widget action button click

* Table header UI overflow fixed

* Clearing selected row on searching data in table widget

* fix for cypress test

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-24 16:02:31 +05:30
vicky-primathon
4f47a8ad3f
Feature/table ui download data (#52)
* Created header for common functionalities in Table Widget

* Client side searching added in Table Widget. Action created for server side searching also.

* Columns visibility feature initial commit

* Column visibility list added in Table Widget

* Changed pagination designs in accordance with new layout. This enable user to jump page as well.

* Using colors values from constants

* Table widget pagination, numeric input page number clamped between 1 and total pages

* Adding tool tip to truncated values in table widget. Added AutoToolTipComponent that adds tooltip when text is truncated.

* Table data download changes. Added downlaod icon and button to table widget.

* Table data download changes

* Download table data as CSV implemented

* table data download, unused code removed

* Code review changes

* code review changes

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-20 11:34:05 +05:30
Nikhil Nandagopal
70c4dd5964
Fix/deploy script (#111)
* Added information to setup domain

* Fixed incorrect var reference

* Updated documentation message

* Updated env template

* updated template

* removed debug echo

* Updated Script

* Updated Text

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-07-17 15:29:28 +05:30
vicky-primathon
290bb8d57c
Table UI breakages on scroll and empty cells fixed (#60)
* Added Button component in Table widget for actions

* Action button state loading added for Table widget

* Action button font-weight made as normal

* Table button loading state fixed. Table code refactored, rendering from props instead of state in ReactTableComponent

* Table widget action button alignment fixed

* Handled actions column changes

* added proper keys to useMemo for react table widget

* Code refactors and added dependency map with meta props and table data for computing columns

* Table UI breakages on scroll and empty cells fixed

* Handled empty rows in table widget

* Fixed last row cut issue

* Code review changes

* Added table widget component heights as enum

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-16 16:09:07 +05:30
vicky-primathon
7114936554
Fix/action btn loading in table widget (#28)
* Added Button component in Table widget for actions

* Action button state loading added for Table widget

* Action button font-weight made as normal

* Table button loading state fixed. Table code refactored, rendering from props instead of state in ReactTableComponent

* Table widget action button alignment fixed

* Handled actions column changes

* added proper keys to useMemo for react table widget

* Code refactors and added dependency map with meta props and table data for computing columns

* RenameColumnHeader function renamed to TableHeaderCell

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-14 13:25:46 +05:30
Abhinav Jha
5ec134eae7
Use Google Maps API key from configs (#76) 2020-07-10 13:05:27 +05:30
Abhinav Jha
94b28311c6
Use injected configuration from Nginx at runtime instead of build time (#30)
* Use envsubst and nginx templates to generate nginx configs which can substitute environment variables and inject into the index.html file

* Fix path in dockerfile. Add .gitignore and .env.example files. Fix nginx-linux template.

* Add all environment variables. Add prefix to all environment variables. Update scripts to attempt to substitute all environment variables with the prefix

* Setup dockerfile to execute a bash script. use env.example for fetching environment variables in development

* Toggle features based on injected configs. Fix nginx template substitution script.

* Update env.example file

* Remove debug code from start-nginx.sh

* Fix nginx config templates by adding quotes by default. Fix sed regex to include numerals. Toggle social login buttons on Login page based on the config.

* Update rapid api environment variable name. Toggle oauth buttons based on config in SignUp page. Update .env.example to be a union of server and client environment variables

* Adding a Map disabled message on Map widget

* Adding links to Privacy policy and TNC

* Use REACT_APP_ env variables with higher priority over injected config variables for toggling features

* Update netlify.toml by commenting out the build environment variables

* Remove env variables not required by the client

* Remove start-storybook entry from package.json

* Fix netlify.toml. Fallback algolia configs

* Add contexts to netlify.toml for successful deploys. Swith to using APPSMITH_MARKETPLACE_URL as the toggle for RapidAPI feature on the client. Remove comments in nginx config templates. Fix template used in dockerfile.

Co-authored-by: Satbir Singh <apple@apples-MacBook-Pro.local>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
2020-07-07 15:52:17 +05:30
vicky-primathon
1e67ea21c0
Widget on error action binding (#22)
Changes to fix the the UI/functionality breaking in widget action selectors when the onError action is configured first for an api or a query type action. Remove validation widget action selectors.
2020-07-06 13:46:42 +05:30
vicky-primathon
49ff42ea72
Feature/table ui update search (#13)
* Created header for common functionalities in Table Widget

* Client side searching added in Table Widget. Action created for server side searching also.

* added onSearch to getTriggerPropertyMap

* debouncing search fixed

* Client side search key made as case insensitive and property of table search value names as searchKey

* Removed unused function form SearchComponent

* Feature/table ui update column visibility (#14)

* Columns visibility feature initial commit

* Column visibility list added in Table Widget

* Colors used from constants

Co-authored-by: Arpit Mohan <me@arpitmohan.com>

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-03 13:56:04 +05:30
vicky-primathon
5df9395003
Created header for common functionalities in Table Widget (#12)
Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-02 11:56:01 +05:30
Satbir Singh
f55357029c Removed syncfusion completely. 2020-06-29 09:10:19 +00:00
Hetu Nandu
fb65b204a8 JSON stringify fixes 2020-06-25 10:04:57 +00:00
Satbir Singh
e2a30da1c3 Merge branch 'master' into 'release'
Backmerge master to release.

See merge request theappsmith/internal-tools-client!754
2020-06-18 16:24:21 +00:00
Hetu Nandu
549b9ba0ad Fix dropdown default value issue 2020-06-18 16:30:05 +05:30
Abhinav Jha
fdd826d929 Remove console warnings like react hook dependency warnings and unused vars 2020-06-17 19:23:01 +05:30
Vicky Bansal
5643a53c9f Fixing table bugs 2020-06-16 07:37:39 +00:00
Nikhil Nandagopal
05bb520479 Merge branch 'release' into fix/form 2020-06-10 17:50:39 +05:30
Nikhil Nandagopal
2df86b79e9 fixed type def
resolved mr comments
2020-06-09 18:40:42 +05:30
Nikhil Nandagopal
9becaa9a9f made form data visible at the top level 2020-06-09 17:34:38 +05:30
Nikhil Nandagopal
8501ebe670 added date format to date picker 2020-06-09 14:14:13 +05:30
Nikhil Nandagopal
8b0258b4b9 Merge branch 'release' into fix/bugs
# Conflicts:
#	src/pages/Editor/APIEditor/PostBodyData.tsx
2020-06-08 17:13:03 +05:30
Nikhil Nandagopal
b84384fa99 fixed filepicker not closing 2020-06-08 16:59:20 +05:30
Nikhil Nandagopal
dff9c60f9f fixed resize handles size
fixed body for url encoded form data
added defaults for dropdown and radio widget
added multipart type but hid it till we figure out logic
allowed number to be added to defaults of widgets
2020-06-08 16:39:13 +05:30
Hetu Nandu
e401844014 Fix Chart series data 2020-06-05 16:20:23 +00:00
Hetu Nandu
d9540f8927 Evaluated value popup 2020-06-04 13:49:22 +00:00
Satbir Singh
3b729bc470 Merge branch 'fix/react-table-widget' into 'release'
Fix/react table widget

See merge request theappsmith/internal-tools-client!599
2020-06-03 10:50:10 +00:00
Vicky Bansal
c2efa63eba Fix/react table widget 2020-06-03 10:50:10 +00:00
Hetu Nandu
973af1c5e7 Single series chart data 2020-06-02 11:27:24 +00:00
Hetu Nandu
2fb29290f1 Merge branch 'fix/chart-data-validation' into 'release'
Chart validations, Tabs add new tab issue fix

* Chart validation fixes
* Tab widget, adding new tab will display the same inside pane configurations

See merge request theappsmith/internal-tools-client!574
2020-05-29 06:07:56 +00:00
Vicky Bansal
747c3d5d8b Chart validations, Tabs add new tab issue fix 2020-05-29 06:07:56 +00:00
Satbir Singh
830184dda0 Merge branch 'release' of gitlab.com:theappsmith/internal-tools-client into fix/tweaks 2020-05-28 14:29:34 +05:30
Nikhil Nandagopal
3211b8c915 minor text changes 2020-05-25 15:02:01 +05:30
Satbir Singh
2aa6a91826 Same locators for widgets in publish and edit view 2020-05-21 11:45:12 +05:30