Commit Graph

5968 Commits

Author SHA1 Message Date
Souma Ghosh
686f3981d8
fix: JS option missing for some style items in table widget v2 (#16958)
* fix: JS option missing for some style items in table widget v2

* Review changes
2022-09-23 15:11:41 +05:30
Aswath K
995847cdef
fix: Action Selector menu goes out of viewport (#16878) 2022-09-23 10:46:26 +05:30
Pawan Kumar
c9bae7b769
fix: Camera widget is unable to capture high quality images (#16646)
* fix mobile bug

* fix

* add forceScreenshotSourceSize only for mobile
2022-09-23 10:27:00 +05:30
Aswath K
d62acb209a
fix: Issues with JS toggle (#16204)
* fix: unwanted JS toggle on Datepicker's firstDayOfWeek
* Remove JS toggle for properties that already accepts JS
* Enables the JS toggle button if the value is same that of defaultValue
2022-09-23 00:30:55 +05:30
Arsalan Yaldram
46b3627bac
feat: implemented slider widgets (#15712)
* feat: implemented slider widget from mantine ui

* fix: remove widget from widgetName

* fix: memoize marks, use primitives for rangeslider value

* fix: use theme accentColor, remove xs and xl size

* fix: renamed slider widget, added searchTags, parity properties

* feat: added labels to the slider widgets.

* fix: Rename SingleSlider components to Slider

* feat: added basic disabled state

* feat: added category slider widget, handled label callback function

* fix: Renamed slider widgets fixed imports and bindings.

* feat: widget redesign, added hover, focus, disabled states.

* feat: added isDirty meta property to the slider widgets.

* feat: Added onChange action triggers to the slider widgets.

* feat: added show marks label property for category widget.

* fix: fixed initial feedback on designs, issues.

* feat: added the new tabbed property pane improvements.

* feat: changes to the slider property panes.

* fix: removed show label on hover and add tooltip always on property.

* fix: slider sizes changed inline with the designs

* feat: added initial logos.

* fix: slider size subtext.

* feat: added show marks to number and range sliders.

* fix: Label will show one decimal point if step Size is in decimal.

* feat: added validations for the slider widgets.

* fix: remove mark dots when show marks is off, change icons.

* fix: addressed validations feedback.

* fix: added stepsize validation number widget & fixed top label aligning.

* fix: Long label styles.

* fix: wrapping removed for long labels, handled focus state.

* fix: remove overflow hidden.

* fix: added pointerEvents none to Marks.

* fix: added default value in the Number Slider widget.

* fix: refactor marks remove un-necessary function calls.

* fix: Review changes done.

* fix: remove transformstyles outside component.

* fix: remove old proprty pane config.

* fix: remove any type from widget files.

* fix: small code refactor validations category slider.

* fix: removed throttle, fixed slider setting to zero issue.

* fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue.

* fix: number and category slider fire events only if value has changed.

* fix: added 0 as default for the min value, range and number sliders.

* fix: remove tooltip always on from category slider.

* fix: minRange validation accept only numbers.

* fix: added old property pane method.
2022-09-22 21:26:50 +05:30
albinAppsmith
bb0c35f923
fix: Design system package conflict with babel-plugin-styled-components (#16881)
* fix: Design system package conflict with styled component babel-plugin-styled-components

* version update
2022-09-22 16:55:03 +05:30
Souma Ghosh
57f3b6fde5
fix: Table's last column doesn't resize properly (#16448)
* fix: Table's last column doesn't resize properly

* Adds comments to code responsible for dynamic resizing of last column width
Adjusts component width to account for widget padding
  - This fixes issue where last column goes outside the table container resulting in showing less padding-right for the last column cells

* Review changes

* Review changes

* Fix failing test
2022-09-22 16:45:00 +05:30
Souma Ghosh
172762bcc9
fix: Table filter issues (#16904)
* fix: Table Filter issues
- Filter reverts to previous operator upon removing a filter condition
- Removing a filter does not rightly update the filter value field
- Removing the second filter causes the table to crash

* Adds cypress tests for bug 12642 and 12638
2022-09-22 14:33:10 +05:30
Favour Ohanekwu
3e49ca175a
fix: cancelled execution causing multiple on page load execution failures (#16137) 2022-09-22 12:09:27 +05:30
akash-codemonk
1b43b16461
feat: fork templates inside an existing app (#14514) 2022-09-22 09:19:18 +05:30
Tolulope Adetula
42003b97b9
feat: parse CSV data using File Picker Widget (#16689)
* feat: user Papaparser for Parsing csv

* feat: enable dynamic typing

* Update cypress.env.json

* Revert "Update cypress.env.json"

This reverts commit 5ca9f43c8ad90c164b4ac68a9b3764eb9c4bd480.

* fix: reorder property pane

* feat: add helper text for property pane inputs (#16782)

* feat: improve helperText

* feat: add test for csv parsing in filePicker

* fix: proper types

* fix: add more test for helperText

* fix: type error

* fix: props issues

* fix: change file name

* fix: helper text

* fix: test
2022-09-21 13:59:17 +01:00
balajisoundar
56d58d8e55
fix: table editaction column should be disabled when injected (#16693) 2022-09-21 17:05:15 +05:30
Souma Ghosh
1dbcde6066
fix: Table interact-able columnTypes should not show in selectedRow (#16648)
* fix: Table interactable columnTypes should not show in selectedRow

* Review changes

* Update failing Cypress tests

* Remove comments
2022-09-21 16:28:11 +05:30
Souma Ghosh
5f0df66b91
fix: URL column in table widget not working correctly (#16425)
* fix: URL column in table widget not working correctly

* Adds cypress tests for URL column issue
2022-09-21 16:22:28 +05:30
Aman Agarwal
6d5fc58d71
fix: updated message changes for auth tab, capital texts (#16832)
* fix: updated message changes for auth tab, capital texts

* fix: updated icon color to text color
2022-09-21 15:48:43 +05:30
Dhruvik Neharia
fdbab9c15b
feat: Image Widget Reskinning (#16787)
* feat: Image Widget Reskin
- Update rotate and download control icons
- Add border radius and box shadow to control wrapper
- Multiple CSS fixes to follow the designs

* feat: Move rotate and download icons for image widget to separate files

* feat: change default object fit to cover for image widget

* style: use color variables from wds themes instead of constants/colors for image widget

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-21 15:11:04 +05:30
sneha122
44e08b096d
fix: fixes right body type not selected after curl import (#16549)
* fixes rght body type not selected after curlimport

* added apiContentType key in ActionConfiguration formData property

This commit fixes the bug https://github.com/appsmithorg/appsmith/issues/13978 and changes two files:
		* appsmith-server/src/test/java/com/appsmith/server/services/CurlImporterServiceTest.java
		* appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java

additionaly this commit fixes the Body type detection for REST APIs with GET method  when imported from cURL.

* Made changes to the casing of Header key 'content-type', now it is  HTTPHeader.CONTENT_TYPE standard -> 'Content-Type'. changed test cases accordingly.

* Made header-key check in assertHeader functions case insensitive in CurlImporterServiceTest.java

* removed wildcard imports and changed some comments

* changes according to PR review comments

* updated imports for APIPaneUtils

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Co-authored-by: manish kumar <manish@appsmith.com>
2022-09-21 09:40:36 +00:00
Keyur Paralkar
d3225b475d
fix: added a condition to check for accentColor (#16910) 2022-09-20 17:20:09 +05:30
balajisoundar
79073d82b7
fix: Migration to convert old defaultOptionValue expression to new one in Select & multi select widget(#16836) 2022-09-19 17:53:07 +05:30
Ayush Pahwa
e3f90db341
feat: grouping in console logs (#16698)
* fix: updated skip functionality

* update: type of logs to add occurence count

* update: reducer function to merge the new logs

* update: added dependance on last log's occurence count

* add: UI to show the occurence badge

* fix: added null check for dependency array

* update: omit occurence from compare fn

* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array

* fix: replaced forEach with reduce

* test: added functions for console log grouping

* feat: updated warning grouping color

* update: moved function to reducer file for jest tests
2022-09-19 06:29:04 +00:00
Rishabh Rathod
9a1fa98416
fix: Autocomplete now works with multiple bindings (#16314)
Fixes #16288
Fixes #16158
Fixes #16188
Fixes #15859
2022-09-19 11:02:06 +05:30
Favour Ohanekwu
d6fbdb15b9
feat: Linting in entity properties and methods (#16171)
* Initial commit

* Remove arrow function params from identifiers

* Remove invalid identifiers from extracted identifiers

* Remove invalid identifiers which are derived from function params and variable declarations

* Fix typo error

* Correctly remove invalid identifiers

* Remove invalid names from identifier list

* fix build failure

* Add Promise to list of unacceptable entity name

* Keep track of unreferenced identifiers in bindings

* Add Global scope object names as unusable entity names

* Keep track of unreferenced identifiers

* Prevent traversal of data tree for addition of new paths and entities

* Sync linting in trigger fields

* Support linting of invalid properties

* Fix linting reactivity bug in trigger field

* Remove unused objects

* Fix conflict in merging

* Lint jsobject body for function change

* Remove unused map from tests

* Code cleanup

* Modify jest tests

* Update jest tests

* Fix cypress tests

* Code cleanup

* Support  linting of multiple bindings

* Set squiggle line as long as invalid property length

* Add jest tests

* Minor code refactor

* Move ast to shared repo

* Rename confusing identifiers

* Improve naming of functions and their return values

* move shared widget validation utils and constants to shared folder

* Add jest test for invalid entity names

* Add cypress tests

* Modify test comment

* Extend list of dedicated worker scope identifiers

* Resolve code review comments

* Resolve review comments

* Annonate code where necessary

* Code refactor

* Improve worker global scope object

* Code refactor

* Fix merge conflict

* Code refactor

* Minor bug fix

* Redundant commit to retrigger vercel build

* Add null checks to dependecy chain
2022-09-17 18:40:28 +01:00
Arsalan Yaldram
5e9cb1e447
feat: added WIDGET_DRAG event. (#16591)
* feat: added WIDGET_DRAG event.

* feat: add source and destination widget name.

* feat: add container types to source and destination.
2022-09-17 12:21:42 +05:30
Ankita Kinger
db32d520d1
fix: Optimize reflows on the applications list page (#16812)
* optimized the reflows

* removed unneccessary changes

* fixing a cypress test

* updated a cypress test
2022-09-17 11:38:28 +05:30
Ayush Pahwa
cc20cb2c20
fix: batching console log save calls in redux store (#16793)
* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array
2022-09-16 19:18:54 +00:00
Keyur Paralkar
cb84bc68c5
fix: chart widget color fontfamily (#16750)
* fix: re-run chart widget reskinning migration

* fix: addressed review comments

* fix: added a new check for versions

* fix: moved the originalDSL to the testDSLs

* chore: removed console statement

* fix: addressed review comments
2022-09-16 19:50:29 +05:30
Shrikant Sharat Kandula
fc983fc65e
Fix hard-coded mime.types location (#16826) 2022-09-16 16:37:23 +05:30
Shrikant Sharat Kandula
8d2ac7ec87
fix: Fix NGINX in start-https clashing with system conf (#16803) 2022-09-16 16:08:32 +05:30
Aman Agarwal
9dda476efa
fix: updated design for save as datasource button (#16700)
* fix: updated design for save as ds btn

* fix: updated the name for save/edit function
2022-09-16 15:57:35 +05:30
ChandanBalajiBP
2b70914f31
test: mysql datatypes cypress test cases (#16696)
* test: mysql datatypes cypress test cases

* test: cypress added comments with cleaner code

* updates w.r.t review comments

* fix 10th cases failure

* fix for test failing on CI

* fix for test failing on CI another way

* fix: address review comments
2022-09-16 11:51:25 +05:30
Dhruvik Neharia
88637de7aa
feat: Code Scanner Widget (#15990)
* feat: Add QR Scanner Widget Folder

* feat: Add QR Code Scanner in the Modal

* feat: Add viewfinder and close button

* QR generator

* feat: Change deafult camera in QR Scanner to back camera

* feat: remove qr generator widget from the registry

* feat: update qr scanner icon

* style: qr code scanner modal and video container, remove futile code

* feat: add camera switch control panel to qr scanner

* fix: update input devices list when the menu opens in qr scanner

* fix: viewfinder in qr scanner responsive on mobile

* feat: Add onCodeDetected event to the QR Scanner widget

* feat: Add QR Scanner to autocomplete's entity definitions

* feat: Add tooltip to QR Scanner

* fix: isDisabled for QR Scanner

* feat: Add icon and related properties to QR Scanner

* feat: Add QR Scanner search tags, remove futile styles

* feat: Add QR Scanner to themes, regex for button color

* test: Add one cy test for qr scanner

* revert: Remove qr scanner from system themes, will be merged in a seperate PR

* fix: typo 'disable' to 'disabled' in qr scanner widget

* test: add disabled and visibility cy tests for qr scanner

* test: add open and close qr scanner modal test

* feat: remove qr scanner image for tests

* feat: add TODO item for solving performance issues for QR Generator widget

* feat: shift from react-qr-reader to react-qr-barcode-scanner to enable barcode and QR scanning both

* feat: Update QR Scanner Widget to Code Scanner Widget

* test: update tests from qr scanner to code scanner widget

* refactor: move code scanner's property pane config to individual files

* fix: code scanner error message on permission denied

* feat: remove Modal.setAppElement from code scanner

* fix: hide code scanner scan animation overflow

* feat: code scanner modal close on escape and overlay click

* fix: code scanner video border radius on mobile

* test: scan qr test for code scanner

* feat: Add Modal.setAppElement for code scanner modal accessibility

* fix: typo in search tags of code scanner

* feat: update property pane content helper texts of code scanner

* feat: hide code scanner widget from explorer

* fix: code scanner events not working

* feat: hide code scanner widget from explorer

* feat: Show Code Scanner widget in Explorer

* fix: remove code scanner scan cypress test

* feat: Add barcode reader to search tags and put Modal.setAppElement inside a block in code scanner

Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:25:32 +05:30
Favour Ohanekwu
b28d7df7c6
fix: prevent duplicated fields in debugger logs (#16761)
* Improve dependency chain generation

* Update jest test
2022-09-16 05:42:20 +01:00
Keyur Paralkar
fff5c16f89
feat: table widget switch column type (#16262)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* feat: added switch column type to table widget

* fix: removed unused imports

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix: added unsaved marker and cypress test

* fix: alginment issues for the tooltipped wrapped switches

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix:
* cypress tests
* rebased new property pane changes for switch column type

* fix: merge conflicts on property section

* fix: address code review callouts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:04:11 +05:30
Rimil Dey
903aaa7a14
feat: Change navigate to UI (#14856)
* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Fix types and imports

* Update the tests

* Add ref back to the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:00:16 +05:30
balajisoundar
c37a8a4cfe
fix: table widget issue where editableCell is undefined (#16729) 2022-09-15 13:17:15 +05:30
Satish Gandham
12f9a005ae
chore: Refactor getSelectedWidget selector (#16647)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Rename getSelectedWidget to getLastSelectedWidget in selectors/ui

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-15 05:44:11 +00:00
Satbir Singh
193dacfeca
chore: Adding JS Object Events (#16472)
* Event for creating new JS Object

* Adding tracking event for function execution

* Removing unwanted comment

* Events for adding new functions added

* Handling optional properties

* Changing event names

* Renaming Event Sources to JS_OBJECT
2022-09-14 21:04:10 +05:30
Shrikant Sharat Kandula
2a55633416
Change worker_connections to 1024 2022-09-14 19:53:03 +05:30
Favour Ohanekwu
16b04f33a6
fix: incorrect lint error position (#16526)
* perform string search using original binding

* Add jest test

* Improve code for better readability
2022-09-14 09:35:29 +01:00
Satish Gandham
a706ad3160
perf: Widget layer optimization (#16502)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Remove stray imports

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-14 12:25:08 +05:30
Shrikant Sharat Kandula
d1110fc774
Restore nginx-app.conf.template 2022-09-14 11:16:00 +05:30
albinAppsmith
3beea62e44
feat: Updates modal new design changes (#16553)
* feat: Updates modal new design changes

* Title and Subtitle font changes

* test cases fixed for product updates modal
2022-09-14 10:40:48 +05:30
Shrikant Sharat Kandula
7ab3b4fbab
feat: Support running NGINX for development without Docker (#16667) 2022-09-14 09:58:31 +05:30
NandanAnantharamu
642cdb886b
test: updated locator with wait for flaky test (#16734)
updated locator with wait
2022-09-14 08:39:09 +05:30
Parthvi
ca64ceb4fb
test: update cypress test fork_template_spec (#16719)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-09-13 12:50:09 +05:30
balajisoundar
87774a64ac
chore: fix table widget migration merge conflict (#16711) 2022-09-13 12:01:40 +05:30
NandanAnantharamu
6f45430395
test: updated test and dsl (#16656)
updated test and dsl
2022-09-13 11:56:37 +05:30
balajisoundar
afb9aa93c1
feat: Table widget V2 Inline editing validation for plain text & number column (#15954) 2022-09-13 11:11:59 +05:30
balajisoundar
9bc5a5e076
chore: Expose widget configuration to define properties that can set … (#16573) 2022-09-13 11:10:08 +05:30
Hetu Nandu
0970389143
chore: Delete service worker cache (#16668) 2022-09-13 10:38:45 +05:30