Commit Graph

10721 Commits

Author SHA1 Message Date
Souma Ghosh
44d1885ae9
fix: Text getting clipped for Italic font in Table Widget V1 (#15549) 2022-08-16 11:12:31 +05:30
arslanhaiderbuttar
9277274b13
Removed the conflicting part with TED (#16022) 2022-08-16 11:01:25 +05:30
NandanAnantharamu
b6b762f623
Updated default-meta fix (#16003) 2022-08-16 10:31:12 +05:30
Aishwarya-U-R
820846ce8b
Cypress version upgrade for timeout issue resolution (#15917) 2022-08-16 09:31:16 +05:30
Bhavin K
0aafa388ec
fix: navigation issue in the Iframe widget due to src change (#15656)
* fix: navigation issue in the Iframe widget due to src change

* test: added test case for the iframe widget
2022-08-16 09:12:38 +05:30
arslanhaiderbuttar
058d90cea0
test: Update workflows for upgrade scenarios (#15841)
Update workflows for upgrade scenarios
2022-08-15 14:08:30 +00:00
Souma Ghosh
4acf5aa59c
fix: Cell background colour not applied to new columns in table widget (#15898) 2022-08-15 17:27:28 +05:30
Aman Agarwal
e6a6ceaebc
RTS Docker image build error (#16010) 2022-08-15 15:23:58 +05:30
Aswath K
b88564d96a
fix: unable to remove Icon on Input widget (#16007) 2022-08-15 09:44:58 +00:00
Aswath K
359d09d53e
chore: Grouping & reorganisation for Toggle widgets (#15706) 2022-08-15 13:35:46 +05:30
Aswath K
759ad4fda4
chore: Grouping & Reorganisation for Select Widgets (#15831) 2022-08-15 13:08:30 +05:30
Manish Kumar
fcfc3d97dc
feat: Making the error messages in amazon s3 plugin informative (#15861)
* feat: make AmazonS3 plugin error messages more readable. #8664

* added curly braces in if/else block

* modified according to PR review comments

* modified according to PR review comments

* This commit introduces readable errors for S3 Datasource: https://github.com/appsmithorg/appsmith/issues/8554
It changes three files:
	*AmazonS3ErrorUtils.java
	*AmazonS3PluginTest.java
	*AmazonS3ErrorUtilsTest.java

This commit has been tested:
	*manual testing
	*Junit testing

* This feature-commit introduces readable errors for S3 Datasource: https://github.com/appsmithorg/appsmith/issues/8554
It changes three files:
	*AmazonS3ErrorUtils.java
	*AmazonS3PluginTest.java
	*AmazonS3ErrorUtilsTest.java

This commit has been tested:
	*manual testing
	*Junit testing

* added new line in the AmazonS3ErrorUtilsTest.java

* * Ommited unused imports in following files:
	* AmazonS3ErrorUtils.java
	* AmazonS3PluginTest.java
	* AmazonS3ErrorUtilsTest.java

* Moved test functions
* combined instance checking for AmazonServiceException and its subclass

* removed unused imports from AmaxonS3UtilsTest.Java

Co-authored-by: somna <somnathdasadhikari@gmail.com>
2022-08-15 10:48:20 +05:30
Aman Agarwal
ba9281cf77
fix: rts version file moved to src (#15963) 2022-08-12 21:10:50 +05:30
Keyur Paralkar
d39cecbbb4
feat: chartwidget reskin feedback (#15621)
* style: added styles to chart configs

* style: adjusted axis names and legend position

* style:
* adjusting legend position
* removed background property at the widget level
* exposed current theme data at widget level

* fix: addressed feedback on chart widget reskin

* fix:
* style according to feedback
* styled custom charts

* fix:
* added migration for accentColor and fontFamily
* implemented reskinning feedback

* fix: changed the position of properties in custom chart config

* fix:
* added unit test for migration
* changed the caption color

* fix: spacing fix

* fix: added accentColor and fontFamily defaults

* test: added cypress test for chart reskinning

* test: fixed cypress test failure
2022-08-12 17:40:17 +05:30
Aswath K
b77a8cae81
feat: JS toggle for icon property of Inputs (#15947) 2022-08-12 14:35:37 +05:30
Vihar Kurama
a8d0c12c54
Update readme: content, links, structural changes (#15926)
* readme revamp

* gif location update

* heading format

* added white logo

* update text getting started section

* getting started section formatting

* update content

* remove line breaks

* update yt link
2022-08-12 13:07:28 +05:30
Ayangade Adeoluwa
0e36569b06
feat: Abort Query Execution (#15775)
* Snaps response view to certain height and adds abort query execution feature

* make raw string a constant

* Add cypress tests

* Remove theme variable

* move raw strings to constants in messages.ts file

* Fix test case description

* Comment out query abort action execution

* cy fix

* Fix abortion of parallel action execution like onPageLoad

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-12 12:49:17 +05:30
Pawan Kumar
a5733da363
fix: Cypress tests for admin settings's watermark setting (#15760) 2022-08-11 17:35:08 +02:00
Aman Agarwal
3b00508c1e
feat: ast mono repo poc (#15610)
* POC for Shared AST Logic using Yarn Symlinks

* fix: preinstall script for bundling shared packages

* Merge commit

* fix: updated the script to link, unlink the package as shared dep

* fix: updated dependencies

* Add a post-install script and fix yarn.lock file

* Remove commented code

* fix: added verification script, readme, moved scripts to shared

Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com>
2022-08-11 20:59:26 +05:30
Aswath K
ee32ffb76f
chore: Grouping & reorganisation for Input widgets (#15584) 2022-08-11 16:50:09 +05:30
Trisha Anand
48ab154cf1
chore: Removing debug feature flag logs from the server (#15931) 2022-08-11 12:50:37 +02:00
Nidhi
10c9f77359
fix: Make default DB compulsory in URI string format (#15881)
* fix: Use admin as default database when no Mongo DB is specified

* fix: Make default db compulsary instead

* Added back check during execution per review

* Json field spec fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 15:35:27 +05:30
Rishabh Rathod
e255593e28
fix: Improve Autocomplete for local vars, JSObject & ButtonGroup Widget
Add Autocomplete support for
- local variables 
- JSObjects
- ButtonGroupWidget
Remove Autocomplete suggestion for
- `eval`
-  undefined global values like `tabs`
2022-08-11 15:29:38 +05:30
albinAppsmith
1a6936435d
fix: design system package conflict with styled-component (#15914) 2022-08-11 15:13:15 +05:30
Aman Agarwal
fb752eaa9e
fix: revamped rts server architecture (#15870)
## Description

RTS node server was being used for Availability feature. Now we will be enhancing the server to utilise client side logic on the server side side like construction of AST, Evaluations logic etc. So, since our codebase was not structured for implementing such use case, so we had to revamp the structure of the codebase.
#### Architecture

- **Routes :** To define different paths to consume apis
- **Controllers :** To capture the routing and formulate the logic to provide response to a particular request
- **Middleware :** action functions that happen to be stitched in between the routes and controllers, or can be used as a part of logic that needs to be injected in between.
- **Constants :** To keep static variables as per the usage without declaring it in other parts of the codebase
- **Sockets :** Any socket apis exists inside this folder to properly structure every socket implementations
- **Utils :** Helper functions which can be used at any stage of the application

Fixes #15645

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.

- Test A
- Test B

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 15:06:02 +05:30
Nikhil Nandagopal
50597d5d6f Updated Label Config 2022-08-11 14:05:45 +05:30
Nikhil Nandagopal
79959fcfec Updated Label Config 2022-08-11 12:54:47 +05:30
Nikhil Nandagopal
7e17ed875d Updated Label Config 2022-08-11 12:54:36 +05:30
Nikhil Nandagopal
7306c48714 Updated Label Config 2022-08-11 12:54:26 +05:30
Nikhil Nandagopal
eaf41a24bb Updated Label Config 2022-08-11 12:54:17 +05:30
Nikhil Nandagopal
b9622c6998 Updated Label Config 2022-08-11 12:54:08 +05:30
Nikhil Nandagopal
19e4375f67 Updated Label Config 2022-08-11 12:53:51 +05:30
Tolulope Adetula
c6ed1b7214
fix: select default value validation (#15846)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* fix: add jest test

* Empty Commit

* Fix: Empty commit to re-reun

* empty commit

* Empty Commit

* cy fix

* json field event fix

* TableFilter failure fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 10:02:55 +05:30
Aishwarya-U-R
d0dd080397
test: Script fix for Cypress Timeout - CI runs (#15878) 2022-08-10 21:36:30 +05:30
Nayan
8e38079a31
chore: Return custom slug in other api (#14854)
* -return custom slug in response to the get list of pages API

* -return custom slug for default page in home page API

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-10 21:52:24 +06:00
Nikhil Nandagopal
f1eff29b7c Updated Label Config 2022-08-10 18:36:42 +05:30
allcontributors[bot]
66e490b6a3
docs: add vishnu-gp as a contributor for code (#15894)
Add @vishnu-gp as a contributor for code.

This was requested by vishnu-gp [in this comment](https://github.com/appsmithorg/appsmith/pull/15684#issuecomment-1210522794)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2022-08-10 16:57:36 +05:30
allcontributors[bot]
e692af3bd9
docs: add dhruvikn as a contributor for code (#15888)
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2022-08-10 14:02:36 +05:30
Dhruvik Neharia
ce2aafaee4
feat: Change default label position of RTE widget to top (#15769) 2022-08-10 14:00:24 +05:30
Shrikant Sharat Kandula
4179017e63
ci: Remove CodeBuild (#15887)
Remove CodeBuild as it's very old and doesn't work now, and we don't use it.
2022-08-10 13:35:32 +05:30
Rishabh Rathod
78379d4718
fix: update def on widget property name update (#15490) 2022-08-10 10:50:08 +05:30
rahulramesha
b4e9f648c3
fix: Multiple scrolls in view mode (#15679)
fix multiple scrollbars
2022-08-09 22:40:10 +05:30
Ayangade Adeoluwa
1ecffb8272
fix: Modify Form Control Inputs for various Datasource Actions (#15396)
* Modify control type for MongoDB Collection field

* Make more form control changes across datasources

* Fix cypress errors

* Fix typescript error

* Fix more cypress tests

* Fix failing MongoDBShoppingCart spec

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-09 13:05:59 +00:00
Aswath K
781620d57b
chore: Property Pane Grouping of Chart, Maps & Media widgets (#15557)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Adds FilePickerWidget

* Adds MapChartWidget

* Adds ContainerWidget

* Adds MapWidget

* Adds ImageWidget

* Adds AudioRecorderWidget

* Adds CameraWidget

* Adds ChartWidget

* fix: issues found in design review

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* Adds FormWidget

* fix: mapchart style section heading

* refactor: cleanup

* incoorporate latest change for Camera widget
2022-08-09 13:05:36 +00:00
Aswath K
6430adb413
chore: Grouping & reorganisation for multiple widgets (#15673)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties

* Adds TextWidget

* Adds RateWidget

* Adds DividerWidget

* Adds ProgressWidget

* Adds ListWidget

* adds TabWidget

* Adds IframeWidget

* Adds StatboxWidget

* Adds ModalWidget

* changes after design review
2022-08-09 13:05:15 +00:00
Vishnu Gp
2c03cecbb1
feat: Added more data to existing analytics events (#15684)
* feat: added more data to existing analytics events

* Added extra audit data points for page and action events

* Corrected minor comment issue

* Review changes

* Removed audit references in variable names

* Review changes related to sending analytics events and DB optimization
2022-08-09 13:05:00 +00:00
Arpit Mohan
ec29bbfac4
ci: Running the "Test plan approved" check only on pull requests to release branch (#15850) 2022-08-08 22:24:00 +05:30
Arpit Mohan
c1dbca6779
fix: Adding checks to prevent disallowed hosts from connecting via Elasticsearch plugin (#15834)
## Description

This PR fixes an issue where a potentially malicious user can connect to disallowed hosts from the Elasticsearch plugin within Appsmith. This is because Elasticsearch client SDK is a HTTP interface underneath the hood. 

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Junits for the following:
  - create datasource with disallowed host
  - validate datasource with disallowed host
  - test datasource with disallowed host

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-08 21:07:15 +05:30
Aswath K
a3fe6a7826
fix: Remove unwanted logs which may confuse the users (#15815) 2022-08-08 19:24:37 +05:30
Arpit Mohan
0967b516b6
fix: Adding a check for invalid hosts on redirects as well (#15782)
## Description

Fixes issue for checking for invalid hosts even when there are redirects in the Rest API plugin.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Junit test

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-08-06 12:36:43 +05:30