Commit Graph

19239 Commits

Author SHA1 Message Date
Arpit Mohan
42b8a564fe
ci: Pinning the server build runs to Ubuntu 22.04 because of Flapdoodle errors (#38723)
## Description
Flapdoodle, our Mongo embedded testing library throws errors when
running Junit tests on Ubuntu 24.04. This is because of a mismatch of
openssl version from Ubuntu 22.04 to Ubuntu 24.04. Hence pinning our CI
for server builds to Ubuntu 22.04 for now. Will issue a holistic fix
with Flapdoodle upgrade later.

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflow configurations for server build and
integration tests
- Migrated workflow environments from `ubuntu-latest-8-cores` to
`ubuntu-22.04-8core`
	- Refined workflow logic for test execution and artifact management

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-17 11:43:37 +05:30
Hetu Nandu
1963a9a27d
chore: Move action redesign to GA (#38659) 2025-01-16 22:26:34 +05:30
Alex
5a98f55024
fix: suppress error toast for update notifications (#38709)
## Description
Prevents error toasts for errors designed to show update notification
toasts.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12811573044>
> Commit: 444b42858eece8b8454283480e5b72d96aee4290
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12811573044&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 16 Jan 2025 15:41:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Updated error handling mechanism for bad request errors
	- Refined version mismatch error processing

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 18:58:02 +03:00
Sagar Khalasi
56f968fb07
fix: Flaky test case fix (#38703)
## Description
Code improvement


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12808540560>
> Commit: a5bfdaf3c397f05bd73d66a0fe57a84b92a36944
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12808540560&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Thu, 16 Jan 2025 12:33:05 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test cases for admin settings to improve interaction
reliability
	- Modified save button interaction and element visibility checks
- Updated test expectations for instance name changes in Enterprise
Edition

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 20:24:47 +05:30
devin-ai-integration[bot]
b3e5e431b2
feat: disabledWhenInvalid in ButtonGroupWidget (#38656)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-16 17:23:35 +05:30
Hetu Nandu
4e7a2a013d
fix: Workflow query conversion (#38688) 2025-01-16 17:06:06 +05:30
Aparna Ramachandran
19a603af4e
CI: Changing cron timing - Update test-build-docker-image.yml (#38701)
Changed TBP to run at different times, and added a new one

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-01-16 17:04:29 +05:30
Sagar Khalasi
eb8e0e398f
ci: Fix for ssh port 22 issue (#38697)
## Description
Workflow failure :
https://github.com/appsmithorg/appsmith/actions/runs/12804875642/job/35705873169


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38698

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12807366996>
> Commit: cc4baab222b9f0667cb9addb98ef3549b2650ecf
> Workflow: `PR Automation test suite`
> Tags: `@tag.Settings`
> Spec: ``
> <hr>Thu, 16 Jan 2025 10:54:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to disable SSH socket service during
Docker container execution
- Ensures SSH service is stopped and prevented from automatically
restarting during CI tests

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 16:41:17 +05:30
Hetu Nandu
2b8ba77fec
fix: AI query not showing any bottom tabs (#38687) 2025-01-16 07:35:32 +00:00
Sagar Khalasi
71ff3ee2a7
chore: Improve code (#38622)
## Description
Minor improvement.


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38320

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12745102566>
> Commit: 6fd0683846fddb03650527c09300b10d9bc29b41
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12745102566&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Mon, 13 Jan 2025 10:43:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
	- Enhanced Cypress end-to-end tests for Admin settings page
	- Added improved loading state and document readiness assertions
- Increased test robustness by ensuring stable application state before
interactions

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-15 22:43:18 +05:30
Aman Agarwal
b496e4ab21
fix: copy changes to the description and content of modal (#38637) 2025-01-15 16:17:27 +05:30
Hetu Nandu
446eb2b602
chore: Update mixpanel masking classname (#38661) 2025-01-15 16:03:07 +05:30
Hetu Nandu
329c797a60
chore: Fix theme CE change only in EE (#38657) 2025-01-15 09:20:09 +00:00
Sagar Khalasi
0106489346
ci: return true if command fails (#38662)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12783144157>
> Commit: 0a2d9705b729c8429e7c79cc52bef0d78a51f390
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12783144157&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Settings
> Spec: 
> It seems like **no tests ran** 😔. We are not able to recognize it,
please check <a
href="https://github.com/appsmithorg/appsmith/actions/runs/12783144157"
target="_blank">workflow here</a>.
> <hr>Wed, 15 Jan 2025 07:01:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated description for PR number input parameter in GitHub Actions
workflow configuration

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-15 12:31:41 +05:30
Sagar Khalasi
df5ef9be98
ci: Do not fail on image remove (#38660)
## Description
Fix : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1736920490455829


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated Docker image build workflow to improve error handling when
removing Docker images.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-15 12:16:43 +05:30
Hetu Nandu
a23bcbf955
fix: Separate Plugin Entity from Action (#38582) 2025-01-15 11:29:32 +05:30
Rudraprasad Das
d7e30e7dc5
chore: fixes mergeviaremote_spec flakiness (#38635)
## Description
Fixes flakiness for merge via remote spec

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12765495211>
> Commit: 7f83e90fe136425136e3f497ba825449dec72ea4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12765495211&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Tue, 14 Jan 2025 11:18:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Updated Git synchronization test suite for merging changes
	- Modified test file to streamline page creation and merging process
	- Added new test path for Anvil Widgets tests
	- Removed commented test file path and related comment
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 13:56:46 +01:00
Hetu Nandu
357664f809
chore: Move IDE Sidebar into ADS (#38641) 2025-01-14 12:10:22 +00:00
Hetu Nandu
d5551aab2e
fix: [ADS] Entity Tree node overflow (#38651) 2025-01-14 17:03:31 +05:30
Hetu Nandu
e1b3b0df00
Revert "feat: Added focus ring for focus visible (#37700)" (#38650) 2025-01-14 16:44:52 +05:30
Rudraprasad Das
3ad06e215e
chore: git mod - minor fixes (#38634)
## Description
- Adds `isInitialized` state for git components
- Adds message to autocommit progressbar
- Adds proper loading state for merge dropdown

Fixes https://github.com/appsmithorg/appsmith/issues/38593
Fixes https://github.com/appsmithorg/appsmith/issues/38594

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12753560383>
> Commit: bd7a5814bd094717bc6bffb746418c3bbe682d55
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12753560383&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 13 Jan 2025 19:21:01 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
	- Added initialization tracking for Git-related components.
	- Enhanced Git editor initialization state management.
- Introduced new selectors for retrieving Git artifact initialization
states.

- **Bug Fixes**
	- Improved conditional rendering for Git quick actions.
	- Updated merge status tracking and display logic.

- **Refactor**
	- Introduced new hooks for Git artifact initialization.
	- Updated state management for Git-related UI components.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 11:58:10 +01:00
Ankita Kinger
d187854e40
chore: Replacing the entity group list component on state inspector and data side pane with new ADS component (#38621)
## Description

Replacing the entity group list component on state inspector and data
side pane with new ADS component

Fixes [#38290](https://github.com/appsmithorg/appsmith/issues/38290)

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12763738469>
> Commit: a4b717244604617d39fb1869d039899dd024c687
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12763738469&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 14 Jan 2025 09:50:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced list item styling with configurable height.
  - Added support for dynamic item count in entity groups.
  - Improved icon rendering with customizable dimensions.
  - Introduced a new constant for default group list size.

- **Improvements**
  - Simplified rendering of grouped items in various components.
  - Refined type safety for boolean assignments.
  - Updated state management for entity groups.
  - Enhanced control over item visibility in modals and lists.

- **Technical Updates**
  - Introduced new data attributes for enhanced component interactions.
  - Modernized component rendering logic.
- Replaced custom styled list with a dedicated `EntityGroupsList`
component for better maintainability.
- Expanded story examples for the `ListItem` component to showcase
various configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 15:27:08 +05:30
Sagar Khalasi
b6f7164c14
chore: Skipping case due to Issue38156 (#38628)
## Description
Skipping case due to :
https://github.com/appsmithorg/appsmith/issues/38156


Fixes # https://github.com/appsmithorg/appsmith/issues/38156

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12746823242>
> Commit: ac771ea7c09d65f387eb5c49277c9da457e21a86
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12746823242&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Mon, 13 Jan 2025 12:31:16 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
	- Temporarily disabled a test suite for file upload testing
	- Skipped test suite due to known issue

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 19:14:02 +05:30
Hetu Nandu
a7f7d3f237
fix: Issue with Api Body content type selection (#38597) 2025-01-13 18:01:04 +05:30
Hetu Nandu
bfd66e50d6
chore: [ADS] Entity Tree Hover interactions (#38615) 2025-01-13 15:49:09 +05:30
Sagar Khalasi
97ebfaa857
chore: Updated the mockdb code (#38603)
## Description
We have identified that the mock database is accessible to multiple
stakeholders, increasing the risk of data corruption. To address this,
we have commented out unnecessary and potentially flaky test code to
ensure stability and reliability.

Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38602

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12743407394>
> Commit: f74f769b8a48b284380a296687c346ba904b595e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12743407394&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Mon, 13 Jan 2025 09:51:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Modified Cypress test for Mock Databases by removing specific query
count and response verification assertions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 15:30:53 +05:30
albinAppsmith
dd5a6d6792
feat: Added focus ring for focus visible (#37700)
## Description

This PR adds focus ring for CTA's in the platform.

Fixes #37699

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12742601686>
> Commit: 25970876103fc1ea3f9feeba62f3be10b0783638
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12742601686&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 13 Jan 2025 08:19:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced focus state styling for the select component, improving
visibility when active.
- Updated focus management for buttons, inputs, and various components
to utilize `:focus-visible`, enhancing accessibility.
- Refined keyboard navigation and interaction logic for the color picker
component.
- Introduced new props for conditional focus styling in the editor and
button components.
	- Added support for AI assistance features in the code editor.
- Improved focus ring visibility in the segmented control and switch
components.

- **Bug Fixes**
- Improved accessibility and visual clarity of focus outlines across the
application.

- **Chores**
- Removed outdated focus outline rules, allowing for a more streamlined
styling approach.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 14:43:27 +05:30
Hetu Nandu
f8784fcf6b
feat: ADS Entity List Tree (#38493)
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2025-01-13 08:24:30 +00:00
NandanAnantharamu
d52a0f283a
test: exluding from airgap list of tests (#38596)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
	- Updated Cypress test suite for import functionality
	- Added tag to exclude test in specific environments

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2025-01-13 12:12:53 +05:30
Jacques Ikot
13d316db55
fix: select column to display cell value when options are mismatched (#38387)
## Description
**Problem**
When a table cell is configured with the Select column type, the cell
value is not displayed if it does not match any of the label-value pairs
in the select options. This results in a broken user experience where it
appears as if the cell has no value.

**Expected Behaviour**
The table cell should always display its value if it exists, regardless
of whether it matches the provided select options.

**Solution**
To address this issue, the default behaviour for the select options has
been updated to prioritise the cell's value instead of falling back to
an empty string. This ensures that cell values are always visible to the
user, even if they are not part of the predefined select options.


Fixes #35807

## Automation

/ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding, @tag.Table,
@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12544985047>
> Commit: d39d7f30bb9ae713a4d7c2038fbef89b6e8acadf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12544985047&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Select, @tag.Binding, @tag.Table,
@tag.Sanity`
> Spec:
> <hr>Mon, 30 Dec 2024 11:52:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved display logic in the SelectCell component to show the value
when no matching option is found.
- Updated test cases for the Select column type functionality to ensure
accurate verification of select options and display behavior when
options are not provided.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 07:40:33 +01:00
shadabbuchh
635de3739b
test: validate 'Show Bindings' menu for queries & JS Objects in split-pane (#38577)
## Description
This PR introduces test cases to validate the visibility and correctness
of the "Show Bindings" menu when working with JavaScript Objects and API
queries in the split-pane mode. It ensures that the bindings are
displayed as expected.

Tests: https://github.com/appsmithorg/appsmith/issues/38547

## Automation

/ok-to-test tags="@tag.Datasource, @tag.Sanity, @tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12708509894>
> Commit: 91840c0953f8528a975c2f90fd467659ea102e3a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12708509894&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource, @tag.Sanity, @tag.JS`
> Spec:
> <hr>Fri, 10 Jan 2025 12:29:18 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added automated tests for validating the "Show Bindings" menu in split
pane mode.
	- Introduced new locators for list toggle and bindings menu.

- **Tests**
- Created test cases for checking "Show Bindings" functionality for
JavaScript Objects and API queries.

- **Chores**
- Updated test configurations to focus on specific test cases and
modified locator references in support files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 10:51:17 +05:30
Sagar Khalasi
1cc3899ad4
fix: Fix copy issue in embedsetting spec (#38590)
## Description
RCA: Found the copy the clipboard is not working in chrome. Have enabled
spec specific permission for copy and the store the cypress variable in
local variable to get firm run results.


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38589

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12740837386>
> Commit: e1903dbd34f17722bf798e4a79687cb6201a78ed
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12740837386&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Mon, 13 Jan 2025 05:11:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Updated clipboard handling in end-to-end testing
- Improved clipboard permission and content retrieval for test scenarios
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 10:43:55 +05:30
Sagar Khalasi
8c3bcbabd3
ci: Checking no_data with contains to avoid error (#38592)
## Description
Found that existing text file was not reading when no_data passed. Fixed
the problem by adding that condition.

Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38591

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12740786426>
> Commit: 7c4e5488fb4dfc564b9d34feaba0f2312277f54f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12740786426&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 13 Jan 2025 05:09:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflow for improved test specification
handling
	- Enhanced debug logging and error handling in CI test workflow
	- Refined mechanism for processing test input sources
	- Added more robust file checking and fallback logic

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 10:40:12 +05:30
NandanAnantharamu
2dadb16b22
test: regression tests for import flow (#38457)
Added test for import app validation at app level

/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12653467361>
> Commit: 1ac6a57472822360ae786bef59df3238cba130c4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12653467361&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 08 Jan 2025 04:28:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Added a new test suite to verify import functionality for applications
- Implemented test case to check import options and data source
validation at the app level

- **New Features**
- Added new locators for import button and list item title to support
testing

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2025-01-12 14:28:05 +05:30
devin-ai-integration[bot]
057c6267bd
fix: SSH key dropdown scrolls with modal (#38584)
## Description

This changes the dropdown container to fix overflow issues in the Git
connect/import modal. The SSH key dropdown now properly scrolls with the
modal content instead of remaining fixed in place.

## Type of Change
- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Manual testing of dropdown scroll behavior in the Git connect modal

Link to Devin run:
https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12710679010>
> Commit: 40cdbf43c02a034e50897ae2194f2e676d147762
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12710679010&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 10 Jan 2025 14:28:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: arpit@appsmith.com <arpit@appsmith.com>
2025-01-10 22:52:38 +05:30
Ankita Kinger
3d97706da3
chore: Adding Group component in ADS Templates (#38512)
## Description

Adding Group component in ADS Templates to use the same for a single
list of grouped entities in the product.

Fixes [#37615](https://github.com/appsmithorg/appsmith/issues/37615)
[#37616](https://github.com/appsmithorg/appsmith/issues/37616)
[#38288](https://github.com/appsmithorg/appsmith/issues/38288)
[#38287](https://github.com/appsmithorg/appsmith/issues/38287)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12704682977>
> Commit: b62fecb2aeb4f3ebc9a9ed683f5d1d1949a943cc
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12704682977&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 10 Jan 2025 09:11:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced List component with improved grouping capabilities.
  - Added support for dynamic list rendering with custom children.
  - Introduced `EntityGroupsList` for more flexible group management.
- Added new styled components for better visual representation of lists.
  - Added `LoadMore` styled component for improved UX in entity groups.
- New Storybook examples for `EntityGroupsList` and `EntityGroup`
components.

- **Improvements**
  - Refined List component to support more flexible item rendering.
  - Updated styling for list components.
  - Improved type safety for list-related components.
  - Streamlined code structure for better maintainability.

- **Changes**
  - Removed `GroupedList` component.
  - Updated list rendering across multiple components.
  - Simplified list item management.
  - Expanded public API for `EntityExplorer` module with new exports.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 18:34:05 +05:30
devin-ai-integration[bot]
ca265494cf
feat: add setText setter to PhoneInputWidget (#38578)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-10 18:03:22 +05:30
Hetu Nandu
5a17a7fea5
fix: Response view not passing error to support (#38579) 2025-01-10 11:38:04 +00:00
Rudraprasad Das
c169d48888
chore: git mod - minor fixes (#38563)
## Description
- Fixes initial loading state for status
- Includes module instances and source module count
- Fixes discard flow

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12692930817>
> Commit: 6689c8e113bc4795cecd533fe5b7eff6ee221283
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12692930817&attempt=4"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 10 Jan 2025 08:32:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Introduced a new focus on source modules instead of packages
	- Enhanced tracking of module instances and source module changes

- **Bug Fixes**
- Updated status change calculations to more accurately reflect module
modifications
	- Improved handling of artifact identification in discard operations

- **Refactor**
- Renamed and restructured various status-related interfaces and
functions
- Modified selectors and reducers to support new module tracking
approach

- **Chores**
	- Updated type definitions and selector implementations
	- Removed deprecated package-related tracking mechanisms

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 12:16:55 +01:00
Sagar Khalasi
1030275d0d
fix: Added login for better flow (#38569)
## Description
Fix for flaky behaviour.


Fixes #
https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38568


## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12705899394>
> Commit: e193fb3ff3ef923ed8b53b080935e932bd1a688a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12705899394&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Fri, 10 Jan 2025 08:50:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Updated the existing test case to verify accessibility of all admin
setting sections.
- Enhanced reliability by ensuring a fresh user session before testing
admin settings.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 15:49:38 +05:30
Goutham Pratapa
e12f1bc96d
chore: update client-build github runner (#38571) 2025-01-10 13:58:47 +05:30
Pawan Kumar
65df8d4c78
chore: Use zone as form (#38550)
Fixes #38525 

/ok-to-test tags="@tag.Anvil"


https://github.com/user-attachments/assets/891ecf61-2850-46c4-acd3-b170196e5ab7



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12703524629>
> Commit: 64616e2f16ed1884c0e7fd86f511b35801b17b88
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12703524629&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Fri, 10 Jan 2025 05:20:43 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Added form validation controls for buttons
  - Introduced ability to disable buttons on invalid form
  - Added option to reset form on button click
  - New context provider for managing widget state in UI builder

- **Improvements**
  - Enhanced reCAPTCHA handling with reset functionality
  - Updated button click event management
  - Improved widget context management

- **Configuration Updates**
  - New form settings for button widgets
  - Added `useAsForm` configuration for zone widgets

These updates provide more granular control over form interactions and
button behaviors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 12:48:51 +05:30
Anagh Hegde
37354bc9d1
chore: make refName and refType transient in Artifact Metadata class (#38564)
## Description
Make the refName and RefType transient for Artifact class.
2025-01-10 10:36:12 +05:30
Hetu Nandu
c155a511f1
chore: Separate files for Redux Types (#38559)
Co-authored-by: Diljit <diljit@appsmith.com>
2025-01-10 10:21:54 +05:30
Arpit Mohan
ee51fbd1a6
chore: Update upload-artifact version to v4 2025-01-09 23:36:36 +05:30
Ankita Kinger
6446f46ee6
fix: Updating CSS for list item to fix UI breaking on JS module instance in EE (#38558) 2025-01-09 18:36:47 +05:30
Hetu Nandu
388fd81d3b
fix: UsagePulse initialisation flow (#38555)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-01-09 18:36:19 +05:30
Aman Agarwal
dfd7fdee97
feat: datasource homepage ui redesign and search functionality for the datasources (#38360) 2025-01-09 16:18:44 +05:30
Hetu Nandu
c302b64be5
fix: Show bindings hiding behind scroll (#38553) 2025-01-09 09:08:28 +00:00
Diljit
46623172c4
chore: make cyclic deps check an error (#38543) 2025-01-09 11:07:37 +05:30