Ravi Kumar Prasad
eb0c93e0e0
feat: Add type inference for redux's useSelector hook ( #18257 )
...
Add type inference for redux's useSelector hook
- Used module augmentation of TS to override the default root state interface
- Replaced custom hook with redux's useSelector
- It brings consistency as at a lot of places in the codebase we're using only the redux's useSelector
2022-11-28 08:13:17 +00:00
Arsalan Yaldram
6edf161edf
fix: added tablet landscape icon ( #16436 )
...
## Description
- Added Tablet Landscape icon to the canvas size selector.
Fixes #9321
## Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
- Tested Manually on the canvas
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-09-03 20:37:31 +05:30
albinAppsmith
fbc3bd663b
feat: Migrate design system components import to design-system repo - I ( #15562 )
...
* Icon component deleted and changed the imports in refrence places
* design system package version changed
* import changes
* Delete TextInput.tsx
* Change imports
* Change single named import
* Update package
* Update package
* Delete ScrollIndicator.tsx
* Change imports
* Icon import completed
* Event type added
* Changed Button component imports
* import change button
* Button onclick type fix
* Label with Tooltip import changes
* Changed breadcrumbs import
* EmojiPicker and Emoji Reaction import changes
* AppIcon import change
* import bug fix
* Menu Item import chnages
* Icon selector imports changed
* Delete LabelWithTooltip.tsx
* Change imports across the app
* Update package version
* Update version number for design-system
* Delete Checkbox.tsx
* Remove the exports
* Add lock file for ds package update
* Change imports
* default import -> named
* Update release version
* Make arg type explicit
* Updated design-system to latest release
* Missing file mysteriously comes back and is updated accordingly
* changes design-system package version
* Add types to arguments in the onChange for text input
* onBlur type fix
* Search component in property pane
* WDS button changes reverted
* package version bumped
* conflict fix
* Remove Dropdown, change imports
* Category import fix
* fix: table icon size import
* Bump version of design system package
* Yarn lock
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
2022-08-22 10:39:39 +05:30
albinAppsmith
fcbcec751d
feat: Design System package & Tooltip integration ( #14547 )
...
* Added Appsmith Design System Package
* Removed tooltip from ADS folder
* Changed imports for Tooltip
* added alias for the @appsmithorg/design-system
* fix for npm aliasing in jest
* design system package version change to beta 1.0.1-beta.8
* Tooltip Position type changed to PopoverPosition
* design system package updated
2022-06-24 19:53:02 +05:30
Pawan Kumar
809a633306
feat: App Theming ( #9714 )
...
* fix style bugs
* fix select styles
* test: fix font size issue for cypress tests
* incorporate ashit feedback
* test: addresed review comments for cypress tests
* add analytics events
* height issue in view mode
* incorporate code review feedbacks
* incorporate code review feedbacks
* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations
* feat: Makes shadow and radius controls keyboard accessible (#11547 )
* makes shadow and radius controls keyboard accessible
* removes unused imports
* moves options out of render method
* fix: changed the misnomer background property name to the relevant property name
* fix: border radius issue for the map widget
* address qa bugs
* address qa bugs
* fix ux of theming pane when widget is selected
* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget
* fix: added delete icon in the delete theme modal
* address qa bugs
* change checkbox column size in config
* add js convertible to button color
* remove unused imports
* test: fixed jest tests
* fix primary color typo
* fix: migrations for the theming
* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.
* test: updated Dsl migration UT
* address qa bugs
* address qa bugs
* fix: address qa comments
* address qa bugs
* fix:
* migration issue;
* unit test cases;
* fix rating widget scroll issue
* fix youtube video border radius bug
* fix select widget
* fix select widgets styles
* address qa bugs
* merge conflicts
* makes the reset button keyboard accessible (#12134 )
* -resolved merge conflicts
* address qa bugs
* fix: labelTextSize migration fixes
* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests
* fix button group widget
* remove unused imports
* fix: fixed the text size migration for the table widget
* refactor: addressed review comments for the table widget theming migration
* fix button group widget
* add init calls for view mode
* json form init theme changes
* fix: added migration for boxShadow, borderRadius and textSizes for table widget
* fix broken fields
* test: fixed unit tests
* wip
* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration
* feat: init json form migration theming
* json form primaryColor -> accentColor
* update table widget
* update table widget
* object field label styling
* fix: migration related to the JSON form
* fix: fixed labelTextSize migration for JSON form nested widgets
* property control nested stylesheet lookup
* JSONForm label styles form array items
* show label for checkbox field array item
* fix button group widget
* wip
* refactor: addressed table widget review comments
* refactor: addressed ashit review comments;
* added childStylesheet for widgets
* feat: Keyboard navigable Color Picker control (#11797 )
* Makes ColorPicker keyboard accessible
* seperate out keyboard and mouse interactions
* fix issue with not focusing back to input
* Adds test for Color picker
* chore: added comment for the boxShadow property
* fix:
* added unit test cases for the widget and property utils
* resolved warning messages
* wip
* theme config update
* fix merge conflicts
* refactor: moved theming migration inside the migrations folder
* fix qa bugs
* fix jest test
* fix: unit test cases
* fix table column creation logic
* refactor: addressed review comments for migrations
* fix: Overriding margin and padding for custom render in the dropdown component (#12875 )
* * fix for custom render padding and margin in ADS dropdown
* * fix for removing padding from normal render options
* refactor: moved the boxShadow condition to the variable
* fix qa bugs
* fix: migration QA callouts for audio recorder widget
* refactor: added updated comments for boxShadow migration for table widget
* fix theme binfings for JSONForm fields under Object
* fix table widget theming bug
* fix: addressed code review comments
* fix: unit test cases
* fix: qa migration callouts
* fix table widget theming bug
* fix JSONForm currency input dropdown not submit form
* Added new tests - AppThemingSpec
* fix qa bugs
* fix unit test
* fix JSONForm cellBorderWidth to have default value post migration
* fix unit test
* fix qa bugs
* remove unused imports
* fix qa bugs
* fix JSONForm input height issue
* fix qa bugs
* Updating Theming spec
* * dropdown color fixes (#13249 )
* fix caching issue
;
* Fixed Theming tests
* fix tests
* fix tab widget tests
* fix: json form children level migration issue
* fix table widget tests
* Updated test
* updated tests
* updated test
* updated tests
* updated tests
* updated pageload
* fix cypress tests
* remove cypress created files
* fix color picker issues
* Failure fixes
* Fixed some more tests
* fix: cypress test failures
* fix tests
* remove consoles
* fix table tests
* fix qa bugs
* updating snapshots for AppPageLayout_spec as per new UI
* fix rating widget bug
* fix qa bugs
* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports
* update constract check algo
* fix color contrast issue
* fix: cypress failure test cases
* update font sizes labels
* fix regression bugs
* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow
* fix: default labelTextSize issue for the Input and Select families
* fix regression bugs
* fix regression bugs
* PassingParams spec - added wait time
* fix: font family default value issue on JS toggle
* fix js toggle issue in text widget
* fix tests
* fix tests
* fix tests
* fix cypress tests
* fix regression bugs
* fix regression bugs
* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget
* fix: failing unit test cases
* fix theming spec
* fix cypress tests
* test: fixed failed cypress test
* incorporate ashit feedback
* fix cypress tests
* fix: addressed review comments
* comment out table cypress test
* fix merge conflicts
* comment out color picker tests
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
rahulramesha
98f6a3fede
move reflow out of beta ( #12746 )
2022-04-20 18:33:30 +05:30
Arsalan Yaldram
366276cdbc
chore: Keyboard accessibility added to canvas selector buttons. ( #11420 )
...
* chore: Keyboard accessibility added to canvas selector buttons.
* chore: Removed default tab navigation for buttons.
* chore: Fixed Tab Navigation.
* chore: Fixed edge cases, handled selectedIndex.
* chore: use OnBlur instead of Tab key press.
* chore: added jest test cases for Arrow navigation.
* chore: review changes for test cases.
2022-03-09 18:40:21 +00:00
rahulramesha
b6bcfec549
chore: Reflow Info Card ( #10481 )
...
* removing reflow flag and adding Reflow Info card
* verbage correction
* adding reflow docs link
2022-01-20 14:59:09 +05:30
Ashok Kumar M
0149085bf8
feat: Reflow and Resize while Dragging and Resizing widgets. ( #9054 )
...
* resize n reflow rough cut
* removing warnings
* relatively stable changes
* minor bug fix
* reflow relative collision
* working dp cut
* fix for reflow of widgets closer next to each other
* disabling scroll
* Drag with reflow
* reflow fix
* overlap and retracing fix
* On Drop updates.
* bug when no displacement but resize update.
* temp fix for new widget addition.
* reflow bug fixes
* new widget addition bug.
* stop reflow on leave.
* fix corner case overlap
* update bottom row when reflowed widgets go beyond bottom boundary.
* capture mouse positions on enter
* enable container jumps with faster mouse movements.
* reflow only for snap changes.
* restructured reflow Algorithm
* collision check and bug fixes
* undo redo fix for new widget drop
* resizable fix snapRows fix
* directional stability
* self collision fix
* first round of perf fixes
* update bottom row while resizing and resize-reflowing
* performance fix and overlapping fix
* Remove eslint warning
* remove eslint warning
* eslint warning
* can reflowed Drop Indication Stability
* container jumps and force direction on entering canvas
* fixing scroll on resize jitters.
* reflow when jumping into container.
* reflow ux fixes while leaving container
* resizing fixes.
* fixes for edge move.
* restrict container jumps into reflowed containers.
* container jump direction reflow
* checkbox dimensions fix.
* Excess bottom rows not lost post dragging or resizing widgets.
* fixing the after drop css glitch.
* double first move trigger bug fix.
* stop reflow only if reflowing
* stabilize container exit directions
* using acceleration and speed instead of movement covered to restrict reflow.
* fixing modal drops.
* remove warnings.
* reflow resize styles
* moving acceleration and movement logic to a monitoring effect.
* adding beta flag for reflow.
* fixing jest tests
* Adding analytics to beta flag toggle.
* Adding placeholder for reflow beta screens.
* fixing initial load's screen
* few more crashes.
* force close onboarding for the session.
* fixing bugs in reset canvas.
* Beta flag bug fixes.
* fixing bugs.
* restrict reflow screens during onboarding.
* disabling reflow screens in tests.
* code review comments.
* fixing store based specs.
* fixing cypress failures.
* fixing specs.
* code cleanup
* reverting yarn lock changes
* removing onboarding screens.
* more cleanup and function descriptors
* keeping reflow under the hood.
Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-13 18:51:57 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking ( #7361 )
...
* add tailwindcss
* docked property pane
* uncomment a line
* make entity explorer as drawer on unpin
* remove unused imports
* add pin state in reducer
* add menu icon in header
* fix widget sidebar
* fix widgets sidebar
* style property pane
* update property pane css
* update icons in property pane
* update property pane header styles
* update spacing
* fix few ui issues
* wip: preview mode
* wip:preview mode
* remove unused import
* comments sidebar in app and edit mode
* fix order of import
* use selected state for property pane
* update scrollbar style
* add classes to sidebar and property pane
* make widgets editor fluid
* make widgets editor fluid and refactor logic
* resize the widgets editor if explorer is pinned
* add shortcut for preview mode
* fix link for tabs in edit mode
* zoom in/zoom out for 0.75
* fix chart widget + table widget crashing
* allow zooming of canvas
* fix weird canvas draw issue + update container for handling zoom
* add actions for is panning
* allow panning with grab cursor
* reset panning + zooming when entering preview mode
* add grabbing cursor when grabbing
* only prevent default when space key is pressed
* dont allow zoom in preview mode
* remove unused imports
* fix dont allow zoom in preview mode
* fix ux of panning on space hit
* make fluid as the default app layout
* chart spec
* fix dropdown_on change spec
* fix add widget table and bind spec
* remove draggable property pane spec
* fix container spec
* fix form widget spec
* fix jest test
* fix the function typo
* remove clicking of close button for property pane in cypress tests
* remove property pane actions test
* fix drag and drop test failing
* add cypress selector id to back button in property pane
* fix toggle js spec
* fix merge conflicts from new design system
* editor header
* fix product updates styles + widget card
* remove all unused imports
* fix dynamic layout spec
* fix entity explorer tab rename test failing
* fix table spec
* fix bind tabletextpagination spec
* fix js object spec
* fix entity explorer rename issue
* fix cypress test
* fix cypress command wrong commit
* fix tab spec
* fix property pane copy tests
* add zoom header
* zoom levels
* make property pane sidebar resizable
* add multi select property pane
* fix widget search bug
* update property pane width in state on drag end
* fix viewer header
* fix editor header
* update editor header + remove zooming
* update small style
* dont allow closing of explorer when resizing
* fix jest test
* fix dropdown widget jest test
* preview test case wip
* add entity explorer pinning tests + preview mode tests
* add tooltip in layout control + add padding bottom in property pane view
* incorporate aakash feedbacks
* fix preview mode margin issue
* remove panning code
* fix cypress failing test
* uncomment jest test
* remove redundant code
* fix maincontainer test
* incorporate review feedbacks
* incorporate aakash feedbacks
* review feedbacks
* incorporate review feedbacks
* incorporate qa feedbacks
* fix dynamic layout spec
* updated test based on latest change
* dsl updated
* Updated dsl
* Updated dsl
* resize deselects widget issue.
* fix canvas height issue
* fix typo
* incorporate qa feedbacks
* incorporate qa feedbacks
* incorporate qa feedbacks
* update color for setting control for widget name
* fix onboarding styles conflicts
* Updated tests
* fix application overflow issue
* updated test method
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
balajisoundar
8ea9e0d31c
chore: Add helper tooltips for page properties icons ( #8538 )
2021-10-18 15:09:04 +05:30
balajisoundar
d1efe8405e
feat: Add tooltips for icons in editor ( #7711 )
...
fixes : #6759
2021-10-08 12:35:34 +05:30
Pranav Kanade
73b795cb71
fix: layout control not working ( #7502 )
...
* fixed layout control problem.
* removed extra padding for multi pointer canvas
2021-09-17 11:07:09 +05:30
Pranav Kanade
b1a399b64a
fix: comment pins related issues ( #7081 )
...
* fix: the thread with the latest comment will be at the top.
* fixed the z index of unpublished pin
* making the layout control absolute
* removed comments
* reversed the ids order
* made sorting logic generic to work with list of ids
* minor refactor
* putting layout controller on top of canvas
2021-09-06 14:27:47 +05:30
Bhavin K
4b932089a5
Feature: Line separator widget ( #4954 )
...
* basic line widget setup
* rename to divider, added icon
* completed divider functionalities
* minor textual updates
* cypress test for divider widget
* tested on local cypress run
* Divider widget jest tests
* basic logic implemented
* arrow head better alignment
* added required svg icons
* divider widget props update
* fix on propertypane dropdown iconSize
* fix capside icon width in property panel
* updated cypress dsl and tests
* minor updates
* cap arrow new implementation
* remove hover animation from divider icon
* updates and optimizations
* moved test class to component
2021-07-07 15:00:06 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency ( #4083 )
...
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) ( #3748 )
...
* Fix: On renaming a widget via entity explorer the canvas gets resized
* Fix: Close prop pane on resize start of unselected widget.
* Fix: Match all - corejs polyfill
* Fix: Proppane not updated properly when same type widgets are selected.
* Feature: Draggable Proppane.
* Bug fixes for draggable popup.
* Fix: Property pane editor when selecting another widget.
* resolve rebase bad merges.
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fixes
* cytest fix
* fixing draggable components inside porp pane.
* Adding cypress test.
* refactored Draggable list POC version
* reverting unwanted changes.
* prop pane bug fix
* unwanted dependencies.
* double click to open prop pane.
* Fixing bugs in draggable prop pane.
* one click prop pane open.
* ignore drag/resize click captures
* make prop pane draggable only via drag handler.
* Fixed property pane title.
* converting layer to hook and adding it to top most layer.
* removing irrelevant comments.
* close panel when widget changes.
* fixing cytests.
* bug fix
* fixing cytest
* Addressing code review comments.
* bug fix
2021-03-29 21:17:22 +05:30
hetunandu
b0580e9ee0
Revert "Feature: Property Pane improvements ( #3561 )"
...
This reverts commit 3437c16ef0
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements ( #3561 )
...
* Fix: On renaming a widget via entity explorer the canvas gets resized
* Fix: Close prop pane on resize start of unselected widget.
* Fix: Match all - corejs polyfill
* Fix: Proppane not updated properly when same type widgets are selected.
* Feature: Draggable Proppane.
* Bug fixes for draggable popup.
* Fix: Property pane editor when selecting another widget.
* resolve rebase bad merges.
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fix
* cytest fixes
* cytest fix
* fixing draggable components inside porp pane.
* Adding cypress test.
* refactored Draggable list POC version
* reverting unwanted changes.
* prop pane bug fix
* unwanted dependencies.
* double click to open prop pane.
* Fixing bugs in draggable prop pane.
* one click prop pane open.
* ignore drag/resize click captures
* make prop pane draggable only via drag handler.
* Fixed property pane title.
* converting layer to hook and adding it to top most layer.
* removing irrelevant comments.
* close panel when widget changes.
* fixing cytests.
* bug fix
* fixing cytest
* Addressing code review comments.
* bug fix
2021-03-29 15:28:52 +05:30
ram-primathon
3b0fb539d5
Property Pane re design ( #3057 )
...
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Shrikant Sharat Kandula
65568a4e13
Add more devices in AppLayout options ( #3451 )
...
* Remove width and introduce more AppLayout type enums
* Fix: Adding min width to layout options.
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-03-11 07:51:48 +05:30
Ashok Kumar M
a7e0990cf8
Feature: Canvas Layout Options(max width config) ( #3141 )
...
* Feature: Canvas Layout Options(max width config)
* Fixing css issues.
* Changing Default Device option to Desktop.
* Changed Implementation to maintain resize updates within the client.
* Addressing code review changes.
* Updating device resolutions.
* updating cytests
* Fixing resize bug.
2021-03-03 10:56:47 +05:30
