## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
Core features of Auto Layout and mobile responsiveness, hidden under a feature flag.
> Add a TL;DR when description is extra long (helps content team)
Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
## Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
> Manual regression and sanity tests for all fixed canvas functionality.
- Manual
- Jest
- Cypress
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag
---------
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Part of #11855.
Instead of getting the Google Maps API Key from runtime env variables,
we get it from the server, as part of the response of
`/api/v1/tenant/current`. This doesn't add a database call, just include
the env variable name in the response, so shouldn't have any performance
impact on the API.
On the client though, the Maps API key won't be available, until at
least the first call to `/tenant/current` is finished.
Also, first big PR in client code. 🙂
Edit: not `/me` anymore, but from `/tenant/current`.
---------
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
## Description
When we worked on replacing the underlying library of google map
component, we accidently replaced the custom icon with the one provided
by google due to which color functionality got lost. This PR fixes this
and also tracks for changes in position or color in the marker values.
Fixes#20271
## Type of change
- Bug fix
## How Has This Been Tested?
- Manual
### Test Plan
> https://github.com/appsmithorg/TestSmith/issues/2180
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [x] Test plan has been approved by relevant developers
- [x] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
This PR:
- updates the react 16 to react 17
- replaces the underlying library for the map widget
- adds clustering of markers
- refactor code for map widget's component
## Description
Fixes#16946
## Type of change
- Breaking change
## How Has This Been Tested?
- Manually
### Test Plan
https://github.com/appsmithorg/TestSmith/issues/2149
### Issues raised during DP testing
1.
https://github.com/appsmithorg/appsmith/pull/19315#issuecomment-1378495845
## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [x] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
Co-authored-by: rahulramesha <rahul@appsmith.com>
* POC: Grouping for ButtonWidget
* Adds featureflag
* improve feature flag experience for unfinished widgets
* Styling of tabs
* Adds activation group for ButtonWidget
* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests
* Adds UI for search
* Fixes title, search & tabs UI to the top
* fix: style issue
* fix styles
* refactor ProeprtyPaneTab
* updates Button based on Figma design changes
* POC for AudioWidget
* chore: JSON Form Grouping & Reorganisation (#15033)
* POC: JSON Form grouping
* fix: Empty sections
* Moves icon into a separate sub section
* fix some sections based on updated Designs
* fix styling issues
* fix: double border
* udpdates based on Figma updates
* Updates order as per Figma
* refactor and better naming of function
* address review comments for JSON form configs
* fix UI issues
* reorder JSON form's array data section
* Adds Button Form settings
* Address QA comments
* update JSON form with new design changes
* Adds FilePickerWidget
* Adds MapChartWidget
* Adds ContainerWidget
* Adds MapWidget
* Adds ImageWidget
* Adds AudioRecorderWidget
* Adds CameraWidget
* Adds ChartWidget
* fix: issues found in design review
* Open array & object style by default
* trigger ci
* chore: Grouping & reorganisation of Video widget (#15297)
* POC: JSON Form grouping
* fix: Empty sections
* Moves icon into a separate sub section
* fix some sections based on updated Designs
* fix styling issues
* fix: double border
* udpdates based on Figma updates
* Updates order as per Figma
* Content & Style Config for Video Widget
* refactor and better naming of function
* address review comments for JSON form configs
* fix UI issues
* ??
* chore: Grouping & reorganisation of Document Viewer widget (#15514)
* Grouping & re-org for Document Viewer
* fix: scroll issue
* Adds FormWidget
* fix: mapchart style section heading
* refactor: cleanup
* incoorporate latest change for Camera widget
* fix: Map pin does not center when location is changed and centering option is turned on
-- Update center meta property when defaultMarkers or mapCenter properties were changed
* fix: Map pin does not center when location is changed and centering option is turned on
-- Force the last marker to be centered
* added config to support code split
* splitting config
* moved the window declaration in EE file as its dependency will be updated in EE
* CE: Splitting ApiConstants and SocialLogin constants
* CE: split login page
* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE
* added key icon
* CE: created a factory class to share social auths list
* Minor style fix for social btns
* Updated the third party auth styles
* updated jest config
* updated third party login registry class
* feat: Change Map Pin Color on Map Widget
-- Add a color property for a marker
* feat: Change Map Pin Color on Map Widget
-- Set #E0DEDE as default color
* feat: Change Map Pin Color on Map Widget
-- Revert to the original logic
* feat: Change Map Pin Color on Map Widget
-- Add a new base icon for a marker
* feat: Change Map Pin Color on Map Widget
-- Add anchor property for custom marker icon
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
-- Change the label for the property, isClickedMarkerCentered
-- Set isClickedMarkerCentered to true by default
-- Create the corresponding migration for it
* reverted previous revert
* standardised widget sizes
* Text changes
* changed default input label style to match default text style
* more messaging tweaks
* minor fix
* Removed dot from the text
* minor fix for form widget
* fixed tests
* minor fixes
