Commit Graph

10628 Commits

Author SHA1 Message Date
Parthvi
3c3e5fffa2
chore: Update ClientSetup.md with instructions on how to run with TED (#15411)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-30 00:35:49 +05:30
Vishnu Gp
7d8fca9545
chore: Fixed flaky ApplicationForkingServiceTests (#15550) 2022-07-30 00:34:23 +05:30
Arpit Mohan
f5c67840ea
chore: Closing resources to ensure there are no memory leaks (#15343)
This is based on warnings from Sonar's static code analysis.
2022-07-29 19:51:10 +05:30
Shrikant Sharat Kandula
8619a311ad
Fix compile error 2022-07-29 15:16:43 +05:30
Shrikant Sharat Kandula
04f8d2799d
Fix potential delay in sending setup completion (#15534)
The Installation setup complete event is not getting sent sometimes, and it's behavior looks very much like there's some race condition somewhere. I'm proposing this change towards two goals.

One, currently, we send the event after the user-entered data is saved to the DB. But, there's no actual dependency, no point to waiting on that for sending the event. The actual user itself, is already created and signed up. So, one change is that we don't wait for the DB update to be applied. I'm also changing .onSuccess to .map, hoping that might make a difference.

Two, make a debug log entry to see if it is our callback function that's not getting invoked, or if Segment's API isn't doing it's job, when the event is not sent.

This PR also fixes formatting of Segment error messages.
2022-07-29 14:35:26 +05:30
Aishwarya-U-R
73c0c9eecd
test: Automated tests for JSObjects + Flaky fixes (#15269)
* FOcusElement

* Specs into folders

* Bug14987_spec.js flaky fix

* S3 flaky trial fix

* CreateQuery() added

* Spec rearranged

* Sepcs rearranged

* MySql table load fix

* Added bug id JSOPageLoad

* Postgress idle connections spec fixed

* fixes

* fix

* fix

* Import fix

* Mock DB spec added

* flake fix

* Flake fix

* fix custom_chart_spec and gitSyncedApp_spec tests

* JSOnLoad after Import app scripted

* fix

* mock db name fix

* fix

* tc #58 scripted

* fix

* fixes

* moved spec

* increased wait time

* table filter fix

* Import time fix

* jsONload spec fix

* jsonload spec fix

* failure fixes

* "videoCompression": false

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 14:18:25 +05:30
Nikhil Nandagopal
98a40e67c7
Update --documentation-improvement.yaml 2022-07-29 13:02:42 +05:30
Nikhil Nandagopal
62c6d48dd3
Update --bug-report.yaml 2022-07-29 13:01:43 +05:30
Anagh Hegde
4821a5c141
fix: ssh url validation in git to include a few cases where - is present in the url (#15499)
Fix the ssh URL validation to include a few cases with `-` in the url
2022-07-29 10:44:19 +05:30
Keyur Paralkar
c396224fe8
fix: filePicker widget re-skinning (#15183)
* fix:
* added css variables for primary color
* added styles for dropHint custom icon

* feat:
* styled the remove uploaded file icon to match re-skinning
* added theme font-family to the contents inside the upload modal
* styled upload button to match re-skinning

* feat:
* set cancel button color to theme's primary color
* set the close button style according to theme
* set the border radius of the upload modal
* set the error message styles in accordance with re-skinning

* fix: cross mark position on the top right corner of upload modal

* fix: added hover background color on modal back and add more files button

* fix: added border radius fix for file remove button

* fix: modal close icon

* fix: addressed feedback from dilip

* fix: font-family issue inside the modal

* test: added cypress test to test styling logic
2022-07-29 10:29:02 +05:30
ashit-rath
b21c8cff31
fix: JSONForm input field REGEX validation (#15316)
* fix: JSONForm input field REGEX validation

* fix cypress test
2022-07-29 09:49:39 +05:30
Nidhi
82ed999d85
fix: Added type static hierarchy to allow compatible types (#15470)
* fix: Added type static hierarchy to allow compatible types

* Removed unnecessary logging
2022-07-29 08:43:23 +05:30
Parthvi
ed90490005
test: fix git cypress tests (#15508)
* fix git tests

* add wait for git status call to complete

* fix git tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 08:33:32 +05:30
Nidhi
12e626d5b0
chore: Added isMock and isTemplate to action execution analytics (#15505)
Added isMock and isTemplate to action execution
2022-07-29 01:18:09 +05:30
sidhantgoel
4c56cc5bda
feat: Annotation based Caching library similar to spring's Cacheable with WebFlux support (#14416)
* added reactive caching module

Signed-off-by: Sidhant Goel <sidhant@appsmith.com>

* CacheManager and implementation

* updated root level pom.xml

* removed spring boot maven plugin from project reactiveCaching

* Support for key annotation

* moved conditional on annotation

* Added comments

* Update app/server/reactive-caching/src/main/java/com/appsmith/caching/aspects/ReactiveCacheAspect.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/reactive-caching/src/main/java/com/appsmith/caching/aspects/ReactiveCacheAspect.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/reactive-caching/src/main/java/com/appsmith/caching/aspects/ReactiveCacheAspect.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* review changes

* addressed review comments

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-07-28 21:45:47 +05:30
Sumesh Pradhan
edbfef7d51
Auto-backup and cleanup with appsmithctl (#15203)
- Auto-cleanup of backup files using env variable APPSMITH_BACKUP_ARCHIVE_LIMIT (default value is 4) after every backup.
- Updated docker file to include watchtower hook scripts.
- Error mail interval to 6hrs.
2022-07-28 17:45:28 +05:30
Sumit Kumar
02f1451443
fix: fix query failure on simultaneous execution of multiple queries (#15458)
* update driver
remove connection closure when not required

* add connection pool
remove ssl options

* got working with postgres driver

* use Redshift driver instead of postgres

* updated JUnit TC
added comments
minor refactor

* add comment
cleanup

* update default port
2022-07-28 17:01:17 +05:30
Pawan Kumar
bae0b75583
feat: Code-split for admin setting for toggling appsmith watermark (#15036)
* create checkbox

* code split for hiding branding badge

* code split for hiding branding badge

* code review feedback fixes

* rename auth to upgrade button

* update mobile branding badge

* change label

* minor refactor

* minor updates

* add a cypress tests to check if watermark setting contains a upgrade button
2022-07-28 14:08:37 +05:30
Arsalan Yaldram
a02155fc88
fix: remove appsmith incoming entity from widget entity dropdown (#15324)
* fix: remove appsmith incoming entity from widget entity dropdown
2022-07-28 13:08:50 +05:30
Nidhi
daea0a8545
chore: Added analytics for C, U, D operations on actions (#15069)
* chore: Added analytics for C, U, D operations on actions

* chore: Added isTemplateOrMock field in datasource

* fix: Set mock datasource field as true on creation

* Split template and mock identifiers into two. Added them to analytics as well

* Added tests as well as felt like a noob.

* Add isMock and isTemplate fields to datasources of created Actions

* Removed execute action triggered props

* Revert "Removed execute action triggered props"

This reverts commit cad1b8af504218813daa5f563f7b417fa263101b.

* Stringified response body before recording event

* Adding ds fields

* Reverting client side changes

* Fixed failing tests

Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com>
2022-07-28 09:40:47 +05:30
Nidhi
6df4dafead
chore: Better server logging infra (#15440)
* Fixed a bunch of server side logging issues

* Tests

* Added ISO8601 timestamp to log format
2022-07-28 09:40:03 +05:30
Arsalan Yaldram
9dea163172
fix: show clear input icon on allow clear value (#15232)
* fix: show clear input on allow clear value

* fix: truncate select input on small size
2022-07-27 22:33:05 +05:30
Vishnu Gp
828f734b18
Added missing analytics events and extra data (#15408)
This adds a few missing analytics events and some more extra data for audit purposes. The missing event added are,

    User login (login_USER)
    User logout (logout_USER)
    Import Application (import_APPLICATION)
    Export Application (export_APPLICATION)
    Clone Application (clone_APPLICATION)
    Create Workspace (create_WORKSPACE)
    Delete Workspace (delete_WORKSPACE)
    View Page (view_NEWPAGE)
2022-07-27 21:01:34 +05:30
akash-codemonk
3fdce8462c
fix: onboarding visual distraction from the entity explorer being hidden (#15446) 2022-07-27 19:29:43 +05:30
Anagh Hegde
712e15a1fc
chore: NPE issue while copying in git-theming migration (#15480)
## Description

> Fix the NPE issue in theming while copying the properties. 


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

> Locally

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-27 17:14:17 +05:30
akash-codemonk
526f2a8be6
chore: fix cannot read properties of null (reading 'id') sentry error (#15323) 2022-07-27 16:25:41 +05:30
Favour Ohanekwu
e5d89e7099
chore: Upgrade astring version from v1.7.5 to v1.8.3 (#15245)
## Description
Previous version of the astring library doesn't preserve parenthesis when transforming AST to JS Code. This led to syntax error when null coalesce and logical expressions are used together.

The latest version of astring library fixes this.

<img width="1291" alt="screenshot_2022-07-16_at_04 29 52" src="https://user-images.githubusercontent.com/46670083/179581475-863d70f2-0886-403a-a667-a32ad93e76b7.png">


Fixes #15283 


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
Test plan

- [x] https://github.com/appsmithorg/TestSmith/issues/1970

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-27 14:48:39 +05:30
Bhavin K
47cc518dbe
fix: set default on reset of The Tab widget (#15202) 2022-07-27 14:26:16 +05:30
Arsalan Yaldram
22250b88a0
fix: updated marked to the latest version (#15309)
fix: updated marked added @babel/helper-create-regexp-features-plugin
2022-07-27 14:04:47 +05:30
Vishnu Gp
91025f94d7
chore: Fixing flaky test in ApplicationForkingServiceTests (#15468)
## Description

Fixes issue in ApplicationForkingServiceTests

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Local tests

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-27 11:25:15 +05:30
Nayan
9489484ffd
Add migration to fix deleted themes when branch was deleted (#14957)
Due to a bug, customized themes set to the parent branch where deleted when user deletes git branch. The bug has been fixed already. This PR adds a DB migration that fixes the data if there is any.
2022-07-27 10:13:39 +05:30
Vishnu Gp
d7fe87fac8
fix: Converted ApplicationForkingServiceTests to synchronous to temporarily solve tests failing on CI (#15450) 2022-07-26 18:20:40 +05:30
Hetu Nandu
a1e5b511eb
chore: Deprecation warning for comments (#15363)
Adds deprecation warning for comments

Resolves #15364
2022-07-26 18:04:54 +05:30
Parthvi
58c7f3d805
test: Update documentation URLs used in tests (#15419)
## Description

With the new documentation structure, updating the URLs which are being used in tests.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-26 12:58:07 +05:30
Parthvi
f60e78c972
test: Fix flaky cypress tests (#15437)
Fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-26 08:55:48 +05:30
Ankita Kinger
3b7ace67b5
feat: migrate texts and error messages from organization to workspace (#15410) 2022-07-25 17:52:09 +05:30
Nikhil Nandagopal
2a32f157ee Updated Label Config 2022-07-25 09:38:30 +05:30
Shrikant Sharat Kandula
dd46348981
Fix isset command not found (#14997) 2022-07-25 07:42:48 +05:30
Favour Ohanekwu
0f92b97226
feat: Triggerpath dependency (#15015)
* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 21:31:08 +01:00
Arpit Mohan
4674be719f
Fixing bug where the Mongo DB URL wasn't being picked up by the billing script (#15378) 2022-07-22 18:11:02 +05:30
Nikhil Nandagopal
692f1a5606 Updated Label Config 2022-07-22 17:23:56 +05:30
dependabot[bot]
92fe556c40
chore: bump terser from 5.13.1 to 5.14.2 in /app/client (#15319)
Bumps [terser](https://github.com/terser/terser) from 5.13.1 to 5.14.2.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-22 15:04:47 +05:30
Bhavin K
f45a15545d
fix: depercate form button widget (#14510) 2022-07-22 08:27:37 +00:00
Rishabh Rathod
6ad308ec39
chore: Refactor dependency Map code (#14944) 2022-07-22 12:32:16 +05:30
Nikhil Nandagopal
020d14dace Updated Label Config 2022-07-22 11:48:30 +05:30
Nikhil Nandagopal
c57b6268a1 Updated Label Config 2022-07-22 10:48:04 +05:30
Souma Ghosh
d45a6bfb97
fix: Compact property not functional for menu type in table widget v2 (#15302)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:45:48 +05:30
Souma Ghosh
27e91f8524
feat: Expose message event details for Iframe Widget (#14730)
* Expose message event details for Iframe Widget

* Change meta property name from messageEventProps to messageMetadata

* Cypress test for Iframe Message event details

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:42:57 +05:30
jaden
06e7d3cc63
CSS cant apply when constant WIDGET_PADDING=0 (#15227) 2022-07-21 18:34:10 +05:30
Favour Ohanekwu
243dc7f477
Improve lint error reporting (#15098)
Core changes in this PR

    Prevents logging of lint warnings (not errors) in the debugger
    Refined message for using 'await' in non-async functions
    Show lint error messages that include line numbers (previously weren't shown)

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-21 18:31:23 +05:30