Commit Graph

10566 Commits

Author SHA1 Message Date
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 (#14158)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* refactor code to migrate from org to workspace

* migrated a few missed out org to workspace

* updated a few more

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* reverted code change

* few more changes

* fixed failing cypress test

* fixed failing cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
Shrikant Sharat Kandula
5d166a46f1
fix: Block the call to clear Redis sessions (#15330) 2022-07-20 16:09:09 +05:30
Preet Sidhu
c03fddf1c9
fix: Improve CodeMirror rendering performance using idleCallback (#13676)
* working editor wrapper

* updated other property controls

* fix tablefilter_spec unit test

* autofocus on editor

* update font styles

* show lint errors

* add syntax highlighting

* fix import issue

* fix input height

* use lazy and suspense

* wip

* update code clean up

* update input style

* fix select widget issue

* fix build issue

* fix import issue and linting css

* update lint error method

* add polyfill for idle callback

* fix undo aggregate helper changes

* rename CodeEditor component

* fix tests add delay before code mirror

* undo name change

* rename lazy editor

* add comments and update aggregate helper

* fix cypress helper

* fix testJsonText command

* update aggregate helper

* add wait to allow time to load

* fix filepicker issue

* fix currency input test

* fix unit tests

* update aggregate helper

* fix table property tests

* fix test

* fix command

* update json text command

* updated command ii

* update iii

* update iv

* add force click

* check for wrapper

* fix for objects

* fix test iv

* fix test v

* fix tests vi

* fix tests vi

* fix variable naming issue

* fix tests vii

* remove wait from wrapper click

* fix tests viii

* fix recheck wrapper availability

* fix updateCodeInput command

* fix undo while loop

* fix ix

* fix each loop

* removed EnableAllCodeEditors

* updated tests

* Upated wait

* updated some more tests

* updated wait time

* updated common method

* updated all related common methods

* update state name and add callback timeout

* updated test

* updated the test

* fix use while loop and update count

* update click func

* fix use get instead of find

* fix on click action command

* remove comments

* fix: update import statements

* add force click to widget command

* update wrapper ui

* fix auto load code editor

* update editor wrapper ui

* fix lineheight adjustment

* refactor editor wrapper

* update style import

* fix ascetic style import

* fix font style

* fix wrapper height

* update color for code block

* fix min height of content wrapper

* remove error linting and editor wrapper

* remove unused variable

* remove unused imports

* fix font color for objects

* update styles for placeholders

* remove console log

* remove react syntax highlighter

* cancel idlecallback on unmount

* Delay input foucs

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-20 14:56:12 +05:30
Souma Ghosh
eddd1e8344
fix: Multiselect widget height decreases on selecting more options (#15228)
Fixes issue where multiselect height decreases on selecting more options
2022-07-20 14:26:37 +05:30
Bhavin K
8848d89650
fix: Added the loader in the Button group widget (#15246) 2022-07-20 14:21:54 +05:30
ashit-rath
cb40e04aa0
fix: JSONForm default array item not deletable when default value initialized with undefined (#15205) 2022-07-20 14:07:52 +05:30
Aman Agarwal
4890742168
fix: api auth fails displays error on view mode now (#14767) 2022-07-20 13:09:11 +05:30
Shrikant Sharat Kandula
e8be0936e6
Fix method name for Redis cleaning migration (#15322) 2022-07-20 12:48:55 +05:30
Rimil Dey
9284c5e240
Auto-indent JS code in the editor (#13222)
This pull request:

    introduces a new option to the menu in the JS editor which lets users prettify/auto-indent code.
    introduces a new keyboard shortcut that lets users prettify/auto-indent code
    Fixes bug where pressing CMD + <- in Mac (Home in windows) shifts the cursor to the first indented column. If the cursor is present on the first indented column, the cursor shifts to the 0th column in the editor

Fixes #9268
2022-07-20 12:43:23 +05:30
f0c1s
58dac0213c
Regenerate SSH key in connect and import flow (#14383)
As of today, we were supporting only ECDSA keys for GitHub, GitLab, and BitBucket. For Azure, RSA key generation was not available. This PR allows users to generate RSA or ECDSA keys.

As of now we support following key types and version control service providers:

    Github: ECDSA
    Gitlab: RSA, ECDSA
    Bitbucket: RSA, ECDSA
    Azure: RSA

Fixes #14382, #14715, #14570
2022-07-20 12:30:11 +05:30
Anagh Hegde
dbf0b94973
feat: Update the table widget to v2 in suggested widget list (#15277)
Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-20 12:28:50 +05:30
balajisoundar
71e581d69b
fix: cell background for edit actions column in Table v2 (#15233) 2022-07-20 11:42:59 +05:30
f0c1s
6eaabc3a7b
fix: reload default page on discard (#14964) 2022-07-20 11:40:06 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Hetu Nandu
5d568b7a6f
fix: Tooltip for long names in Entity Explorer (#15068) 2022-07-20 06:06:11 +00:00
Aswath K
8724f1c4fa
fix: Unwanted width calculation in Dropdown (#15239) 2022-07-20 06:05:44 +00:00
Arpit Mohan
1af9e2042f
chore: Adding the appsmithctl command to estimate the bill for an existing Appsmith user (#15311)
## Description

This PR adds to the `estimate_billing` option to the `appsmithctl` command. This will help existing users estimate their bill when they consider upgrading to the paid edition.

Usage: 
```
appsmithctl estimate_billing 

Options:
  --sessionPrice    The price per active session. Defaults to 0.3 
  --priceCap        The price cap for a user in a given month. Defaults to 15
```

A user can also run the command for various scenarios to determine the optimum capacity tier.

## Type of change

- New feature (non-breaking change which adds functionality)
- This change requires a documentation update

## How Has This Been Tested?

Manually

## Checklist:

- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-20 10:33:47 +05:30
Aman Agarwal
10ca5b5033
fix: query creation via shortcut (#15281)
## Description

- Shortcut key-up and key-down were not working because the list of file operations on ui were filtered out of the `sectionTitle` but on key actions it was being referred to which was adding in the offset for the current active item.

Fixes #15264

## Type of change

- Bug fix (non-breaking change which fixes an issue)
2022-07-20 10:06:51 +05:30
Shrikant Sharat Kandula
39ad73228c
Log users out to fix serialization error from upgrading Spring (#15314) 2022-07-20 07:43:38 +05:30
Parthvi
04ec2c99d6
test: JSObject tests and flaky test fix (#15292)
* JSObject tests and flaky test fix

* fixing omnibarspec doc link
2022-07-19 17:11:27 +05:30
akash-codemonk
086ac89565
fix: query forms which require evaluation shows loading (#15272) 2022-07-19 12:16:07 +05:30
Shrikant Sharat Kandula
6f37a02653
Remove path concatenation in Algolia sync script 2022-07-19 12:01:09 +05:30
Shrikant Sharat Kandula
bba78afc3b
chore: Upgrade dependencies reported by Dependabot (#13735)
Upgrades vulnerable dependencies in all plugins except for MySQL. That one is still failing and I'll fix it in a separate PR. Issue #14475

Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
2022-07-19 10:23:27 +05:30
Nikhil Nandagopal
7445d5d737
Update config.json 2022-07-18 13:00:38 +05:30
f0c1s
df4fca9b8f
fix: show conflict info properly (#15240)
## Description

ConflictInfo was showing up along side discard button. Moved it to a row of its own.

Fixes #15113 

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:03:21 +05:30
f0c1s
654ae38e67
fix: break branch creation text, fix text casing (#15241)
## Description

During branch creation, a bit of text was clinging to each other. Put them as per the design.

Fixes #15014 

### Issue:

![image](https://user-images.githubusercontent.com/1573771/179294901-7820fe79-4f35-47fd-9f63-98a886f102b5.png)

### design:

![Screenshot 2022-07-16 at 12 40 39 AM](https://user-images.githubusercontent.com/1573771/179295031-bbb5ef67-8955-4901-997a-1f455bdf5bb0.png)

### fix:


https://user-images.githubusercontent.com/1573771/179295053-d5940ba7-2a9f-41a9-965d-596bff69ac71.mov

![Screenshot 2022-07-16 at 12 36 52 AM](https://user-images.githubusercontent.com/1573771/179295067-c82d3905-f325-47ed-9007-06b0c7104e86.png)


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:02:54 +05:30
Anand Srinivasan
53641d9c68
feat: filter error messages from hidden widgets (#14738)
* initial filter

* hide modal errors

* handle tabs and modal

* remove console logs

* clean up

* comment

* add comments

* handle nested tab

* unit tests

* update test

* uncomment

* show errors in isVisible bindings

* show all errors when widget has faulty binding for isVisible

* handle isVisible faults inside containers
2022-07-18 08:55:32 +05:30
Ayush Pahwa
886359b0a3
fix: UI alignment for key value arrays (#15235)
fix: added required padding for form label div
2022-07-16 17:20:58 +05:30
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
Rishabh Rathod
bd571ffeb8
fix: JSObject AST parsing logic (#14962)
fix AST logic
2022-07-16 16:06:53 +05:30
Arsalan Yaldram
56063ab23d
feat: update dependencies (bot-alerts) (#15124)
* chore(deps): bump async from 2.6.3 to 2.6.4 in /app/client

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: bump moment from 2.29.3 to 2.29.4 in /app/client

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* feat: updated rts folder packages

* feat: remove node-sass

* fix: use marked 3.0.8 instead of marked 4

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-15 17:07:56 +05:30
rahulramesha
b878d5bd01
fix: Update maincanvas height on widget resize, drag or delete operation (#14992)
* fix extra space on canvas

* reverting selector changes

* use updated main canvas minheight

* use default canvas minHeight
2022-07-15 15:57:13 +05:30
Satish Gandham
c9a7587dcf
ci: Fix golden app tests and more (#15172)
* - Save the DOM on test failures.
- Handle promise rejection in tests.
- Save console logs to a file instead of stdout

* - Fix golden app tests
- Upgrade widgets in golden app to latest version

* - Removing logging to file temporarily
- Add test index to the file names

* Some final cleanup

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-15 14:40:45 +05:30
Ayush Pahwa
458715f0ac
fix: added default value for switch view type (#15215) 2022-07-15 09:15:08 +02:00
Parthvi
af2e55ef31
test: Add tests for bugs and fix flaky cypress tests (#15115)
* Fix flaky tests 

* fix discardChanges_Spec

* comment the intercept in merge method

* add test for bug#15175

* add test for bug

* fix git tests
2022-07-15 11:36:58 +05:30
Nidhi
bac313a235
chore: Added script to run Appsmith branches locally (#15182)
* chore: Added script to run Appsmith branches locally

* Clean up

* Clean up

* Clean up
2022-07-14 17:47:00 +05:30
Souma Ghosh
d40a8fd9f2
fix: Compact property not functional for menu widget (#15090)
Fix compact property functionality for menu widget and menu type in table widget
2022-07-14 17:11:03 +05:30
akash-codemonk
c76c052d36
fix: remove the image binding step in guided tour (#15161) 2022-07-14 16:21:24 +05:30
subratadeypappu
41c3446f5b
fix: Enable parsing dates before Jan 1, 1970 in MongoDB (#15105)
* fix: Enable parsing dates before Jan 1, 1970 in MongoDB

This commit takes care of three things
1. It enables the application to parse dates before Jan 1, 1970 in case of MongoDB
2. JUnit test
3. Cypress test

* fix: Enable parsing dates before Jan 1, 1970 in MongoDB

This commit takes care of three things
1. It enables the application to parse dates before Jan 1, 1970 in case of MongoDB
2. JUnit test
3. Cypress test

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2022-07-14 15:45:34 +05:30
Shrikant Sharat Kandula
bc71311c8c
GitBook's API is sending id instead of uid now 2022-07-14 12:36:52 +05:30
arunvjn
c331f8c330
fix: change edit/launch buttons to anchor tags in applications dashboard (#15168) 2022-07-14 12:34:19 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
Aswath K
3824435f7d
chore: Adds analytics for Property Pane keyboard navigation (#13703)
* Adds analytics for DropdownControl

* Add isUpdatedViaKeyboard to WIDGET_PROPERTY_UPDATE

* fix: jest test for iconselectorcontrol

* refactor: Interaction analytics event dispatching moved to a hook

* refactor: event collection logic to HOC

* Analytics for SwitchControl

* Analytics for CodeEditor

* Analytics for InputTextControl

* Analytics for ColorPicker

* fix issue with ColorPicker

* refactor to re-use ref

* rename the hook to ts

* Analytics for StepControl

* Analytics for ButtonTabComponent

* Analytics for NumericInputControl

* Analytics for IconSelector

* fix: failed test

* Analytics for ActionSelector

* fix: failed jest test

* fix: jest test for StepControl

* Analytics for Option Control

* Analytics for LocationSearchControl

* Adds Analytics for Tab key

* analytics for Property pane connections

* Add analytics for widget name

* Adds analytics for copy & delete button

* fix issue with widget name analytics

* add useCallback for tab keydown handler for button

* Create separate Event handling for design system

* removes unused imports

* changes ADS_EVENT to DS_EVENT

* Changes AdsEventTypes to DSEventTypes

* Changes AdsEventDetail to DSEventDetail

* changes occurences of Ads to DS

* avoids creation of intermediate function

* removes trace of 'analytics' from DS components

* rename dispatchDSEvent to emitDSEvent

* fix: Cypress selector
2022-07-14 10:30:30 +05:30
Aishwarya-U-R
d727d66c17
test: Automated tests for Postgres Datatype - Array type (#15164)
* Postgres Array DT scripted

* Array spec updates

* Arrayspec fix
2022-07-14 08:33:48 +05:30
Anand Srinivasan
59f91b618c
fix: curl import error (#15178)
* send only pageId on curl import creation

* remove variables

* fix data source redirect
2022-07-13 19:24:05 +05:30
Nidhi
02a5e1d490
fix: Added dropdown to select whether to send credentials in header or body in client credentials flow (#14545)
* Added dropdown to select isAuthorizationHeader in client credentials flow

* Added tests

* Added cypress test

* Oopsie
2022-07-13 14:33:19 +05:30
Arsalan Yaldram
8428ae506a
fix: using old versions of marked (#15151) 2022-07-13 13:04:23 +05:30
Pawan Kumar
0a78aa4aed
fix: Not able to right click on app home button in view mode (#15085)
replace button with link
2022-07-13 12:26:59 +05:30
Nayan
bac6162921
feat: Add new field for the page meta data in templates (#14784)
In order to import a specific page or browse to that page, the templates FE need page names and page ids. This PR replaces the list of page names with a list of objects that contains the page names and page ids.
2022-07-13 00:07:18 +06:00
rahulramesha
4dc3ed481c
fix: modal and App viewer header overlap (#15093)
* modal positions calculations on App View mode

* using css variables to compute modal offsets
2022-07-12 21:13:26 +05:30