Commit Graph

246 Commits

Author SHA1 Message Date
Bhavin K
374e8aec4a
datepicker 2 migration 27 added, default response udpated (#5393)
Default Min and Max Date were showing errors, We have fixed it now. This was specific to safari
2021-07-16 12:34:11 +05:30
Vicky Bansal
fad7874613
Currency datatype in Input Widget (#5049)
Added currency type input to input widget
2021-07-15 18:20:01 +05:30
Paul Li
560db4d4df
Menu button widget (#5334)
* FEATURE-3261 : Menu Widget

-- Perform initial onboarding of the widget, not completed

* FEATURE-3261 : Menu Widget

-- Create a menuItemsControl
-- Create the first MVP of IconSelectControl

* FEATURE-3261 : Add Menu Widget

-- Align add menu item button to the center
-- Build icon select control with a grid popup

* FEATURE-3261 : Menu Widget

-- Create a icon alignment control
-- Complete the property pane of the widget

* FEATURE-3261 : Add Menu Widget

-- Implement the body of the widget
-- Bind into the properties from property pane

* FEATURE-3261 : Menu Widget

-- Fix the issues from the first feedback

* FEATURE-3261 : Menu Widget

-- Fix on the 2nd feedback

* FEATURE-3261 : Menu Widget

-- Fix on issues from IconSelectControl, IconAlignControl

* FEATURE-3261 : Menu Button Widget

-- Rename Menu to MenuButton, accordingly refactoring the relevant codes
-- Change some help content
-- Change styles for icon select control, adding padding for search box

* FEATURE-3261 : Menu Button Widget

-- Bind isDisabled property into the UI
-- Prevent input text of menu item from overflowing
-- Add tooltip feature for icon select control
-- Set the height of the popover content dynamically

* FEATURE-3261 : Menu Button Widget

-- Use POPOVER2_TARGET class name for styling
2021-07-13 13:35:09 +05:30
Somangshu Goswami
ad840bb8b4
Change the default object fit property of image widget to contain (#5696)
* Change the default object fit property of image widget to `contain`
2021-07-09 13:35:14 +05:30
Vicky Bansal
718c257286
Support for Google reCaptcha v2 in Button Widget (#5638)
* Handle google recaptcha v2 in button component

* Use same code for recaptcha v2 and v3

* Updated error handling comments

* Added toggle to use google recaptcha v2 with button

* Create separate components for Google recaptcha v2 and v3

* Extract click function from google recaptch v3 component

* Hide recaptcha error badge and show invalid site key error on button key

* Fix isInvalidKey name
2021-07-08 17:32:08 +05:30
Bhavin K
f471a269b1
Feature/image rotation (#4674)
Developers now have the control to allow users to rotate or download image. These settings are available in the property pane.
2021-07-08 16:10:22 +05:30
Tolulope Adetula
814823aab8
fix: filterable default value (#4657)
The enable filter switch in the select widget property pane shows up as false but the widget component shows it. Fixed.
2021-07-08 15:53:12 +05:30
Vicky Bansal
c95f18b0d2
Add required option to Rich Text Editor for validations when used with Form widget (#5330)
* Added support to make rich text editor as require field

* Add default value of isRequired property for Rich Text Editor widget

* change isValid derived property to iffee functions value

* Converted isValid computation to use simple ternary operator
2021-07-07 17:39:15 +05:30
Bhavin K
4b932089a5
Feature: Line separator widget (#4954)
* basic line widget setup

* rename to divider, added icon

* completed divider functionalities

* minor textual updates

* cypress test for divider widget

* tested on local cypress run

* Divider widget jest tests

* basic logic implemented

* arrow head better alignment

* added required svg icons

* divider widget props update

* fix on propertypane dropdown iconSize

* fix capside icon width in property panel

* updated cypress dsl and tests

* minor updates

* cap arrow new implementation

* remove hover animation from divider icon

* updates and optimizations

* moved test class to component
2021-07-07 15:00:06 +05:30
Abhijeet
17006ffe0e
Minimise DB calls to throw duplicate app name error message (#5625)
* Minimise DB calls to throw duplicate error message for updating application name
2021-07-06 22:20:47 +05:30
Tolulope Adetula
6d32e868ce
feat: HTML Render option (#5566)
* Text widget now has an option to render the HTML code as it is. Once the user enables `render as html` the text widget will not parse HTML
2021-07-06 10:34:54 +05:30
Yash Vibhandik
8ef7c62bb6
FIX #4376 : update default config response to render proper data for … (#4778)
- update default config response to render proper data for table widget drop on canvas
- clone data for primaryColumns
2021-07-05 11:01:47 +05:30
Paul Li
38ffe86290
Rate widget (#4891)
* FEATURE-3357 : Rate Widget

-- Create the first MVP of rate widget

* FEATURE-3357 : Rate Widget

-- Change the widget name into rating
-- Change the widget icon
-- Fix the overflow issue in case max count is big
-- Fix the issue in case default rate is zero
-- Add validations for maxCount and defaultRate

* FEATURE-3357 : Rate Widget

-- Fix an issue : Stars is cut off if maxCount is greater than 20
-- Add test cases for two validation types, RATE_DEFAULT_RATE and RATE_MAX_COUNT

* FEATURE-3357 : Rate Widget

-- Add expected data type for tooltip field

* FEATURE-3357 : Rate Widget

-- Expose maxCount

* FEATURE-3357 : Rate Widget

-- Change contents of isAllowHalf property
-- Adjust alignment of stars dynamically
-- Decrease default widget width

* FEATURE-3357 : Rate Widget

-- Remove a unnecessary comment block
2021-07-02 15:25:50 +05:30
Tolulope Adetula
132abdaa54
feat: add object fit control (#4986)
* Added attribute to image widget to change cover properties
2021-06-29 19:00:14 +05:30
Satish Gandham
47bc5aa032
Merge pull request #5026 from appsmithorg/feature/1726-iframe-widget
Adding iframe widget
2021-06-23 13:01:40 +05:30
Hetu Nandu
441f42c72f
Generate linting errors via JSHint (#5034) 2021-06-21 16:39:51 +05:30
Paul Li
9bc1cd4899 Merge branch 'release' into feature/1726-iframe-widget 2021-06-21 06:54:20 -04:00
Paul Li
96c273cc22 FEATURE-1726 : Iframe Widget
-- Set default source url to wikipedia.org
-- Fix typo on the tooltip of onURLChanged, url to URL
-- Fix the issue which is related to reduced iframe in its deploy mode
-- Fix the issue which is related to the inclusion of nearby widgets in deploy mode
-- Add Expected Data Type fields with regard to borderOpacity and borderWidth
2021-06-21 06:48:00 -04:00
Pawan Kumar
91bf527bea
List Widget Phase 2 (#4189)
* update  meta properties + default properties map

* update widget registery

* update get meta property

* update metahoc + widgetfactory + data tree evaluator

* try sending function as string to worker

* revert data tree evaluator update

* pass default props map from dataTreeWidget file

* wip

* save child meta properties

* remove console.log

* save meta and default map in list

* update listwidget

* remove console.log + unused variables

* revert getMetaPropertiesMap function

* fix data tree test

* fix list widget test

* fix entity definition test

* fix overriting of item in updatedItems

* remove todo comments

* fix meta prop issue

* revert making meta properties from undefiend to "" & fix filepicker bug

* fix test case

* change items to listData and updatedItems to items

* remove console.log

* fix test

* extract derived properties to dervied.js

* disabled top, left, right resize handler list widget container

* add test for dervied js

* add test for selectedItem

* fix background color bug on hover

* remove console.log

* fix chart widget inside list widget

* fix checkbox issue + points raised by yogesh

* revert the createImmerReducer usage

* fix parse derived properties

* remove internal props object that fails the test

* fix import typo

* allow bottom resize handler

* fix template height check

* fix template height check

* update template size check

* fix the is visible invalid prop issue

* fix migration of list widget phase 2

* fix migration

* remove unused import

* fix migration

* fix migration

* remove console.log

* hide delete option for container in entity explorer

* fix testcases

* remove unused import

* fix switch widget meta prop

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-06-18 13:12:57 +05:30
Paul Li
e2168f70d8 Merge branch 'release' into feature/1726-iframe-widget 2021-06-10 04:18:56 -04:00
Paul Li
a54b0ffc16 Merge branch 'release' into feature/2111-toggle-header-options 2021-06-09 06:19:41 -04:00
Paul Li
a5cdf32590 FEATURE-1726 : iframe widget
-- Scaffold the widget
-- Bind properties
2021-06-09 05:39:17 -04:00
Somangshu Goswami
5f01ec859d
Merge pull request #4660 from appsmithorg/FIX/4573-custom-chart-type-not-supported-text
FIX #4573 : added custom fusion chart config to override default message
2021-06-07 19:09:35 +05:30
vicky.bansal@primathon.in
6610786e79 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/default-table-scrolls 2021-06-07 13:04:04 +05:30
Apeksha Bhosale
179d5ae8a9
Improve JS error reporting in the debugger (#4854) 2021-06-04 12:39:36 +05:30
Yash
8008aefcc7 FIX #4573 : custom fusion chart sample data make consistent as chartData property 2021-06-03 20:50:23 +05:30
Paul Li
f7ae4f0b2d Merge branch 'release' into feature/2111-toggle-header-options 2021-06-03 03:46:29 -04:00
vicky.bansal@primathon.in
40debe9e42 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/default-table-scrolls 2021-06-03 11:32:16 +05:30
Yash
9de9b1eb30 FIX #4573 : added sample custom fusion chart config and updated data shape to override default message 2021-05-28 14:49:36 +05:30
Ashok Kumar M
575d7fe7f9
Fix: Adding missing widget properties when a new tab is created. (#4733)
* dip

* dip

* dip

* Revert "dip"

This reverts commit f0eeaa4a2dc9845509945c2af9376f1573baafdf.

* dip

* removing unwanted iteration.

* Adding and fixing specs.
2021-05-28 08:28:02 +05:30
Pawan Kumar
0d41797a26
Fix: List Widget crashes on null empty object in data (#4349)
* filter null values in property pane autocomplete

* add hover states for list items

* add loading state in list

* fix loading state of list widget

* open list widget property on click of container

* fix isVisible bug in list widget children

* remove unused import

* add cusor pointer

* add focused state for first item in list widget

* fix empty state

* fix test case

* fix visiblity bug

* fix test case

* fixes for review comments

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-05-27 12:11:38 +05:30
Apeksha Bhosale
4825ce2a2a
Show JS eval errors in evaluated value pane and debugger (#4463)
Co-authored-by: jsartisan <pawankumar2901@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-05-26 18:02:43 +05:30
vicky.bansal@primathon.in
312ea00138 Increase width of default table widget so that scrollbars are not required by default 2021-05-26 10:22:08 +05:30
Yash
e34a156f18 FIX #4573 : added custom fusion chart config to override default message 2021-05-24 18:27:50 +05:30
Paul Li
c76ef9e3d7 FEATURE-2111 : Show/Hide Table Controls
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
2021-05-19 05:31:53 -04:00
Ashok Kumar M
8c8141650a
Feature: Widget grouping Phase I (Multi select and Bulk Delete) + Canvas Enhancements. (#4219)
* Feature: Canvas layer enhancements(DIP)

* feedback fixes

* fixing build

* dip

* dip

* dip

* fixing build

* dip

* dev fixes

* dip

* Fixing top bottom resize handles

* dip

* reposition widget name on top edges.

* dip

* dip

* dip

* dip

* renaming selectedWidget to lastSelectedWidget

* code clean up

* Fixing list widget as per grid scale.

* Fixing existing specs.

* Adding migration test cases.

* dip

* FIxing proppane in modal.

* fixing modal z-indedx.

* fix for modal name.

* dip

* dip

* dip

* adding test cases for hotkeys.

* dip

* dip

* fixing build

* Trying some performance improvements for jests.

* 17 mins with runinband lets try without it.

* minor bug fixes.

* code clean up

* save migrated app on fetch.

* fixing few cypress tests

* fixing cypress tests

* fixing cypress tests.

* fixing cypress

* updated DSL

* Addressing code review comments.

* test fails

* dip

* eslint fixes.

* fixing debugger cypress tests.

* updating latest page version.

* updating migration changes to cypress dsl's.

* updating chart data fixes for cypress tests.

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-18 23:59:39 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
bhavin
47a7128a06 Refactor: rename Dropdown to Select 2021-05-07 10:56:36 +05:30
abhishek nayak
10b8cdc32a
Update WidgetConfigResponse.tsx
Edited default table column size to remove scrollbar
2021-05-05 03:36:21 +05:30
abhishek nayak
782afcc6b0
Create WidgetConfigResponse.tsx 2021-05-01 04:57:16 +05:30
abhishek nayak
7623b99830
Update WidgetConfigResponse.tsx
1. Changed default text of dropdown widget, and radio button
2. Changed the font size of title of form widget to heading1 from paragraph
3. Changed default location of Google maps widget
2021-05-01 04:25:37 +05:30
Nikhil Nandagopal
9650dfe638
Merge pull request #4236 from appsmithorg/fix/table-data
fixed the column sizes
2021-04-30 14:55:19 +05:30
Nikhil Nandagopal
529114f57f fixed the column sizes 2021-04-30 13:49:13 +05:30
Somangshu Goswami
9caf953b41
Merge pull request #4128 from appsmithorg/fix/#4023-datepicker-incorrect-placeholder
[Bug-4023] : Incorrect placeholder in the datepicker widget
2021-04-29 21:21:36 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
Paul Li
aedac74d3a Merge branch 'release' into fix/#4023-datepicker-incorrect-placeholder 2021-04-29 05:54:24 -04:00
Nikhil Nandagopal
217b55697b
Merge pull request #4089 from appsmithorg/fix/table-data
Updated the default table data to guide users to connect a datasource
2021-04-27 14:14:23 +05:30
Ashok Kumar M
8f7cc87801
Fix: Tabs widget refactor with new nested property validation (#4014)
* dip

* test cases first commit

* Adding Tabs migrator.

* fixing tests.

* bug fix.

* selected tab fix

* missed commit

* fixing bugs

* Fixing tab name bugs.

* close property pane when dragging or resizing

* migration changes.

* release rebase changes.

* adding List factory

* remove dynamic bindings on deleting tabs.

* Adding validation messages for nested properties as well

* fixing validation issue.

* tabs visibility validation.

* missed commit

* Fixing broken cypress tests.

* Fixing broken tests.
2021-04-27 12:46:54 +05:30
Nikhil Nandagopal
edac5344d2 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:00:09 +05:30
Nikhil Nandagopal
165c7cdc78 removed unused imports 2021-04-26 18:59:53 +05:30