Commit Graph

13236 Commits

Author SHA1 Message Date
Valera Melnikov
3484a7b74c
fix: removing unused dependencies and explicitly installing used ones (#36573)
## Description
Removing unused dependencies and explicitly installing used ones.

The identification of dependencies was done using the
[knip](https://knip.dev/). Dependency lists are provided in the
appropriate files.
- [Unused
dependencies.txt](https://github.com/user-attachments/files/17161963/Unused.dependencies.txt)
- [Unused
devDependencies.txt](https://github.com/user-attachments/files/17161964/Unused.devDependencies.txt)
- [Unlisted
dependencies.txt](https://github.com/user-attachments/files/17161965/Unlisted.dependencies.txt)

EE PR — https://github.com/appsmithorg/appsmith-ee/pull/5229

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11100669672>
> Commit: 31b8da3dd07e452c8921526cd8e1336b11add27f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11100669672&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 30 Sep 2024 09:15:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced new dependencies to enhance functionality and
observability.
  
- **Bug Fixes**
- Removed outdated or unnecessary dependencies to streamline the
application.

- **Documentation**
  - Updated configuration files to improve clarity and maintainability.

- **Chores**
- Cleaned up various package files by removing unused dependencies
across multiple modules.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-30 12:28:46 +03:00
Jacques Ikot
6f27959bce
fix: Invalid Date Display in Table Widget's Date Column When Using Unix Timestamp (ms) (#36455)
## Description

**Problem**
When populating a table widget with data that includes dates in Unix
timestamp (milliseconds) format, setting the column type to "Date," the
input format to "Unix timestamp (ms)," and selecting a display format
leads to an issue during inline editing. While the date picker behaves
correctly, selecting a new date results in the table cell showing an
"Invalid Date" error.

**Root Cause**
The platform currently uses DateInputFormat.MILLISECONDS for Unix
timestamp (ms) formatting. However, this value is not a valid option for
the moment.format() function, which expects the input format to be 'x'
for Unix timestamps in milliseconds. This mismatch leads to the "Invalid
Date" error.

**Solution**
Modify the logic to map DateInputFormat.MILLISECONDS to the correct
moment format string 'x'.
Adjust the table's transformDataPureFn to correctly process and display
dates in Unix timestamp (ms) format after inline edits, ensuring the
moment library can handle the input properly.

**Outcome**
This fix ensures that when a user selects a date via the date picker in
inline editing mode, the selected date is displayed correctly in the
table without any errors.


Fixes #35631, #25081

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Binding, @tag.Table,
@tag.Datepicker"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11101758400>
> Commit: 6a3cae774f3824bd2ee126b501bfa4b6d71ae0c8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11101758400&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Binding, @tag.Table, @tag.Datepicker`
> Spec:
> <hr>Mon, 30 Sep 2024 08:54:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced date column editing in table widgets to accept Unix
timestamps in milliseconds without errors.
	- Introduced a new enumeration for improved date formatting options.
- Added mock data structures for testing various date formats and
transformations in the table widget.
- New method for generating formatted date strings for tomorrow in both
verbose and ISO formats.

- **Bug Fixes**
- Improved validation logic for date inputs in the table, ensuring
proper handling of different date formats.

- **Tests**
- Added new test cases to validate date handling and input formats in
the table widget.
- Introduced a new test suite for transforming table data based on
specified column metadata.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-30 10:02:42 +01:00
Rudraprasad Das
138cb7928f
fix: fixing modal height by removing min-content (#36589)
## Description
min-content css property is behaving weirdly in the latest update of the
chrome browser

Fixes https://github.com/appsmithorg/appsmith/issues/36586

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11084506553>
> Commit: a888acf77730a014fe6d708bf8ed9b48e0cb8029
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11084506553&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Sat, 28 Sep 2024 14:34:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Removed the minimum height constraint from the modal body, allowing
for more flexible vertical space allocation in the modal display.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-30 12:45:35 +08:00
Ankita Kinger
5995e4292a
chore: Handling the updation of action name in the plugin action toolbar (#36560)
## Description

Handling the updation of action name in the plugin action toolbar in the
new modularised flow.

Fixes [#36498](https://github.com/appsmithorg/appsmith/issues/36498)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11071023786>
> Commit: 73647e50cfeb6919b30c674f8f3a3a219f6f98c8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11071023786&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 27 Sep 2024 14:15:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new component for editing plugin action names, enhancing
user experience in managing plugin actions.
- Added optional icon size property to the editable text component for
improved customization.
- Enhanced the `CommonEditorForm` and `QueryEditorHeader` components to
display plugin-specific information and saving status.

- **Bug Fixes**
- Streamlined action dispatching logic, improving reliability in saving
actions.

- **Documentation**
- Updated interfaces and prop types for better clarity and type safety
in the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-27 19:48:05 +05:30
Rudraprasad Das
b1ed82dbcf
fix: fixed autocommit spec for airgap (#36579)
## Description
Changes autocommit test repo to a new airgap compatiable repo

## Automation

```
/test
cypress/e2e/Regression/ClientSide/Git/GitAutocommit_spec.ts
```

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11065723641>
> Commit: ed27652b4fe386f943a937e0e7efdc059700d779
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11065723641&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: ``
> Spec: cypress/e2e/Regression/ClientSide/Git/GitAutocommit_spec.ts
> <hr>Fri, 27 Sep 2024 06:55:15 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated the repository name in the autocommit tests to better reflect
current context.
	- Revised test suite tags for improved organization and focus.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-27 18:07:57 +08:00
Nilansh Bansal
e6cd97318d
feat: added LRU cache for mockDB connections (#36480)
## Description
This PR implements an LRU (Least Recently Used) caching mechanism for
the Mongo mockDB connections which get auto-cleaned up every 2 hours
based on their access time.
This is done to stop the overpopulation of the open dangling connections
to the mockDB resulting in the max connection limit.
The Caching Implementation used is [Google Guave
Cache](https://github.com/google/guava/wiki/CachesExplained).
Also refer - [Working of Guava cache
](https://medium.com/@alxkm/introduction-to-caching-with-google-guava-a-simple-and-flexible-solution-2c721427e72e)

<img width="811" alt="image"
src="https://github.com/user-attachments/assets/5abb3e05-13ea-421e-aaf0-22ac441f68e6">


Fixes #36474

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11066462645>
> Commit: 38fcf572b32f1b5d7544828ccf00f2b6fbaa180e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11066462645&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 27 Sep 2024 08:01:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new constant for the MongoDB plugin to enhance plugin
identification.
- Added a `DatasourcePluginContext` class to encapsulate datasource
plugin context, including connection details and creation time.
- Implemented a caching mechanism for datasource contexts to optimize
connection management and reduce excessive database connections.
	- Added functionality to identify mock MongoDB datasources.

- **Bug Fixes**
- Enhanced cleanup processes for stale connections in the caching
system.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-27 14:00:01 +05:30
Hetu Nandu
63682157ee
fix: Quick fixes for current state of Plugin Action Editor (#36574)
## Description

Fixes null values crashes in Plugin Action Editor


## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-09-27 11:41:15 +05:30
NandanAnantharamu
fc9a594a0a
test: replace 3rd party API1 CE (#36518)
Replacing the 3rd party API with TED API

/ok-to-test tags="@tag.Datasource"




<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11027894410>
> Commit: 0446747b46e74c3ea16b86578cab06fe04346b94
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11027894410&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Wed, 25 Sep 2024 07:37:49 UTC
<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2024-09-27 10:51:33 +05:30
saiprabhu-dandanayak
c2fcd512ad
fix:icon align when datatype is of image (#35992)
### Description


### [Bug Link](https://github.com/appsmithorg/appsmith/issues/35549)

I have raised this PR In-order to fix `alignment` of the `icon` in
`input component` when `datatype` is selected as `number` and position
is selected as `right`

### screenshot
### Before issue is resolved , icon dissapears

![image](https://github.com/user-attachments/assets/7d7f2865-5c88-458b-bf8f-cc4097f493ac)

### After the issue is resolved

![image](https://github.com/user-attachments/assets/9c4f1a65-e2c2-4725-bb94-723c512df70d)

### Cypress Testing 

![image](https://github.com/user-attachments/assets/597cd565-4269-463f-bbf2-ba0c078add3c)

### unit Testcases

![image](https://github.com/user-attachments/assets/71c75575-0c1d-40a4-a2f3-7b2f129a1097)

### Cypress Testing video

https://github.com/user-attachments/assets/3898144e-e84e-48b8-9ff1-9f449007cf41




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a customizable `rightElement` prop in the
`BaseInputComponent`, allowing users to display an icon on the right
side of the input field based on specified properties.
  
- **Tests**
- Added a new test suite for the `BaseInputComponent` to validate the
rendering and behavior of the component, including checks for icon
visibility and alignment.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-26 19:48:29 +05:30
Aman Agarwal
347dba5aca
fix: js library load functionality handling for default exports (#36539) 2024-09-26 16:58:39 +05:30
Manish Kumar
91bea3ea71
fix: added flags back (#36561) 2024-09-26 13:38:00 +05:30
NandanAnantharamu
cc9673757b
test: udpated 3rd party api for Commandclick nav spec (#36545)
replace 3rd API with TED
/ok-to-test tags="@tag.IDE"



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated the test suite to focus on command click navigation within the
IDE.
  
- **Bug Fixes**
- Adjusted the base URL for the data source in the navigation test to
reflect local development settings.

- **Chores**
- Modified the limited tests execution list to prioritize IDE command
click navigation tests over template-related tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11046090068>
> Commit: fd95c8bc6a69ad009ddc8377a1a3c2b20c7be033
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11046090068&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Thu, 26 Sep 2024 05:55:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2024-09-26 12:09:17 +05:30
Raushan Kumar Gupta
cdb22f4dfd
fix: mongo schema collections order of mongo plugin (#36062)
### PR Description: 
- **File changes in the PR**:
  - Integrated the sorting feature to the mongo collections.
  - Added the unit test for sorting.

Fixes https://github.com/appsmithorg/appsmith/issues/35842

- **Snapshots**:
  
  **Before resolving bug:**
  

![image](https://github.com/user-attachments/assets/34c04ebc-e81b-480c-9a54-1b643b68ffb2)
  
  **After resolving bug:**
  

![image](https://github.com/user-attachments/assets/fd7155e1-e261-491a-b912-7d482b8a9386)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the MongoDB plugin to return collection names in a
case-insensitive sorted order, improving predictability and user
experience.
  
- **Tests**
- Added a new test to validate that collections returned by the plugin
are sorted correctly, ensuring consistent functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-25 15:15:57 +01:00
Sagar Khalasi
73169d13b0
chore: Replacing ted api call for resources (#36472)
## Description
Remove third party url. 

Fixes `https://github.com/appsmithorg/appsmith/issues/36535`

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11031926377>
> Commit: bf5f2950598b16f4eadda81c1076d0c504e90be1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11031926377&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 25 Sep 2024 12:37:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Updated various image and URL references in test configurations to
point to local resources instead of external links, improving
consistency and performance during testing.

- **Bug Fixes**
- Corrected image source URLs in multiple test files to ensure proper
loading of images in the application.

- **Chores**
- Replaced outdated URLs with local Docker host URLs across numerous
test files and configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-25 19:41:00 +05:30
Pawan Kumar
2f2f5a6bf4
chore: Refactor API (#36412)
Fixes #36481 

/ok-to-test tags="@tag.All"

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11028542060>
> Commit: ed537d3958a3eba4502cbc32daf60c4cd814002d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11028542060&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 25 Sep 2024 08:56:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced API interaction with new default configurations for requests.
- Improved error handling with a centralized interceptor for managing
various API response errors.
- Introduced access control for specific API endpoints through blocked
and enabled route management.
- Streamlined environment-specific configurations for better
maintainability.
- Added functionalities for managing application themes, including
fetching, updating, and deleting themes.
- Introduced new API functions for retrieving consolidated page load
data for viewing and editing.
- Centralized access point for API services related to theming and
consolidated page load data.
- New modular structure for API request and response interceptors to
improve organization and maintainability.

- **Tests**
- Added unit tests for both API response and request interceptors to
ensure correct functionality and error handling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-09-25 16:29:21 +05:30
Manish Kumar
842443c267
chore: making autocommit GA (#36347)
## Description
- Removal of release_git_autocommit_feature_enabled flag
- Removal of fallback implementation to classes which was autocommit
flag annotated
- Removal of irrelevant test cases post removal of fallback
implementation.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10994151881>
> Commit: 42b43f19e4b47d70f8c9784ae1c4c67601d79412
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10994151881&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 23 Sep 2024 12:53:01 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced file operations for resource management in Git, including
methods for saving, deleting, and reading resources.
- Streamlined handling of auto-commit functionalities, making certain
features universally accessible.

- **Bug Fixes**
- Removed outdated fallback implementations for auto-commit eligibility
and Git auto-commit helpers.

- **Refactor**
- Simplified constructors and dependencies in file operation classes,
improving maintainability.
- Eliminated feature flag dependencies from various components,
including tests, focusing on core functionality.

- **Tests**
- Removed tests related to feature flags, streamlining the testing
process for auto-commit and migration functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: brayn003 <rudra@appsmith.com>
2024-09-25 14:32:01 +05:30
Hetu Nandu
a93e87ba18
chore: [Plugin Action Form] Common Editor State (#36512)
## Description

Passes the correct states for the Common Editor form in the Plugin
Action Form.
- Uses a hook to pass the form states as already implemented
- Uses helper functions to get the header and params count from the said
state
- As a side effect I can remove these from the original implementation
since the invocation is now in the common `RequestTabs` components
- Updates the `changeActionCall` hook to only be called if the action
changes
   - Updates the tests to reflect this

EE PR to track tests:
https://github.com/appsmithorg/appsmith-ee/pull/5217


Parts of #36154 



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced a custom hook for streamlined retrieval of action-related
values in forms.
  - Added utility functions for counting valid headers and parameters.

- **Improvements**
- Simplified component interfaces by removing unnecessary properties
related to headers and parameters.
  - Enhanced type safety for header and parameter properties.
  - Refined tab rendering logic for better user experience.

- **Bug Fixes**
- Adjusted logic to ensure actions are dispatched only on changes to
action IDs.

- **Documentation**
- Updated relevant documentation to reflect changes in component props
and functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-25 08:01:38 +00:00
Hetu Nandu
5ee7f83cdf
chore: Init Plugin Action Response (#36485)
## Description

Response Pane stuff

- Move Api Response into its own component and sub components
- Move Api Headers response into its own component and sub components
- A lot of these are also used by queries and js so maybe we will create
a common folder for that
- Add a logic to render the bottom tabs in the module. Allows for
extension via hook

Fixes #36155

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11026260058>
> Commit: c3b5b4b8f0e0668ff43adae1b22d320a5e6d347d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11026260058&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Wed, 25 Sep 2024 05:04:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new components for displaying API responses, including
`ApiFormatSegmentedResponse` and `ApiResponseHeaders`.
- Enhanced user interaction with a segmented control for switching
between different API response formats.
  
- **Improvements**
- Added utility functions for improved handling and validation of API
response headers and HTML content.
  
- **Bug Fixes**
- Improved error handling for API response states to ensure accurate
feedback during user interactions.

- **Chores**
- Added tests for new utility functions to validate their functionality
and ensure reliability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-25 13:14:26 +05:30
NandanAnantharamu
20fa8de803
test: fix test in airgap for canvas context prop (#36519)
This test spec was working fine on EE/CE this fix will handle scenario
in airgap environment

/ok-to-test tags="@tag.Sanity"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11026655789>
> Commit: f120b71d43a06123060ccfc3fcc0b3feb7b72d71
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11026655789&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 25 Sep 2024 05:41:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2024-09-25 12:26:59 +05:30
Ilia
199638229b
chore: move wds widgets to modules (#36511)
## Description



Fixes #36510
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11015252866>
> Commit: a5fae728c0f857b2ff62a4f6a3bc50b1b377c2bd
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11015252866&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 24 Sep 2024 14:30:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Chores**
- Updated import paths for various components and types to reflect a new
directory structure, enhancing organization and maintainability.
- Modified paths for multiple widgets including `WDSInputWidget`,
`WDSBaseInputWidget`, `WDSModalWidget`, and `MenuButtonWidget`, ensuring
consistent access to resources.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-24 18:04:02 +02:00
Aman Agarwal
2443b8ce9d
fix: js library default export to a unique name instead of default key in self (#36483) 2024-09-24 18:12:48 +05:30
albinAppsmith
9731728956
fix: Query instance failure caused by missing prepared statement obj (#36493)
## Description

Query instance was breaking because of missing prepared statement obj in
the action configuration.

PR caused this issue: https://github.com/appsmithorg/appsmith/pull/36407

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11007670447>
> Commit: 420801e87c807d4b3fda6c47c26df428fd49ea29
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11007670447&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 24 Sep 2024 07:04:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced logic for displaying warnings related to prepared statements,
improving user experience by streamlining checks.

- **Bug Fixes**
- Resolved issues with warning display for prepared statements, ensuring
accurate notifications based on user actions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-24 13:02:56 +05:30
albinAppsmith
4a70072b04
fix: initial store value fix for query response tab test case (#36487)
## Description
 
Initial state value was not having module instance data which cause test
failure in EE. This PR address this issue.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10997712576>
> Commit: 8877729aa15e313bdd6ab552f0658eba8e3211ed
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10997712576&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 23 Sep 2024 16:17:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated the test setup for the Query Response Tab to simplify the
store data initialization using a factory function.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-23 22:21:22 +05:30
albinAppsmith
12986df894
feat: Added warning message in response pane while prepared statement is on (#36407)
## Description

Added warning message in response pane to show that use prepared
statement is turned on. This will be showing up only if there is an
error.

Fixes #36326 

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10987691166>
> Commit: debc9f34515ee9303ac8e96d59cb8b59a6c5ecbf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10987691166&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource`
> Spec:
> <hr>Mon, 23 Sep 2024 05:25:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a warning message for users regarding prepared statements
that may cause query errors.
- Added a mechanism to navigate users to the settings page for resolving
issues related to prepared statements.
- Enhanced the Query Response Tab with contextual warnings and improved
user guidance.

- **Bug Fixes**
- Improved error handling related to prepared statements in the query
response.

- **Tests**
- Added comprehensive unit tests for the Query Response Tab to ensure
correct behavior of the prepared statement warning under various
conditions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-23 19:27:43 +05:30
Valera Melnikov
cd3472ac1d
chore: delete unused code (#36461)
## Description
The second round of deleting unused files, `.ts` were added to the
check.

[Related EE PR](https://github.com/appsmithorg/appsmith-ee/pull/5205)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10991435044>
> Commit: 7cfbcb9f9028c7cca5f06ae5a3836762e94214ec
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10991435044&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 23 Sep 2024 10:51:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Expanded project file scope to include JavaScript files alongside
TypeScript files.
- **Bug Fixes**
- Removed obsolete functions and constants related to help, tour, and
API functionalities, improving overall code clarity and maintenance.
- **Chores**
- Deleted several unused files and constants across various components,
enhancing project organization and reducing clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-23 13:52:00 +03:00
Jacques Ikot
8fe96c9c20
fix: isRequired validation property for table select column (#36375)
## Description

**Problem**
The select column of the table widget does not have a validation
property within its property pane to allow users add an isRequired
validation to the table select column.

**Solution**
Added a Validation section to the table select column's property pane,
which includes an isRequired toggle. When enabled, this feature will
trigger a visual indication (error border colour) around the select
widget if a required field is left unselected during "Add new row" or
inline editing.


Fixes #30091 

## Automation

/ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity,
@tag.Select"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10957896180>
> Commit: d2597e6a26938f2b99f2f997fca7bc110e5c2091
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10957896180&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity,
@tag.Select`
> Spec:
> <hr>Fri, 20 Sep 2024 12:23:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced end-to-end tests for Select column validation in Table
widgets.
- Enhanced validation logic to support Select column types in the Table
widget.
- Added visual feedback for required Select fields during row addition
and inline editing.
- Improved locator for single-select widget button control to enhance UI
interaction.

- **Bug Fixes**
- Improved error handling and visual representation for invalid editable
Select cells.

- **Documentation**
- Updated validation configuration to include Select column types for
better usability.

- **Refactor**
	- Enhanced code clarity for styled components related to Select fields.
- Modified method to improve versatility in handling table interactions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Sai Charan <saicharan.chetpelly@zemosolabs.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-09-23 08:44:46 +01:00
Manish Kumar
44f14865d7
fix: Unit test fix (#36471)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/10988998437>
> Commit: f59a3687d89d4e86a28c69fa7fec79190bc34ab3
> Workflow: `PR Automation test suite`
> Tags: `@tag.ImportExport`
> Spec: ``
> <hr>Mon, 23 Sep 2024 06:43:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Updated error message for clarity when importing an invalid JSON file,
ensuring consistent phrasing and capitalization.
- Introduced a standardized error message constant for improved
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-23 12:40:20 +05:30
Diljit
7685c852cc
chore: fix this.rootSpan undefined bug in PageLoadInstrumentation (#36459) 2024-09-23 08:21:07 +05:30
Rudraprasad Das
e798ec66e7
fix: fixing cta for git import modal (#36364)
## Description
Fixes CTA for git import modal to "Import App"

Fixes https://github.com/appsmithorg/appsmith/issues/32388

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10958198926>
> Commit: 3a4468f2750b956618a39de3f89315ecce9f372d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10958198926&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 20 Sep 2024 11:44:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new call-to-action message for importing an app,
enhancing user guidance.
- Improved the Git connection process by providing context-sensitive
messages based on the import state.

- **Bug Fixes**
- Adjusted the text displayed during the Git connection steps to reflect
the import status dynamically.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 23:55:36 +08:00
Ankita Kinger
0ad0989a55
chore: Adding a new hook to set settingsConfig for an action based on IDE type (#36442)
## Description

Adding a new hook to set `settingsConfig` for an action based on IDE
type. This is being used in PluginActionEditor in the new modular flow.

Fixes #36438 #36439 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10955776812>
> Commit: 447d926c31c6e26922bb24851c68727bec14d1ae
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10955776812&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 20 Sep 2024 10:12:39 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced a new hook, `useActionSettingsConfig`, for simplified
access to plugin action settings.
- Updated the `PluginActionEditor` to utilize the new hook, enhancing
the logic for retrieving plugin settings.
- Added a re-exporting mechanism for `useActionSettingsConfig` to
improve organization within the Plugin Action Editor.
- **Improvements**
- Streamlined the process of accessing plugin configurations, improving
overall code clarity and maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 19:37:10 +05:30
Abhishek Pandey
54a0f2b3c0
fix: show bindings menu does not appear in split mode (#36378)
## Description
Issue: Show bindings menu does not appear in split mode.

This PR addresses issue
https://github.com/appsmithorg/appsmith/issues/35775 by updating `left`
style property appropriately based on the editor view mode (split
screen/full screen).

Fixes https://github.com/appsmithorg/appsmith/issues/35775 
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the responsiveness of the EntityProperties component by
adapting its layout based on the IDE view mode, improving user
experience across different interface configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 16:49:22 +03:00
Manish Kumar
9bbf794a85
chore: removed non reactive json migration (#36413) 2024-09-20 17:42:21 +05:30
Rudraprasad Das
e89fb0c2e4
fix: loading state for pull (#36363)
## Description
Fixes issue of missing loader when pulling changes from remote

Fixes https://github.com/appsmithorg/appsmith/issues/36273
Fixes https://github.com/appsmithorg/appsmith/issues/31308

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10958207646>
> Commit: 4b8a1175b3728c6c743f46b08998ce74e3308bbc
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10958207646&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 20 Sep 2024 11:44:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Introduced a new selector to track the progress of pull operations.
- Enhanced loading state logic to reflect multiple concurrent Git
operations.

- **Bug Fixes**
- Improved accuracy of loading state for pull actions and discard
operations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 19:49:39 +08:00
Abhijeet
c6eaed4ca6
chore: Disable MSSql tests as test container is unable to accept connection (#36451)
## Description
Ref:
https://theappsmith.slack.com/archives/C02GAUE9P5H/p1726806965773469

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
eab6cefe70e63404475892b31785ff5f35bbb90e yet
> <hr>Fri, 20 Sep 2024 10:21:35 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Disabled test execution for the `MssqlGetDBSchemaTest` class to
improve test suite performance.
- Disabled test execution for the `MssqlPluginTest` class to streamline
testing processes.
- Disabled test execution for the `RedisPluginTest` class to enhance
overall testing efficiency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 17:09:57 +05:30
Sagar Khalasi
1cf043c40a
fix: Inline editing flaky test fix (#36366)
## Description

EE PR: [Appsmith EE Pull Request
#5158](https://github.com/appsmithorg/appsmith-ee/pull/5158)

Root Cause Analysis (RCA):
The `updateCodeInput` function was identified as a source of flakiness
due to improper execution. Additionally, the `SaveLocalStorageCache`
caused issues by retaining the reset button after the 6th test case,
resulting in a duplicate button in the 7th test case, which led to test
failures.

Solution:
Replaced `updateCodeInput` with `EnterJSContext` from `agHelper` for
more reliable execution. For the second flaky step, a new page was
created, and a table with relevant data was added. This resolved the
issue without requiring significant changes to the test case or
workflow.

Fixes #`36365`  

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10940196158>
> Commit: 32d1be4c3dfe54bf8a0f8e9f54b20d2845c86407
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10940196158&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.ImportExport`
> Spec:
> <hr>Thu, 19 Sep 2024 12:01:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted the inline editing test suite for the table widget to improve
state management between tests.

- **New Features**
- Updated the limited tests to focus on inline editing functionality,
enhancing testing priorities for the Table V2 widget.
- Introduced new properties in the widget locators to enhance UI
interactions, including selectors for various controls and elements
within the property pane and cell editing functionalities.
- Added a new JavaScript toggle selector to facilitate interactions in
tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 12:44:14 +05:30
Rahul Barwal
6507f90e05
fix: Incorrect updation of selctedRowIndex when primary column is set. (#36393)
## Description
<ins> Problem statement </ins>
1. Table should have a primary column set.
2. The table should be filtered(via search or client side filters)
3. there should be a selectedRow in table
a. One way to ensure is add a text widget and bind it to table's
`selectedRowIndex` property.

If you now run a query that updates the data behind the table: the
`selectedRow` is updated to (seemingly) random row and selectedRowIndex
is updated as well

<ins> Rootcause </ins>
We have a mechanism of preserving `selectedRow` when data updates
happen.
Underlying logic gets the previous selected row and tries to find it in
the new data using the primary key.
* If it finds it, it updates the selectedRowIndex to the
`__original_index__` of the found row i.e. its position in the original
data before any filters were applied.

<ins> Solution </ins>
We update the selectedRowIndex to the index in the new filtered data.

<ins> How to test </ins>
1. Create a table with a primary key
2. Add a text widget and bind it to table's `selectedRowIndex` property
3. Filter the table
4. Click on a row to select it
5. Run a query that updates the data behind the table
6. Assert that the selected row is the same and that the
selectedRowIndex is updated to the new index


Fixes #36080
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10953679202>
> Commit: 1a2d64467e453229940b67b29da1ce9d0e9ac24d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10953679202&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table, @tag.Binding, @tag.Sanity`
> Spec:
> <hr>Fri, 20 Sep 2024 06:30:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Improvements**
- Enhanced the efficiency of the TableWidgetV2 by streamlining the
method for retrieving the index of selected rows.
- Improved code readability and maintainability without altering the
overall functionality.

- **New Features**
- Introduced new test cases to validate filtering and searching
functionalities within the Table Widget V2.
- Added a JSON configuration for a data-driven table interface,
supporting sorting, filtering, and dynamic data binding.
- Introduced fixture data for testing, allowing for comprehensive
validation of table behavior under various conditions.
- Added a JavaScript object containing employee data to facilitate
filtering and display in the table.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 12:25:23 +05:30
Diljit
b1aca5d502
chore: add reo client sdk to index.html (#36408)
## Description
Add Reo client sdk

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10935820624>
> Commit: 272e10efc33086ef5a30e19b65e197cabc7f4559
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10935820624&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 19 Sep 2024 07:12:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Integrated Reo services into the application, enabling enhanced
functionality.
- Dynamic loading of the Reo JavaScript SDK based on configuration
settings.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 10:51:45 +05:30
Hetu Nandu
305268d3ab
chore: [Plugin Action Editor] CommonEditorForm (#36380)
## Description

Extracted certain parts of the `CommonEditorForm` to be re used in the
new modular approach. The left out areas are not part of the form
(Toolbar or Response) and other presentational logic.

As a test, API Editor is being rendered.

Post this, I will be extracting out the transformation logic in forms
and place them, refactor and re organise it.

EE PR for testing: https://github.com/appsmithorg/appsmith-ee/pull/5179


Parts of #36154

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10939684892>
> Commit: b2a220925a6d5186a82eb50297d2fe5ab9a0755b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10939684892&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Thu, 19 Sep 2024 11:45:15 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced `APIEditorForm` for editing API actions, enhancing user
interaction.
- Added `CommonEditorForm`, `InfoFields`, `RequestTabs`, and
`HintMessages` components for improved API action management.
- Enhanced `DatasourceConfig` for managing key-value pairs related to
data sources.

- **Improvements**
- Streamlined the API editor interface by removing unnecessary
components and simplifying logic.
- Improved tab management with a custom hook for better user experience.
- Added support for predefined HTTP methods in the `GraphQLEditorForm`.
- Enhanced rendering logic in `RestAPIForm` to always display the
`PostBodyData` component.

- **Bug Fixes**
- Removed deprecated functions and selectors related to the API right
pane tab management.

- **Chores**
- Refactored imports for better organization and clarity across
components.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-20 10:45:01 +05:30
Ayush Pahwa
cbf8291d9c
chore: add telemetry for current linter (#36417) 2024-09-20 11:59:08 +08:00
Abhishek Pandey
66270b44b1
fix: duplicate page name error does not disappear on navigating to other pages (#36320)
## Description 
**Issue:** Duplicate page name error does not disappear on navigating to
other pages.

This PR addresses issue #35949 by resetting the isPageNameValid state to
undefined using useEffect hook when the Page settings loads.

Fixes #35949 

> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved page name validation by resetting its state when the page
data updates, ensuring accurate checks based on new information.
- **Style**
	- Minor formatting adjustment for better code readability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-19 19:20:25 +03:00
Valera Melnikov
c76e6c031c
chore:delete unused files (#36368)
## Description
I used [knip](https://knip.dev/) to identify unused files. There will be
a few more related PRs, after that I will add CI check for this.

Fixes #35778

Related EE PR https://github.com/appsmithorg/appsmith-ee/pull/5165

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10940962461>
> Commit: 31749570e9a3f9e4cce250eedba4ec18aace23f9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10940962461&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 19 Sep 2024 12:55:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-09-19 16:01:03 +03:00
Sagar Khalasi
9e7fa1d725
chore: Added sanity and tags for blank tag specs (#36421)
## Description
Added relevant tags with sanity tags.

Fixes `https://github.com/appsmithorg/appsmith/issues/36415`

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10938122144>
> Commit: 8383cf735da821760853af77f232b5c992904a19
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938122144&attempt=4"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 19 Sep 2024 11:41:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced test suites with additional `@tag.Sanity` tags for improved
categorization and organization.
	
- **Bug Fixes**
- Updated various test suite tags to include `@tag.Sanity`, ensuring
comprehensive coverage of functionalities.

- **Documentation**
- Improved tagging structure across multiple test suites for better
clarity and maintainability.

- **Chores**
- General modifications to existing test suite descriptors to include
new tags without altering core functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-19 18:21:58 +05:30
Ankita Kinger
b30d86ec6e
chore: Calling changeApi and changeQuery actions based on PluginType when plugin action form component is mounted (#36398)
## Description

Calling `changeApi` and `changeQuery` actions based on PluginType when
plugin action form component is mounted in the new Plugin action
modularisation flow.

Fixes #36344 #36345 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10939522143>
> Commit: 528977f7e9aed43a6429a2a3c9aa7430e1183b91
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10939522143&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 19 Sep 2024 12:26:12 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new hook, `useChangeActionCall`, to enhance action
management within the IDE.
- Integrated `useChangeActionCall` into the `PluginActionForm` component
for improved interactivity.

- **Tests**
- Added unit tests for the `useChangeActionCall` hook to ensure correct
action dispatching based on plugin context.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-19 18:14:26 +05:30
Valera Melnikov
bb0ec5ce9d
fix: disable anvil snapshots tests (#36422)
## Description
Disable all Anvil snapshot tests. The tests will be enabled after
solving the #36419.

Related thread
https://theappsmith.slack.com/archives/C025SE88KNE/p1726721979435589

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10938186194>
> Commit: ee5c8f40eb3873bd9db8d9b7ca4c3519d989a038
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938186194&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 19 Sep 2024 11:14:18 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Temporarily skipped multiple test suites for various Anvil widgets due
to unresolved issues, preventing potential false negatives in testing.
- Specific tests affected include those for Modal sizes, App Theming,
Button, Checkbox, Currency Input, Heading, Icon Button, Inline Button,
Input, Paragraph, Phone Input, Radio Group, Stats, Switch Group, Switch,
Table, Toolbar Button, and Zone Section Widgets.

These adjustments ensure the integrity of the testing process while
issues are being addressed.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-19 14:22:21 +03:00
Ayush Pahwa
163bde4027
chore: Revert "feat: telemetry added for current linter (#36400)" (#36411)
This reverts commit 6ab9684b73.

## Description
PR to revert changes made in telemetry for linter


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/test js

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10936319851>
> Commit: 00ef3209fe35ed23db8aa7df0958f95359eb1363
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10936319851&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Thu, 19 Sep 2024 07:56:21 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Simplified linting process by removing telemetry-related
functionality.
  
- **Bug Fixes**
	- Improved performance and maintainability of the linting process.

- **Refactor**
- Updated method for retrieving keys from an object to use standard
JavaScript functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-19 13:50:24 +05:30
Rahul Barwal
aa18a4f46d
chore: Removes unused feature flag ref (#36416) 2024-09-19 13:49:52 +05:30
NandanAnantharamu
006dbfd46a
test:Fix canvas context prop01 (#36391)
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159

RCA:
The property section related validations were not working

Solution:

Enhanced verification of property pane section visibility using
accessibility attributes.
Introduced new UI interaction properties for managing collapsible
sections.

/ok-to-test tags="@tag.IDE"

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10923368993>
> Commit: c996a38fba4d94cf80baf574d6ad3db75b2bb8cf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10923368993&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 18 Sep 2024 14:10:07 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved test logic for verifying the state of property pane sections,
enhancing accessibility compliance.
- Updated limited tests to include new test specifications for the
property pane.

- **Bug Fixes**
- Enhanced robustness of tests by refining visibility state checks using
ARIA attributes.

- **Chores**
- Expanded locator capabilities in the testing framework to support new
UI components related to collapsible sections.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2024-09-19 11:39:44 +05:30
Diljit
c2521fae81
chore: Page load instrumentation: add network and device info to page load spans (#36395)
## Description
- Remove page visibility change listener in Page load instrumentation.
The page visibility data is not working as expected.
- Add `otlpSessionId` and `appMode` attributes to all PageView and
PageViewTimings data pushed by the new relic browser agent. This will
help us infer session based information and join reports with Page load
Spans
- Add network and device specific attributes to the `PAGE_LOAD` span


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10934682384>
> Commit: de172593ce8d7782fb526d3294e8a63155e3c849
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10934682384&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 19 Sep 2024 05:22:19 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced telemetry data collection during page load events, capturing
device memory and network attributes.
- Introduced functionality to gather operating system details (name and
version) for improved telemetry insights.
- Improved integration with New Relic for detailed monitoring through
custom attributes.

- **Bug Fixes**
- Removed outdated logic for tracking page visibility, focusing on more
relevant metrics.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-19 11:06:14 +05:30
Ayush Pahwa
6ab9684b73
feat: telemetry added for current linter (#36400) 2024-09-19 11:54:04 +08:00
Ilia
d6f249b42d
chore: add blank line eslint rule (#36369)
## Description
Added ESLint rule to force blank lines between statements. 


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10924926728>
> Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
> <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Wed, 18 Sep 2024 16:33:36 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No

---------

Co-authored-by: Valera Melnikov <valera@appsmith.com>
2024-09-18 19:35:28 +03:00