Commit Graph

3065 Commits

Author SHA1 Message Date
Somangshu Goswami
559555f175
Merge pull request #4485 from appsmithorg/bug/select-optionmenu-scroll
fix: select disabled option popover overflow
2021-05-18 20:01:06 +05:30
Somangshu Goswami
c233dc1273
Merge pull request #4313 from appsmithorg/fix/datepickerwidget-popover
fix: datepicker popover adjust height and width.
2021-05-18 20:00:04 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
Satish Gandham
faeac974ca - Remove code casuing expensive style recalculation 2021-05-18 17:48:29 +05:30
akash-codemonk
51b98eed2f
Fix: Debugger shows errors for evaluations done on page load (#4552) 2021-05-18 17:21:32 +05:30
arunvjn
4733edfccd
Fixed query params parsing in API pane (#4482)
* Fixed query params parsing when there are mulitple "="s.

* Added cypress tests to validate query params parsing
2021-05-18 17:17:43 +05:30
arunvjn
08966499be
Remove request/response data from copies of an executed API (#4521) 2021-05-18 17:17:22 +05:30
Shrikant Sharat Kandula
1e052a9462
Fix redirectUrl not being encoded (#4546) 2021-05-18 11:22:54 +05:30
Apple
5abd651e25 updated test 2021-05-17 21:36:46 +05:30
akash-codemonk
cbace9d5d7
Fix: Debugger showing previous application logs (#4455) 2021-05-17 15:31:22 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Satish Gandham
bed4b39561
Merge pull request #4292 from appsmithorg/perf/optimize-table-widget
Optimize table widget
2021-05-17 14:52:49 +05:30
Apeksha Bhosale
e4ee2b07c9
r.match on API pane error (#4497)
* r.match on API pane error

* Pr comment fixed
2021-05-17 12:51:48 +05:30
arunvjn
67e292cc2a
Fixed handleSubmit bug in API form editor (pagination buttons) (#4477) 2021-05-15 00:13:08 +05:30
bhavin
cab7f4a099 fix: select disabled option popover overflow 2021-05-14 14:53:22 +05:30
arunvjn
341a4d62af
Bug/paste widget append copy to name (#4399)
* Changes to retain widget/Action names on copy when there is no clash.

* Updated tests

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-14 14:35:55 +05:30
NandanAnantharamu
b66692ba57
Test commented (#4476) 2021-05-14 12:32:25 +05:30
arunvjn
068e4065d7
Expose response headers for API/DB actions (#4336)
* Expose response headers for API/DB actions

* Added responseMeta to actions datatree

* Modified cypress test to account for responseMeta

* Modify cypress test case

* More test changes

* Modified tests
2021-05-14 12:21:09 +05:30
NandanAnantharamu
fb8b6d1995
updated method to print response (#4473) 2021-05-13 21:27:19 +05:30
Trisha Anand
377629955d Revert "Init minor comment"
This reverts commit 2b7212da8c.
2021-05-13 20:01:37 +05:30
Trisha Anand
2b7212da8c Init minor comment 2021-05-13 19:52:54 +05:30
Satish Gandham
d27dcca678 - Remove jsx-no-bind and noshadow eslint rules 2021-05-13 17:50:04 +05:30
Satish Gandham
8ecac87ec7 Change the cell renderer function from class property to inline and use JSON.stringify to do the comparision. 2021-05-13 17:38:15 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Nidhi
ea451ef061
Add default configs for prod and tests (#4464)
* Added default cs config for prod and tests

* Env variable for new installations

* K8s defaults
2021-05-13 13:30:23 +05:30
Satish Gandham
8f1cc88b7d Merge branch 'release' into add-more-eslint-rules 2021-05-13 12:47:50 +05:30
Satish Gandham
f2d228c346 - Add no shadow eslint rule 2021-05-13 12:41:11 +05:30
Apeksha Bhosale
66c7a0b252
Revert "Separating js error and validation error for debugger (#4361)" (#4447)
This reverts commit c6a8f81d60.
2021-05-13 09:50:30 +05:30
NandanAnantharamu
fb7db810da
Updated Cypress locator for product updates test (#4454) 2021-05-12 17:43:11 +05:30
Pawan Kumar
cc36bdc051
Fix: TypeError: t.match is not a function (#4445)
* add is number check before setting widget property

* use toString of lodash

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-12 13:27:28 +05:30
Apeksha Bhosale
c6a8f81d60
Separating js error and validation error for debugger (#4361)
* separate js error and validation error

* PR comments fixed and added error for pageload action

* reverted to jsError message property

* small check for empty errors

* small changes for Test to pass

* space was missing for test case

* removed console statement
2021-05-12 12:10:32 +05:30
Ashok Kumar M
3eeaf86097
Fix: Resize doesn't react as intended for top/bottom handles. (#4321) 2021-05-11 20:09:33 +05:30
Satish Gandham
8bd947671d Move the expensive getBoundingReactangle call to isColliding function to avoid unnecessary calls. 2021-05-11 20:09:09 +05:30
Satish Gandham
68c258ab3a - Remove unncessary anonymous funciton
- Use destructured imports
2021-05-11 12:25:42 +05:30
vicky-primathon.in
56f0ba716b Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-11 12:10:26 +05:30
vicky-primathon.in
78bad85e24 Used useCallBack hook and remove inline arrow function 2021-05-11 12:10:13 +05:30
Satish Gandham
812e893eee - Add name to memoized resizableComponent 2021-05-11 12:03:07 +05:30
Satish Gandham
8763f9518b - Memoize EditorContext value
- Change mapDispatchToProps to object form
2021-05-11 12:02:24 +05:30
akash-codemonk
d6de913949
Revert "Feature: Show widget error state (#4202)" (#4406)
This reverts commit bf7a8b91a4.
2021-05-11 09:40:43 +05:30
abhishek nayak
1276edf517
Update DropdownWidget.tsx
Updated the default value to something that doesn't fail.
2021-05-11 03:19:03 +05:30
Apeksha Bhosale
2138c9059b
match is not a function (#4409) 2021-05-10 19:40:22 +05:30
arunvjn
1b98c2e520
Revert Gsheets warning modal (#4405) 2021-05-10 19:39:26 +05:30
Tolulope Adetula
57a621978d Merge branch 'release' into pr/3791 2021-05-10 14:33:01 +01:00
arunvjn
3b61af395e
Fix/text overflow json viewer (#4367)
CSS fix to wrap long urls/text in json viewer. GSheets to occupy full width
2021-05-10 18:58:38 +05:30
NandanAnantharamu
408517de39
Datasource test with basic profile added (#4374) 2021-05-10 17:27:54 +05:30
vicky-primathon.in
f14ca6b6c3 Hide sub icon 2021-05-10 17:04:17 +05:30
vicky-primathon.in
97178ea899 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-header-styles 2021-05-10 16:56:37 +05:30
vicky-primathon.in
9ab8da4671 Table header style changes 2021-05-10 16:54:50 +05:30
Pawan Kumar
fc10625d41
Fix: Cannot read property 'label' of undefined & Cannot read property 'length' of undefined (#4389)
* fix for label of undefined

* add check for data type

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-10 15:22:17 +05:30
vicky-primathon.in
aa5beddf4a Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-10 15:08:48 +05:30
vicky-primathon.in
30510c56b4 Fix download dropdown UI 2021-05-10 15:08:23 +05:30
bhavin
4c824a1214 fix: datepicker popover adjust height and width. 2021-05-10 13:14:29 +05:30
akash-codemonk
359d104f5f
Show debug button in toast only for some particular errors (#4311) 2021-05-10 13:13:12 +05:30
akash-codemonk
78ccfadb61
Fix: Make contents of tab selectable (#4390) 2021-05-10 13:08:39 +05:30
Somangshu Goswami
d4e3de6330
Merge pull request #4359 from appsmithorg/fix/dropdown-rename-select
Refactor: Rename Dropdown to Select
2021-05-10 11:25:24 +05:30
Somangshu Goswami
1864166fdc
Merge pull request #4285 from appsmithorg/fix/date-time-picker-bug
change data-time format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss'
2021-05-10 11:21:42 +05:30
akash-codemonk
bf7a8b91a4
Feature: Show widget error state (#4202) 2021-05-07 20:03:20 +05:30
Nidhi
4a288439f0
Added basic authentication type to REST APIs (#4040)
* Added basic authentication type to REST APIs

* Spacing for prefix

* Tests and json ignore for password

* Client side form changes

* Review comments
2021-05-07 17:24:05 +05:30
Satish Gandham
c86390ebfe - Collapse all but the first two records in react-json-view 2021-05-07 15:22:53 +05:30
arunvjn
45aa3c57f1
Added null check against datasource url (#4352) 2021-05-07 13:24:58 +05:30
Nidhi
51aee58c54 Bearer prefix without space 2021-05-07 12:35:34 +05:30
bhavin
47a7128a06 Refactor: rename Dropdown to Select 2021-05-07 10:56:36 +05:30
Tolulope Adetula
213d7e0c58 Merge branch 'release' into pr/3791 2021-05-06 19:04:14 +01:00
arunvjn
65d33c2614
Fixed query params parsing in API pane when dynamic bindings are present in the URL (#4205) 2021-05-06 18:45:05 +05:30
Trisha Anand
ee14571ffc
[Bug Fix] : Removal of cyclical dependencies due to action relationships being added to dependency map (#4342) 2021-05-06 18:28:06 +05:30
vicky-primathon.in
a5dbb5261b Added test case to validate onSearchTextChange function if configured in table widget 2021-05-06 13:54:18 +05:30
Satish Gandham
f193ff4a21 - Remove the accidental recursive funciton call in tablewidget 2021-05-06 12:01:39 +05:30
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Satish Gandham
abf7277d20
Merge pull request #4240 from appsmithorg/perf/optimize_react-json-viewer
Memoize CurrentValueViewer to prevent expensive rerenders of react JSON viewer
2021-05-05 18:18:05 +05:30
Trisha Anand
218ac82e7f
During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path. (#4315)
* During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path.

* To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist.

* Revert "To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist."

This reverts commit c494932289e33287074c56844fbf76c8418875af.

* Disabling cypress test which asserts cyclical errors when depending on yourself
2021-05-05 17:55:39 +05:30
Rishabh Saxena
95f3cb8a9a
Log an analytics event for cyclical dependency errors (#4323) 2021-05-05 16:51:15 +05:30
Trisha Anand
6cf3b8a901
In case the chart series data id starts with a number, it was incorrectly identified as a number instead of a string which led to incorrect path computed to check in binding paths (#4322) 2021-05-05 16:50:59 +05:30
Kaushik Varanasi
984119e9cb
Feature: auto create organisation Fixes #2720 (#3922)
* added basic function structure for creating organization

* added functionality for automatically creating an organization with 'Untitled organization 1' like applications. Need to add tests.

* added test for creating organizations with default names

* added tests for creating org with default name

* updated jest tests to not fill in the organization form

* remove unused imports

* deleted unnused files

* added more test to check invite users to application and check that the create application is visible

* updated share application tests according to the new workflow

* fix failing tests. TODO: fix tests with renameRandomOrg to rename specific org

* remove rename random org and rename specific orgs

* remove blocking code so the element can be scrolled into view

* fix tests

* try to fix flaky tests

* remove unused

* remove create organization tests as we are testing these components elsewhere

* fix failing tests by stubbing create org response

* update tests according to new workflow
2021-05-05 12:40:35 +05:30
vicky-primathon.in
e96fa63f6d Disable client side search when server side search is enabled in table widget 2021-05-05 12:39:15 +05:30
Somangshu Goswami
fd6709b29a
Merge pull request #4119 from appsmithorg/fix/date-input-edit
Fix date string parsing for date from input field
2021-05-05 12:08:16 +05:30
Somangshu Goswami
0a0d9794dd
Merge pull request #4099 from appsmithorg/fix/#3860-input-widget-validation
[Bug] : Input widget validation issues#3860
2021-05-05 12:06:59 +05:30
Somangshu Goswami
6d41a4eb27
Merge pull request #4211 from appsmithorg/fix/4134-table-filter-case-insensitive
Fix/4134 table filter case insensitive
2021-05-05 12:02:27 +05:30
bhavin
a29b20eca5 fix: set date picker calendar popover position to bottom 2021-05-05 11:53:59 +05:30
Satish Gandham
4543bcc39e Add eslint rule to warn against inline functions in jsx 2021-05-05 11:37:12 +05:30
abhishek nayak
10b8cdc32a
Update WidgetConfigResponse.tsx
Edited default table column size to remove scrollbar
2021-05-05 03:36:21 +05:30
Abhinav Jha
b508e37387
Fix DEFAULT_OPTION_VALUE validations which were breaking evaluations (#4295) 2021-05-04 22:42:15 +05:30
akash-codemonk
6ad40de1e5
Fix undefined error in debugger sagas (#4291)
Use correct types and check if validationMessages exists as it could be undefined
2021-05-04 20:12:42 +05:30
Satish Gandham
611a07af75 Add eslint rule to sort destructure keys 2021-05-04 19:45:29 +05:30
Apeksha Bhosale
8473226382
app crashes when moving from google to rest api (#4282)
* app crashes when moving from google to rest api

* wrong url for test
2021-05-04 18:38:20 +05:30
bhavin
5f9497a627 date format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss' 2021-05-04 16:39:05 +05:30
Satish Gandham
adb5f7bc7a - Memoize ReactTableComponent 2021-05-04 16:30:57 +05:30
Rishabh Saxena
99c302e018
Fix update application test (#4281) 2021-05-04 14:31:19 +05:30
Satish Gandham
30b33331a2
Fix cyclic dependency making the table widhget crash the app. #4209 (#4214)
- Check if sanitizedTableData is array

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-05-04 13:04:35 +05:30
Kaushik Varanasi
7af0faa32e
Feature: Fork apps across orgs : fixes #3089 (#4121)
* create basic button for forking

* added menu item for fork, opens a basic modal. TODO: Add functionality to fork

* clicking fork app enables organization select and forks across applications

* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible

* removed unused code

* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing

* tests fixed, but needs unexpected login from cy

* Resolved bug with login by using correct cypress selectors

* Added tests to check that dsls match, added documentation and removed unused code

* remove unused fork function and directly dispatch from modal

* refactor code

* revert

* removed unused code and refactored tests

* feature/fork-apps-across-orgs-refactor

* make code prettier

* renamed components correctly

* refactored modal code into single file. TODO: fix warnings, test and remove unused code

* pass setModalClose to dialog component to maintain global modal state

* Added types for fork modal props

* update tests and remove unused code

* Removed isDeployedApp and instead passed trigger as a prop

* remove console logs and revert imports to small case

* rename files as components

* minor changes

* cleanup

* mock dispatch for jest

* move jest mocks to component tests
2021-05-04 11:34:23 +05:30
arunvjn
da0abfb2bf
CSS fix to wrap long urls/text in json viewer (#4269) 2021-05-04 11:17:09 +05:30
Satish Gandham
2a3d0fd28e - Destructure TableComponent props 2021-05-04 00:12:21 +05:30
Nidhi
8596f51921
New privacy policy (#4267)
* New policy

* Minor styling
2021-05-03 22:54:03 +05:30
abhishek nayak
edfe965cf7
Merge pull request #4248 from appsmithorg/areyabhishek-patch-2
Update WidgetConfigResponse.tsx
2021-05-03 20:28:44 +05:30
arunvjn
2956953955
Feature/gsheet warning modal (#4258)
Added modal to inform the users about google sheet warnings and events to monitors sheets usage.
2021-05-03 17:43:37 +05:30
Nidhi
446220515f
Added limited use disclosure (#4261)
* Added limited use disclosure
2021-05-03 16:28:51 +05:30
Satish Gandham
e3b361a8d4 Change inline functions in jsx to class properties 2021-05-03 14:33:03 +05:30
akash-codemonk
c36b1ffa04
Update debugger analytics events (#4186)
- Send analytic event for tab change in api and query pane

- Also update debugger text

- Send open debugger analytic event while opening from shortcut
2021-05-03 13:38:49 +05:30
Ashok Kumar M
4350da7da3
Fix: Updating help text for tabs widget after refactor. 2021-05-03 13:12:57 +05:30
Rishabh Saxena
81a2bfa067
Fix storybook build (#4087) 2021-05-03 11:19:12 +05:30
Pawan Kumar
923cbcd595
Fix: Validation on grid gap + handle delete child on list widget (#4247)
* handle delete case for list widget

* add check for grid grap validation

* update test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-03 10:31:47 +05:30