Commit Graph

1598 Commits

Author SHA1 Message Date
Sumesh Pradhan
1f5223c01d
ci: docDB int test wait for appsmith health before cypress (#26655) 2023-08-25 15:27:48 +05:30
Saroj
193f4849a7
ci: Add env variables to ci test limit and hosted workflow to use internal cypress db (#26656)
## Description
- Add env variables to ci test limit and hosted workflow to use internal
cypress db
#### PR fixes following issue(s)

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
 - CI Run
2023-08-25 15:06:19 +05:30
Saroj
301852dcd7
test: Fix cypress local run (#26652)
## Description
 - Fix cypress local run
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-25 15:06:05 +05:30
Sumesh Pradhan
97d3c03b7e
Ci/cypress on doc db fix (#26645) 2023-08-25 12:15:15 +05:30
Saroj
edbbefd979
chore: Changes to enable internal cypress dashboard (#26626)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-25 10:21:12 +05:30
Sumesh Pradhan
8640c27d37
ci: cypress on doc db fix (#26637) 2023-08-25 10:15:05 +05:30
Sumesh Pradhan
5f79a6e638
ci: cypress and perf tests on documentDB (#26616)
Runs cypress and perf tests on an Appsmith instance with an existing
DocumentDB backend instead of MongoDB.

Comment to trigger the run on a PR:
`/ok-to-test-with-documentdb`
2023-08-24 18:07:33 +05:30
Abhijeet
4d6fc662d6
chore: Add JUnit option for the testcase type in PR template (#26560) 2023-08-22 15:15:44 +05:30
Shrikant Sharat Kandula
56c6aa0f1d
ci: Include info.json for all workflows (#26429) 2023-08-22 10:34:23 +05:30
Saroj
132a0c2e25
ci: Update ce push workflow to use dime defenders (#26527)
## Description
- Update ce push workflow to use dime defenders
#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- [ ] Workflow run
>
>
2023-08-21 17:23:20 +05:30
Nikhil Nandagopal
fcd516a28b Updated Label Config 2023-08-21 12:37:48 +05:30
Nikhil Nandagopal
47ffd52bb5 Updated Label Config 2023-08-21 10:22:56 +05:30
Valera Melnikov
826d58f813
chore:update node version to v18 (#26358)
## Description
Update node version

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-15 18:56:04 +05:30
codesee-maps[bot]
c108a31a38
chore: Install the CodeSee workflow. (#26315)
This pull request adds the CodeSee workflow to your repository.
This workflow runs a code analysis on each time:

  - a new PR is opened
  - a new commit is pushed to an existing PR
- a PR is merged or a new commit is pushed directly to the default
branch

The analysis enables [code
visibility](https://www.codesee.io/what-is-code-visibility) for your
codebase: generating maps of your codebase, keeping existing maps
up-to-date, and automating code workflows.

Access the CodeSee web app at https://app.codesee.io/ or learn more at
https://docs.codesee.io. If you have any questions, please reach out to
support@codesee.io and we'll be happy to help.

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
2023-08-14 12:43:25 +05:30
Nikhil Nandagopal
3a320b1ced Updated Label Config 2023-08-12 13:18:29 +05:30
Nikhil Nandagopal
ed17e17e72 Updated Label Config 2023-08-12 13:14:35 +05:30
Nikhil Nandagopal
ddf49b1a2d Updated Label Config 2023-08-12 13:10:22 +05:30
Sumesh Pradhan
d15bb78d13
ci: workflow run id context var fix (#26244)
Updated github context variable for the workflow id.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-08-11 10:39:28 +05:30
Nikhil Nandagopal
e795407b6a Updated Label Config 2023-08-10 18:20:47 +05:30
Sumesh Pradhan
87b8aa58ce
ci: Secret typo (#26192)
Typo fixed for secret token key.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-08-09 10:49:15 +05:30
Nikhil Nandagopal
ac0947a554 Updated Label Config 2023-08-08 12:02:30 +05:30
Nikhil Nandagopal
45884ebf87 Updated Label Config 2023-08-08 12:02:17 +05:30
Nikhil Nandagopal
9308b93246 Updated Label Config 2023-08-08 12:02:12 +05:30
Shrikant Sharat Kandula
75eea5b87d
ci: Make info json script optional 2023-08-07 14:23:50 +05:30
Sumesh Pradhan
be9c935732
ci: Deploy preview from branch (#25846)
Updated ad-hoc dp workflow to update the db with progress.
- This workflow should only be called via internal ops api.
- This workflow uses the internal ops api to patch data with the updates
on the workflow statuses.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-08-07 10:59:42 +05:30
Valera Melnikov
65a662ee48
chore: clean up switch stories (#26057)
## Description
Clean up switch stories

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-04 21:56:45 +03:00
Goutham Pratapa
c6d9357f88
chore: add deployment dp params (#26002) 2023-08-04 10:40:25 +05:30
Goutham Pratapa
bc24d03dbd
Revert "update: migrate dp from sts to deployments (#25615)" (#25996)
This reverts commit 6762d2ce90.
2023-08-03 23:40:06 +05:30
Pawan Kumar
57cf92e68d
chore: Split Chromatic and Storybook stories (#25877)
Fixes #25427
2023-08-03 21:00:17 +03:00
Goutham Pratapa
6762d2ce90
update: migrate dp from sts to deployments (#25615) 2023-08-03 19:02:17 +05:30
Saroj
495b35358f
ci: Fix slack notification for ci-test-hosted (#25960)
## Description
- Fix slack notification for ci-test-hosted
#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-08-03 10:59:06 +05:30
Saroj
f89e5b8612
test: Cypress - fix for selected gsheet (#25940)
## Description
- Fix for selected gsheet failure
- Added steps in ci-test-hosted to notify on slack
- Updated config to run the Airtable_basic_spec on the hosted instance
and skip it in regular runs

#### Type of change
- Cypress changes
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- [x] Cypress

## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-02 18:58:04 +05:30
Shrikant Sharat Kandula
e8c3cc19a2
chore: Add info.json to Docker images (#25948)
This adds a `/opt/appsmith/info.json` file to Docker images, with the
following sample content:

```json
{
  "commitSha": "0521ba2c0d7a62cef3d4def66fc15b59cc34ceef",
  "commitUrl": "0521ba2c0d",
  "branch": "release",
  "date": "2023-08-02T12:52:53+00:00",
  "isCI": false
}
```

We're enabling this only for images built for DPs currently, and will
then extend to other workflows as well.

Notice that we copy `info.*json` instead of `info.json`. The reason is
so that the Docker build doesn't fail, even if the `info.json` file
doesn't exist. This lets us publish this to each workflow in turn,
slowly and carefully.

[Relevant Slack
conversation](https://theappsmith.slack.com/archives/C02MUD8DNUR/p1686197957141419).
2023-08-02 18:36:59 +05:30
Shrikant Sharat Kandula
e0962f3a1c
ci: Use vars.EDITION instead of hard-coded edition to avoid conflicts with EE sync (#25870)
Note: Please review/approve only, do not merge. This PR is expected to
cause conflicts and so I'd like to be around when this is merged.
2023-08-02 14:35:08 +05:30
Aman Agarwal
2603107afa
fix: remove shared-modules workflow file (#25932) 2023-08-02 12:47:45 +05:30
Saroj
fe88895020
ci: Fix cypress dashboard url for rerun (#25933)
## Description
- Fix cypress dashboard url for rerun for Git messages that comes in PR
runs

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- workflow run
2023-08-02 12:45:13 +05:30
Shrikant Sharat Kandula
24a12d55d3
ci: Update docker/build-push-action to v4 (#25906)
The currently used `v1` is deprecated, and not recommended anymore. The
`v4` changes a few things. Some details are in the following pages:

1. https://github.com/docker/build-push-action/blob/v2/UPGRADE.md
2.
4fad532b9f/README.md (customizing)

Essentially, in the current code, `build-args` isn't working. This
should fix that.
2023-08-02 10:43:37 +05:30
Saroj
1b534cdd79
test: Additional regression scenarios for gsheet (#25844)
## Description
- Added following  regression scenarios for gsheet
   1. Create query from active ds tab
   2. Create query from ds details page
   3. Generate CRUD page from active ds
   4. Generate CRUD page from entity explorer
   5. Added test to add query from global search

#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [ ] Cypress
## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-01 16:42:44 +05:30
Goutham Pratapa
c2b6b92e73
ci: vercel dp comments (#25898) 2023-08-01 15:46:36 +05:30
Aishwarya-U-R
af415f4f30
test: Cypress | Automated tests for MySQL + Flaky fixes (#25867)
## Description
- This PR fixes the below flaky fixes
- GitSyncedApps_spec.js
- Improves coverage for MySQl - adding suggested widget binding
- TableV2/Date_column_editing_1_spec.ts fix
- WaitUntilEleAppear improved
- DeployApp() updated
- QueryPane/Mongo_Spec.js - adding wait time
- AssertIfPropertyIsNotVisible() replaced
- fat-migration.yml deleted
- cypress-real-events - update
- /Filepicker/FilePicker2_spec.js
- /Autocomplete/Autocomplete_setters_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-01 15:04:15 +05:30
Shrikant Sharat Kandula
818d997d5d
ci: Default to release CS unless building for prod (#25856)
When running Appsmith release image, it's currently using production CS,
which is causing a lot of incompatibility related errors since `release`
moves much faster than prod.

This changes this. Note that for `:latest` and `:nightly` images, we do
NOT change this default. There's no change for Docker images with those
tags. We _only_ want change `:release` image, DP images, and images
built for Cypress runs.
2023-08-01 07:35:01 +05:30
Valera Melnikov
e5209aa7cd
fix: bump storybook version and move stories to storybook package (#25821)
## Description
- bump storybook version
- move stories to storybook package
- add dimensions for testing viewports
- improve some stories and types for argTable

#### PR fixes following issue(s)
Fixes #25534

#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-31 19:15:50 +03:00
Goutham Pratapa
3f8db42522
fix: failing-vercel-dps (#25851)
Fixes:
https://github.com/appsmithorg/appsmith/actions/runs/5713787930/job/15479827656#step:9:30

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-31 20:51:35 +05:30
Saroj
e88eb26bdd
ci: Fix for comments in case ci-test failure due to other steps (#25850)
## Description
- Fix for comments in case ci-test failure due to other steps
- Fixed the ci-test-result issue in ci-test-limited
#### Type of change
- Workflow file
## Testing
- Workflow run
2023-07-31 17:56:55 +05:30
Sumesh Pradhan
18b26a4ec5
ci: Ad-hoc DP | Build Push Deploy from branch (#25357)
Workflow and script to build from branch and deploy to uat-cluster.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-31 13:27:47 +05:30
Shrikant Sharat Kandula
0d69fb5472
ci: Use cache from release image to build faster (#25829)
This should enable using unchanged layers from the `release` image, as a
cache, and build PR images faster. We only do this for images built for
PRs and not for direct `release` or `master` branches.
2023-07-31 10:30:46 +05:30
Shrikant Sharat Kandula
5a9abe0075
ci: Add a note about Vercel DPs with env=release (#25211)
Non-impacting change, only adds some more content to the DP URL comment.

More context around this at
https://notion.so/031b87bce3404e3a95240d4c14c82e46.
2023-07-31 10:19:20 +05:30
Nikhil Nandagopal
c02a7fb324 Updated Label Config 2023-07-27 22:24:52 +05:30
Nikhil Nandagopal
8b70366c9a Updated Label Config 2023-07-27 22:24:44 +05:30
Abhijeet
2f36589171
chore: Update CI test to add CS release image instead of mocking CS response (#25400)
https://theappsmith.slack.com/archives/C0134BAVDB4/p1687775438002889

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/1908
2023-07-27 18:03:10 +05:30