Somangshu Goswami
3023fcf955
chore: Release v1.9.44 ( #28477 )
...
This is a promotion branch for the release v1.9.44
---------
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com>
Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Dhruvik Neharia <dhruvik@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: Appsmith Bot <74705725+appsmith-bot@users.noreply.github.com>
Co-authored-by: Nilansh Bansal <nilansh@appsmith.com>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Guilherme Ventura <1488378+danguilherme@users.noreply.github.com>
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Manish Kumar <107841575+sondermanish@users.noreply.github.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
Co-authored-by: sneha122 <sneha@appsmith.com>
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: danceAndJive <99446612+danceAndJive@users.noreply.github.com>
Co-authored-by: Kyle Zhang <u6133716@anu.edu.au>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: sharanya-appsmith <135708039+sharanya-appsmith@users.noreply.github.com>
Co-authored-by: Diljit <diljit@appsmith.com>
Co-authored-by: Vemparala Surya Vamsi <121419957+vsvamsi1@users.noreply.github.com>
Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>
Co-authored-by: Jacques Ikot <jacquesikot@gmail.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Victor Kostyuk <torcoste@gmail.com>
Co-authored-by: Rudraprasad Das <rudra@appsmith.com>
Co-authored-by: manish kumar <manish@appsmith.com>
2023-11-06 20:12:29 +05:30
Aishwarya-U-R
4ffc5bb62a
test: Cypress | CI Stabilize + Other test improvements ( #28172 )
...
## Description
- **This PR flaky fixes below specs:**
- GenerateCRUD/MySQL2_Spec.ts script fix
- ServerSide/ApiTests/API_All_Verb_spec.js
- Regression/Apps/PromisesApp_spec.js
- TableV2_Property_ToggleJs_With_Binding_spec.js
- GSheet cases failures due to EditApponHover method fix
- Radio/Radio2_spec.ts, using `GetHeight` instead of
`GetWidgetCSSHeight`
- Select/Select3_Spec.ts
- Widgets/Text/Text_new_feature_spec.js
- Binding/API_with_List_Widget_spec.js
- Workspace/LoginFromUIApp_spec.js - removed redundant code
- QueryPane/DSDocs_Spec.ts
- ServerSide/QueryPane/GoogleSheets_spec.ts
- TableV2/Date_column_editing_1_spec.ts
- Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts - script flow
corrected
- ServerSide/QueryPane/Mongo_Spec.js
- **Added validation for form plugin response data, which addresses the
Empty toast issue**
- **Below specs are fixed for new appName localStorage changes:**
- /SettingsPane/PageSettings_spec.ts
- BugTests/Moment_Spec.ts
- /Fork/ForkAppWithMultipleDS_Spec.ts
- Fork/ForkApplicationWithinAppEditor_spec.ts
- Fork/ForkApplication_spec.ts
- /ClientSide/OtherUIFeatures/Analytics_spec.js
- OtherUIFeatures/ApplicationURL_spec.js
- OtherUIFeatures/ExportApplication_spec.js - Duplicate case removed
- OtherUIFeatures/UpdateApplication_spec.js
- VisualTests/JSEditorIndent_spec.js
- Workspace/WorkspaceImportApplication_spec.js
- **Improvemnets:**
- deployMode.StubWindowNAssert() improved to validate `getPluginForm`
instead of `getWorkspace`
- agHelper.AddDsl() improved, removed wait times
- appSettings.CheckUrl() - appName url updated
- assertHelper.AssertDocumentReady() -removed wait times
- assertHelper.AssertNetworkResponseData() - added for `getPluginForm`
validation for Page loads
- deployMode.DeployApp() -removed wait times
- homePage.CreateNewWorkspace() - improved to set localStorage for
workspaceName, workspaceId & create new workspace without new name
- homePage.CreateNewApplication() - - improved to set localStorage for
appName
- jsEditor.NavigateToNewJSEditor() - improved to remove tooltip
- cy.CreateAppInFirstListedWorkspace() - improved to set localStorage
for appName, removed waitTimes, Removed rename of every app for every
spec, calling AssertNetworkResponseData(getPluginForm)
- cy.DeleteWorkspaceByApi() added
- e2e.js - removed guid generation for first app, added
cy.DeleteWorkspaceByApi() in after()
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-10-20 07:45:47 +05:30
Aishwarya-U-R
885c951066
test: Cypress | CI Stabilize ( #27818 )
...
## Description
- This PR adds tests for validating the set properties for widget across
all objects
- Covers only some scenarios from [Test
#2409 ](https://github.com/appsmithorg/TestSmith/issues/2409 )
- Adds the failure cypress dashboard link directly in case of CI run
failures
- Flaky fix - Sanity/Datasources/SMTPDatasource_spec.js
- Cypress.on - exception & fail handling updated
- InvokeDispatchOnStore() created for logout/login Internal server
errors - trial fix for RBACFunctionalTests/OthersTabPermission_spec.js
- EditAppFromAppHover() improved to take app name also - trial fix
PropertyPane_Connections_Error_spec.js
- Flaky fix - TableV2_Property_ToggleJs_With_Binding_spec.js
- Flaky fix - Radio2_spec.ts
- Flaky fix - API_TestExecuteWithDynamicBindingInUrl_spec.ts
- Flaky fix - Button_with_API_spec.js
- AssertTableInVirtuosoList() improved to handle the DS name not present
in EE scenario also
- Flaky fix - Button_with_API_spec.js
- Flaky fix - Table_Style_ToggleJS_spec.js
- Flaky fix - Tablev2_Style_ToggleJS_spec
#### Type of change
- Script update (non-breaking change which fixes an issue)
## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-10-17 20:26:24 +05:30
Aman Agarwal
09657f4cea
fix: run before walkthrough function to select widget before showing it ( #27688 )
2023-10-06 15:33:27 +05:30
akash-codemonk
3dc1241468
chore: get browser logs from failed cypress tests ( #27724 )
...
Fixes https://github.com/appsmithorg/appsmith/issues/26006
Get browser console logs for failed tests. This will help with easier
debugging of flaky tests.
Sample artifact for a test
https://github.com/appsmithorg/appsmith/suites/16856147292/artifacts/962768313
Latest test run of the change:
https://github.com/appsmithorg/appsmith/actions/runs/6405413689
Trimming down the files to a max of 10 files, since the artifact size
can go upto a GB when there are a 1000 or more tests failing.
---------
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-10-05 14:42:30 +05:30
Aman Agarwal
3979a302d3
fix: remove redundant code for ab_ds_binding_enabled and ab_ds_schema_enabled ab test flags ( #26356 )
2023-08-31 19:49:36 +05:30
akash-codemonk
03b8bebf65
feat: debugger api pane navigation ( #25771 )
2023-08-10 19:25:06 +05:30
Aishwarya-U-R
d6520e53aa
test: Cypress | CI Stablize + verifying DS Connection Errors (DI) ( #26004 )
...
## Description
- This PR - improved EnterURL() to - verify for api url entering issue
- Improves AssertText() - added new locator (_widgetToVerifyText) for
ease of use
- Improved StatboxDsl_spec.js validation
- Childwigets/List_Select_Widgets_spec.js (DragDrop - trial fix)
- Fork_Template_spec.js - trial fix
- ServerSide/LoginTests/LoginFailure_spec.js
- /OtherUIFeatures/ApplicationURL_spec.js
- ListV2/Childwigets/List_Inputs_spec.js
- SettingsPane/EmbedSettings_spec.ts
- Templates/Fork_Template_Existing_app_spec.js
- ListV2/ListV2_SerververSide_spec.js
- New TestScript - ConnectionErrors_spec.ts - added
- /OtherUIFeatures/ViewMode_spec.js
- Apps/PgAdmin_spec.js - trial fix
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-08 14:44:46 +05:30
Hetu Nandu
6cd4117f38
fix: Update product alert stub to check for 200 status ( #25881 )
...
Product alert api was mocked in the cypress tests which missed cases
where the api would return a 401 error. Updating the mock to now make
the call, verify the response status code to be 200 and then stub the
response.
---------
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-08-04 16:42:47 +05:30
Saroj
81a114642f
ci: Split specs and run Cypress without Cypress Dashboard ( #25347 )
...
- Hackathon
2023-07-19 12:12:36 +05:30
akash-codemonk
c7dd9f354a
chore: log editor state on test failure ( #24703 )
...
Added some logs to be printed on failure. Hoping this would help in
debugging the loading issue. Will remove it later once it is fixed.
Related to https://github.com/appsmithorg/appsmith/issues/23713
2023-06-21 16:43:51 +05:30
Aishwarya-U-R
0bf8e17e74
test: Cypress | Flaky fixes ( #24576 )
...
## Description
- This PR fixes below flaky tests:
- GitBugs_Spec (welcom screen load)
- Theme_FormWidget_spec.js (multiple flaky places)
- Logs1_spec.js
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [x] Cypress local
## Checklist:
#### QA activity:
- [x] Added `Test Plan Approved` label after changes tests were reviewed
2023-06-17 15:55:37 +05:30
Aishwarya-U-R
959fdce6ac
test: Cypress | Flaky fixes ( #24508 )
...
## Description
- This PR improves the sign up method to work even if telemetry related
details are not asked at start
- Also alters the Commit message based on the repository/workflow or
push runs
- Improves DragDropWidgetNVerify()
- Fixes flaky TableV2/Inline_editing_spec.js spec with TS methods
- Improved EditTableCell()
- Skipping deleting apps during local runs for debugging purpose
- Fixes PropertyPane_Search_spec.ts
- Fixed ever flaky AppNavigationWithMultiplePages_spec,
AppNavigationWithAutoLayout_spec
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
>
>
## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after changes were reviewed
2023-06-17 00:10:10 +05:30
Aishwarya-U-R
d7b2bad974
test: Cypress | Cy 12 upgrade + Flaky fixes ( #23852 )
...
## Description
- This PR upgrades cypress from 11.2 to 12.13.0 which fixes the random
browser crash issue in CI runs
- ValidateNetworkStatus() updates to validate the n/w responses
- cy.route() to cy.intercept()
- Converting dataSources.json to HostPort.ts
- Api responses read - updating to right Cy12 supported format
- js inconsistent testJsontext to TS `EnterJSContext` in few failing
specs
- CI - higher resolution trials
- Improves _.agHelper.RefreshPage() - fixing Error: Socket closed before
finished writing response
- AssertDocumentReady() created
- within(()) & .children() - handled for Cy12
- Improved DeployApp(), NavigateBacktoEditor(), RefreshPage(), AddDsl()
methods
- js inconsistent goToEditFromPublish to TS `NavigateBacktoEditor` in
all specs
- js inconsistent PublishtheApp to TS `_.agHelper.DeployApp` in all
specs
- Convert /DynamicHeight/Text_Widget_spec.js to TS with all supporting
TS helpers
- ToggleJSMode()
- COMMIT_INFO_MESSAGE improved
- Remove tooltip on the Application Name after rename
- js inconsistent cy.addDsl(dsl); to TS helper `_.agHelper.AddDsl(val);`
- ++++ Much more improvements....
#### Type of change
- Script fixes
## Testing
#### How Has This Been Tested?
- [X] Cypress
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
---------
Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
2023-06-15 18:51:11 +05:30
albinAppsmith
629999f124
feat: [epic] appsmith design system version 2 deduplication ( #22030 )
...
## Description
### Fixes
- [x] https://github.com/appsmithorg/appsmith/issues/19383
- [x] https://github.com/appsmithorg/appsmith/issues/19384
- [x] https://github.com/appsmithorg/appsmith/issues/19385
- [x] https://github.com/appsmithorg/appsmith/issues/19386
- [x] https://github.com/appsmithorg/appsmith/issues/19387
- [x] https://github.com/appsmithorg/appsmith/issues/19388
- [x] https://github.com/appsmithorg/appsmith/issues/19389
- [x] https://github.com/appsmithorg/appsmith/issues/19390
- [x] https://github.com/appsmithorg/appsmith/issues/19391
- [x] https://github.com/appsmithorg/appsmith/issues/19392
- [x] https://github.com/appsmithorg/appsmith/issues/19393
- [x] https://github.com/appsmithorg/appsmith/issues/19394
- [x] https://github.com/appsmithorg/appsmith/issues/19395
- [x] https://github.com/appsmithorg/appsmith/issues/19396
- [x] https://github.com/appsmithorg/appsmith/issues/19397
- [x] https://github.com/appsmithorg/appsmith/issues/19398
- [x] https://github.com/appsmithorg/appsmith/issues/19399
- [x] https://github.com/appsmithorg/appsmith/issues/19400
- [x] https://github.com/appsmithorg/appsmith/issues/19401
- [x] https://github.com/appsmithorg/appsmith/issues/19402
- [x] https://github.com/appsmithorg/appsmith/issues/19403
- [x] https://github.com/appsmithorg/appsmith/issues/19404
- [x] https://github.com/appsmithorg/appsmith/issues/19405
- [x] https://github.com/appsmithorg/appsmith/issues/19406
- [x] https://github.com/appsmithorg/appsmith/issues/19407
- [x] https://github.com/appsmithorg/appsmith/issues/19408
- [x] https://github.com/appsmithorg/appsmith/issues/19409
Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers
about this first
Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
## Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important
- Manual
- Jest
- Cypress
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in>
Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com>
Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-05-20 00:07:06 +05:30