Commit Graph

3685 Commits

Author SHA1 Message Date
Ashok Kumar M
f4210e4601
fix: load main container without waiting for evaluations to complete. (#6669)
* Fix: load main container without waiting for evaluations to complete.
2021-08-25 14:39:50 +05:30
Rishabh Rathod
08917a0592
fix: Generate Page using Empty Table error (#6834)
- Do not allow to generate CRUD app when selected table of datasource is empty (has no columns)
- Fix #6824: When the Dropdown is empty (has no options) do not show the dropdown option (popup) UI.
2021-08-25 10:55:33 +05:30
Pawan Kumar
960159eef3
Grouping widgets into container (#5704)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* add icon for grouping

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* add container on copy

* add analytics middleware

* refactor paste widget saga

* change flash element to accept array + revert refactor

* add logic to create containers from selected widgets

* update positions of grouped widgets

* fix comments + remove console

* update flashElementbyId to flashElementsById

* remove analytics middleware + remove unecessary imports

* add shorcut for grouping

* fix position issue when pasting

* allow grouping only when multi widgets are selected

* fix ux issues with widget grouping

* fix help text for grouping actions

* filter out the modal widget when calculting next row

* fix delete issue when grouping

* persist positin when grouping if there is no collision

* fix typo for new position

* changes for review comments

* changes for review comments

* fix position issue when pasting

* fix new container position issue

* move utils function to utils

* fix import issue

* fix the composite widget grouping issue

* fix table name bug

* remove repeated code

* move copied groups existence check;

* fix copied group check

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-25 10:30:31 +05:30
akash-codemonk
daed3716c6
fix: Fix omnibar redirecting to invalid url when there are no results (#6696) 2021-08-25 10:28:58 +05:30
akash-codemonk
95c60bafeb
fix: Hide debugger errors until onPageLoadActions are run (#6786) 2021-08-25 10:04:42 +05:30
arunvjn
0b1e42691b
fix: Api pane url input height and datasource mouse click. (#6818) 2021-08-24 20:44:32 +05:30
Paul Li
cb4242e7e5
Feat: Style customisation in the button widget (#6052)
Added multiple style props to the button widget:
- Button styles
- The background colour can change with a hex code
- elevation (box-shadow & colour)
- There are button variant contained (solid button), outlined (only borders), text (text buttons)
- Button can have an end icon or start icon
2021-08-24 19:23:15 +05:30
Ashok Kumar M
de73e847ae
[Enhancement] Adding Webpack bundle analyser for CRA, removing source map explorer for better visualisation. (#6793)
* Enhancement: Adding better build visualiser(Webpack build analyser)
2021-08-24 17:44:23 +05:30
Ashok Kumar M
698b9d5b82
Fix: show property pane only when respective widget is present on the dom. (#6670) 2021-08-24 17:43:49 +05:30
Hetu Nandu
f012fd9d69
fix: Revert redux update perf improvements (#6808) 2021-08-24 17:40:25 +05:30
Ashok Kumar M
83147afdc5
feat: Widget grouping Extended Features (#6538)
- [x] Draw to select from outside of the editor.
- [x] Cmd + A to select child widgets inside containers, forms, list, tabs, and modals.

Fixes #5995
Fixes #6102
2021-08-24 17:08:20 +05:30
Yash Vibhandik
05d733cfe8
FIX #6193 : bind enter and tab key on color picker input to close color board (#6305)
This is done to improve the keyboard navigation on the property pane
2021-08-24 16:55:45 +05:30
arunvjn
1082cb9ca3
fix: Sentry type error in DB form (#6817) 2021-08-24 16:30:55 +05:30
yatinappsmith
aa869f21ab
test: Added Support for MySQL (#6795)
* Added Support for MySQL

* Update setup-test.sh

fixed sql file

* Update setup-test.sh

Fixed path
2021-08-24 14:16:52 +05:30
Paul Li
b170a014c6
menu style customization (#6237)
- Menu widget needs to show transparent background
- Make background none if user choose no background colour
- Adopt button style options(menu style, variant, box shadow, border radius)
2021-08-24 11:07:16 +05:30
Satish Gandham
da1af9cac7
Filepicker v2 - Don't store large files in the dataStore (#6692)
* - Create a clone of the existing filepicker widget

* - If a file is larges than 5MB, don't put it in the dataTree.

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-24 09:08:57 +05:30
Ashok Kumar M
971cc35e7f
[Feature] Click on widget will no longer open property pane (#6219)
* [Feature] Click on widget will no longer open property pane

* fixing test cases

* coverage fixes

* fixing imports.

* fixing build failure.

* fixing new specs

* clear property pane state for any new selection.
2021-08-23 19:42:17 +05:30
akash-codemonk
bb1c5ab9a3
Send errorType as part of analytics payload for action execution errors (#6754) 2021-08-23 19:17:17 +05:30
Rishabh Saxena
7b23de64d9
Analytics events for the comments onboarding (#6763) 2021-08-23 14:55:16 +05:30
Pranav Kanade
6782bf6b85
fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) 2021-08-23 14:46:25 +05:30
Rishabh Saxena
aee2d19b8e
Commit page ui (#6772) 2021-08-23 14:15:54 +05:30
NandanAnantharamu
0e5816d413
Fix/chart spec (#6774)
* updated Chart spec with a wait for route

* updated Chart spec with a wait for route
2021-08-23 14:02:53 +05:30
Ayush Pahwa
b1d003fdba
Added new type to the ActionConfig, fixed some typos (#6748) 2021-08-23 13:04:44 +05:30
Yash Vibhandik
a5fe7c391e
fixed the filter issue in table widget (#6739)
The filters did not get reset where the data in the table widget changes in the edit mode. This is now fixed
2021-08-23 12:59:14 +05:30
akash-codemonk
25c6bd8c0f
Fix two skip tour options shown in onboarding (#6729) 2021-08-23 12:40:26 +05:30
akash-codemonk
a42938c139
Expand all debugger errors by default (#6676) 2021-08-23 11:57:23 +05:30
Pranav Kanade
7b587a8d43
Fix: Style for documentation link in query pane (#6716)
* updated styling for documentation link in query pane

* added message constants
2021-08-23 11:47:28 +05:30
arslanhaiderbuttar
01e5d8d839
Table UI test cases (#5910)
* TableUITestCases

Commit

* Table-widget-testcases

On Search Text Change Action
Default array data
On Row Selected Action
Explore Widget related documents Verification
On Page Change Action
Default search text
Default selected row
Delete Table Widget
Changing Column data type to "Image"
Changing Column data type to "URL"
Table Widget Functionality To Verify Row Height Functionality
Drage and Drop Table widget and verify default data
Table Widget Functionality To Filter The Data using 'Empty
Table Widget Functionality To Filter The Data using 'Not Empty'

* Discarded changes in cypress.json

Discarded changes in cypress.json

* Updated the test cases

* Undo changes to Cypress.json

Undo changes to Cypress.json

* Added new dsl json file

* Merge branch 'release' into SelectUITestCases

* table test cases fix

Co-authored-by: arslan <>
2021-08-21 12:34:23 +05:00
Rishabh Rathod
652950d239
Add Gsheets support for generate CRUD page (#6301)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Fix issues related to dropdown

* Add hooks to fetch sheets and spreadsheets

* Resolve warnings

* complete gheets basic support

* Add UI changes for Gsheet column names
- Fix Page Scroll issue

* Add debounce to avoid to many API calls

* Add request object formation via plugin config

* Resolve comments & remove executingDatasourceQuery

* Send sheetName in the tableName key.

* Add loader and Column name UI Fix

* Add Column Headers Label

* Fix logic to show comma separator btn column names
- Make "Column Header Fetched" text Bold

* Add tooltip info for searchable column

* Add value prop to TextInput
- Fix Table header Index Invalid Input issue

* Hotfix validator logic
2021-08-20 15:25:59 +05:30
Abhijeet
163c7cde71
Update template application file to fix failing cypruss TC (#6758) 2021-08-20 14:51:17 +05:30
Rishabh Saxena
add2127dad
Remove onboarding typeform (#6752) 2021-08-20 13:00:36 +05:30
Rishabh Rathod
12e7ee0c94
Add s3 support for generate CRUD (#6264)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Add useS3BucketList hook WIP

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Add Query to get all S3 buckets

* Fix dropdown open issue

* Remove defaultIsOpen prop from dropdown

* Resolve comments
- Remove debugger
- mockSheetUrl -> getSheetUrl

* Add S3 cypress test

* Fix cypress test yml config

* Fix generate page cypress test
2021-08-20 12:27:01 +05:30
Hetu Nandu
17edf11d00
Add eslint rule to disallow console.log (#6717) 2021-08-20 09:43:16 +05:30
Rishabh Saxena
d89bf5c487
Default deploy section state (#6740) 2021-08-19 21:04:43 +05:30
Yash Vibhandik
2ba63fb5b1
Removed isCellVisible flag (#6731)
We have reverted a code which is coming in from #4819, which caused a bug in the table filter input element to hide, We will log this issue to be fixed in the release env separately, We will cherry pick this commit to RC to resolve the current build error
2021-08-19 19:49:02 +05:30
hetunandu
9941c253f7 Revert "Hotfix for logging and debugging redux updates (#6728)"
This reverts commit 4b5ca10e0d.
2021-08-19 18:31:37 +05:30
Anagh Hegde
e76d8c2c15
Change the name of the mock datasource (#6498)
* Change the name of the mock datasource

* Remove the hardcoded value for Cloud services

* Handle index out of exception

* Add check if the response contains necessary credentials for mockdb

* Change as per review comments

* Fix cypress test failures

* minor changes to fix cypress test for mock data according to new changes

* updated mock data locator

* Update the mockdata source name

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-19 17:53:30 +05:30
Hetu Nandu
4b5ca10e0d
Hotfix for logging and debugging redux updates (#6728) 2021-08-19 16:35:16 +05:30
Hetu Nandu
77ea24ba85
Fix debugger trying to render objects (#6720) 2021-08-19 14:23:03 +05:30
Rishabh Rathod
ab3fdd4ece
Add User Profile Section (#6705)
- Replace AuthTypeSelector with OptionSelector for general use.
- Fix Scroll issue in GitSyncModal
2021-08-19 12:09:19 +05:30
Abhijeet
9677a4fb8f
[Skip_changelog] Enable S3 and GSheet from backend for generate CRUD page (#6706)
* Update appsmithVersion for static json file used in import application cypruss test
2021-08-19 12:04:14 +05:30
Pranav Kanade
ca0b08e482
Fix: background rect width of usernames, of other realtime users (pointer sharing) (#6703)
* updated collab event names

* added a canvas to record the mouse movement

* can show pointers

* temp

* can draw multiple pointers using canvas, moved multiplayer canvas to artboard level

* using constants to draw the cursors on canvas

* can show pointers with different colors

* showing proper username

* added constants for collab events and namespace

* updated the page socket var name

* defined a id constant, and resizing the canvas if needed on window resizing, and then clearing it

* minor refactor

* hide pointer of users leaving the page

* moved our the share pointer func

* defined separate types

* added minor comment

* using requestAnimationFrame to improve performance.

* added connection checks before emitting events. Added mechanism to try to reconnect manually

* using ref to keep animation step id

* updated the way using requestAnimationFrame

* passing pageId as prop to canvas and pointer canvas

* emitting events only if there are more than one realtime editors

* added pageId dependency

* removed unnecessary prop and using reactive state

* remove explicit connection event

* maintaining connection state of page level socket

* fixed the multipointer text background width
2021-08-19 11:13:53 +05:30
Rishabh Saxena
6c7a045916
Git connection page ui components (#6667) 2021-08-18 17:18:24 +05:30
Rishabh Saxena
eda5b05faa
Fix redirection to auth page when trying an app without having access (#6682) 2021-08-18 16:31:50 +05:30
Yash Vibhandik
158a71acab
FIX #3123 : added custom csvSeparator property in table widget for csv download (#6291) 2021-08-18 16:03:26 +05:30
Yash Vibhandik
05bcad89ff
FIX #6615 : added check for open filter pane and close if before property pane open (#6662)
Hotfix for the RC blocker
2021-08-18 16:01:38 +05:30
Pranav Kanade
7a75d400ab
Feature: Sharing pointers of concurrent editors (#6540)
* updated collab event names

* added a canvas to record the mouse movement

* can show pointers

* temp

* can draw multiple pointers using canvas, moved multiplayer canvas to artboard level

* using constants to draw the cursors on canvas

* can show pointers with different colors

* showing proper username

* added constants for collab events and namespace

* updated the page socket var name

* defined a id constant, and resizing the canvas if needed on window resizing, and then clearing it

* minor refactor

* hide pointer of users leaving the page

* moved our the share pointer func

* defined separate types

* added minor comment

* using requestAnimationFrame to improve performance.

* added connection checks before emitting events. Added mechanism to try to reconnect manually

* using ref to keep animation step id

* updated the way using requestAnimationFrame

* passing pageId as prop to canvas and pointer canvas

* emitting events only if there are more than one realtime editors

* added pageId dependency

* removed unnecessary prop and using reactive state

* remove explicit connection event

* maintaining connection state of page level socket
2021-08-18 15:59:52 +05:30
Rishabh Saxena
74bff938b5
Init git sync modal (#6641) 2021-08-18 15:10:31 +05:30
Rishabh Saxena
a1daa7e3f8
Handle deletion for comments and threads in realtime (#6605) 2021-08-18 12:51:21 +05:30
Yash Vibhandik
ffb348bc82
FIX #6463 : updated condition to handle undefined values in tableUtility (#6588) 2021-08-18 12:44:56 +05:30