Commit Graph

6890 Commits

Author SHA1 Message Date
Abhijeet
cdf06cb773
feat: API to discard changes for git connected applications (#11362)
* Add discard changes functionality for git

* Recover deleted resources from the file system and refactor

* Remove untracked files, remove unwanted actions

* Testcases added for discard changes

* Added comments
2022-03-02 19:54:09 +00:00
balajisoundar
fe72182064
fix: Number type input should honour required property when value is empty string (#11442) 2022-03-03 00:38:22 +05:30
Ankita Kinger
13fe125a0c
feat: Add disconnect button on auth config pages and form login callout banner (#11389)
* added form login callout banner

* form login config page changes

* form login config page changes

* added redirecturl and uneditable field components

* added disconnect button on auth pages

* Added env variables for form login auth page

* added disconnect button on auth pages

* updated docs link for dform login callout doc

* added condition for disconnect button

* added ce changes done on ee

* updated css

* suggested changes in PR review

* suggested changes in PR review

* suggested changes in PR review

* reverted gitignore files changes

* reverted gitignore files changes

* updated logic for saving admin settings

* removed unused imports

* added changes for taginput field

* removed console

* removed warning

* removed unwanted changes
2022-03-02 23:48:50 +05:30
Leo Thomas
18104b9291
fix: 9824 Google Sheet to filter empty condition ver.2 (#11435)
* fix: 9824 Google Sheet to filter empty condition ver.2

* Code review comments updated

* Updates as per review comments - Ver 3

* Resolved errors found during testing

* Code review comments fix

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-03-02 22:34:34 +05:30
Mojtaba
29be75e0e9
feat: add smart substitution handling for known MongoDB types (#11135)
* shelf: start working on substitution for `ISODate`

* a draft for Sumit to check what I did wrong in my tests

* test: tests are working

* test: cleanup

* refactor: add replacementDataType parameter to DataTypeStringUtils.jsonSmartReplacementPlaceholderWithValue

* fix: remove quotes for Mongo Types work in single form, arrays and json.

* add handling for more use cases
add/update more TCs

* add comments

* add more comments

* add space (cosmetic change)

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-03-02 22:33:50 +05:30
Aishwarya-U-R
ef20c1e341
test: Automated tests for Promises & related bugs in Typescript + Flaky fixes (#10378)
* Flaky fixes

* S3 CRUD intercept fix

* S3 CRUD script change revert

* S3 revert!

* .its(store) not present fix

* TS failure fixes

* ChartDataopoint js removed

* JSObject ts flaky fix

* Bugs 9789, 10150 scripted

* Bug 10284 & 9782 scripted

* Updated dsl file names

* Table_Widget case #7 flaky fix

* Bug 10150 scripting improved

* DocumentViewer spec flaky fix

* Input widget locator corrected

* MemberRoles cases script started in TS

* UpdateUserRoleInOrg() fix

* Skip JSObject_To_ListWidgetSpec.ts until #10284

* Add validation

* JSObject_To_ListWidgetSpec.ts timeout increase

* Skipping tests until bug 10284 is fixed

* Increased wait time

* UpdateUserRoleInOrg() updated

* MemberRoles_Spec.ts fixed

* JSObjToInput - updated

* Postgres flaky fix

* Member Roles aka CreateOrg test flaky fix

* JSObToListWidget_Spec.ts - commenting until bugfix

* COmmenting JSobjToInput spec

* Commonlocators added back

* Entity explorer name fix

* Locators fix

* Locator corrected

* Cypress.json removed files from ignoring list

* S3 & Postgress failures fix

* Postgress failure locator fix

* S3 upload script skipping until bug fix

* Params Bug 10784 script started

* Fixing Promises Spec

* Increased wait time!

* MigrationSpec - Image column,Cardformat,Pagestyles

* S3, Postgres, Promise - failures fix

* Canvas renamed

* Bug 11415 - Added Validations

* InputWidgets_navigateTo - flaky fix

* MigrationSpec - import change

* Locators files - Json to Js conversion

* DS plugnis name change

* Locators - Json to JS conversion

* Locators - Json to JS updations

* Select_Widget_Value flaky fix

* Adding timeout for execute calls to finish

* Migration spec - diff syntax+List.js flaky fix

* List & MIgration flaky fix
2022-03-02 16:54:43 +00:00
Nidhi
5c994975d7
fix: Modified action execution endpoint (#9473) 2022-03-02 16:01:50 +00:00
Nidhi
eaf1701d7e
fix: Modified error from string to first error object in debugger log (#11511) 2022-03-02 15:52:35 +00:00
Bhavin K
12954d4e3d
fix: changed download flow for image control (#11391)
* fix: changed download flow for image control

* test: cypress test added

* fix cypress test case
2022-03-02 13:43:24 +00:00
rahulramesha
4c1a6674fa
fix: separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas (#11396)
* separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas
2022-03-02 13:42:41 +00:00
Anagh Hegde
1d90a9fed9
feat: Add API for delete branch for git connected application (#11432)
* Add API to delete git branches

* WIP

* Fix test failures

* Change the method from POST to DELETE

* Changes per review

* Changes per review
2022-03-02 13:42:16 +00:00
f0c1s
8666fc23ff
fix: use sentence casing (#11376) 2022-03-02 13:42:06 +00:00
Bhavin K
c6f5dcb673
fix: handle main container height (#11461) 2022-03-02 13:41:44 +00:00
Preet Sidhu
5bfb770d2c
Merge pull request #11503 from appsmithorg/fix-1146_page_editor_behaviour
fix: 11476 page editor behaviour upon visibility toggle
2022-03-02 13:46:34 +05:30
rashmi rai
82a56222d2
fix: added allowDeselection in ads/dropdown (#11495)
* added allowDeselection in ads/dropdown

* fix dropdown height multi-selection

* add tests

Co-authored-by: Aswath K <aswath@appsmith.com>
2022-03-02 13:15:43 +05:30
Preet
96b9cc6523 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-03-02 12:09:21 +05:30
Preet
e64bf8f60b Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-03-02 12:07:26 +05:30
Hetu Nandu
ac7a73f667
fix: table button multi-line execution (#11525) 2022-03-02 12:07:20 +05:30
Shrikant Sharat Kandula
22f24110e7
Fix extra space in email placehoder in signup page (#11436) 2022-03-02 11:54:44 +05:30
Nayan
3cfc3781f1
Handle NPE in home page API (#11481) 2022-03-02 11:54:24 +05:30
Preet
cbeeba64f2 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-02-28 23:10:50 +05:30
Ayangade Adeoluwa
51b43daa1b
fix: Fixes modal pop up bugs on page load (#11504)
* Fixes modal pop up bugs on page load

* send confirmBeforeExecute attribute with page execution order info

(cherry picked from commit 6d3cfdfbdb83b435e67797f3fb27024799d5d579)

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-02-28 23:07:21 +05:30
Preet
9831f9e334 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-02-28 19:57:31 +05:30
Tolulope Adetula
1ea734bc14
fix: revert #8121 (#11502) 2022-02-28 19:44:56 +05:30
Preet
bfad6f4af4 check for drag distance 2022-02-28 18:33:05 +05:30
Abhinav Jha
a70763d1c3
Add showdown types package as a dev dependency for the client (#11496) 2022-02-28 18:08:56 +05:30
Hetu Nandu
06bf4696b4
fix: Promises in Table buttons (#11239) 2022-02-28 15:05:43 +05:30
Bharat Patodi
59c0d94ade
chore: Replace require with import statements (#8121) 2022-02-28 14:53:19 +05:30
Aswath K
ad952bb9a9
feat: make outgoing entities keyboard accessible (#11446) 2022-02-28 14:33:09 +05:30
Ankita Kinger
821c0d2021
css changes for invite users and manage users tables (#11441) 2022-02-28 11:38:33 +05:30
Ayush Pahwa
813d5850b0
fix: Update api params for dynamic fetched values (#11463)
* <feat> Updated payload for formEvals

- Added datasource and plugin ID to the payload

* <feat> Added IDs to dispatch calls

- Added datasource and plugin IDs to the dispatch calls so they can be used for dynamic query fetch

* <feat> Added type in evaluation saga

- Added datasource ID and plugin ID in the expected type for the eval function
- Updated call type from GET to POST for the dynamic trigger URLs

* <feat> Made params compulsory for editor config

- Params are now compulsory for any config defined in editor JSON for the dynamic value fetching

* <feat> Updated API definition

- Update the definition for the axios function from GET to POST

* <feat> Added configProperty to payload

- Added configProperty to the payload to allow for distinction between different components making a call to the server

* <chroe> Added null check

- Added null check to function call for datasource and plugin IDs in API since they are not compulsory in the type

* <refactor> Remove unused imports
2022-02-27 03:32:36 +00:00
Ayush Pahwa
fe2d625f5e
fix: Updated drop down control memo usage (#11218)
* Stopped props drilling of eval state

* Connect drop down to redux state

* Added extra check to formcontrol memo function

* Reduced modification of section at top

* Stopped mutating the initial state

* Created selector to get dynamic fetched values

* <refactor> Added comments and refactors

- Added key to the ES fragment
- Cleaned drop down component from redundant code
- Added comments

* <refactor> Removed test files

- Removed testing JSON configs

* <fix> Added null check for form eval output

- Added check to prevent null evalOutput in forms

* <chore> Removed console error

- Removed console error which is causing the vercel builds to fail
2022-02-26 22:41:38 +05:30
NandanAnantharamu
a2240c7107
test: Added test for Table Switch binding (#11423)
* Added test for Table Switch binding

* Updated test
2022-02-26 16:21:39 +05:30
NandanAnantharamu
5d2c35606c
Bug10757 automation (#11149) 2022-02-26 10:59:58 +05:30
rashmi rai
705d275d12
fix: add binding paths for new UQI components (#11287) 2022-02-26 09:22:06 +05:30
Rishabh Rathod
7a484fc027
fix: meta changes (non-default) also update metaHOC state (#10734)
* Reset metaHOC state on widget reset

* Pass all meta values for metaHOC reset logic

* pass only metaReducer values in meta

* fix unit test

* Add test
2022-02-26 02:16:04 +05:30
Parthvi12
71acf31fef
test: commenting git sync tests until fixed (#11450)
* commenting git sync tests until fixed

* updating datasource locators

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-02-25 14:56:09 +00:00
Anagh Hegde
231cb34199
Add check for yml CI files in git connect (#11431) 2022-02-25 17:51:45 +05:30
Ayangade Adeoluwa
72b718ce11
fix: Fixes UI and functionality issues on the Curl editor page (#11405) 2022-02-25 15:01:06 +05:30
Shrikant Sharat Kandula
8056e76946
Fix casing of plugin names (#11447)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-25 13:10:31 +05:30
Rishabh Saxena
acf01995bd
chore: git sync cypress tests (#10006)
* Fix connect test

* check api response

* [wip] test comments across branches (#8704)

* Intercept only connect api

* chore: update switch branches tests (#9005)

* test switch branches from the query params

* test flow wip

* .

* fix merge status update

* change mergeAble to isMergeAble

* wip

* fix: show error popup if pulled from bottom bar

* fix: append branch query to notification links

* fix: disable git connection during onboarding

* fix: typo

* fix: typo

* fix: typo

* fix: z-index bottom bar cout

* fix: pull button minor fix

* fix: reset conflicts when the git sync modal is opened

* fix

* feat: enable search for branch dropdown

* fix

* fix: typo

* added merge conflicting on merge tab

* updated gitsyncsaga for git sync error action

* added generate ssh key on init and updated git changed count message

* removed git sync error action from error processing module(toast and log)

* commented push button on bottom git action bar temperory

* added option to use git global config

* Added latest deploy preview time: didn't appear until the duration was in minutes

* Link open repo button with repo link

* fixed of commented code part

* upated tooltip of push button on bottom quick git sync toolbar

* Update banner styles for error and warning

* updated repo publish url pattern and last deployed view part

* when the user clicks on the push icon the deploy tab should open

* when branch name is too big and user hover on it the tooltip is not displayed

* The dropdown alignment displayed for the git connect should be polished

* update tests

* fix: minor git sync fixes (#9228)

* fixed of Under the merge tab when the user searches for the branch name which is not present the pop up closes all of a sudden

* fix: update merge api, use message from api response

* fix: update field

* added tooltip of long dropdown option and updated merge tab dropdowns

* removed log

* chore: add connection cypress tests

* temp update for running tests locally

* fixed long branch name on branch list popup

* Use _ as the branch name separator, instead of -

* Use large buttons as CTAs

* Remove the % from the progress bar

* Fix alignment for the skeletons on the deploy tab

* Merge CTA moves down when the status is rendered, add offset to prevent that and error branch dropdown on merge tab

* Show progress bar after clicking on Merge CTA as the loading state and generate key button

* after generating the deploy key before clicking on connect close the pop-up and open it again the Remote URL is not visible in the input box

* fixing of conflicting issue

* updated git connection design

* Provide more spacing between the lines

* Learn more does not have a hover state

* Heading Merge Changes should be sentence cased like headings on other tabs

* Button can trigger CTA call when in loading state

* disabled clickable icon on git connect bottom bar

* Git connection tab: on error the window doesn't scroll all the way to the bottom

* updated temp remote url values on action and reducer

* updated ellipsis functions of text

* fix: prune branch flag

* fix: update page level roomId to include branch name

* fix

* fix

* feat: add a separate feature flag for git import

* feat: branch section headers bottom bar branch list

* fixed branch list comments

* fixed merge issue

* fix

* feat: hotkey for commit and push

* remove pull button on git conflict info

* move tempRemoteUrl redux to gitSyncreducer and added messages

* splited git error as individual action

* removed push button from git sync bottom buttons

* feat: section header at the merge dropdown

* added comment of converting ssh to https

* feat: show connected to git badge

* feat: show asterisk when we have uncommitted changes

* fix: upate segment header for dropdown

* t fix: remove redundant success toasts

* removed tempory git repo url from app data

* wrapped tooltip with elipsis text

* fix: rm unused vars

* fix: bottom bar icon updates

* updated dropdown option with ellipsis text

* added new props named "wrappedOption" on dropdown for wrapping ellipsis option

* rename wrappedOption to truncateOption on dropdown component

* updated dropdown option with disabled props of tooltip

* fix: remove remote branches from merge branch dropdown

* reset yarn lock

* reset yarn

* fix: keeping it same as the existing value

* fix: remove branch dropdown border

* fix: show merge success indicator

* feat: init repo limit error modal

* fix: disconnect git wip

* added git user config test

* removed test data

* fix: checkout api

* fix: lint

* chore: pre connection test specs

* added revoking git workflow

* renamed revoke to disconnectGit

* added setting on git sync action over bottom bar

* added analytic on git connection

* added learn more for remote url and init module of temp remote url when select new application

* .

* chore: test learn more ssh url

* Verify the functionality of Read documantation link

* added git connect with onboarding workflow

* Validate the Input Box displayed below Commit to master Text

* updated test module for deploy tab with commit comment and deploy preview

* test of prune branch name

* Validate the error faced when user switches between the branches

* verify the functionality when user click on "+" Icon

* Verify the functionality of serach input box inside the serach dropdown

* Verify the display of the Merge Button

* advanced of disconnect git ui

* added git disconnect modal test case

* updated repo limit error condition

* added learn more link test on git disconnect modal

* for review of repo limit error modal test script.

* fix: issue with intercept

* fixes

* fixes

* add key, misc fixes

* fix

* revert changes

* fix

* fix imports

* Fix import

* Yarn lock update

* fix

* fix imports

* chore: remove timeout for a test run

* Increase timeout for jgit APIs

* chore: try increasing timeout

* try increasing timeout further

* Handle git connect error on the basis of error type

* Add env variable to CI build script

* Fix bad commit for adding env var in workflow

* Refactor

* FAdd env var for local repo path

* fix import

* fix specs

* fix

* fix

* try

* fix

* fix

* fix

* fix

* fix: don't validate error msgs

* fix spec

* improve spec

* chore: rm unused code

* chore: update descriptions

* rm commented out code

* fix

* rm comment

* chore: rm comments

* fix: lint

* chore: update comment

* fix: wait for widget switch transition

* spec updates

* fix

* fix imports

* try waiting for getPagesForViewApp

* fix: rm unused file

* fix: remove spec

* fix: add js collection, comment out repo limit exceeded error since it seems not limited on appsmith instances

* Fix server failure

* chore: correct bootIntercom import and sort lines

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Abhijeet <abhijeet@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: f0c1s <anubhav@appsmith.com>
2022-02-25 06:13:16 +00:00
Shrikant Sharat Kandula
68d8c27a94
Remove CORS allow-star from RTS (#11437) 2022-02-25 10:26:04 +05:30
arunvjn
fa7d0f6a9f
Added zipy.ai for analytics (#11411) 2022-02-25 08:58:03 +05:30
Shrikant Sharat Kandula
fb19d0ef99
Scrolling issue in container and modals for app view (#11424) 2022-02-24 20:49:25 +05:30
Abhijeet
612d7d6727
feat: API to provide a way to distinguish if the application is updated manually or through DB migration (#11414)
* Added check for updating application resources manually

* Refactor to include client-side migration
2022-02-24 14:17:50 +00:00
Tolulope Adetula
8ab5557e39 fix: add Modal scroll cypress tests 2022-02-24 14:48:13 +01:00
akash-codemonk
cb4b9595d1
fix: indicator does not appear while attaching onClick handler during guided tour (#10739) 2022-02-24 18:43:23 +05:30
Tolulope Adetula
588e1356e3 fix: scrolling issue in container and modals for app view 2022-02-24 13:54:37 +01:00
Nayan
10033aea09
-Added new API to return list of default plugins (#11297)
Added a new API that'll return a list of plugins which are available to install. In other words, it'll return list of default/system plugins. This returns the package name, name and icon only - which will be used by templates to show datasource name and icons.
2022-02-24 16:43:11 +06:00
Nayan
32757a9f35
-set feature flag for templates (#11368)
Adds feature flag for templates.
2022-02-24 16:39:15 +06:00
Mojtaba
450950d68f
fix: curl import tries to guess the content-type from the body if content-type header is not specified (#11295)
* fix: content-type is empty when it's not specified.

* feat: try to guess the content type json or form-urlencoded

* fix: broken test for curl with `--data-urlencode` parameter

* fix: fix guessing urlEncodedPattern

* fix: fix broken tests

* fix: Fixed and improved the code formatting
2022-02-24 13:58:26 +03:30
Pawan Kumar
cc3f98c0f1
chore: Remove chance lib (#11230)
* remove chance

* update yarn.lock

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-02-24 10:04:17 +00:00
Bhavin K
73a3a2452e
fix: added width cap, updated props to handle size (#11357) 2022-02-24 13:51:45 +05:30
Abhijeet
86c7c09982
fix: Map correct collection ids for onPageLoad actions during import application (#11328)
* Introduce defaultCollectionId for onLayoutLoadAction

* Added TC for clone application

* ImportExportSpec & Dropdown resetSpec flaky fix

* Fix test failures

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-24 12:42:28 +05:30
Aswath K
2ad121a092
feat: Keyboard accessible property pane header (#11339) 2022-02-24 12:34:31 +05:30
Paul Li
bd9636f514
fix: left border of Input widget is cut off when icon is set and left aligned (#11257)
-- Remove the CSS rule for border-left to be transparent
2022-02-24 11:30:55 +05:30
Arsalan Yaldram
f719a791e8
Merge pull request #11195 from appsmithorg/reset-widget-option
fix: Add true as the default param to resetWidget function.
2022-02-24 10:33:06 +05:30
akash-codemonk
61a163127d
fix: scroll hides content on the canvas in guided tour (#10735)
- Also datasource structure to be expanded only when user expands it in guided tour
2022-02-24 09:38:43 +05:30
Paul Li
4b80ea27e9
fix: Some .jpg images don't load in the Image Widget (#11247) 2022-02-24 09:07:54 +05:30
Aishwarya-U-R
67652287f2
test: Automated tests for Table Migration scenarios + Flaky fixes (#11360)
* Migration table script added

* Migration case & inputv2 flaky fix

* Added menu btn validations

* MigrationSpec - Added sorting valiation

* Flaky tests fix

* LIstWidget api.users count fix

* ListWidget api.users count validation fix

* Bind_ApI spec - added waituntil
2022-02-24 08:41:35 +05:30
Tolulope Adetula
facf6a3d96
fix: date picker uniformity when only Month or year is changed (#11077)
* fix: date picker uniformity

* cypress tests

* fix: Failing date picker test

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-23 15:54:24 -08:00
Tolulope Adetula
27d645955a
fix: long page name text cutting off in preview mode (#11345) 2022-02-23 23:53:49 +00:00
Apeksha Bhosale
db2c638fc4
fix: after JS object delete success move to page url (#11331) 2022-02-23 18:09:41 +00:00
Bhavin K
89bc82b4f5
fix: radio widget example string (#11352) 2022-02-23 17:23:15 +00:00
Preet Sidhu
cc2242de9d
fix: page dragging in Pages editor (#11377) 2022-02-23 22:24:43 +05:30
Arsalan
b34a6c8268 Merge branch 'release' into reset-widget-option 2022-02-23 22:24:00 +05:30
Nayan
4ae0b5b1de
fix: Set comment authors email address as reply to field in comment notification email (#11251) 2022-02-23 21:56:57 +05:30
Favour Ohanekwu
d2c96b9727
fix: suppress warnings about the use of expressions where assignments are expected (#11343) 2022-02-23 21:49:44 +05:30
Tolulope Adetula
06eac9387e
fix: make table button transparent when no color is selected (#11348)
* fix: make table button transparent when no color is selected

* fix:  failing tests in Table_widget_add _button_spec
2022-02-23 07:54:46 -08:00
balajisoundar
5dc5cff722
fix: Update date ISO string validations (#11399) 2022-02-23 20:48:58 +05:30
Paul Li
c30f072c84
fix: Input widget onSubmit ends up triggering onTextChange (#11304)
-- Make onSubmitSuccess callback not to trigger additional onTextChange
2022-02-23 20:44:55 +08:00
Arsalan
5b892ec3fa fix: Removed Datasources from Execute Query Action List. 2022-02-23 17:28:50 +05:30
f0c1s
64a9fd451b
chore: remove second scrollbar from git connect modal (#11336) 2022-02-23 15:41:58 +05:30
f0c1s
989086337a
chore: reformat code in rts/ service (#11309) 2022-02-23 15:36:40 +05:30
Nayan
f060ab8c03
feat: Allow saving theme customizations (#11165)
This PR adds API to save a customized theme so that it can be used again for that application. It also adds permission to themes. Each customized theme will have permissions set just like other domain objects.
2022-02-23 12:32:18 +06:00
Bhavin K
03dc8da930
fix: updated max character validation (#11333) 2022-02-23 11:53:58 +05:30
Preet Sidhu
91f3e11984
Merge pull request #11323 from appsmithorg/fix-9367_resize_property_pane
fix: Property panel resize on dragging
2022-02-23 11:21:59 +05:30
Bhavin K
e944f1b17c
fix: handled to hide widget in preview mode (#11138)
* fix: handled to hide widget in preview mode

* docs : comment update

* fix: condition updated as required, cypress test added

* fix: simpler condition, types updated
2022-02-23 10:22:04 +05:30
Rishi Kumar Ray
7a97640a07
chore: Update config label in Rest API datasource config page (#11107) 2022-02-23 09:51:50 +05:30
Preet
9adf3cbb66 Merge remote-tracking branch 'origin/release' into fix-9367_resize_property_pane 2022-02-22 22:07:43 +05:30
NandanAnantharamu
9016fa0a85
test: updated flaky test (#11324)
* updated flaky test

* updated test PageOnLoad

* commented out flaky test
2022-02-22 21:05:22 +05:30
Ayangade Adeoluwa
be685ef815
Prevent content-type header from changing when switching to raw mode in API pane (#11326)
This commit fixes post body type switcher in API editor. Prior to this PR,
switching the post body to Raw changes the content-type to "text/plain", This
fixes that by preserving the previous content-type when user switches to raw or
none body type. It also gives users the flexibility to use any non supported
content type, while in Raw body mode.
2022-02-22 16:32:43 +05:30
Tolulope Adetula
24293ced76
fix: select widget accept string and object in the defaultOption property (#11082)
* fix: Select widget accept string and object

* fix: JSON object case

* Fix: make Multiselect Defaukt option Array of strings

* fix: Select and Multiselect

* fixes and test cases

* comments

* fix: Select option value

* fix: mutiselect and test case

* fix: failing test

* fix: reset select widget

* fix: PR issues

* fix: Select widget Reset

* fix: failing Test

* fix: test

* fix: tests

* FIX: EVALUATION TESTS

* fix: getting Select Value in form

* fix: Test cases

* fix: add more test cases

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-22 00:43:35 -08:00
Paul Li
42b2dc80e2
fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.) (#11085)
* fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.)

-- Set trimValue prop to false with property controls such as TabControl, MenuItemsControl, ButtonListControl, PrimaryColumnsControl

* fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.)

-- Make trimValue property default to false
2022-02-22 12:17:55 +05:30
Preet
4fb3d7169f use clientWidth instead of getBoundingClientRect 2022-02-21 22:11:50 +05:30
albinAppsmith
5022df9192
Open fix: Username and email hardcoded in mobile sidebar (#11300) 2022-02-21 16:45:11 +05:30
Trisha Anand
860b573bc2
chore: Rename metadata to idToken (#11313) 2022-02-21 16:43:37 +05:30
Bhavin K
707dd9bb8a
fix: updated css for ISDCode Dropdown in the phone widget so that placeholder does not collapses to the left when disabled (#11196) 2022-02-21 11:12:39 +05:30
arunvjn
d27dd30415
feat: Added use case input box in welcome tour to input custom use caes (#11171) 2022-02-19 11:56:10 +05:30
Bhavin K
9eeb120c77
fix: updated height for page view (#10796) 2022-02-18 19:34:14 +05:30
Apeksha Bhosale
44597c5e57
fix: marking old async functions as async in the backed for settings (#10723) 2022-02-18 19:28:11 +05:30
Apeksha Bhosale
92a8df8f04
fix: push js object after creation (#11123) 2022-02-18 19:27:38 +05:30
Arsalan Yaldram
d12ae7a800
fix: Table Filter pane overflows when Table is at the top of the canvas (#10618)
* Added boundaryParent prop to Propperto prevent table filter pane overflow.

* Review Changes, done.

* Resolved overflow issue with multiple pages.

* Removed hardcoded Top value while dragging.

* Added parentElement as a function parameter.
2022-02-18 12:26:09 +00:00
Arsalan Yaldram
45da98f1dd
Merge pull request #10935 from appsmithorg/fix/10766-rating-inactive-color
fix: Rating Widget inactive-color.
2022-02-18 17:54:44 +05:30
yatinappsmith
bd7ae1f924
test: Added test event driver (#11222)
* Added test event driver

* changed port to 28017

* updated credentials

* updated password for postgres

* Update forkedApp.json

* fixing ImportExportForkApplication_spec

* fixing ImportExportFork_spec

* updating testdata

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-02-18 17:45:05 +05:30
Nayan
a877d137a6
fix: NPE when application has no page (#11204)
This PR fixes a NPE when application has no page or page are missing.
2022-02-18 12:14:02 +00:00
Satish Gandham
bcf6e616f5
Fix an issue with saving run data (#11242) 2022-02-18 16:03:39 +05:30
albinAppsmith
9fd6292c32
fix: Appsmith Design System fixes and improvements (#11011)
* * Added index file for Appsmith Design System
* Datasource context menu, changed position of delete

* * page setting icon color fix

* * filepicker image padding added

* * Debug button icon change

* * share modal design changes according to Appsmith Design System

* * Release notes modal - added see more functionality

* * Navbar header arrow fix

* * Padding fixed in share modal

* * Changed share icon in applications page

* * Header height changed to 32px from 34px

* * Removed icontab component index file of ADS

* * Added AppPageLayout cy test in ignore list
2022-02-18 15:21:02 +05:30
Mojtaba
dad6dfb636
fix: Fixed test MongoDB datasource shows ok even if there is no database matching the name in the 'Default Database Name' input (#11238) 2022-02-18 10:41:01 +03:30
Ayangade Adeoluwa
ead4d875fa
feat: add confirmation for Datasource deletion operation (#11180)
* add confirmation for Datasource, refactor other components

* fix failing cypress tests

* fix Mongo_spec failing test
2022-02-18 07:58:36 +01:00
f0c1s
c03ecf2e13
fix: update git connect modal (#11249)
Show notification banner on SSH key generation and regeneration
Remove BETA tag from Git Connection
2022-02-18 12:13:07 +05:30
Confidence Okoghenun
7ebaa577a3
chore: Updates JS editor default text (#10912) 2022-02-18 07:11:12 +05:30
albinAppsmith
39e28f4e1b
feat: Homepage mobile UI (#10255)
* * Added hooks for detecting device
* fixed partial header issues

* * mobile UI completed

* config URL changed

* * bug fix

* * bug fix

* * mobile - on tap of app card launch app

* * conflict fix
* removed context menu from app card

* * homepage cy fix
2022-02-17 22:08:36 +05:30
Favour Ohanekwu
46810e832a
fix: remove dependencies from trigger fields (#11163) 2022-02-17 21:27:23 +05:30
Shrikant Sharat Kandula
4d3e1282ad
Move data counts to properties for analytics (#11236)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-17 19:07:31 +05:30
f0c1s
a2e2bf0055
chore: introduce lookup tables inplace of switch (#11228) 2022-02-17 17:49:39 +05:30
Paul Li
12dad5737d
fix: Issues and Enhancements in the camera widget (#10943)
* fix: Issues and Enhancements in the camera widget

-- Fix on an image stretching issue when taking a picture
-- Set background to black
-- Add onImageSave, onVideoSave Actions
-- Rename Camera to Image

* fix: Issues and Enhancements in the camera widget

-- List all device info only when one or more MediaStreams are active

* fix: Issues and Enhancements in the camera widget

-- Always keep camera aspect ratio when resizing

* fix: Issues and Enhancements in the camera widget

-- Add a Cypress test case for onSaveImage property

* Increased wait!

* Camera case failure locator fix

* Camera case locator fix

* Promises restWidget moved to last!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-17 20:10:32 +08:00
Paul Li
f3360d814e
fix: Text widget shows a horizontal scroll on center and right alignment (#11189)
-- Set overflow-x to hidden on StyledText
2022-02-17 20:01:15 +08:00
rahulramesha
13a0258c9c
changing reflow threshold to 10/10 from 20/20 (#11210) 2022-02-17 15:07:22 +05:30
Leo Thomas
69f7136a81
fix: 8878 - To handle Comma delimited float values (#11207)
* fix: 8878 - To handle Comma delimited float values

* Code review comments fixes

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-02-17 13:30:01 +05:30
Trisha Anand
ac7ccfd243
feat: Disable form login configurable via admin settings page. (#11234) 2022-02-17 07:54:07 +00:00
f0c1s
5aba318f67
chore: remove pointer cursor from dialog header icons. (#11216) 2022-02-17 12:36:05 +05:30
Abhijeet
aaf9740674
chore: Remove theme ids during git commit (#11225) 2022-02-17 05:33:25 +00:00
Hetu Nandu
8599130176
fix: Wait for evaluation before completing resetWidget and storeValue functions (#11178) 2022-02-17 10:01:59 +05:30
Anagh Hegde
9992a9ae3c
feat: Add api to check the git connection after the key is regenerated (#11144)
* Add api to check the git connection

* Add analytics event for test connection api
2022-02-16 22:25:38 +05:30
Abhinav Jha
938edd5284
chore: Remove old way of adding feature flags (#11213)
* Remove optimizely, as it isn't being used anymore from the frontend codebase

* Remove optimizely references form netlify config, vercel config, index.html, docker script, nginx templates and example .env file
2022-02-16 19:57:58 +05:30
Satish Gandham
4bff451735
chore: persist performance test results (#11208)
* Persist performance run data to supabase

* Remove stray comment

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-16 19:55:33 +05:30
Arsalan Yaldram
8c83cf767b
Merge pull request #10919 from appsmithorg/fix/10780-circular-progress-icon
fix: Add circular progress svg to WidgetIcons.tsx
2022-02-16 17:03:26 +05:30
Daniel
5994e87648
fix: fix spacing for encrypted tag for form control (#11063) 2022-02-16 11:12:00 +00:00
f0c1s
64669f5e45
feat: ssh key regeneration (#11018)
feat/ssh-key-regeneration - implementation

- moved copy icon inside the input box
- added regenerate ssh key function on git connection
- remove learn more and paste text from top
- introduce SSH Key label
- introduce ads/NotificationBanner
- update NotificationBanner integration
- jest tests
- system notification on key regeneration
- use @appsmith for constants/messages
- update imports
- remove optional chaining

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-02-16 10:15:35 +00:00
Mojtaba
497dd1a21b
fix: showing invalid credentials message on MongoDB test datasource if there is an unauthorized error (#11124)
* fix: if test datasource gets Unauthorized accessing admin database
It will try to access the default database.

* fix: fix broken test

* fix: cleanup unused imports

* test: make test more readable with better comments
2022-02-16 14:03:13 +05:30
Leo Thomas
4c81347128
fix: 7794 Google Sheet Fails with Mixed Datatype (#11089)
* fix: 7794 Google Sheet Fails with Mixed Datatype

* resolved failing test cases after new implementation

* Added code comments to the changes

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-02-16 08:22:40 +00:00
Abhijeet
325f27982a
fix: Take previously connected git applications accessibility into consideration to accurately calculate private repo count (#11151)
* Take already connected apps repo accessibility into account during connect and import flows

* Testcases for private repo limit check
2022-02-16 13:36:39 +05:30
Arsalan Yaldram
81e79af04f
Merge pull request #10954 from appsmithorg/fix/10697-rating-widget-flickering
fix: rating widgets flickering when value is reduced.
2022-02-16 13:27:21 +05:30
Arsalan
9c414355a2 fix: added true option as default for resetWidget 2022-02-16 11:54:37 +05:30
Nayan
eefae47b09
feat: Return page slug for default pages in get applications API in home page (#11080)
The GET /application/new API is used to show list of organizations, applications in home page. The list of pages under each application contains only page id. As we're introducing page slugs in URLs, we need the slug of the default page inside the response of this API. This PR adds default page's slug to the response of GET /application/new API.
2022-02-16 12:19:29 +06:00
dependabot[bot]
7ddf4d0ab2
chore: bump postgresql in /app/server/appsmith-plugins/postgresPlugin (#11190)
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.25 to 42.3.3.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.25...REL42.3.3)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-16 08:57:41 +05:30
Ayangade Adeoluwa
b69f85891f
fix: ensure backward compatibility with older Actions. (#11184) 2022-02-16 08:47:13 +05:30
Vicky Bansal
10cb49b2ee
fix: add ellipsis when the page name is longer than width (#10667) 2022-02-16 00:16:37 +05:30
Vicky Bansal
e77ab8b06c
fix: add ellipsis to table search input when blur (#11020) 2022-02-16 00:16:21 +05:30
Favour Ohanekwu
a659cba4ea
chore: upgrade jshint to fix security alert (#11179) 2022-02-15 23:23:19 +05:30
Félix Suarez Bonilla
9bcd4afff1
feat: Add Mongo Templates for plugin. (#11153)
Adds templates for the Aggregate, Distinct and Count commands for the MongoDB plugin.
2022-02-15 10:29:01 -06:00
Nidhi
7a8db4270a
fix: Added channel timeout configurations for REST WebClient provider (#11177) 2022-02-15 13:19:20 +00:00
Aswath K
f610c749f9
feat: Step control keyboard navigation (#11059)
* Make step control keyboard accessible

* Add Jest tests
2022-02-15 17:55:11 +05:30
Arpit Mohan
286864eb3d
feat: Support body in GET API requests (#7127)
* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* adds apiContentType to actionConfiguration.formData object

* Handling apiContentType property in Rest API formData

* change apiContentType when user types content-type value and switches http method

* makes api editor as similar as possible to postman, project postman.

* Correcting the import in ApiEditorConstants

* Resolved all merge conflicts

* replay DSL functtionality

* removes unneccessary files from worker

* Fixes type declarations, naming e.t.c.

* fix server side merge conflicts

* fix client side merge conflicts

* fix failing cypress tests

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
2022-02-15 11:13:48 +00:00
Abhijeet
ce2cf1ba3a
fix: Fix error code for application controller test case(#11161)
* Fix error code for the application controller TCs

* Fix import-export TCs
2022-02-15 16:28:02 +05:30
Tolulope Adetula
7837b568af
fix: select Widget resize (#11048) 2022-02-14 23:34:53 -08:00
Tolulope Adetula
fd4c99ccf2
fix: dropdown propert control (#11041) 2022-02-14 23:34:17 -08:00
Sumit Kumar
d208792786
fix: S3 plugin: remove Expiry Duration config from Read file query
* This PR removes the Expiry Duration field from the Read file command of S3 plugin.
* An Expiry Duration field got added to Read file command mistakenly some time post migration to UQI schema. This field did not exist with the read command before the migration and does not get used even now.
2022-02-15 12:24:48 +05:30
Nidhi
1868675349
feat: Self-signed certificates for REST APIs (#11043)
* feat: Self-signed certificates for REST APIs

* Changed scope for netty dep
2022-02-15 06:54:26 +00:00
Sumit Kumar
00a7647590
feat: S3 plugin: add command to delete multiple files at a time
* Add a new command Delete multiple files. This command will allow users to delete many files at once. Currently, only one file can be deleted at a time. It takes an array of files as config parameter from the user e.g. ["file1", "file2"]
* Add template for the new command.
* Add template for the command Create multiple files
2022-02-15 12:24:16 +05:30
Trisha Anand
e892ba18a7
Moving ActionServiceTest to ce package (#11125) 2022-02-15 06:54:03 +00:00
Abhijeet
d8e4ba61fe
fix: Add migration for actionCollection and newAction to improve the performance for getResourceByPageId queries (#11148) 2022-02-14 20:07:02 +00:00
Ankita Kinger
0998b441e7
refactor: superadmin settings UI/UX (#11130)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

* css changes for admin settings page and breadcrumb removal

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2022-02-14 17:25:12 +05:30
Trisha Anand
80bab90e28
chore: Minor code refactoring for bean utils and action execution (#11102) 2022-02-14 10:24:54 +05:30
Sumit Kumar
d03f503657 add new command: delete multiple files
add template for delete multiple files
add template for create multiple files
add / update TCs
2022-02-14 10:18:01 +05:30
Sumit Kumar
004bd89e7a fix read.json 2022-02-14 07:07:10 +05:30
Anagh Hegde
eb54d7d325
fix: Remove default error fields for git-sync related analytics for success events (#11097)
* Do not include the error data points in the map for success states

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2022-02-12 15:10:52 +05:30
Ankita Kinger
c29c2f745e
fix: Comment icon gets hidden behind tabs on Tab widget (#11019)
* fix for z-index issue on comments icon

* css changes

* fixed failing cypress tests
2022-02-12 08:28:13 +05:30
Pranav Kanade
b778b83ac4
refactor: admin settings (#9906)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-02-11 23:38:46 +05:30
Abhijeet
d218b48cf6
fix: Increase supported header size for multipart data (#11058)
* Increase supported header size for multipart data to 128kB

* Update error to be thrown from the global exception handler
2022-02-11 11:26:40 +00:00
Ayangade Adeoluwa
44ce1d4b5a
fix: fixes apiEditor url overflow, indicates active datasource in datasour… (#10663)
* fixes apiEditor url overflow, indicates active datasource in datasources list

* Adds custom tooltip to datasource url, and optimizes the performance of ApiEditor form

* hide the custom tooltip whenever there is a default datasource config on the page

* Making the implementation more reusable

* fix failing cypress tests and increase delay for tooltip

* A better implementation and also making the logic more reusable

* remove comments

* Fix prettier issues due to merge with release
2022-02-11 12:02:47 +01:00
Ayangade Adeoluwa
c06c8b817e
fixes numbering system for dynamic bindings in evaluated popup text (#11005) 2022-02-11 11:53:50 +01:00
Apeksha Bhosale
980c8cbf57
fix: added new library and reduced function calls for global data (#11001) 2022-02-11 16:22:27 +05:30
Abhijeet
6f7691b6aa
fix: Update error handling for git connect (#11070)
* Update error handling for git connect

* Add testcase for git generic error
2022-02-11 16:17:02 +05:30
balajisoundar
85cc3f3497
feat: Provide option in phone input widget to turn off auto formatting (#10832) 2022-02-11 15:39:38 +05:30
Tolulope Adetula
c992bd5285
feat: add more plugins to rich text editor (#11052) 2022-02-11 13:52:35 +05:30
arunvjn
9e0c0a1598
Sorted actions in explorer in alphabetical order to give them a predictable position (#10777) 2022-02-11 07:30:30 +00:00
Anagh Hegde
5bb73ce36f
Fix NPE in git analytics (#11072) 2022-02-11 05:49:29 +00:00
Aswath K
fb83b0fbc6
feat: Make Button Tab keyboard accessible (#10873) 2022-02-11 00:30:20 +05:30
Favour Ohanekwu
a1a774f7fe
fix: js editor not showing falsy values 🐞 (#10946) 2022-02-10 23:33:12 +05:30
Favour Ohanekwu
1ed7e9086c
keep linting in trigger field in sync with the state of the datatree (#10941) 2022-02-10 23:32:16 +05:30
Favour Ohanekwu
223be6c057
fix lint tooltip getting clipped (#10899) 2022-02-10 18:40:36 +01:00
balajisoundar
e67474a4f3
fix: Input, Phone and Currency input widgets valid property validations (#10966)
- When the user removes an expression from the validation property of
  input widget, its value becomes `""`. And in boolean validation
  function we treat this empty string as false. so Input widget
  ends up with isValid false and we show an error border around the
  Input. so we are setting a default value true, so when there is
  no expression it evaluates to true.
2022-02-10 17:06:18 +05:30
Abhijeet
860318e0fe
chore: Add stopwatch to log execution time by process name (#11069)
* Add stopwatch to log execution time by process name

* Refactor
2022-02-10 16:59:26 +05:30
Aswath K
9597c82f7c
feat: keyboard accessible multi-select dropdown, action selector and text input (#10622)
* feat: Add keyboard navigation to multiselect dropdown (#10397)

* feat: Make Action Selector keyboard accessible (#10005)

* feat: keyboard accessible text / code input (#10641)

* {Space} as an alternate option to make code editor editable
2022-02-10 16:42:44 +05:30
Satish Gandham
594e02edbd
chore: Increase cooldown time after app import for the app to load. #UI-Performance-infra (#10845)
* Code cleanup and fix typos

* Increase the wait time after app import

Increase the wait time after app import for the categories to load

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-10 16:16:55 +05:30
Pawan Kumar
d4eeff8fcc
fix: Header tags are not styled correctly in the Text widget (#10949)
* fix text widget styles

* add font weight in headings

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-02-10 12:25:33 +05:30
Abhijeet
ee6d639e42
chore: Update error handling for resource not found exception for clone, fork and import APIs #11044 2022-02-10 10:26:07 +05:30
Nayan
a5dec675b1
feat: Added application templates (#10952)
Added the required BE API for application templates. It gets templates from Appsmith cloud services through REST API.
2022-02-09 23:13:31 +06:00
Anagh Hegde
b1055cc94d
feat: Add gitHosting provider to analytics (#11036)
* Add gitHosting provider to analytics

* Add support for git provierders like bitbucket

* Change the logic to get provider name
2022-02-09 16:41:19 +00:00
Mojtaba
f6463d0cf8
fix: Added stricter validation for Mongo pipeline (#11034)
* fix(mongoPlugin): try to make JSON validation more strict

* test(mongoPlugin): add testAggregateCommandWithInvalidQuery
2022-02-09 22:04:03 +05:30
Trisha Anand
d7ce026b93
Minor refactor of code to avoid merge conflicts. (#11039) 2022-02-09 13:53:57 +00:00
balajisoundar
8f383ca8ea
fix: Phone Input and Input widget not getting reset on submit (#10860) 2022-02-09 17:33:10 +05:30
Aman Agarwal
9894a6522c
feat: added datasource icon on left of entity name, revamped name editor (#10821)
* feat: added datasource icon on left of entity name, revamped name editor

* fix: updated the hardcoded message strings to use message.ts

* fix: types of variables
2022-02-09 17:11:47 +05:30
Paul Li
ce42dcb00b
fix: Map pin does not center when location is changed and centering option is turned on (#10296)
* fix: Map pin does not center when location is changed and centering option is turned on

-- Update center meta property when defaultMarkers or mapCenter properties were changed

* fix: Map pin does not center when location is changed and centering option is turned on

-- Force the last marker to be centered
2022-02-09 18:39:07 +08:00
balajisoundar
fab552cafa
chore: Extend the list of widgets that cannot be used inside the List… (#10928) 2022-02-09 12:45:10 +05:30
Ankita Kinger
81760a94fc
Merge pull request #10942 from appsmithorg/hotfix/disable-signup-config
fix: Added disable signup form config
2022-02-09 12:35:16 +05:30
Vicky Bansal
e4e7c59bc2
fix: disable closing dropdown on space (#10945) 2022-02-09 12:32:57 +05:30
Shrikant Sharat Kandula
6e1e2faaac
chore: Anonymous stats if telemetry is enabled (#11014)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-09 10:31:00 +05:30
Sumit Kumar
aa2290405d
fix: fix refresh token flow in REST API OAuth (#10875)
Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
2022-02-09 09:38:58 +05:30
arunvjn
be1b5a5db3
Re-focus widgets search bar when the search text is cleared (#10763) 2022-02-09 04:00:56 +00:00
haojin111
0288f79b70
fix: added missed analytic events for git sync (#10953) 2022-02-08 21:46:16 +05:30
Abhinav Jha
9d21ccf52f
fix: Remove references of messages.ts in worker files (#11004) 2022-02-08 20:53:25 +05:30
Tolulope Adetula
453974b18e
fix: Multiselection in table widget (#10838)
* fix: Multiselection in table widget

* fix: add test cases
2022-02-08 06:41:25 -08:00
Ayangade Adeoluwa
21018c640f
fix: fixes uqi component issues (#10829)
* fixes uqi component issues

* fix dropdown container width issue
2022-02-08 12:51:41 +01:00
Abhinav Jha
aee5816a54
fix: limit validation errors in debugger (#10886)
* Add a limit to the number of error messages sent from validations to be rendered in the debugger
2022-02-08 17:13:25 +05:30
Leo Thomas
6e7687450e
fix: 9414 Firestore where clause not fetching numbers (#10775)
* Fixed issue with Firestore in fetching data while using numbers in the where condition.
* Other Fixes made in the where condition :
  When using Boolean
  When using Date 
  When Using Timestamp 
  When given space in the key
  When Space given in the Value
2022-02-08 11:29:50 +00:00
Ayangade Adeoluwa
da655b5748
fix margin top issues with checkbox form controls (#10930) 2022-02-08 11:29:17 +00:00
Arsalan
048d8ac349 fix: Rating widget flicker, when value is changed. 2022-02-08 12:52:43 +05:30
Abhijeet
fa0e900f3f
fix: Sort unordered set elements before committing to git repo so as to have same serialised output string for identical set of elements (#10933) 2022-02-08 00:48:20 +05:30
Ankita Kinger
1c8d804d88 added config for signup disabling 2022-02-07 20:48:44 +05:30
Arsalan
903b2cec4d Added grey as the default inactive color. 2022-02-07 17:28:11 +05:30
Sumit Kumar
5c3e12fc10
handle empty column name in sort component (#10895)
* This PR adds changes to ignore all the empty column names in sort component (or ignore the sort conditon if all column names are empty).
2022-02-07 08:55:26 +00:00
Abhijeet
fba0fc2fd7
chore: Remove git feature-flag (#10914)
* Remove git feature-flag
2022-02-07 06:46:15 +00:00
Arsalan
c0b290d0b6 Add circular progress svg to WidgetIcons.tsx 2022-02-07 11:22:55 +05:30
akash-codemonk
dbf8568c7b
fix: hide the image column in guided tour table (#10709) 2022-02-07 10:06:33 +05:30
Snyk bot
194b78b4c4
chore: Upgrade org.springframework:spring-webflux from 5.2.3.RELEASE to 5.3.15 (#4586)
* fix: upgrade org.springframework:spring-webflux from 5.2.3.RELEASE to 5.3.15

Snyk has created this PR to upgrade org.springframework:spring-webflux from 5.2.3.RELEASE to 5.3.15.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.springframework/spring-webflux/

See this project in Snyk:
https://app.snyk.io/org/nikhil-nu4/project/1b8549de-d47e-4508-85dd-9a19fa240760?utm_source=github&utm_medium=upgrade-pr

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-07 09:49:47 +05:30
NoxiousPenguin
abb3aebbba
chore: replaced == and != with === and !=== (#10733) 2022-02-05 11:11:15 +05:30
Rishabh Rathod
f91f860d1e
Add brotli and gzip compression (#10869) 2022-02-05 01:52:31 +05:30
dependabot[bot]
38108cc098
chore: bump postgresql in /app/server/appsmith-plugins/postgresPlugin (#10809)
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.12 to 42.2.25.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.12...REL42.2.25)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-05 00:51:45 +05:30
balajisoundar
c9f65d080a
fix: skip bad table migration thats breaking computed columns we di… (#10897) 2022-02-04 23:07:22 +05:30
Anand Srinivasan
c2a6e089db
fix: passing params from JS to API/SQL query (#10826)
* Revert "fix: revert this.params solution (#10322)"

This reverts commit 2bcd73e41d.

* replace 'this.params' with 'executionParams'

* replace 'this?.params' also with 'executionParams'

* fix unit test lint errors

* added unit tests for params handling

* evaluateActionBindings unit test - add default value case

* comments update

* remove un-necessary `executionparams` assigment to `evalTree`
2022-02-04 17:58:46 +05:30
Rishabh Rathod
1bcf344154
fix: Race condition issue of meta reducer update (#10837)
* Fix race condition issue of meta reducer update

* refactor comment

* Fix logic to update meta state
2022-02-04 17:52:25 +05:30
Ayangade Adeoluwa
aa129fc26b
feat: adds Headers tab to the Api response view (#10807)
* adds Headers field to the Api response view

* show empty object if headers not present
2022-02-04 12:32:38 +01:00
Vicky Bansal
b7ebc7501e
fix: Column tile reposition on focus state of Input element inside property pane configuration for Table and Tabs widget (#10046) 2022-02-04 16:29:54 +05:30
Rishabh Saxena
ebb257bac2
chore: update cta text and doc url on the disconnect modal (#10872) 2022-02-04 12:40:36 +05:30
Tolulope Adetula
c82fab975d
fix: table column visibility (#10808) 2022-02-04 08:09:37 +01:00
Anagh Hegde
fa06473d63
fix: Delete the pages post merge operation from application when they are removed from file system (#10810)
* Delete the pages post merge operation from application if they are removed from file system

* Changes per review

* Add tests

* changes per review

* Use string utils for null check

* Change per review

* Fix tests

* Fix tcs
2022-02-04 12:07:07 +05:30
Paul Li
6b45805f21
fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.) (#10724)
-- Set trimValue prop to false with property controls such as TabControl, MenuItemsControl, ButtonListControl, PrimaryColumnsControl
2022-02-04 13:46:21 +08:00
Apeksha Bhosale
a66b8be886
fix: enable response tab in js editor even if it has warnings (#10866) 2022-02-03 21:29:46 +05:30
Shrikant Sharat Kandula
6967c35531
fix: Disallowed IPs can be bypassed by using a CNAME/A record (#10868)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-03 21:23:04 +05:30
Abhijeet
2e5c1ea4ec
chore: Update doc urls for errors related to git (#10852)
* Update doc urls for errors and SSH key response
2022-02-03 21:13:40 +05:30
Abhijeet
7329d7ff23
fix: Fix NPE during import application when page ids are missing for published action and actionCollection (#10858)
* Provide a fallback pageIds for missing ones in action and JSObjects published version

* Add TC
2022-02-03 20:08:58 +05:30
Abhijeet
e356fd039f
chore: Commit only unpublished resources to git repo which includes queries, JSObjects, pages to avoid data duplication (#10776)
* Commit only unpublished resources to avoid resolving merge conflicts twice

* Added TCs

* Update directory names, fix pull issue in JSObjects
2022-02-03 11:47:57 +00:00
rashmi rai
e73ccc7f25
fix: props is now required in type Validator (#10854) 2022-02-03 15:27:08 +05:30
Keyur Paralkar
da638d7f2b
Updated Template (#10853)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2022-02-03 15:23:56 +05:30
Tolulope Adetula
94dbd612c3
fix: onOptionChange on TreeSelects and fix Switch Toggle (#10632)
* fix: treeSelect onoptionChange

* fix: revert cypress

* fix:switch widget toggle

* fix: remove Important from styling
2022-02-02 23:57:49 -08:00
Sumit Kumar
6f83df976d
feat: add sorting and pagination features to S3 plugin (#10736)
* add sorting and pagination features to S3 plugin
2022-02-03 06:15:01 +00:00
Keyur Paralkar
45152272a6
fix: added sentry exception for invalid DynamicBindingListPath (#10790)
* fix: added sentry exception for invalid DynamicBindingListPath

* refactor: updated the error message

* test: update unit test case for dynamic binding path error

* fix: addressed review comments

* fix: removed widgetFactory and propertyPane code for invalidDynamicBindingPath function
2022-02-03 11:22:14 +05:30
Abhijeet
0b1a8ad20b
fix: Update ApplicationPageId with defaultPageId while fetching applications for homepage (#10812) 2022-02-03 10:56:35 +05:30
Bharat Patodi
743d6cb00d
chore: Replace equality and inequality operators with their strict versions (#7585)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-03 09:42:38 +05:30
Satish Gandham
fa32411383
chore: Perform perf tests on a large app (#10831)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-03 00:25:10 +05:30
Daniel
d29016590b
Merge pull request #10437 from appsmithorg/fix/name-of-undefined-datasource
fix: Name of undefined error in datasource catch Block
2022-02-02 19:53:11 +01:00
albinAppsmith
1c7a4f4a48
fix: Execute query overflow scroll issue (#10836) 2022-02-02 23:50:45 +05:30
Nidhi
f450ea5be3
fix: Fixed issue with H2 where PS parameters were getting merged if the keys were the same (#10805) 2022-02-02 17:43:53 +00:00
Vicky Bansal
a39176dc38
fix: add keywords to the validation list (#10690) 2022-02-02 21:05:42 +05:30
Mojtaba
170c263f9c
Merge pull request #10711 from appsmithorg/fix/9221-mysqlPlugin_user_with_empty_password
fix(mysqlPlugin): MySQL allow empty password if user is not empty
2022-02-02 18:39:51 +03:30
Segun Daniel Oluwadare
a91b7c2a2b fix: add default value 2022-02-02 16:03:34 +01:00
Danieldare
cf577f8751 fix undefined error 2022-02-02 16:03:33 +01:00
Daniel
ec1c3c9fb8
Merge pull request #10664 from appsmithorg/fix/db-section-overlap
fix: Datasources section overlap
2022-02-02 15:49:03 +01:00
Tolulope Adetula
bb2f7da823
feat: Select and Multiselect V2 (#10359)
* fix: Select V2

* Fix: CI Fail

* fix: failing test

* fix: failing test

* Fix: MultiSelect

* Fix: loading issue

* Fix: loadin state

* Fix: loading

* fix: failing test

* fix: evaluation tests

* Fix: failing tests

* Fix: failing test

* fix: failing tests

* Fix: Failing tests

* fix: select All

* fix: filtering

* Fix: filtering

* fix: refactor Select widget

* fix: hide MultiSelect

* fix: select options

* Fix: failing tests

* fix: failing tests

* Fix: issues

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* fix: PR reviews

* Update EntityDefinitions.ts

* Fix: issues

* fix: console

* fix: QA issues

* fix: options issues

* fix: add widget icons

* fix: update Selectv2

* empty commit to fix CI

* fix: failing test
2022-02-02 06:15:07 -08:00
Daniel
45816c51f1
Merge pull request #10652 from appsmithorg/fix/delete-icon-s3-amazon-page
fix: Change delete icon in s3 amazon where clause component
2022-02-02 04:59:45 -08:00
Vicky Bansal
b99a42acdf
fix: add pre-filled option on adding an option to a checkbox or radio button (#10544) 2022-02-02 17:40:40 +05:30
Danieldare
54e2f2e9b1 fix: revert delete icon name 2022-02-02 12:00:01 +01:00
Danieldare
cfc89819a8 fix: remove unused icon 2022-02-02 12:00:01 +01:00
Danieldare
43b77d08af fix: change delete icon 2022-02-02 12:00:01 +01:00
Danieldare
532ec5768c fix: datasources section overlap 2022-02-02 11:54:56 +01:00
Ankita Kinger
da68425a57
Merge pull request #10801 from appsmithorg/hotfix/team-settings-page
fix: Multiple API calls on Team settings page for same user role selection
2022-02-02 15:16:39 +05:30
rahulramesha
d1de691790
change reflow BETA Card (#10789) 2022-02-02 15:16:06 +05:30
Abhinav Jha
e08c7e66d4
fix: Purge orphaned paths from dynamic path lists in widgets (#10803)
- Paths in dynamicBindingPathList and dynamicTriggerPathList which don't exist in the widget, may cause issues later in the lifecycle of an application. Purging these orphaned paths during property updates.
2022-02-02 14:55:16 +05:30
Nidhi
bc93a1d413
fix: Removed filter of JS actions from get method (#10726) 2022-02-02 08:28:41 +00:00
Nidhi
b02a7f53f6
fix: Disabled generate CRUD page feature for MsSQL (#10811) 2022-02-02 08:27:59 +00:00
Rishabh Saxena
812da166e0
chore: beta tags for git sync (#10774) 2022-02-02 13:22:37 +05:30
Tolulope Adetula
ea1ba54603
fix: test case (#10804)
* fix: test case

* fix: dsl

* fix: DSL

* fix: test
2022-02-01 23:52:05 -08:00
Keyur Paralkar
2ec0d2b02a
fix: Updated Template (#10694)
* Updated Template

* Updated Template

* Updated Template

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2022-02-02 12:50:21 +05:30
Parthvi12
283ef050d4
test: Fixed flaky tests Replay_editor and Table_navigateTo_validation_spec (#10772)
* Fixed flaky tests Replay_editor_spec and TableWidget_NaviagateTo_Validation_spec

* adding fix for ActiveDatasource.spec
2022-02-02 10:52:10 +05:30
ankurrsinghal
c349f2f9f5
Merge pull request #10688 from appsmithorg/enhancement/focus-widget-title-on-f2
feat: added a keydown listener to focus property pane title on pressing f2
2022-02-02 10:51:46 +05:30
arunvjn
52f979cbf6
Fixes inconsistent rename behaviour for datasources (#10767) 2022-02-02 05:21:25 +00:00
Ankita Kinger
28e9f90f8b Merge branch 'release' of https://github.com/appsmithorg/appsmith into hotfix/team-settings-page 2022-02-01 18:19:16 +05:30
Ankita Kinger
98dea5e64a updated conditional check 2022-02-01 18:19:07 +05:30
Shrikant Sharat Kandula
b1997b8b08
fix: Disallow access to instance metadata hosts (#10797)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-01 18:07:08 +05:30
Ankita Kinger
6ef90973c5 Merge branch 'release' of https://github.com/appsmithorg/appsmith into hotfix/team-settings-page 2022-02-01 18:06:27 +05:30
Ankita Kinger
34da849cbd avoiding multiple API calls on selecting same role for a user under manage users 2022-02-01 18:06:10 +05:30
Bhavin K
4e28b4887c
Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770)" (#10786)
This reverts commit df1ee35992.
2022-02-01 15:43:20 +05:30
Tolulope Adetula
8729c2b435
fix: select treeselect value validation (#10760)
* fix: Select adn treeSelect validation

* fix: remove cy.wait()
2022-02-01 10:54:16 +01:00
Mojtaba Zarezadeh
d1ddebd3d8 merge all tests in one file 2022-02-01 13:02:53 +03:30
Bhavin K
df1ee35992
fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770) 2022-02-01 13:37:52 +05:30
Mojtaba Zarezadeh
8197ebf297 fix: add single imports 2022-02-01 10:32:55 +03:30
Favour Ohanekwu
caca4131e7
fix: Evaluate PrivateWidgets to fix list widget children evaluation issue (#10737) 2022-02-01 10:48:57 +05:30
Vicky Bansal
8e174f7316
chore: Fix recaptcha script not loading issue (#10764) 2022-01-31 21:25:58 +05:30
Abhijeet
6b1e3fe7c0
fix: Add branch param for redirect url while authorising Google Sheet when application is connected to git (#10715)
* Add branch param in the redirect url
2022-01-31 10:11:12 +05:30
Rishabh Saxena
2e92b3a05e
chore: increase axios timeout for git specific APIs (#10732) 2022-01-31 09:48:58 +05:30
Abhijeet
8c4d711f5b
chore: Make sure to keep forked application in valid state even if client exits the flow before server responds (#10704) 2022-01-30 17:43:35 +05:30
Rishabh Saxena
c0285eb168
chore: use documentation link from the error response for git errors (#10662) 2022-01-29 13:56:27 +05:30
albinAppsmith
5cfe12bcea
feat: Entity explorer UI redesign (#9811)
Co-authored-by: arunvjn <arun@appsmith.com>
2022-01-29 12:56:19 +05:30
Daniel
20f5a7f7d3
Merge pull request #10681 from appsmithorg/fix/authenticated-api-query-parameters
fix: Add query parameters to Options/Form
2022-01-28 05:03:33 -08:00
Shrikant Sharat Kandula
d3d1f8bbf9
Clear sessions on password reset (#9955)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Nayan <nayan@appsmith.com>
2022-01-28 16:49:00 +05:30
Shrikant Sharat Kandula
cc3ab115b5
Remove CORS config as it's unused now (#10312)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-01-28 16:48:04 +05:30
Rishabh Rathod
b61ceab94b
fix: Add meta to eval cycle and update it when default changes (#10401)
* Rearrange data tree widget factory

* Remove existing handling of default value override

* Altternate way of meta property override

* Fix tests

Co-authored-by: hetunandu <hetu@appsmith.com>
2022-01-28 16:40:05 +05:30
Mojtaba Zarezadeh
e400ea0e80 cleanup: improve comments 2022-01-28 13:03:07 +03:30
Favour Ohanekwu
d5a459be30
fix: show lint warning when unused variable is present in code (#10599) 2022-01-28 09:18:19 +01:00
Mojtaba Zarezadeh
6d3be8c283 fix(mysqlPlugin): allow empty password if user is not empty 2022-01-28 11:43:21 +03:30
Abhijeet
07082f6bde
fix: Copy evaluation version for cloned application from the source application to fix dynamic binding evaluation to support escaped characters without double escapes (#10702) 2022-01-28 08:07:59 +00:00
Bhavin K
45d3704dda
fix: icon button remove default green (#10573) 2022-01-27 19:07:13 +05:30
Ankur Singhal
842828b187 added a keydown listener to focus property pane title on pressing f2 2022-01-27 16:40:57 +05:30
Yash Vibhandik
35d46b42d4
fix: #10428 styling support in popup (#10487) 2022-01-27 15:37:05 +05:30
Favour Ohanekwu
db3e29e15d
fix: Fix crash on broken list widget (#10670) 2022-01-27 15:31:24 +05:30
rashmi rai
10b3fe3800
feat: Validations for Action Forms (#10457) 2022-01-27 15:20:05 +05:30
Rishabh Rathod
d3c2833c8c
chore: remove defaultSelectedFiles (#10586)
- It is not being used anywhere
2022-01-27 09:40:51 +00:00
Danieldare
5cfc81a9d3 fix: add query parameters to options 2022-01-27 10:04:27 +01:00
Aman Agarwal
aab77b8ebb
fix: Memoized the Form Control Component reducing unwanted re-rendering (#10553)
* fix: reduced unnecessary re-rendering of form components

* fix: memoized form control and moved config errors to selector logic
2022-01-27 14:09:21 +05:30
Tolulope Adetula
b89c3100e4
fix: RTE required field (#10629) 2022-01-27 00:37:50 -08:00
Abhijeet
8d93d06317
feat: Add reference doc url for error responses for git APIs (#10620)
* Added reference doc urls for pull conflicts

* Update TCs
2022-01-27 13:08:21 +05:30
Bhavin K
dfaddfbce4
fix: Datepicker closeOnSelection will now remain true by default for new widget drops(#10479) 2022-01-27 11:42:39 +05:30
Anagh Hegde
e0e4a73650
fix: Logic to delete stale git branch which are not in db (#10647) 2022-01-26 21:29:00 +05:30
Anagh Hegde
c83f7fb3c1
feat: Git import api (#10282)
* Added API to generate deploy keys and store them in a collection for import flow

* Add tests for the key generation flow

* Move the key generation to helper class

* changes per review

* Fix bad merge

* add api to import application

* handle timeout for git import

* Update the comments

* Add API for git import

* handle duplicate application name error & add profiles while importing

* Add tests for import api

* Hydrate from file system after cloning the repo

* Fix test failures

* Test cases

* changes per review

* throw error when the datasource with same name of different type exists

* Fix test failures

* Fis error messages

* Fix test failures

* Fix issue with checking the datasource types

* Add datasource name check while importing the application

* Refactor SSH key gen code for import

* Resolve issues around defaultResourceIds, don't commit app name

* Resolve the issue related to duplicate name for app during import

* Minor fixes

* WIP

* Add logic to get unconfigured datasources for the application

* Fix tests

* WIP

* revert datasource related changes

* Add a boolean flag to Datasource entity

* Add a boolean flag to Datasource entity

* Add flag to identify import status

* Set application name before importing from json files in git-import

* update the variable name

* changes per review

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2022-01-26 21:26:22 +05:30
Abhijeet
0183897d5a
chore: Update mongo indexes to improve the query performance (#10658)
* Add index for JScollection, action and userData

* Refactor
2022-01-26 21:24:56 +05:30
Nidhi
c7d1e87c0a
fix: Removed tracking on Sentry for unsupported plugin operation (#10636) 2022-01-26 19:02:48 +05:30
Abhijeet
231c3aaeb7
fix: Bugfix for curl import when the request is made from the child branch for git-connected application (#10638)
* Fix for curl import in sub-branch

* Added comment
2022-01-26 18:20:49 +05:30
Daniel
d553495d23
Merge pull request #10321 from appsmithorg/fix/active-datasoure-flash-page
fix: Active datasource page flashes to user upon clicking the Save DataSource Button.
2022-01-26 11:42:36 +01:00
Sumit Kumar
610d665aae
add query params to form.json (#10574) 2022-01-26 12:59:07 +05:30
Anagh Hegde
341bc61e8c
feat: Add logic to sync the repo if the path is not updated in env file (#10478)
* Add logic to sync the repo if the path is not updated in env file

* changes per review

* checkout branch locally when the branch is not present in remote

* Add the local checked out branch to list
2022-01-26 12:55:07 +05:30
Keyur Paralkar
5afff85e8d
fix: changed validation to FUNCTION for the default selected value RadioGroupWidget (#10020)
* fix: changed validation to FUNCTION for the default selected value RadioGroupWidget

* refactor: changed evalued struct msg for radio group default value

* test: added cypress test for checking radiogroup widget with integer value

* test: added jest test to validate the defaultValidation function for radio widget

* refactor: changed the test case title

* chore: updated yarn.lock file

* refactor: addressed the review comments

* refactor: added comment for defaultOptionValidation

* refactor: changed the expected example [QA comment]

* fix: added validationOperationType prop

* Revert "fix: added validationOperationType prop"

This reverts commit 896226fe940621c2c71aa8a9e87831039a9655de.

* fix: added custom validation for the options property

* fix: modififed the custom validation logic

* refactor: modified the cypress test

* refactor: addressed review comments

* refactor: addressed review comments

* refactor: addressed review comments; Updated custom validation for DSV; Update cypress

* refactor: added boolean check for the default selected value

* refactor: addressed review comments

* test: fixed jest test case
2022-01-26 12:48:13 +05:30
Shrikant Sharat Kandula
6accb9e364
fix: Use CDN for all assets (#10417)
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-26 02:19:43 +05:30
Ashok Kumar M
2a8e37bf3b
feat: Sliding Canvas for Dragging and Selection (#9983)
* Move existing canvas's to CanvasArenas folder

* moving hooks to canvas arenas folder.

* Sticky canvas implementation.

* fixing specs(WIP)

* dip

* fixing test cases.

* removing comments.

* fixing build

* renaming for readability.

* adding folder for canvas based sagas.

* Resolve conflicts.

* fixing failed cases.

* fixing cypress cases.

* fixing bugs introduced coz of drag and drop.

* fixing bugs.

* few more bug fixes in draw to select.

* mouse pointer default when drag to select.

* bug fix.

* dip

* integrating intersection api.

* dip need to adjust offset

* fixing offset issues.

* readability fix

* rebase bug fixes.

* bug fix.

* adjust canvas slider on mouse over.

* unwanted changes.

* left offset fix + removing dead code.

* fixing bugs.

* fixing broken test cases.

* addressing code review comments.
2022-01-25 20:58:31 +05:30
NandanAnantharamu
91986714f6
test: commenting out Typescript tests (#10619) 2022-01-25 20:21:54 +05:30
dependabot[bot]
113c96dc54
chore: bump h2 from 2.0.206 to 2.1.210 in /app/server/appsmith-interfaces (#10554)
Bumps [h2](https://github.com/h2database/h2database) from 2.0.206 to 2.1.210.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/compare/version-2.0.206...version-2.1.210)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-25 19:38:36 +05:30
NandanAnantharamu
5245984ff8
test: Table Download test (#10571)
* Table Download test

* updated test
2022-01-25 19:37:51 +05:30
Confidence Okoghenun
98a8aab728
feat: Adds code hint for JS promises in JS Object editor (#10570) 2022-01-25 19:34:10 +05:30
akash-codemonk
94d37f55dd
feat: improved guided tour (#9125) 2022-01-25 19:26:52 +05:30
Ankita Kinger
e30fec9109
fix: Incorrect member list sorting on user roles (#10594) 2022-01-25 19:25:32 +05:30
Nayan
bb9010d875
fix: fetch user by case insensitive email for oauth login (#10350)
When an user signs up, we store the email in lower case. When user logins with oauth2, we fetch user by email ignoring case. This creates a problem if email from oauth is in upper case. As users are registered with lowercase and we're trying to fetch with upper, users are not found.
This PR fetches user by case insensitive emails during oauth login.
2022-01-25 13:54:50 +00:00
Bhavin K
b52ec44966
fix: changed cap default to fix ux issue on js toggle (#10424)
* fix: changed cap default to fix ux issue on js toggle

* fix: hard check on capSide hide

* fix: always show capSide if dynamic capType

* docs: label, help text update

* fix: remove hidden condition
2022-01-25 13:54:36 +00:00
Bhavin K
cd02572374
fix: table column name migration update (#10383)
* fix: table column name migration update

* test: added test case for migration

* fix: migration version update

* fix: update latest version logic

* fix: cypress updated

* fix: updated test case

* fix: delay added

* fix: test case update

* fix/ one more custom column added
2022-01-25 13:54:13 +00:00
Apeksha Bhosale
5f91f2d20f
added functions while checking isAsync (#10425) 2022-01-25 13:53:53 +00:00
ankurrsinghal
3e0749c82f
fix: hover highlight for menu item (#10610)
Co-authored-by: Ankur Singhal <ankursinghal@Ankurs-MacBook-Pro.local>
2022-01-25 15:15:52 +05:30
Leo Thomas
aec120bc3c
fix: Spaces in Google Sheet name (#10605) 2022-01-25 10:52:40 +05:30
rahulramesha
302cdf0d03
fix: Reflow onboarding typo fix (#10543)
* fixing reflow on boarding typo
2022-01-21 20:08:47 +05:30
Favour Ohanekwu
1b858bcf5c
fix: Remove private widgets from autocompletion (#10535) 2022-01-21 13:08:40 +01:00
Ashok Kumar M
6bc1bdd5e1
fix: Fixing GRID_DENSITY_MIGRATION_V1 based configs and adding test cases. (#10488) 2022-01-21 15:49:10 +05:30
Bhavin K
9976cb5018
fix: handle no color as transperant (#10498) 2022-01-21 15:31:30 +05:30
rahulramesha
1b2295d31f
react spring upgrade (#10427)
Upgrading react-spring
2022-01-21 11:42:46 +05:30
akash-codemonk
978e820b9f
fix: page settings invoking onClick on drag (#10449) 2022-01-21 11:35:27 +05:30
Nidhi
44f5e353fa
fix: Fix typo in default resources ids for actions within collections while creating new collection (#10349)
* fix: Small fix in default resources for actions within collections

* Added tests
2022-01-20 18:17:34 +00:00
Leo Thomas
58b376fa9b
fix: Fix 10463 js object cloning issue (#10523)
* fixes js object cloning issue

* fix10463- JSObject returning new name of cloned object

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-01-20 22:02:11 +05:30
Anagh Hegde
31f02df54f
Use the authorName as committer to avoid the inconsistency with name in git clients (#10518) 2022-01-20 19:49:36 +05:30
Rishabh Rathod
10e64df1e5
chore: S3 Template (#10461)
* Updated Template

* Updated Template

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2022-01-20 14:07:05 +00:00
Favour Ohanekwu
f7ce277e4c
fix: currentItem showing error in debugger for list widgets (#10338) 2022-01-20 11:59:03 +01:00
rahulramesha
b6bcfec549
chore: Reflow Info Card (#10481)
* removing reflow flag and adding Reflow Info card

* verbage correction

* adding reflow docs link
2022-01-20 14:59:09 +05:30
Leo Thomas
d5d37a512f
fix: Prevent Google Sheet bulk insert from overwriting existing rows (#10435)
This PR fixes the issue when bulk inset of data overwrites existing rows
Fixes #5076

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-01-20 10:33:30 +05:30
Abhijeet
62b720ab00
feat: Add documentation URL alongwith the error response to offer more info about the exception (#10325)
* Add doc url param in error response

* Modify TCs

* Update error codes to follow the sequence
2022-01-20 02:48:43 +00:00
Abhijeet
0ec6875b47
fix: Fix clone JSObject issue where cloned JSObject gets attached to both parent and cloned page and fix race condition for delete action when trying to delete page with JSObject (#10455)
* Fix clone JSObject issue where cloned JSObject gets attached to both parent and cloned page

* Race condition for delete action when trying to delete page with JSObject

* Set published collection to null during fork application
2022-01-19 17:06:27 +00:00
Aishwarya-U-R
067d18a84e
test: Skipping JSObjectToListWidgetSpec.ts until open bug is fixed (#10477)
This PR skips tests from JSObject_To_ListWidgetSpec.ts until Bug #10284 is fixed
2022-01-19 17:37:30 +05:30
Bhavin K
832622a221
fix/datepicker derived property condition updates (#10353)
- fixed mix / max date validation error on datepicker
2022-01-19 16:29:08 +05:30
Parthvi12
69fabb908b
Automated mongoDB app with CRUD operations (#10409) 2022-01-19 13:55:14 +05:30
Bhavin K
63ce7e108a
fix: changed height calc for embeded app page (#10440) 2022-01-19 11:48:11 +05:30
Abhijeet
a48aa9c72b
feat: Remove action and actionCollection ids in exported application JSON (#10430)
* Export action and actionCollection without actual ids

* Added TC

* Comments
2022-01-19 11:46:32 +05:30
Abhijeet
3471de90cd
fix: Gracefully handle defaultResourceIds exception (#10454)
* Gracefully handle defaultResourceIds exception

* Added TCs

* Remove sentry logs
2022-01-19 10:45:36 +05:30
Tolulope Adetula
70cff3c373
fix: Copy and paste (#10422)
* fix: Copy and paste

* fix: test cases

* fix: onPaste action

* Update index.tsx
2022-01-18 19:54:34 +01:00
Parthvi12
a8eb1d838b
test: Adding fix for Chart_Widget_Loading_spec (#10462)
* Adding fix for Chart_Widget_Loading_spec

* adding wait after reloading

* commenting delete datasource part

* updating test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-01-18 21:07:29 +05:30
Arsalan Yaldram
de3298ae9c
feat: Added Circular progress Widget (#10244)
* Added Circular Porgress Widget

* Updated the svg icon for the widget.

* Added strokeLineCap prop to the widget.

* Added Rounding for percent values.

* Review Changes completed. Removed un-necessary props, added Default Values.

* App crashes when a modal has a filepicker? (#10376)

(cherry picked from commit f646eeafc1)

* Revert "chore: Don't take client subscription into account for fork application (#10220)" (#10375)

This reverts commit 814a7d57f9.

* Added widget entries in TernServer files.

* Added Radial Separators.

* Removed Steps Functionality.

* Added isJSConvertible to progress property.

* Resovled eslint error under EntityDefinition.ts

Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
2022-01-18 14:36:14 +00:00
Ayangade Adeoluwa
28a3f59452
feat: Displays validation errors corresponding to a particular form control. (#10365)
* initial implementation, still WIP

* Cleaning up implementation

* added types for evaluation errors and error handling

* remove unneccessary console.log

* better naming for variables

* add unique identifier for error text

* add unique identifier for error text message
2022-01-18 13:09:04 +01:00
Ayangade Adeoluwa
f9e8c84fcd
fix: Fixes UI inconsistencies on the app (#10433)
* Fixes UI inconsistencies on the app

* using a better implementation
2022-01-18 10:09:34 +01:00
balajisoundar
02785b90b2
feat: Input, Phone no., Currency input widget (#10259)
* feat: Input, Phone no., Currency Widget

* cypress tests, jest test, QA and CR callouts

* fix tests

* Cypress and jest test fixes
2022-01-18 13:22:24 +05:30
Keyur Paralkar
d88022939e
fix: added loading state for chart widget (#10262)
* fix: added loading state for chart widget

* test: added cypress tests

* refactor: moved the loading logic from widget to component
2022-01-18 13:21:28 +05:30
akash-codemonk
541e105b07
fix: Signposting intro modal UI issue (#10403) 2022-01-18 12:42:52 +05:30
Abhijeet
1ed1bf0e5d
feat: Apply JSON schema migration while importing the application using JSON file (#10339)
* Json schema version check added before importing an application

* Added TC

* Fieldname refactor to make it more relevant
2022-01-18 07:11:23 +00:00
Ayush Pahwa
a6d2d6fd89
feat: 5705 entity selector component (#10400)
* Added new files for entity selector component

* Add error handling to data fetched via API

* Added init eval for schemas in entity selector

* Extracting conditionalOutput for schema from state and passing it to individual schema

* Removed unnecessary loop

* Fixed CSS of ES, added new Icon

* Minor refactor
2022-01-18 07:10:58 +00:00
Pawan Kumar
8e03dae88e
fix http issue in filepicker v1 too (#10426)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-01-17 10:34:45 +00:00
Parthvi12
4871035742
test: Adding fix for Table_widget_add_button spec's test (#10423)
* Adding fix for Table_widget_add_button spec's test

* updating test

* commenting changing column type to button in second test
2022-01-17 15:00:58 +05:30
Paul Li
fa29fef4a5
fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode (#10356)
* fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode

-- Make header options JS convertible

* fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode

-- Fix a broken test case accordingly
2022-01-16 15:04:24 +08:00
Shrikant Sharat Kandula
f2d26db290
Use CDN for plugin icons (#10393)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-01-15 12:54:30 +05:30
dependabot[bot]
bfc6b1f29b
chore: bump follow-redirects from 1.13.0 to 1.14.7 in /app/client (#10371)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.13.0...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-15 12:42:25 +05:30
dependabot[bot]
a033cd3a19
chore: bump postcss from 7.0.35 to 8.2.13 in /app/client (#10246)
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 8.2.13.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.35...8.2.13)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-15 12:41:36 +05:30
Snyk bot
4bc56cb99e
chore: [Snyk] Security upgrade node-sass from 7.0.0 to 7.0.1 (#10016)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-15 04:25:27 +05:30
dependabot[bot]
7d64d7fa53
chore: bump h2 from 2.0.202 to 2.0.206 in /app/server/appsmith-interfaces (#10414)
Bumps [h2](https://github.com/h2database/h2database) from 2.0.202 to 2.0.206.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/compare/version-2.0.202...version-2.0.206)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-15 04:13:05 +05:30
dependabot[bot]
4b3527e472
chore: bump follow-redirects from 1.14.5 to 1.14.7 in /app/rts (#10370)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.5...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-15 03:47:34 +05:30
dependabot[bot]
d73b075aa2
chore: bump follow-redirects from 1.14.3 to 1.14.7 in /app/server/scripts/node (#10413)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.3 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.3...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-15 03:43:12 +05:30
Snyk bot
65b5b61840
chore: [Snyk] Security upgrade com.h2database:h2 from 1.4.200 to 2.0.202 (#9500) 2022-01-15 03:37:21 +05:30