Commit Graph

8624 Commits

Author SHA1 Message Date
Anand Srinivasan
284571803b
fix: update settings pane validations (#18739)
* init fix

* button style update

* decode url in preview

* bring back custom slug validation

* custom slug validation on type

* remove imports

* handle special characters in url preview

* change label

* code clean up

* remove pageId from action name selector

* messages clean up

* tests for validations

* cypress cases update

* Renamed helper methods

* add index for test cases

* AppSettings specs script ts updates

* Added Bud id in title #18698

* GIt Import spec fix

* GItImport spec fix

* Git import unskip

* Skipping Git import

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 10:21:14 +05:30
ashit-rath
f67f8571ec
refactor: JSONForm eliminate the use of canvasWidgets and remove childStylesheet from dynamicBindingPathList (#18715)
* refactor: JSONForm eliminate the use of canvasWidgets and remove childStylesheet from dynamicBindingPathList

* review changes

* fixed field reset on deploy

* reverted prevSourceData changes
2022-12-12 10:13:18 +05:30
akash-codemonk
a6df3a6deb
chore: add analytics for page creation ctas (#18676) 2022-12-12 10:12:17 +05:30
ankurrsinghal
432e513678
fix: modal deselect issue auto height (#18750)
modal deselect issue fixed when dynamicHeight property is changed
2022-12-11 20:51:46 +05:30
Aswath K
ce2925cafc
feat: Property pane search (#18164) 2022-12-11 20:12:32 +05:30
Ankita Kinger
9899eaa0c3
fix: Left panel not scrollable on Admin settings page when the list is too long (#18845) 2022-12-11 18:21:52 +05:30
sidhantgoel
4501434ede
chore: Synchronize Page,Action and ActionCollection object from original corresponding object (#18846)
Synchronize Page,Action and ActionCollection object from original corresponding object
2022-12-11 12:23:45 +05:30
rahulramesha
a1973b81a3
Fix: Context switching UX issues (#18828)
* fix Property panel jitters on focus

* open widget entity on widget selection

* Remove retaining Datasources url on page change

* fix param string while restoring URLs

* add cypress test
2022-12-10 23:59:36 +05:30
f0c1s
2ce9665b61
chore: add some more audit logs analytics (#18738) 2022-12-10 14:56:29 +05:30
Ankita Kinger
d9f20e33ad
chore: splitting the role name to avoid showing workspace name next to it (#18830)
* splitting the role name to avoid showing workspace name next to it

* fixing cypress tests failures
2022-12-10 14:00:28 +05:30
Shrikant Sharat Kandula
e12b865bf2
Fix logos in email templates (#18835)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-10 08:02:37 +05:30
Parthvi
aafaa8abfa
test: fix flaky tests (#18603)
* Update GitImport_spec.js

* fix flaky tests

* skip git import tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-12-09 19:46:51 +00:00
Ayangade Adeoluwa
aec6296e2c
fix: query command value from being reset to an empty state (#18559)
* Fixes query command value from being reset to an empty state

* Fix merge issues
2022-12-09 16:58:36 +00:00
Pawan Kumar
d7e2c491e0
feat: Branding (#18717)
* add branding for ce

* add ce changes

* update colorpicker ux

* remove unsued flag

* Add new email templates

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* add local appsmith logo

* code review feedback fixes + qa fixes

* remove forward slash in url of favicon

* fix message

* Fix tests

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* update messages

* Fix tests (again)

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* update messages

* fix cypress tests

* skipping app layout test cases

* fix cypress tests

* remove it.only

* try moving test

* use stable DS version

* remove __diff

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-09 20:13:47 +05:30
Satish Gandham
03703ff044
ci: Ship source maps + fix perf test failures on EE (#18700)
* - Add missing env variables to fix perf tests failures in EE

* - Delete source maps on CI only for EE

* - Add the additional steps that might be required for running perf tests on EE

* Update if condition

* Update if condition

* Switch to bash from using sh in build.sh

* Check if the server started later

* Update the check to see if the server has started

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-12-09 18:40:59 +05:30
Nirmal Sarswat
9f0b9ee94b
fix: Filtering out empty value env variables from /admin/env API response in backend (#18430)
* Filtering out empty value env variables from /admin/env API response in backend

* adding UT for getAllNonEmpty;
2022-12-09 17:17:26 +05:30
sneha122
c094a28c40
fix: gsheet multiline broken formatting fixed (#18552)
* gsheet multiline broken formatting fixed

* junit test added

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-09 15:53:55 +05:30
Sangeeth Sivan
ab00c3dda4
fix: hide workspace menu options trigger when there are no permissions (#18742)
* fix: variable mismatch fix

* fix: updated to use the right boolean flag

* fix: workspace menu order
2022-12-09 15:46:00 +05:30
sneha122
c460154c43
fix: datasource discard popup issue fixed (#18761)
* datasource discard popup issue fixed

* cypress code review changes

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-09 15:29:35 +05:30
Shrikant Sharat Kandula
cf81c14ec2
chore: Add multipart payload support for admin settings (#18434) 2022-12-09 13:46:14 +05:30
Souma Ghosh
0395457e51
feat: Add Series Colour property for default charts (#18229)
* Adds functionality for Series Color property

* fix an issue where chart was breaking when color property is not provided

* Changes Series Color field to Color Picker type input
Default color set as primary theme color

* Under development
- Some bug fixes to the series colour feature

* Fix issue with second series color not being applied correctly
New property placeholderText for ColorPickerComponentV2
Disable series color feature for Pie Chart
Code clean up
2022-12-09 12:47:21 +05:30
Anand Srinivasan
84426b9c41
chore: update smartlook client (#18784)
update smartlook client
2022-12-09 11:45:14 +05:30
Aishwarya-U-R
70f6cd1ab8
test: Automated tests for Bug18376 + few flaky fixes (#18769)
* ApiOnload spec fix

* Bug 18376 script added

* Bug 18376 script fix

* ValidateURL() added

* OnLoadTests/APIOnLoad_Spec.ts fix

* Moved Bug 16248 script

* JSOnload trial fix

* JsonLoad fix -disbaling not working hnce commented

* Skipping GitImport (merge issue-open bug 18776)

* Git imPort trial fix

* PassingParams spec update

* APIPage.ts wrong update corrected

* Removed added comments

* ApiPage.ts mistake corrected!
2022-12-09 10:36:52 +05:30
Ankita Kinger
df8add5e0c
chore: Updating the text from enterprise to business to maintain consistency (#18787)
* updating the text from enterprise to business to maintain consistency

* minor change

* Omnibar fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-09 00:08:42 +05:30
Aman Agarwal
1bcb321ec3
fix: gs quick wizard table header index (#18242)
* fix: gs quick wizard table header index

* fix: disable generate button if error

* Omni spex fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-08 22:20:51 +05:30
Vishnu Gp
a1702d9b2e
fix: Corrected action execution analytics event (#18783) 2022-12-08 21:05:34 +05:30
Hetu Nandu
3b98c8f7fe
feat: Command click navigation via code (#18326) 2022-12-08 17:46:41 +05:30
rahulramesha
3bb9e96e39
feat: [Context Switching] Complex widgets and other Phase 2 items (#17046)
This PR contains changes to retain context on the following items,
Leaving and then returning to a page should maintain what api/query was open
Entity explorer should stay as you left it when you left the page (collapse levels)
Widget/explorer tab
Width - Should be the same across all pages of an app
Property Pane width
Complex widgets, multi tier property panes

Co-authored-by: hetunandu <hetunandu@gmail.com>
Co-authored-by: Akash N <akash@codemonk.in>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-08 12:51:58 +05:30
Ankita Kinger
10bdbed0e3
refactor: Updating upgrade flows to start using upgrade hook for better code reusability (#18735)
* updated upgrade flow for authentication page to start using upgrade hook

* using the upgrade hook on upgrade pages as well

* adding RBAC feature flag
2022-12-08 10:48:03 +05:30
Ankita Kinger
a0211f5eed
fix: fetching the plugin form config for queries if datasource is not viewable (#18749)
fetching the plugin form config for queries if datasource is not viewable
2022-12-08 09:06:35 +05:30
Nilansh Bansal
669120b3a6
fix: fork template tracking (#18727)
fix: fork_APPLICATIONTEMPLATE event tracking added to merge template api (#18416)
2022-12-08 02:32:23 +00:00
Rishabh Kashyap
2213a61357
fix: resetting audio and video widget (#18126)
* bug for audio and video widget fixed

* cypress test for audio widget

* audio and video updated cypress tests

* cypress test cases updated

* writing logic for video widget

* working on video widget

* intermediate logic

* inbetween logic

* updateWidgetMetaProperty removed from onEnded event

* this.props.playing logic in onPlay & onPause events

* test code

* test code

* Add comment

* audio widget updated; comments for audio and video widget

* cypress changes

* removed cypress credentials

* comments updated

* change in comments and cypress test cases

* feedback incorporated

* comments added to audio and video spec files

* video spec updated

* video spec updated

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-12-07 20:40:28 +05:30
appsmithguru
b64df3e1c9
chore: rename_triggerUtils (#18405)
Refactored Renamed TriggerUtils.java to RestAPIActivateUtils.java and its usage
2022-12-07 15:03:50 +03:00
Tanvi Bhakta
9931d3cdc5
feat: update button states (#18335)
* fix: Form message component link issue

* removed the inverted flag for testing

* use updated design system

* category.tertiary -> category.secondary

* fix: Made changes to pass action link element to design system component - formMessage

* chore: update design-system version to access new tertiary button styles

* chore: update design-system version to use blacks instead of grays

* chore: bump design-system version to use buttons with explicit background color

* Remove rules that mess with border, background, text color on StyledPropertyPaneButton

* chore: update design-system version to use updated button categories across all ads components

Co-authored-by: Albin <albin@appsmith.com>
2022-12-07 11:44:30 +00:00
Souma Ghosh
b2f67e12bc
feat: update property name automatically when custom column name is changed (#18048) 2022-12-07 16:20:29 +05:30
Favour Ohanekwu
e37f7419b9
fix: Aggregate calls to add and remove Appsmith errors (#18285)
* Aggregate calls to add and remove Appsmith errors

* fix switch type

* Fix entity deletion errors

* Code clean up

* fix cypress tests

* Return early for empty errors in Appsmith debugger

* Remove redundant identifier

* Retain order of debugger logs

* Use push instead of unshift for perf reasons

* redundant commit to retrigger CI
2022-12-07 11:28:29 +01:00
dependabot[bot]
f3e37b9d1e
chore: bump express from 4.17.1 to 4.18.2 in /app/client (#18734)
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 13:20:56 +05:30
dependabot[bot]
d93d7ff5ee
chore: bump qs from 6.5.2 to 6.5.3 in /app/client (#18733)
Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 13:19:57 +05:30
Sangeeth Sivan
c0a7574772
fix: workspace context menu is not permission driven (#18642)
* fix: workspace context menu is now permission driven

* fix: remove action operation on global search if there are no file operations

* fix: hide more options when there are no options and refactor

* refactor: revert settings title changes in this PR

* fix: use manage permission for delete on CE

* fix: move delete workspace permission to EE

* fix: change in permissions

* Remove redundant share CTA from org menu

* fix: change of permissions for members and import/create new app

* Remove redundant invite users dialog

* Remove unused variables

Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 11:07:59 +05:30
dependabot[bot]
f3d4600d85
chore: bump decode-uri-component from 0.2.0 to 0.2.2 in /app/client (#18659)
* chore: bump decode-uri-component in /app/util/plugin-generation

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: bump decode-uri-component from 0.2.0 to 0.2.2 in /app/client

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-12-07 11:01:16 +05:30
dependabot[bot]
59fb886342
chore: bump decode-uri-component from 0.2.0 to 0.2.2 in /app/util/plugin-generation (#18658)
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/SamVerschueren/decode-uri-component/releases">decode-uri-component's releases</a>.</em></p>
<blockquote>
<h2>v0.2.2</h2>
<ul>
<li>Prevent overwriting previously decoded tokens  980e0bf</li>
</ul>
<p><a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2">https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2</a></p>
<h2>v0.2.1</h2>
<ul>
<li>Switch to GitHub workflows  76abc93</li>
<li>Fix issue where decode throws - fixes <a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/6">#6</a>  746ca5d</li>
<li>Update license (<a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/1">#1</a>)  486d7e2</li>
<li>Tidelift tasks  a650457</li>
<li>Meta tweaks  66e1c28</li>
</ul>
<p><a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1">https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="a0eea469d2"><code>a0eea46</code></a> 0.2.2</li>
<li><a href="980e0bf09b"><code>980e0bf</code></a> Prevent overwriting previously decoded tokens</li>
<li><a href="3c8a373dd4"><code>3c8a373</code></a> 0.2.1</li>
<li><a href="76abc93978"><code>76abc93</code></a> Switch to GitHub workflows</li>
<li><a href="746ca5dcb6"><code>746ca5d</code></a> Fix issue where decode throws - fixes <a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/6">#6</a></li>
<li><a href="486d7e26d3"><code>486d7e2</code></a> Update license (<a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/1">#1</a>)</li>
<li><a href="a65045724e"><code>a650457</code></a> Tidelift tasks</li>
<li><a href="66e1c2834c"><code>66e1c28</code></a> Meta tweaks</li>
<li>See full diff in <a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=decode-uri-component&package-manager=npm_and_yarn&previous-version=0.2.0&new-version=0.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/appsmithorg/appsmith/network/alerts).

</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-07 11:00:38 +05:30
balajisoundar
be997b240a
fix: show filter & show download properties should not control add new row link visibility in table widget (#18348) 2022-12-07 09:52:18 +05:30
balajisoundar
b8aa7b3a67
fix: table widget header links should have pointer cursor when hovered (#18262) 2022-12-07 09:50:18 +05:30
Rishabh Kashyap
2afc10387f
fix: add js for icon property in button group (#18524)
made icon js convertible
2022-12-06 23:02:43 +05:30
NandanAnantharamu
bbf896e389
test: Added test for bug fixed (#18135)
* Added test for bug fixed

* Commented a test
2022-12-06 21:59:05 +05:30
Trisha Anand
0cbb0e20c6
chore: Fetch pages in editor with READ permissions (#18722) 2022-12-06 21:06:04 +05:30
Hetu Nandu
473501c761
fix: Remove redundant share CTA from org menu (#18718) 2022-12-06 12:50:41 +00:00
Arsalan Yaldram
ad55928fc3
chore: Fix dropdown font family (#18693)
## Description

- Fix dropdown font family. 

Fixes  #18677 



## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-06 13:31:58 +05:30
Parthvi
bc7659d53a
test: Add dummy users in Cypress test suite (#18675) 2022-12-06 11:21:54 +05:30
Shrikant Sharat Kandula
e7b2e2392b
Fix NPE on reset password, and message formats (#18108)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-06 08:37:41 +05:30