Commit Graph

782 Commits

Author SHA1 Message Date
Bhavin K
244b089771
fix: added support for timePrecision (#9423) 2021-12-23 14:17:08 +00:00
balajisoundar
8d3e3fd88b
fix: remove allowed filetype restriction in filepickerwidget (#9921) 2021-12-23 18:46:57 +05:30
Keyur Paralkar
848bc13bc3
fix: corrected Index cond. for conditional formatting in table widget (#9735)
* fix: corrected Index cond. for conditional formatting in table widget

* test: added integration test for checking condtional formating post sorting

* refactor: enhanced the originalIndex condition with nullish coalescing op
2021-12-21 15:25:12 +05:30
balajisoundar
2796bf0baf
fix: handle undefined filterdata props in table widget (#9832) 2021-12-20 15:41:33 +05:30
Paul Li
f62c8a62a4
fix: checkbox group feedback (#6959)
* FIX-6783 : Checkbox group widget - Feedback

-- Add default border for a checkbox icon and color for a label
-- Align the option to the center if its options count is one or inline
-- Set isInline to true by default in widget config

* FIX-6783 : Checkbox Group Widget Feedback

-- Add a migration for isInline property

* Feat: Checkbox Groupd Widget Feedback

-- Add vertical margin between options

* Fix: Checkbox Group Widget

-- Increase default rows value to 1.5 in widget configuration

* Fix: Checkbox Group Widget

-- Change the migration version number

* Fix: Checkbox Group Widget

-- Change migration version number

* Fix: Checkbox Groupd Widget Feedback

-- Delete redundant WidgetConfigResponse file

* Fix: Checkbox Group Widget Feedback

-- Change the config values of rows, columns
-- Refactor migration file

* Fix: Checkbox Group Widget

-- Refactor migration file

* fix: Checkbox Group Widget Feedback

-- Fix on the wrong dsl version

* fix: Checkbox Group Widget Feedback

-- Remove a unnecessary comment
-- Update the version of the widget in its config and migration

* fix: checkbox group feedback

-- Rewrite a migration for isInline property

* fix: checkbox group feedback

-- Follow the figma design on disabled state

* fix: Checkbox Group Widget feedback

-- Apply appropriate migration

* fix: Checkbox group widget - Feedback

-- Apply theme changes

* fix: Checkbox Group Widget - Feedback

-- Change the border color of an unchecked checkbox to DARK_GRAY

* fix: Checkbox Group Widget - Feedback

-- Remove inset box shadow from the checkbox indicators

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 22:24:23 +08:00
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Bhavin K
f7e2e079a9
fix: 8336 updated isLoading property in all widgets (#9409) 2021-12-14 07:55:58 +00:00
Bhavin K
406255fcf6
fix : updated alignments (#9602) 2021-12-14 07:55:30 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
Paul Li
08b0e86967
feat: Change Map Pin Color on Map Widget (#8337)
* feat: Change Map Pin Color on Map Widget

-- Add a color property for a marker

* feat: Change Map Pin Color on Map Widget

-- Set #E0DEDE as default color

* feat: Change Map Pin Color on Map Widget

-- Revert to the original logic

* feat: Change Map Pin Color on Map Widget

-- Add a new base icon for a marker

* feat: Change Map Pin Color on Map Widget

-- Add anchor property for custom marker icon

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 13:43:29 +08:00
Vicky Bansal
39db055211
fix: use defaultTab as selectedTab when selectedTab property is not available on page load (#9487) 2021-12-10 14:15:03 +05:30
Tolulope Adetula
7f3c849876
fix: button variant table binding (#8712)
* fix: Table widget binding

* fix: binding property

* fix: Add binding and new validation

* fix: Control for Table Binding

* fix: revert new Validation type change

* fix: failing test

* fix: validation

* fix: validation issue

* fix: binging issue

* revert: control changes

* revert: control changes

* fix: binding issues

* revert: validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 04:12:42 -08:00
Paul Li
54579a4e6c
feat: Switch Group widget (#7590)
* Feat: Switch Group Widget

-- The first MVP of the widget

* feat: Switch Group Widget

-- Follow the same config and implementation as the other group widgets

* feat: Switch Group Widget

-- Elaborate the help text for defaultSelectedValues

* feat: Switch Group Widget

-- Add a widget icon

* feat: Switch Group Widget

-- Remove unnecessary property control at ItemsControl.tsx
-- Refactor some code snippets for higher code quality
-- Add basic cypress test cases

* fix: icon for the widget optimised & replaced

* feat: Switch Group Widget

-- Add a unit test for defaultSelectedValuesValidation

* feat: Switch Group Widget

-- Make the validation type for defaultSelectedValues property to ValidationTypes.ARRAY
-- Remove original validation function and its unit test

* feat: Switch Group Widget

-- Fix on typo
-- Fix on formatting issue
-- Change the help text for isRequired property

* feat: Switch Group Widget

-- Revert help text for isRequired property to the original one

* feat: Switch Group Widget

-- Set strict property to true on defaultSelectedValues

* feat: Switch group widget

-- Refactor utility function, getCamelCaseString
-- Add the corresponding test case

* feat: Switch group widget

-- Implement options property as a plain JS field
-- Reimplement update logic for selectedValues when options changes
-- Add a new utility function for checking equality of object arrays
-- Add a unit test for the above function
-- Rewrite the corresponding Cypress test cases

* feat: Switch Group Widget

-- Remove isArrayEqual utility function and directly use functions from lodash

* feat: Swtich Group Widget

-- Make selectedValues as a derived property

* feat: Switch Group Widget

-- Replace the widget icon

* feat: Switch Group Widget

-- Rewrite a test case for onSelectionChange property

* feat: Switch Group Widget

-- Remove redundant calls for openPropertyPane

* feat: Switch Group Widget

-- Remove closePropertyPane call from afterEach hook

* feat: Switch Group Widget

-- Change the selector for every switch element in onSelectionChange test case

* feat: Switch Group Widget

-- Fix on failed Cypress test case, adding closePropertyPane command to onSelectionChange

* feat: Switch Group Widget

-- Remove template literal from a selector

* feat: Switch Group Widget

-- Make click on onSelectionChange test case forced

* feat: Switch Group Widget

-- Fix on crash issue when editing on Options property

* feat: Switch Group Widget

-- Add the widget icon to show in entity explorer

* feat: Switch Group Widget

-- Fix on blue color on mouse down
-- Add a new property for alignment

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-12-09 20:02:47 +08:00
Tolulope Adetula
3e51c1173c
fix: negative spacing in list widget (#9571)
* fix: add validation for negative numbers and allow negative spacing

* fix: add validation test for negative numbers

* fix: validation tests

* fix: validation test

* fix: errors

* fix: grid gap

* fix: validation test
2021-12-09 02:01:11 -08:00
Nishi Agrawal
3e7123d11a
fix: Cursor turning to pointer upon onclick in deployed app (#8111)
* [fix]:cursor turning to pointer upon onclick in deployed app

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: cursor changing to pointer only if onclick event associated to image widget

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: build error, no used var

Signed-off-by: nishihere19 <nishihere19@gmail.com>

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 14:49:24 +05:30
Tolulope Adetula
4829820e86
fix: add enableClientSideSearch (#9505)
* fix: add enableClientSideSearch

* fix: add test

* fix: refactor function

* fix: filter issue

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 22:35:27 -08:00
Aswath K
177df5cc68
fix: table icon selector js mode toggle issue (#9396)
* fix: ARRAY validation with allowedValues

* Adds TABLE_PROPERTY validation

* Add test

* fix: Table icon JS mode toggle issue

* remove unused variable

* Make use of constant for icon

* Adds comment

* better validation

* fix: failed cypress test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 11:45:59 +05:30
Tolulope Adetula
af08547529
fix: Select widget Value (#9444)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 11:14:53 -08:00
Vicky Bansal
3ac913a12c
feat: Row selection in Table widget using Primary Column (#8156) 2021-12-08 19:36:14 +05:30
Bhavin K
4889098888
fix: added placement support in button, button group, and menu widget (#9354) 2021-12-08 13:11:13 +00:00
balajisoundar
ef488f1f7a
fix: Empty column name check before computing dynamicBindingPathList in Table widget (#9466) 2021-12-08 11:24:31 +05:30
Pawan Kumar
f33758d871
remove reset on text widget (#9594)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-12-07 15:59:04 +05:30
Keyur Paralkar
6e986f9e50
fix: undefined evaluted value text widget (#9521)
* fix: evaluted value undefined for text widget

* test: added cypress spec for cell background and text size change validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-07 10:24:19 +05:30
Yash Vibhandik
9b3b1f5196
fix: 7487 added allowSelectAll option in property pane (#9536)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-06 11:26:44 +05:30
Bhavin K
62a0f0c952
fix: ButtonGroupWidget button variant validation updated (#9454) 2021-12-06 11:07:29 +05:30
Tolulope Adetula
5ec470e3c6
fix: selected row issue (#9445)
* fix: selected row issue

* fix: add tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-03 06:15:23 -08:00
imgbot[bot]
81ccdbaede
chore: [ImgBot] Optimize images (#9544)
*Total -- 1,062.82kb -> 832.92kb (21.63%)

/contributions/assets/widgetConfig.png -- 422.37kb -> 324.12kb (23.26%)
/contributions/assets/propertyConfig.png -- 449.61kb -> 350.59kb (22.02%)
/contributions/assets/widgetFolder.png -- 180.78kb -> 148.29kb (17.97%)
/app/client/src/assets/icons/comments/pin_3.svg -- 0.41kb -> 0.39kb (5.21%)
/app/client/src/assets/icons/comments/unpin.svg -- 0.53kb -> 0.51kb (4.02%)
/app/client/src/assets/icons/form/trash.svg -- 2.81kb -> 2.76kb (1.88%)
/app/client/src/assets/icons/control/copy.svg -- 0.88kb -> 0.87kb (1.55%)
/app/client/src/assets/icons/header/hamburger.svg -- 0.22kb -> 0.21kb (1.35%)
/app/client/src/assets/icons/ads/double-arrow-right.svg -- 1.07kb -> 1.06kb (1.28%)
/app/client/src/assets/icons/widget/text.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/widgets/DocumentViewerWidget/icon.svg -- 0.96kb -> 0.96kb (0.61%)
/app/client/src/assets/icons/ads/double-arrow-left.svg -- 1.05kb -> 1.04kb (0.28%)
/app/client/src/assets/icons/comments/eye.svg -- 1.39kb -> 1.38kb (0.21%)
/app/client/src/assets/icons/control/help.svg -- 0.48kb -> 0.48kb (0.2%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-03 12:47:23 +05:30
Anand Srinivasan
4ced0954db
feat: Syntax parsing through AST (#9115)
* ast changes

* ast fix for cyclic dependency

* jest test updates for ast

* feat: Extract references in code with AST (#8617)

Co-authored-by: Nidhi <nidhi@appsmith.com>

* undo debugger changes

* code clean up and comments

* update type checks for literal nodes

* include tests for IIFE and direct object access

* fix - dependency map not updated on IIFE/direct object access

* update tslib

* unescape on AST parsing

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
2021-12-02 15:33:43 +05:30
Bhavin K
2ade131ebf
fix: button group cursor in case of disable (#9481) 2021-12-02 14:15:46 +05:30
Keyur Paralkar
ba5262df2c
fix: fixed the default value of zero not present in parent form data on pageload (#9324)
* fix: fixed the default value of zero not present in parent form data on pageload

* test: added cypress test for Checking default value 0

* refactor: changed the DSL and added reset condition at the end of test

* refactor: removed the proxy variable

* refactor: corrected the typo
2021-12-02 11:36:24 +05:30
Tolulope Adetula
809a288bdc
fix: popups same width as parent (#7499)
* fix: select widget popup

* fix: select widget

* fix: Menu button

* fix: make Clear Var names

* fix: consistent dropdown width

* fix: define variable better

* fix: prettier error

* fix: variable name

* fix: select popup issue

* fix: PR issues add comments

* fix: remove unused css

* fix: add tests

* fix: more pop overs

* fix: menu button popup

* fix: Multiselect dropdown

* fix: failing test

* fix: add more tests

* fix: Failing Test
2021-11-30 02:38:46 -08:00
Bhavin K
6ea90e7c7b
feat: add document viewer widget (#7666)
* created new widget

* new lib for document viewer

* added cypress tests

* updated icon

* handling different url types with viewer

* add to ignore react-documents in jest transformIgnorePatterns

* added jest test, updated comments

* required changes

* updated cypress test

* updated icon svg

* doc viewer new renderers added

* comment as required

* updated test case

* added url / base64 validations

* updated url checking condition for space and updated test case

* cypress selector update

* updated url validations

* Merge branch 'release' into feature/new-document-viewer

* lazy load external lib
2021-11-29 15:37:49 +00:00
Yash Vibhandik
f6acbf1407
fix: #8530 Added Config for Menu JS Convertible (#8775)
* fix: #8530 updated config for menu color jsconvertible

* test case updated

* yarn lock update
2021-11-29 15:37:05 +00:00
Tolulope Adetula
f30e389167
fix: Evaluation issue with Button in table Widget (#9356)
* fix: Evaluation issue

* fix: add validation

* revert jest tests changes

* revert cypress test

Co-authored-by: root <pawan@appsmith.com>
2021-11-26 17:03:50 +05:30
Confidence Okoghenun
0b18ea64f3
chore: Renames actions to event on property pane (#8579) 2021-11-26 15:02:04 +05:30
Keyur Paralkar
9fc0a038ec
fix: update tooltip record count prop table (#9297)
* docs: changed the tooltip text for total record count for table widget

* test: added unit test for testing tooltip text table widget

* refactor: added Tooltip message in the message constants
2021-11-26 10:44:00 +05:30
Bhavin K
a961c66ec3
fix: updated button group widget properties and GROUP_BUTTONS controls style (#9304) 2021-11-26 10:29:56 +05:30
Rishabh Rathod
d7cdf6f84b
fix: Add escaping special characters before JSON.parse (#9293)
* Add escaping special characters before JSON.parse
2021-11-25 16:22:40 +05:30
Aswath K
41c7c344b4
fix: radio group widget crash when one of options becomes null (#9303) 2021-11-25 14:59:16 +05:30
Pawan Kumar
d96c4981ca
fix: Button size inside the Table widget has increased + Property pane's panel not scrollable + Alignment issues (#9318) 2021-11-24 17:55:07 +05:30
Vicky Bansal
bf513f5c60
fix: Hide scrollbar in header and show when user hovers over header in Table Widget (#9323)
Co-authored-by: root <pawan@appsmith.com>
2021-11-24 15:27:26 +05:30
Paul Li
3f87f4959e
fix: Table Widget Icon Button should be having a default variant (#8664)
* fix: Table Widget Icon Button should be having a default variant

-- Add update logic for button variant property

* fix: Table Widget Icon Button should have default variant

-- Revert old solution
-- Set default button variant to PRIMARY both in getTableColumns and in propertyConfig

* fix: Table Widget Icon Button should have default variant

-- Change comments for updateIconAlignment utility function
-- Create a migration for button variant

* fix: Table Widget Icon Button should have default variant

-- Remove unused index parameter from forEach statement

* fix: Table Widget Icon Button should have default button variant

-- Fix on misuse of forEach on primaryColumns object

* fix: Table Widget Icon Button should have default variant

-- Change buttonVariant to TERTIARY instead of PRIMARY
2021-11-23 22:10:13 +08:00
Bhavin K
ffefdcccd8
fix: added muted flag and updated helper text (#9259) 2021-11-23 15:10:43 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking (#7361)
* add tailwindcss

* docked property pane

* uncomment a line

* make entity explorer as drawer on unpin

* remove unused imports

* add pin state in  reducer

* add menu icon in header

* fix widget sidebar

* fix widgets sidebar

* style property pane

* update property pane css

* update icons in property pane

* update property pane header styles

* update spacing

* fix few ui issues

* wip: preview mode

* wip:preview mode

* remove unused import

* comments sidebar in app and edit mode

* fix order of import

* use selected state for property pane

* update scrollbar style

* add classes to sidebar and property pane

* make widgets editor fluid

* make widgets editor fluid and refactor logic

* resize the widgets editor if explorer is pinned

* add shortcut for preview mode

* fix link for tabs in edit mode

* zoom in/zoom out for 0.75

* fix chart widget + table widget crashing

* allow zooming of canvas

* fix weird canvas draw issue + update container for handling zoom

* add actions for is panning

* allow panning with grab cursor

* reset panning + zooming when entering preview mode

* add grabbing cursor when grabbing

* only prevent default when space key is pressed

* dont allow zoom in preview mode

* remove unused imports

* fix dont allow zoom in preview mode

* fix ux of panning on space hit

* make fluid as the default app layout

* chart spec

* fix dropdown_on change spec

* fix add widget table and bind spec

* remove draggable property pane spec

* fix container spec

* fix form widget spec

* fix jest test

* fix the function typo

* remove clicking of close button for property pane in cypress tests

* remove property pane actions test

* fix drag and drop test failing

* add cypress selector id to back button in property pane

* fix toggle js spec

* fix merge conflicts from new design system

* editor header

* fix product updates styles + widget card

* remove all unused imports

* fix dynamic layout spec

* fix entity explorer tab rename test failing

* fix table spec

* fix bind tabletextpagination spec

* fix js object spec

* fix entity explorer rename issue

* fix cypress test

* fix cypress command wrong commit

* fix tab spec

* fix property pane copy tests

* add zoom header

* zoom levels

* make property pane sidebar resizable

* add multi select property pane

* fix widget search bug

* update property pane width in state on drag end

* fix viewer header

* fix editor header

* update editor header + remove zooming

* update small style

* dont allow closing of explorer when resizing

* fix jest test

* fix dropdown widget jest test

* preview test case wip

* add entity explorer pinning tests + preview mode tests

* add tooltip in layout control + add padding bottom in property pane view

* incorporate aakash feedbacks

* fix preview mode margin issue

* remove panning code

* fix cypress failing test

* uncomment jest test

* remove redundant code

* fix maincontainer test

* incorporate review feedbacks

* incorporate aakash feedbacks

* review feedbacks

* incorporate review feedbacks

* incorporate qa feedbacks

* fix dynamic layout spec

* updated test based on latest change

* dsl updated

* Updated dsl

* Updated dsl

* resize deselects widget issue.

* fix canvas height issue

* fix typo

* incorporate qa feedbacks

* incorporate qa feedbacks

* incorporate qa feedbacks

* update color for setting control for widget name

* fix onboarding styles conflicts

* Updated tests

* fix application overflow issue

* updated test method

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
Yash Vibhandik
75a25925b8
fix: #5980 added clear all filters button and close filter pane button (#8734)
* fix: #5980 added clear all filters button and close filter pane button

* height updated

* updated class names for test case
2021-11-23 11:53:26 +05:30
Yash Vibhandik
399eabd987
fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name (#8770)
* fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name

* highlighted duplicate column labels, show error message only when duplicate column label focused

* updated test case

* updated duplicate label indicator logic for test case
2021-11-23 11:35:01 +05:30
onifade boluwatife
e466495b5b
fix: Date picker must exit on pressing esc key when 'close on selecting' is turned off (#8425)
* refactored date picker a little
* minor refactor of date picker
* update
2021-11-22 07:08:36 +00:00
Bhavin K
e9bee3e511
fix: handled component update value logic (#9232)
* handled component update value logic

* Update index.tsx
2021-11-19 17:35:40 +05:30