Commit Graph

148 Commits

Author SHA1 Message Date
sharanya-appsmith
241bb8d43c
test: Cypress - Rating widget (#25944)
1. Validate Max rating and Default rating
2. Validations on Tooltip values
3. Validations on readonly, disabled and visibility of rating widget
4. Validations on events - On change rating widget - alert and modal 
5. Validations on Rename, Copy, Delete - rating widget
2023-08-08 12:16:48 +05:30
NandanAnantharamu
fbe47a4522
test: cypress - updated tests for List page js to ts migration (#25409)
- migration of flaky list tests from js to ts

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-08-04 00:55:03 +05:30
Aishwarya-U-R
a8c4d9f170
test: Cypress | Flaky fixes (#25901)
## Description
- This PR Flaky fixes below:
- Widgets/Others/Video_spec.js
- ListV2/Childwigets/List_Inputs_spec.js
- ActionExecution/uiToCode/uiToCode_spec.ts
- Datasources/MsSQL_Basic_Spec.ts
- /Apps/EchoApiCMS_spec.js - UpdateCodeInput() to always go to end of
entered input
- /BugTests/InputTruncateCheck_Spec.ts - PinUnpinEntityExplorer()
improved to handle pin based on its presence

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-02 03:44:56 +05:30
Saroj
1b534cdd79
test: Additional regression scenarios for gsheet (#25844)
## Description
- Added following  regression scenarios for gsheet
   1. Create query from active ds tab
   2. Create query from ds details page
   3. Generate CRUD page from active ds
   4. Generate CRUD page from entity explorer
   5. Added test to add query from global search

#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [ ] Cypress
## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-01 16:42:44 +05:30
Aishwarya-U-R
af415f4f30
test: Cypress | Automated tests for MySQL + Flaky fixes (#25867)
## Description
- This PR fixes the below flaky fixes
- GitSyncedApps_spec.js
- Improves coverage for MySQl - adding suggested widget binding
- TableV2/Date_column_editing_1_spec.ts fix
- WaitUntilEleAppear improved
- DeployApp() updated
- QueryPane/Mongo_Spec.js - adding wait time
- AssertIfPropertyIsNotVisible() replaced
- fat-migration.yml deleted
- cypress-real-events - update
- /Filepicker/FilePicker2_spec.js
- /Autocomplete/Autocomplete_setters_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-01 15:04:15 +05:30
akash-codemonk
22c272c210
feat: debugger error navigation (#25505)
## Description

Property pane navigation on click of a widget error or log from the
debugger. Navigation to a field works if the log has the required meta
data here it would be the property path. With the help of the property
pane config and the widget's properties we generate the payload to set
the required panel, tab, section states. Factory class to clearly
separate out the logic for the different entities.

#### PR fixes following issue(s)
Related to https://github.com/appsmithorg/appsmith/issues/16408
Fixes https://github.com/appsmithorg/appsmith/issues/25465
Fixes https://github.com/appsmithorg/appsmith/issues/25462
2023-08-01 09:32:41 +05:30
Saroj
d27078b54e
test: Gsheet Automation (#25255)
## Description
- Automated below queries for gsheet

1. Fetch Details
2. Insert one
3. Insert many
4. Update one
5. Update many
6. Fetch many
7. Delete One

- Added workflow to schedule run for gsheet automated tests on the
hosted instance
- Added a new cypress config file which will be used to run the gsheet
tests
- Added tests for folowing permission/scope options `All access`,
`selected access`, `Read/write | All google sheets` and `Read | All
google sheets`
- Added negative scenarios
- Added tests to verify widget binding for both suggested widget and
drag n drop widget for both selected and all access permission/scope
#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>
## Checklist:

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-26 18:56:24 +05:30
Aishwarya-U-R
c6be140eb2
test: Cypress | Flaky fixes (#25700)
## Description
- This PR does the below:
       - Improve HoverElement() 
       - Button_onClickAction_spec.js - CI flaky fix
       - ListV2/Childwigets/List_FilePicker_spec.js 
       - Datasources/RestApiOAuth2Validation_spec.js
       - ApiPage - EnterURL() improved - for the entered url to settle
       
#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress
- 
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-26 14:26:36 +05:30
Ayangade Adeoluwa
3ea0568771
fix: Fix cancel issue and form value state persistence (#25412)
This PR fixes two things 

1. The cancel button not showing the dialog after a change has been
made.
2. The fields in the datasource form retaining values changed by the
user without the user saving those changes.

Fixes #25333 

> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [x] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-24 15:59:05 +05:30
sharanya-appsmith
125c8d4414
test: Cypress - Helpers update (#25582)
Added helper method: 

1.  to validate tooltip text
2. to assert if the class name contains "disabled"
3. dragNDrop to public 
4. to search and open an application
2023-07-24 14:24:17 +05:30
Ayush Pahwa
75b297201a
chore: code splitting for multiple env feature (#25479)
code split for EE feature

---------

Co-authored-by: ChandanBalajiBP <104058110+ChandanBalajiBP@users.noreply.github.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
2023-07-21 12:53:17 +07:00
Vijetha-Kaja
facc4d75eb
test: Cypress - Flaky fix (#25451)
## Description

- RefreshPage() method update
- Replaced External API in ApiBugs_Spec.ts

**Fixed below flaky tests**

- DSCrudAndBindings_Spec.ts
- GitSyncedApps_spec.js
- S3_1_spec.js

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-20 18:45:27 +05:30
NandanAnantharamu
6dd1d8b72d
test: cypress - js to ts migration for AppNavigation (#25188)
js to ts migration for AppNavigation
2023-07-19 14:35:31 +05:30
Vijetha-Kaja
83f957e228
test: Cypress - Flaky fix (#25341)
## Description

**Fixed below flaky tests**

- CommunityIssues_Spec.ts
- TableTextPagination_spec.js
- TableV2TextPagination_spec.js

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-18 18:06:01 +05:30
Preet Sidhu
0cc716c2a5
chore: add cypress tests for auto height scenarios (#23616)
## Description

Added specs:
1. AutoHeight_Container_spec.js
2. AutoHeight_Form_spec.js
3. AutoHeight_Modal_spec.js
4. AutoHeight_Tabs_spec.js

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [x] Cypress

---------

Co-authored-by: rahulramesha <rahul@appsmith.com>
2023-07-10 10:02:42 +05:30
NandanAnantharamu
9304a568d5
test: Cypress- js to ts migration tests for Dynamic Height feature (#24328)
PR is meant to improve Dynamic height tests and make them more readable
2023-07-07 12:22:06 +05:30
Sangeeth Sivan
f24ecc2473
feat: MySQL & MSSQL query generator (#24516)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-06 13:50:58 +05:30
Aishwarya-U-R
8e868b3093
test: Cypress | Flaky fixes (#25087)
## Description
- This PR improves RefreshPage()
- Improves StubbingDeployPage()
- Fixes below flaky tests;
- Datasources/ElasticSearch_Basic_Spec.ts
- Datasources/MsSQL_Basic_Spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after changes were reviewed
2023-07-06 10:43:15 +05:30
Aishwarya-U-R
6488effb4f
test: Cypress | Simplifying AddDsl method (#24991)
## Description
- This PR fixes below from Cypress suite to better developer experience
- Simplifies the AddDSL method
- Added AssertQueryTableResponse() & used
- SaveDataSource improved
- ReconnectDSbyName() created
- FirstTimeUserOnboarding_spec - 5th - Trail fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-04 22:03:31 +05:30
Ashok Kumar M
3cc044e126
fix: Remove Auto layout feature flag dependency. (#24947)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description

Removing Feature flag requirement for auto layout since its been in prod
for a while and also feature flags are unavailable for public apps.
>
>
#### PR fixes following issue(s)
Fixes #24848
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-03 12:03:27 +05:30
Dhruvik Neharia
e311d206a9
feat: Update the default text widget value to "Hello {{appsmith.user.name || appsmith.user.email}}" (#24705) 2023-07-03 10:38:01 +05:30
Aishwarya-U-R
63eae07346
test: Cypress | Flaky fixes (#24925)
## Description
This PR upgrades Cypress from 12.14 to Cy 12.16 along with below flaky
fixes:
- This PR fixes the below flakyness in Cypress suite:
- ConversionAlgorithm_AutoLayout_Valid.js
- ButtonGroup_MenuButton_Width_spec.js
- columntypes/select_spec - method update
- Date_column_editing_1_spec.js
- Omnibar_spec.js - 6th case
- TableV2_Widget_API_Pagination_spec.js
- TableV2_Widget_API_Derived_Column_spec.js
- TableV2TextPagination_spec.js
- Table_Widget_API_Pagination_spec.js
- TableTextPagination_spec.js
- Table_Derived_Column_Data_validation_spec.js
- LoginTests/LoginFailure_spec.js
- cy.visit - timeouts handled
- CreateQueryAfterDSSaved for Mock DB's
- TableV2Filter1_2_Spec
- InputTruncateCheck_Spec
- DSDocs_Spec - for assertNewtab open
- TableV2_DisplayText_spec
- MultiSelect3_spec
- PropertyPaneSuggestion_spec
- Others/Video_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes tests were reviewed
2023-07-01 00:16:57 +05:30
Aishwarya-U-R
bc3b8fc52a
test: Cypress | Flaky fixes (#24886)
## Description
- This PR tried update of the 3rd party api - typicode to TED -
Fetch_spec.ts - fetch not working with TED API - to check with Dev
further
- Fixed below flaky tests:
- Widgets/Image/Image_spec.js
- Widgets/TableV2/TableFilterV2_Filter.ts - all specs
- Table_Widget_API_Derived_Column_spec.js
- Onboarding/FirstTimeUserOnboarding_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress
>
>
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-06-29 12:20:07 +05:30
Rahul Barwal
8b912bff5d
fix: Reset templates filter for templates modal (#24192)
## Description

* Currently we do not reset the template filters when we close template
modal and open it again in `add page from template flow`
   This becomes confusing for some users.

* Also increases test coverage of templates filtering

#### PR fixes following issue(s)
Fixes #17276

#### Media


https://github.com/appsmithorg/appsmith/assets/6761673/3c94e21b-e8a9-4c6b-bc81-e677269bb5ea



#### Type of change
- Bug fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-29 11:52:05 +05:30
Rahul Barwal
2a72eddb2c
fix: puts navbar functionality behind feature flag (#24561)
## Description
This PR puts shownavbar functionality behind a feature flag.

* adds analytics events to track apps that use this flag.
* updates relevant specs.

#### PR fixes following issue(s)
Fixes #24515

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- Bug fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-22 10:30:24 +05:30
Aishwarya-U-R
91325d258e
test: Cypress | Moving Non-TED containers within Tests (#24709)
## Description
- This PR improves the container start for 
- Arango DB - Container started moved to test case level
- MsSql - Delete container added
- Elastic - Container started moved to test case level
- Starts container, runs tests, stops containers & deletes it too 🤞🏻
- Removed containers start from yml file
- Flaky fixes below:
         - Apps/ReconnectDatasource_spec.js
         - Improved FillPostgresDSForm()

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after all changes are reviewed
2023-06-21 23:07:21 +05:30
Aishwarya-U-R
6651475313
test: Cypress | Flaky fixes (#24593)
## Description
- This PR fixes below flaky tests:
  - AppNavigation/NavigationSettings_spec.js
  - Autocomplete/JS_AC_spec.ts - 6th case
  - Analytics_spec.js - increased restart time
- Apps/ReconnectDatasource_spec.js - Increasing timeout for better pass
rate
  - TableV2/Inline_editing_spec.js - trial fix
  - OneClickBinding/mongoDB_spec.ts
  - OneClickBinding/postgres_spec.ts
  - ScrollIntoView() fixes
  - /OtherUIFeatures/ViewMode_spec.js - flaky fix
  - TableV2/TableV2_PropertyPane_spec.js
  - OtherUIFeatures/UpdateApplication_spec.js
  - ListV2/Childwigets/List_FilePicker_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-06-20 14:28:06 +05:30
Aishwarya-U-R
084e28ab21
test: Cypress | Flaky fixes (#24581)
## Description
- This PR fixes the below flaky:
- ReconnectDatasource_spec.js
- ConversionAlgorithm_AutoLayout_Validation_BasicSpec.js
- Improves CreateApplication with intercept assert
- Changes all agHelper.AssertN.wStatus to assertHelper() method

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-06-18 10:25:16 +05:30
Aishwarya-U-R
2bfd4091ab
test: Cypress | Flaky fixes (#24572)
## Description
- This PR fixes Cypress flaky tests as mentioned below:
- JS_AC_spec.ts
- Admin_settings.js
- Theme_FormWidget_spec.js
- Scrolling_Spec.ts
- JSOnLoad2_Spec.ts
- Pick up the branch name from PR number

#### Type of change
- Script update (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
>
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress changes were
reviewed
2023-06-17 13:53:03 +05:30
Aishwarya-U-R
959fdce6ac
test: Cypress | Flaky fixes (#24508)
## Description
- This PR improves the sign up method to work even if telemetry related
details are not asked at start
- Also alters the Commit message based on the repository/workflow or
push runs
 - Improves DragDropWidgetNVerify()
 - Fixes flaky TableV2/Inline_editing_spec.js spec with TS methods
 - Improved EditTableCell()
 - Skipping deleting apps during local runs for debugging purpose
 - Fixes PropertyPane_Search_spec.ts
- Fixed ever flaky AppNavigationWithMultiplePages_spec,
AppNavigationWithAutoLayout_spec

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?

- [X] Cypress CI runs
>
>

## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after changes were reviewed
2023-06-17 00:10:10 +05:30
Aishwarya-U-R
d7b2bad974
test: Cypress | Cy 12 upgrade + Flaky fixes (#23852)
## Description
- This PR upgrades cypress from 11.2 to 12.13.0 which fixes the random
browser crash issue in CI runs
 - ValidateNetworkStatus() updates to validate the n/w responses
 - cy.route() to cy.intercept()
 - Converting dataSources.json to HostPort.ts
 - Api responses read - updating to right Cy12 supported format
- js inconsistent testJsontext to TS `EnterJSContext` in few failing
specs
 - CI - higher resolution trials
- Improves _.agHelper.RefreshPage() - fixing Error: Socket closed before
finished writing response
 - AssertDocumentReady() created
 - within(()) & .children() - handled for Cy12
- Improved DeployApp(), NavigateBacktoEditor(), RefreshPage(), AddDsl()
methods
- js inconsistent goToEditFromPublish to TS `NavigateBacktoEditor` in
all specs
- js inconsistent PublishtheApp to TS `_.agHelper.DeployApp` in all
specs
- Convert /DynamicHeight/Text_Widget_spec.js to TS with all supporting
TS helpers
 - ToggleJSMode()
 - COMMIT_INFO_MESSAGE improved
 - Remove tooltip on the Application Name after rename
- js inconsistent cy.addDsl(dsl); to TS helper `_.agHelper.AddDsl(val);`
 - ++++ Much more improvements....

#### Type of change
- Script fixes

## Testing
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed

---------

Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
2023-06-15 18:51:11 +05:30
Ankita Kinger
daba039423
ci: Fixing the default value syntax for update input parameter (#24323)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-09 23:08:29 +05:30
rahulramesha
06ef98dd1a
chore: Conversion and Copy Paste tests for Autolayout (#23702)
## Description
Add Auto layout related test cases for Conversion algorithm and copy
paste test cases

#### PR fixes following issue(s)
Fixes #23642 
Fixes #23644

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
- [ ] Cypress

#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-09 20:10:12 +05:30
Aishwarya-U-R
49ea8ee6eb
test: Cypress | Flaky fix (#24242)
## Description
- This PR fixes the flaky spec - ImportExportForkApplication_spec in CI
runs

#### Type of change
- Script fix 

## Testing
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-06-08 14:40:38 +05:30
Aishwarya-U-R
a220b6ef95
test: Cypress | Flaky fix MySQL1_Spec.ts (#24004)
## Description
- This PR fixes the flaky network validation for MySQL1_Spec.ts that is
failing in CI runs

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress local run

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress changes were
reviewed
2023-06-02 21:24:06 +05:30
NandanAnantharamu
7e04c17cf7
test: Test/auto layout modal spec (#23830)
Tests added as part of
https://github.com/appsmithorg/appsmith/issues/23230

- Modal Widget
- App Navigation
- Widget Navigation
2023-05-31 12:09:17 +05:30
Ivan Akulov
3cb5da9ba3
fix: EnableAllCodeEditors should not fail when code editors don’t exist on the page (#23551)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-05-30 10:02:47 +05:30
Aswath K
a18c1222ee
test: Auto dimension scenarios (#23398)
## Description
Adds Cypress tests for ensuring Auto layout's auto-dimension feature
works properly

#### PR fixes following issue(s)
Fixes #23230
Fixes #22580

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-05-30 08:10:13 +05:30
Vijetha-Kaja
e551a76e8b
test: Cypress - Flaky test fix (#23722)
## Description

**Fixed below flaky tests**

- MongoDBShoppingCart_spec.js
- API_Edit_spec.js
- Command_Click_Navigation_spec.js
- TopStacked_spec.js

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-05-30 07:11:49 +05:30
Aishwarya-U-R
49649be7e4
test: Cypress version upgrade Cy 11.2 + Flaky fixes (#23667)
## Description
- Cy 10.4 seems to crash browser sometimes & CI runs are timingout,
hence upgrading to Cy 11.2 in which fix for this is included (fix from
10.11 onwards)
- WIDGET also included into ObjectsCore & all references for direct
WIDGET updated
- .attachFile() updated to .selectFile
- NavigateTo_spec - split done - updated methods to use TS helpers
- Flakiness with @updateLayout call - fixed
- ActionExecution/PostWindowMessage_spec.ts - flakyfix
- GitSync/SwitchBranches_spec.js - 7th case - flakyfix
- S3_spec1 - removed duplicate `its` & updated tests
- Datasources/Styles_spec.js - flakyfix
- ci-viewports updated to check CI video/screenshot quality - this is
affecting other cases, hence reverted
- Binding/Widget_loading_spec.js - flakyfix
- ApiTests/API_Edit_spec.js - flakyfix
- ExplorerTests/Query_Datasource_spec.js - flakyfix

#### PR fixes following issue(s)
Fixes #
- Improves CI runs
#### Type of change
- Script update (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:

#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-05-24 18:00:39 +05:30
Aishwarya-U-R
40f52bdad6
test: Cypress | Folder structure correction (#23568)
## Description
- This PR fixes flaky Bind_tableV2Api_spec
- Corrects the folder structure/names
- Splits IDE/Canvas_Context_Property_Pane_spec.js which is long running
into smaller units
- Increased timeout to reduce flaky tests

#### Type of change
- Script fixes

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress changes were
reviewed
2023-05-21 02:01:50 +05:30
albinAppsmith
629999f124
feat: [epic] appsmith design system version 2 deduplication (#22030)
## Description

### Fixes
- [x] https://github.com/appsmithorg/appsmith/issues/19383
- [x] https://github.com/appsmithorg/appsmith/issues/19384
- [x] https://github.com/appsmithorg/appsmith/issues/19385
- [x] https://github.com/appsmithorg/appsmith/issues/19386
- [x] https://github.com/appsmithorg/appsmith/issues/19387
- [x] https://github.com/appsmithorg/appsmith/issues/19388
- [x] https://github.com/appsmithorg/appsmith/issues/19389
- [x] https://github.com/appsmithorg/appsmith/issues/19390
- [x] https://github.com/appsmithorg/appsmith/issues/19391
- [x] https://github.com/appsmithorg/appsmith/issues/19392
- [x] https://github.com/appsmithorg/appsmith/issues/19393
- [x] https://github.com/appsmithorg/appsmith/issues/19394
- [x] https://github.com/appsmithorg/appsmith/issues/19395
- [x] https://github.com/appsmithorg/appsmith/issues/19396
- [x] https://github.com/appsmithorg/appsmith/issues/19397
- [x] https://github.com/appsmithorg/appsmith/issues/19398
- [x] https://github.com/appsmithorg/appsmith/issues/19399
- [x] https://github.com/appsmithorg/appsmith/issues/19400
- [x] https://github.com/appsmithorg/appsmith/issues/19401
- [x] https://github.com/appsmithorg/appsmith/issues/19402
- [x] https://github.com/appsmithorg/appsmith/issues/19403
- [x] https://github.com/appsmithorg/appsmith/issues/19404
- [x] https://github.com/appsmithorg/appsmith/issues/19405
- [x] https://github.com/appsmithorg/appsmith/issues/19406
- [x] https://github.com/appsmithorg/appsmith/issues/19407
- [x] https://github.com/appsmithorg/appsmith/issues/19408
- [x] https://github.com/appsmithorg/appsmith/issues/19409

Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers
about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in>
Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com>
Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-05-20 00:07:06 +05:30
Satish Gandham
83538ad74d
feat: Bundle optimization and first load improvements (#21667)
Co-authored-by: Ivan Akulov <mail@iamakulov.com>
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Ivan Akulov <iamakulov@outlook.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2023-05-11 10:56:03 +05:30
Hetu Nandu
3408729df9
feat: Open doc links in a new tab (#22613)
## Description

When user clicks on a docs link, open the docs in a new tab instead of
the omnibar.

Fixes #22409


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

- New feature (non-breaking change which adds functionality)


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-26 16:03:13 +00:00
arunvjn
e2224ae01d
chore: code splitting changes for appsmith ai v0.1 (#22521)
## Description
This PR only contains interfaces for the EE AI feat. These are temporary
changes

## Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## How Has This Been Tested?
- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] New and existing unit tests pass locally with my changes
- [x] My changes generate no new warnings
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 20:42:35 +05:30
Aishwarya-U-R
a49043c478
test: Cypress - Flaky fix (#22263)
## Description

- This PR adds timeout for the EntityExpand() - to solve all the recent
issue seen with Expanding of Entity Explorer items - either after
refresh/page load/from view to edit mode navigations

## Type of change

- Script update (non-breaking change which fixes CI timeout issues with
EntityExplorer click)


## How Has This Been Tested?
- Cypress CI run

## Checklist:
### QA activity:
- [x] Added Test Plan Approved label after reviewing all Cypress test
2023-04-12 00:34:32 +05:30
Aishwarya-U-R
00695e0600
test: Cypress - Flaky fix (#22248)
## Description

- This PR fixes below flaky test in CI - by improving the
EnterActionValue() agHelper metod:
- setInterval_spec.js


## Type of change

- Script fix (non-breaking change which fixes CI failure)


## How Has This Been Tested?

- Cypress local run

## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
2023-04-11 01:24:10 +05:30
Ravi Kumar Prasad
6ac99037b0
feat: Action selector (#21582)
## Description
Replaces the old boring action selector dropdown with a much more
sophisticated UI that is capable of going above and beyond. Users with
an aversion to code can now build their more complex workflows with a
click of a few buttons.

Consider this code snippet 
```javascript
Api1.run(() => {
  showAlert("Hello");
  navigateTo('Page1', {}, 'SAME_WINDOW');
}, () => {
  removeValue("test");
});
```
|**Old action selector** |**New action selector**|
|:-:|:-:|
|<img width="250" alt="Screenshot 2023-03-29 at 16 54 14"
src="https://user-images.githubusercontent.com/32433245/228520661-a639b580-8986-4aec-a0f5-e2786d1a0f56.png">|
<img width="250" alt="Screenshot 2023-03-29 at 16 55 15"
src="https://user-images.githubusercontent.com/32433245/228521043-5025aa42-af95-4574-b586-bc4c721240bc.png">|

**Click on an action block to edit its parameters.**
<img width="500" alt="Screenshot 2023-03-29 at 17 01 18"
src="https://user-images.githubusercontent.com/32433245/228522479-493769d0-9d2c-4b67-b493-a79e3bb9c947.png">

**Switch to JS mode to get the raw code**
<img width="273" alt="Screenshot 2023-03-29 at 17 05 51"
src="https://user-images.githubusercontent.com/32433245/228523458-13bc0302-4c94-4176-b5aa-3ec208122f57.png">

### Code changes
**New UI components**
  - ActionCreator component splits the code into block statements.
  - Each block statement is represented by ActionTree.tsx UI component.
  - ActionTree.tsx represents an action and its chains.
- ActionCard.tsx is the block that represents the individual action on
the UI.
- ActionSelector.tsx component is popover that contains the form for
editing individual action.
- TabView, TextView, SelectorView, ActionSelectorView and KeyValueView
are components that represent configurable fields in ActionSelector
form.
  
**AST methods**
  - Added methods to get/set function names, expressions, arguments.
- Added methods to get/set then/catch blocks to allow chaining of
actions.
  - Added methods to check if code is convertible to UI.

Fixes #10160
Fixes #21588 
Fixes #21392
Fixes #21393
Fixes #7903
Fixes #15895
Fixes #17765
Fixes #14562

Depends on https://github.com/appsmithorg/design-system/pull/306

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?
- Manual
- Jest
- Cypress

### Test Plan
https://github.com/appsmithorg/TestSmith/issues/2296

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [x] Test plan has been approved by relevant developers
- [x] Test plan has been peer reviewed by QA
- [x] Cypress test cases have been added and approved by either SDET or
manual QA
- [x] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [x] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Rimil Dey <rimil@appsmith.com>
Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2023-04-06 22:19:12 +05:30
Aishwarya-U-R
ca6ab330c5
test: test: Cypress - Automated tests for Elasticsearch datasource (#22101)
## Description

- This PR includes tests for Elastic Search datasource - with querying &
usage of various fields in the query page

## Type of change

- New script

## How Has This Been Tested?

- Cypress local/CI runs

## Checklist:

### QA activity:
- [X] Added Test Plan Approved label after reviewing all Cypress test
2023-04-06 09:37:04 +05:30
Ankita Kinger
c3f7d6c0cf
fix: Adding a permission check for creating new datasource on generate page (#22085)
## Description

Adding a permission check for creating new datasource on generate page.
When a custom role is assigned in GAC, where the user doesn't have
access to create a new datasource, in spite of that the create new
datasource option is showed in the dropdown on generate page with data.
This is fixed with this PR.

Fixes [#22027](https://github.com/appsmithorg/appsmith/issues/22027)

## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?
> Tested it manually and it works fine.

- Manual

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-05 17:22:43 +05:30