Commit Graph

77 Commits

Author SHA1 Message Date
arunvjn
63db439183
Fixed r.match bug (#4593) 2021-05-20 16:51:10 +05:30
arunvjn
4733edfccd
Fixed query params parsing in API pane (#4482)
* Fixed query params parsing when there are mulitple "="s.

* Added cypress tests to validate query params parsing
2021-05-18 17:17:43 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Apeksha Bhosale
e4ee2b07c9
r.match on API pane error (#4497)
* r.match on API pane error

* Pr comment fixed
2021-05-17 12:51:48 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
arunvjn
65d33c2614
Fixed query params parsing in API pane when dynamic bindings are present in the URL (#4205) 2021-05-06 18:45:05 +05:30
Apeksha Bhosale
8473226382
app crashes when moving from google to rest api (#4282)
* app crashes when moving from google to rest api

* wrong url for test
2021-05-04 18:38:20 +05:30
Hetu Nandu
c92eb0e5a4
Introduce different evaluation types for different binding fields (#3834) 2021-04-26 11:11:32 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
Apeksha Bhosale
333c4169eb
name can't be read from empty object (#3958) 2021-04-20 12:26:30 +05:30
Hetu Nandu
28995e5b53
Fix PS and smart substitute true false value (#3896) 2021-04-07 16:06:17 +05:30
Hetu Nandu
af5f6544ea
Always guarantee to fetch Api plugin forms (#3847) 2021-04-02 15:17:37 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
Apeksha Bhosale
5d71e86f43 Test case and refactor code 2021-03-23 15:14:44 +05:30
Apeksha Bhosale
3dc04901c8 added index check to add content type in existing field 2021-03-16 19:57:21 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798)
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-13 19:54:45 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
akash-codemonk
05b2cd6d29
Fix renaming action goes to the action page (#3201) 2021-02-26 11:15:27 +05:30
Piyush Mishra
74b013d909
Encode params toggle (#3006)
* Makes client side changes to support actionConfiguration.encodeParamsToggle setting.
* Add migration code.

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-16 20:31:35 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-11 12:06:07 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223)
* @hetunandu for president
2020-12-17 20:13:01 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Abhinav Jha
543b7ec72d
Entity Explorer Render (#1354)
* WIP: Performance improvements in entity explorer

* WIP: Achieve feature parity for entity explorer with release

* Update unit tests

* Add sentry profiling to current page entity properties component

* Fix page add/delete not showing up on entity explorer issue. Update memoization logic for pagegroup entity

* Deal with the ban-ts-ignore eslint issues

* Update unit tests

* Fix widget entity children visibility

* Fix tests and code

* Fix tests for scenarios where the collapsed entities are unmount, as this is a part of the performance optimization

* Filter undefined children when generating structureDSL

* Remove rule from eslintrc

Consolidate createPage test command

* Update CreatePage tests to remove redundant dsl updates

* Revert CreatePage test changes, as adding more checks within this command globally causes other tests to have issues.

* re-enable eslint rule, as without it CI tests fail

* Revert to ban-ts-comment

* Fix typescript ban-ts-ignore issue by upgrading react-scripts and fixing typescript issue across the application

* Typescript errors handled

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
2020-11-03 18:35:40 +05:30
Nikhil Nandagopal
fcb6c4c43c
added data source name to query creation (#1068) 2020-10-07 19:40:08 +05:30
Nikhil Nandagopal
194f27aabb
Feature/analytics (#1022)
* added appname to PAGE_LOAD data and fixed getCurrentApplication method

* Fixed analytics to save and test datasources

* fixed analytics for create action

* added event for action execution

* added a type for event location
2020-10-06 20:40:21 +05:30
Nikhil Nandagopal
662098d771
Manual Performance Tracking utility (#696)
- Created Performance Tracker to use a queue internally to make synchronous logging easy
- Bump sentry sdk versions
- Added performance tracking for 
  - GENERATE_VIEW_MODE_PROPS
  - GENERATE_API_PROPS
  - ENTITY_EXPLORER_ENTITY
  - GENERATE_PROPERTY_PANE_PROPS
  - GENERATE_WIDGET_EDITOR_PROPS
  - CLOSE_API
    - SYNC_PARAMS_SAGA
    - CHANGE_API_SAGA
  - CONSTRUCT_UNEVAL_TREE
  - DATA_TREE_EVALUATION
    - CREATE_DEPENDENCIES
    - SORTED_DEPENDENCY_EVALUATION
    - SET_WIDGET_LOADING
    - VALIDATE_DATA_TREE
  - CONSTRUCT_CANVAS_DSL
 

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-24 10:17:37 +05:30
Abhinav Jha
613db73b15
Fix: Action move & copy issues (#381)
* Fix: When copying a query, the app tries to open the API page with the queryID

* Fix: When moving a query, the query input box is empty
2020-08-21 11:33:04 +05:30
Hetu Nandu
9a1658e2c1
Fixes for autocomplete (#351)
* Fix tern guessing for completions

* Probable fix for create api button not working

* Close autocomplete when "Backspace" or "Comma" is pressed

* Only show extra docs when ctrl+space is pressed when hint is selected

* Fix issue with action form state params not disabling after taking an action
2020-08-19 14:51:32 +05:30
Hetu Nandu
c4ac4668c2
Launch polish bug fixes (#337)
* Make sure default page is first in view mode

* Update query form on name change

* Add copy support for deploy link

* Show server error when timeout occurs on first load
2020-08-18 14:18:06 +05:30
NandanAnantharamu
05f190c102
Feature/entity browse (#220)
# New Feature: Entity Explorer
- Entities are actions (apis and queries), datasources, pages, and widgets
- With this new feature, all entities in the application will be available
  to view in the new entity explorer sidebar
- All existing application features from the api sidebar, query sidebar, datasource sidebar and pages sidebar
  now are avialable on the entity explorer sidebar
- Users are now able to quickly switch to any entity in the application from the entity explorer sidebar.
- Users can also search all entities in the application from the new sidebar. Use cmd + f or ctrl + f to focus on the search input
- Users can rename entities from the new sidebar
- Users can also perform contextual actions on these entities like set a page as home page, copy/move actions, delete entity, etc from the context menu available alongside the entities in the sidebar
- Users can view the properties of the entities in the sidebar, as well as copy bindings to use in the application.
2020-08-10 14:22:45 +05:30
Hetu Nandu
612f01b04a
Fix params not saving after url update (#85) 2020-07-14 12:23:33 +05:30
Hetu Nandu
0b86b503aa
Fix move/copy success/failure workflow (#47) 2020-07-07 13:37:37 +05:30
Hetu Nandu
13e173fa77
Action save fixes (#33)
- Increased timeout for move action
- Table header typescript fix
- Fix data tree selectors for better performance
- Debounce update action saga by 500 ms
- Query delete fix
- Query save fix
2020-07-06 19:05:31 +05:30
satbir121
bbbdbd50b5
Name of a newly created api and query is focused on mount. (#21)
* New api and query has name in edit mode

* Curl import new api.

* Changing createApi command for new ui.

* Edit Api name is not visible in UI.

* Removed edit api name click.

Co-authored-by: Satbir Singh <satbir@appsmith.com>
Co-authored-by: Arpit Mohan <me@arpitmohan.com>
Co-authored-by: Satbir Singh <apple@apples-MacBook-Pro.local>
2020-07-06 11:08:39 +05:30
Hetu Nandu
4a6717889c
Streamline action save with widgets (#10)
- Remove drafts from actions
- Direct update action from forms
- Debounced saving of actions
- Add org id in default datasource
- Merge query and api run saga
2020-07-03 14:28:58 +05:30
Hetu Nandu
46f0873efe update paths 2020-06-30 15:19:30 +05:30
Akash N
598ef55aff Fixes
- Show loader in api home screen when creating a new api action
- Show column lines for table in query pane
2020-06-20 05:29:30 +00:00
Satbir Singh
e2a30da1c3 Merge branch 'master' into 'release'
Backmerge master to release.

See merge request theappsmith/internal-tools-client!754
2020-06-18 16:24:21 +00:00
Hetu Nandu
ded1a130e3 Action draft fixes 2020-06-18 14:16:49 +00:00
Arpit Mohan
fc8e43da1f Query pane fixes
- Show mongo execute response in seperate cards for each record
- Update postgres read template
- Show query execute error message in the UI.
2020-06-17 10:19:56 +00:00
Satbir Singh
7e3df81302 Api name editable. 2020-06-16 10:23:19 +00:00
Abhinav Jha
2609f26117 Merge branch 'fix/lightning-menu' into 'release'
Fix/lightning menu

- Add lightning menu to assist users in binding
- Change the action selection display for consistency.

See merge request theappsmith/internal-tools-client!706
2020-06-15 10:51:20 +00:00
Hetu Nandu
133f50807e Fix api pane performance 2020-06-12 08:35:52 +00:00
vicky_primathon.in
a528ffc7d4 merge conflicts resolved 2020-06-10 19:16:45 +05:30
Nikhil Nandagopal
125fb9c162 Merge branch 'fix/bugs' into 'release'
Fix/bugs

See merge request theappsmith/internal-tools-client!696
2020-06-10 12:19:55 +00:00
Hetu Nandu
cb2867069f Action creator evaluated value fixes 2020-06-10 12:16:50 +00:00
vicky_primathon.in
a5986ed8a8 merge conflicts resolved 2020-06-10 16:34:11 +05:30
Nikhil Nandagopal
8b0258b4b9 Merge branch 'release' into fix/bugs
# Conflicts:
#	src/pages/Editor/APIEditor/PostBodyData.tsx
2020-06-08 17:13:03 +05:30