- When the user removes an expression from the validation property of
input widget, its value becomes `""`. And in boolean validation
function we treat this empty string as false. so Input widget
ends up with isValid false and we show an error border around the
Input. so we are setting a default value true, so when there is
no expression it evaluates to true.
* Code cleanup and fix typos
* Increase the wait time after app import
Increase the wait time after app import for the categories to load
Co-authored-by: Satish Gandham <satish@appsmith.com>
* feat: added datasource icon on left of entity name, revamped name editor
* fix: updated the hardcoded message strings to use message.ts
* fix: types of variables
* fix: Map pin does not center when location is changed and centering option is turned on
-- Update center meta property when defaultMarkers or mapCenter properties were changed
* fix: Map pin does not center when location is changed and centering option is turned on
-- Force the last marker to be centered
* Fixed issue with Firestore in fetching data while using numbers in the where condition.
* Other Fixes made in the where condition :
When using Boolean
When using Date
When Using Timestamp
When given space in the key
When Space given in the Value
* Revert "fix: revert this.params solution (#10322)"
This reverts commit 2bcd73e41d.
* replace 'this.params' with 'executionParams'
* replace 'this?.params' also with 'executionParams'
* fix unit test lint errors
* added unit tests for params handling
* evaluateActionBindings unit test - add default value case
* comments update
* remove un-necessary `executionparams` assigment to `evalTree`
* Delete the pages post merge operation from application if they are removed from file system
* Changes per review
* Add tests
* changes per review
* Use string utils for null check
* Change per review
* Fix tests
* Fix tcs
* fix: added sentry exception for invalid DynamicBindingListPath
* refactor: updated the error message
* test: update unit test case for dynamic binding path error
* fix: addressed review comments
* fix: removed widgetFactory and propertyPane code for invalidDynamicBindingPath function
- Paths in dynamicBindingPathList and dynamicTriggerPathList which don't exist in the widget, may cause issues later in the lifecycle of an application. Purging these orphaned paths during property updates.
* Rearrange data tree widget factory
* Remove existing handling of default value override
* Altternate way of meta property override
* Fix tests
Co-authored-by: hetunandu <hetu@appsmith.com>
* Added API to generate deploy keys and store them in a collection for import flow
* Add tests for the key generation flow
* Move the key generation to helper class
* changes per review
* Fix bad merge
* add api to import application
* handle timeout for git import
* Update the comments
* Add API for git import
* handle duplicate application name error & add profiles while importing
* Add tests for import api
* Hydrate from file system after cloning the repo
* Fix test failures
* Test cases
* changes per review
* throw error when the datasource with same name of different type exists
* Fix test failures
* Fis error messages
* Fix test failures
* Fix issue with checking the datasource types
* Add datasource name check while importing the application
* Refactor SSH key gen code for import
* Resolve issues around defaultResourceIds, don't commit app name
* Resolve the issue related to duplicate name for app during import
* Minor fixes
* WIP
* Add logic to get unconfigured datasources for the application
* Fix tests
* WIP
* revert datasource related changes
* Add a boolean flag to Datasource entity
* Add a boolean flag to Datasource entity
* Add flag to identify import status
* Set application name before importing from json files in git-import
* update the variable name
* changes per review
Co-authored-by: Abhijeet <abhijeet@appsmith.com>
* Add logic to sync the repo if the path is not updated in env file
* changes per review
* checkout branch locally when the branch is not present in remote
* Add the local checked out branch to list
* fix: changed validation to FUNCTION for the default selected value RadioGroupWidget
* refactor: changed evalued struct msg for radio group default value
* test: added cypress test for checking radiogroup widget with integer value
* test: added jest test to validate the defaultValidation function for radio widget
* refactor: changed the test case title
* chore: updated yarn.lock file
* refactor: addressed the review comments
* refactor: added comment for defaultOptionValidation
* refactor: changed the expected example [QA comment]
* fix: added validationOperationType prop
* Revert "fix: added validationOperationType prop"
This reverts commit 896226fe940621c2c71aa8a9e87831039a9655de.
* fix: added custom validation for the options property
* fix: modififed the custom validation logic
* refactor: modified the cypress test
* refactor: addressed review comments
* refactor: addressed review comments
* refactor: addressed review comments; Updated custom validation for DSV; Update cypress
* refactor: added boolean check for the default selected value
* refactor: addressed review comments
* test: fixed jest test case
When an user signs up, we store the email in lower case. When user logins with oauth2, we fetch user by email ignoring case. This creates a problem if email from oauth is in upper case. As users are registered with lowercase and we're trying to fetch with upper, users are not found.
This PR fetches user by case insensitive emails during oauth login.
* fix: changed cap default to fix ux issue on js toggle
* fix: hard check on capSide hide
* fix: always show capSide if dynamic capType
* docs: label, help text update
* fix: remove hidden condition
* fix: table column name migration update
* test: added test case for migration
* fix: migration version update
* fix: update latest version logic
* fix: cypress updated
* fix: updated test case
* fix: delay added
* fix: test case update
* fix/ one more custom column added
* fixes js object cloning issue
* fix10463- JSObject returning new name of cloned object
Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
* Fix clone JSObject issue where cloned JSObject gets attached to both parent and cloned page
* Race condition for delete action when trying to delete page with JSObject
* Set published collection to null during fork application
* initial implementation, still WIP
* Cleaning up implementation
* added types for evaluation errors and error handling
* remove unneccessary console.log
* better naming for variables
* add unique identifier for error text
* add unique identifier for error text message
* Added new files for entity selector component
* Add error handling to data fetched via API
* Added init eval for schemas in entity selector
* Extracting conditionalOutput for schema from state and passing it to individual schema
* Removed unnecessary loop
* Fixed CSS of ES, added new Icon
* Minor refactor
* fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode
-- Make header options JS convertible
* fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode
-- Fix a broken test case accordingly
* resize n reflow rough cut
* removing warnings
* relatively stable changes
* minor bug fix
* reflow relative collision
* working dp cut
* fix for reflow of widgets closer next to each other
* disabling scroll
* Drag with reflow
* reflow fix
* overlap and retracing fix
* On Drop updates.
* bug when no displacement but resize update.
* temp fix for new widget addition.
* reflow bug fixes
* new widget addition bug.
* stop reflow on leave.
* fix corner case overlap
* update bottom row when reflowed widgets go beyond bottom boundary.
* capture mouse positions on enter
* enable container jumps with faster mouse movements.
* reflow only for snap changes.
* restructured reflow Algorithm
* collision check and bug fixes
* undo redo fix for new widget drop
* resizable fix snapRows fix
* directional stability
* self collision fix
* first round of perf fixes
* update bottom row while resizing and resize-reflowing
* performance fix and overlapping fix
* Remove eslint warning
* remove eslint warning
* eslint warning
* can reflowed Drop Indication Stability
* container jumps and force direction on entering canvas
* fixing scroll on resize jitters.
* reflow when jumping into container.
* reflow ux fixes while leaving container
* resizing fixes.
* fixes for edge move.
* restrict container jumps into reflowed containers.
* container jump direction reflow
* checkbox dimensions fix.
* Excess bottom rows not lost post dragging or resizing widgets.
* fixing the after drop css glitch.
* double first move trigger bug fix.
* stop reflow only if reflowing
* stabilize container exit directions
* using acceleration and speed instead of movement covered to restrict reflow.
* fixing modal drops.
* remove warnings.
* reflow resize styles
* moving acceleration and movement logic to a monitoring effect.
* adding beta flag for reflow.
* fixing jest tests
* Adding analytics to beta flag toggle.
* Adding placeholder for reflow beta screens.
* fixing initial load's screen
* few more crashes.
* force close onboarding for the session.
* fixing bugs in reset canvas.
* Beta flag bug fixes.
* fixing bugs.
* restrict reflow screens during onboarding.
* disabling reflow screens in tests.
* code review comments.
* fixing store based specs.
* fixing cypress failures.
* fixing specs.
* code cleanup
* reverting yarn lock changes
* removing onboarding screens.
* more cleanup and function descriptors
* keeping reflow under the hood.
Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
We've added slug for pages. Each page has a slug which is generated from name automatically. In our get pages API /api/v1/pages/application/<app_id>, the slug names were not included in the Page DTO. This PR adds slug name in this API response.
* Added new condition type
* Added new variables to cater to enable/disable conditionals
* Adding functionality to disable the drop down control
* Added ability to enable/disable to dynamic input text fields
* Updated input text control to have enabled/disabled feature
* Added enable/disable functionality to FixedKeyInputControl
* Added enable/disable func to switch control and stanrdasied var name
* Added disable functionality for file picker
* Added enable/disable functionality to QUER_DYNAMIC_TEXT
* Added new state and object for evaluating conditionals
* Connected the output to the final source
* Updating loading state on the final component
* Tied fetched data to the options of dropdown component
* Added declaration to make API call
* Added loading state for dropdown
* Updated types in reducer
* Added implementation to extract API calls from the response and setting the output
* Removed extra variables
* Moved all calculation logic to the class component
* Refactors and added comments
* Added flag to store when the value fetch fails
* Reduced usage of spread operators
* Add `getStructure` implementation for S3 to return a list of accessible buckets.
* Add command templates for S3.
- List files
- Read file
- Create file
- Delete file
* Remove getDatasourceMetadata implementation as getStructure method can be directly used now.
* move away from RSA-SHA1 to ECDSA-SHA2 protocol for key generation
* Add migration to regenerate SSH keys via new protocol
* use 256 bit signature for the keys
* remove unused imports
* Fix error message for key generation
* feat: Tab widget should have navigation arrows when the tabs don't fit
-- Add scroll navigation control
* feat: Tab widget should have navigation arrows when the tabs don't fit
-- Divide tabs navigator control into both sides of contents
* feat: Tab widget should have navigation arrows when the tabs don't fit
-- Implement navigation per slide
* feat: Tab widget should have navigation arrows when the tabs don't fit
-- Refactor on useEffect dependencies and some calculations
-- Introduce if-else statement for readability and consistency
* feat: Tab widget should have navigation arrows when the tabs don't fit
-- Add class names for scroll navigation controls
-- Narrow the width of Tab widget in dsl
-- Add a Cypress test case for checking the presence of scroll navigation controls
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* This PR fixes the page load action execution order when the actions have been set to run on page load explicitly via the settings tab by the user and its data has not been referenced in any other widget or action. e.g.
- create action1 and action2.
- make action2 dependent on action1 by adding {{action1.data}} in action2's body.
- set both action1 and action2 to run on page load via settings tab. Do not reference action1 and action2 data in any other widget or action.
* feat: Checkbox group should have a select all option
-- Add a new property, isSelectAll
-- Implement its functionality
* feat: Checkbox group should have a select all option
-- Set height to auto for select all control
-- Move isInline and isSelectAll properties below isDisabled
-- Set color for options to GREY_9 and GREY_10
-- Add Cypress test cases for handleSelectAllChange
* feat: Checkbox group should have a select all option
-- Fix on misalignment of select all control if isInline is true
-- Refactor the cypress test cases which is affected by adding select all control
* feat: Checkbox group should have a select all option
-- Set white-space to nowrap
* feat: Checkbox group widget should have a select all option
-- Change helpText for isSelectAll property
* feat: Checkbox group should have a select all option
-- Fix on broken test cases for the select all option
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* This PR adds a limit field which sets the batchSize for aggregate command. This way the user can set the number of documents they want in their Mongo query result.
* limit is set to 10 initially. However, for pre-existing Mongo actions, migration has been added to set this field to 101 - which is the default value that has been used by Mongodb in the absence of any user set value. Ref: https://docs.mongodb.com/manual/tutorial/iterate-a-cursor/
Order of execution was not proper because the dynamic parameters embedded inside url without any trailing slashes and query params did not match with url grouping regex to convert the query params to dsl params.
Fixes#10049Fixes#10055
* FEATURE-6314 : Map Chart Widget
-- Scaffold the widget
* FEATURE-6314 : Map Chart Widget
-- Add a new widget icon
-- Proptotype the property pane for the first time
* FEATURE-6314 : Map Chart Widget
-- Install fusionmaps
-- Draw naive world map for the PoC
* FEATURE-6314 : Map Chart Widget
-- Integrate the limited number of FusionMaps into the widget
-- Bind basic properties and a action into the map
* FEATURE-6314 : Map Chart Widget
-- Comment out the console statements for linting error
* FEATURE-6314 : Map Chart Widget
-- Update dependency versioning
* feat: Map Chart Widget
-- Fix on linting errors, including unused variables, console statement
* Feat: Map Chart Widget
-- Install dependencies from scratch
* fix: increased max chink size allowed in the build config
* Feat: Map Chart Widget
-- Refactor code base according to the changed widget structure
-- Add cleanup for removing event listener
-- Eliminate the unnecessary codes, comments
* Feat: Map Chart Widget
-- Remove unnecessary icon
-- Refactor on constants
* Feat: Map Chart Widget
-- Add a cypress test case for map type changes
-- Add a cypress test case for title change
-- Add a cypress test case for toggling show labels
-- Add a cypress test case for onEntityClick event listener
* feat: Map Chart Widget
-- Scaffold the setup for custom map config
* feat: Map Chart Widget
-- Dynamically import map definition files
* feat: Map Chart Widget
-- Eliminate unnecessary comments
* feat: Fusion Maps Widget
-- Update base dependencies
* partial map chart changes.
* feat: Map Chart Widget
-- Refactor entire code base, removing custom configs
-- Disable prefetching on mapCharts chunk
* feat: Map Chart Widget
-- Comment onEntityClick test case out
* feat: Map Chart Widget
-- Fix on onEntityClick test case
* feat: Map Chart Widget
-- Change the widget icon
-- Rename onEnityClick to onDataPointClick
-- Expose selectedDataPoint
-- Add a new Cypress test case for the toast message on onDataPointClick
* feat: Map Chart Widget
-- Add a new property colorRange
-- Add default values for data and colorRange properties
-- Eliminate unnecessary constant colorRange
* feat: Map Chart Widget
-- update selectedDataPoint meta property unconditionally
* feat: Map Chart Widget
-- Update initial map type config to be consistent with the corresponding property
* feat: Map Chart Widget
-- Add widget icon for entity explorer
* feat: Map Chart Widget
-- Make array elements of data, colorRange properties unique
* feat: Map Chart Widget
-- Prevent re-render when disabling color codes and double-clicking on entities
* feat: Map Chart Widget
-- Declare defaultChartConfigs variable inside component class
-- Replace deprecated substr method with substring
* feat: Map Chart widget
-- Complement validation rules for data property
* feat: Map Chart widget
-- Define rows and cols without using GRID_DENSITY_MIGRATION_V1
-- Change updateDataSet hook by replacing switch statement with object mapping
* feat: Map Chart widget
-- Pull out dataSetMapping from the updateDataSet hook
* feat: Map Chart widget
-- Force click events with regard to onDataPointClick test cases
* feat: Map Chart widget
-- Update fusioncharts and fusionmaps npm packages to the latest version
* feat: Map Chart widget
-- Make contents responsive using CSS styles instead of directly changing width, height attributes of the chart
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* added config to support code split
* splitting config
* moved the window declaration in EE file as its dependency will be updated in EE
* CE: Splitting ApiConstants and SocialLogin constants
* CE: split login page
* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE
* added key icon
* CE: created a factory class to share social auths list
* Minor style fix for social btns
* Updated the third party auth styles
* updated jest config
* updated third party login registry class
* Added new condition type
* Added new variables to cater to enable/disable conditionals
* Adding functionality to disable the drop down control
* Added ability to enable/disable to dynamic input text fields
* Updated input text control to have enabled/disabled feature
* Added enable/disable functionality to FixedKeyInputControl
* Added enable/disable func to switch control and stanrdasied var name
* Added disable functionality for file picker
* Added enable/disable functionality to QUER_DYNAMIC_TEXT
* Added Mono sink calls for git and import application APIs
* TC for import-export
* Update TCs for gitService
* Added git commit and create branch test
* Test added for midway cancellation flow
* Registering new eval types
* Moving code from saga to thread execution
* Added a loading state while thread is working
* Added types and comments
* Code refactor for final render
* Added custom spinner
* Instead of spawning a new thread, working on the same one
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* fix: added min width to wrap long page names
* fix: adjusted the width on editing for contextMenu
* style: moved the editing style in the contextMenu
* refactor: added custom classes
* Connect drop down control to redux state to fetch options dynamically when needed
* Moved whole selection logic to mapStateToProps
* Removing unused imports
* Added API to generate deploy keys and store them in a collection for import flow
* Add tests for the key generation flow
* Move the key generation to helper class
* changes per review
* changes per review
* Sorting component implementation with testing templates to be removed.
* add dsls implementation
* fixes delete item function, removes test cases
* removes test and unwanted files, adds enum to sorting control
* updated the form control from dropdown to dynamic text
Co-authored-by: Aman Agarwal <aman@appsmith.com>
* feat: support iframe.srcdoc in iframe widget
-- Add a new property srcDoc and its change handler
-- Rename handlers
* feat: Support iframe.srcdoc in iframe widget
-- Show error messages only if there are no both of URL and inline HTML
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
- Run all files in the tests folder in sequence
- Better error handling and saving of screenshots
- Organise and refactor code. WIP
- Improve the summary generator
- Add utility method to import an app
- Add a basic performance test on imported app
Co-authored-by: Satish Gandham <satish@appsmith.com>
* feat: #4141 added truncate support into text widget
* fix: updated truncate show logic, cypress added
* fix: updated ellipsis position
Co-authored-by: bhavin <techbhavin@gmail.com>
* Error handling for git limit
* clear cahe of git limit on connect api
* update per review
* check the repo is public before checking for the limit
* changes per review
* check if the repo is public or private during connect flow
* fix issues with sync branches
* Add sucess error handler
* changes per review
* add missing return statement
* remove unused import statements
* Change recaptcha key and type and add suggestion for recaptchatoken
* Add recaptchaToken property as target for auto completion cypress tests
* Added cypress test to validate recaptcha v2 can be selected in button widget property pane
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* fix:9648 Mongo update All issue-In Progress
* fix: Mongo Multi update query fail fixes
* Added updated testcases that got affected by the code change
* Changes reverted as per review comments
- Checkbox group widget
- MultiSelecttree widget
- Multiselect widget
- dropdown widget
- radio group widget
- single select tree
- switch group widget
* Fix currency number formating and add unit tests
* Fix Input currency type cypress test
* Fix currency number formating and add unit tests
* Fix Input currency type cypress test
* Add comments for utilities formatCurrencyNumber and limitDecimalValue
* Fix currency number formating and add unit tests
* Fix Input currency type cypress test
* Fix Input currency type cypress test
* Add comments for utilities formatCurrencyNumber and limitDecimalValue
* Fix upstep and downstep button action for formated currency input
* remove crendentials from cypress.json
* Fix input currency test flakiness
* Fix cypress test for currency input type
Fix formatCurrencyNumber function and added more unit tests
* Fix cypress test for currency input
Handle group separator and decimal separator when formatting and deformatting input for currency type
* remove console.log
* Handle formatting changes for default text
* Format input widget value for currency to handle default text
* remove unused import
* Add unit tests for getGroupSeparator and getDecimalSeparator functions
* add function to get user locale
* use preventDefault in input increment/decrement button click
* Use getLocale function, use String function
* use Number function for type conversion
* fix number to string type
* Handle 0 value for numbers
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* disable submit button when date is out of bounds
* Remove comment from derived.js function as comments are not allowed for parsing
* Fix table client side search cypress test
* validate date again min/max irrespective of isRequired property
