Commit Graph

4785 Commits

Author SHA1 Message Date
Arsalan Yaldram
45da98f1dd
Merge pull request #10935 from appsmithorg/fix/10766-rating-inactive-color
fix: Rating Widget inactive-color.
2022-02-18 17:54:44 +05:30
yatinappsmith
bd7ae1f924
test: Added test event driver (#11222)
* Added test event driver

* changed port to 28017

* updated credentials

* updated password for postgres

* Update forkedApp.json

* fixing ImportExportForkApplication_spec

* fixing ImportExportFork_spec

* updating testdata

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-02-18 17:45:05 +05:30
Satish Gandham
bcf6e616f5
Fix an issue with saving run data (#11242) 2022-02-18 16:03:39 +05:30
albinAppsmith
9fd6292c32
fix: Appsmith Design System fixes and improvements (#11011)
* * Added index file for Appsmith Design System
* Datasource context menu, changed position of delete

* * page setting icon color fix

* * filepicker image padding added

* * Debug button icon change

* * share modal design changes according to Appsmith Design System

* * Release notes modal - added see more functionality

* * Navbar header arrow fix

* * Padding fixed in share modal

* * Changed share icon in applications page

* * Header height changed to 32px from 34px

* * Removed icontab component index file of ADS

* * Added AppPageLayout cy test in ignore list
2022-02-18 15:21:02 +05:30
Ayangade Adeoluwa
ead4d875fa
feat: add confirmation for Datasource deletion operation (#11180)
* add confirmation for Datasource, refactor other components

* fix failing cypress tests

* fix Mongo_spec failing test
2022-02-18 07:58:36 +01:00
f0c1s
c03ecf2e13
fix: update git connect modal (#11249)
Show notification banner on SSH key generation and regeneration
Remove BETA tag from Git Connection
2022-02-18 12:13:07 +05:30
Confidence Okoghenun
7ebaa577a3
chore: Updates JS editor default text (#10912) 2022-02-18 07:11:12 +05:30
albinAppsmith
39e28f4e1b
feat: Homepage mobile UI (#10255)
* * Added hooks for detecting device
* fixed partial header issues

* * mobile UI completed

* config URL changed

* * bug fix

* * bug fix

* * mobile - on tap of app card launch app

* * conflict fix
* removed context menu from app card

* * homepage cy fix
2022-02-17 22:08:36 +05:30
Favour Ohanekwu
46810e832a
fix: remove dependencies from trigger fields (#11163) 2022-02-17 21:27:23 +05:30
f0c1s
a2e2bf0055
chore: introduce lookup tables inplace of switch (#11228) 2022-02-17 17:49:39 +05:30
Paul Li
12dad5737d
fix: Issues and Enhancements in the camera widget (#10943)
* fix: Issues and Enhancements in the camera widget

-- Fix on an image stretching issue when taking a picture
-- Set background to black
-- Add onImageSave, onVideoSave Actions
-- Rename Camera to Image

* fix: Issues and Enhancements in the camera widget

-- List all device info only when one or more MediaStreams are active

* fix: Issues and Enhancements in the camera widget

-- Always keep camera aspect ratio when resizing

* fix: Issues and Enhancements in the camera widget

-- Add a Cypress test case for onSaveImage property

* Increased wait!

* Camera case failure locator fix

* Camera case locator fix

* Promises restWidget moved to last!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-17 20:10:32 +08:00
Paul Li
f3360d814e
fix: Text widget shows a horizontal scroll on center and right alignment (#11189)
-- Set overflow-x to hidden on StyledText
2022-02-17 20:01:15 +08:00
rahulramesha
13a0258c9c
changing reflow threshold to 10/10 from 20/20 (#11210) 2022-02-17 15:07:22 +05:30
f0c1s
5aba318f67
chore: remove pointer cursor from dialog header icons. (#11216) 2022-02-17 12:36:05 +05:30
Hetu Nandu
8599130176
fix: Wait for evaluation before completing resetWidget and storeValue functions (#11178) 2022-02-17 10:01:59 +05:30
Abhinav Jha
938edd5284
chore: Remove old way of adding feature flags (#11213)
* Remove optimizely, as it isn't being used anymore from the frontend codebase

* Remove optimizely references form netlify config, vercel config, index.html, docker script, nginx templates and example .env file
2022-02-16 19:57:58 +05:30
Satish Gandham
4bff451735
chore: persist performance test results (#11208)
* Persist performance run data to supabase

* Remove stray comment

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-16 19:55:33 +05:30
Arsalan Yaldram
8c83cf767b
Merge pull request #10919 from appsmithorg/fix/10780-circular-progress-icon
fix: Add circular progress svg to WidgetIcons.tsx
2022-02-16 17:03:26 +05:30
Daniel
5994e87648
fix: fix spacing for encrypted tag for form control (#11063) 2022-02-16 11:12:00 +00:00
f0c1s
64669f5e45
feat: ssh key regeneration (#11018)
feat/ssh-key-regeneration - implementation

- moved copy icon inside the input box
- added regenerate ssh key function on git connection
- remove learn more and paste text from top
- introduce SSH Key label
- introduce ads/NotificationBanner
- update NotificationBanner integration
- jest tests
- system notification on key regeneration
- use @appsmith for constants/messages
- update imports
- remove optional chaining

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-02-16 10:15:35 +00:00
Arsalan Yaldram
81e79af04f
Merge pull request #10954 from appsmithorg/fix/10697-rating-widget-flickering
fix: rating widgets flickering when value is reduced.
2022-02-16 13:27:21 +05:30
Arsalan
9c414355a2 fix: added true option as default for resetWidget 2022-02-16 11:54:37 +05:30
Ayangade Adeoluwa
b69f85891f
fix: ensure backward compatibility with older Actions. (#11184) 2022-02-16 08:47:13 +05:30
Vicky Bansal
10cb49b2ee
fix: add ellipsis when the page name is longer than width (#10667) 2022-02-16 00:16:37 +05:30
Vicky Bansal
e77ab8b06c
fix: add ellipsis to table search input when blur (#11020) 2022-02-16 00:16:21 +05:30
Favour Ohanekwu
a659cba4ea
chore: upgrade jshint to fix security alert (#11179) 2022-02-15 23:23:19 +05:30
Aswath K
f610c749f9
feat: Step control keyboard navigation (#11059)
* Make step control keyboard accessible

* Add Jest tests
2022-02-15 17:55:11 +05:30
Arpit Mohan
286864eb3d
feat: Support body in GET API requests (#7127)
* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* adds apiContentType to actionConfiguration.formData object

* Handling apiContentType property in Rest API formData

* change apiContentType when user types content-type value and switches http method

* makes api editor as similar as possible to postman, project postman.

* Correcting the import in ApiEditorConstants

* Resolved all merge conflicts

* replay DSL functtionality

* removes unneccessary files from worker

* Fixes type declarations, naming e.t.c.

* fix server side merge conflicts

* fix client side merge conflicts

* fix failing cypress tests

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
2022-02-15 11:13:48 +00:00
Tolulope Adetula
7837b568af
fix: select Widget resize (#11048) 2022-02-14 23:34:53 -08:00
Tolulope Adetula
fd4c99ccf2
fix: dropdown propert control (#11041) 2022-02-14 23:34:17 -08:00
Nidhi
1868675349
feat: Self-signed certificates for REST APIs (#11043)
* feat: Self-signed certificates for REST APIs

* Changed scope for netty dep
2022-02-15 06:54:26 +00:00
Ankita Kinger
0998b441e7
refactor: superadmin settings UI/UX (#11130)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

* css changes for admin settings page and breadcrumb removal

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2022-02-14 17:25:12 +05:30
Ankita Kinger
c29c2f745e
fix: Comment icon gets hidden behind tabs on Tab widget (#11019)
* fix for z-index issue on comments icon

* css changes

* fixed failing cypress tests
2022-02-12 08:28:13 +05:30
Pranav Kanade
b778b83ac4
refactor: admin settings (#9906)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-02-11 23:38:46 +05:30
Ayangade Adeoluwa
44ce1d4b5a
fix: fixes apiEditor url overflow, indicates active datasource in datasour… (#10663)
* fixes apiEditor url overflow, indicates active datasource in datasources list

* Adds custom tooltip to datasource url, and optimizes the performance of ApiEditor form

* hide the custom tooltip whenever there is a default datasource config on the page

* Making the implementation more reusable

* fix failing cypress tests and increase delay for tooltip

* A better implementation and also making the logic more reusable

* remove comments

* Fix prettier issues due to merge with release
2022-02-11 12:02:47 +01:00
Ayangade Adeoluwa
c06c8b817e
fixes numbering system for dynamic bindings in evaluated popup text (#11005) 2022-02-11 11:53:50 +01:00
Apeksha Bhosale
980c8cbf57
fix: added new library and reduced function calls for global data (#11001) 2022-02-11 16:22:27 +05:30
balajisoundar
85cc3f3497
feat: Provide option in phone input widget to turn off auto formatting (#10832) 2022-02-11 15:39:38 +05:30
Tolulope Adetula
c992bd5285
feat: add more plugins to rich text editor (#11052) 2022-02-11 13:52:35 +05:30
arunvjn
9e0c0a1598
Sorted actions in explorer in alphabetical order to give them a predictable position (#10777) 2022-02-11 07:30:30 +00:00
Aswath K
fb83b0fbc6
feat: Make Button Tab keyboard accessible (#10873) 2022-02-11 00:30:20 +05:30
Favour Ohanekwu
a1a774f7fe
fix: js editor not showing falsy values 🐞 (#10946) 2022-02-10 23:33:12 +05:30
Favour Ohanekwu
1ed7e9086c
keep linting in trigger field in sync with the state of the datatree (#10941) 2022-02-10 23:32:16 +05:30
Favour Ohanekwu
223be6c057
fix lint tooltip getting clipped (#10899) 2022-02-10 18:40:36 +01:00
balajisoundar
e67474a4f3
fix: Input, Phone and Currency input widgets valid property validations (#10966)
- When the user removes an expression from the validation property of
  input widget, its value becomes `""`. And in boolean validation
  function we treat this empty string as false. so Input widget
  ends up with isValid false and we show an error border around the
  Input. so we are setting a default value true, so when there is
  no expression it evaluates to true.
2022-02-10 17:06:18 +05:30
Aswath K
9597c82f7c
feat: keyboard accessible multi-select dropdown, action selector and text input (#10622)
* feat: Add keyboard navigation to multiselect dropdown (#10397)

* feat: Make Action Selector keyboard accessible (#10005)

* feat: keyboard accessible text / code input (#10641)

* {Space} as an alternate option to make code editor editable
2022-02-10 16:42:44 +05:30
Satish Gandham
594e02edbd
chore: Increase cooldown time after app import for the app to load. #UI-Performance-infra (#10845)
* Code cleanup and fix typos

* Increase the wait time after app import

Increase the wait time after app import for the categories to load

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-10 16:16:55 +05:30
Pawan Kumar
d4eeff8fcc
fix: Header tags are not styled correctly in the Text widget (#10949)
* fix text widget styles

* add font weight in headings

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-02-10 12:25:33 +05:30
balajisoundar
8f383ca8ea
fix: Phone Input and Input widget not getting reset on submit (#10860) 2022-02-09 17:33:10 +05:30
Aman Agarwal
9894a6522c
feat: added datasource icon on left of entity name, revamped name editor (#10821)
* feat: added datasource icon on left of entity name, revamped name editor

* fix: updated the hardcoded message strings to use message.ts

* fix: types of variables
2022-02-09 17:11:47 +05:30
Paul Li
ce42dcb00b
fix: Map pin does not center when location is changed and centering option is turned on (#10296)
* fix: Map pin does not center when location is changed and centering option is turned on

-- Update center meta property when defaultMarkers or mapCenter properties were changed

* fix: Map pin does not center when location is changed and centering option is turned on

-- Force the last marker to be centered
2022-02-09 18:39:07 +08:00
balajisoundar
fab552cafa
chore: Extend the list of widgets that cannot be used inside the List… (#10928) 2022-02-09 12:45:10 +05:30
Ankita Kinger
81760a94fc
Merge pull request #10942 from appsmithorg/hotfix/disable-signup-config
fix: Added disable signup form config
2022-02-09 12:35:16 +05:30
Vicky Bansal
e4e7c59bc2
fix: disable closing dropdown on space (#10945) 2022-02-09 12:32:57 +05:30
Sumit Kumar
aa2290405d
fix: fix refresh token flow in REST API OAuth (#10875)
Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
2022-02-09 09:38:58 +05:30
arunvjn
be1b5a5db3
Re-focus widgets search bar when the search text is cleared (#10763) 2022-02-09 04:00:56 +00:00
haojin111
0288f79b70
fix: added missed analytic events for git sync (#10953) 2022-02-08 21:46:16 +05:30
Abhinav Jha
9d21ccf52f
fix: Remove references of messages.ts in worker files (#11004) 2022-02-08 20:53:25 +05:30
Tolulope Adetula
453974b18e
fix: Multiselection in table widget (#10838)
* fix: Multiselection in table widget

* fix: add test cases
2022-02-08 06:41:25 -08:00
Ayangade Adeoluwa
21018c640f
fix: fixes uqi component issues (#10829)
* fixes uqi component issues

* fix dropdown container width issue
2022-02-08 12:51:41 +01:00
Abhinav Jha
aee5816a54
fix: limit validation errors in debugger (#10886)
* Add a limit to the number of error messages sent from validations to be rendered in the debugger
2022-02-08 17:13:25 +05:30
Ayangade Adeoluwa
da655b5748
fix margin top issues with checkbox form controls (#10930) 2022-02-08 11:29:17 +00:00
Arsalan
048d8ac349 fix: Rating widget flicker, when value is changed. 2022-02-08 12:52:43 +05:30
Ankita Kinger
1c8d804d88 added config for signup disabling 2022-02-07 20:48:44 +05:30
Arsalan
903b2cec4d Added grey as the default inactive color. 2022-02-07 17:28:11 +05:30
Arsalan
c0b290d0b6 Add circular progress svg to WidgetIcons.tsx 2022-02-07 11:22:55 +05:30
akash-codemonk
dbf8568c7b
fix: hide the image column in guided tour table (#10709) 2022-02-07 10:06:33 +05:30
NoxiousPenguin
abb3aebbba
chore: replaced == and != with === and !=== (#10733) 2022-02-05 11:11:15 +05:30
Rishabh Rathod
f91f860d1e
Add brotli and gzip compression (#10869) 2022-02-05 01:52:31 +05:30
balajisoundar
c9f65d080a
fix: skip bad table migration thats breaking computed columns we di… (#10897) 2022-02-04 23:07:22 +05:30
Anand Srinivasan
c2a6e089db
fix: passing params from JS to API/SQL query (#10826)
* Revert "fix: revert this.params solution (#10322)"

This reverts commit 2bcd73e41d.

* replace 'this.params' with 'executionParams'

* replace 'this?.params' also with 'executionParams'

* fix unit test lint errors

* added unit tests for params handling

* evaluateActionBindings unit test - add default value case

* comments update

* remove un-necessary `executionparams` assigment to `evalTree`
2022-02-04 17:58:46 +05:30
Rishabh Rathod
1bcf344154
fix: Race condition issue of meta reducer update (#10837)
* Fix race condition issue of meta reducer update

* refactor comment

* Fix logic to update meta state
2022-02-04 17:52:25 +05:30
Ayangade Adeoluwa
aa129fc26b
feat: adds Headers tab to the Api response view (#10807)
* adds Headers field to the Api response view

* show empty object if headers not present
2022-02-04 12:32:38 +01:00
Vicky Bansal
b7ebc7501e
fix: Column tile reposition on focus state of Input element inside property pane configuration for Table and Tabs widget (#10046) 2022-02-04 16:29:54 +05:30
Rishabh Saxena
ebb257bac2
chore: update cta text and doc url on the disconnect modal (#10872) 2022-02-04 12:40:36 +05:30
Tolulope Adetula
c82fab975d
fix: table column visibility (#10808) 2022-02-04 08:09:37 +01:00
Paul Li
6b45805f21
fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.) (#10724)
-- Set trimValue prop to false with property controls such as TabControl, MenuItemsControl, ButtonListControl, PrimaryColumnsControl
2022-02-04 13:46:21 +08:00
Apeksha Bhosale
a66b8be886
fix: enable response tab in js editor even if it has warnings (#10866) 2022-02-03 21:29:46 +05:30
rashmi rai
e73ccc7f25
fix: props is now required in type Validator (#10854) 2022-02-03 15:27:08 +05:30
Tolulope Adetula
94dbd612c3
fix: onOptionChange on TreeSelects and fix Switch Toggle (#10632)
* fix: treeSelect onoptionChange

* fix: revert cypress

* fix:switch widget toggle

* fix: remove Important from styling
2022-02-02 23:57:49 -08:00
Keyur Paralkar
45152272a6
fix: added sentry exception for invalid DynamicBindingListPath (#10790)
* fix: added sentry exception for invalid DynamicBindingListPath

* refactor: updated the error message

* test: update unit test case for dynamic binding path error

* fix: addressed review comments

* fix: removed widgetFactory and propertyPane code for invalidDynamicBindingPath function
2022-02-03 11:22:14 +05:30
Bharat Patodi
743d6cb00d
chore: Replace equality and inequality operators with their strict versions (#7585)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-03 09:42:38 +05:30
Satish Gandham
fa32411383
chore: Perform perf tests on a large app (#10831)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-03 00:25:10 +05:30
Daniel
d29016590b
Merge pull request #10437 from appsmithorg/fix/name-of-undefined-datasource
fix: Name of undefined error in datasource catch Block
2022-02-02 19:53:11 +01:00
albinAppsmith
1c7a4f4a48
fix: Execute query overflow scroll issue (#10836) 2022-02-02 23:50:45 +05:30
Vicky Bansal
a39176dc38
fix: add keywords to the validation list (#10690) 2022-02-02 21:05:42 +05:30
Segun Daniel Oluwadare
a91b7c2a2b fix: add default value 2022-02-02 16:03:34 +01:00
Danieldare
cf577f8751 fix undefined error 2022-02-02 16:03:33 +01:00
Daniel
ec1c3c9fb8
Merge pull request #10664 from appsmithorg/fix/db-section-overlap
fix: Datasources section overlap
2022-02-02 15:49:03 +01:00
Tolulope Adetula
bb2f7da823
feat: Select and Multiselect V2 (#10359)
* fix: Select V2

* Fix: CI Fail

* fix: failing test

* fix: failing test

* Fix: MultiSelect

* Fix: loading issue

* Fix: loadin state

* Fix: loading

* fix: failing test

* fix: evaluation tests

* Fix: failing tests

* Fix: failing test

* fix: failing tests

* Fix: Failing tests

* fix: select All

* fix: filtering

* Fix: filtering

* fix: refactor Select widget

* fix: hide MultiSelect

* fix: select options

* Fix: failing tests

* fix: failing tests

* Fix: issues

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* fix: PR reviews

* Update EntityDefinitions.ts

* Fix: issues

* fix: console

* fix: QA issues

* fix: options issues

* fix: add widget icons

* fix: update Selectv2

* empty commit to fix CI

* fix: failing test
2022-02-02 06:15:07 -08:00
Daniel
45816c51f1
Merge pull request #10652 from appsmithorg/fix/delete-icon-s3-amazon-page
fix: Change delete icon in s3 amazon where clause component
2022-02-02 04:59:45 -08:00
Vicky Bansal
b99a42acdf
fix: add pre-filled option on adding an option to a checkbox or radio button (#10544) 2022-02-02 17:40:40 +05:30
Danieldare
54e2f2e9b1 fix: revert delete icon name 2022-02-02 12:00:01 +01:00
Danieldare
cfc89819a8 fix: remove unused icon 2022-02-02 12:00:01 +01:00
Danieldare
43b77d08af fix: change delete icon 2022-02-02 12:00:01 +01:00
Danieldare
532ec5768c fix: datasources section overlap 2022-02-02 11:54:56 +01:00
Ankita Kinger
da68425a57
Merge pull request #10801 from appsmithorg/hotfix/team-settings-page
fix: Multiple API calls on Team settings page for same user role selection
2022-02-02 15:16:39 +05:30
rahulramesha
d1de691790
change reflow BETA Card (#10789) 2022-02-02 15:16:06 +05:30
Abhinav Jha
e08c7e66d4
fix: Purge orphaned paths from dynamic path lists in widgets (#10803)
- Paths in dynamicBindingPathList and dynamicTriggerPathList which don't exist in the widget, may cause issues later in the lifecycle of an application. Purging these orphaned paths during property updates.
2022-02-02 14:55:16 +05:30
Rishabh Saxena
812da166e0
chore: beta tags for git sync (#10774) 2022-02-02 13:22:37 +05:30
Tolulope Adetula
ea1ba54603
fix: test case (#10804)
* fix: test case

* fix: dsl

* fix: DSL

* fix: test
2022-02-01 23:52:05 -08:00
Parthvi12
283ef050d4
test: Fixed flaky tests Replay_editor and Table_navigateTo_validation_spec (#10772)
* Fixed flaky tests Replay_editor_spec and TableWidget_NaviagateTo_Validation_spec

* adding fix for ActiveDatasource.spec
2022-02-02 10:52:10 +05:30
ankurrsinghal
c349f2f9f5
Merge pull request #10688 from appsmithorg/enhancement/focus-widget-title-on-f2
feat: added a keydown listener to focus property pane title on pressing f2
2022-02-02 10:51:46 +05:30
arunvjn
52f979cbf6
Fixes inconsistent rename behaviour for datasources (#10767) 2022-02-02 05:21:25 +00:00
Ankita Kinger
98dea5e64a updated conditional check 2022-02-01 18:19:07 +05:30
Ankita Kinger
6ef90973c5 Merge branch 'release' of https://github.com/appsmithorg/appsmith into hotfix/team-settings-page 2022-02-01 18:06:27 +05:30
Ankita Kinger
34da849cbd avoiding multiple API calls on selecting same role for a user under manage users 2022-02-01 18:06:10 +05:30
Bhavin K
4e28b4887c
Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770)" (#10786)
This reverts commit df1ee35992.
2022-02-01 15:43:20 +05:30
Tolulope Adetula
8729c2b435
fix: select treeselect value validation (#10760)
* fix: Select adn treeSelect validation

* fix: remove cy.wait()
2022-02-01 10:54:16 +01:00
Bhavin K
df1ee35992
fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770) 2022-02-01 13:37:52 +05:30
Favour Ohanekwu
caca4131e7
fix: Evaluate PrivateWidgets to fix list widget children evaluation issue (#10737) 2022-02-01 10:48:57 +05:30
Vicky Bansal
8e174f7316
chore: Fix recaptcha script not loading issue (#10764) 2022-01-31 21:25:58 +05:30
Rishabh Saxena
2e92b3a05e
chore: increase axios timeout for git specific APIs (#10732) 2022-01-31 09:48:58 +05:30
Rishabh Saxena
c0285eb168
chore: use documentation link from the error response for git errors (#10662) 2022-01-29 13:56:27 +05:30
albinAppsmith
5cfe12bcea
feat: Entity explorer UI redesign (#9811)
Co-authored-by: arunvjn <arun@appsmith.com>
2022-01-29 12:56:19 +05:30
Daniel
20f5a7f7d3
Merge pull request #10681 from appsmithorg/fix/authenticated-api-query-parameters
fix: Add query parameters to Options/Form
2022-01-28 05:03:33 -08:00
Rishabh Rathod
b61ceab94b
fix: Add meta to eval cycle and update it when default changes (#10401)
* Rearrange data tree widget factory

* Remove existing handling of default value override

* Altternate way of meta property override

* Fix tests

Co-authored-by: hetunandu <hetu@appsmith.com>
2022-01-28 16:40:05 +05:30
Favour Ohanekwu
d5a459be30
fix: show lint warning when unused variable is present in code (#10599) 2022-01-28 09:18:19 +01:00
Bhavin K
45d3704dda
fix: icon button remove default green (#10573) 2022-01-27 19:07:13 +05:30
Ankur Singhal
842828b187 added a keydown listener to focus property pane title on pressing f2 2022-01-27 16:40:57 +05:30
Yash Vibhandik
35d46b42d4
fix: #10428 styling support in popup (#10487) 2022-01-27 15:37:05 +05:30
Favour Ohanekwu
db3e29e15d
fix: Fix crash on broken list widget (#10670) 2022-01-27 15:31:24 +05:30
rashmi rai
10b3fe3800
feat: Validations for Action Forms (#10457) 2022-01-27 15:20:05 +05:30
Rishabh Rathod
d3c2833c8c
chore: remove defaultSelectedFiles (#10586)
- It is not being used anywhere
2022-01-27 09:40:51 +00:00
Danieldare
5cfc81a9d3 fix: add query parameters to options 2022-01-27 10:04:27 +01:00
Aman Agarwal
aab77b8ebb
fix: Memoized the Form Control Component reducing unwanted re-rendering (#10553)
* fix: reduced unnecessary re-rendering of form components

* fix: memoized form control and moved config errors to selector logic
2022-01-27 14:09:21 +05:30
Tolulope Adetula
b89c3100e4
fix: RTE required field (#10629) 2022-01-27 00:37:50 -08:00
Bhavin K
dfaddfbce4
fix: Datepicker closeOnSelection will now remain true by default for new widget drops(#10479) 2022-01-27 11:42:39 +05:30
Daniel
d553495d23
Merge pull request #10321 from appsmithorg/fix/active-datasoure-flash-page
fix: Active datasource page flashes to user upon clicking the Save DataSource Button.
2022-01-26 11:42:36 +01:00
Keyur Paralkar
5afff85e8d
fix: changed validation to FUNCTION for the default selected value RadioGroupWidget (#10020)
* fix: changed validation to FUNCTION for the default selected value RadioGroupWidget

* refactor: changed evalued struct msg for radio group default value

* test: added cypress test for checking radiogroup widget with integer value

* test: added jest test to validate the defaultValidation function for radio widget

* refactor: changed the test case title

* chore: updated yarn.lock file

* refactor: addressed the review comments

* refactor: added comment for defaultOptionValidation

* refactor: changed the expected example [QA comment]

* fix: added validationOperationType prop

* Revert "fix: added validationOperationType prop"

This reverts commit 896226fe940621c2c71aa8a9e87831039a9655de.

* fix: added custom validation for the options property

* fix: modififed the custom validation logic

* refactor: modified the cypress test

* refactor: addressed review comments

* refactor: addressed review comments

* refactor: addressed review comments; Updated custom validation for DSV; Update cypress

* refactor: added boolean check for the default selected value

* refactor: addressed review comments

* test: fixed jest test case
2022-01-26 12:48:13 +05:30
Shrikant Sharat Kandula
6accb9e364
fix: Use CDN for all assets (#10417)
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-26 02:19:43 +05:30
Ashok Kumar M
2a8e37bf3b
feat: Sliding Canvas for Dragging and Selection (#9983)
* Move existing canvas's to CanvasArenas folder

* moving hooks to canvas arenas folder.

* Sticky canvas implementation.

* fixing specs(WIP)

* dip

* fixing test cases.

* removing comments.

* fixing build

* renaming for readability.

* adding folder for canvas based sagas.

* Resolve conflicts.

* fixing failed cases.

* fixing cypress cases.

* fixing bugs introduced coz of drag and drop.

* fixing bugs.

* few more bug fixes in draw to select.

* mouse pointer default when drag to select.

* bug fix.

* dip

* integrating intersection api.

* dip need to adjust offset

* fixing offset issues.

* readability fix

* rebase bug fixes.

* bug fix.

* adjust canvas slider on mouse over.

* unwanted changes.

* left offset fix + removing dead code.

* fixing bugs.

* fixing broken test cases.

* addressing code review comments.
2022-01-25 20:58:31 +05:30
NandanAnantharamu
91986714f6
test: commenting out Typescript tests (#10619) 2022-01-25 20:21:54 +05:30
NandanAnantharamu
5245984ff8
test: Table Download test (#10571)
* Table Download test

* updated test
2022-01-25 19:37:51 +05:30
Confidence Okoghenun
98a8aab728
feat: Adds code hint for JS promises in JS Object editor (#10570) 2022-01-25 19:34:10 +05:30
akash-codemonk
94d37f55dd
feat: improved guided tour (#9125) 2022-01-25 19:26:52 +05:30
Ankita Kinger
e30fec9109
fix: Incorrect member list sorting on user roles (#10594) 2022-01-25 19:25:32 +05:30
Bhavin K
b52ec44966
fix: changed cap default to fix ux issue on js toggle (#10424)
* fix: changed cap default to fix ux issue on js toggle

* fix: hard check on capSide hide

* fix: always show capSide if dynamic capType

* docs: label, help text update

* fix: remove hidden condition
2022-01-25 13:54:36 +00:00
Bhavin K
cd02572374
fix: table column name migration update (#10383)
* fix: table column name migration update

* test: added test case for migration

* fix: migration version update

* fix: update latest version logic

* fix: cypress updated

* fix: updated test case

* fix: delay added

* fix: test case update

* fix/ one more custom column added
2022-01-25 13:54:13 +00:00
Apeksha Bhosale
5f91f2d20f
added functions while checking isAsync (#10425) 2022-01-25 13:53:53 +00:00
ankurrsinghal
3e0749c82f
fix: hover highlight for menu item (#10610)
Co-authored-by: Ankur Singhal <ankursinghal@Ankurs-MacBook-Pro.local>
2022-01-25 15:15:52 +05:30
rahulramesha
302cdf0d03
fix: Reflow onboarding typo fix (#10543)
* fixing reflow on boarding typo
2022-01-21 20:08:47 +05:30
Favour Ohanekwu
1b858bcf5c
fix: Remove private widgets from autocompletion (#10535) 2022-01-21 13:08:40 +01:00
Ashok Kumar M
6bc1bdd5e1
fix: Fixing GRID_DENSITY_MIGRATION_V1 based configs and adding test cases. (#10488) 2022-01-21 15:49:10 +05:30
Bhavin K
9976cb5018
fix: handle no color as transperant (#10498) 2022-01-21 15:31:30 +05:30
rahulramesha
1b2295d31f
react spring upgrade (#10427)
Upgrading react-spring
2022-01-21 11:42:46 +05:30
akash-codemonk
978e820b9f
fix: page settings invoking onClick on drag (#10449) 2022-01-21 11:35:27 +05:30
Leo Thomas
58b376fa9b
fix: Fix 10463 js object cloning issue (#10523)
* fixes js object cloning issue

* fix10463- JSObject returning new name of cloned object

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-01-20 22:02:11 +05:30
Favour Ohanekwu
f7ce277e4c
fix: currentItem showing error in debugger for list widgets (#10338) 2022-01-20 11:59:03 +01:00
rahulramesha
b6bcfec549
chore: Reflow Info Card (#10481)
* removing reflow flag and adding Reflow Info card

* verbage correction

* adding reflow docs link
2022-01-20 14:59:09 +05:30
Aishwarya-U-R
067d18a84e
test: Skipping JSObjectToListWidgetSpec.ts until open bug is fixed (#10477)
This PR skips tests from JSObject_To_ListWidgetSpec.ts until Bug #10284 is fixed
2022-01-19 17:37:30 +05:30
Bhavin K
832622a221
fix/datepicker derived property condition updates (#10353)
- fixed mix / max date validation error on datepicker
2022-01-19 16:29:08 +05:30
Parthvi12
69fabb908b
Automated mongoDB app with CRUD operations (#10409) 2022-01-19 13:55:14 +05:30
Bhavin K
63ce7e108a
fix: changed height calc for embeded app page (#10440) 2022-01-19 11:48:11 +05:30
Tolulope Adetula
70cff3c373
fix: Copy and paste (#10422)
* fix: Copy and paste

* fix: test cases

* fix: onPaste action

* Update index.tsx
2022-01-18 19:54:34 +01:00
Parthvi12
a8eb1d838b
test: Adding fix for Chart_Widget_Loading_spec (#10462)
* Adding fix for Chart_Widget_Loading_spec

* adding wait after reloading

* commenting delete datasource part

* updating test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-01-18 21:07:29 +05:30
Arsalan Yaldram
de3298ae9c
feat: Added Circular progress Widget (#10244)
* Added Circular Porgress Widget

* Updated the svg icon for the widget.

* Added strokeLineCap prop to the widget.

* Added Rounding for percent values.

* Review Changes completed. Removed un-necessary props, added Default Values.

* App crashes when a modal has a filepicker? (#10376)

(cherry picked from commit f646eeafc1)

* Revert "chore: Don't take client subscription into account for fork application (#10220)" (#10375)

This reverts commit 814a7d57f9.

* Added widget entries in TernServer files.

* Added Radial Separators.

* Removed Steps Functionality.

* Added isJSConvertible to progress property.

* Resovled eslint error under EntityDefinition.ts

Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
2022-01-18 14:36:14 +00:00
Ayangade Adeoluwa
28a3f59452
feat: Displays validation errors corresponding to a particular form control. (#10365)
* initial implementation, still WIP

* Cleaning up implementation

* added types for evaluation errors and error handling

* remove unneccessary console.log

* better naming for variables

* add unique identifier for error text

* add unique identifier for error text message
2022-01-18 13:09:04 +01:00
Ayangade Adeoluwa
f9e8c84fcd
fix: Fixes UI inconsistencies on the app (#10433)
* Fixes UI inconsistencies on the app

* using a better implementation
2022-01-18 10:09:34 +01:00
balajisoundar
02785b90b2
feat: Input, Phone no., Currency input widget (#10259)
* feat: Input, Phone no., Currency Widget

* cypress tests, jest test, QA and CR callouts

* fix tests

* Cypress and jest test fixes
2022-01-18 13:22:24 +05:30
Keyur Paralkar
d88022939e
fix: added loading state for chart widget (#10262)
* fix: added loading state for chart widget

* test: added cypress tests

* refactor: moved the loading logic from widget to component
2022-01-18 13:21:28 +05:30
akash-codemonk
541e105b07
fix: Signposting intro modal UI issue (#10403) 2022-01-18 12:42:52 +05:30
Ayush Pahwa
a6d2d6fd89
feat: 5705 entity selector component (#10400)
* Added new files for entity selector component

* Add error handling to data fetched via API

* Added init eval for schemas in entity selector

* Extracting conditionalOutput for schema from state and passing it to individual schema

* Removed unnecessary loop

* Fixed CSS of ES, added new Icon

* Minor refactor
2022-01-18 07:10:58 +00:00
Pawan Kumar
8e03dae88e
fix http issue in filepicker v1 too (#10426)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-01-17 10:34:45 +00:00
Parthvi12
4871035742
test: Adding fix for Table_widget_add_button spec's test (#10423)
* Adding fix for Table_widget_add_button spec's test

* updating test

* commenting changing column type to button in second test
2022-01-17 15:00:58 +05:30
Paul Li
fa29fef4a5
fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode (#10356)
* fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode

-- Make header options JS convertible

* fix: When all the rows are hidden the user must not be displayed with number of records or pages in the Deploy mode

-- Fix a broken test case accordingly
2022-01-16 15:04:24 +08:00
dependabot[bot]
bfc6b1f29b
chore: bump follow-redirects from 1.13.0 to 1.14.7 in /app/client (#10371)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.13.0...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-15 12:42:25 +05:30
dependabot[bot]
a033cd3a19
chore: bump postcss from 7.0.35 to 8.2.13 in /app/client (#10246)
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 8.2.13.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.35...8.2.13)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-15 12:41:36 +05:30
Snyk bot
4bc56cb99e
chore: [Snyk] Security upgrade node-sass from 7.0.0 to 7.0.1 (#10016)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-15 04:25:27 +05:30
imgbot[bot]
cca32e7e6d
chore: [ImgBot] Optimize images (#10344)
*Total -- 240.33kb -> 209.06kb (13.01%)

/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/EmptyApp.snap.png -- 20.32kb -> 13.87kb (31.78%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/loginpage.snap.png -- 35.57kb -> 26.33kb (25.96%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/Profile.snap.png -- 31.54kb -> 24.07kb (23.66%)
/app/client/cypress/fixtures/GlobeChristmas.jpeg -- 149.94kb -> 141.86kb (5.39%)
/app/client/src/widgets/ProgressBarWidget/icon.svg -- 0.86kb -> 0.84kb (1.82%)
/app/client/src/assets/icons/widget/tabs/scroll-nav-left.svg -- 0.24kb -> 0.23kb (1.24%)
/app/client/src/assets/icons/widget/tabs/scroll-nav-right.svg -- 0.24kb -> 0.23kb (1.24%)
/app/client/src/widgets/MapChartWidget/icon.svg -- 0.82kb -> 0.81kb (0.72%)
/app/client/src/assets/icons/widget/map-chart.svg -- 0.82kb -> 0.81kb (0.72%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2022-01-14 23:23:24 +05:30
Ayangade Adeoluwa
3d8e605245
projection selector component (#10294) 2022-01-14 19:23:33 +05:30
Ayush Pahwa
f100b5918d
fix: Where clause UI fixes (10406) (#10411)
* Replaced vh with vw, fixed logic for customStyles

* Removed console logs

* Updated width of the dropdown options

* Fixes where clause filter group delete icon placement

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
2022-01-14 19:20:54 +05:30
Favour Ohanekwu
72f8b7e2e1
feat: Support OAuth for all plugin types (#9657)
* customize datasource authorization

* improve performance

* fix save datasource bug

* switch auth type from form config

* better naming of components

* fix minor bug

* minor bug fix

* minor bug fix

* syntax cleanup

* Add comments where necessary

* Added comments where necessary

* fix broken airtable page

* code refactor and annotation
2022-01-14 12:01:54 +05:30
Anand Srinivasan
2bcd73e41d
fix: revert this.params solution (#10322)
* revert changes

* code clean up

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2022-01-14 11:50:01 +05:30
albinAppsmith
ea0f0fd176
fix: Widget pane not closing when switching from canvas (#10323) 2022-01-14 11:29:19 +05:30
Arpit Mohan
18276f962b
chore: Removing trailing slash from application API endpoint. (#10316)
- This causes issues in Vercel's deploy preview when creating an app.
2022-01-13 17:49:58 +00:00
Shrikant Sharat Kandula
3610241b38
Fix path to http nginx config file (#10395) 2022-01-13 19:02:35 +05:30
Ashok Kumar M
0149085bf8
feat: Reflow and Resize while Dragging and Resizing widgets. (#9054)
* resize n reflow rough cut

* removing warnings

* relatively stable changes

* minor bug fix

* reflow relative collision

* working dp cut

* fix for reflow of widgets closer next to each other

* disabling scroll

* Drag with reflow

* reflow fix

* overlap and retracing fix

* On Drop updates.

* bug when no displacement but resize update.

* temp fix for new widget addition.

* reflow bug fixes

* new widget addition bug.

* stop reflow on leave.

* fix corner case overlap

* update bottom row when reflowed widgets go beyond bottom boundary.

* capture mouse positions on enter

* enable container jumps with faster mouse movements.

* reflow only for snap changes.

* restructured reflow Algorithm

* collision check and bug fixes

* undo redo fix for new widget drop

* resizable fix snapRows fix

* directional stability

* self collision fix

* first round of perf fixes

* update bottom row while resizing and resize-reflowing

* performance fix and overlapping fix

* Remove eslint warning

* remove eslint warning

* eslint warning

* can reflowed Drop Indication Stability

* container jumps and force direction on entering canvas

* fixing scroll on resize jitters.

* reflow when jumping into container.

* reflow ux fixes while leaving container

* resizing fixes.

* fixes for edge move.

* restrict container jumps into reflowed containers.

* container jump direction reflow

* checkbox dimensions fix.

* Excess bottom rows not lost post dragging or resizing widgets.

* fixing the after drop css glitch.

* double first move trigger bug fix.

* stop reflow only if reflowing

* stabilize container exit directions

* using acceleration and speed instead of movement covered to restrict reflow.

* fixing modal drops.

* remove warnings.

* reflow resize styles

* moving acceleration and movement logic to a monitoring effect.

* adding beta flag for reflow.

* fixing jest tests

* Adding analytics to beta flag toggle.

* Adding placeholder for reflow beta screens.

* fixing initial load's screen

* few more crashes.

* force close onboarding for the session.

* fixing bugs in reset canvas.

* Beta flag bug fixes.

* fixing bugs.

* restrict reflow screens during onboarding.

* disabling reflow screens in tests.

* code review comments.

* fixing store based specs.

* fixing cypress failures.

* fixing specs.

* code cleanup

* reverting yarn lock changes

* removing onboarding screens.

* more cleanup and function descriptors

* keeping reflow under the hood.

Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-13 18:51:57 +05:30
Daniel
19f00cbca7
Merge pull request #10328 from appsmithorg/fix/broken-datasource-alignment
fix: Datasource alignment is broken under the active tab
2022-01-13 11:49:04 +01:00
Aman Agarwal
8cc35e797e
fix: added condition for where clause evaluated value binding path (#10308) 2022-01-13 14:22:00 +05:30
haojin111
33a4c74994
fix: minor git sync fixes (#10022) 2022-01-13 14:20:29 +05:30
Bhavin K
0c5cc1a340
fix: extended min date limit to last 150 years (#10326) 2022-01-13 14:18:43 +05:30
Ayush Pahwa
16ad07fa68
feat: 5701 dynamic value fetch for forms (#10324)
* Added new condition type

* Added new variables to cater to enable/disable conditionals

* Adding functionality to disable the drop down control

* Added ability to enable/disable to dynamic input text fields

* Updated input text control to have enabled/disabled feature

* Added enable/disable functionality to FixedKeyInputControl

* Added enable/disable func to switch control and stanrdasied var name

* Added disable functionality for file picker

* Added enable/disable functionality to QUER_DYNAMIC_TEXT

* Added new state and object for evaluating conditionals

* Connected the output to the final source

* Updating loading state on the final component

* Tied fetched data to the options of dropdown component

* Added declaration to make API call

* Added loading state for dropdown

* Updated types in reducer

* Added implementation to extract API calls from the response and setting the output

* Removed extra variables

* Moved all calculation logic to the class component

* Refactors and added comments

* Added flag to store when the value fetch fails

* Reduced usage of spread operators
2022-01-13 13:37:30 +05:30
Pawan Kumar
f646eeafc1
App crashes when a modal has a filepicker? (#10376) 2022-01-13 13:31:42 +05:30
Sumit Kumar
18edb18b20
fix: implement getStructure method for S3 plugin (#8919)
* Add `getStructure` implementation for S3 to return a list of accessible buckets.
* Add command templates for S3.
  - List files
  - Read file
  - Create file
  - Delete file
* Remove getDatasourceMetadata implementation as getStructure method can be directly used now.
2022-01-13 11:33:50 +05:30
Aswath K
ef9c8e0aa3
feat: Add Jest Test for propertyPaneConfiguration validation (#8773) 2022-01-13 05:24:12 +00:00
Aishwarya-U-R
cc426f1455
test: Automated tests for Promises in Typescript + failure fixes (#10288)
* JSObjects scripting

* storeValue Implemented

* Resolve, AsyncAwait script implementation

* Moved ts tests inside already existing folders

* Then & Catch test script implemented

* Promise.race test script implemented + S3 fix

* JSObject_To_ListWidgetSpec.ts failure fix

* S3 flaky test fix

* createOrg flaky fix

* FilePicker_with_fileTypes_spec.js filename fix

* createOrg flaky fix

* createOrg revert

* JSObject_To_ListWidgetSpec.ts added validations

* .then .catch promises script added

* Added script for Promises Maintaining context

* Added WaitUntilEleDisappear()

* JSObj run fix
2022-01-13 05:23:27 +00:00
Danieldare
a7b2967f16 fix: conditionally show shadow div 2022-01-12 07:13:47 +01:00
Paul Li
6df4ebc1f0
feat: Tab widget should have navigation arrows when the tabs don't fit (#8630)
* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Add scroll navigation control

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Divide tabs navigator control into both sides of contents

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Implement navigation per slide

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Refactor on useEffect dependencies and some calculations
-- Introduce if-else statement for readability and consistency

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Add class names for scroll navigation controls
-- Narrow the width of Tab widget in dsl
-- Add a Cypress test case for checking the presence of scroll navigation controls

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-12 13:04:28 +08:00
Parthvi12
687be0f64a
test: removing failure threshold (#10178)
* removing failure threshold

* updating screenshots

* changing failure threshold to 0.1
2022-01-12 10:16:20 +05:30
Danieldare
60904c6bbf fix: remove router from scope 2022-01-11 15:06:58 +01:00
Paul Li
f0fb061dbd
feat: Checkbox group should have a select all option (#8744)
* feat: Checkbox group should have a select all option

-- Add a new property, isSelectAll
-- Implement its functionality

* feat: Checkbox group should have a select all option

-- Set height to auto for select all control
-- Move isInline and isSelectAll properties below isDisabled
-- Set color for options to GREY_9 and GREY_10
-- Add Cypress test cases for handleSelectAllChange

* feat: Checkbox group should have a select all option

-- Fix on misalignment of select all control if isInline is true
-- Refactor the cypress test cases which is affected by adding select all control

* feat: Checkbox group should have a select all option

-- Set white-space to nowrap

* feat: Checkbox group widget should have a select all option

-- Change helpText for isSelectAll property

* feat: Checkbox group should have a select all option

-- Fix on broken test cases for the select all option

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-11 21:26:50 +08:00
Parthvi12
7d257c95fe
test: Autocomplete not working for Appsmith specific JS APIs (#10301) 2022-01-11 16:26:26 +05:30
Pawan Kumar
a68b98d7dc
fix alignment issues (#10264)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-01-11 05:57:13 +00:00
Keyur Paralkar
843eeb1444
fix: Inconsistency propertypane (#10181)
* issue #8439

* Added color to cell background

* test: fixed existing tests

* test: fixed the backgroundcolor selector issue

Co-authored-by: AR10X <arehamanofficial@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-11 11:08:17 +05:30
Ayangade Adeoluwa
eb472eaf78
fix: long status code text ellipsized in API pane (#10021) 2022-01-10 16:43:04 +00:00
Ayush Pahwa
8c141ed2cd
chore: Added null check on eval output and started using standard call for pluginId (#10290) 2022-01-10 21:36:52 +05:30
akash-codemonk
c533d26a94
fix: filter menu not opening in snippet search (#10229) 2022-01-10 09:55:05 +05:30
Aishwarya-U-R
c711e39849
test: Automated tests for JSObjects in Typescript (#10223)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix

* Bugs # 8595 & 10049 - Implemented

* Updating AGHelper methods to explicit public

* Reverting tsconfig.json

* tsconfig.json reverted

* Adding local tsconfig.json for Cypress tests

* fixture read updating for ts tests

* Updating .yml files to pick up ts files execution

* Including ts files for cypress run

* Running only ts test files

* Inclusion of TS files for cypress run

* Revert cypress.json to run all tests

* Added validation for Bug #10055 & commented

* Flaky fix

* JSObject_To_ListWidgetSpec - Implemented in TS

* Entity_Explorer_JSEditor_spec implemented in TS

* Uncommenting script for Bug 10049, 10055
2022-01-10 09:51:43 +05:30
Favour Ohanekwu
dde68ce753
prevent corruption of downloaded file when base64 string is used in download action (#10254) 2022-01-09 08:15:09 +01:00