218dbef6e8
322 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Aman Agarwal
|
d070ca76b0
|
fix: add a warning icon and tooltip to indicate empty datasources (#33618) | ||
|
NandanAnantharamu
|
8682dd2b90
|
test: PartialExport_Widgets_spec - updated test validation logic (#33371)
Spec -
cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_Widgets_spec.ts
RCA:
Comparison of this file post export is failing this file needed change.
closeModal('Insert_Modal')) is changed to closeModal(Insert_Modal.name))
and
showModal('Delete_Modal')) to showModal(Delete_Modal.name))
Solution:
To overcome this issue of frequent updation of file we have come up with
a solution to validate the partial import post export in a different
way.
1. We are creating a separate page and importing the partially exported
file
2. We are doing widget validation based on the selection we did during
our export
3. We are checking the properties of the widgets in the process in the
new page
---------
Co-authored-by: Trisha Anand <trisha@appsmith.com>
|
||
|
Ankita Kinger
|
4bb0af479e
|
chore: Replacing "Edition" with "Plan" for business and enterprise edition references (#33506)
## Description Replacing "Edition" with "Plan" for business and enterprise edition references. Fixes [#1415](https://github.com/appsmithorg/cloud-services/issues/1415) |
||
|
ashit-rath
|
98dc16d9d0
|
chore: Adding couple of messages for modules (#33502)
## Description Adding couple of messages to by used in modules cypress tests PR for https://github.com/appsmithorg/appsmith-ee/pull/4118 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9105210254> > Commit: da03a364f5c6f200f11b35aff10ee45fc5fc99eb > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9105210254&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
albinAppsmith
|
f13309e75d
|
feat: New tab ui changes (#33228)
## Description Added new design of New Query/Js tab design. Fixes #33116 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9084312304> > Commit: 48223f4aecb77cd98e1bfea1c0ffc5710689509a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9084312304&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
Ankita Kinger
|
a6b8a36d6c
|
chore: Updating embed settings feature tag from Business to Enterprise (#33448)
## Description - Updating embed settings feature tag from Business to Enterprise - Also, removing references of "edition" from all over the codebase - Also, fixing the issue for text input fields not getting cleared on click of reset button when the old value was a blank string Fixes [#33450](https://github.com/appsmithorg/appsmith/issues/33450) [#33449](https://github.com/appsmithorg/appsmith/issues/33449) ## Automation /ok-to-test tags="@tag.Settings, @tag.Fork, @tag.Workspace" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9094357338> > Commit: 59f05f374b777778ee39bf1f7078844a50f6a72a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9094357338&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
Ayush Pahwa
|
43d61f785f
|
chore: cypress strings replaced with var names (#33469)
## Description Updated cypress tests by replacing hard coded strings with variables. Also removed unused commented code from DebuggerHelper and an extra var Fixes #33256 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9092019864> > Commit: e66c44b9e17a2bedb33ecf4d84b84fc6f8860fe0 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9092019864&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
NandanAnantharamu
|
7135acae64
|
test:PartialExport_Widgets spec file updated and import app method updated with validations (#33343)
RCA: PartialExport_Widgets_spec.ts was failing where we export and compare files. Solution: - Updated the WidgetsExportedOnly.json, now the comparison step is working as expected - Improved the assertions within importApp() reduced wait time and waiting for import modal to close as a check. - Also updated tags which used importApp() below are the list of files [AppNavigation_spec.ts,Sidebar_spec.ts,TopStacked_spec.ts,TopInline_spec.ts,Editor_Segment_Context_Switching_spec.ts,JSOnLoad2_Spec.ts] - Reverted the intercept success check within ImportApp() - Updated PartialExport_Widgets_spec.ts with network call assertion post import /ok-to-test tags="@tag.Workspace,@tag.ImportExport"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9028944129> > Commit: b9ad3c9f7c9f6b52aa061f286b143b715b7d627a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9028944129&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
Apeksha Bhosale
|
d88b43165f
|
test: GitSyncedApps_spec - multiple IA changes (#33257)
## Description In this spec, IA changes were required. 1. table version change --- https://github.com/appsmithorg/appsmith/pull/29457 2. page related functionalities addition and replacement ie clone, hide and show list to assert a page name 3. replaced as many as possible git related functionalities to gitSync helpers Link - **9th Spec** in https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339 **Phase 1** EE - PR for runs -https://github.com/appsmithorg/appsmith-ee/pull/4140 EE run -- for Git and AccessControl tags https://github.com/appsmithorg/appsmith-ee/actions/runs/9002744046 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
Ayush Pahwa
|
370016a16d
|
chore: move cypress strings to vars (#33245)
## Description Replaced strings of cypress tests to variables Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE, @tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8996892379> > Commit: 3badf854bd74903b7689fc4f2fa5fdae6a670704 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8996892379&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
Trisha Anand
|
0a6e822bcf
|
Revert "test: PartialExport_Widgets_spec - updated exported json file to compare and added confirmation of successful import" (#33254)
Reverts appsmithorg/appsmith#33090 |
||
|
Pawan Kumar
|
6a6e494f90
|
fix: button group spec (#33234)
Fixes the button group failing spec /ok-to-test tags="@tag.Button"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8983388408> > Commit: 0e7d32e7dcf3562fd0f08bab33559b7876e2ca66 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8983388408&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
albinAppsmith
|
d27725d93b
|
fix: Create module btn UI fix in split screen view (#33095)
## Description Create Module (Beta) button was overlapping on context menu in split screen. This PR addresses this issue. Fixes #33038 ## Automation /ok-to-test tags="@tag.Sanity, @tag.Workflows" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8969352623> > Commit: ad38d66124ec426fb84a17ce9f884080f25af849 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8969352623&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
NandanAnantharamu
|
87d535ac23
|
test: PartialExport_Widgets_spec - updated exported json file to compare and added confirmation of successful import (#33090)
RCA: Test was failing at comparison step where we export and compare Solution: Updated the WidgetsExportedOnly.json, now the comparison step is working as expected Improved the assertions within importApp() reduced wait time and also removed the Toast message verification /ok-to-test tags="@tag.Workspace,@tag.ImportExport" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8941790028> > Commit: 23535e879fde6b8d3018e6bcd762a85df18fea9c > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8941790028&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
Rahul Barwal
|
c37aa0a9af
|
fix: Drag drop Building blocks prompt fixes (#33093)
## Description This PR fixes 2 issues: 1. Building blocks after getting dropped had multiple seleciton on - now we not selecting anything 2. BBs were visible in side by side nav. Now it will only be visible if `UI` widget is selected. Fixes #33085 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity, @tag.Templates" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8909118563> > Commit: 6603b5c05bad39ffdc06e3b67a83669cd2cfe4f7 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8909118563&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
albinAppsmith
|
dfead818cd
|
feat: Removed tabs revamp feature flag (#32956)
## Description This PR will remove tabs revamp feature flag and make it available for every users. Fixes #32955 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8847166703> > Commit: 7c27a28e1f73a8470543e453c7000d3d773116e9 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8847166703&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed the feature flag for the IDE tabs revamp, simplifying the rendering logic and component behavior across various IDE components. - Streamlined the handling of tabs in the IDE, eliminating conditional feature flag checks and associated conditional rendering. - Adjusted test suites to align with the removal of the feature flag, ensuring consistency in component behavior testing. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
114a624ee2
|
fix: Minor UI fixes in the Query Editor Form (#32958)
## Description Makes minor changes in copy and style for better readability in Side by Side mode Fixes #31558 Fixes #31565 Fixes #31566 ## Automation /ok-to-test tags="@tag.IDE, @tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8830604958> > Commit: 4f3a8a13685ef2a04077bc4641ddb8691101b852 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8830604958&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Improved clarity in user interface messaging for data source creation and table search functionalities. - **Style** - Updated spacing in dropdown components and form rows to use custom CSS variables, ensuring a more consistent design across the platform. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
ef279d1e76
|
feat: update copy from widgets to UI elements (#32514)
## Description > [!TIP] With the addition of building blocks to the explorer items, we need to change the widget name to something that better encapsulates the contents of the canvas explorer. All instances of "widgets" in the canvas explorer have been changed to "UI elements" Fixes #32331 ## Automation /ok-to-test tags="@tag.Widget, @tag.MainContainer, @tag.Visual" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8777493414> > Commit: 97f5cdb47a40086bf2979661c39fa4a32d0e4dd8 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8777493414&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new constants and updated text descriptions for UI elements in the editor pane. - Enhanced the multi-select property pane with clearer text. - **Refactor** - Changed terminology from "widgets" to "UI elements" across various UI components. - **Style** - Updated messages and placeholder texts to improve user interface clarity and consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
sneha122
|
5860351ce2
|
fix: removed success toast message for onload js functions (#32700)
## Description Whenever we have js object functions set to execute on page load, and we reload such page, all these functions are execute and we get lots of success message popups indicating the execution of js object functions was successful, These toasts clutter the UI and unnecessary since action execution has been successful, this PR removes those toast messages https://github.com/appsmithorg/appsmith/assets/30018882/44472503-d3c7-4bf8-861f-437284a4996c Fixes #32695 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8734047332> > Commit: fb22e7445618c592dee1066991d668082afc5642 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8734047332&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Refactor** - Simplified JavaScript execution flow by removing unused imports and functions. - Removed success toast notification after JavaScript function execution. - Updated test scenarios in Cypress related to JavaScript execution and navigation back to the editor. - Removed test cases verifying the number and sequence of JS objects on page load in ServerSide/OnLoadTests. - Added functionality to interact with the debugger in the test scenario in ClientSide/BugTests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Rudraprasad Das
|
c85631c06f
|
fix: adding branch protection callout (#32707)
## Description - Changes branch protection tooltip to callout - Adds protected branches for merge in a disabled state Fixes #32706 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8735310063> > Commit: f654e1168fde85388991cf547630b42bc61d9b4e > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8735310063&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
Ankita Kinger
|
e07e3ecd04
|
chore: Updating the login and signup page for cloud hosting as per new design (#32641)
## Description Updating the login and signup page for cloud hosting as per new design Fixes [#32267](https://github.com/appsmithorg/appsmith/issues/32267) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8723701550> > Commit: 65a0179c5d22e1f950888c24a119af608aed2a28 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8723701550&attempt=4" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced titles and messages across login, signup, and forgot password pages for clarity and engagement. - Added new analytics event for tracking visits to self-hosting documentation. - Introduced new content and layout adjustments in user authentication pages to improve user experience. - Implemented conditional rendering to optimize content display for mobile devices and cloud hosting scenarios. - **Bug Fixes** - Updated footer links to use consistent capitalization. - **Refactor** - Major structural and styling overhaul of forms and user authentication components to utilize modern CSS practices and improve maintainability. - **Documentation** - Added direct links to self-hosting documentation to facilitate user access. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
0118051301
|
feat: implement dropping building blocks on canvas (#31857)
## Description > [!TIP] **Goal** To drag any building blocks from the explorer and drop at any position on the users canvas with full implementation. **Implementation** - Show skeleton widget when building block is initially dragged unto the canvas. - Make API call to add datasources, queries, and JS to existing page of users app - Get returned widget DSL and use existing copy paste logic to display widgets on the canvas - Remove loading state, handle clean up for copy paste - Run all queries newly created by the dropped building block **Limitations** - There is a loading state and the process is not instant like dropping a widget This PR is followed by this one [here](https://github.com/appsmithorg/appsmith/pull/31406), which displays the loading state when a building block is dragged unto the canvas. Fixes #31856 ## Automation /ok-to-test tags="@tag.Templates, @tag.MainContainer, @tag.Visual, @tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8701664455> > Commit: 456a7a0a322e76974a7f5c41a6c1e274ef82e4ea > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8701664455&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new "Building Blocks" category in the widget sidebar for enhanced organization and accessibility. - Added functionality to resize building blocks with new horizontal and vertical limits. - Implemented a "see more" button for "Building Blocks" to display all associated widgets. - Enhanced drag and drop functionality for building blocks on the canvas. - **Enhancements** - Improved sorting logic for widgets, prioritizing "Building Blocks". - Enhanced widget search functionality within the sidebar. - **Bug Fixes** - Adjusted default rows and columns settings for explorer building blocks to improve layout and usability. - **Documentation** - Updated messages and constants related to new features for clarity and consistency. - **Refactor** - Refactored drag and drop handling logic to support new building block constraints and features. - Updated application state management to include building blocks related data. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com> |
||
|
Rishabh Rathod
|
6a26602086
|
fix: deprecate JS object confirm before calling (#32527)
## Description We deprecate confirm before calling for JSObjects - For new JSObject, confirm before calling option won't be visible - For already present JSObject, only for function where confirm before calling was enabled will be visible and once turned off will not be visible anymore. Fixes https://github.com/appsmithorg/appsmith/issues/29248 ## Test scenarios - For an application where JSObject confirmed before calling was enabled, it should work same. - For new JSObject, confirm before calling option shouldn't be visible. - Once user disable confirm before calling it should not be visible anymore. - Deprecation warning on info. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8654538946> > Commit: 6ac458bdec864a2963fa5eb59b5912607ddfa3a7 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8654538946&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
albinAppsmith
|
d5ed551b16
|
feat: Added searchable files list for IDE tabs (#32505)
## Description This PR implements the new searchable files list menu in IDE tabs. Fixes #32479 ## Automation /ok-to-test tags="@tag.IDE, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8629000008> > Commit: `e5c317b4057e814fc04cdb107fbe223de601c7bc` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8629000008&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
albinAppsmith
|
3d2b33c0fa
|
chore: cypress test for canvas view mode (#32354)
## Description This PR added cypress test for canvas view mode. Fixes #31874 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8534736683> > Commit: `f1d8cc5c4437571b5bbe9a43e892068ae774c75f` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8534736683&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced testing functionality for Canvas view mode in IDE, including various interactions and validations. - Added a new Cypress command for asserting the presence and content of tooltips. - Enhanced tooltip message customization in the Canvas view mode with a new message creation function. - **Refactor** - Improved code organization in Canvas support files with better method implementations. - **Tests** - Added end-to-end tests for new and existing functionalities related to the Canvas view mode. - **Documentation** - Updated Cypress support documentation with the new `assertTooltipPresence` method. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vinay Chilukuri
|
eabb046eb1
|
fix: Copy change in side-by-side announcement modal (#31703)
Added punctuation and rewrote the message to make it crisper. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated text content for the split pane feature to enhance clarity and guide users more effectively. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
albinAppsmith
|
29cc9d39d5
|
feat: Added split pane beta announcement modal (#31676)
## Description This PR adds the beta announcement modal for the new split pane. Fixes #31657 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8244295273> > Commit: `8f20379a3f045328c0c7fa0ddce9b28d34a86348` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8244295273&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a beta version feature allowing users to work with code and UI side-by-side, enhancing productivity and user experience. - Added an announcement modal to inform users about the new split-screen functionality, with options to try it immediately or learn more. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Abhijeet
|
0c2f1a27e0
|
feat: Add functionality to enforce strong password for form signups (#31605)
**PR to selectively enable strong password requirements.** Fixes: https://github.com/appsmithorg/appsmith/issues/31525 |
||
|
albinAppsmith
|
46b4252ae6
|
fix: side by side blank state, tooltip, and add button UI (#31479)
## Description This PR fixes following issues - JS and Query Blank state issue in side by side mode. - Added tooltip for minimize and maximize button. - Fixed add button getting squeezed issue. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/31330 #### Media https://github.com/appsmithorg/appsmith/assets/87797149/e0e30e47-1f3a-447d-93a5-144e48360cec #### Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced tooltips for maximize and minimize buttons in the editor interface, enhancing user interaction. - Added new empty state components for JavaScript actions and queries, improving the user experience for adding new elements. - Implemented split-screen empty states for both JavaScript actions and queries, catering to users who prefer side-by-side editing. - **Enhancements** - Updated the editor's segmented header and full-screen tabs with tooltips, providing clearer guidance on button functionalities. - Adjusted the maximum width of tabs in the editor to accommodate additional elements, ensuring a more organized display. - **Refactor** - Replaced the use of `EmptyState` with new `Empty` components in JavaScript and Query editor panes, streamlining the interface and aligning with new functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
albinAppsmith
|
32955bcab8
|
feat: Added modal for action creator new query option (#31210)
## Description Before, when use clicks on new query from action selector, omnibar used to show to create a new query. This PR removed showing omnibar and instead will start showing a modal with similar content as add pane. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/31217 #### Media Before https://github.com/appsmithorg/appsmith/assets/87797149/641a1409-bc9c-42be-907f-02157faf901e After https://github.com/appsmithorg/appsmith/assets/87797149/c1ee3d29-1fef-4de2-8c34-3e2bedc4081f #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new modal for creating items, enhancing user interaction and productivity. - Added omnibar trigger sources to refine search functionalities based on the context of use. - Implemented a function to dynamically generate messages for creating new items, improving user guidance. - **Enhancements** - Enhanced the global search by including additional trigger sources, allowing for more precise search operations. - Improved the property pane with a toggle for a new creation modal, streamlining the process of adding new items. - **Refactor** - Optimized query list item creation and management within the editor, ensuring a smoother user experience. - Refined action dispatch mechanisms to better support side-by-side editing modes. - **UI Improvements** - Updated the UI to include a new create new modal, making it easier for users to add queries and other items. - Enhanced search results handling to better accommodate different trigger sources and editor modes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
fb0472d241
|
chore: show suggested widgets in response (#31008)
## Description Show the Suggested widgets panel in the response pane in the bottom instead of the right side. This will greatly simplify the Query and Api screens. - Removes functionality of suggested widgets from the right pane context - Only renders the right pane if `additionalSections` is passed - Adds a new Bind Data button in the Response Pane - OnClick of button, a menu with suggested widget bindings show up #### PR fixes following issue(s) Fixes #30968 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/20e239ad-dea4-4755-b199-4f0920ae1d46 #### Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced a new `BindDataButton` component for easier data binding to widgets in the visual editor. - Updated UI elements and interactions in the API and Query editors for improved usability. - Added an import statement for `Widgets` from the `DataSources` module. - Changed the method call from clicking on a suggested table widget to adding a suggested widget of type `Table`. - **Refactor** - Simplified and streamlined the `ActionRightPane` component by removing outdated functionalities. - Adjusted UI components and layouts across various editor components for better consistency and usability. - **Bug Fixes** - Fixed text inconsistency in the `CONNECT_EXISTING_WIDGET_LABEL` constant. - Removed unnecessary `useEffect` hook in the `EntityBottomTabs` component to improve performance. - **Chores** - Removed deprecated code and unused imports across several files to clean up the codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
b380b28c42
|
feat: Add "Start with template" option and refactor template components (#30946)
## Description This pull request adds the "Start with template" option to the workspace action menu and refactors several template components to improve code organization and maintainability. #### PR fixes following issue(s) Fixes #30860 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability to create new applications from templates, enhancing user experience with a selection of predefined options. - Added a new feature flag to toggle the visibility of the "Create App from Template" functionality, allowing for phased rollouts. - **Enhancements** - Updated text constants for a more intuitive user interface. - Streamlined the template selection and application creation process with improved UI components and logic. - **Refactor** - Significant code organization and refactoring in template handling components for better maintainability and readability. - **Tests** - Adjusted unit tests to align with the new template creation flow. - **Style** - Adjusted styling for template views, ensuring a consistent and appealing user interface. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
balajisoundar
|
4a4ff3cf27
|
feat: [custom widget] support SCSS syntax (#31042)
## Description - Add support for [ Scss syntax](https://sass-lang.com/documentation/syntax/) in the custom widget builder style tab. - Change the css editor title to style. Since we now support the SCSS syntax as well. #### PR fixes following issue(s) Fixes #28614 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [x] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added SCSS syntax support and CSS variables usage in tooltips. - Introduced styled components for better styling consistency across the app. - Enhanced the Custom Widget Builder with improved error message styling and tooltip content rendering. - **Bug Fixes** - Refined warning message conditions to reduce unnecessary warnings. - Ensured the `selectedTab` is always valid in the Custom Widget Builder's `TabLayout`. - **Refactor** - Updated function and component names for clarity and consistency (e.g., `CSSEditor` to `StyleEditor`, `getBabelError` to `getError`). - Restructured CSS styles for better layout and presentation in the Custom Widget Builder. - **Chores** - Removed unused CSS class definitions and adjusted existing ones for optimization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rohan Arthur
|
4af694681d
|
fix: broken line in page settings (#30951)
## Description for old pages that were created before the new url style, the page settings has a prompt to ask the user to change the URL. The line in this prompt is broken  This PR changes this line to:  For testing, you can get an example old app from [here](https://theappsmith.slack.com/archives/C02JT9CSE6L/p1707204475068809?thread_ts=1706698534.445299&cid=C02JT9CSE6L) #### PR fixes following issue(s) Fixes #30922 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the wording of messages related to setting page URLs for enhanced clarity and consistency. - Changed test tags from `@tag.Settings` to `@tag.Visual` for improved test categorization. - Modified JSEditor indentation visual tests to include additional test cases and adjustments in test descriptions. - Updated test tags from `@tag.JS` to `@tag.Visual` for consistency in test categorization. - Added `@tag.Visual` to the list of tags for test categorization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|
Hetu Nandu
|
1afe639911
|
chore: Show schema as a tab instead of the right pane (#30906)
## Description Moves the Schema in Query Pane from the right side to the tab on the bottom. This is done to eventually remove the right side pane for Side by Side layout #### PR fixes following issue(s) Fixes #30873 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/28c5086a-1967-4a72-8dc5-0717751198cf #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. - [ x ] Manual - [ x ] Jest - [ x ] Cypress <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a refresh button in the datasource structure container for easy refreshing. - Added a new state to handle scenarios with no columns to display, enhancing user feedback. - Implemented conditional rendering of components based on new props and states, improving UI responsiveness and interaction. - **Enhancements** - Updated placeholder texts and messages for a clearer user experience. - Improved the layout and styling of various components for better visual appeal and usability. - **Refactor** - Streamlined the rendering logic and state management in several components, leading to a cleaner codebase. - Removed unused imports and functions, optimizing component performance. - **Bug Fixes** - Fixed issues in test suites related to table schema handling and selection. - **UI Changes** - Adjusted styling properties for better alignment, display, and gap spacing in the datasource structure search container. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Nirmal Sarswat
|
479f9132bd
|
feat: Add knowledge retrieval in Appsmith AI (#30725)
## Description Frontend Changes - Remove Appsmith AI Query as a default datasource query - Add Appsmith AI Datasource in the AI section of Datasources screen - ~~Creation of Appsmith AI datasource to mimic the mock datasource flow. This was necessary because we are using a trigger in the datasource edit form and inorder for the trigger to function the datasource needs to be created before the trigger call.~~ (We are using the plugin trigger to upload files and hence this change is not required anymore) - Add a new Form control element to support multiple file uploads. The multiple file upload control type can either upload the files to the trigger end point (multipart-form trigger api) or save the files as base64 string in the datasource configuration. If the files are uploaded in the trigger, only the file metadata (name, size, mimeType and id) is saved in the datasource configuration. - Fix a bug in Dropdown control. This fix makes sure that the options that are disabled as infact disabled on the UI. - Add preview for the new Multi file picker control type. Backend Changes - Add a new trigger end point for datasource to support multipart form data - Add trigger for Appsmith AI datasource to upload files during datasource creation/edit flow - Associate the file ids with the datasourceId in AI Node server - Add Knowledge retrieval implementation in text generation action for Appsmith AI datasource - Add form.json for Appsmith AI Datasource - Add a fetch files trigger for populating the files in the Text generate action. #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a multiple file picker control for users to select and upload multiple files with options for file types and size limits. - Added new AI Query functionality with enhanced file upload capabilities, including timeout settings. - Enhanced datasource editor to display the number of uploaded files or a message if no files are uploaded. - **Bug Fixes** - Simplified the logic for showing the datasource selector by removing specific conditions related to the Appsmith AI Plugin. - **Refactor** - Removed unused imports and functionalities related to Appsmith AI across various components. - Updated plugin handling to dynamically determine button text based on plugin type. - **Chores** - Implemented backend support for file upload and association with datasources and workspaces. - Added new utility functions and DTOs for handling file uploads and AI plugin interactions. - **Documentation** - No visible changes to end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Diljit VJ <diljit@appsmith.com> |
||
|
Aman Agarwal
|
cc620b3ab3
|
feat: removing delete multiple apps feature (#30661)
## Description Removing the bulk delete applications feature as it not generally used by many users and this was creating some UI conflicts rather than giving us some valuable output. Please follow this thread for more context : https://theappsmith.slack.com/archives/C02Q4B2AGM8/p1706249168968689 #### PR fixes following issue(s) Fixes #30660 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the application deletion process to handle multiple deletions more efficiently. - **Bug Fixes** - Removed redundant code and unused features related to the multiple selection and deletion of applications. - **Chores** - Cleaned up various files by removing unused imports, constants, and state variables. - **Documentation** - Adjusted code comments and documentation to reflect removal of multiple application deletion features and related UI elements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ankit Srivastava
|
a45dcfa61f
|
feat: Homepage experience v2 changes (#29282)
> Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description > Add a TL;DR when description is extra long (helps content team) > > Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation > and context. List any dependencies that are required for this change > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new workspace search functionality in the search bar. - Introduced a help button for user assistance. - Implemented new UI components for workspace selection and management. - Enhanced application card with edit permission checks. - Integrated workspace actions for creating and fetching workspaces directly from the UI. - **Improvements** - Improved workspace and application fetching logic. - Enhanced Global Search with updated import paths and logic. - Refined the layout and styling of the applications page and sub-header components. - Optimized workspace-related sagas and reducers for better performance and maintainability. - **Bug Fixes** - Fixed tooltip functionality in "Reconnect Datasources" within templates. - Corrected test logic for forking templates and applications. - Updated Cypress test commands for consistency and reliability. - Addressed issues with application URL test cases and workspace import logic. - **Documentation** - Updated messages and constants related to workspace and application UI elements for clearer user communication. - **Chores** - Cleaned up unused code and simplified selectors across various components and tests. - Refactored application and workspace selectors for improved code organization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Dipyaman Biswas <dipyaman@appsmith.com> Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com> Co-authored-by: Nidhi <nidhi@appsmith.com> Co-authored-by: Goutham Pratapa <goutham@appsmith.com> Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Nayan <nayan@appsmith.com> Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> |
||
|
Preet Sidhu
|
c396fc5499
|
feat: Add copy paste functionality for Anvil. (#30217)
## Description 1. Copy paste functionality for Anvil. 2. Handle automatic creation of sections and zones based on different scenarios. 3. Handle space distribution on paste. #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new paste functionality for widgets within the Anvil layout system. - **Improvements** - Refined widget movement logic to accommodate different canvas types. - Expanded widget pasting capabilities with additional checks and operations. - **Bug Fixes** - Addressed potential issues with dragging blocks by ensuring existence checks before mapping. - **Refactor** - Streamlined sagas for widget operations to better align with the Anvil layout system. - Consolidated widget position utility functions for more efficient layout management. - **User Interface** - Implemented user-friendly error messaging for paste operations that fail. - **Documentation** - Updated messages and constants to support new paste functionality and error handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> |
||
|
albinAppsmith
|
ced4ffa179
|
fix: Remove guided tour code (#30387)
## Description Removed the guided tour code. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/30332 #### Type of change - Bug fix (non-breaking change which fixes an issue) - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined onboarding process by removing guided tour features. - Refined action and message management for a more intuitive user experience. - Enhanced property controls generation for better user interaction. - **Refactor** - Simplified various components by removing unnecessary guided tour logic. - Improved application and page sagas for more efficient operation. - Refined editor components for a smoother user interface. - **Documentation** - Updated message constants for clearer user guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
38d37ba874
|
chore: Split files for Module Instances in IDE (#30562)
As part of updating the IDE IA Redesign, we are splitting certain functionalities so that they can be extended on the EE side. Summary of changes: - Create a `WithAddView` interface in RouteBuilder to indicate a scenario where the url can be suffixed with a `/add` to have edit and add views together - Create a common GroupedList component - Adds a dummy JS Add screen and routes. Wont navigate to it via the system - Move `EntityItem` interface to a more common location for extensibility - Update FocusElement config type to allow for a limited targeting in FocusStrategy - Extracted out ListItem render components for JS and Query - Moved JS and Query segment hooks to a CE location for extensibility of AddQuery and ListQuery - Extracted EditorPaneRoutes for extensibility - Added FocusEntity entries for QueryModuleInstance and JSModuleInstance. This will be cleaned up at a later date. Companion EE PR: https://github.com/appsmithorg/appsmith-ee/pull/3389 Fixes: #30544 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an interface for adding views to enhance URL generation for different editor functions. - Added new user-facing messages for creating blank JavaScript objects in the editor. - Implemented new hooks and components to manage and render JavaScript and Query entities within the IDE. - Created a grouped list component for categorizing items within the editor pane. - **Enhancements** - Extended existing enums and utilities to support new module instance types and actions. - Improved navigation and focus management within the IDE based on user interaction and context. - Streamlined the process of adding JavaScript operations and queries in the editor. - **Refactor** - Updated import paths for better code organization and module resolution. - Removed redundant code and replaced components with more efficient implementations. - **Bug Fixes** - Corrected the behavior of the `Files` component to handle undefined types appropriately. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rudraprasad Das
|
0cbc6bfd40
|
feat: adding continuous delivery tab in git settings (#30512)
## Description Part of continuous delivery with git feature. Includes CE UI elements for "Continuous delivery" tab. Utilizes feature flag `release_git_continuous_delivery_enabled` to hide the implementation from UI #### PR fixes following issue(s) Fixes #30510 #### Media <img width="1728" alt="image" src="https://github.com/appsmithorg/appsmith/assets/8724051/66dfca37-4bbd-4e27-a8a5-369b214af9b4"> #### Type of change - New feature (non-breaking change which adds functionality)\ ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed |
||
|
Aman Agarwal
|
04c0dcaad2
|
fix: delete multiple apps feature ui updated (#30112) | ||
|
Rudraprasad Das
|
e262ea42f7
|
fix: fixing message variable name due to run issues (#30478)
reverts changes issue with message variable name <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated labels and logic for the General Settings section in the app settings pane for improved clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rudraprasad Das
|
877aa1a2c9
|
fix: adding new settings modal (#30320)
## Description Separates git sync modal from git settings modal #### PR fixes following issue(s) Fixes #30319 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the `GitSettingsModal` for enhanced Git configuration. - Added the ability to switch between General and Branch settings tabs within the Git settings modal. - Implemented new user permission checks for displaying Git user settings and danger zone sections. - **Enhancements** - Streamlined the Git settings experience by removing unnecessary modals and components. - **Refactor** - Improved action and selector naming for better clarity and maintainability. - Adjusted UI components to utilize new Redux state management for Git settings. - **Style** - Updated padding for better visual spacing in Git user settings. - **Tests** - Modified and removed tests to align with the updated component structure and functionality. - **Bug Fixes** - Fixed navigation issues within the Git settings modal by refining action dispatches and state handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
f52e4781c1
|
feat: update canvas building blocks (#30311)
## Description **Goal** 1. To remove the dashboard canvas starter building block and replace it with the Sort and Filter Table building block from the templates gallery. 2. To replace all canvas starter icons with the corresponding building blocks icons. **Steps** - Add a new page to the Starter Templates app called Sort and Filter Table - Export the existing Sort and Filter Template and import into the new page in Starter Templates using PIE - Change the copy for title and description in the code - Take a screenshot of the Sort and Filter table home page, upload to Contentful and update the screenshot URL. - Download and add new Icons for all 3 canvas starter blocks - Deploy updated Starter Templates application and upload new JSON to S3 under the same name #### PR fixes following issue(s) Fixes #30261 #### Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the naming and descriptions of template page layouts for improved clarity. - Reorganized and renamed SVG icons for consistency across the platform. - **Style** - Enhanced the styling of template layout titles and descriptions for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
balajisoundar
|
f376d362e4
|
chore: custom widget onReady warning and template updates (#30335)
## Description Update tempaltes and add warning message when onReady function is missing. > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new Vanilla JavaScript template for custom widgets. - Enhanced Vue.js custom widget template with new design and functionality. - Added a warning system to alert users when certain expected code patterns are missing. - **Bug Fixes** - Updated the `appsmithConsole` to include error handling. - **Documentation** - Added new documentation URLs for custom widget development guidance. - **Refactor** - Replaced the `blank` module with `vanillaJs` in code templates. - Removed unused styles and code comments from React template. - Streamlined default context values for widget development. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
balajisoundar
|
5d44d4f2cf
|
chore: misc updates to custom widget (#30114)
#### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29991 Fixes https://github.com/appsmithorg/appsmith/issues/30154 Fixes https://github.com/appsmithorg/appsmith/issues/30020 Fixes https://github.com/appsmithorg/appsmith/issues/30019 Fixes https://github.com/appsmithorg/appsmith/issues/30130 Fixes https://github.com/appsmithorg/appsmith/issues/30159 Fixes https://github.com/appsmithorg/appsmith/issues/30223 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Custom widgets now support analytics events, enhancing visibility into user interactions. - Template selection, layout controls, and reference triggers in the Custom Widget Builder are now integrated with analytics. - Added new style options for custom widgets, including `primaryColor`, `backgroundColor`, `borderRadius`, and `boxShadow`. - **Bug Fixes** - Corrected a typo in the constant title for better clarity. - Updated help text for the Container Widget to accurately describe the widget's border edge. - **Enhancements** - Improved user interface with additional styling for reference names in the Custom Widget Builder. - Enhanced debugger functionality with `useCallback` optimization and new analytics logging. - **Refactor** - Streamlined the property pane by introducing a new `LabelContainer` styled component. - Refined the handling of dynamic binding paths to ignore certain properties efficiently. - **Documentation** - Added a new constant for the default model documentation URL in the Custom Widget Builder. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
albinAppsmith
|
9bbf13debe
|
feat: enabled editor pane sidebar (#29882)
## Description This PR fixes the cypress failures introduced after editor pane #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29881 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Hetu Nandu <hetunandu@gmail.com> |
||
|
albinAppsmith
|
a65c11fba8
|
feat: Pages section in header (#30175)
## Description This PR adds the pages section toggle in the header #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29955 #### Media https://github.com/appsmithorg/appsmith/assets/87797149/fb0545ac-d362-4bc3-b2cc-85435f5decf0 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Implemented functionality to manage the active status of IDE editor pages. - Introduced new `DefaultTitle` and `EditorTitle` components for improved title display in the IDE. - **Enhancements** - Updated editor pane to reflect active status of pages for better user experience. - Enhanced IDE header to dynamically render titles based on the current application state. - **Refactor** - Replaced the `getIsSideBySideEnabled` with a new selector for active page status. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |