Commit Graph

527 Commits

Author SHA1 Message Date
arunvjn
4e5b21600d
Optimise code editor renders (#15405) 2022-08-04 11:10:44 +05:30
Aishwarya-U-R
8fd3b94f8c
test: Automated tests for Postgres Datatype - UUID Cont., + Flaky fixes (#15582)
* UUID continued

* Edit Obj save

* Added TypeTextIntoField()

* Added paste back to JSEDitor context

* ExecuteActions spec ts

* ApiOnPage load spec ts

* propPane.UpdatePropertyFieldValue update

* fix

* AddDsl method update

* UUID flake fix

* DS docs spec

* GS & Firestore stub specs ts

* faliure fixes

* title fix

* Promises flake fix

* UUID update

* Autocomplete bug file name update

* Restapi flaky fix

* Flaky fix

* UUID fix

* UUID done

* UUID fix

* UUID fix

* Promy fix
2022-08-04 10:18:15 +05:30
arunvjn
7c37f7b35a
Add a new rule to show selectedRow in autocomplete's best match (#15406)
Refactored auto complete sorting logic.
2022-08-03 12:54:38 +05:30
Hetu Nandu
887832d29a
refactor: deprecate commenting and notifications (#15484) 2022-08-03 12:32:49 +05:30
Nidhi
02aa9b29bf
fix: Reset sync function fields on each update (#15442)
* Reset sync function fields on update

* Partial cypress test

* Completed cypress test

* Uncommented every other test :P
2022-08-03 10:11:02 +05:30
Aishwarya-U-R
5369edc245
test: Automated tests for Postgres Datatype - UUID + Flaky fixes (#15535)
* Binary spec updated

* flaky fix

* Removed skip, added only - recaptcha spec

* fix

* Reduced defaultCommandTimeout

* Adding global timeout

* failure fixes

* toForceClick to btn clicks js

* Elastic search flaky fix

* Passing Params - moved to CreateDs()

* Combining similar cases

* Removing unsed variables

* JSON Form widget specs moved

* flaky fix

* Mock db duplicate handling

* UUID added

* UUID spec update

* S3 fix
2022-08-01 17:16:00 +05:30
Aishwarya-U-R
73c0c9eecd
test: Automated tests for JSObjects + Flaky fixes (#15269)
* FOcusElement

* Specs into folders

* Bug14987_spec.js flaky fix

* S3 flaky trial fix

* CreateQuery() added

* Spec rearranged

* Sepcs rearranged

* MySql table load fix

* Added bug id JSOPageLoad

* Postgress idle connections spec fixed

* fixes

* fix

* fix

* Import fix

* Mock DB spec added

* flake fix

* Flake fix

* fix custom_chart_spec and gitSyncedApp_spec tests

* JSOnLoad after Import app scripted

* fix

* mock db name fix

* fix

* tc #58 scripted

* fix

* fixes

* moved spec

* increased wait time

* table filter fix

* Import time fix

* jsONload spec fix

* jsonload spec fix

* failure fixes

* "videoCompression": false

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 14:18:25 +05:30
Parthvi
ed90490005
test: fix git cypress tests (#15508)
* fix git tests

* add wait for git status call to complete

* fix git tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 08:33:32 +05:30
Parthvi
f60e78c972
test: Fix flaky cypress tests (#15437)
Fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-26 08:55:48 +05:30
Favour Ohanekwu
0f92b97226
feat: Triggerpath dependency (#15015)
* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 21:31:08 +01:00
Favour Ohanekwu
243dc7f477
Improve lint error reporting (#15098)
Core changes in this PR

    Prevents logging of lint warnings (not errors) in the debugger
    Refined message for using 'await' in non-async functions
    Show lint error messages that include line numbers (previously weren't shown)

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-21 18:31:23 +05:30
Nidhi
50172ecd64
fix: Added support for self signed certificate during OAuth2 flows (#14719)
* Added support for self signed certificate during OAuth2 flows, server side changes

* fix: authentication.useSelfSignedCert key added

* Merging from release

* Fixed issue with dependencies, plus bug with using ssl

* Cypress test attempt 1

* Cypress test attempt 2

* Cypress test attempt 3

* Clean up

* Review comments

* Enabled compression again

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-07-21 16:10:36 +05:30
Sumit Kumar
fc65216782
fix: fix race condition on datasource creation (#14348)
* fix race condition on datasource creation for non-clustered setup
2022-07-20 23:31:50 +05:30
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 (#14158)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* refactor code to migrate from org to workspace

* migrated a few missed out org to workspace

* updated a few more

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* reverted code change

* few more changes

* fixed failing cypress test

* fixed failing cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
Preet Sidhu
c03fddf1c9
fix: Improve CodeMirror rendering performance using idleCallback (#13676)
* working editor wrapper

* updated other property controls

* fix tablefilter_spec unit test

* autofocus on editor

* update font styles

* show lint errors

* add syntax highlighting

* fix import issue

* fix input height

* use lazy and suspense

* wip

* update code clean up

* update input style

* fix select widget issue

* fix build issue

* fix import issue and linting css

* update lint error method

* add polyfill for idle callback

* fix undo aggregate helper changes

* rename CodeEditor component

* fix tests add delay before code mirror

* undo name change

* rename lazy editor

* add comments and update aggregate helper

* fix cypress helper

* fix testJsonText command

* update aggregate helper

* add wait to allow time to load

* fix filepicker issue

* fix currency input test

* fix unit tests

* update aggregate helper

* fix table property tests

* fix test

* fix command

* update json text command

* updated command ii

* update iii

* update iv

* add force click

* check for wrapper

* fix for objects

* fix test iv

* fix test v

* fix tests vi

* fix tests vi

* fix variable naming issue

* fix tests vii

* remove wait from wrapper click

* fix tests viii

* fix recheck wrapper availability

* fix updateCodeInput command

* fix undo while loop

* fix ix

* fix each loop

* removed EnableAllCodeEditors

* updated tests

* Upated wait

* updated some more tests

* updated wait time

* updated common method

* updated all related common methods

* update state name and add callback timeout

* updated test

* updated the test

* fix use while loop and update count

* update click func

* fix use get instead of find

* fix on click action command

* remove comments

* fix: update import statements

* add force click to widget command

* update wrapper ui

* fix auto load code editor

* update editor wrapper ui

* fix lineheight adjustment

* refactor editor wrapper

* update style import

* fix ascetic style import

* fix font style

* fix wrapper height

* update color for code block

* fix min height of content wrapper

* remove error linting and editor wrapper

* remove unused variable

* remove unused imports

* fix font color for objects

* update styles for placeholders

* remove console log

* remove react syntax highlighter

* cancel idlecallback on unmount

* Delay input foucs

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-20 14:56:12 +05:30
f0c1s
58dac0213c
Regenerate SSH key in connect and import flow (#14383)
As of today, we were supporting only ECDSA keys for GitHub, GitLab, and BitBucket. For Azure, RSA key generation was not available. This PR allows users to generate RSA or ECDSA keys.

As of now we support following key types and version control service providers:

    Github: ECDSA
    Gitlab: RSA, ECDSA
    Bitbucket: RSA, ECDSA
    Azure: RSA

Fixes #14382, #14715, #14570
2022-07-20 12:30:11 +05:30
f0c1s
6eaabc3a7b
fix: reload default page on discard (#14964) 2022-07-20 11:40:06 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Hetu Nandu
5d568b7a6f
fix: Tooltip for long names in Entity Explorer (#15068) 2022-07-20 06:06:11 +00:00
akash-codemonk
086ac89565
fix: query forms which require evaluation shows loading (#15272) 2022-07-19 12:16:07 +05:30
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
Parthvi
af2e55ef31
test: Add tests for bugs and fix flaky cypress tests (#15115)
* Fix flaky tests 

* fix discardChanges_Spec

* comment the intercept in merge method

* add test for bug#15175

* add test for bug

* fix git tests
2022-07-15 11:36:58 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
Nidhi
02a5e1d490
fix: Added dropdown to select whether to send credentials in header or body in client credentials flow (#14545)
* Added dropdown to select isAuthorizationHeader in client credentials flow

* Added tests

* Added cypress test

* Oopsie
2022-07-13 14:33:19 +05:30
ChandanBalajiBP
a99176fae9
fix: Outdated design for Rest API Editor (#13812)
* Outdated design for Queries/JS/API Editor

* updated cypress test cases and colors reference

* updated cypress test cases with add and delete datasource

* added indexing for testcases

Co-authored-by: Chandan Balaji <chandanbalaji@Chandans-MacBook-Pro.local>
2022-07-08 20:01:12 +05:30
Ayangade Adeoluwa
57dba485ce
fix: fixes google sheets datasource global search error (#15020)
* fixes google sheets datasource global search error

* Adds cypress test

* Fix cypress test

* Fixes navigating to google sheets queries from global search issue
2022-07-08 18:27:59 +05:30
Parthvi
1f7b923ad9
test: Automate JSObject app in cypress and fix few flaky tests (#14613)
* add tests for promises

* update dsl

* fix deleteBranch_spec

* fix ImportExportForkApplication_spec

* update test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-08 16:18:20 +05:30
Anagh Hegde
883d9d801e
chore: Refactor git api to include application id as request param instead of the path variable (#14800)
* Refactor git API's to add `/app` to the API path to identify the appId

* Update the url in cypress tests

* Update the path in git spec cypress files

* Update the url for connection spec
2022-07-07 12:35:03 +05:30
Bhavin K
1ca40f9eeb
fix: show the error message for text input widget (#14934)
* fix: show the error message for text input widget

* Update the error message & added releated new test case
2022-07-07 05:37:54 +00:00
Aishwarya-U-R
a5ff06ad7e
test: Script fixes for failing cases due to UQI css changes (#15037)
* flaky fixes

* Eval value pop up hinder fix

* JS delete from EE fix

* ActionContextMenuByEntityName() fix

* Adding Escape()

* Toasts handling
2022-07-06 20:52:24 +05:30
Aishwarya-U-R
10fe3e3acf
Automated tests for Postgres Datatype - JSON type (#14796) 2022-07-06 11:24:00 +05:30
Nidhi
906a7298dc
feat: Simplified Google Sheets queries (#14869)
* Client changes 1

* add DSL functionality

* Temp commit for refactoring changes

* Do I even know what I'm doing here?

* chore: Second GS layout

* Update: Visibility conditional outputs for schemas

- Added the output from conditional outputs for schema children too

* Update: Entity selector visibility control

- Added logic for controlling visibility of sub components via the JS expressions system

* Update: Passing disabled prop to toggle button

* Update: Passing disabled prop to toggle btn

* Update: Styled component for toggle button

- Added disabled styles based on the disabled prop sent to the toggle form view JSON button

* Update: configProperty role in Entity Selector

- Removed dependance of the configProperty of the entity selector children to it's parent component

* Update: type of placeholder key

- Made placeholder key from form config JSON to accept either string or an object
- Earlier only string was accepted
- This is for pagination component

* Update: Added placeholder control for pagination

* Client changes 1

* add DSL functionality

* Do I even know what I'm doing here?

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design

* fix: updated tooltip component for wrong ui on entity explore

* temp triggers

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design (#12395)

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design

* fix: updated tooltip component for wrong ui on entity explore

* fix: updated tooltip ui, where condition placement, sort by ui

* temp form data access logic

* fix: updated sorting type width ui

* fix: updated ui for spacing, width and text issues

* Update: Type for tooltip of UQI forms

- Added option to send an object to the tooltipText object.
- This allows for composite components like pagination to have tooltips for each sub component

* Update: tooltip for pagination component

- Added handling to parse the tooltip for multiple components.
- This allows for composite components like pagination to have tooltips for each sub component

* Update: Type cast for tooltip component

- Made the content passed to tooltip component as a string only

* Update: Fixed tooltip component CSS

* Update: Dropdown option component

- Added a tooltip wrapper to each option
- This is to show on hover text like disabled state

* fix: updated ẇhere clause broken ui for condition

* Add: functions to check and extract expressions

- Loop through the formConfig and find any keys that have a value that is bindable
- Used pre defined regex to check if value is a moustache binding

* Add: Types for evaluated form configs

- Added types for the form configs to be evaluated and their output post eval

* Add: Flow to run the form config

- Run the form config and update the result to the redux state

* Update: Name of the type for formconfigs

- Updated since it was clashing with a component of the same name

* Add: Function to enforce config type checks

- This is done so that the improper configs can be weeded out and the rest of the form can be shown

* Add: Function to update evaluated config

- Added option to update the config if it's values needed evaluation

* Add: Type check for schema sections

* Update: Error handling for invalid control type

- We were throwing an exception till now, changed it to a warning text

* Add: Exposed tooltip for dropdown option disabled state

* Update: switch to json mode functionality

- Added logic to convert data to a string rather than an object when the first switch to JSON mode happens

* Update: Added key to tooltip for dropdown options

* Trigger API modification

* Add: function to fetch default trigger URL

* Update: Made URL optional in dynamic trigger config

* Update: Dynamic trigger API call

- Made the API call for dynamic triggers have URL as optional field
- Added type check to the response of the API call

* Update: resp type for trigger APIs

* Update: Moved code to utils folder

- Moved functions for UQI form eval processing to utils file

* Update: passing original controltype to JS switch

* Update: config for JSON editor mode

- Updated the config to have different options for JSON mode depending on the original control type

* Update: Connected line numbers flag to config

* Revert: CSS changes for tooltip

* Refactor: Removed consle

* Add: type for the config of dynamic values

* Add: Feature to evaluate config for triggers

* Refactor: fix type check errors

* fix: dropdown ui width with text alignment

* Update: fixed selector for dynamic values

* Update: selector call for fetchDynamicValues

* Add table header index prop for columns selector

* migration partial commit

* migration partial commit

* Refactor: removed unused import

* Update: reused function for checking dynamic value

* Update: removed unused import

* Fix format JSON issues

* Retrieve binding paths from entity selector components

* Fixes 6 remaining issues with UQI implementation

* Fix dropdown issues

* Fix dropdown height issues and fixes triggering of APIs when option is deselected

* Migration changes

* Fix QA generated UQI issues

* Fix projection component height and route change logic

* Fix multi select dropdown placeholder text issue and json stringify issue with switching view types

* Reset entity type value when command value changes

* Test changes

* Review comments

* Moved migrations around

* Corrected import statement

* Added JSON schema migration

* Updated schema version

* perf improvements and filter dropdown options feature

* Fix Code mirror component config for toggleComponentToJson input fields.

* Fix prettier issues

* fix prettier issues

* Fix style issues as a result of the merged conflicts

* Fix failing test case

* Fixed a few other flows (#14225)

* Fixed a few other flows

* Review comments

* Fix generate CRUD, fix evaluation of dynamic bindings and fix various styling issues.

* More fixes (#14367)

* Factor in the root formconfig parent key.

* Fix flickering issues, and evaluatedFormConfig issues

* fix: Teeny bugs (#14455)

* Teeny bugs

* Added previous functionality as is

* Improvements in the way we fetch dynamic values

* Fix stringiification issue and cyclic dependency issues

* Resolve projection component values deletion

* Resolve merge conflicts and fix prettier issues

* fix: Tsc issues

* Fix property pane connection navigation

* updating ee locator

* updating inputfield locator

* dropdown locator update

* Merge conflict not properly resolved.

* Fix s3 spec

* Fix Mongo Spec

* Fix some more tests

* fix: prevent cyclic dependency when switching to js mode (#14668)

* add delete events for change from array to string in diff

* add test to assert absence of cyclic dependency error when switching to js in switchgroup widget

* Assert that evaluation is not disabled when no cyclic dependency happens

* Cypress test preparations for google sheets and form controls

* Fixed a few test errors (#14874)

* Add: unit tests for uqi UI updates

- view type tests
- conditional output extraction
- processing conditional output to handle view/enabled state of the component

* Add: completed isValidFormConfig test

* Update: improved tests for update config

- These tests cover the functionality to update a section config after it's components are done evaluating

* Fix failing cypress tests and cyclic dependency issue

* Fixes some more tests

* Fixed migration of row objects (#14896)

* Bumped the version of design system package

* Update: reverted change to EE selector

* Fix deletion pointer

* Update: selector for js on load spec

- Synced with changes related to ADS dropdown

* Fix mongoDBShoppingCart spec

* Remove comments

* Fix: mongo shopping cart test failures

* fix: mongo shopping cart spec

* Dummy push to retrigger vercel

* fix: mongo shopping cart spec

* Update MongoDBShoppingCart_spec.js

* fix: removed unused click away

* dummy commit

* Update: moved helper functions to separate file

* Add: added tests for saga functions

- Worked on testing for
   - extractFetchDynamicValueFormConfigs
   - extractQueueOfValuesToBeFetched

* Add if check for queueOfValuesToBeFetched

* Resolve review comments

* Empty-Commit

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-07-04 11:13:27 +05:30
Favour Ohanekwu
11f8684e7f
fix: prevent temporary update of sub-path value in store object (#14847)
* support paths as keys in storevalue

* add cypresstests

* StoreValue added deploy mode verification

* Adding array input [boolean, string, number]

* store number too

* Added bug id to title

* Added dot object array & SelectJSFunctionToExecute

* propPane.UpdateFieldValue() update

* updated UpdatePropertyFieldValue

* JS toasts handling

* JSOnload spec fix

* JsOnload toast appearances fix

* support paths as keys in storevalue

* add cypresstests

* StoreValue added deploy mode verification

* Adding array input [boolean, string, number]

* store number too

* Added bug id to title

* Added dot object array & SelectJSFunctionToExecute

* propPane.UpdateFieldValue() update

* updated UpdatePropertyFieldValue

* JS toasts handling

* JSOnload spec fix

* JsOnload toast appearances fix

* prevent modification of storeValue path in temporary store

* Add cypress tests for case where storeValue key is a path

* remove redundant import of lodash

* Modify cypress tests

* update cypress tests

* Store fix revert

* revert

* Actions revert

* revert redundant change

* removed additional button- from script

* JsOnPage load script fix

* validate toast fixes

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-01 06:26:57 +01:00
Parthvi12
cc3b10c9a6
test: Add visual tests for datasource page (#14811)
* add layout tests for datasource

* fix omnibar_spec

* add tests for postgres and mong

* fix git import test

* fix test

* comment test until issue is fixed

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-01 09:01:02 +05:30
Favour Ohanekwu
41789c71bc
fix: show js function execution errors in debugger (#14555)
* Show js function execution error logs

* remove unused function

* improve check for async functions

* clear errors for deleted jsActions

* fix typescript error

* modify js function execution error logging

* test that execution parse errors are logged in the debugger

* Add test to show that js execution errors are logged in the debugger

* re-order js execution tests

* Add type to jsObj variable

* update cypress tests

* update cypress test
2022-06-30 08:21:20 +01:00
Rishabh Rathod
8bfc3ee87e
fix: store value spec as JsObject bug is resolved (#14788)
* fix: store value spec as JsObject bug is resolved

* fix test

* Use GetNClick

* StoreVal trial fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-29 17:47:14 +05:30
ChandanBalajiBP
be626a132e
Merge pull request #14103 from appsmithorg/Fix/Mismatch-with-design-in-Sample-Datasource-Card
fix: UI inconsistencies in Datasource card and page
2022-06-29 17:32:43 +05:30
Bhavin K
a2dd01806c
fix: remove the duplicate and rename the actions to events in property panel (#14714)
* Fix: Remove the duplicate & rename the "Actions" To "Events"

* rename the "Actions" to "Events" in select & multiselct widget

* Trigger Build

* fix: failed testcase are resolved
2022-06-29 11:54:50 +00:00
Rishabh Rathod
5625784829
fix: reset meta to default value (#14468)
* fix: [WIP] reset meta to default value

* refactor

* fix reset child widget and type in metaReducer

* Fix type and refactor test

* fix multiselect click

* Add jest test for reset widget action

* Add cypress test

* Add comments

* Add more cases as per comment

* remove `only` from test case

* Add default value case of array with values

* MultiSelect spec fix

* fix currencyInput reset

* refactor test code suggested in comments

* fix type

* fix more type

* fix cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-25 11:00:54 +05:30
Aishwarya-U-R
9774118b8b
test: Automated tests for Postgres Datatype - Boolean & Enum (#14778)
* BooleanEnumDT spec added

* failure point fixes

* Snaps paths updated

* Unskipping cases

* BoolEnum query create fix

* list_regression fix
2022-06-24 13:52:29 +05:30
Aishwarya UR
906cbe1f3f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-23 21:01:19 +05:30
Aishwarya-U-R
5d75a46df1
test: Automated tests for Bug #14299 + Specs rearranged (#14632)
* Moving tests

* Workspace cases moved all to one folder

* Moving tests

* Bug 14299 scripted

* JSOnload spec failure fix

* Moving spec

* Moving specs

* Moving specs

* Added bug id in title

* Moving specs

* Moving specs

* Moving spec

* Added bug id in title

* Removed tests

* Theme Basic spec - added publish mode validations

* tests re-arranged

* Theme_form widget fix

* endp to endpoint change

* theme Basic spec fix

* AppSetupForRename removed

* Appli rename reverted

* Specs rearranged

* Added interval validation

* Also deleting query

* validation moved places

* Git imports corrected

* git import corrected

* datePicker fix
2022-06-23 20:43:15 +05:30
subratadeypappu
704d19ac4f
Merge pull request #14233 from appsmithorg/fix/14054-describe-table-in-mysql
fix: Show table structure when desc table or describe table command is run stand-alone in MySQL (#14054)
2022-06-23 19:38:20 +06:00
ChandanBalajiBP
abaafab74b Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-22 17:43:51 +05:30
Tolulope Adetula
7ba4f0679a
Merge pull request #13129 from appsmithorg/fix/12161-multiselects-broken-in-modal
fix: Popover in Multi select widget inside modals breaks away from the widget
2022-06-22 09:59:00 +01:00
Vishnu Gp
63205dce27
Merge pull request #14184 from appsmithorg/feat/git-delete-only-removed-resources
Feat: Perform file ops only when the resource is updated
2022-06-22 10:53:45 +05:30
Tolulope Adetula
31f91f6e1c fix: use ESC to close dropdown 2022-06-22 01:11:29 +01:00
Tolulope Adetula
5af2839220 fix: popup issue 2022-06-21 12:22:55 +01:00
ChandanBalajiBP
3b60d16d1f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-20 13:38:38 +05:30
subrata
4abbd9c0cf Merge branch 'release' into fix/14054-describe-table-in-mysql 2022-06-20 09:06:16 +06:00
Aishwarya UR
673bcea321 Bug 14054 scripted 2022-06-17 17:01:40 +05:30
Aishwarya-U-R
3622bf924e
Automated tests for Postgres Datatype - Datetime (#14607) 2022-06-17 11:42:18 +05:30
Aswath K
478ae29b34
feat: Disable js toggle button if field is not empty (#12754)
* feat: Disable js toggle button if field is not empty and on non-default value

* allows certain values based on control type

* adds handling for more control types

* Change disabled message

* feat: makes option control delete button keyboard accessible

* adds support for theme values

* Adds support for border radius & box shadow controls

* message change and refactor

* minor correction in the message

* Add proper condition for Datepicker control

* fix one cypress test

* updated tests

* add checks for OptionControl

* Updated table binding test

Co-authored-by: apple <nandan@thinkify.io>
2022-06-16 15:17:35 +05:30
Aishwarya-U-R
d7eb5c58fc
Automated tests for Postgres Datatype - Numeric, Character (#14481) 2022-06-16 12:20:02 +05:30
ChandanBalajiBP
24d1ac1018 added test cases with requireed changes 2022-06-16 11:48:44 +05:30
Ankita Kinger
9b7944e7ee
feat: migrate organisation to workspace (#13863)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* migrated a few missed out org to workspace

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* fixed AppsmithRole

* mongodb version update

* fixed compile error

* fixed compile issue

* fixed some tests

* simplified embedded mongodb config

* updated a cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-06-15 21:07:41 +05:30
Favour Ohanekwu
6c45270def
fix: order async functions in settings tab alphabetically (#13731)
* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* fix merge conflict

* JSFunctionnExe spec flow fix

* update cypress tests

* update cypress tests

* add test case for cloning page

* Datatypes - Numeric spec addition

* failure fixes

* JSfun failure fix

* Postgres failure fix

* JSFuncExecutions failure fix

* MySQL failure point fix

* COmmunity issues wait time fix

* Fixing toast mesg validation point

* Reverting all fixes

* Revertion

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:46:53 +05:30
Pawan Kumar
89bf40e3d7
fix: Toast shows wrong theme name when changing themes (#14488)
* fix typo in toast when changing theme

* fix cypress test

* Added wait time!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:21:37 +05:30
Aishwarya-U-R
43cba21013
test: Automated tests for improved CRUD with JSONFrom - Postgres Ds (#14271)
* Postgres CRUD

* MySQL CI run fix

* Added wait time to DeployApp()

* Helpers Enhancements

* ChangeTheme CRUD

* Postgres CRUD

* Postgres CRUD updated

* Postgres CRUD updates

* Postgres CRUD fix

* Postgres CRUD update

* postgres CRUD update

* Postgress CRUD fix

* setting cypress video false

* ExecuteAction spec fixed

* Postgres case #13 fix

* postgres CRUD fix

* Postgres CRUD fixes

* cypress video - true, reattempt - 1

* failure fixes

* Bug 11529 script added

* Bug 11529 scripted + failure fixes

* JSOnLoad_spec failure fix

* OnLoadActions failure fix

* Failure fixes

* ReadTable increased timeout

* JSFunctionExecution_spec failure fix

* Removed duplicate cases

* Mongo failure fixes + applying theme

* Mongo Spec - Added Deletion of DS also

* Deleting initial page

* Deleting DS Validation added

* tc desc updated

* failure point fixes
2022-06-10 19:00:59 +05:30
rahulramesha
c1da8a6866
fix: paste widgets on a new page (#14295)
* paste widget on generate Page

* adding cypress tests
2022-06-09 17:17:47 +05:30
balajisoundar
265ed0dc25
fix: Improve cell overflow check logic when switching between table page (#14095)
* fix: Improve cell overflow check logic when switching between table page.

* Table locators update

* Migration spec - locators update

* Migration spec locators update

* MongoDBShoppingCart spec locators update

* POstgress Spec locator fix

* Adding wait!

* Mongo DBcart spec fix

* EchoApiCMS_spec locator update

* Table locators update

* updated locators

* Added delay

* Hidden column fix trial

* Adding refresh page

* Adding time

* Fix cypress xpaths

Co-authored-by: bhavin <techbhavin@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
2022-06-08 21:59:31 -07:00
RakshaKShetty
221d9c0a7c
test: git delete branch tests (#14047)
* gitdeletebranchtests
2022-06-08 17:14:15 +05:30
Favour Ohanekwu
d5da24e51e
fix: cyclic dependency in renaming js objects (#13914)
* keep localunevaltree update in sync with unevaltree

* undo tree check

* identify .data difference for js objects

* empty line

* unit test

* unit test name change

* comment

Co-authored-by: Anand Srinivasan <anand.a.srinivasan@outlook.com>
2022-06-08 08:47:59 +01:00
Parthvi12
38f14bb5ac
test: Add regenerate SSH key tests (#14325)
* Add regenerate SSH key tests

* fix flaky tests

* fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-08 13:07:00 +05:30
Aishwarya-U-R
98c06e2817
Automated tests for improved CRUD with JSONFrom - Mongo Ds (#14191) 2022-06-06 11:29:15 +05:30
Aishwarya-U-R
6c1c5581e7
Automated tests for improved CRUD with JSONFrom - MySQL Ds (#14014) 2022-05-31 11:03:59 +05:30
NandanAnantharamu
6359bfcfbe
test: List testcases (#14009) 2022-05-26 13:25:08 +05:30
Ankita Kinger
fa45282b0a
fix: alignment of the image seen on no search results on application page (#13950)
* fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)

* add debounce to search and remove state var

* increase debounce time

* fix: updated the condition to show expiry key (#13092)

* Add index for git (#13133)

* fix: Fixed compile time errors

* fix: Unable to see apps in home page after git connect fails (#13387)

* Fix Redis installation in Dockerfile (#13428) (#13430)

Conflicts:
	Dockerfile

* fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)

* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections

(cherry picked from commit 7261834fe5)

* fix: NPE check when datasource createdAt is null

(cherry picked from commit beafb371b24180dce2e351f1dea6d9d34db2a204)

* fixed image alignment for no search results on applications page

* deleted duplicate file

* reload to Refresh script update

* Adding sleep - script fix

Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Rimil Dey <rimildeyjsr@gmail.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-26 10:05:35 +05:30
Favour Ohanekwu
7bbd109f62
fix: improve jseditor linting performance (#14001) 2022-05-25 18:08:35 +02:00
Aswath K
c8e79eca95
feat: Focus widget name or first property when opening property pane (#13513)
* feat: intial investigation.

* Completed focusing of Property title

* removes unused import

* fix issue with inability to focus Dropdown

* checks if PP opened not because of focusing on input elements in widget

* Adds two level of focus for LocationSearch

* adds multi state to KeyValue component

* Adds multi state to Draggable List as well

* Adds multi state to DatePickerControl

* fix: style issue with draggableList & KeyValue comp

* avoids auto focusing on Panel

* remove commentedout code

* fix: cypress tests

* change ActionConstant name

Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-05-25 15:35:53 +05:30
Rishabh Rathod
cbce8f8b8e
fix: trigger consuming previous evaluated values (#13084)
We are changing how we maintain meta values in our architecture,

Earlier metaHOC component state was used to store meta values that were debounced and pushed in batch to metaReducer and trigger evaluation.
We remove the metaHOC state and directly update values to metaReducer and trigger evaluation separately via a debouched function.
2022-05-25 15:16:14 +05:30
Aishwarya-U-R
d0fed6bfe7
Automation script update to fix Community issues failure (#13968) 2022-05-23 10:50:27 +05:30
arunvjn
9753df54f4
fix: remove transition delay in the switch between explorer and widgets. (#13942) 2022-05-20 10:32:13 +05:30
Favour Ohanekwu
2748ed0e64
fix: prioritize parse errors in debugger callout (#13765)
Prioritize parse errors over lint errors in debugger callout
2022-05-19 11:57:49 +01:00
Ayangade Adeoluwa
f7107a4a0a
Fix response tab overflow issue (#13839)
This commit fixes three things

- It prevents the tab headers from being scrolled up when on the RAW/JSON tabs.
- It prevents the Table component from pushing the API right pane away when its contents are too wide.
- It also prevents the table and JSON component from clipping the data displayed within them by adding margins/paddings between them and the parent container.
2022-05-19 08:32:43 +05:30
Ayangade Adeoluwa
1ee494b9ca
fix: Fix validation check that is blocking input from changing (#13943)
* Fix validation check that is blocking input from changing

* Add testcases for Elastic search datasource

* Adds header value to test case

* Fix validation logic
2022-05-18 17:35:03 +00:00
Aishwarya-U-R
04a8c3b037
Tests for JSObjects-onPageLoad (#13712)
Automated tests to improve coverage for JSObjects-onPageLoad
2022-05-18 16:09:42 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows (#13257) 2022-05-18 04:46:25 +00:00
Parthvi12
32bcd94e54
Add tests for git discard changes (#13866) 2022-05-18 04:45:32 +00:00
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects (#13700) 2022-05-11 11:20:33 +01:00
NandanAnantharamu
7199a329a9
test: Theme related tests (#12740)
* Removed unwanted waits

* Updated test for fonts

* Updated tests with Font and Theme usecases

* updated tests

* Added new tests and common locators

* Added default/update theme tests

* grouped tests

* Updated Theme tests

* updated multiwidget test

* updated theme tests

* Updated tests

* Reordered tests
2022-05-11 11:43:28 +05:30
Aishwarya-U-R
f5cc98644f
Automated tests to TableFilterSpec for Bug #13334 + failure fixes (#13662) 2022-05-10 10:40:46 +05:30
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page (#13178)
* added cypress test of form login on admin setting page

* resotre setting after checked

* added a check if signup form is enabled for all users

* minor fix

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Aishwarya-U-R
e8c9d1da3e
test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes (#12904)
* Adding theming spec

* Removed theming spec

* Reverted cypress.json changes

* Adding more JSOnPage load validations

* Added Theming - comment spec

* Theming - new cases

* JSOnload fix

* JSOnPage load cases update

* Bind_tabWidget fix

* Name update to CommunityIssues

* Flaky fixes

* Flaky fix

* Reverting postgress index addition

* Failure fixes
2022-05-06 11:10:10 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component (#13105)
* fix: set max-height for Dropdown component

* changes style for date format dropdown

* Combines MultiSelectControl into DropdonwControl

* fix: max height set via props

* fix: popover double scrollbar issue

* fix: styles for chips

* Delete MultiSelectControl

* fix: error when pressing Enter twice

* add tests for multi select & fix some warnings

* removes unwanted test file

* fix: country filtering issue

* address review comments

* fix dropdown for primary columns dropdown

* fix: issue with position

* Adds scrollIntoView when using arrow key for navigation

* fixes issue with scrollbar

* fix: jest tests

* fix: jest test

* fix: flaky cypress test

* fix: height & align issue in Date format selection

* smoothens the scroll
2022-05-06 10:34:17 +05:30
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects (#13212) 2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Abhijeet
9fc9f7a774
chore: Commit application files during the connect flow (#12288)
* Commit application files during the connect flow

* Refactor detach remote method name

* updating connectToGitRepo method

* fix git tests

* Update default dsl to remove uncommitted changes for bottomRow and pathlist

* updating git cypress tests

* fixed git bug spec cypress test

* enabled other test case

* with store test

* fixed comment

* closing git sync modal

* updated test logic

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Parthvi12 <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-04 12:27:07 +05:30
Parthvi12
2f4ca6aa98
test: Add tests for git sync app and git bugs (#13394)
* Add tests for gitSync

* add test for git import bug#12749

* modified importAppfromGit method

* add test for bug #13385

* updated tests

* fixed test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-02 09:59:03 +05:30
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once (#13272) 2022-04-26 19:51:06 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name (#12930)
* Change response tab name

* Fix response tab name
2022-04-22 12:10:00 +01:00
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30