Commit Graph

1171 Commits

Author SHA1 Message Date
ashit-rath
07757c7e7b
fix: Replace "klona/full" -> "klona" in JSONForm to avoid cloning of non-enumerable properties (#13193)
- non-enumerable like `writable`, `configurable`, `enumerable` were getting cloned with `klona/full` and it wasn't needed.
2022-04-22 14:15:45 +05:30
Bhavin K
7e3d873d20
feat: added searched address into map center data (#12962) 2022-04-22 11:44:42 +05:30
Bhavin K
958233f4f5
fix: added dataFormat into file data (#12807) 2022-04-21 16:09:24 +05:30
Preet
19172bf2b6 reduce line break limits to 1000 2022-04-20 13:22:45 -04:00
Preet
eb4eaf849a Merge remote-tracking branch 'origin/release' into fix-10379 2022-04-20 13:20:22 -04:00
Paul Li
0771f23294 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Rename getDropdownPosition to getCloesetCanvas
2022-04-20 20:40:53 +08:00
Paul Li
ef56d732a8 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 20:36:53 +08:00
Paul Li
b2c1ebf736 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Makes getDropdownPosition as a widget utility function
2022-04-20 20:35:35 +08:00
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
Paul Li
9301bf9637 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Sets popover container to the closest canvas
2022-04-20 17:02:57 +08:00
Tolulope Adetula
a892aa678d fix: Table Multiselect checkbox alignment 2022-04-19 09:40:42 +01:00
Bhavin K
3575a03005
fix: updated cursor style in actionWrapper (#12850) 2022-04-18 11:39:11 +05:30
Preet Sidhu
820a99e5d1 disable html parsing for long texts 2022-04-15 10:03:38 -04:00
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
Rishabh Rathod
846ba223ea
fix: replace rfdc with klona (#12568)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-14 14:19:13 +00:00
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
rahulramesha
cfba555fe8
chore: Should not persist DSL for mainContainer layout changes (#12351)
* Moving out non persistent state out of DSL

* replacing canvas width seector

* converting to immerReducer

* adding TODO and more immer reducer changes
2022-04-14 10:06:20 +05:30
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30
Preet Sidhu
19d0db30b0
fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)
* add debounce to search and remove state var

* increase debounce time
2022-04-12 16:31:51 +00:00
Ankita Kinger
c1e48f7486
feat: Refactor code for SAML integration (#12700)
* Implemented code splitting of some files for SAML integration

* Implemented code splitting of some more files for SAML integration

* updated redirect url component

* fixed an import statement

* fixed a unit test

* updated restart banner tooltip logic

* updated an import statement
2022-04-12 16:20:01 +05:30
Tolulope Adetula
89fcc414e3
fix: remove internalKeys from Selected row and Triggered row (#12655) 2022-04-12 10:01:03 +00:00
Tolulope Adetula
52a51b882c
fix: select widget virtualization not rendering first top items (#12768)
* fix: select widget virtualization

* fix: use max height of renderMenuItem

* fix: make height a constant

* fix: variable name

* fixed spec

Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-04-11 18:20:01 +05:30
balajisoundar
6cdef28afa
fix: Phone and currency widget's dialCode and currencyCode should … (#12720) 2022-04-08 19:39:05 +02:00
ashit-rath
6a33b4da5a
fix: JSONForm select not working in nested fields - Array/Object (#12635)
* fix: JSONForm select not working in nested fields - Array/Object

* fixed merge-conflict missing import
2022-04-08 22:54:08 +05:30
imgbot[bot]
bc0325617c
chore: [ImgBot] Optimize images (#12266)
*Total -- 563.13kb -> 460.13kb (18.29%)

/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/EmptyApp.snap.png -- 17.86kb -> 11.54kb (35.43%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/quickPageWizard.snap.png -- 57.24kb -> 39.42kb (31.12%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/emptyAppBuilder.snap.png -- 74.00kb -> 51.48kb (30.43%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/apppage.snap.png -- 46.22kb -> 32.18kb (30.38%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/loginpage.snap.png -- 33.64kb -> 24.07kb (28.44%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/Profile.snap.png -- 29.72kb -> 21.58kb (27.4%)
/app/client/src/assets/gifs/table_data.gif -- 60.23kb -> 50.42kb (16.29%)
/app/client/src/assets/gifs/default_text.gif -- 90.40kb -> 75.70kb (16.26%)
/app/client/src/widgets/JSONFormWidget/icon.svg -- 0.47kb -> 0.46kb (1.66%)
/app/client/src/assets/icons/ads/js.svg -- 1.14kb -> 1.12kb (1.2%)
/app/client/src/assets/icons/ads/fork-2.svg -- 1.45kb -> 1.44kb (0.47%)
/app/client/src/assets/images/lock-password-line.svg -- 0.80kb -> 0.80kb (0.36%)
/app/client/src/assets/icons/menu/settings.svg -- 1.00kb -> 1.00kb (0.29%)
/app/client/src/widgets/CurrencyInputWidget/icon.svg -- 1.05kb -> 1.05kb (0.28%)
/app/client/src/widgets/PhoneInputWidget/icon.svg -- 1.47kb -> 1.46kb (0.2%)
/app/client/src/assets/images/saml.svg -- 2.71kb -> 2.70kb (0.18%)
/app/client/src/widgets/CircularProgressWidget/icon.svg -- 2.32kb -> 2.32kb (0.17%)
/app/client/src/assets/images/oidc.svg -- 19.98kb -> 19.97kb (0.05%)
/app/client/src/assets/images/request-template.svg -- 121.44kb -> 121.43kb (0.01%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2022-04-08 22:52:58 +05:30
Ayangade Adeoluwa
bc8d885813
feat: Response view switcher for all action editors (#9629)
* Response view switcher for all action editors

* fixes prettier issue

* adds correct type to responseDataTypes property

* fix some more conflicts

* Try a new  multi switch component

* Revert multiswitch changes

* Adds finishing touches

* remove warnings

* Fixing bugs, reusing logic
2022-04-08 16:32:34 +00:00
Paul Li
9219545879
fix: Form widget should include the following widgets in data property when added in form (#12529)
* fix: Form widget should include the following widgets in data property when added in form

-- Add value props to the widgets, including CheckboxGroupWidget, MultiSelectTreeWidget, MultiSelectWidgetV2, SingleSelectTreeWidget, SwitchGroupWidget
-- Add the corresponding Cypress test case

* fix: Form widget should include the following widgets in data property when added in form

-- Set the value meta propperty for PhoneInputWidget to empty string by default

* fix: Form widget should include the following widgets in data property when added in form

-- Include PhoneInputWidget for test

* fix: Form widget should include the following widgets in data property when added in form

-- Add InputWidgetV2 and CurrencyInputWidget

* fix: Form widget should include the following widgets in data property when added in form

-- Add SelectWidget for assertion

* fix: Form widget should include the following widgets in data property when added in form

-- Wait for @updateLayout

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
2022-04-08 21:07:10 +08:00
Tolulope Adetula
08246e7783
Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-08 09:02:06 +01:00
ashit-rath
99ec9e82e3
fix: JSONForm select/multiselect filterText value synchronous update with onFilterUpdate action (#12578)
* fix: JSONForm select/multiselect filterText synchronous update with onFilterUpdate action

* removed unused dep from useMemo
2022-04-08 11:39:23 +05:30
Tolulope Adetula
99a5b8ca69
Merge pull request #12356 from appsmithorg/fix/table-widget-scroll-issue
fix: remove unnecessary horizontal scroll when table columns fit within table widget width and prevent unnecessary re-renders
2022-04-07 19:46:43 +01:00
Yash Vibhandik
7736daf0a5
fix: 8385 added button variant support in table column type button (#9164) 2022-04-07 16:19:51 +00:00
Bhavin K
d22ae809cb
fix: handle duplicate tab name in tab widget (#12411) 2022-04-07 16:19:12 +00:00
Anand Srinivasan
ada1293797
Revert "fix: trigger fields linting issue (#11875)" (#12668)
This reverts commit 186a97c699.
2022-04-07 16:31:31 +05:30
Paul Li
7045416dd8
fix: Progress widget with circular type is showing wrong value (#12667)
-- Output progress value as it is
2022-04-07 15:39:35 +05:30
Paul Li
481c1297a7
fix: Auto-suggestion is not working for progress widget while binding (#12658) 2022-04-07 13:37:09 +05:30
Tolulope Adetula
25c0dabd7b fix: add HTML default for empty space 2022-04-07 05:23:08 +01:00
Tolulope Adetula
86ce80abc3 feat: add total records and pageCount to table header 2022-04-06 12:48:55 +01:00
Bhavin K
787df868bb
Revert "fix: #6518 Implemented responsive table header controls (#10971)" (#12583)
This reverts commit 88ad2bcbd1.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 11:07:13 +05:30
Tolulope Adetula
f7018314ab
Merge pull request #12541 from appsmithorg/fix/Align-Table-widget-URL-Column-type
fix: align Table widget URL Column type
2022-04-05 13:54:14 +01:00
Tolulope Adetula
470fd8da21 fix: Align Link icon with text 2022-04-05 12:22:33 +01:00
Arsalan
f5057c544e Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-05 14:47:39 +05:30
Tolulope Adetula
6b5a6ff8bf
Merge pull request #12459 from appsmithorg/fix/Multiselect-style-specificity
fix: Multi-select dropdown not closing properly
2022-04-05 09:07:54 +01:00
Tolulope Adetula
e05e75758d
Merge pull request #11383 from appsmithorg/feat/4182-form-detect-changes
feat: Internal property to detect changes in a form
2022-04-05 06:35:20 +01:00
Yash Vibhandik
88ad2bcbd1
fix: #6518 Implemented responsive table header controls (#10971) 2022-04-04 18:47:45 +05:30
Arsalan
c3f2ef1b03 fix: added helpful comments 2022-04-04 16:12:51 +05:30
Arsalan
2e2c0d977e Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-04 16:06:09 +05:30
Arsalan
a64c485f2d fix: remove renderMode prop from widget. 2022-04-04 16:05:08 +05:30
Arsalan
f525137f46 fix: Added DragContainer in all modes for tooltip. 2022-04-04 12:43:04 +05:30
Tolulope Adetula
c157c5fa72 fix: align Table widget URL Column type 2022-04-04 07:54:25 +01:00
Paul Li
dfd3662bd1 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-04 13:27:03 +08:00
Tolulope Adetula
3fb3eff92e
Merge pull request #12324 from appsmithorg/fix/default-value-for-select-widget
fix: default value consistency issues in select widget
2022-04-04 06:20:01 +01:00
Tolulope Adetula
be39074862 revert unnecessary changes 2022-04-04 06:18:03 +01:00
Tolulope Adetula
880cb75b3c fix: select dropdown 2022-04-04 06:12:33 +01:00
Paul Li
bbf7f12e4b Merge branch 'release' into feat/4182-form-detect-changes 2022-04-02 23:35:10 +08:00
Arsalan
abe304152c Merge branch 'release' into fix/button-group-undo 2022-04-02 18:07:58 +05:30
Paul Li
9590e0fc7a Merge branch 'release' into feat/4182-form-detect-changes 2022-04-02 00:13:16 +08:00
Paul Li
78e452634e
feat: Progress bar widget enhancements (#12053)
* feat: Progress bar widget enhancements

-- Scaffold the widget for the first time

* feat: Progress bar widget enhancements

-- Change widget icon

* feat: Progress bar widget enhancements

-- Build property pane

* feat: Progress bar widget enhancements

-- Add a missing property, counterClockwise
-- Rename some properties

* feat: Progress bar widget enhancements

-- Build the first MVP of the widget

* feat: Progress bar widget enhancements

-- Reset rows to 4

* feat: Progress bar widget enhancements

-- Add Cypress test cases

* feat: Progress bar widget enhancements

-- Limit value by ranging from  0 to 100

* feat: Progress bar widget enhancements

-- Make isIndeterminate property not to be JS convertible
-- Hide progress bar and circular progress widget icon from entity explorer

* feat: Progress bar widget enhancements

-- Place indeterminate circular progress to be 100% fit into the container

* feat: Progress bar widget enhancements

-- Show result without rounding for the circular type

* feat: Progress bar widget enhancements

-- Comment out ProgressBar_spec.js

* feat: Progress bar widget enhancements

-- Remove circular progress and progressbar widgets from allowed list for list widget

* feat: Progress bar widget enhancements

-- Move ProgressBar_spec into CommentedScriptFiles directory
2022-04-02 00:02:19 +08:00
Arsalan
9ccdde3b1b Merge branch 'release' into fix/button-group-undo 2022-04-01 14:28:01 +05:30
Paul Li
afb7b40a44 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 15:44:55 +08:00
Tolulope Adetula
ed7369493f fix: use default HTML ellipsis 2022-04-01 08:07:25 +01:00
Bhavin K
5124ae0322
fix: onclick handler update in ButtonGroup Widget (#12442) 2022-04-01 11:28:51 +05:30
Tolulope Adetula
4911aa3b65 fix 2022-04-01 06:10:51 +01:00
Tolulope Adetula
d6ee01ca29 Merge branch 'release' into fix/Multiselect-style-specificity 2022-04-01 05:25:20 +01:00
Tolulope Adetula
dabbbb0084 fix: css specitifity in MultiTreeSelect 2022-04-01 05:11:37 +01:00
Tolulope Adetula
b185119a79 revert css fix 2022-04-01 05:00:19 +01:00
Tolulope Adetula
9982593545 improve css specitifity 2022-04-01 04:58:17 +01:00
Paul Li
6d744859c6 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 04:14:05 +08:00
Tolulope Adetula
b65c0a21b7 fix: replace memoised value with state 2022-03-31 19:19:58 +01:00
Tolulope Adetula
da397d32f4 fix: css dropdown for multiselect 2022-03-31 17:19:29 +01:00
Paul Li
dc7b9a8b95 Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-01 00:18:16 +08:00
ashit-rath
50efc68fd3
fix: old list widgets incorrect page size (#12443) 2022-03-31 17:09:21 +02:00
Paul Li
4940d197b5 Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-03-31 20:24:50 +08:00
Anand Srinivasan
186a97c699
fix: trigger fields linting issue (#11875)
* initial fix

* fix warnings

* log evaluation order length

* log time

* logs

* re-order

* rename

* onclick vs release logs

* unit test for loading properties

* clean up

* ends with .tableData

* add comment
2022-03-31 17:07:18 +05:30
Abhinav Jha
2cd7dc9d88
Remove all references to WidgetIcons, as the icons now come from the individual widget folders (#12334)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-31 10:07:37 +00:00
Paul Li
c582ad22da Merge branch 'release' into feat/4182-form-detect-changes 2022-03-31 17:53:50 +08:00
Tolulope Adetula
a44e7b3f24 Merge branch 'release' into fix/default-value-for-select-widget 2022-03-31 09:31:47 +01:00
Tolulope Adetula
c0569b4a76 Fix: table widget scroll issue 2022-03-31 09:23:07 +01:00
Tolulope Adetula
2267a79899 Merge branch 'release' into fix/table-widget-scroll-issue 2022-03-31 07:13:44 +01:00
ashit-rath
8bdd631ee3
JSON form autogenerate control tooltip content changes (#12208) 2022-03-31 11:36:26 +05:30
Bhavin K
2b47e00a71
fix: add overflow property in text-widget (#12160) 2022-03-31 10:18:51 +05:30
Bhavin K
e5208b090e
fix: updated word-break for modal only (#12192) 2022-03-31 10:15:58 +05:30
ashit-rath
f8aaa2179f
fix: JSONForm date field tooltip visibility (#12299) 2022-03-31 08:32:57 +05:30
balajisoundar
ffc0f0e72f
fix: Currency input widget rounding off value if there is a trailing zero a… (#12325) 2022-03-31 08:31:04 +05:30
Paul Li
44685835ce feat: Internal property to detect changes in a form
-- Reset isDirty if defaultText is changed in PhoneInputWidget
-- Enable reset if defaultText is not empty in RichTextEditorWidget
2022-03-30 23:15:44 +08:00
Paul Li
93ae266672 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-30 21:45:40 +08:00
Tolulope Adetula
17a206c3dd
Merge pull request #12138 from appsmithorg/fix/multiselect-prepopulate-value-with-number
fix: Allow Multiselect DefaultValue to accept numbers
2022-03-30 14:33:59 +01:00
Paul Li
a1884e1336
feat: Hide shadows of hiddens objects during page loading in deploy view (#12184)
-- Does not render children of which isVisible is true in view mode
2022-03-30 21:22:01 +08:00
Preet Sidhu
c9069bedce
Merge pull request #11673 from appsmithorg/fix-11468_dropdown_performance
fix: 11468 select widget performance on a large data set.
2022-03-30 18:41:59 +05:30
Bhavin K
9f246f7d7a
fix: updated internal selectedDate condition (#12268)
* fix: updated internal selectedDate condition

* fix: updated cypress test case
2022-03-30 13:11:10 +00:00
Preet Sidhu
5cf633ba8d
Merge pull request #11812 from appsmithorg/fix-10771_text_widget_warning
fix: 10771 show text widget warning on exceeding line breaks limit
2022-03-30 18:40:51 +05:30
Bhavin K
806759d266
fix: added backdrop for menubutton (#12199) 2022-03-30 13:10:22 +00:00
Paul Li
54e925996a Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-03-30 17:59:06 +08:00
Paul Li
2ac3cff977 fix: Even disabled button tooltip should show
-- Introduce AnchorButton for the disabled button with a tooltip
2022-03-30 17:51:07 +08:00
Tolulope Adetula
5a87430e6a fix: table widget scroll when not needed 2022-03-30 01:40:56 +01:00
Tolulope Adetula
6aa2c36ea4 fix: test failure 2022-03-29 08:55:19 +01:00
Tolulope Adetula
e89c454ce5 fix: add cypress tests 2022-03-29 08:39:34 +01:00
Tolulope Adetula
a12c183c12 fix: default value consistency issues in select widget 2022-03-29 08:07:01 +01:00
Arsalan
d18ee573cb fix: Merge conflicts Resolved. 2022-03-28 18:21:06 +05:30
Preet
8734ae04f3 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-28 15:25:05 +05:30
Preet
738215931b Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-28 15:24:00 +05:30
Pallav Agarwal
b019fbae6f
fix: iframe srcDoc was not able to postMessage that can be received by onMessageReceived event. Match iframe by object not origin (#11809) 2022-03-28 13:12:12 +05:30
Paul Li
35b1546f78
fix: Button group widget's pop-over/drop-down enlarged along the width of the parent (#11804)
* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Implement dynamic width calculation

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add corresponding Cypress test cases

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add min-width CSS property for popover

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add a comment for minPopoverWidth

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Remove the comment for minPopoverWidth

* feat: Button group widget's pop-over/drop-down enlarged along the width

-- update the state variable, itemWidths inside setTimeout to access the updated DOM

* fix: Button gruop widget's pop-over/drop-down enlarged along the width

-- Refine update logic

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Make code DRY by creating createMenuButtonRefs and getMenuButtonWidths methods

* fix: Button group widget's popover/dropdown enlarged along the width

-- Make every popover class name unique

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Rewrite Cypress test

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Eliminate unnecessary test case from ButtonGroup_spec
2022-03-28 12:44:40 +05:30
Preet
0e5602e47e create an object for inline style 2022-03-28 11:33:43 +05:30
Tolulope Adetula
71284e2fc9 fix: add default error message 2022-03-27 07:06:34 +01:00
Preet
6902255b72 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:06:37 +05:30
Paul Li
d001aa81c5 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-25 17:29:04 +08:00
Preet
7b8a950b95 Merge branch 'release' into fix-10771_text_widget_warning 2022-03-24 20:46:18 +05:30
Preet
5b6d7623cc fix filter text 2022-03-24 18:27:39 +05:30
Preet
19c7786388 fix auto height of virtual list 2022-03-24 18:04:01 +05:30
Arsalan
543240017d fix: Merge Conflicts Resloved. 2022-03-24 15:32:21 +05:30
Tolulope Adetula
c82fa8fadb Merge branch 'release' into fix/multiselect-prepopulate-value-with-number 2022-03-24 08:39:49 +01:00
Tolulope Adetula
8b26bfc0c7
Merge pull request #12089 from appsmithorg/fix/MultiSelect-Default-Label-incorrectly-displayed
fix: multiselect default label issue
2022-03-24 08:37:15 +01:00
Paul Li
89e10add95
fix: Even disabled button tooltip should show (#12186)
-- Remove disable popover prop
2022-03-24 15:18:05 +08:00
Paul Li
c0a3bd27c8
fix: Switch group widget is crashed when selectedValues is undefined (#12095)
* fix: Switch group widget is crashed when selectedValues is undefined

-- Make selected prop for the component to return empty array if its value is falsy

* fix: Switch group widget is crashed when selectedValues is undefined

-- Add a Cypress test for the fix
2022-03-24 15:16:18 +08:00
ashit-rath
32fee08c5c
feat: JSON Form widget (#8472)
* initial layout

* updated parser to support nested array

* array field rendering

* changes

* ts fix

* minor revert FormWidget

* modified schema structure

* select and switch fields

* added checkbox field

* added RadioGroupField

* partial DateField and defaults, typing refactoring

* added label and field type change

* minor ts changes

* changes

* modified widget/utils for nested panelConfig, modified schema to object approach

* array/object label support

* hide field configuration when children not present

* added tooltip

* field visibility option

* disabled state

* upgraded tslib, form initial values

* custom field configuration - add/hide/edit

* field configuration - label change

* return input when field configuration reaches max depth

* minor changes

* form - scroll, fixedfooter, enitity defn and other minior changes

* form title

* unregister on unmount

* fixes

* zero state

* fix field padding

* patched updating form values, removed linting warnings

* configured action buttons

* minor fix

* minor change

* property pane - sort fields in field configuration

* refactor include all properties

* checkbox properties

* date properties

* refactor typings and radio group properties

* switch, multselect, select, array, object properties

* minor changes

* default value

* ts fixes

* checkbox field properties implementation

* date field prop implementation

* switch field

* select field and fix deep nested meta properties

* multiselect implementation

* minor change

* input field implementation

* fix position jump on field type change

* initial accordian

* field state property and auto-complete of JSONFormComputeControl

* merge fixes

* renamed FormBuilder to JSONForm

* source data validation minor change

* custom field default value fix

* Editable keys for custom field

* minor fixes

* replaced useFieldArray with custom logic, added widget icon

* array and object accordian with border/background styling

* minor change

* disabled states for array and objects

* default value minor fix

* form level styles

* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren

* added isValid for all field types

* fixed reset to default values

* debounce form values update

* minor change

* minor change

* fix crash - source data change multi-select to array, fix crash - change of options

* fix positioning

* detect date type in source data

* fix crash - when object is passed to regex input field

* fixed default sourceData path for fields

* accodion keep children mounted on collapse

* jest test for schemaParser

* widget/helper and useRegisterFieldInvalid test

* tests for property config helper and generatePanelPropertyConfig

* fix input field validation not appearing

* fix date field type detection

* rename data -> formData

* handle null/undefined field value change in sourceData

* added null/undefined as valid values for defaultValue text field

* auto detect email field

* set formData default value on initial load

* switch field inline positioning

* field margin fix for row direction

* select full width

* fiex date field default value - out of range

* fix any field type to array

* array default value logic change

* base cypress test changes

* initial json form render cy test

* key sanitization

* fix fieldState update logic

* required design, object/array background color, accordion changes, fix - add new custom field

* minor change

* cypress tests

* fix date formatted value, field state cypress test

* cypress - field properties test and fixes

* rename test file

* fix accessort change to blank value, cypress tests

* fix array field default value for modified accessor

* minor fix

* added animate loading

* fix empty state, add new custom field

* test data fix

* fix warnings

* fix timePrecision visibility

* button styling

* ported input v2

* fix jest tests

* fix cypress tests

* perf changes

* perf improvement

* added comments

* multiselect changes

* input field perf refactor

* array field, object field refactor performance

* checkbox field refactor

* refectored date, radio, select and switch

* fixes

* test fixes

* fixes

* minor fix

* rename field renderer

* remove tracked fieldRenderer field

* cypress test fixes

* cypress changes

* array default value fixes

* arrayfield passedDefaultValue

* auto enabled JS mode for few properties, reverted swith and date property controls

* cypress changes

* added widget sniping mode and fixed object passedDefaultValue

* multiselect v2

* select v2

* fix jest tests

* test fixes

* field limit

* rename field type dropdown texts

* field type changes fixes

* jest fixes

* loading state submit button

* default source data for new widget

* modify limit message

* multiseelct default value changes and cypress fix

* select default value

* keep default value intact on field type change

* TextTable cypress text fix

* review changes

* fixed footer changes

* collapse styles section by default

* fixed footer changes

* form modes

* custom field key rentention

* fixed footer fix in view mode

* non ascii characters

* fix meta merge in dataTreeWidget

* minor fixes

* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts

* modified dependency injection into evaluated values

* refactored fixedfooter logic

* minor change

* accessor update

* minor change

* fixes

* QA fixes date field, scroll content

* fix phone number field, removed visiblity option from array item

* fix sourceData autocomplete

* reset logic

* fix multiselect reset

* form values hydration on widget drag

* code review changes

* reverted order of merge dataTreeWidget

* fixes

* added button titles, fixed hydration issue

* default value fixes

* upgraded react hook form, modified array-level/field-level default value logic

* fixed select validation

* added icon entity explorer, modified icon align control

* modify accessor validation for mongo db _id

* update email field regex

* review changes

* explicitly handle empty source data validation
2022-03-24 12:43:25 +05:30
ashit-rath
b9ed9e74e8
fix: List widget inconsistent pageSize value with the number of item shown in the list. (#11355)
* fix - List widget inconsistent pageSize value

* consider data list length to calculate average gap

* update listdsl for List_spec

* minor change

* fix this.props.children mutation

* fix gridGap calculation

* minor spec change

* update listwidgetdsl.json

* reverted dsl update

* minor test dsl update

* minor averageGridGap calc fix

* minor change

* updated List_spec

* minor change
2022-03-24 12:41:33 +05:30
ankurrsinghal
6a503b4d57
Merge pull request #12007 from appsmithorg/fix/datepicker-resets-today-11837-2
fix: added bugfix for date parsing in datepicker widget 2
2022-03-24 12:31:03 +05:30
Paul Li
8820e4c7c9 fix: Even disabled button tooltip should show
-- Remove disable popover prop
2022-03-24 03:19:55 +08:00
Arsalan
86125dee5e fix: Merge conflicts resolved. 2022-03-23 20:28:12 +05:30
Tolulope Adetula
aa806de7ba fix: parsing unnecessary value 2022-03-23 13:08:32 +01:00
Tolulope Adetula
90dfa002fa fix: build issue 2022-03-23 07:25:20 +01:00
Tolulope Adetula
15c827bf87 FIX: BUILD ISSUE 2022-03-22 13:55:06 +01:00
Arsalan
e8566e10f8 fix: added missing semi-colon 2022-03-22 17:06:49 +05:30
Arsalan
035583e92d fix: ButtonGroup vertical orientation styles. 2022-03-22 16:47:06 +05:30
Tolulope Adetula
7d6bc6e2e5 fix: default value with number 2022-03-22 12:03:27 +01:00
Paul Li
2b278ee7a1 feat: Internal property to detect changes in a form
-- Merge componentDidUpdate methods
2022-03-22 18:09:52 +08:00
Tolulope Adetula
eec6b0e227 Fix: multiselect default label issue 2022-03-22 09:51:27 +01:00
Arsalan
b643ea7bb9 fix: Menu Button Table componenet Menu button order fixed. 2022-03-22 13:15:33 +05:30
Arsalan
bef9d2d81b fix: resolved disabled captcha click. 2022-03-22 12:22:39 +05:30
Preet
29fca665ef Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-22 11:39:44 +05:30
Paul Li
0e6ade690c Merge branch 'release' into feat/4182-form-detect-changes 2022-03-22 05:13:38 +08:00
Arsalan
f2ea8b1838 fix: Merge conflicts resolved. 2022-03-21 20:49:24 +05:30
Preet
7016f3d439 fix cypress tests 2022-03-21 20:15:17 +05:30
Ankur Singhal
d5afbd4629 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/datepicker-resets-today-11837-2 2022-03-21 15:45:20 +05:30
Preet
1595a7a61d move isNilOrEmpty to helpers.ts 2022-03-21 13:27:25 +05:30
Preet
84a2e96b6d Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-21 13:18:57 +05:30
Preet
4b27fdf643 fix select widget width 2022-03-21 13:18:51 +05:30
Ankur Singhal
3f0450ea96 added bugfix for date parsing in datepicker widget 2 2022-03-21 13:05:47 +05:30
balajisoundar
f1d1ee9ac0
fix: numeric type input widget should accept zero after decimal point (#11923)
- Derived properties of List widget children won't work. so having the text
  property of the Input widget as a derived property causes issues. hence
  having it as a meta property.
2022-03-18 22:18:16 +05:30
Arsalan
ec62586a44 fix: Replace GREY_4 with GREY_8 2022-03-18 16:23:02 +05:30
Arsalan
0bbe9fedbb fix: Fixed Icon Button onClick in disabled state. 2022-03-18 14:59:34 +05:30
Arsalan
83d166d42b fix: ButtonGroup, MenuItems update indexes. 2022-03-17 18:58:56 +05:30
Arsalan
37d9fd22bb Merge branch 'release' into fix/button-group-undo 2022-03-17 17:45:25 +05:30
Paul Li
3e37914b01 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-17 19:27:50 +08:00
Paul Li
dd49573d15 feat: 4182: Internal property to detect changes in a form
-- Eliminate unnecessary props
2022-03-17 19:26:24 +08:00
Arsalan
87c4645a87 fix: Button Group, MenuButton, Tabs undo Redo fixed. 2022-03-17 15:49:17 +05:30
Preet
53c8b18c79 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-17 11:56:44 +05:30
Preet
9003e6ddfb add unit test for Select Button 2022-03-17 11:49:35 +05:30
Arsalan Yaldram
9f51619b2c
Merge pull request #11865 from appsmithorg/fix/button-icon-alignment
fix: Button Icon Alignment on Icon Change
2022-03-17 11:12:15 +05:30
Preet
cd694540fd fix scroll behaviour on filtering 2022-03-17 11:10:22 +05:30