20b83faec4
9279 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
20b83faec4
|
chore: Revert "chore: bump tinymce from 7.0.0 to 7.2.0 in /app/client" (#34421)
Reverts appsmithorg/appsmith#34349 ## Automation /ok-to-test tags="@tag.Sanity,@tag.TextEditor" <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's changelog</a>.</em></p> <blockquote> <h2>7.2.0 - 2024-06-19</h2> <h3>Added</h3> <ul> <li>Added <code>options.debug</code> API that logs the initial raw editor options to console. #TINY-10605</li> <li>Added <code>referrerpolicy</code> as a valid attribute for an iframe element. #TINY-10374</li> <li>New <code>onInit</code> and <code>stretched</code> properties to the <code>HtmlPanel</code> dialog component. #TINY-10900</li> <li>Added support for querying the state of the <code>mceTogglePlainTextPaste</code> command. #TINY-10938</li> <li>Added <code>for</code> option to dialog label components to improve accessibility. The value must be another component on the same dialog. #TINY-10971</li> </ul> <h3>Improved</h3> <ul> <li>Dialog slider components now emit an onChange event when using arrow keys. #TINY-10428</li> <li>Accessibility for element path buttons, added tooltip to describe the button and removed incorrect <code>aria-level</code> attribute. #TINY-10891</li> <li>Improve merging of inserted inline elements by removing nodes with redundant inheritable styles. #TINY-10869</li> <li>Improved Find & Replace dialog accessibility by changing placeholders to labels. #TINY-10871</li> </ul> <h3>Changed</h3> <ul> <li>Replaced tiny branding logo with <code>Build with TinyMCE</code> text and logo. #TINY-11001</li> </ul> <h3>Fixed</h3> <ul> <li>Deleting in a <code>div</code> with preceeding <code>br</code> elements would sometimes throw errors. #TINY-10840</li> <li><code>autoresize_bottom_margin</code> was not reliably applied in some situations. #TINY-10793</li> <li>Fixed cases where adding a newline around a br, table or img would not move the cursor to a new line. #TINY-10384</li> <li>Focusing on <code>contenteditable="true"</code> element when using <code>editable_root: false</code> and inline mode causing selection to be shifted. #TINY-10820</li> <li>Corrected the <code>role</code> attribute on listbox dialog components to <code>combobox</code> when there are no nested menu items. #TINY-10807</li> <li>HTML entities that were double decoded in <code>noscript</code> elements caused an XSS vulnerability. #TINY-11019</li> <li>It was possible to inject XSS HTML that was not matching the regexp when using the <code>noneditable_regexp</code> option. #TINY-11022</li> </ul> <h2>7.1.2 - 2024-06-05</h2> <h3>Fixed</h3> <ul> <li>CSS color values set to <code>transparent</code> were incorrectly converted to '<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`. #TINY-10916</li> </ul> <h2>7.1.1 - 2024-05-22</h2> <h3>Fixed</h3> <ul> <li>Insert/Edit image dialog lost focus after the image upload completed. #TINY-10885</li> <li>Deleting into a list from a paragraph that has an <code>img</code> tag could cause extra inline styles to be added. #TINY-10892</li> <li>Resolved an issue where emojis configured with the <code>emojiimages</code> database were not loading correctly due to a broken CDN. #TINY-10878</li> <li>Iframes in dialogs were not rendering rounded borders correctly. #TINY-10901</li> <li>Autocompleter possible values are no longer capped at a length of 10. #TINY-10942</li> </ul> <h2>7.1.0 - 2024-05-08</h2> <h3>Added</h3> <ul> <li>Parser support for math elements. #TINY-10809</li> <li>New <code>math-equation</code> icon. #TINY-10804</li> </ul> <h3>Improved</h3> <ul> <li>Included <code>itemprop</code>, <code>itemscope</code> and <code>itemtype</code> as valid HTML5 attributes in the core schema. #TINY-9932</li> <li>Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. #TINY-6925</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
0a2ca2c38c
|
feat: Anvil dnd sagas unit tests (#34407)
[](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=Pmk6xa9) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #33981 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9639877981> > Commit: 311f59c5d6cff265ea985c13f9891193866304d6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9639877981&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Introduced test cases for adding and moving widgets within a canvas layout. - **New Features** - Added functionality to generate mock data for a layout with two sections, each containing a zone widget. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
71bc84fc76
|
test: Fix extracing pageId from app page URL (#34401)
Over on `pg`, we use UUIDs for page IDs, not Object IDs, so the way we extract page ID should account for this. This PR supports page IDs as both ObjectId and UUID. So the same code should work on both `release` and `pg`. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9625470562> > Commit: e21db70964e824cbbb82a76182f46fe08a259f90 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9625470562&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved URL parsing logic for extracting `pageid` using a new method to enhance robustness. - Added assertions to ensure `pageid` is not null before proceeding with further actions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
8482f78584
|
chore: capturing allPaths and unevalTree diffs computation latency (#34396)
## Description Capturing the telemetry of webworker's allPaths and unEvalTreeWithStringifiedJSFunctionsDiff computation. #34397 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9613641914> > Commit: b3d679a8a079fc5c3febf7b4855916f32c982512 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced profiling for key operations to monitor performance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
4942a959c5
|
fix: Prefetch apis: Include only branchname header in request key (#34389)
## Description The request key used to store the mutex for prefetch request was including all header keys. The prefetch request created by the service worker only had one key (branchname) but the request initiated by the client had more headers. Because of this mismatch in keys the request was missing the cache. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9612628976> > Commit: e9c4a982eddded5dce31005365978b4729dadba2 > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved request key generation by including specific headers, enhancing cache performance. - **Tests** - Added a test case to verify the new request key generation logic based on headers. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
ae161b14c8
|
chore: Fix missing changes in revert #34313 (#34371)
## Description Reverted missed out code in https://github.com/appsmithorg/appsmith/pull/34367 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9608916182> > Commit: a2525661414e7bb571914ede981383778e9c4d56 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9608916182&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
|
01dba7700c
|
fix: revert to passing hook as a prop for EE compatibility (#34367)
## Description Revert to passing hook as a prop for EE compatibility. Fixes #32982 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9600106265> > Commit: 042f94586b64efc1b8224059ceebddb0a4a9f0e6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9600106265&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced navigation menu generation in the editor with improved data management. - **Refactor** - Updated the navigation menu logic to use a new function, improving code maintainability and data handling. - **Bug Fixes** - Fixed inconsistencies in the navigation menu across different components in the editor. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
e01b34ec5d
|
chore: tests for wds button widget (#34242)
/ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced test cases for Anvil Button Widgets, including Canvas, Preview, and Deploy modes. - **Bug Fixes** - Updated CSS and HTML selectors for better element targeting and testing reliability. - **Style** - Improved styling logic for buttons in the InlineButtons component. - **Chores** - Added `data-testid` attributes for better test targeting. - Refactored code for string concatenations and URL constructions in DeployModeHelper. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9597157402> > Commit: c551705fe01aace94962fcc7fa91dff253136721 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9597157402&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
62fad08bf7
|
chore: add excludeFromTabOrder for wds widgets (#34361)
## Description - Add excludeFromTabOrder for WDS widgets - WDS Table refactoring Fixes #32369 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9596169254> > Commit: 25d5ef47520266d904c3c545940ad6009e7b2a8f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9596169254&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability to exclude toolbar buttons from the tab order for improved accessibility and user experience. This can be controlled via the `excludeFromTabOrder` property. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
7346cfda8c
|
chore: bump socket.io from 4.6.1 to 4.6.2 in /app/client (#34350)
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.6.1 to 4.6.2. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p> <blockquote> <h2>4.6.2</h2> <h3>Bug Fixes</h3> <ul> <li><strong>exports:</strong> move <code>types</code> condition to the top (<a href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>) (<a href=" |
||
|
|
a1e5024806
|
chore: bump tinymce from 7.0.0 to 7.2.0 in /app/client (#34349)
Bumps [tinymce](https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce) from 7.0.0 to 7.2.0. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's changelog</a>.</em></p> <blockquote> <h2>7.2.0 - 2024-06-19</h2> <h3>Added</h3> <ul> <li>Added <code>options.debug</code> API that logs the initial raw editor options to console. #TINY-10605</li> <li>Added <code>referrerpolicy</code> as a valid attribute for an iframe element. #TINY-10374</li> <li>New <code>onInit</code> and <code>stretched</code> properties to the <code>HtmlPanel</code> dialog component. #TINY-10900</li> <li>Added support for querying the state of the <code>mceTogglePlainTextPaste</code> command. #TINY-10938</li> <li>Added <code>for</code> option to dialog label components to improve accessibility. The value must be another component on the same dialog. #TINY-10971</li> </ul> <h3>Improved</h3> <ul> <li>Dialog slider components now emit an onChange event when using arrow keys. #TINY-10428</li> <li>Accessibility for element path buttons, added tooltip to describe the button and removed incorrect <code>aria-level</code> attribute. #TINY-10891</li> <li>Improve merging of inserted inline elements by removing nodes with redundant inheritable styles. #TINY-10869</li> <li>Improved Find & Replace dialog accessibility by changing placeholders to labels. #TINY-10871</li> </ul> <h3>Changed</h3> <ul> <li>Replaced tiny branding logo with <code>Build with TinyMCE</code> text and logo. #TINY-11001</li> </ul> <h3>Fixed</h3> <ul> <li>Deleting in a <code>div</code> with preceeding <code>br</code> elements would sometimes throw errors. #TINY-10840</li> <li><code>autoresize_bottom_margin</code> was not reliably applied in some situations. #TINY-10793</li> <li>Fixed cases where adding a newline around a br, table or img would not move the cursor to a new line. #TINY-10384</li> <li>Focusing on <code>contenteditable="true"</code> element when using <code>editable_root: false</code> and inline mode causing selection to be shifted. #TINY-10820</li> <li>Corrected the <code>role</code> attribute on listbox dialog components to <code>combobox</code> when there are no nested menu items. #TINY-10807</li> <li>HTML entities that were double decoded in <code>noscript</code> elements caused an XSS vulnerability. #TINY-11019</li> <li>It was possible to inject XSS HTML that was not matching the regexp when using the <code>noneditable_regexp</code> option. #TINY-11022</li> </ul> <h2>7.1.2 - 2024-06-05</h2> <h3>Fixed</h3> <ul> <li>CSS color values set to <code>transparent</code> were incorrectly converted to '<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`. #TINY-10916</li> </ul> <h2>7.1.1 - 2024-05-22</h2> <h3>Fixed</h3> <ul> <li>Insert/Edit image dialog lost focus after the image upload completed. #TINY-10885</li> <li>Deleting into a list from a paragraph that has an <code>img</code> tag could cause extra inline styles to be added. #TINY-10892</li> <li>Resolved an issue where emojis configured with the <code>emojiimages</code> database were not loading correctly due to a broken CDN. #TINY-10878</li> <li>Iframes in dialogs were not rendering rounded borders correctly. #TINY-10901</li> <li>Autocompleter possible values are no longer capped at a length of 10. #TINY-10942</li> </ul> <h2>7.1.0 - 2024-05-08</h2> <h3>Added</h3> <ul> <li>Parser support for math elements. #TINY-10809</li> <li>New <code>math-equation</code> icon. #TINY-10804</li> </ul> <h3>Improved</h3> <ul> <li>Included <code>itemprop</code>, <code>itemscope</code> and <code>itemtype</code> as valid HTML5 attributes in the core schema. #TINY-9932</li> <li>Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. #TINY-6925</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
138fc6a148
|
feat: side-by-side edit mode hover analytics (#34185)
## Description The purpose of this PR is to collect data about hovered canvas and widgets and send it to analytics platform. Fixes #33159 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584384829> > Commit: 9cec247f7f1e82e0cc23fa5aa5499008bdc58964 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584384829&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced analytics tracking for side-by-side hover actions in the IDE canvas. - Added a new `AnalyticsWrapper` component for handling analytics events within layout systems. - Implemented a custom hook `useIsInSideBySideEditor` to check for side-by-side editor mode. - Added new CSS styles for layout systems. - **Bug Fixes** - Improved handling of widget hover events and analytics tracking in side-by-side editor mode. - **Refactor** - Refactored logic for determining the current entity info and segment state in the IDE. - Updated import paths and reordered imports for better organization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
a6faf6d7a5
|
perf: add react-hooks/exhaustive-deps rule (#34338)
## Description Adds ESLint rule `react-hooks/exhaustive-deps` with warn level. Context in the task below. Fixes #34337 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584250724> > Commit: daa705074504f398b80b1175440d00011b5d865d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584250724&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Added ESLint rule `react-hooks/exhaustive-deps` with a severity level of "warn" to enforce exhaustive dependencies in React hooks. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
b85c4f5451
|
refactor: move apps link out of menu & refactor nav menu data (#34313)
## Description Moved `Back to all apps` from dropdown menu directly to header. Additionally renamed `NavigationMenuData.ts` to `useNavigationMenuData.ts` and fixed dependency related memoization issues. <img width="267" alt="image" src="https://github.com/appsmithorg/appsmith/assets/173164/020abfe3-1359-43ff-aa99-972a45f270bd"> Fixes #32982 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9567752111> > Commit: 824b2fe1231de1d073a1b19054507643b325400f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567752111&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed `getNavigationMenu` prop from `EditorHeader` for streamlined navigation menu data retrieval. - Updated `EditorName` to use `useNavigationMenuData` for navigation menu items. - Refactored `useNavigationMenuData` to use `useCallback` and `useMemo` for enhanced performance. - Adjusted imports and event handling functions in `IDE/Header` to use `useCallback` for better efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
092208a1c1
|
fix: checkbox column misalignment on table widget (#34222)
Fixes #21790 _or_ Fixes [Issue URL](https://github.com/appsmithorg/appsmith/issues/21790) Introduced a new prop called isFullWidth for the CheckboxComponent and pass this prop to this styled component CheckboxContainer. The isFullWidth is an optional boolean property whole default value would be true. Added screenshot for reference.  <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a full-width option for checkboxes to enable better styling flexibility. - **Tests** - Added new test cases to verify checkbox styling properties in tables. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
36372468c5
|
chore: remove headless radio and use react-aria component instead (#34312)
## Description - Remove headless radio and use react-aria component instead - Create ErrorMessage component Fixes #27677 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9567388261> > Commit: 62d1153caa8bf03d827f88593c9dfaf3121091ee > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567388261&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added `ErrorMessage` component for displaying error messages with specific styling. - Introduced `isDisabled` prop for `Label` and `ToggleGroup` components. - Updated `RadioGroup` to accept an items array for easier configuration. - **Bug Fixes** - Improved conditional rendering in `Label` component to prevent issues when `text` and `contextualHelp` are both falsy. - **Refactor** - Removed `Radio` component export from design system. - Restructured import statements and prop declarations for `Checkbox` and `RadioGroup`. - **Style** - Updated styles for `RadioGroup` and `ToggleGroup` components for better state handling (disabled, hovered, selected). - **Documentation** - Updated Storybook stories for `RadioGroup` to reflect changes in component usage. - **Tests** - Adjusted `RadioGroup.test.tsx` to test new items array prop. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
f2a6341c58
|
fix: evalTrigger mutation fix (#34106)
## Description This fixes a gap in our evaluation flow where we were not sending evaluation updates during an evaluation in the evalTrigger. We have resolved that by sending updates in the evalTrigger, also we have created a separate function called evaluateAndGenerateWebWorkerResponse which unifies the logic between sending updates in evalTrigger as well as evalTreeWithChanges. We have added several unit test cases in this PR to test the evaluation flow. Fixes #33823 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9558723818> > Commit: 8b7bc93e3d1a8ce93c722a94c8846f9359d40686 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9558723818&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the evaluation and update process for data tree structures with new helper functions and interfaces. - Enhanced error handling with optional chaining in `setPrevState` function. - **New Features** - Introduced `evaluateAndPushResponse`, `evaluateAndGenerateResponse`, and `getAffectedNodesInTheDataTree` functions for better data tree evaluation and updates. - Added `UpdateTreeResponse` interface for structured update responses. - **Bug Fixes** - Adjusted error handling in the evaluation process to ensure robustness. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
12879c7c55
|
fix: property pane height fix for animation (#34276) | ||
|
|
dc42ccf1b1
|
chore: bump ws from 6.2.2 to 6.2.3 in /app/client (#34291)
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p> <blockquote> <h2>6.2.3</h2> <h1>Bug fixes</h1> <ul> <li>Backported e55e5106 to the 6.x release line (eeb76d31).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
4100fa9319
|
fix: learn more link in git connect success modal (#34297)
## Description Learn more link in Git connection success modal was not working properly. This PR fixes it Fixes https://github.com/appsmithorg/appsmith/issues/34295 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9560201005> > Commit: 3e282e06d3a26442a5f3acb0c8231b51ba13ee05 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9560201005&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated documentation link for branch protection settings to the latest URL in the Git sync success modal. - **Tests** - Added a test to verify the updated 'Learn more' link in the Git connection success modal. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
6585ec1487
|
chore: removing branch protection trigger from git connect flow (#34118)
## Description 1. Remove branch protection trigger from git connect saga 2. Updating test-cases and removed logic for removing branch protection after git connect Fixes https://github.com/appsmithorg/appsmith/issues/34059 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9498573284> > Commit: 6ef7f8bc0bfbe15880857fff1f6262c9e9b5ef4a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9498573284&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected Git branch protection interactions in test scenarios. - **New Features** - Enhanced Git connection success messages and actions. - **Improvements** - Reordered import statements for better code organization. - Adjusted visibility of methods and refactored parameters in Git synchronization. - **Dependencies** - Updated `design-system` dependency to version `2.1.42`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
1007c2356d
|
test: replace LogintoApp with LoginFromAPI (#34040)
This replaces LogintoApp with LoginFromAPI /ok-to-test tags="@tag.All" EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4440 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced login functionality in multiple test scripts by shifting from user-based login to API-based login. - **Chores** - Updated the spec names in the limited Cypress tests to align with new test locations and names. - Added new logout API call in the `LoginFromAPI` custom command to improve test reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9517666274> > Commit: a42a585c062bab201dd18f148981d5a4f4265556 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9517666274&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
|
84f67fe0f2
|
chore: remove headless checkbox and switch use react-aria component instead (#34217)
## Description - Remove headless checkbox and switch use react-aria component instead - Add Label component - Now `ToggleGroup` is used instead of `SwitchGroup` and `CheckboxGroup`, since they are essentially the same component. **I'll create another one PR to refactor the radioGroup.** Fixes #27677 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9485370398> > Commit: f2557233978da533b9ab856335a8191b4226dba5 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9485370398&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `ToggleGroup` component with various features for improved user interaction. - **Enhancements** - Updated `Radio`, `Checkbox`, and `Switch` components for better functionality and styling alignment. - Added `labelPosition` options to `Radio` and `Checkbox` components for flexible label positioning. - Enhanced `ContextualHelp` component with a new `slot` prop for more customization. - Improved `Select` component to use `Label` directly, optimizing rendering. - **Bug Fixes** - Adjusted logic for `WDSSwitchWidget` to ensure correct validity handling. - **Styling** - Various styling adjustments across multiple components for consistent design. - **Tests** - Updated test cases for the `Checkbox` component to reflect recent changes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
cae0114372
|
fix: fixing unprotect logic in callout (#34244)
## Description Clicking "Unprotect branch" in the branch protection callout was making all the branches as unprotected. This PR fixes that and only allows the current branch to be unprotected Fixes #33310 #34005 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9511853863> > Commit: 1ccab8a270b12427eeda6f4cdbea0fb84b4d77ee > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9511853863&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced IDE with advanced branch protection management, including the ability to unprotect branches directly within the IDE. - **Bug Fixes** - Improved handling of current branch filtering to ensure accurate protected branch management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
4cb6ff03f9
|
chore: Prefetch module apis in service worker (#34003)
## Description This PR has the following changes - Modify the prefetch api cache strategy to handle multiple prefetch requests. - Convert the service worker files from js to ts - Code splitting of CE and EE for service worker utils to handle EE specific changes - Jest test cases for the updated logic Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9511154598> > Commit: 785197e27873e71ed457f785a73d4ea57f379213 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9511154598&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced API request handling with new utility functions and caching strategies for service worker operations. - Updated service worker configuration to TypeScript for improved type safety and maintainability. - Added type definitions for `node-fetch` to support new service worker functionalities. - **Refactor** - Consolidated `view` and `edit` endpoint URL construction in `ConsolidatedPageLoadApi` for better code maintainability. - **Chores** - Updated dependencies in `package.json` for better development experience and compatibility. - Added tests for new service worker utility functions to ensure reliability and correctness. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
dae657e3e4
|
chore: WDS, adjust inner spacing of buttons with icons (#34210)
## Description When an icon is present reduce leading/trailing inner spacing. | Before | After | |--------|--------| |  |  | Fixes #33917 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9481602526> > Commit: 038d756b2f36020a9f9ed95bd2d681a91fb9f03d > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9481602526&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Adjusted padding styles for Button component to improve alignment based on icon position (start/end) and size (small/medium). <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
1a0889e035
|
test: fix failing gitsync tests (#34214)
RCA: Test was failing because of hard wait Also the dropdown element which was being clicked was failing Solution: Removed hard waits and replaced with intercept Updated locator and better method to fix tests EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4413 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the method for merging changes to the master branch in Git sync tests for improved reliability. - **Tests** - Revised Cypress test configurations and spec names for better organization and clarity. - Enhanced the `CheckMergeConflicts` method to improve test accuracy and reliability by including element visibility checks and network status assertions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
f73b9a47d7
|
fix: Fix for regression in js query refactor in modules (#34186)
## Description PR #33545 removed the action `REFACTOR_JS_ACTION_NAME` and called the saga `handleRefactorJSActionNameSaga` directly. This caused a regression in the refactor of functions in js modules. This PR reverts this code. Fixes #34148 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9494201779> > Commit: 3b7c67d7d82c4d15d7129f09a023d6475b835600 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9494201779&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new actions for refactoring JavaScript collections to improve management and updating of JS collections in the application. - **Refactor** - Simplified dummy JavaScript functions, removing comments and unnecessary code to streamline function bodies. - Updated variable initialization values for cleaner code. - **Tests** - Updated network status assertions for JS collections in test scripts. - Switched test specifications in the Cypress test suite to ensure better coverage. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
dbffbb81c7
|
feat: add tests for AddAndMove and AddBuildingBlocks to canvas (#34215)
## Description Ad unit tests for adding and moving building blocks saga. Fixes #34146 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9494392536> > Commit: c6b9b1b679f284458cc6500729408ddb015adb62 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9494392536&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Added comprehensive tests for adding and moving building blocks on the canvas. - Updated import paths for consistency in test files. - Introduced new test suites for sagas handling building block operations. - **New Fixtures** - Added mock data and constants for testing building block functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
4326ae81fc
|
chore: fix table height (#34178)
Fixes #33758 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Updated table header styles to improve layout on specific screen sizes. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9478133261> > Commit: 0d32fdfac2d13ab54b4886f5d2891e8604f5f6ef > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9478133261&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
6e5f3069f2
|
chore: fix validation in wds phoneinput widget (#34177)
Fixes #34057 /ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9478894908> > Commit: 37635701f1073d445d732a1498c0a8b556d09ca3 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9478894908&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved phone input validation by using parsed text for more accurate results. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
1d80c0694c
|
feat: update explorer widget icons (#34018)
## Description Update the explorer widget icons with the 16x16 px version for all widgets. Fixes #33907 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9446856870> > Commit: 9bf0b74f6cb09fa3faeb03b2bd59f46982a460c5 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9446856870&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
|
69b63fa552
|
fix: set eval version for workflows artefact (#34197)
## Description Eval version 2 is used to properly handle the escape characters like `\n` etc in the eval flow. If not set, it is defaulting to behaviour for eval version 1. This PR introduces the type fixes to allow for eval version to be set via the API. The main change is in the EE PR and this PR is to update the type. Fixes #34171 ## Automation /test sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9478023950> > Commit: c5edfb33f93802d2a025a064ddaa4593ea7932a4 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9478023950&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Consolidated `EvaluationVersion` type imports to a single source for improved maintainability. - Promoted `DEFAULT_EVALUATION_VERSION` to be exportable for broader use across the application. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
cdee74e93b
|
chore: Split JS collection update api call to override for modules (#34009)
## Description The API call is moved to a saga called `updateJSCollectionAPICall` whose role is to identify whom this JS collection belongs to `Page` / `Module` / `Workflow` and then call the correct API. In the context of CE, it just calls the existing `updateJSCollection` but in EE this saga (`updateJSCollectionAPICall`) is extended and does the checking mentioned above. For more info on extension check the [EE PR](https://github.com/appsmithorg/appsmith-ee/pull/4356) Fixes https://github.com/appsmithorg/appsmith/issues/34008 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9465185887> > Commit: 5e0214b97de20cf1b9042717fdb578f872c2c7d3 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9465185887&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Added test cases for the `updateJSCollectionAPICall` function. - Updated `pageId` constant in `pasteSagas.test.ts` for improved readability and consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> |
||
|
|
e6ebd41544
|
chore: add min validation param (#34132)
Fixes #33757 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Enhancements** - Improved validation for table widget properties by adding a minimum value constraint, ensuring input values are greater than or equal to 1. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9463054159> > Commit: bddc1f8d76e534d5573c282ab40640286c7bc53d > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9463054159&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
337e12f41c
|
chore: Fix Connect data button is active on preview mode and triggers property pane pop-up (#34168)
Fixes #33719 /ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9461238496> > Commit: a5a79c94a8ce1d5c312c9b87d484974295e5eab2 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9461238496&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved the conditional logic for displaying the connect data overlay in the table widget, ensuring it does not show in preview mode. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
989cd8ed67
|
chore: Unify ID extraction regex from browser url (#33925)
## Description Regex update to make it compatible to extract identifiers for both Mongo ObjectIds and UUIDs. This will help us to keep the unified logic required in `pg` branch. ## Automation /ok-to-test tags="@tag.Datasource, @tag.GenerateCRUD, @tag.ImportExport, @tag.Fork, @tag.Workspace, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9405554200> > Commit: 3959703aab1d10e28d3b80057793476467126929 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9405554200&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced URL path handling to support both UUID and Mongo ObjectIds. - **Refactor** - Replaced hardcoded page IDs with dynamic variables across multiple test files for improved maintainability and flexibility. - **Tests** - Updated test cases to use dynamic page IDs, ensuring consistency and easier updates in the future. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
5a6bb4e48b
|
chore: exclude button from tab order (#34099)
## Description Removed the option to select the tab button in edit mode. This is the first PR. There will be separate PRs for each widget. ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9445961677> > Commit: ccba28bd2b17a7afdc27fb59371f7e72bd370169 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9445961677&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `isEditMode` getter in widgets to enhance edit mode detection. - **Improvements** - Updated button component properties for better consistency and usability. - Enhanced widget interaction logic for more accurate behavior in different modes. - **Removed** - Eliminated unnecessary `minWidth`, `maxWidth`, and `minHeight` properties from button components. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
d4afb9e932
|
chore: Fix Currency widget fails to display it's default value (#34136)
Fixes #34056 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the currency input widget to include `rawText` and `parsedText` properties for better data handling and display. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9460624233> > Commit: 9957e7114a222231912174f00e5c61fd37c80aad > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9460624233&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
341a58e68f
|
chore: fix Read only widget incorrectly triggers configured actions that are hidden because of the toggle (#34134)
Fixes #34000 /ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9460620209> > Commit: fd17eacb6f9edee8905fb5cf1054b56822f2c3cd > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9460620209&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
b9a7be3a64
|
chore: remove allowDialCodeChange property (#34133)
Fixes #33933 /ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9460615539> > Commit: 6349d4235c3f3c26b785599ed721433df277ac9e > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9460615539&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
6e5b8bba67
|
chore: hide form settings in button widget (#34131)
Fixes #33935 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed form settings section from the property pane configuration to streamline settings management. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9460604238> > Commit: f75662e62726b06e8627ba4f5c5f43da8ee89419 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9460604238&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
|
9bd55f2ee9
|
chore: Add a check if span attributes is present or not (#34142)
Fix crash on empty attributes. Fixes #34141 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9449423201> > Commit: 57170b068a026a6d329bbe97f4c7c494c7dfe1b4 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9449423201&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved error handling in worker telemetry to prevent setting attributes on a span when `__spanAttributes` is not present. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
212a7aff8b
|
fix: pass correct widgetId for reflow of building blocks (#34143)
## Description **Problem** When dragging a dropping a building block on the canvas with reflow (i.e when other widgets are moved) the process fails. The building block does not show, the skeleton loader does not go away and an error message is shown. **Why** The flow for adding building blocks with reflow does not contain a widgetId in the newWidget object, instead, the payload carries a canvasId parameter. **Solution** I have added a check to add the correct value for the widgetId in the flow for dropping building blocks on canvas with reflow. Fixes #34139 ## Automation /ok-to-test tags="@tag.Templates" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9448541112> > Commit: fc8cfe04c784888514f119b0b51b67ea60014910 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9448541112&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved the stability of the widget loading process by ensuring the correct widget ID is assigned when adding and moving building blocks to the canvas. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
3a895f9dd3
|
test: replace togglebarDisable with CheckUncheck (#34069)
This replaces togglebarDisable with CheckUncheck from Ts helper /ok-to-test tags="@tag.All" EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4393 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated test scripts to use a new method for interacting with checkbox elements, improving consistency and reliability. - **Chores** - Added new locators for client-side search and fixed footer input fields for better test coverage. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9438128926> > Commit: dcdb3ab2c366de74cdea844517ff67864b379551 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9438128926&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
|
068847d4e9
|
fix: vanishing widgets in protected branches (#34129)
## Description Fixing vanishing widgets in protected branches Fixes https://github.com/appsmithorg/appsmith/issues/34128 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9448976837> > Commit: b45f21e9573c872c809b4f509d735988cbfcfae7 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9448976837&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified logic by removing unnecessary checks for protected mode. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
99fa93d61e
|
chore: Adding specs/tests for space distribution and copy paste sagas (#34063)
[](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=mFGYFxI) ## Description - Adding additional specs for space distribution and section deletion. - Adding unit tests for anvil pasting. Fixes #33739 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9443154667> > Commit: 4a770670aaf2f00d175066b597680345d840cd60 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9443154667&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new test cases for verifying section removal and visual aspects of background-less zones in the Anvil layout system. - Introduced methods to handle mouse events for space distribution within sections. - Added mock data generation functionality for widgets, sections, zones, and layouts. - **Tests** - Implemented tests for paste operations in the Anvil layout system, including various mock functions and scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
27e772546d
|
feat: Hide suggested widgets when drag-and-drop building blocks feature is enabled (#34101)
## Description This pull request includes changes to hide suggested widgets when the drag-and-drop building blocks feature is enabled. * It also adds unique keys to WidgetCard components and a data-testid attribute to the UIEntityTagGroup div. * Additionally, tests have been added for UIEntitySidebar to handle empty cards and feature flag scenarios, as well as for widget card grouping by tags and filtering based on search input in UIEntitySidebar. Fixes #33996 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE, @tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9418161856> > Commit: 89e5bcc6e8dcdb8312a9a24cd49885a87c7c0eac > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9418161856&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a feature flag for drag-and-drop building blocks in the widget sidebar. - Enhanced search result management and rendering logic based on search results and feature flag status. - **Improvements** - Renamed state variables for better clarity in the widget sidebar. - Added `data-testid` attribute for improved testability. - Adjusted widget card mapping for more accurate rendering. - **Tests** - Added unit tests for the `UIEntitySidebar` component, covering search input, empty states, widget grouping, search filtering, and feature flag conditions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
|
bf92a52f5a
|
chore: autocommit feature branch (#34062)
## Description The changes are related to the "auto-commit" migration feature. **Server changes** - Fixed issue with concurrent git calls for the same repo - Trigger issues with auto-commit **UI changes** - Introduced new REST api for triggering auto-commit via client - Updated logic for saga to use trigger auto-commit api for checking whether to poll for auto-commit progress - Updated logic to make status api call blocking - Response structure change for auto-commit apis Fixes #30110 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9419768186> > Commit: 129eaee76d3810e5e0ea9b6391048ff9338c9c8a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9419768186&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced enhanced Git autocommit functionality with improved error handling and progress tracking. - Added new autocommit actions and state management for better synchronization. - **Bug Fixes** - Improved error handling during Git synchronization processes. - **Refactor** - Updated method names and parameters for clarity and consistency in Git synchronization. - **Chores** - Renamed feature flags and constants related to Git autocommit for better readability and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: brayn003 <rudra@appsmith.com> |
||
|
|
187c543b9e
|
fix: adds tenant config to CreateNewAppsOption.test.tsx (#34121)
## Description Fixes failing client jest test cases by adding tenant config to mocked store of `CreateNewAppsOption.test.tsx` added by #34048 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Updated test configuration to include a new `tenant` object with an empty `tenantConfiguration` in the default store state. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |