Commit Graph

4047 Commits

Author SHA1 Message Date
Favour Ohanekwu
30d0fb7a6d
fix: Add window object methods and properties as invalid entity name (#7928)
Added window object property and method names to list of invalid entity names
2021-10-04 13:49:58 +01:00
Apeksha Bhosale
7665ff3c4f
fix: small fixes js editor (#8022)
* remove space below response

* changes to name editor

* removing variable as dynamic binding path list

* error message change for js object
2021-10-04 16:38:02 +05:30
Ayush Pahwa
5c3cdea47b
Preventing evaluations to be reset on page change unless it is the first load (#8153) 2021-10-04 15:32:41 +05:30
arunvjn
d67165f8bb
fix: for in null check sentry bug (#8150) 2021-10-04 15:11:25 +05:30
Ayush Pahwa
b90a00ba0f
fix: Added checks to ensure that the configs are valid before starting eval (#8019) 2021-10-04 13:39:14 +05:30
Rishabh Saxena
a69c8b7484
feat: callouts for wip features (#8080) 2021-10-04 13:31:46 +05:30
Pranav Kanade
ca4541a415
updated existing test cases to validate the import export flow with different user permissions (#8099) 2021-10-04 13:04:48 +05:30
Pranav Kanade
7298937e36
revert: back button navigation fixes (#8044)
* Revert "fixes to add proper routing around navigation between query pane, api pane and integration screen (#7782)"

This reverts commit b3d7f08d4e.

* Revert "fix: back btn navigation problems (#7692)"

This reverts commit c0f5ab3f30.
2021-10-04 12:27:26 +05:30
rashmi rai
4e7dec2738
added max width to the switch control (#7790) 2021-10-04 06:57:17 +00:00
Vinod
d9b4685192
Introduce linting to all users (#7736)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-10-04 12:11:02 +05:30
akash-codemonk
3d95598c18
fix: Fixes scenario where onboarding was trying to create an app in an organisation with view access (#8072) 2021-10-04 09:57:57 +05:30
akash-codemonk
a7fd0e16ac
fix: Fixes scenario where renaming actions was clearing debugger errors (#7993) 2021-10-04 09:57:23 +05:30
akash-codemonk
3209ad8cdf
chore: Do not show initialLocation of map widget in an error state when field is blank (#7931) 2021-10-04 09:56:52 +05:30
Hetu Nandu
79aefc4d74
hotfix: js action parsing error resolution (#8086) 2021-10-01 22:40:49 +05:30
Pranav Kanade
a1488a73f6
refactor: client side rts (#7837)
* moved constants to a proper files

* added new action constants

* updated websocket reducers and actions

* updated websocket saga to handle proper socket events

* updated initialization

* updated multi pointer arena + realtime app editors components

* minor feedback update

* updated events list by socket level

* removed e.persist

* passing socket obj rather than just id
2021-10-01 16:44:19 +00:00
Pranav Kanade
b261efc511
fix: skip bot comment when user skips comments tour (#7693)
* setup for skipping the bot comments if user skips the comments tour

* Using the onboarding status api

* removed comments

* fixed typos

* added test cases

* small fixes

* updated the tests

* minor update to a test case
2021-10-01 21:55:55 +05:30
Hetu Nandu
633db3068e
fix: Single binding sql query causing prepared statement issue (#7792) 2021-10-01 21:05:05 +05:30
Bhavin K
1e6b916ff9
added auto focus for number input (#7961) 2021-10-01 15:09:59 +00:00
Abhijeet
49182e7060
chore: Update success asset urls for generate page (#7579)
* Update asset urls

* fix: use successImageUrl for CRUD success popup

* Increase delay to switch between GIF and image

* Use ASSETS_CDN_URL instead of S3_BUCKET_URL

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2021-10-01 15:09:41 +00:00
Hetu Nandu
72f6ad8d99
fix: Cyclic dependency not resolving in JS Editor (#8003) 2021-10-01 15:09:09 +00:00
arunvjn
7acce6e802
fix: slash command auto open (#7977)
* Remove onFocus trigger for slash commands.
2021-10-01 15:08:42 +00:00
arunvjn
223bf0174f
fix: snippets ranking (#8020) 2021-10-01 15:08:26 +00:00
rashmi rai
0619e3798f
fix: missing where key in plugin specified templates (#8040) 2021-10-01 14:02:52 +00:00
Rishabh Rathod
70e6e54815
fix: Avoid sending param with no initialValue (#7647)
- Add initialValue for spreadSheetURL
- Pass only params having initialValue defined in generate CRUD
2021-09-30 11:29:09 +00:00
Tolulope Adetula
8b30fdd758
fix: wrong doc link (#7983) 2021-09-30 03:39:21 -07:00
Ayush Pahwa
6023bb10e4
fix: 7630 fixing where clause add delete row (#7968)
* Added new row addition action for form value changes

* Added comments

* Added special handling for where clause rows
2021-09-30 09:40:40 +00:00
Pranav Kanade
cf3cdced07
fix: small utility fixes for redirection to datasource and export app permissions (#7970)
* send user to auto tab in integration from property pane when they create new query

* only app admins will be able to export from inside app
2021-09-30 13:29:14 +05:30
arunvjn
964d58747a
fix: snippet usage analytics (#7946) 2021-09-30 03:31:50 +00:00
Apeksha Bhosale
1aac46a66d
don't send errors to sentry (#7906) 2021-09-29 20:11:55 +05:30
Apeksha Bhosale
222f0e04c3
sending collectionName instead id in refactor (#7930) 2021-09-29 20:10:49 +05:30
akash-codemonk
48f2c584ab
fix: Fix mismatch between errors in debugger and evaluated value popup (#7752) 2021-09-29 17:33:11 +05:30
Rishabh Rathod
570731507b
fix: Remove unneccessary scrolling (#7896) 2021-09-29 11:23:24 +05:30
Satish Gandham
c3d5b1010b
fix: Change multiselect back to supporting numbers and boolean. (#7895)
* Revert "fix: multiselect validation (#7698)"

This reverts commit 728a2559c5.

* - Convert the multiselect options value and labels to string before filtering as the values can be numbers.

* - Discourage users from using string in multiselect default value

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-28 19:38:24 +05:30
Ayush Pahwa
f8442622b3
fix: Added new row addition action for form value changes (#7682) 2021-09-28 11:36:03 +00:00
Aswath K
b4bab33d1e
fix: make the row click event trigger when table button is clicked (#7878) 2021-09-28 16:27:44 +05:30
Pranav Kanade
25035cbf88
hiding comments mode toggle for anonymous users (#7885) 2021-09-28 14:37:12 +05:30
Apeksha Bhosale
a1e5b39b49
fix: Debugger logs and errors related to js editor (#7749)
* added errors

* small change url

* messages created

* few logs for debugger

* after merge
2021-09-28 13:01:46 +05:30
balajisoundar
287f7e2de2
chore: Signposting progress should be hidden when user generates a page (#7883)
Fixes: #7660
2021-09-28 11:58:18 +05:30
Apeksha Bhosale
1b8a77044e
scroll for response tab list of functions (#7864) 2021-09-28 11:29:09 +05:30
Vinod
d1730a92f9
fix: autocomplete suggestions should be restricted in bindings (#7732)
* Remove bracket highlight on error

* hide data tree functions in non actions

* filter by entity type

* fix the autocomplete issue

* temp

* Fix case where entity type is undefined

* remove unused code

* fix failing test
2021-09-28 11:09:43 +05:30
Paul Li
31424e77b1
fix: The recorder widget does not reset when onClick actions on submit button is set to reset recorder widget (#7729)
-- Add the logic for resetting the widget
2021-09-27 23:55:53 +05:30
Bhavin K
59edccf294
fix: Image widget - file format change on download file (#7335) 2021-09-27 19:42:21 +05:30
Pranav Kanade
db02756173
fix: upgraded socket.io client package to latest stable version (#7845)
* upgraded socket io client to latest stable version

* auto update enabled

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
2021-09-27 16:59:47 +05:30
arunvjn
cb2ad8990a
Removed snippets feature flag (#7839) 2021-09-27 08:19:07 +00:00
Aswath K
d9fa049578
fix: Button variant validation (#7699)
* fix: Button variant validation

* fix: MenuVariant validation

* Add default value to buttonVariant

* Adds default value to MenuVariant
2021-09-27 12:00:04 +05:30
Tolulope Adetula
60131403b2
feat: disable parsing link (#7075)
* feat: add disableLink for text widget

* feat: add test for disable link

* fix: email parsing

* fix: test issues

* fix: failing test

* fix: failing test
2021-09-26 23:00:40 -07:00
Aswath K
20c1b56932
fix: table button migration issues (#7825) 2021-09-27 10:45:51 +05:30
arunvjn
90fda1ccae
fix: Remove snippet and doc icon from property pane (#7806) 2021-09-27 04:56:39 +00:00
rahulramesha
46f525d365
fix: modal widget issues (#7821)
* fixing modal issues

* adding cypress tests

* patch for modal Issues
2021-09-25 16:45:39 +05:30
Aswath K
8a45e1507e
feat: Add AudioWidget (#7179)
* Create initial version of AudioWidget by copying VideoWidget

* Add EventType for AUDIO

* Change default Audio URL to a podcast related to Appsmith

* Add AudioWidget icon

* Change Entity definition for AudioWidget

* Add cypress test

* Add jest test

* fix: typo
2021-09-24 21:35:53 +05:30
arunvjn
f3afa81afe
fix: copy snippet (#7769)
Fixes copy snippets and snippets execution toast messages
2021-09-24 19:19:59 +05:30
Pranav Kanade
79f613cf71
handle socket exception and log to sentry for time being. Need to test its impact on import/export (#7818) 2021-09-24 17:44:26 +05:30
Satish Gandham
941db9e99c
fix: Tweak how we show errors for required and not required inputs (#7783)
* - If a field is not required and empty, don't show error.
- If a field is required and empty, bail early and show error.

* - Remove default label from input
- Fix a issue with required validation

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-24 11:52:46 +00:00
Satish Gandham
eb2cbb383d
perf: Optimize list widget renders by memoizing part of renderChildren (#7681)
* - Optimze list widget renders by memoizing part of renderchildren

* - Fix failing tests and add more dependecnies to memo

* - Fix issue with repositioning widgets inside list.

* comment out the moving of widgets test

* Remove stray import

* Fix the failing jest test

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-24 17:00:26 +05:30
balajisoundar
8e0cf39419
chore: UI enhancements to welcome landing page (#7766)
Fixes: #7765
2021-09-24 14:47:58 +05:30
Pranav Kanade
b3d7f08d4e
fixes to add proper routing around navigation between query pane, api pane and integration screen (#7782) 2021-09-24 12:52:43 +05:30
arunvjn
7159119329
Fixed header resizing (#7787) 2021-09-24 12:43:36 +05:30
Trisha Anand
c84844e905
Fix for generating action from datasource structure (#7778) 2021-09-24 12:17:36 +05:30
Pranav Kanade
5a2ac0db69
fix: show correct dependency list for widgets even if one's name is substring of other widget (#7725)
* checking string equivalence rather than inclusion.

* reusing getEntityName function to get the abs name of the dependencies and entities

* added a test to check the fix
2021-09-24 10:23:32 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
rahulramesha
fb7143cef2
fix: chartWidget fix for "TypeError: r.palettecolors.split" (#7717)
* adding validation for fusion chart's paletteColors Attribute

* restructuring as params for TEXT type

* removing unnecessary space

* addressing review comments

* adding validations to ignore case
2021-09-23 18:12:34 +05:30
Rishabh Rathod
f0325c11c6
fix: Git sync modal minor fixes (#7760)
fix: Hide Snackbar for gitSSHKey fetch failure
Add Tooltip for copy icon
Fix config issues
2021-09-23 18:02:58 +05:30
Vicky Bansal
609cdc05e4
feat: Table selected row and action trigger UX improvement (#7310) 2021-09-23 17:16:47 +05:30
Hetu Nandu
d18d781a06
Fix issue when form crashes after copy or move of mongo query (#7750) 2021-09-23 11:35:49 +00:00
NandanAnantharamu
8e6ba37d00
test: fix/Updated common method (#7734)
* Updated common method

* updated dsl
2021-09-23 16:44:01 +05:30
Apeksha Bhosale
3f76855d59
fetching js collections parallel with actions in view mode (#7481) 2021-09-23 15:39:01 +05:30
Rishabh Rathod
90a275a502
fix: On connect Tab Switch error (#7740)
fix: On connect Tab Switch error
Add Git local config API
2021-09-23 08:47:09 +00:00
Pawan Kumar
be7e573175
fix: crashing of menu widget in list widget + "type" of undefined error (#7092)
* fix crashing of menu widget in list

* add ternary operator when calling type on widget

* remove eslint disable rule

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-09-23 13:57:28 +05:30
arunvjn
e474958d2d
fix: evaluation popper z index (#7744)
Reduce z-index to place modals above evaluations popper
2021-09-23 08:05:36 +00:00
Nidhi
688b75af22
Changes to introduce peader prefix in API key authentication type (#7742) 2021-09-23 13:20:44 +05:30
Hetu Nandu
8f84fc0f69
fix: error handling in trigger execution flow (#7671) 2021-09-23 07:21:57 +00:00
Pranav Kanade
ab450e5cb9
fix: add support for self tagging (#7715)
* removed current user filtering for getting tagging suggestions in comment input.

* using map instead of for
2021-09-23 11:03:22 +05:30
akash-codemonk
a971d49a1e
chore: Fix remaining empty fields in property pane shown in error state (#7537) 2021-09-23 10:35:59 +05:30
Rishabh Rathod
48dabf9efd
feat: Add Git push API & UI Updates (#7704)
Add Git push API & UI Updates
-  Add Global Config fetch in git connection
-  Add Success Toast Msg for commit and push API
-  Fix generate and fetch SSHKey API
-  Fix Close button UI
-  Add Tick Icon when SSH Key is copied
- Add Direct Deploy option
-  Hide Merge Tab
- Add Commit success and push success msg
- Add the Latest Deploy Preview option
2021-09-23 00:18:50 +05:30
balajisoundar
0eaabe9423
chore: Fix signposting issue where application crashing out if there is nested binding (#7731)
Fixes: #7730
2021-09-22 23:14:55 +05:30
arunvjn
3cd93e11a7
feat: snippets discoverablity (#7689) 2021-09-22 16:59:47 +00:00
Pawan Kumar
c48cdcdeb4
chore: comment out the moving widget cypress test (#7733)
* comment out the moving of widgets test

* update tests for replay spec

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-22 20:38:03 +05:30
Bhavin K
de20a2a52f
feat: add server side pagination in list widget (#7128) 2021-09-22 14:16:51 +05:30
Tolulope Adetula
728a2559c5
fix: multiselect validation (#7698)
* fix: multiselect validation

* fix: add failing scenarios for validation

* fix: test
2021-09-22 08:37:12 +01:00
Vicky Bansal
2c08417829
Fix digits after decimal in input widget (#7468) 2021-09-22 12:58:56 +05:30
Vicky Bansal
8679141c76
Fix button click issue in table widget when action configured in onClick is no action (#7523) 2021-09-22 12:58:35 +05:30
Pranav Kanade
c0f5ab3f30
fix: back btn navigation problems (#7692)
* the package name is not necessary when routing to saas action editor.

* This makes back btn truly perform go back operation.
2021-09-22 12:54:05 +05:30
ashit-rath
4144b8786c
fix: Enable dragging of widgets only when focused on (#7494)
* fix: Enable dragging of widgets only when focused on

* added test cases
2021-09-22 12:48:46 +05:30
akash-codemonk
997eb0b65b
fix: Do not show empty array as an error for tableData field (#7332) 2021-09-22 12:36:26 +05:30
Vinod
f3b281092b
fix: copy icon in evaluated popup and dot notation jshint error (#7639)
* Remove bracket highlight on error

* remove dot notation rule and change copy icon

* fix #7582
2021-09-22 07:05:02 +00:00
Nidhi
c3f4cdaa15
feat: Introducing SaaS integrations as a plugin (#7560)
* WIP client side changes

* Saas execution flow + scheduled import of remote plugins
2021-09-21 17:35:29 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
Apeksha Bhosale
386e788e28
fix: pushing and removing errors from debugger for js object (#7465)
* pushing and removing errors from debugger for js object

* added message part of messages

* changes for linting and errors showing

* added try catch for executing function

* PR comments fixed

* PR comment fixed
2021-09-21 11:32:45 +05:30
Apeksha Bhosale
ffe00cd1a2
fix: widget refactor actions fetch change (#7574)
* widget refactor actions fetch change

* Added test for binding Button with API

Co-authored-by: Apple <nandan@thinkify.io>
2021-09-21 11:32:30 +05:30
Tolulope Adetula
834507866a
fix: tabindex and a11y (#7125)
* fix: Datepicker Keypress and Focus State

* fix: Dropdown Select Focus and Tabbale
2021-09-21 06:49:13 +01:00
Satish Gandham
1423b55f55
Add array and object_array to list widget validation check (#7572)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-21 10:40:16 +05:30
Shrikant Sharat Kandula
c6c5e4fef3
ci: Add CI workflow for building fat container (#7385)
This commit changes the client test workflow into building the fat container's image, and so builds server and RTS as well, in order to achieve that.
2021-09-21 08:33:22 +05:30
rahulramesha
0b37812b56
feat: resizable modal (#7312)
* dip

* resizable modal full working commit

* resizable modal minor fixes

* code restructuring

* fix canvas small size bugs and add migration to remove modal type

* moving resize modal to modal sagas

* layoutResize and last column width

* fix warning

* setResizible if resizing

* fix incorrect import

* fixing cypress tests

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-09-20 22:36:13 +05:30
Nikhil Nandagopal
b9b5d54745
fix: Property pane updates (#7631)
* Renamed TreeSelect Widget
2021-09-20 20:48:10 +05:30
Aswath K
1cca96c032
fix: Currency input text overlap (#7477)
* Change currency input layout to flex

* fix: styles for normal input

* Increase space b/w icon and text. Add focus color

visual modifications as suggested by Momcilo

* fix: alignment for ISDCodeDropdown

* fix: background color for disabled

* change dropdown focus color as suggested by Momcilo

* remove unwanted conditional height

* makes disabled Numeric input consistent to disabled input
2021-09-20 14:20:46 +00:00
Hetu Nandu
4315e92cf7
Reset widget children by default (#7505) 2021-09-20 18:40:03 +05:30
akash-codemonk
9877fe4b05
fix: Switch to the debugger error tab when clicked on the debug button in toast (#7455) 2021-09-20 16:50:22 +05:30
Pranav Kanade
a555ed7a88
fixed the pointer for omnibar (#7629) 2021-09-20 16:24:05 +05:30
Nikhil Nandagopal
87b13eca2d
fix: Widget Property Pane Updates (#7467)
* reverted previous revert

* standardised widget sizes

* Text changes

* changed default input label style to match default text style

* more messaging tweaks

* minor fix

* Removed dot from the text

* minor fix for form widget

* fixed tests

* minor fixes
2021-09-20 16:13:44 +05:30
balajisoundar
2dddd07f92
chore: Fix unnecessary scrollbar in entity explorer during onboarding (#7613)
Fixes: #7425
2021-09-20 14:55:37 +05:30